[jira] [Commented] (CB-13854) Camera opens in portrait orientation on iphones
[ https://issues.apache.org/jira/browse/CB-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16436602#comment-16436602 ] ASF subversion and git services commented on CB-13854: -- Commit 7c90555bd4bfbbdfe23f357f130eb1bbb7e4fce6 in cordova-plugin-camera's branch refs/heads/4.0.x from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=7c90555 ] CB-13854(ios): fix Camera opens in portrait orientation on iphones > Camera opens in portrait orientation on iphones > --- > > Key: CB-13854 > URL: https://issues.apache.org/jira/browse/CB-13854 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios, cordova-plugin-camera >Affects Versions: cordova-ios 4.5.0 > Environment: Cordova 7.1.0, Cordova 8.0.0 > iOS 9, 10, 11 > cordova-ios 4.5.x > >Reporter: Damian Ibbotson >Assignee: jcesarmobile >Priority: Major > > Using app in landscape on iphone and open the camera using a plugin > (cordova-plugin-camera). The camera opens in portrait mode. Dialogs to > request permissions are therefore rotated, as is button text. > Replicated with HelloCordova app with addition of cordova-plugin-camera. > Using cordova-plugin-screen-orientation, we can see that an event to change > the orientation to portrait-primary is fired when the camera is opened. > > Does not affect ipads. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13854) Camera opens in portrait orientation on iphones
[ https://issues.apache.org/jira/browse/CB-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360228#comment-16360228 ] ASF subversion and git services commented on CB-13854: -- Commit 7c90555bd4bfbbdfe23f357f130eb1bbb7e4fce6 in cordova-plugin-camera's branch refs/heads/master from [~jcesarmobile] [ https://gitbox.apache.org/repos/asf?p=cordova-plugin-camera.git;h=7c90555 ] CB-13854(ios): fix Camera opens in portrait orientation on iphones > Camera opens in portrait orientation on iphones > --- > > Key: CB-13854 > URL: https://issues.apache.org/jira/browse/CB-13854 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios, cordova-plugin-camera, > cordova-plugin-media-capture >Affects Versions: cordova-ios 4.5.0 > Environment: Cordova 7.1.0, Cordova 8.0.0 > iOS 9, 10, 11 > cordova-ios 4.5.x > >Reporter: Damian Ibbotson >Priority: Major > > Using app in landscape on iphone and open the camera using a plugin > (cordova-plugin-camera, cordova-plugin-media-capture). The camera opens in > portrait mode. Dialogs to request permissions are therefore rotated, as is > button text. > Replicated with HelloCordova app with addition of cordova-plugin-camera. > Using cordova-plugin-screen-orientation, we can see that an event to change > the orientation to portrait-primary is fired when the camera is opened. > > Does not affect ipads. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13854) Camera opens in portrait orientation on iphones
[ https://issues.apache.org/jira/browse/CB-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360229#comment-16360229 ] ASF GitHub Bot commented on CB-13854: - macdonst commented on issue #312: CB-13854(ios): fix Camera opens in portrait orientation on iphones URL: https://github.com/apache/cordova-plugin-camera/pull/312#issuecomment-364817265 Closes CB-13854 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camera opens in portrait orientation on iphones > --- > > Key: CB-13854 > URL: https://issues.apache.org/jira/browse/CB-13854 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios, cordova-plugin-camera, > cordova-plugin-media-capture >Affects Versions: cordova-ios 4.5.0 > Environment: Cordova 7.1.0, Cordova 8.0.0 > iOS 9, 10, 11 > cordova-ios 4.5.x > >Reporter: Damian Ibbotson >Priority: Major > > Using app in landscape on iphone and open the camera using a plugin > (cordova-plugin-camera, cordova-plugin-media-capture). The camera opens in > portrait mode. Dialogs to request permissions are therefore rotated, as is > button text. > Replicated with HelloCordova app with addition of cordova-plugin-camera. > Using cordova-plugin-screen-orientation, we can see that an event to change > the orientation to portrait-primary is fired when the camera is opened. > > Does not affect ipads. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13854) Camera opens in portrait orientation on iphones
[
https://issues.apache.org/jira/browse/CB-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360227#comment-16360227
]
ASF GitHub Bot commented on CB-13854:
-
macdonst closed pull request #312: CB-13854(ios): fix Camera opens in portrait
orientation on iphones
URL: https://github.com/apache/cordova-plugin-camera/pull/312
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/ios/CDVCamera.m b/src/ios/CDVCamera.m
index 37b4ec84..c71de054 100644
--- a/src/ios/CDVCamera.m
+++ b/src/ios/CDVCamera.m
@@ -206,6 +206,7 @@ - (void)takePicture:(CDVInvokedUrlCommand*)command
[weakSelf displayPopover:pictureOptions.popoverOptions];
weakSelf.hasPendingOperation = NO;
} else {
+cameraPicker.modalPresentationStyle =
UIModalPresentationCurrentContext;
[weakSelf.viewController presentViewController:cameraPicker
animated:YES completion:^{
weakSelf.hasPendingOperation = NO;
}];
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Camera opens in portrait orientation on iphones
> ---
>
> Key: CB-13854
> URL: https://issues.apache.org/jira/browse/CB-13854
> Project: Apache Cordova
> Issue Type: Bug
> Components: cordova-ios, cordova-plugin-camera,
> cordova-plugin-media-capture
>Affects Versions: cordova-ios 4.5.0
> Environment: Cordova 7.1.0, Cordova 8.0.0
> iOS 9, 10, 11
> cordova-ios 4.5.x
>
>Reporter: Damian Ibbotson
>Priority: Major
>
> Using app in landscape on iphone and open the camera using a plugin
> (cordova-plugin-camera, cordova-plugin-media-capture). The camera opens in
> portrait mode. Dialogs to request permissions are therefore rotated, as is
> button text.
> Replicated with HelloCordova app with addition of cordova-plugin-camera.
> Using cordova-plugin-screen-orientation, we can see that an event to change
> the orientation to portrait-primary is fired when the camera is opened.
>
> Does not affect ipads.
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org
[jira] [Commented] (CB-13854) Camera opens in portrait orientation on iphones
[ https://issues.apache.org/jira/browse/CB-13854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16359922#comment-16359922 ] ASF GitHub Bot commented on CB-13854: - jcesarmobile opened a new pull request #312: CB-13854(ios): fix Camera opens in portrait orientation on iphones URL: https://github.com/apache/cordova-plugin-camera/pull/312 ### Platforms affected iOS ### What does this PR do? Allow to properly present the camera in landscape ### What testing has been done on this change? Tested on iPhone and iPod touch ### Checklist - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB- is the JIRA ID & "android" is the platform affected. - [ ] Added automated test coverage as appropriate for this change. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Camera opens in portrait orientation on iphones > --- > > Key: CB-13854 > URL: https://issues.apache.org/jira/browse/CB-13854 > Project: Apache Cordova > Issue Type: Bug > Components: cordova-ios, cordova-plugin-camera, > cordova-plugin-media-capture >Affects Versions: cordova-ios 4.5.0 > Environment: Cordova 7.1.0, Cordova 8.0.0 > iOS 9, 10, 11 > cordova-ios 4.5.x > >Reporter: Damian Ibbotson >Priority: Major > > Using app in landscape on iphone and open the camera using a plugin > (cordova-plugin-camera, cordova-plugin-media-capture). The camera opens in > portrait mode. Dialogs to request permissions are therefore rotated, as is > button text. > Replicated with HelloCordova app with addition of cordova-plugin-camera. > Using cordova-plugin-screen-orientation, we can see that an event to change > the orientation to portrait-primary is fired when the camera is opened. > > Does not affect ipads. > > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
