Github user asdf2014 closed the pull request at:
https://github.com/apache/eagle/pull/943
---
Github user asdf2014 closed the pull request at:
https://github.com/apache/eagle/pull/925
---
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/922
@haoch Done
---
Github user asdf2014 closed the pull request at:
https://github.com/apache/eagle/pull/922
---
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/943
@jhsenjaliya Okay, i see :D
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/944#discussion_r120552490
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java
---
@@ -39,6 +39,7
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/943
@qingwen220 Yep, you are right. This will destroy backward compatibility.
But, for people with obsessive compulsive disorder it still be a huge problem.
Moreover, if you do not modify it now, then
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/944#discussion_r120549413
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-common/src/main/java/org/apache/eagle/alert/engine/model/AlertStreamEvent.java
---
@@ -39,6 +39,7
GitHub user asdf2014 opened a pull request:
https://github.com/apache/eagle/pull/943
[MINOR] Fxi sprk issues in JPM module
Fxi sprk issues in JPM module
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/asdf2014/eagle spark_jpm
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/941#discussion_r119341799
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/email/EagleMailClient.java
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/925
@jhsenjaliya You are welcome. Sorry, i just note it. Letâs finish this
after `v0.5.0` together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/925#discussion_r114278551
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEagleStorePlugin.java
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/925#discussion_r114255903
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEagleStorePlugin.java
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/925#discussion_r114254748
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertPublisherImpl.java
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/925
@jhsenjaliya Okay, i see. Thx for your `code review`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/925#discussion_r114254151
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert/alert-engine/src/main/java/org/apache/eagle/alert/engine/publisher/impl/AlertEagleStorePlugin.java
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/925#discussion_r114253745
--- Diff:
eagle-core/eagle-alert-parent/eagle-alert-service/src/main/java/org/apache/eagle/service/alert/resolver/AttributeResolverFactory.java
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/925
If these improvements are necessary, we should step by step merge to avoid
too much code conflict. So, creating multiple sub `PRs` for `EAGLE-1012` will
be more suitable for this situation. What do
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/926#discussion_r112595490
--- Diff:
eagle-jpm/eagle-jpm-mr-history/src/test/resources/job_1479206441898_508949_conf.xml
---
@@ -1,18 +1,164 @@
-
--- End diff
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/926#discussion_r112591726
--- Diff:
eagle-jpm/eagle-jpm-mr-history/src/test/resources/job_1479206441898_508949_conf.xml
---
@@ -1,18 +1,164 @@
-
--- End diff --
Why
GitHub user asdf2014 opened a pull request:
https://github.com/apache/eagle/pull/925
[EAGLE-1012] Some language level problems
Some language level problems
* Spell
* Duplicated
* Lambda
* Collection
* String
* instanceof
* Complex Method
* Exception
GitHub user asdf2014 opened a pull request:
https://github.com/apache/eagle/pull/922
[MINOR] Fix some project construction problems about `test sources`
Fix some project construction problems about `test sources`
* "src/test/org.apache.eagle.xxx" -> &
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/920
@qingwen220 Hi, qingwen220. You are right. This situation will not lose any
exception because all exception from `try` statement will be catched in `catch`
block and it just print the exception
GitHub user asdf2014 opened a pull request:
https://github.com/apache/eagle/pull/920
[EAGLE-1009] Fix losing exception issues
`return` inside `finally` block will result in losing exception:
* If the finally block completes abruptly for reason S, then the try
statement
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/905
@jhsenjaliya Okey, i got it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/905
@jhsenjaliya Already done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asdf2014 closed the pull request at:
https://github.com/apache/eagle/pull/896
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/896
@jhsenjaliya Okey.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/897
Those changes about `.travis.yml` file shouldn't effect `Jenkins`. It seems
like the `maven-surefire-plugin` throw a `ExecutionException` to make this
build process failed.
```bash
[
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/897
@jhsenjaliya Already done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/897#discussion_r111721566
--- Diff:
eagle-core/eagle-query/eagle-entity-base/src/main/java/org/apache/eagle/log/base/taggedlog/RowkeyAPIEntity.java
---
@@ -16,66 +16,79
Github user asdf2014 commented on the issue:
https://github.com/apache/eagle/pull/905
@jhsenjaliya Hi, jhsenjaliya. I am glad to fix the problem in PR, but i got
the `404` page in Jinkens when i visit the
[url](https://builds.apache.org/job/incubator-eagle-pr-reviewer/1773
GitHub user asdf2014 opened a pull request:
https://github.com/apache/eagle/pull/905
HBase Naming that unify `Hbase` and `HBase` into `HBase`
HBase Naming that unify `Hbase` and `HBase` into `HBase`
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user asdf2014 opened a pull request:
https://github.com/apache/eagle/pull/897
[EAGLE-982] The log length has exceeded the limit of 4 MB in Travis
Maven throw too many warnings for checking `Code Style` in `Travis`. Should
we disable it for a while until we fix those `Code
GitHub user asdf2014 opened a pull request:
https://github.com/apache/eagle/pull/896
[EAGLE-981] GC overhead limit exceeded
Travis throw `GC overhead limit exceeded` exception because the default
`JVM` option of maven limit the resource of Travis.
