Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/549#issuecomment-88376612
Looks very good, I will do some additional checks and merge it :+1:
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390203#comment-14390203
]
ASF GitHub Bot commented on FLINK-1792:
---
Github user rmetzger commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390216#comment-14390216
]
ASF GitHub Bot commented on FLINK-1797:
---
Github user asfgit closed the pull request
[
https://issues.apache.org/jira/browse/FLINK-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gyula Fora resolved FLINK-1797.
---
Resolution: Implemented
Add jumping pre-reducer for Count and Time windows
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/553#discussion_r27551487
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -129,6 +129,10 @@ class TaskManager(val connectionInfo:
[
https://issues.apache.org/jira/browse/FLINK-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gyula Fora resolved FLINK-1662.
---
Resolution: Fixed
1a3ae03baff7cc3a406e2e63e7d57b3f7c71ea26
NullFieldException is thrown when
[
https://issues.apache.org/jira/browse/FLINK-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390127#comment-14390127
]
ASF GitHub Bot commented on FLINK-1797:
---
Github user gyfora commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-88387132
Thank you for the contribution. I'll have a look at the changes.
The integration test of your change
(https://travis-ci.org/apache/flink/builds/56641563) has
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/549
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann reassigned FLINK-1809:
Assignee: (was: Till Rohrmann)
Add standard scaler to ML library
[
https://issues.apache.org/jira/browse/FLINK-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann reassigned FLINK-1809:
Assignee: Till Rohrmann
Add standard scaler to ML library
[
https://issues.apache.org/jira/browse/FLINK-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390282#comment-14390282
]
ASF GitHub Bot commented on FLINK-1718:
---
Github user tillrohrmann commented on the
[
https://issues.apache.org/jira/browse/FLINK-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390325#comment-14390325
]
Maximilian Michels commented on FLINK-1387:
---
As of recent changes, the starting
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390245#comment-14390245
]
Till Rohrmann commented on FLINK-1807:
--
I agree with you. Such a distinction gives a
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/543#issuecomment-88414519
I rebased the PR on the current master which contains #539. If all tests
pass on Travis and there are no objections, then I would like to merge the PR.
---
If your
Github user gyfora closed the pull request at:
https://github.com/apache/flink/pull/554
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Maximilian Michels resolved FLINK-1043.
---
Resolution: Fixed
This is now possible via GroupCombine followed by a GroupReduce.
[
https://issues.apache.org/jira/browse/FLINK-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390266#comment-14390266
]
ASF GitHub Bot commented on FLINK-1718:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/539
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/553#issuecomment-88418659
The memory statistics get pretty big when the chart is enabled as well.
Can you hide the string-based statistics when the graph is activated?
[
https://issues.apache.org/jira/browse/FLINK-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390298#comment-14390298
]
ASF GitHub Bot commented on FLINK-1792:
---
Github user rmetzger commented on the pull
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/555
[FLINK-1800][docs] Add beta badge to components in flink-staging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink1800
[
https://issues.apache.org/jira/browse/FLINK-1809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-1809:
-
Assignee: Faye Beligianni
Add standard scaler to ML library
-
[
https://issues.apache.org/jira/browse/FLINK-1718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-1718.
--
Resolution: Fixed
Added with d2e2d79fc0052c064188940520c93bbd0c1b1d4b
Add sparse vector and
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/539#issuecomment-88414948
FYI: Travis failed only for the last profile because the tests didn't start
for some reason. Travis passed for my own repository, though.
---
If your project is set
[
https://issues.apache.org/jira/browse/FLINK-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390278#comment-14390278
]
ASF GitHub Bot commented on FLINK-1717:
---
Github user tillrohrmann commented on the
GitHub user gyfora opened a pull request:
https://github.com/apache/flink/pull/554
Added type hints for streaming operators
The only difference between this and the batch approach is that we allow
the change of type as well. I don't think this could break functionality but we
use
[
https://issues.apache.org/jira/browse/FLINK-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger reassigned FLINK-1800:
-
Assignee: Robert Metzger
Add a Beta badge in the documentation to components in
[
https://issues.apache.org/jira/browse/FLINK-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger updated FLINK-1800:
--
Component/s: Documentation
Add a Beta badge in the documentation to components in
[
https://issues.apache.org/jira/browse/FLINK-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390340#comment-14390340
]
ASF GitHub Bot commented on FLINK-1800:
---
GitHub user rmetzger opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390351#comment-14390351
]
Maximilian Michels commented on FLINK-509:
--
I suppose this can be replaced by
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390468#comment-14390468
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-88453493
If there are no objections, I'm going to merge the PR in the next 24 hours.
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-1807:
-
Assignee: Theodore Vasiloudis
Stochastic gradient descent optimizer for ML library
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27564491
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -103,6 +110,9 @@ public void start() throws Exception {
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27564493
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -70,6 +72,11 @@ public LocalExecutor() {
}
}
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390481#comment-14390481
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390485#comment-14390485
]
Gyula Fora commented on FLINK-1670:
---
I would probably implement this as a combination of
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390491#comment-14390491
]
Theodore Vasiloudis commented on FLINK-1807:
Do you mean link from this JIRA
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390493#comment-14390493
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user uce commented on a diff in the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27566199
--- Diff:
flink-clients/src/main/java/org/apache/flink/client/LocalExecutor.java ---
@@ -103,6 +110,9 @@ public void start() throws Exception {
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27564611
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/LocalEnvironment.java ---
@@ -32,6 +33,7 @@
* machine.
*/
public class
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390482#comment-14390482
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user mxm commented on a diff in the
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27566259
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -1058,6 +1059,20 @@ public static LocalEnvironment
[
https://issues.apache.org/jira/browse/FLINK-1792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390195#comment-14390195
]
ASF GitHub Bot commented on FLINK-1792:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390474#comment-14390474
]
Gyula Fora commented on FLINK-1239:
---
Is there any update on this issue? Should we close
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390487#comment-14390487
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user StephanEwen commented on the
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-88462555
Looks good.
It is possible to add a more Unit-Test style test, rather than an
Integration test case (starting a full mini cluster) ?
---
If your project is
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390486#comment-14390486
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user StephanEwen commented on a diff
Ufuk Celebi created FLINK-1810:
--
Summary: UpdateTask message contains unused information
Key: FLINK-1810
URL: https://issues.apache.org/jira/browse/FLINK-1810
Project: Flink
Issue Type:
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390495#comment-14390495
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user uce commented on a diff in the
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/555#issuecomment-88449216
The changes are good.
I very much like the text on the bottom of the left navigation.
A matter of taste: I like the blue badge, but it really draws the visual
[
https://issues.apache.org/jira/browse/FLINK-1728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-1728:
-
Assignee: Mikio Braun
Add random forest ensemble method to machine learning library
[
https://issues.apache.org/jira/browse/FLINK-1727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-1727:
-
Assignee: Mikio Braun
Add decision tree to machine learning library
GitHub user gyfora opened a pull request:
https://github.com/apache/flink/pull/556
[FLINK-1803] [streaming] returns(..) method added to Stream operators
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mbalassi/flink FLINK-1803
[
https://issues.apache.org/jira/browse/FLINK-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390413#comment-14390413
]
ASF GitHub Bot commented on FLINK-1803:
---
GitHub user gyfora opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390459#comment-14390459
]
Theodore Vasiloudis commented on FLINK-1807:
Can I get this assigned to me? My
[
https://issues.apache.org/jira/browse/FLINK-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390458#comment-14390458
]
ASF GitHub Bot commented on FLINK-1800:
---
Github user uce commented on the pull
Robert Metzger created FLINK-1811:
-
Summary: Allow users to pass custom buffer sizes and timeouts to
PersistentKafkaSource
Key: FLINK-1811
URL: https://issues.apache.org/jira/browse/FLINK-1811
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390506#comment-14390506
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user uce commented on the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/558#discussion_r27567913
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390548#comment-14390548
]
ASF GitHub Bot commented on FLINK-1753:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390532#comment-14390532
]
ASF GitHub Bot commented on FLINK-1811:
---
Github user rmetzger commented on a diff in
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/558#discussion_r27568089
--- Diff:
flink-staging/flink-streaming/flink-streaming-connectors/src/main/java/org/apache/flink/streaming/connectors/kafka/api/simple/PersistentKafkaSource.java
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/558#issuecomment-88481744
LGTM but
```
[INFO] There are 2 checkstyle errors.
[ERROR] KafkaMultiplePartitionsIterator.java[37:n/a] Line has leading space
characters; indentation should
[
https://issues.apache.org/jira/browse/FLINK-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390546#comment-14390546
]
ASF GitHub Bot commented on FLINK-1811:
---
Github user uce commented on the pull
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/427#discussion_r27569381
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/ExecutionEnvironment.java ---
@@ -1058,6 +1059,20 @@ public static LocalEnvironment
[
https://issues.apache.org/jira/browse/FLINK-1239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390564#comment-14390564
]
Gábor Hermann commented on FLINK-1239:
--
The IterationExample runs and terminates. The
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390556#comment-14390556
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user mxm commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390503#comment-14390503
]
ASF GitHub Bot commented on FLINK-1753:
---
GitHub user gaborhermann opened a pull
GitHub user gaborhermann opened a pull request:
https://github.com/apache/flink/pull/557
[FLINK-1753] [streaming] Added test for Kafka connector with tuple type
Extended the KafkaITCase with a topology of a non-String type and fixed a
small bug with Kafka key serializer.
You can
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/427#issuecomment-88473959
Looks good.
- Can you add missing `@Override` tags to `executePlan` and
`getOptimizerPlanAsJSON` while editing the file?
- If you only want to ensure that the
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/558
[FLINK-1811] Allow passing custom buffer sizes and timeouts to Persisten...
...tKafkaSource
You can merge this pull request into a Git repository by running:
$ git pull
[
https://issues.apache.org/jira/browse/FLINK-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390518#comment-14390518
]
ASF GitHub Bot commented on FLINK-1811:
---
GitHub user rmetzger opened a pull request:
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/552#issuecomment-88477937
LGTM. Robert also gave his OK in the old PR.
@hsaputra: Can you squash both commits and add a tag like [tools] before
merging?
---
If your project is set up for it,
[
https://issues.apache.org/jira/browse/FLINK-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390534#comment-14390534
]
ASF GitHub Bot commented on FLINK-1811:
---
Github user uce commented on a diff in the
[
https://issues.apache.org/jira/browse/FLINK-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390550#comment-14390550
]
ASF GitHub Bot commented on FLINK-1811:
---
Github user rmetzger commented on the pull
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/558#issuecomment-88482551
Thanks for the review @uce. I'll update the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/558#issuecomment-88493994
I'updated the PR. Once Travis is green, I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/552#issuecomment-88499833
Thanks @uce and @rmetzger. Will squash both commits and add tag before
commit.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/543#issuecomment-88505717
Go ahead, the changes look good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/FLINK-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390612#comment-14390612
]
ASF GitHub Bot commented on FLINK-1717:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390800#comment-14390800
]
Alexander Alexandrov edited comment on FLINK-1789 at 4/1/15 3:29 PM:
[
https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390804#comment-14390804
]
ASF GitHub Bot commented on FLINK-1753:
---
Github user gaborhermann commented on the
[
https://issues.apache.org/jira/browse/FLINK-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann resolved FLINK-1717.
--
Resolution: Fixed
Added with 015af177d1b54ea7bdf860a3a48e5a8f022d8304
Add support to read
[
https://issues.apache.org/jira/browse/FLINK-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390776#comment-14390776
]
ASF GitHub Bot commented on FLINK-1717:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/543
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/545#issuecomment-88522329
I rebased the PR on the current master. When Travis gives green light and
if there are no objections, I'll merge this PR.
---
If your project is set up for it, you
GitHub user aalexandrov opened a pull request:
https://github.com/apache/flink/pull/559
Fixup ReusingKeyGroupedIterator value iterators in
NonReusingSortMergeCoGroupIterator.
Correct me if I'm wrong, but I think that the
NonReusingSortMergeCoGroupIterator should construct value
[
https://issues.apache.org/jira/browse/FLINK-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390838#comment-14390838
]
Till Rohrmann commented on FLINK-1807:
--
From the umbrella JIRA.
On Wed, Apr 1, 2015
[
https://issues.apache.org/jira/browse/FLINK-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390680#comment-14390680
]
Till Rohrmann commented on FLINK-687:
-
+1 for this feature.
Add support for
Github user gaborhermann commented on the pull request:
https://github.com/apache/flink/pull/557#issuecomment-88523220
Thanks for the remark. I updated the branch and added more tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/557#issuecomment-88527923
The code looks good. Tests are running locally.
As soon as travis signals green, I'm +1 to merge.
---
If your project is set up for it, you can reply to this email
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/473#issuecomment-88540354
I reworked the PR. It is now ready for review again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
[
https://issues.apache.org/jira/browse/FLINK-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390915#comment-14390915
]
ASF GitHub Bot commented on FLINK-1676:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390839#comment-14390839
]
ASF GitHub Bot commented on FLINK-1753:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390938#comment-14390938
]
ASF GitHub Bot commented on FLINK-1589:
---
Github user rmetzger commented on the pull
[
https://issues.apache.org/jira/browse/FLINK-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Metzger resolved FLINK-1811.
---
Resolution: Fixed
Fix Version/s: 0.9
Resolved in
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/558
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-1811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390972#comment-14390972
]
ASF GitHub Bot commented on FLINK-1811:
---
Github user asfgit closed the pull request
1 - 100 of 109 matches
Mail list logo
