Stephan Ewen created FLINK-3379:
---
Summary: Refactor TimestampExtractor
Key: FLINK-3379
URL: https://issues.apache.org/jira/browse/FLINK-3379
Project: Flink
Issue Type: Improvement
Com
[
https://issues.apache.org/jira/browse/FLINK-3109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139097#comment-15139097
]
ASF GitHub Bot commented on FLINK-3109:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1527#issuecomment-181922703
@wangyangjun We actually merged all the changes concerning the state
abstraction.
To make this window join work seamlessly on Flink's state backends (memory,
[
https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139082#comment-15139082
]
ASF GitHub Bot commented on FLINK-3271:
---
Github user StephanEwen commented on a diff
[
https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139089#comment-15139089
]
ASF GitHub Bot commented on FLINK-3271:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1543#issuecomment-181920795
I think we can merge this, with the changes suggested in the inline
comments...
---
If your project is set up for it, you can reply to this email and have your
rep
[
https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139086#comment-15139086
]
ASF GitHub Bot commented on FLINK-3271:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1543#discussion_r52325053
--- Diff: flink-shaded-hadoop/flink-shaded-hadoop1/pom.xml ---
@@ -68,10 +68,10 @@ under the License.
org.mortbay.j
[
https://issues.apache.org/jira/browse/FLINK-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139071#comment-15139071
]
ASF GitHub Bot commented on FLINK-3366:
---
Github user fhueske commented on the pull r
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-181917384
Thanks a lot @StephanEwen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
[
https://issues.apache.org/jira/browse/FLINK-3271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139085#comment-15139085
]
ASF GitHub Bot commented on FLINK-3271:
---
Github user StephanEwen commented on a diff
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1543#discussion_r52324939
--- Diff: flink-shaded-hadoop/flink-shaded-hadoop2/pom.xml ---
@@ -184,10 +184,10 @@ under the License.
org.mortbay
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/1543#discussion_r52324384
--- Diff: flink-shaded-hadoop/pom.xml ---
@@ -111,6 +111,7 @@ under the License.
i
[
https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139073#comment-15139073
]
ASF GitHub Bot commented on FLINK-3234:
---
Github user fhueske commented on the pull r
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-181917425
Will merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1599#issuecomment-181917327
Will merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139052#comment-15139052
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user vasia commented on a diff in th
Github user vasia commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52320399
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AvgAggregate.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Lice
[
https://issues.apache.org/jira/browse/FLINK-3107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139047#comment-15139047
]
ASF GitHub Bot commented on FLINK-3107:
---
GitHub user uce opened a pull request:
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1610
[FLINK-3107] [runtime] Start checkpoint ID counter with periodic scheduler
Problem: The job manager enables checkpoints during submission of streaming
programs. This can lead to call to a call to
`ZooK
Maximilian Michels created FLINK-3378:
-
Summary: Consolidate TestingCluster and FokableFlinkMiniCluster
Key: FLINK-3378
URL: https://issues.apache.org/jira/browse/FLINK-3378
Project: Flink
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-181908838
Looks good at a first glance. I'll try to go through it and see if I can
merge it...
---
If your project is set up for it, you can reply to this email and have your
Github user ggevay commented on the pull request:
https://github.com/apache/flink/pull/1517#issuecomment-181907722
What I'm not sure about is the `closeUserCode` call in
`ChainedReduceCombineDriver.closeTask`. Those other chained drivers that have a
`running` flag for indicating cance
[
https://issues.apache.org/jira/browse/FLINK-2237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139041#comment-15139041
]
ASF GitHub Bot commented on FLINK-2237:
---
Github user ggevay commented on the pull re
[
https://issues.apache.org/jira/browse/FLINK-2055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139040#comment-15139040
]
Chesnay Schepler commented on FLINK-2055:
-
What's the status on this one?
> Imple
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139025#comment-15139025
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user twalthr commented on the pull r
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-181902296
I have added comments and fixed the string bug. I will solve the other
issues at the end of the week.
If you have no objections, you can merge the PR ;-)
---
If you
[
https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139018#comment-15139018
]
Gabor Gevay commented on FLINK-:
I have raised the priority to Blocker, because it
[
https://issues.apache.org/jira/browse/FLINK-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139016#comment-15139016
]
ASF GitHub Bot commented on FLINK-3377:
---
GitHub user zentol opened a pull request:
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1609
[FLINK-3377] Remove final flag from ResultPartitionWriter class
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3377_partitionwriter
[
https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gabor Gevay updated FLINK-:
---
Priority: Blocker (was: Critical)
> Documentation about object reuse should be improved
> ---
[
https://issues.apache.org/jira/browse/FLINK-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chesnay Schepler updated FLINK-3377:
Summary: Remove final flag from ResultPartitionWriter class (was: Remove
final flag from Re
Chesnay Schepler created FLINK-3377:
---
Summary: Remove final flag from ResultPatitionWriter class
Key: FLINK-3377
URL: https://issues.apache.org/jira/browse/FLINK-3377
Project: Flink
Issue T
[
https://issues.apache.org/jira/browse/FLINK-3375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139005#comment-15139005
]
Shikhar Bhushan commented on FLINK-3375:
This would be super useful for me, as I c
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138937#comment-15138937
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138936#comment-15138936
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52306203
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MinAggregate.scala
---
@@ -0,0 +1,86 @@
+/*
+ * Lic
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52306088
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/AvgAggregate.scala
---
@@ -0,0 +1,145 @@
+/*
+ * Li
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138934#comment-15138934
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52306136
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MaxAggregate.scala
---
@@ -0,0 +1,84 @@
+/*
+ * Lic
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138931#comment-15138931
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52305988
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/runtime/aggregate/MinAggregate.scala
---
@@ -0,0 +1,86 @@
+/*
+ * Lic
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138922#comment-15138922
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52305236
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetJoinRule.scala
---
@@ -39,6 +46,10 @@ class DataSet
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138916#comment-15138916
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52304994
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataset/DataSetAggregateRule.scala
---
@@ -37,14 +39,24 @@ class D
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138913#comment-15138913
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1600#discussion_r52304432
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/nodes/logical/FlinkAggregate.scala
---
@@ -58,19 +58,23 @@ class FlinkAg
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138904#comment-15138904
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52303126
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to
Github user twalthr commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-181848000
Thanks for reviewing @fhueske.
I will comment my code more.
Regarding the splitting of the `CodeGenerator`, I think it is not that easy
because function
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138885#comment-15138885
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user twalthr commented on the pull r
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52301780
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138881#comment-15138881
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user twalthr commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138880#comment-15138880
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52301613
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138876#comment-15138876
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user twalthr commented on a diff in
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52301458
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138870#comment-15138870
]
ASF GitHub Bot commented on FLINK-3234:
---
Github user fhueske commented on the pull r
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-181845299
Thanks for the fast update!
Good to merge :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user chiwanpark commented on the pull request:
https://github.com/apache/flink/pull/1585#issuecomment-181833677
Thanks for review @fhueske. I have addressed your comments. :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138832#comment-15138832
]
ASF GitHub Bot commented on FLINK-3234:
---
Github user chiwanpark commented on the pul
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1599#issuecomment-181829201
Thanks for catching that @StephanEwen.
JavaDocs are updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
[
https://issues.apache.org/jira/browse/FLINK-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138814#comment-15138814
]
ASF GitHub Bot commented on FLINK-3366:
---
Github user fhueske commented on the pull r
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138805#comment-15138805
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on the pull r
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1595#issuecomment-181824403
Hi Timo, the PR looks really good :-)
I found the following issues / questions:
- Accessing of POJO fields might not work.
- Can you add method comments t
[
https://issues.apache.org/jira/browse/FLINK-3286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138794#comment-15138794
]
Robert Metzger commented on FLINK-3286:
---
Removed the files as well:
http://git-wip-
[
https://issues.apache.org/jira/browse/FLINK-3373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138787#comment-15138787
]
Stephan Ewen commented on FLINK-3373:
-
Would it help if Flink simply updated the HTTP
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138788#comment-15138788
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52293343
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenUtils.scala
---
@@ -0,0 +1,176 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138781#comment-15138781
]
Stephan Ewen commented on FLINK-3376:
-
Some of that information is available, but hidd
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138784#comment-15138784
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52293004
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen updated FLINK-3376:
Summary: Add an illustration of Event Time and Watermarks to the docs
(was: Add an illustration of
Stephan Ewen created FLINK-3376:
---
Summary: Add an illustration of Event Time and Watermarks to the
docsq
Key: FLINK-3376
URL: https://issues.apache.org/jira/browse/FLINK-3376
Project: Flink
Is
[
https://issues.apache.org/jira/browse/FLINK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138777#comment-15138777
]
ASF GitHub Bot commented on FLINK-3371:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1603#issuecomment-181813971
Exactly, the `AlignedTrigger` will have an `AlignedTriggerContext` without
Key/Value state.
---
If your project is set up for it, you can reply to this email and ha
[
https://issues.apache.org/jira/browse/FLINK-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138775#comment-15138775
]
ASF GitHub Bot commented on FLINK-3355:
---
Github user asfgit closed the pull request
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enab
Stephan Ewen created FLINK-3375:
---
Summary: Allow Watermark Generation in the Kafka Source
Key: FLINK-3375
URL: https://issues.apache.org/jira/browse/FLINK-3375
Project: Flink
Issue Type: Improv
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1513#issuecomment-181810307
I rebased it to master and updated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
[
https://issues.apache.org/jira/browse/FLINK-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138768#comment-15138768
]
ASF GitHub Bot commented on FLINK-3243:
---
Github user aljoscha commented on the pull
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1595#discussion_r52291201
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/codegen/CodeGenerator.scala
---
@@ -0,0 +1,661 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138764#comment-15138764
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user fhueske commented on a diff in
[
https://issues.apache.org/jira/browse/FLINK-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138755#comment-15138755
]
ASF GitHub Bot commented on FLINK-3355:
---
Github user aljoscha commented on the pull
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1603#issuecomment-181807335
You are not moving `TriggerContext` because it is specific to Trigger,
correct?
Otherwise it looks good to merge. :+1:
---
If your project is set up for it,
[
https://issues.apache.org/jira/browse/FLINK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138754#comment-15138754
]
ASF GitHub Bot commented on FLINK-3371:
---
Github user aljoscha commented on the pull
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1608#issuecomment-181807481
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
[
https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138751#comment-15138751
]
ASF GitHub Bot commented on FLINK-1966:
---
Github user sachingoel0101 commented on the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1186#issuecomment-181803637
I'm all for that. Flink's models should be transferable at least across
flink. But that should be part of a separate PR, and not block this one as it
has been for
[
https://issues.apache.org/jira/browse/FLINK-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138734#comment-15138734
]
ASF GitHub Bot commented on FLINK-3355:
---
Github user gyfora commented on the pull re
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1608#issuecomment-181800676
Looks good :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featur
[
https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138728#comment-15138728
]
ASF GitHub Bot commented on FLINK-1966:
---
Github user chobeat commented on the pull r
Github user chobeat commented on the pull request:
https://github.com/apache/flink/pull/1186#issuecomment-181799783
@sachingoel0101 I agree. Nonetheless, an easy way to store and move a model
generated in batch to a streaming enviroment would be a really useful feature
and we go back
[
https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138722#comment-15138722
]
ASF GitHub Bot commented on FLINK-1966:
---
Github user sachingoel0101 commented on the
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/1186#issuecomment-181798643
That is a good point. In streaming setting, it does indeed make sense for
the model to be available. However, in my opinion, then it would make sense to
actually
[
https://issues.apache.org/jira/browse/FLINK-3226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138705#comment-15138705
]
ASF GitHub Bot commented on FLINK-3226:
---
Github user vasia commented on the pull req
Github user vasia commented on the pull request:
https://github.com/apache/flink/pull/1600#issuecomment-181794348
Thanks for the feedback @tillrohrmann, @twalthr!
I've moved the classes to `org.apache.flink.api.table.runtime` and tried to
shorten the aggregates code using Numerics.
[
https://issues.apache.org/jira/browse/FLINK-3366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138701#comment-15138701
]
ASF GitHub Bot commented on FLINK-3366:
---
Github user StephanEwen commented on the pu
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1599#issuecomment-181794025
Can you update the JavaDoc of the `@PublicEvolving` annotation?
Otherwise, good to merge...
---
If your project is set up for it, you can reply to this emai
101 - 200 of 240 matches
Mail list logo
