[jira] [Commented] (FLINK-2832) Failing test: RandomSamplerTest.testReservoirSamplerWithReplacement

2016-02-09 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138691#comment-15138691 ] Robert Metzger commented on FLINK-2832: --- Another instance: https://s3.amazonaws.com

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138686#comment-15138686 ] ASF GitHub Bot commented on FLINK-1966: --- Github user chobeat commented on the pull r

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181790876 I agree with @sachingoel0101 on the import complexity but, from our point of view, Flink is the perfect platform to evaluate models in streaming and we are using it that

[jira] [Commented] (FLINK-3066) Kafka producer fails on leader change

2016-02-09 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138677#comment-15138677 ] Gyula Fora commented on FLINK-3066: --- Thank you Robert for the help, it is a good catch :

[jira] [Commented] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138626#comment-15138626 ] Till Rohrmann commented on FLINK-3374: -- Probably because it uses {{WriteMode.OVERWRIT

[jira] [Assigned] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-3374: Assignee: Till Rohrmann > CEPITCase testSimplePatternEventTime fails >

[jira] [Commented] (FLINK-3243) Fix Interplay of TimeCharacteristic and Time Windows

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138616#comment-15138616 ] ASF GitHub Bot commented on FLINK-3243: --- Github user aljoscha commented on the pull

[jira] [Commented] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138617#comment-15138617 ] Till Rohrmann commented on FLINK-3374: -- Hmm I just saw that the CEPITCase creates a f

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-09 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/pull/1513#issuecomment-181777122 You're right, I'm changing it. But it was also me who didn't notice when we put it in initially :sweat_smile: --- If your project is set up for it, you can reply to t

[jira] [Commented] (FLINK-3243) Fix Interplay of TimeCharacteristic and Time Windows

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138610#comment-15138610 ] ASF GitHub Bot commented on FLINK-3243: --- Github user StephanEwen commented on the pu

[GitHub] flink pull request: [FLINK-3243] Fix Interplay of TimeCharacterist...

2016-02-09 Thread StephanEwen
Github user StephanEwen commented on the pull request: https://github.com/apache/flink/pull/1513#issuecomment-181776065 For new classes, it makes sense. Was a mistake on my end to name them like this in the first place. But users that adopted this draw in my experience more sa

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282118 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java --- @@ -36,27 +40,58 @@ */ public class SortPart

[jira] [Commented] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138600#comment-15138600 ] Stephan Ewen commented on FLINK-3374: - My guess is that the parent path does not exist

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138598#comment-15138598 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on the pull r

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on the pull request: https://github.com/apache/flink/pull/1585#issuecomment-181773503 The refactoring looks good, @chiwanpark. I have just a few minor remarks. The PR can be resolved after these have been addressed. --- If your project is set up for

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138594#comment-15138594 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138595#comment-15138595 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in

[jira] [Assigned] (FLINK-3359) Make RocksDB file copies asynchronous

2016-02-09 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-3359: --- Assignee: Aljoscha Krettek > Make RocksDB file copies asynchronous >

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282391 --- Diff: flink-tests/src/test/scala/org/apache/flink/api/scala/operators/SortPartitionITCase.scala --- @@ -166,6 +167,58 @@ class SortPartitionITCase(mode:

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138591#comment-15138591 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181772422 That said, just for a comparison purpose, spark has its own model export and import feature, along with pmml export. Hoping to fully support pmml import in a fram

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138593#comment-15138593 ] ASF GitHub Bot commented on FLINK-1966: --- Github user sachingoel0101 commented on the

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282336 --- Diff: flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/SortPartitionITCase.java --- @@ -197,6 +198,58 @@ public void testSortPartitionPar

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282275 --- Diff: flink-scala/src/main/scala/org/apache/flink/api/scala/DataSet.scala --- @@ -1508,6 +1508,31 @@ class DataSet[T: ClassTag](set: JavaDataSet[T]) {

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138589#comment-15138589 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52282174 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/operators/SortPartitionOperator.java --- @@ -79,58 +119,41 @@ public SortPartitionOperator(DataS

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138577#comment-15138577 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138576#comment-15138576 ] ASF GitHub Bot commented on FLINK-1966: --- Github user sachingoel0101 commented on the

[jira] [Commented] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138575#comment-15138575 ] Till Rohrmann commented on FLINK-3374: -- Is this reproducible? Looks to me as if the t

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread sachingoel0101
Github user sachingoel0101 commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181771679 As the original author of this PR, I'd say this: I tried implementing the import features but they aren't worth it. You have to discard most of the valid pmml

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138573#comment-15138573 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52281965 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1377,6 +1377,24 @@ public long count() throws Exception { re

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138571#comment-15138571 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52281750 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1377,6 +1377,24 @@ public long count() throws Exception { re

[GitHub] flink pull request: [FLINK-3234] [dataSet] Add KeySelector support...

2016-02-09 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/1585#discussion_r52281721 --- Diff: flink-java/src/main/java/org/apache/flink/api/java/DataSet.java --- @@ -1377,6 +1377,24 @@ public long count() throws Exception { re

[jira] [Commented] (FLINK-3234) SortPartition does not support KeySelectorFunctions

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138570#comment-15138570 ] ASF GitHub Bot commented on FLINK-3234: --- Github user fhueske commented on a diff in

[jira] [Created] (FLINK-3374) CEPITCase testSimplePatternEventTime fails

2016-02-09 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-3374: -- Summary: CEPITCase testSimplePatternEventTime fails Key: FLINK-3374 URL: https://issues.apache.org/jira/browse/FLINK-3374 Project: Flink Issue Type: Test

[jira] [Created] (FLINK-3373) Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems

2016-02-09 Thread Jakob Sultan Ericsson (JIRA)
Jakob Sultan Ericsson created FLINK-3373: Summary: Using a newer library of Apache HttpClient than 4.2.6 will get class loading problems Key: FLINK-3373 URL: https://issues.apache.org/jira/browse/FLINK-337

[jira] [Commented] (FLINK-1966) Add support for predictive model markup language (PMML)

2016-02-09 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15138528#comment-15138528 ] ASF GitHub Bot commented on FLINK-1966: --- Github user chobeat commented on the pull r

[GitHub] flink pull request: [FLINK-1966][ml]Add support for Predictive Mod...

2016-02-09 Thread chobeat
Github user chobeat commented on the pull request: https://github.com/apache/flink/pull/1186#issuecomment-181757426 Well that wouldn't be a problem for the export: you will create and therefore export only models that have `double` as datatype for parameters but that's not an issue.

<    1   2   3