Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281038
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/examples/WriteCassandraSink.java
---
[
https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151895#comment-15151895
]
ASF GitHub Bot commented on FLINK-3311:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151893#comment-15151893
]
ASF GitHub Bot commented on FLINK-3311:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151896#comment-15151896
]
ASF GitHub Bot commented on FLINK-3311:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53281044
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/examples/WriteBatch.java
---
@@ -0,0
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53280971
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/streaming/ClusterConfigurator.java
---
@@
Github user cellvia commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185576114
bump. is this happening?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
[
https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151852#comment-15151852
]
ASF GitHub Bot commented on FLINK-3311:
---
Github user cellvia commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151346#comment-15151346
]
Dongwon Kim edited comment on FLINK-1502 at 2/18/16 2:30 AM:
-
To
[
https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151460#comment-15151460
]
Dongwon Kim commented on FLINK-1502:
[~jgrier] What you are suggesting is that TaskManagers publish
[
https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151444#comment-15151444
]
Dongwon Kim commented on FLINK-1502:
[~mxm] I just meant to aggregate metrics from multiple
[
https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151415#comment-15151415
]
Dongwon Kim commented on FLINK-1502:
To [~jgrier],
Okay, let's count out such additional calculation
[
https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151346#comment-15151346
]
Dongwon Kim edited comment on FLINK-1502 at 2/17/16 11:02 PM:
--
To
[
https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151346#comment-15151346
]
Dongwon Kim edited comment on FLINK-1502 at 2/17/16 10:57 PM:
--
To
[
https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151346#comment-15151346
]
Dongwon Kim commented on FLINK-1502:
To [~StephanEwen], [~mxm], [~jgrier],
First of all, sorry for
[
https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151338#comment-15151338
]
ASF GitHub Bot commented on FLINK-3311:
---
Github user alkagin commented on a diff in the pull
Github user alkagin commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53244631
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1663#issuecomment-185435610
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
[
https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151302#comment-15151302
]
ASF GitHub Bot commented on FLINK-3311:
---
Github user rmetzger commented on the pull request:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1660#issuecomment-185434970
Thank you for the contribution. I just scrolled over the code once and made
some comments. I think some further (small) changes are needed here and there.
---
If your
[
https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151300#comment-15151300
]
ASF GitHub Bot commented on FLINK-3311:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53241280
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/connectors/cassandra/CassandraConnectorTest.java
---
@@ -0,0
[
https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151299#comment-15151299
]
ASF GitHub Bot commented on FLINK-3311:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53241145
--- Diff:
[
https://issues.apache.org/jira/browse/FLINK-3311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151293#comment-15151293
]
ASF GitHub Bot commented on FLINK-3311:
---
Github user rmetzger commented on a diff in the pull
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1660#discussion_r53240407
--- Diff:
flink-streaming-connectors/flink-connector-cassandra/src/main/java/org/apache/flink/connectors/cassandra/batch/CassandraOutputFormat.java
---
@@
[
https://issues.apache.org/jira/browse/FLINK-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151290#comment-15151290
]
ASF GitHub Bot commented on FLINK-3368:
---
Github user rmetzger commented on the pull request:
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-185430953
Thank you for the review. I'll address them soon!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
[
https://issues.apache.org/jira/browse/FLINK-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151223#comment-15151223
]
Josep Rubió commented on FLINK-1707:
Hi Vasia,
I've been working with the binary variable model of
GitHub user vasia opened a pull request:
https://github.com/apache/flink/pull/1663
[docs] fix typos in quickstart and CEP docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vasia/flink docs_typos
Alternatively you can review
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1659#issuecomment-185374491
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/FLINK-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151048#comment-15151048
]
ASF GitHub Bot commented on FLINK-3436:
---
Github user uce commented on the pull request:
[
https://issues.apache.org/jira/browse/FLINK-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151004#comment-15151004
]
Jamie Grier commented on FLINK-1502:
I understand [~eastcirclek]'s points about using the InstanceID.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1648#issuecomment-185114983
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1658
Improve TaskManagerTest#testRemotePartitionNotFound failure message
I've observed a failure in TaskManagerTest#testRemotePartitionNotFound, but
the exception was essentially swallowed. I've added an
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53153223
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/ReduceProperties.java
---
@@ -59,37 +65,69 @@ public DriverStrategy
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53153386
--- Diff:
flink-tests/src/test/java/org/apache/flink/test/javaApiOperators/GroupReduceITCase.java
---
@@ -434,6 +431,95 @@ public void
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53152587
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53152922
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53152668
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53153193
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/ReduceProperties.java
---
@@ -59,37 +65,69 @@ public DriverStrategy
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1655#issuecomment-185197756
I like this change. Non-POJO types are perfectly fine, people should not be
put off by these warnings.
+1 from my side
---
If your project is set up for
Github user uce closed the pull request at:
https://github.com/apache/flink/pull/1656
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53152430
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1656
[FLINK-3396] [runtime] Fix JobGraph submission and client ACK logic
A failure when recovering savepoint state could lead to not ACKing
the job submission. For detached submissions, this could have
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53152240
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1652
[FLINK-3425] FileOutputFormat closes outStream in case of failure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1640#issuecomment-185087544
resources are properly closed now; removed all mentions of exactly-once;
tests run now that i removed powermock (and the initual cause: a final flag in
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53152054
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -110,28 +135,49 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53152023
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -110,28 +135,49 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53151692
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53152093
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -110,28 +135,49 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53151777
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53151545
--- Diff:
flink-examples/flink-examples-batch/src/main/java/org/apache/flink/examples/java/wordcount/WordCount.java
---
@@ -66,7 +66,7 @@ public static void
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1642
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53151628
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -110,28 +135,49 @@ public
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1553#discussion_r53151578
--- Diff:
flink-optimizer/src/main/java/org/apache/flink/optimizer/operators/GroupReduceWithCombineProperties.java
---
@@ -87,19 +92,39 @@ public
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1649#discussion_r53151610
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java
---
@@ -432,11 +436,11 @@ private void
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185210139
Hello! I just rebased to the new master.
Please review this new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1649#discussion_r53151157
--- Diff:
flink-libraries/flink-python/src/main/java/org/apache/flink/python/api/PythonPlanBinder.java
---
@@ -432,11 +436,11 @@ private void
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1646#issuecomment-185083361
+1 This should go into 1.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kl0u commented on the pull request:
https://github.com/apache/flink/pull/1583#issuecomment-185271802
Hello!
I just rebased to the new master.
Please review this new PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1648#issuecomment-185083603
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1659#issuecomment-185305868
Makes sense. The only tests that seem to remain anyways (are not ignored)
are a simple map/writeFile test and an iteration test that is similarly
elsewhere as well.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1652#discussion_r53150485
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/FileOutputFormat.java
---
@@ -305,6 +305,12 @@ public void tryCleanupOnError() {
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1646
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/1662
FLINK-2523: Makes the task cancellation interval configurable.
This PR is rebased on top of https://github.com/apache/flink/pull/1583 .
Please review that first.
You can merge this pull request into
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1645
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150929#comment-15150929
]
ASF GitHub Bot commented on FLINK-2523:
---
GitHub user kl0u opened a pull request:
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1513#issuecomment-185132200
Manually merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/1513
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1645#issuecomment-185132226
Manually merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
[
https://issues.apache.org/jira/browse/FLINK-2523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150923#comment-15150923
]
ASF GitHub Bot commented on FLINK-2523:
---
Github user kl0u closed the pull request at:
Github user kl0u closed the pull request at:
https://github.com/apache/flink/pull/1612
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-185204685
You can rebase your PR's branch to our current master and then force push
it again. This will update the PR.
---
If your project is set up for it, you can reply to
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/1657
[FLINK-3396] [runtime] Suppress job restart if adding to job graph store
fails
@tillrohrmann, this leaves everything as is, but suppresses the restart in
case of a failure to add the job graph to
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1652#discussion_r53150231
--- Diff:
flink-core/src/main/java/org/apache/flink/api/common/io/FileOutputFormat.java
---
@@ -305,6 +305,12 @@ public void tryCleanupOnError() {
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1655
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1649
[FLINK-3309] [py] Resolve Maven warnings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3309_py_maven
Alternatively you can
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1642#issuecomment-185205104
OK, I'm going to merge this then.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/1655
[FLINK-3430] Remove "no POJO" warning in TypeAnalyzer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink scala-remove-pojo-warning
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-185265002
Taking a look right now. Give me a bit to double check...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1641#issuecomment-185230357
rebasing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-185264548
Awesome. Thanks a lot for testing it! @StephanEwen wanted to take a look at
the PR as well.
---
If your project is set up for it, you can reply to this email and have
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1651#issuecomment-185155443
how about ``` new Path(basePath).toUri()``` instead of ```new
File(basePath)toUri()```?
---
If your project is set up for it, you can reply to this email and have your
Github user aljoscha commented on the pull request:
https://github.com/apache/flink/pull/1645#issuecomment-185126063
@uce Yes, they could also be moved to separate pages.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1650
[FLINK-3423] Fixed ExternalProcessRunnerTest on Windows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3423_test_failure_1
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1651
[FLINK-3426] Fixed JobManagerLeader[Re]ElectionTest.testleaderElectioâ¦
â¦n onWindows
You can merge this pull request into a Git repository by running:
$ git pull
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1653#issuecomment-185229158
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1623#issuecomment-185260566
We have tested this and it worked correctly. Should we go ahead a merge it?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1650#issuecomment-185228383
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1654#discussion_r53162193
--- Diff:
flink-core/src/main/java/org/apache/flink/api/java/typeutils/runtime/TupleSerializerBase.java
---
@@ -56,7 +58,19 @@ public boolean
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1581#issuecomment-185200365
I see there's a conflict, perhaps due to my minor fix in
`YARNSessionFIFOITCase.java`, can I help fix this one? At this point I'm pretty
sure it's the last thing
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1654
[FLINK-3332] TupleSerializer.getLength() can return fixed-length size
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1647#issuecomment-185199372
Manually merged in e08d7a6f30f8e3b845ff33d4266fbd4fad4bec63
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1649#issuecomment-185153138
Looks good, +1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user StephanEwen closed the pull request at:
https://github.com/apache/flink/pull/1647
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1654#issuecomment-185199249
Aside from a minor comment, this looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1642#issuecomment-185199936
Looks reasonable to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1651#issuecomment-185152853
Are we sure that this always only uses local file systems? This change
would break HDFS or S3 URIs.
---
If your project is set up for it, you can reply to this
1 - 100 of 272 matches
Mail list logo
