[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390557#comment-15390557
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2257
The problem that maven downloads the flink-runtime_2.10-tests.jar from the
snapshot repository instead of using the one from the local repository still
remains.
---
If your project is set up
[
https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390505#comment-15390505
]
ASF GitHub Bot commented on FLINK-4035:
---
Github user tzulitai commented on the issue:
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2231
@radekg Thank you for the quick fix. I hope to find time over the weekend
to test + review this, if not than early next week :)
---
If your project is set up for it, you can reply to this email
[
https://issues.apache.org/jira/browse/FLINK-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390493#comment-15390493
]
Cliff Resnick commented on FLINK-4228:
--
I added a pull request for this. I included the fink-yarn
GitHub user cresny opened a pull request:
https://github.com/apache/flink/pull/2288
Feature/s3 a fix
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into
[
https://issues.apache.org/jira/browse/FLINK-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan updated FLINK-3480:
--
Comment: was deleted
(was: Today I bumped into the performance discrepancy where a forwarding ship
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
Fixed build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390291#comment-15390291
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390225#comment-15390225
]
ASF GitHub Bot commented on FLINK-4035:
---
Github user radekg commented on the issue:
Github user radekg commented on the issue:
https://github.com/apache/flink/pull/2231
Travis is going to run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
[
https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390177#comment-15390177
]
ASF GitHub Bot commented on FLINK-4035:
---
Github user radekg commented on the issue:
Github user radekg commented on the issue:
https://github.com/apache/flink/pull/2231
Thanks, running `verify` again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/FLINK-3480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390164#comment-15390164
]
Greg Hogan commented on FLINK-3480:
---
Today I bumped into the performance discrepancy where a forwarding
[
https://issues.apache.org/jira/browse/FLINK-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390158#comment-15390158
]
ASF GitHub Bot commented on FLINK-3904:
---
Github user mxm commented on the issue:
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2123
Brief summary of changes:
- fail if config couldn't be loaded
- make globalconfiguration non-global and remove static SINGLETON
- remove duplicate api methods
- remove undocumented
[
https://issues.apache.org/jira/browse/FLINK-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390153#comment-15390153
]
ASF GitHub Bot commented on FLINK-3904:
---
Github user mxm commented on the issue:
Github user mxm commented on the issue:
https://github.com/apache/flink/pull/2123
That's odd. I was working on exactly these changes and have just pushed
them (without seeing your comment before).
---
If your project is set up for it, you can reply to this email and have your
reply
[
https://issues.apache.org/jira/browse/FLINK-4251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390142#comment-15390142
]
ASF GitHub Bot commented on FLINK-4251:
---
Github user PhilippGrulich commented on the issue:
Github user PhilippGrulich commented on the issue:
https://github.com/apache/flink/pull/2281
@kkamkou Thank you for your review.
I changed also the access levels for the connection and schema field. So
the RMQSink is more similar to the RMQSource.
---
If your project is set up
Ted Yu created FLINK-4259:
-
Summary: Unclosed FSDataOutputStream in FileCache#copy()
Key: FLINK-4259
URL: https://issues.apache.org/jira/browse/FLINK-4259
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390130#comment-15390130
]
ASF GitHub Bot commented on FLINK-4035:
---
Github user tzulitai commented on the issue:
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2231
The errors are due to some of the changes to `AbstractFetcher` in
https://github.com/apache/flink/commit/41f58182289226850b23c61a32f01223485d4775.
Some of the Kafka 0.9 connector code that has
Ted Yu created FLINK-4258:
-
Summary: Potential null pointer dereference in
SavepointCoordinator#onFullyAcknowledgedCheckpoint
Key: FLINK-4258
URL: https://issues.apache.org/jira/browse/FLINK-4258
Project:
Github user radekg commented on the issue:
https://github.com/apache/flink/pull/2231
Merged with `upstream/master` and I'm getting this when running `mvn clean
verify`:
```
[INFO] -
[ERROR] COMPILATION ERROR
[
https://issues.apache.org/jira/browse/FLINK-4035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390117#comment-15390117
]
ASF GitHub Bot commented on FLINK-4035:
---
Github user radekg commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-2929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi closed FLINK-2929.
--
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed in FLINK-4166.
> Recovery of jobs on cluster
[
https://issues.apache.org/jira/browse/FLINK-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi closed FLINK-3411.
--
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed in FLINK-2733 and FLINK-4201.
> Failed recovery
[
https://issues.apache.org/jira/browse/FLINK-2227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi closed FLINK-2227.
--
Resolution: Fixed
Fix Version/s: 1.1.0
Fixed by the recent YARN client refactorings.
>
[
https://issues.apache.org/jira/browse/FLINK-3904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390051#comment-15390051
]
ASF GitHub Bot commented on FLINK-3904:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2123
Looks like a good fix for now.
I would eventually really like to get rid of the `GlobalConfiguration`
singleton - it causes issues with embedding, testing, and encourages to not
cleanly
[
https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390044#comment-15390044
]
Stephan Ewen commented on FLINK-4245:
-
Addendum: We need to also include the operator-id (each
[
https://issues.apache.org/jira/browse/FLINK-4245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen updated FLINK-4245:
Comment: was deleted
(was: 1. As long as we don't have unique operator names you cannot have
[
https://issues.apache.org/jira/browse/FLINK-3006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390039#comment-15390039
]
Stephan Ewen commented on FLINK-3006:
-
[~gyfora] Did you manage to reproduce the problem? I think we
[
https://issues.apache.org/jira/browse/FLINK-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan closed FLINK-4213.
-
Resolution: Implemented
Implemented in e2ef74ea5a854555f86aefbd8a6b1889ef188ff1
> Provide CombineHint in
[
https://issues.apache.org/jira/browse/FLINK-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Hogan closed FLINK-4217.
-
Resolution: Implemented
Implemented in b71ac354d19dccdd8bfa837b92f6bc814c9d29c6
> Gelly drivers should
[
https://issues.apache.org/jira/browse/FLINK-4217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390019#comment-15390019
]
ASF GitHub Bot commented on FLINK-4217:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/FLINK-4213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15390020#comment-15390020
]
ASF GitHub Bot commented on FLINK-4213:
---
Github user asfgit closed the pull request at:
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
[
https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Mushketyk reassigned FLINK-3298:
-
Assignee: Ivan Mushketyk
> Streaming connector for ActiveMQ
>
[
https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389913#comment-15389913
]
Ivan Mushketyk commented on FLINK-3298:
---
I would like to work on this.
> Streaming connector for
[
https://issues.apache.org/jira/browse/FLINK-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389902#comment-15389902
]
Ivan Mushketyk commented on FLINK-3866:
---
I'll fix this.
> StringArraySerializer claims type is
[
https://issues.apache.org/jira/browse/FLINK-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Mushketyk reassigned FLINK-3866:
-
Assignee: Ivan Mushketyk
> StringArraySerializer claims type is immutable; shouldn't
>
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389887#comment-15389887
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2257
The latter problem apparently only occurred in my local branch because I
set `akka.remote.log-remote-lifecycle-events=on` for debugging purposes. The
former problem with the downloading of the
Greg Hogan created FLINK-4257:
-
Summary: Handle delegating algorithm change of class
Key: FLINK-4257
URL: https://issues.apache.org/jira/browse/FLINK-4257
Project: Flink
Issue Type: Bug
[
https://issues.apache.org/jira/browse/FLINK-4152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389874#comment-15389874
]
ASF GitHub Bot commented on FLINK-4152:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2257
At the moment I'm a little bit clueless why the test case errors occur. One
test case error is probably related to concurrency issues in the
`TestingLeaderRetrievalService`. I've fixed them but
Stephan Ewen created FLINK-4256:
---
Summary: Fine-grained recovery
Key: FLINK-4256
URL: https://issues.apache.org/jira/browse/FLINK-4256
Project: Flink
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/FLINK-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen closed FLINK-3725.
---
> Exception in thread "main" scala.MatchError: ... (of class scala.Tuple4)
>
[
https://issues.apache.org/jira/browse/FLINK-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephan Ewen resolved FLINK-3725.
-
Resolution: Fixed
Assignee: Stephan Ewen
Fix Version/s: 1.1.0
Fixed as part of
[
https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389776#comment-15389776
]
ASF GitHub Bot commented on FLINK-4192:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2226
Had a quick offline discussion with @zentol and @aljoscha with the outcome:
- Make `flink-metrics-core` strictly the metrics API project for Metrics
and Reporters
- Move all
[
https://issues.apache.org/jira/browse/FLINK-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389770#comment-15389770
]
Stephan Ewen commented on FLINK-3725:
-
This looks like a strange classpath issue - probably multiple
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/2287
[hotfix] Prevent CheckpointCommitter from failing job
This PR fixes an issue in the `GenericWriteAheadSink` that @aljoscha
stumbled upon.
If the sink fails while writing the data into the
[
https://issues.apache.org/jira/browse/FLINK-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389743#comment-15389743
]
Gary Yao commented on FLINK-4228:
-
We also want to use RocksDB with checkpointing to s3a. We would prefer
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389703#comment-15389703
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389702#comment-15389702
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389700#comment-15389700
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898897
--- Diff:
flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
@@ -137,9 +140,11 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389701#comment-15389701
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389698#comment-15389698
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898876
--- Diff:
flink-metrics/flink-metrics-dropwizard/src/test/java/org/apache/flink/dropwizard/ScheduledDropwizardReporterTest.java
---
@@ -67,7 +67,9 @@ public
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389694#comment-15389694
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898811
--- Diff:
flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java
---
@@ -79,19 +81,24 @@ public void testGenerateName() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898826
--- Diff:
flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java
---
@@ -79,19 +81,24 @@ public void testGenerateName() {
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389697#comment-15389697
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898798
--- Diff:
flink-core/src/test/java/org/apache/flink/metrics/MetricRegistryTest.java ---
@@ -88,8 +91,10 @@ public void open(Configuration config) {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898844
--- Diff:
flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java
---
@@ -128,18 +133,26 @@ public Integer getValue() {
@Test
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898858
--- Diff:
flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java
---
@@ -197,7 +204,8 @@ public void testHistogramReporting() throws
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389690#comment-15389690
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389693#comment-15389693
]
ASF GitHub Bot commented on FLINK-3940:
---
Github user wuchong commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389695#comment-15389695
]
ASF GitHub Bot commented on FLINK-3940:
---
Github user wuchong commented on a diff in the pull
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2282#discussion_r71898802
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
@@ -150,6 +150,41 @@ case class Sort(order:
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/2282#discussion_r71898818
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/logical/operators.scala
---
@@ -150,6 +150,41 @@ case class Sort(order:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898835
--- Diff:
flink-core/src/test/java/org/apache/flink/metrics/reporter/JMXReporterTest.java
---
@@ -128,18 +133,26 @@ public Integer getValue() {
@Test
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389691#comment-15389691
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389692#comment-15389692
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898790
--- Diff:
flink-core/src/test/java/org/apache/flink/metrics/MetricRegistryTest.java ---
@@ -42,7 +42,8 @@
public void testReporterInstantiation() {
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898715
--- Diff:
flink-metrics/flink-metrics-statsd/src/test/java/org/apache/flink/metrics/statsd/StatsDReporterTest.java
---
@@ -138,12 +138,11 @@ public void
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389687#comment-15389687
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389688#comment-15389688
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user aljoscha commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389686#comment-15389686
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2285
Jip, but that's not done very often, only when instantiating the
`MetricRegistry`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898559
--- Diff:
flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/WindowWordCount.java
---
@@ -17,12 +17,13 @@
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389685#comment-15389685
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on the issue:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898375
--- Diff: docs/apis/metrics.md ---
@@ -229,21 +229,25 @@ or by assigning unique names to jobs and operators.
Metrics can be exposed to an external
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/2285
That would imply iterating over the entire configuration and checking for
the prefix, correct?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389681#comment-15389681
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71898033
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -75,77 +78,92 @@ public MetricRegistry(Configuration config) {
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389679#comment-15389679
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user aljoscha commented on the issue:
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/2285
Thanks for the thorough review @zentol! I'm addressing the comments in a
new commit.
About the move to `MetricConfig`, I think the Configuration could be
extended for that case to move all
[
https://issues.apache.org/jira/browse/FLINK-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389674#comment-15389674
]
Jark Wu commented on FLINK-4203:
We should also improve [Table API Operators
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389671#comment-15389671
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user aljoscha commented on a diff in the pull
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/2285#discussion_r71896724
--- Diff:
flink-core/src/main/java/org/apache/flink/metrics/MetricRegistry.java ---
@@ -75,77 +78,92 @@ public MetricRegistry(Configuration config) {
[
https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389641#comment-15389641
]
ASF GitHub Bot commented on FLINK-4192:
---
Github user StephanEwen commented on the issue:
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2226
Actually, we do not even have to move the JobID, if the runtime-specific
parts (the component metric groups) are in `flink-runtime`. That part, I
believe, we should do anyways.
It
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389534#comment-15389534
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389588#comment-15389588
]
ASF GitHub Bot commented on FLINK-4246:
---
Github user zentol commented on the issue:
1 - 100 of 221 matches
Mail list logo
