[
https://issues.apache.org/jira/browse/FLINK-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389641#comment-15389641
]
ASF GitHub Bot commented on FLINK-4192:
---------------------------------------
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2226
Actually, we do not even have to move the JobID, if the runtime-specific
parts (the component metric groups) are in `flink-runtime`. That part, I
believe, we should do anyways.
It certainly is nice to have a complete "self-contained" metrics project
with everything. That way, people can actually build their own metrics tooling
using some of the implementation classes, or they can set up self-contained
tests for reporters (without having flink-core) as a test dependency. If it
were not for the `NetUtils`, I would suggest to go for that. The
`Preconditions` are used only for `checkNotNull`, which one can do via
`java.util.Objects.requireNonNull` as well.
On the other side of the argument are the `NetUtils` (one utility function
for port ranges) and making the MetricRegistry use MetricConfig in all places.
> Move Metrics API to separate module
> -----------------------------------
>
> Key: FLINK-4192
> URL: https://issues.apache.org/jira/browse/FLINK-4192
> Project: Flink
> Issue Type: Improvement
> Components: Metrics
> Affects Versions: 1.1.0
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Fix For: 1.1.0
>
>
> All metrics code currently resides in flink-core. If a user implements a
> reporter and wants a fat jar it will now have to include the entire
> flink-core module.
> Instead, we could move several interfaces into a separate module.
> These interfaces to move include:
> * Counter, Gauge, Histogram(Statistics)
> * MetricGroup
> * MetricReporter, Scheduled, AbstractReporter
> In addition a new MetricRegistry interface will be required as well as a
> replacement for the Configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
