[
https://issues.apache.org/jira/browse/FLINK-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427574#comment-15427574
]
ASF GitHub Bot commented on FLINK-4347:
---
GitHub user KurtYoung opened a pull request:
GitHub user KurtYoung opened a pull request:
https://github.com/apache/flink/pull/2388
[FLINK-4347][cluster management] Implement SlotManager core
Implement some SlotManager's logic mainly in 4 parts:
* handle slot request initiated by JobMaster
* sync slot status trigger by
Kurt Young created FLINK-4427:
-
Summary: Add slot / container releasing logic to SlotManager
(Standalone / Yarn / Mesos)
Key: FLINK-4427
URL: https://issues.apache.org/jira/browse/FLINK-4427
Project:
[
https://issues.apache.org/jira/browse/FLINK-4347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kurt Young updated FLINK-4347:
--
Summary: Implement SlotManager core (was: Implement SlotManager core for
new ResourceManager)
>
[
https://issues.apache.org/jira/browse/FLINK-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427391#comment-15427391
]
ASF GitHub Bot commented on FLINK-4222:
---
Github user chadnickbok commented on the issue:
Github user chadnickbok commented on the issue:
https://github.com/apache/flink/pull/2260
Sorry I dropped off the map on this one - I actually got pulled onto a
front-end project and ended up not having any time to follow this pull request
:(
Glad to hear this PR is being
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/2260
@rmetzger Sure, that would be great. Thanks for your help with merging this.
Thanks for your contribution @chadnickbok :)
---
If your project is set up for it, you can reply to this email and
[
https://issues.apache.org/jira/browse/FLINK-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427390#comment-15427390
]
ASF GitHub Bot commented on FLINK-4222:
---
Github user tzulitai commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Harpreet Sawhney updated FLINK-4426:
Affects Version/s: 1.1.1
> Unable to create proxy to the ResourceManager
>
Harpreet Sawhney created FLINK-4426:
---
Summary: Unable to create proxy to the ResourceManager
Key: FLINK-4426
URL: https://issues.apache.org/jira/browse/FLINK-4426
Project: Flink
Issue
[
https://issues.apache.org/jira/browse/FLINK-305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427281#comment-15427281
]
Pavel Fadeev commented on FLINK-305:
Dear [~fhueske],
I`ve just discovered that code coverage
[
https://issues.apache.org/jira/browse/FLINK-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427212#comment-15427212
]
ASF GitHub Bot commented on FLINK-1984:
---
Github user EronWright commented on a diff in the pull
Github user EronWright commented on a diff in the pull request:
https://github.com/apache/flink/pull/2315#discussion_r75395325
--- Diff:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosArtifactServer.java
---
@@ -0,0 +1,304 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhenzhong Xu reassigned FLINK-4371:
---
Assignee: Zhenzhong Xu
> Add ability to take savepoints from job manager RESTful API
>
[
https://issues.apache.org/jira/browse/FLINK-3874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427117#comment-15427117
]
ASF GitHub Bot commented on FLINK-3874:
---
Github user mushketyk commented on the issue:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2244
@wuchong I've removed the test as you've suggested since it pretty much
duplicates `TableSinkITCase`.
---
If your project is set up for it, you can reply to this email and have your
reply appear
[
https://issues.apache.org/jira/browse/FLINK-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427082#comment-15427082
]
Ivan Mushketyk commented on FLINK-4395:
---
I'll work on this if no one minds.
> Eager processing of
[
https://issues.apache.org/jira/browse/FLINK-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ivan Mushketyk reassigned FLINK-4395:
-
Assignee: Ivan Mushketyk
> Eager processing of late arrivals in CEP operator
>
[
https://issues.apache.org/jira/browse/FLINK-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427080#comment-15427080
]
Ivan Mushketyk commented on FLINK-2254:
---
Hi [~vkalavri],
I think I could work on this task.
Do you
[
https://issues.apache.org/jira/browse/FLINK-4303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427068#comment-15427068
]
Ivan Mushketyk commented on FLINK-4303:
---
I can add an example for CEP.
[~twalthr] do you have any
[
https://issues.apache.org/jira/browse/FLINK-3298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427045#comment-15427045
]
ASF GitHub Bot commented on FLINK-3298:
---
Github user mushketyk commented on the issue:
Github user mushketyk commented on the issue:
https://github.com/apache/flink/pull/2314
@rmetzger I performed the check as you described and everything seems to be
fine.
I also updated the PR according to your suggestions.
Is this commit in a good shape to merge it?
---
If
[
https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426944#comment-15426944
]
Sunny T edited comment on FLINK-4422 at 8/18/16 6:19 PM:
-
Hi [~StephanEwen], I
[
https://issues.apache.org/jira/browse/FLINK-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426944#comment-15426944
]
Sunny T commented on FLINK-4422:
Hi [~StephanEwen], I would like to work on this. Is there any dependency
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75360196
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426941#comment-15426941
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426892#comment-15426892
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426894#comment-15426894
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75355630
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricFetcher.java
---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426912#comment-15426912
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75356544
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java
---
@@ -33,19 +36,42 @@
* group could for
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426908#comment-15426908
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75356320
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -54,13 +53,19 @@
* return Counters,
[
https://issues.apache.org/jira/browse/FLINK-3397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ufuk Celebi closed FLINK-3397.
--
Resolution: Fixed
Assignee: (was: ramkrishna.s.vasudevan)
Fixed as part of `FLINK-4322`.
>
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75356190
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricQueryService.java
---
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426906#comment-15426906
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426899#comment-15426899
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75355826
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/metrics/AbstractMetricHandlerTest.java
---
@@ -0,0 +1,158 @@
+/*
+ *
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75355525
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricFetcher.java
---
@@ -0,0 +1,185 @@
+/*
+ * Licensed to
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426885#comment-15426885
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426884#comment-15426884
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75354845
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/messages/Messages.scala
---
@@ -47,4 +47,21 @@ object Messages {
* @return The
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75354763
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricQueryService.java
---
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426877#comment-15426877
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75354216
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java
---
@@ -61,9 +58,7 @@ public
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426870#comment-15426870
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75353675
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426867#comment-15426867
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user zentol commented on a diff in the pull request:
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75353538
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-4317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426862#comment-15426862
]
ASF GitHub Bot commented on FLINK-4317:
---
GitHub user uce opened a pull request:
GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/2387
[FLINK-4317, FLIP-3] [docs] Restructure docs
This is the initial layout for the docs restructuring as discussed in
FLIP-3.
We move the top level navigation to the left side and allow arbitrary
[
https://issues.apache.org/jira/browse/FLINK-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426838#comment-15426838
]
ASF GitHub Bot commented on FLINK-4282:
---
Github user Renkai commented on the issue:
Github user Renkai commented on the issue:
https://github.com/apache/flink/pull/2355
I have rearranged the code. It is really hard for me to add space after
every comma,do you have any code style preset for IDEs so that I can reformat
my new code automatically without change those of
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426830#comment-15426830
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on the issue:
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2363
Thanks for your contribution @zentol. I've gone over the code and made some
inline comments. My main concern/question is actually the representation of
metric's type and hierarchy information.
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/2386
[FLINK-3660] Measure latency and exposes them via a metric
This commit adds the initial runtime support for measuring latency of
records going through the system.
I therefore introduced a
[
https://issues.apache.org/jira/browse/FLINK-3660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426825#comment-15426825
]
ASF GitHub Bot commented on FLINK-3660:
---
GitHub user rmetzger opened a pull request:
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426822#comment-15426822
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75347741
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricQueryService.java
---
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426813#comment-15426813
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75346843
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1024,6 +1024,17 @@ class JobManager(
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75346742
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/messages/Messages.scala
---
@@ -47,4 +47,21 @@ object Messages {
* @return The
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426812#comment-15426812
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426808#comment-15426808
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75346431
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426787#comment-15426787
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426786#comment-15426786
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75344971
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java
---
@@ -61,9 +58,7 @@ public
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75344832
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java
---
@@ -33,19 +36,42 @@
* group could for
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426784#comment-15426784
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75344502
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java
---
@@ -33,19 +36,42 @@
* group could for
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426783#comment-15426783
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r7534
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java
---
@@ -54,13 +53,19 @@
* return Counters,
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426776#comment-15426776
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75343567
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -207,6 +239,9 @@ public void register(Metric metric,
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426774#comment-15426774
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75343353
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistry.java
---
@@ -144,6 +152,30 @@ public MetricRegistry(Configuration
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426770#comment-15426770
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75343063
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricQueryService.java
---
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426764#comment-15426764
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75342927
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricQueryService.java
---
@@ -0,0 +1,180 @@
+/*
+ * Licensed to the
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75340401
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/metrics/AbstractMetricHandlerTest.java
---
@@ -0,0 +1,158 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426740#comment-15426740
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75340930
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/metrics/AbstractMetricHandlerTest.java
---
@@ -0,0 +1,158 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-3866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426739#comment-15426739
]
ASF GitHub Bot commented on FLINK-3866:
---
Github user fhueske commented on the issue:
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426738#comment-15426738
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2289
Thanks for the fix @mushketyk!
Looks good to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75340742
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/metrics/AbstractMetricHandlerTest.java
---
@@ -0,0 +1,158 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426732#comment-15426732
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426734#comment-15426734
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75340445
--- Diff:
flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/metrics/AbstractMetricHandlerTest.java
---
@@ -0,0 +1,158 @@
+/*
[
https://issues.apache.org/jira/browse/FLINK-4414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426728#comment-15426728
]
ASF GitHub Bot commented on FLINK-4414:
---
Github user wenlong88 commented on the issue:
Github user wenlong88 commented on the issue:
https://github.com/apache/flink/pull/2381
Coming back to the initial motivation of this PR, It is because that I
tried to get the address from the RpcService, and the RpcService provides a api
`getAddress(RpcGateway gateway)` but can
[
https://issues.apache.org/jira/browse/FLINK-4231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426725#comment-15426725
]
ASF GitHub Bot commented on FLINK-4231:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/2272
Thanks for the PR @greghogan. I added a few comments.
Looks good to merge otherwise.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426720#comment-15426720
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2363#discussion_r75339017
--- Diff:
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/metrics/MetricStore.java
---
@@ -0,0 +1,172 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/FLINK-4389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426718#comment-15426718
]
ASF GitHub Bot commented on FLINK-4389:
---
Github user tillrohrmann commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426717#comment-15426717
]
ASF GitHub Bot commented on FLINK-4253:
---
Github user ramkrish86 commented on the issue:
Github user ramkrish86 commented on the issue:
https://github.com/apache/flink/pull/2342
@uce
Got a green build. Any feedback/reviews here. I know you guys are busy,
just a gentle reminder.
---
If your project is set up for it, you can reply to this email and have your
reply
1 - 100 of 321 matches
Mail list logo
