[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837834#comment-15837834 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97790271 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837835#comment-15837835 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837831#comment-15837831 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97790228 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837828#comment-15837828 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837830#comment-15837830 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837832#comment-15837832 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[jira] [Commented] (FLINK-3318) Add support for quantifiers to CEP's pattern API

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837833#comment-15837833 ] ASF GitHub Bot commented on FLINK-3318: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97790385 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97789988 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97789900 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -130,26 +114,166 @@ }

[GitHub] flink pull request #2361: [FLINK-3318][cep] Add support for quantifiers to C...

2017-01-25 Thread kl0u
Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/2361#discussion_r97789775 --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/compiler/NFACompiler.java --- @@ -80,25 +82,17 @@ // return

[jira] [Commented] (FLINK-5599) State interface docs often refer to keyed state only

2017-01-25 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837815#comment-15837815 ] Aljoscha Krettek commented on FLINK-5599: - Definite +1, yes. > State interface docs often refer

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837809#comment-15837809 ] ASF GitHub Bot commented on FLINK-5092: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2017-01-25 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r97788511 --- Diff: flink-contrib/flink-storm-examples/pom.xml --- @@ -364,6 +363,18 @@ under the License.

[jira] [Commented] (FLINK-5638) Deadlock when closing two chained async I/O operators

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837807#comment-15837807 ] ASF GitHub Bot commented on FLINK-5638: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #3210: [backport] [FLINK-5638] [asyncIO] Fix deadlock when closi...

2017-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3210 Agreed, the problem is a little bit that you don't control from where the `close` method is called... Thanks for the review @StephanEwen. Merging once Travis has passed. --- If your

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837805#comment-15837805 ] ASF GitHub Bot commented on FLINK-5643: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-5643. Resolution: Fixed 1.3.0: cf9f4c77c8e785567f036cc2fbb97c0cd16979a7 1.2.0:

[GitHub] flink pull request #3212: [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837800#comment-15837800 ] ASF GitHub Bot commented on FLINK-5643: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #3212: [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3212 Forwarding review from #3213. Merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837798#comment-15837798 ] ASF GitHub Bot commented on FLINK-5643: --- Github user tillrohrmann closed the pull request at:

[GitHub] flink pull request #3213: [backport] [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread tillrohrmann
Github user tillrohrmann closed the pull request at: https://github.com/apache/flink/pull/3213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #3213: [backport] [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/3213 Thanks for the review @rmetzger. Merging this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837795#comment-15837795 ] ASF GitHub Bot commented on FLINK-5643: --- Github user tillrohrmann commented on the issue:

[jira] [Commented] (FLINK-5546) java.io.tmpdir setted as project build directory in surefire plugin

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837776#comment-15837776 ] ASF GitHub Bot commented on FLINK-5546: --- Github user shijinkui commented on the issue:

[GitHub] flink issue #3190: [FLINK-5546][build] java.io.tmpdir setted as project buil...

2017-01-25 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3190 @greghogan That make sense. Let JUnit to create root dir and delete temporary dir recursively. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] flink pull request #3214: [FLINK-5644] Remove metric: Task#lastCheckpointSiz...

2017-01-25 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3214 [FLINK-5644] Remove metric: Task#lastCheckpointSize This PR removes the lastCheckpointSize metric that was broken when the key-groups were introduced. I couldn't find an easy way to fix it instead.

[jira] [Commented] (FLINK-5644) Task#lastCheckpointSize metric broken

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837773#comment-15837773 ] ASF GitHub Bot commented on FLINK-5644: --- GitHub user zentol opened a pull request:

[jira] [Created] (FLINK-5644) Task#lastCheckpointSize metric broken

2017-01-25 Thread Chesnay Schepler (JIRA)
Chesnay Schepler created FLINK-5644: --- Summary: Task#lastCheckpointSize metric broken Key: FLINK-5644 URL: https://issues.apache.org/jira/browse/FLINK-5644 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-5551) NPE at SourceStreamTask

2017-01-25 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837769#comment-15837769 ] Aljoscha Krettek commented on FLINK-5551: - I think this can happen when canceling happens before

[jira] [Assigned] (FLINK-5637) Default Flink configuration contains whitespace characters, causing parser WARNings

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-5637: - Assignee: Robert Metzger > Default Flink configuration contains whitespace characters,

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837761#comment-15837761 ] ASF GitHub Bot commented on FLINK-5643: --- Github user rmetzger commented on the issue:

[jira] [Commented] (FLINK-5516) Hardcoded paths in flink-python/.../PythonPlanBinder.java

2017-01-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837760#comment-15837760 ] Chesnay Schepler commented on FLINK-5516: - Yeah this is easy to implement; it is pretty much a

[GitHub] flink issue #3213: [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3213 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Resolved] (FLINK-5492) BootstrapTools log wrong address of started ActorSystem

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger resolved FLINK-5492. --- Resolution: Fixed Fix Version/s: 1.3.0 1.2.0 > BootstrapTools log

[jira] [Commented] (FLINK-5492) BootstrapTools log wrong address of started ActorSystem

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837756#comment-15837756 ] Robert Metzger commented on FLINK-5492: --- Fixed for 1.2 in

[GitHub] flink pull request #3213: [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3213 [FLINK-5643] Fix NPE in StateUtil Introduces a null check to deal with state futures which have a null value. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837752#comment-15837752 ] ASF GitHub Bot commented on FLINK-5643: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-5229) Cleanup StreamTaskStates if a checkpoint operation of a subsequent operator fails

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837750#comment-15837750 ] Robert Metzger commented on FLINK-5229: --- Thank you! > Cleanup StreamTaskStates if a checkpoint

[jira] [Commented] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837751#comment-15837751 ] ASF GitHub Bot commented on FLINK-5643: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #3212: [FLINK-5643] Fix NPE in StateUtil

2017-01-25 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3212 [FLINK-5643] Fix NPE in StateUtil Introduces a null check to deal with state futures which have a null value. You can merge this pull request into a Git repository by running: $ git pull

[jira] [Commented] (FLINK-5229) Cleanup StreamTaskStates if a checkpoint operation of a subsequent operator fails

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837748#comment-15837748 ] Till Rohrmann commented on FLINK-5229: -- Will be addressed with FLINK-5643. > Cleanup

[jira] [Created] (FLINK-5643) StateUtil.discardStateFuture fails when state future contains null value

2017-01-25 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-5643: Summary: StateUtil.discardStateFuture fails when state future contains null value Key: FLINK-5643 URL: https://issues.apache.org/jira/browse/FLINK-5643 Project:

[jira] [Commented] (FLINK-5516) Hardcoded paths in flink-python/.../PythonPlanBinder.java

2017-01-25 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837744#comment-15837744 ] Aljoscha Krettek commented on FLINK-5516: - [~Zentol] would this be possible? I think no one is

[jira] [Closed] (FLINK-4905) Kafka test instability IllegalStateException: Client is not started

2017-01-25 Thread Andrew Efimov (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Efimov closed FLINK-4905. Resolution: Fixed Fix Version/s: 1.3.0 Fixed by Stephan Ewen > Kafka test instability

[jira] [Commented] (FLINK-5229) Cleanup StreamTaskStates if a checkpoint operation of a subsequent operator fails

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837740#comment-15837740 ] Till Rohrmann commented on FLINK-5229: -- Should be fixed. Apparently, there are state handle futures

[jira] [Updated] (FLINK-5641) Directories of expired checkpoints are not cleaned up

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-5641: -- Attachment: application-1485249546281-0021-misbehaved-1.2.0-rc1 > Directories of expired

[jira] [Created] (FLINK-5642) queryable state: race condition with HeadListState

2017-01-25 Thread Nico Kruber (JIRA)
Nico Kruber created FLINK-5642: -- Summary: queryable state: race condition with HeadListState Key: FLINK-5642 URL: https://issues.apache.org/jira/browse/FLINK-5642 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-5641) Directories of expired checkpoints are not cleaned up

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837738#comment-15837738 ] Robert Metzger commented on FLINK-5641: --- I have a job that has expiring checkpoints. I'll attach the

[jira] [Commented] (FLINK-5641) Directories of expired checkpoints are not cleaned up

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837736#comment-15837736 ] Till Rohrmann commented on FLINK-5641: -- [~rmetzger] how have you produced this? > Directories of

[jira] [Commented] (FLINK-5229) Cleanup StreamTaskStates if a checkpoint operation of a subsequent operator fails

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837735#comment-15837735 ] Robert Metzger commented on FLINK-5229: --- I'm seeing the following exceptions in my 1.2.0 RC1 code

[GitHub] flink pull request #3207: [FLINK-5630] [streaming api] Followups to the Aggr...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3207#discussion_r97775252 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java --- @@ -279,6 +286,202 @@ public

[jira] [Commented] (FLINK-5630) Followups to AggregationFunction

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837730#comment-15837730 ] ASF GitHub Bot commented on FLINK-5630: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3207: [FLINK-5630] [streaming api] Followups to the Aggr...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3207#discussion_r97774934 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java --- @@ -279,6 +286,202 @@ public

[jira] [Commented] (FLINK-5630) Followups to AggregationFunction

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837729#comment-15837729 ] ASF GitHub Bot commented on FLINK-5630: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3207: [FLINK-5630] [streaming api] Followups to the Aggr...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3207#discussion_r97776155 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java --- @@ -515,12 +515,16 @@ public

[jira] [Commented] (FLINK-5630) Followups to AggregationFunction

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837731#comment-15837731 ] ASF GitHub Bot commented on FLINK-5630: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3207: [FLINK-5630] [streaming api] Followups to the Aggr...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3207#discussion_r97773952 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/AggregateFunction.java --- @@ -18,14 +18,37 @@ package

[jira] [Commented] (FLINK-5630) Followups to AggregationFunction

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837733#comment-15837733 ] ASF GitHub Bot commented on FLINK-5630: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #3207: [FLINK-5630] [streaming api] Followups to the Aggr...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3207#discussion_r97774041 --- Diff: flink-core/src/main/java/org/apache/flink/api/common/functions/AggregateFunction.java --- @@ -81,14 +104,55 @@ * } * } * }

[GitHub] flink pull request #3207: [FLINK-5630] [streaming api] Followups to the Aggr...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3207#discussion_r97776428 --- Diff: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/windowing/AllWindowTranslationTest.java --- @@ -101,6 +108,24 @@

[GitHub] flink pull request #3207: [FLINK-5630] [streaming api] Followups to the Aggr...

2017-01-25 Thread aljoscha
Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/3207#discussion_r97775106 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/AllWindowedStream.java --- @@ -279,6 +286,202 @@ public

[jira] [Commented] (FLINK-5630) Followups to AggregationFunction

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837732#comment-15837732 ] ASF GitHub Bot commented on FLINK-5630: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-5630) Followups to AggregationFunction

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837728#comment-15837728 ] ASF GitHub Bot commented on FLINK-5630: --- Github user aljoscha commented on a diff in the pull

[jira] [Commented] (FLINK-5630) Followups to AggregationFunction

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837734#comment-15837734 ] ASF GitHub Bot commented on FLINK-5630: --- Github user aljoscha commented on a diff in the pull

[jira] [Assigned] (FLINK-5641) Directories of expired checkpoints are not cleaned up

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-5641: Assignee: Till Rohrmann > Directories of expired checkpoints are not cleaned up >

[jira] [Commented] (FLINK-5492) BootstrapTools log wrong address of started ActorSystem

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837726#comment-15837726 ] Till Rohrmann commented on FLINK-5492: -- Arg, you're right. The grizzled logger used in the Scala

[jira] [Updated] (FLINK-4719) KryoSerializer random exception

2017-01-25 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nico Kruber updated FLINK-4719: --- Assignee: (was: Nico Kruber) > KryoSerializer random exception > ---

[GitHub] flink issue #3210: [FLINK-5638] [asyncIO] Fix deadlock when closing two chai...

2017-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3210 It's a bit hacky to release the lock in scope via `wait()` but seems to work. One more reason to go for a post-box model... +1 --- If your project is set up for it, you can

[jira] [Commented] (FLINK-5638) Deadlock when closing two chained async I/O operators

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837722#comment-15837722 ] ASF GitHub Bot commented on FLINK-5638: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-4905) Kafka test instability IllegalStateException: Client is not started

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837721#comment-15837721 ] ASF GitHub Bot commented on FLINK-4905: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5492) BootstrapTools log wrong address of started ActorSystem

2017-01-25 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837720#comment-15837720 ] Robert Metzger commented on FLINK-5492: --- I will provide a fix for the issue. > BootstrapTools log

[GitHub] flink issue #3035: [ FLINK-4905] Kafka test instability IllegalStateExceptio...

2017-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3035 I pushed a fix for that to master in e7cda75b8594417559d6aac6229b5893f5459f0f --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Updated] (FLINK-5640) configure the explicit Unit Test file suffix

2017-01-25 Thread shijinkui (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shijinkui updated FLINK-5640: - Description: There are four types of Unit Test file: *ITCase.java, *Test.java, *ITSuite.scala,

[jira] [Commented] (FLINK-5640) configure the explicit Unit Test file suffix

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837719#comment-15837719 ] ASF GitHub Bot commented on FLINK-5640: --- GitHub user shijinkui opened a pull request:

[GitHub] flink pull request #3211: c[FLINK-5640][test]onfigure the explicit Unit Test...

2017-01-25 Thread shijinkui
GitHub user shijinkui opened a pull request: https://github.com/apache/flink/pull/3211 c[FLINK-5640][test]onfigure the explicit Unit Test file suffix There are four types of Unit Test file: *ITCase.java, *Test.java, *ITSuite.scala, *Suite.scala File name ending with "IT.java"

[jira] [Commented] (FLINK-5638) Deadlock when closing two chained async I/O operators

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837716#comment-15837716 ] ASF GitHub Bot commented on FLINK-5638: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-5638) Deadlock when closing two chained async I/O operators

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837717#comment-15837717 ] ASF GitHub Bot commented on FLINK-5638: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #3210: [FLINK-5638] [asyncIO] Fix deadlock when closing t...

2017-01-25 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3210 [FLINK-5638] [asyncIO] Fix deadlock when closing two chained AsyncWaitOperators This PR is a backport of #3209 onto `release-1.2.` This PR addresses the problem by changing the

[GitHub] flink pull request #3209: [FLINK-5638] [asyncIO] Fix deadlock when closing t...

2017-01-25 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/3209 [FLINK-5638] [asyncIO] Fix deadlock when closing two chained AsyncWaitOperators This PR addresses the problem by changing the Emitter's behaviour to first output the element before

[jira] [Commented] (FLINK-4905) Kafka test instability IllegalStateException: Client is not started

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837713#comment-15837713 ] ASF GitHub Bot commented on FLINK-4905: --- Github user BrainLogic commented on the issue:

[GitHub] flink issue #3035: [ FLINK-4905] Kafka test instability IllegalStateExceptio...

2017-01-25 Thread BrainLogic
Github user BrainLogic commented on the issue: https://github.com/apache/flink/pull/3035 I caught yours idea and together with the argument which I mentioned above - users will not extensively use 8 version of kafka connector, I agree with this proposal. Let me finish this jira,

[jira] [Assigned] (FLINK-5628) CheckpointStatsTracker implements Serializable but isn't

2017-01-25 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi reassigned FLINK-5628: -- Assignee: Ufuk Celebi > CheckpointStatsTracker implements Serializable but isn't >

[jira] [Commented] (FLINK-5608) Cancel button not always visible

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837708#comment-15837708 ] ASF GitHub Bot commented on FLINK-5608: --- Github user uce commented on the issue:

[jira] [Created] (FLINK-5641) Directories of expired checkpoints are not cleaned up

2017-01-25 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-5641: - Summary: Directories of expired checkpoints are not cleaned up Key: FLINK-5641 URL: https://issues.apache.org/jira/browse/FLINK-5641 Project: Flink Issue

[GitHub] flink issue #3189: [FLINK-5608] [webfrontend] Cancel button stays visible in...

2017-01-25 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/3189 Good point. @rehevkor5 is it possible to only hide the color boxes when the browser window is very narrow? --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Updated] (FLINK-5638) Deadlock when closing two chained async I/O operators

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-5638: - Fix Version/s: (was: 1.2.1) 1.2.0 > Deadlock when closing two chained

[jira] [Updated] (FLINK-5638) Deadlock when closing two chained async I/O operators

2017-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-5638: - Description: The {{AsyncWaitOperator}} can deadlock in a special cases when closing two chained

[GitHub] flink pull request #3208: [hotfix] [rat] Add exclusion for rolling-sink snap...

2017-01-25 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/3208 [hotfix] [rat] Add exclusion for rolling-sink snapshot Adds a RAT exclusion for the rolling sink snapshot used for testing backwards compatibility. Note that the RAT plugin only complains about

[jira] [Commented] (FLINK-5634) Flink should not always redirect stdout to a file.

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837691#comment-15837691 ] ASF GitHub Bot commented on FLINK-5634: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3204: [FLINK-5634] Flink should not always redirect stdout to a...

2017-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3204 Looks good to me, +1 @uce the ScriptMeister should probably give his blessing as well... --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (FLINK-4905) Kafka test instability IllegalStateException: Client is not started

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837684#comment-15837684 ] ASF GitHub Bot commented on FLINK-4905: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3035: [ FLINK-4905] Kafka test instability IllegalStateExceptio...

2017-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3035 I this case, the exception would not be logged, true. It is a very rare corner case that should not affect correctness, and not really distinguishable from the case where an exception is

[jira] [Created] (FLINK-5640) configure the explicit Unit Test file suffix

2017-01-25 Thread shijinkui (JIRA)
shijinkui created FLINK-5640: Summary: configure the explicit Unit Test file suffix Key: FLINK-5640 URL: https://issues.apache.org/jira/browse/FLINK-5640 Project: Flink Issue Type: Test

[jira] [Commented] (FLINK-4905) Kafka test instability IllegalStateException: Client is not started

2017-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837665#comment-15837665 ] ASF GitHub Bot commented on FLINK-4905: --- Github user BrainLogic commented on the issue:

[GitHub] flink issue #3035: [ FLINK-4905] Kafka test instability IllegalStateExceptio...

2017-01-25 Thread BrainLogic
Github user BrainLogic commented on the issue: https://github.com/apache/flink/pull/3035 Distributed systems and multithreading environments make us think in term of logical clock, like Lamport clock, step by step: Thread1 - fetcher is running `running = true` Thread2 performs

[GitHub] flink pull request #3206: [FLINK-5612] Fix GlobPathFilter not-serializable e...

2017-01-25 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3206#discussion_r97768800 --- Diff: flink-core/src/test/java/org/apache/flink/api/common/io/GlobFilePathFilterTest.java --- @@ -138,4 +141,30 @@ public void doubleStarPattern() {

<    1   2   3   4   >