[jira] [Commented] (FLINK-5792) Improve “UDTF" to support with parameter constructor

2017-02-13 Thread Zhuoluo Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865221#comment-15865221 ] Zhuoluo Yang commented on FLINK-5792: - [~sunjincheng121] Could you please attach some design documents

[jira] [Commented] (FLINK-5793) Running slot may not be add to AllocatedMap in SlotPool

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865219#comment-15865219 ] ASF GitHub Bot commented on FLINK-5793: --- GitHub user shuai-xu opened a pull request:

[GitHub] flink pull request #3306: [FLINK-5793] [runtime] fix running slot may not be...

2017-02-13 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/3306 [FLINK-5793] [runtime] fix running slot may not be add to AllocatedMap in SlotPool bug This pr is for jira #[5793](https://issues.apache.org/jira/browse/FLINK-5793) In SlotPool, when a

[jira] [Created] (FLINK-5793) Running slot may not be add to AllocatedMap in SlotPool

2017-02-13 Thread shuai.xu (JIRA)
shuai.xu created FLINK-5793: --- Summary: Running slot may not be add to AllocatedMap in SlotPool Key: FLINK-5793 URL: https://issues.apache.org/jira/browse/FLINK-5793 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-5133) Add new setResource API for DataStream and DataSet

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865200#comment-15865200 ] ASF GitHub Bot commented on FLINK-5133: --- Github user wangzhijiang999 commented on the issue:

[GitHub] flink issue #3303: [FLINK-5133][core] Add new setResource API for DataStream...

2017-02-13 Thread wangzhijiang999
Github user wangzhijiang999 commented on the issue: https://github.com/apache/flink/pull/3303 @StephanEwen , this PR includes the new API that would be visible to user, but it can not work completely because the following codes in runtime have not been submitted. In order not to

[jira] [Resolved] (FLINK-4930) Implement FLIP-6 YARN client

2017-02-13 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu resolved FLINK-4930. - Resolution: Fixed fix via 3695a8e92e9c3deee368d9cc3ce89a5ab117d6a1 > Implement FLIP-6 YARN client >

[jira] [Resolved] (FLINK-4929) Implement FLIP-6 YARN TaskManager Runner

2017-02-13 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu resolved FLINK-4929. - Resolution: Fixed fix via 371997a81a7035b68cf47e7bca64ce01e3ac36a6 > Implement FLIP-6 YARN TaskManager

[jira] [Resolved] (FLINK-4928) Implement FLIP-6 YARN Application Master Runner

2017-02-13 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu resolved FLINK-4928. - Resolution: Fixed fix via 0113e5a467858f9cd435e80df2c2626170e5de62 > Implement FLIP-6 YARN Application

[jira] [Resolved] (FLINK-4927) Implement FLI-6 YARN Resource Manager

2017-02-13 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu resolved FLINK-4927. - Resolution: Fixed fix via e2922add100338776db765a62deb02f556845cf9 > Implement FLI-6 YARN Resource

[jira] [Closed] (FLINK-5023) Add get() method in State interface

2017-02-13 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaogang Shi closed FLINK-5023. --- Resolution: Won't Fix The updates to the `State` interface will affect existing user code. We will

[jira] [Closed] (FLINK-5024) Add SimpleStateDescriptor to clarify the concepts

2017-02-13 Thread Xiaogang Shi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5024?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xiaogang Shi closed FLINK-5024. --- Resolution: Invalid Now we refactor the state descriptors with the introduction of composited

[jira] [Commented] (FLINK-5023) Add get() method in State interface

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865167#comment-15865167 ] ASF GitHub Bot commented on FLINK-5023: --- Github user shixiaogang closed the pull request at:

[jira] [Commented] (FLINK-5023) Add get() method in State interface

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5023?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865166#comment-15865166 ] ASF GitHub Bot commented on FLINK-5023: --- Github user shixiaogang commented on the issue:

[GitHub] flink pull request #2768: [FLINK-5023][FLINK-5024] Add SimpleStateDescriptor...

2017-02-13 Thread shixiaogang
Github user shixiaogang closed the pull request at: https://github.com/apache/flink/pull/2768 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] flink issue #2768: [FLINK-5023][FLINK-5024] Add SimpleStateDescriptor to cla...

2017-02-13 Thread shixiaogang
Github user shixiaogang commented on the issue: https://github.com/apache/flink/pull/2768 Close the pull request because the state descriptor now is refactored with the introduction of composited serializers (See [FLINK-5790](https://issues.apache.org/jira/browse/FLINK-5790)). ---

[jira] [Updated] (FLINK-5792) Improve “UDTF" to support with parameter constructor

2017-02-13 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-5792: --- Description: Improved “UDTF" to support with parameter constructor. (was: Improved “UDF/UDTF" to

[jira] [Updated] (FLINK-5792) Improve “UDTF" to support with parameter constructor

2017-02-13 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-5792: --- Summary: Improve “UDTF" to support with parameter constructor (was: Improve “UDF/UDTF" to support

[jira] [Commented] (FLINK-5790) Use list types when ListStateDescriptor extends StateDescriptor

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865162#comment-15865162 ] ASF GitHub Bot commented on FLINK-5790: --- Github user shixiaogang commented on a diff in the pull

[GitHub] flink pull request #3305: [FLINK-5790][StateBackend] Use list types when Lis...

2017-02-13 Thread shixiaogang
Github user shixiaogang commented on a diff in the pull request: https://github.com/apache/flink/pull/3305#discussion_r100967108 --- Diff: flink-core/src/main/java/org/apache/flink/migration/util/MigrationInstantiationUtil.java --- @@ -47,9 +47,16 @@ public

[jira] [Commented] (FLINK-5790) Use list types when ListStateDescriptor extends StateDescriptor

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865156#comment-15865156 ] ASF GitHub Bot commented on FLINK-5790: --- GitHub user shixiaogang opened a pull request:

[GitHub] flink pull request #3305: [FLINK-5790][StateBackend] Use list types when Lis...

2017-02-13 Thread shixiaogang
GitHub user shixiaogang opened a pull request: https://github.com/apache/flink/pull/3305 [FLINK-5790][StateBackend] Use list types when ListStateDescriptor extends StateDescriptor 1. Now the state serializer, instead of the element serializer, is stored in `ListStateDescriptor`.

[jira] [Commented] (FLINK-5406) add normalization phase for predicate logical plan rewriting between decorrelate query phase and volcano optimization phase

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865136#comment-15865136 ] ASF GitHub Bot commented on FLINK-5406: --- Github user godfreyhe commented on the issue:

[GitHub] flink issue #3101: [FLINK-5406] [table] add normalization phase for predicat...

2017-02-13 Thread godfreyhe
Github user godfreyhe commented on the issue: https://github.com/apache/flink/pull/3101 Done, thanks for the suggest @fhueske --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (FLINK-5791) Resource should be strictly matched when allocating for yarn

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865127#comment-15865127 ] ASF GitHub Bot commented on FLINK-5791: --- GitHub user shuai-xu opened a pull request:

[GitHub] flink pull request #3304: [FLINK-5791] [runtime] Resource should be strictly...

2017-02-13 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/3304 [FLINK-5791] [runtime] Resource should be strictly matched when allocating for yarn This pr is for jira #[5791](https://issues.apache.org/jira/browse/FLINK-5791). It has following

[jira] [Commented] (FLINK-5566) Introduce structure to hold table and column level statistics

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865088#comment-15865088 ] ASF GitHub Bot commented on FLINK-5566: --- Github user beyond1920 commented on the issue:

[GitHub] flink issue #3196: [FLINK-5566] [Table API & SQL]Introduce structure to hold...

2017-02-13 Thread beyond1920
Github user beyond1920 commented on the issue: https://github.com/apache/flink/pull/3196 @fhueske , thanks for your review. I modify code based on your advice, including compatibility with Java and column stats field type. --- If your project is set up for it, you can reply to this

[GitHub] flink issue #3149: FLINK-2168 Add HBaseTableSource

2017-02-13 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3149 @fhueske - Are you fine with that pom change? If so we can get this in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-2168) Add HBaseTableSource

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865068#comment-15865068 ] ASF GitHub Bot commented on FLINK-2168: --- Github user ramkrish86 commented on the issue:

[jira] [Commented] (FLINK-5133) Add new setResource API for DataStream and DataSet

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865048#comment-15865048 ] ASF GitHub Bot commented on FLINK-5133: --- GitHub user wangzhijiang999 opened a pull request:

[GitHub] flink pull request #3303: [FLINK-5133][core] Add new setResource API for Dat...

2017-02-13 Thread wangzhijiang999
GitHub user wangzhijiang999 opened a pull request: https://github.com/apache/flink/pull/3303 [FLINK-5133][core] Add new setResource API for DataStream and DataSet This is part of the fine-grained resource configuration. For **DataStream**, the **setResource** API will be setted

[jira] [Commented] (FLINK-5566) Introduce structure to hold table and column level statistics

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865033#comment-15865033 ] ASF GitHub Bot commented on FLINK-5566: --- Github user beyond1920 commented on a diff in the pull

[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...

2017-02-13 Thread beyond1920
Github user beyond1920 commented on a diff in the pull request: https://github.com/apache/flink/pull/3196#discussion_r100958745 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed

[jira] [Created] (FLINK-5792) Improve “UDF/UDTF" to support with parameter constructor

2017-02-13 Thread sunjincheng (JIRA)
sunjincheng created FLINK-5792: -- Summary: Improve “UDF/UDTF" to support with parameter constructor Key: FLINK-5792 URL: https://issues.apache.org/jira/browse/FLINK-5792 Project: Flink Issue

[jira] [Created] (FLINK-5791) Resource should be strictly matched when allocating for yarn

2017-02-13 Thread shuai.xu (JIRA)
shuai.xu created FLINK-5791: --- Summary: Resource should be strictly matched when allocating for yarn Key: FLINK-5791 URL: https://issues.apache.org/jira/browse/FLINK-5791 Project: Flink Issue

[jira] [Commented] (FLINK-5566) Introduce structure to hold table and column level statistics

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864939#comment-15864939 ] ASF GitHub Bot commented on FLINK-5566: --- Github user beyond1920 commented on a diff in the pull

[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...

2017-02-13 Thread beyond1920
Github user beyond1920 commented on a diff in the pull request: https://github.com/apache/flink/pull/3196#discussion_r100951579 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed

[jira] [Resolved] (FLINK-5190) ZooKeeperLeaderRetrievalService should not close the zk client when stop

2017-02-13 Thread shuai.xu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shuai.xu resolved FLINK-5190. - Resolution: Fixed fix via cbfb807d65b68b2b6157e1b1d42606123ea499ad > ZooKeeperLeaderRetrievalService

[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...

2017-02-13 Thread beyond1920
Github user beyond1920 commented on a diff in the pull request: https://github.com/apache/flink/pull/3196#discussion_r100950729 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed

[jira] [Commented] (FLINK-5566) Introduce structure to hold table and column level statistics

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864928#comment-15864928 ] ASF GitHub Bot commented on FLINK-5566: --- Github user beyond1920 commented on a diff in the pull

[jira] [Created] (FLINK-5790) Use list types when ListStateDescriptor extends StateDescriptor

2017-02-13 Thread Xiaogang Shi (JIRA)
Xiaogang Shi created FLINK-5790: --- Summary: Use list types when ListStateDescriptor extends StateDescriptor Key: FLINK-5790 URL: https://issues.apache.org/jira/browse/FLINK-5790 Project: Flink

[jira] [Commented] (FLINK-5739) NullPointerException in CliFrontend

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864869#comment-15864869 ] ASF GitHub Bot commented on FLINK-5739: --- Github user clarkyzl commented on a diff in the pull

[GitHub] flink pull request #3292: [FLINK-5739] [client] fix NullPointerException in ...

2017-02-13 Thread clarkyzl
Github user clarkyzl commented on a diff in the pull request: https://github.com/apache/flink/pull/3292#discussion_r100945289 --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java --- @@ -842,6 +842,12 @@ protected int executeProgram(PackagedProgram

[jira] [Closed] (FLINK-5737) Fix the bug when TableSource contains a field of byte[] type

2017-02-13 Thread zhangjing (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangjing closed FLINK-5737. Resolution: Fixed > Fix the bug when TableSource contains a field of byte[] type >

[jira] [Commented] (FLINK-5737) Fix the bug when TableSource contains a field of byte[] type

2017-02-13 Thread zhangjing (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864852#comment-15864852 ] zhangjing commented on FLINK-5737: -- Hi Fabian, thanks a lot. The bug was already fixed, I will close this

[jira] [Commented] (FLINK-5710) Add ProcTime() function to indicate StreamSQL

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864833#comment-15864833 ] ASF GitHub Bot commented on FLINK-5710: --- GitHub user huawei-flink opened a pull request:

[GitHub] flink pull request #3302: [FLINK-5710] Add ProcTime() function to indicate S...

2017-02-13 Thread huawei-flink
GitHub user huawei-flink opened a pull request: https://github.com/apache/flink/pull/3302 [FLINK-5710] Add ProcTime() function to indicate StreamSQL Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.

[GitHub] flink issue #3285: [FLINK-4997] [streaming] Introduce ProcessWindowFunction

2017-02-13 Thread manuzhang
Github user manuzhang commented on the issue: https://github.com/apache/flink/pull/3285 LGTM. Really excited to see we move further in this direction, and faster if possible. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-4997) Extending Window Function Metadata

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864819#comment-15864819 ] ASF GitHub Bot commented on FLINK-4997: --- Github user manuzhang commented on the issue:

[jira] [Commented] (FLINK-5624) Support tumbling window on streaming tables in the SQL API

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864797#comment-15864797 ] ASF GitHub Bot commented on FLINK-5624: --- Github user haohui commented on the issue:

[GitHub] flink issue #3252: [FLINK-5624] Support tumbling window on streaming tables ...

2017-02-13 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3252 The v3 PR gets the best from both of the worlds -- the code generator will throw exceptions if the queries actually execute the `rowtime()`. Essentially it rewrites the project and the

[jira] [Commented] (FLINK-5723) Use "Used" instead of "Initial" to make taskmanager tag more readable

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864795#comment-15864795 ] ASF GitHub Bot commented on FLINK-5723: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3274: [FLINK-5723][UI]Use Used instead of Initial to make taskm...

2017-02-13 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3274 @zentol Is it ok to go? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Updated] (FLINK-5486) Lack of synchronization in BucketingSink#handleRestoredBucketState()

2017-02-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5486: -- Description: Here is related code: {code}

[jira] [Updated] (FLINK-5488) yarnClient should be closed in AbstractYarnClusterDescriptor for error conditions

2017-02-13 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-5488: -- Description: Here is one example: {code} if(jobManagerMemoryMb > maxRes.getMemory() ) {

[jira] [Commented] (FLINK-5624) Support tumbling window on streaming tables in the SQL API

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864614#comment-15864614 ] ASF GitHub Bot commented on FLINK-5624: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3252: [FLINK-5624] Support tumbling window on streaming ...

2017-02-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3252#discussion_r100918614 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala --- @@ -290,6 +291,15 @@ object

[jira] [Commented] (FLINK-5406) add normalization phase for predicate logical plan rewriting between decorrelate query phase and volcano optimization phase

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864607#comment-15864607 ] ASF GitHub Bot commented on FLINK-5406: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3101: [FLINK-5406] [table] add normalization phase for predicat...

2017-02-13 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3101 Thanks for the update @godfreyhe! PR looks good to me and can be merged IMO. @godfreyhe, can you rebase the PR to the current master? @twalthr, do you want to have another look as

[jira] [Commented] (FLINK-5624) Support tumbling window on streaming tables in the SQL API

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864603#comment-15864603 ] ASF GitHub Bot commented on FLINK-5624: --- Github user haohui commented on a diff in the pull request:

[GitHub] flink pull request #3252: [FLINK-5624] Support tumbling window on streaming ...

2017-02-13 Thread haohui
Github user haohui commented on a diff in the pull request: https://github.com/apache/flink/pull/3252#discussion_r100917108 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala --- @@ -290,6 +291,15 @@ object

[GitHub] flink pull request #3301: [FLINK-5788] [docs] Improve documentation of FileS...

2017-02-13 Thread StephanEwen
GitHub user StephanEwen opened a pull request: https://github.com/apache/flink/pull/3301 [FLINK-5788] [docs] Improve documentation of FileSystem and spell out the data persistence contract This writes down the contract that the Flink `FileSystem` and `FSDataOutputStream`

[jira] [Commented] (FLINK-5788) Document assumptions about File Systems and persistence

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864489#comment-15864489 ] ASF GitHub Bot commented on FLINK-5788: --- GitHub user StephanEwen opened a pull request:

[jira] [Commented] (FLINK-4997) Extending Window Function Metadata

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864476#comment-15864476 ] ASF GitHub Bot commented on FLINK-4997: --- Github user VenturaDelMonte commented on the issue:

[GitHub] flink issue #3285: [FLINK-4997] [streaming] Introduce ProcessWindowFunction

2017-02-13 Thread VenturaDelMonte
Github user VenturaDelMonte commented on the issue: https://github.com/apache/flink/pull/3285 I checked the code and it looks fine according to me. I see you are dealing with RichFunction inheritance in wrapper classes. It is something that bothered me too when I was working on the

[jira] [Created] (FLINK-5789) Make Bucketing Sink independent of Hadoop's FileSysten

2017-02-13 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-5789: --- Summary: Make Bucketing Sink independent of Hadoop's FileSysten Key: FLINK-5789 URL: https://issues.apache.org/jira/browse/FLINK-5789 Project: Flink Issue

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864356#comment-15864356 ] ASF GitHub Bot commented on FLINK-5092: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864355#comment-15864355 ] ASF GitHub Bot commented on FLINK-5092: --- Github user rmetzger commented on a diff in the pull

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2017-02-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r100888724 --- Diff: flink-test-utils-parent/flink-test-utils-coverage/pom.xml --- @@ -0,0 +1,393 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2017-02-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r100888652 --- Diff: flink-examples/pom.xml --- @@ -69,4 +69,12 @@ under the License. flink-examples-batch flink-examples-streaming

[GitHub] flink pull request #2836: [FLINK-5092] Add maven profile with code coverage ...

2017-02-13 Thread rmetzger
Github user rmetzger commented on a diff in the pull request: https://github.com/apache/flink/pull/2836#discussion_r100888521 --- Diff: flink-connectors/flink-connector-cassandra/pom.xml --- @@ -65,6 +68,7 @@ under the License.

[jira] [Commented] (FLINK-5092) Add integration with Sonarqube and code coverage

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864354#comment-15864354 ] ASF GitHub Bot commented on FLINK-5092: --- Github user rmetzger commented on a diff in the pull

[jira] [Commented] (FLINK-5631) [yarn] Support downloading additional jars from non-HDFS paths

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864315#comment-15864315 ] ASF GitHub Bot commented on FLINK-5631: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-5690) protobuf is not shaded properly

2017-02-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864312#comment-15864312 ] Robert Metzger commented on FLINK-5690: --- Feel free to review my pull request. > protobuf is not

[jira] [Created] (FLINK-5788) Document assumptions about File Systems and persistence

2017-02-13 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-5788: --- Summary: Document assumptions about File Systems and persistence Key: FLINK-5788 URL: https://issues.apache.org/jira/browse/FLINK-5788 Project: Flink Issue

[GitHub] flink pull request #3300: [FLINK-5690][docs] Add note on shading to best pra...

2017-02-13 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/3300 [FLINK-5690][docs] Add note on shading to best practices guide You can merge this pull request into a Git repository by running: $ git pull https://github.com/rmetzger/flink flink5690

[GitHub] flink pull request #3283: [FLINK-5729][EXAMPLES]add hostname option to be mo...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3283 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Closed] (FLINK-5631) [yarn] Support downloading additional jars from non-HDFS paths

2017-02-13 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-5631. --- > [yarn] Support downloading additional jars from non-HDFS paths >

[jira] [Commented] (FLINK-5729) add hostname option in SocketWindowWordCount example to be more convenient

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864314#comment-15864314 ] ASF GitHub Bot commented on FLINK-5729: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-5729) add hostname option in SocketWindowWordCount example to be more convenient

2017-02-13 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-5729. --- > add hostname option in SocketWindowWordCount example to be more convenient >

[jira] [Resolved] (FLINK-5631) [yarn] Support downloading additional jars from non-HDFS paths

2017-02-13 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-5631. - Resolution: Fixed Fix Version/s: 1.3.0 Fixed in 186b12309b540f82a055be28f3f005dce4b8cf46

[GitHub] flink pull request #3202: [FLINK-5631] [yarn] Support downloading additional...

2017-02-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (FLINK-5729) add hostname option in SocketWindowWordCount example to be more convenient

2017-02-13 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-5729. - Resolution: Fixed Fix Version/s: 1.3.0 Fixed via 30c5b771a7943e981dd5f67131c932fdb204fbc2

[jira] [Commented] (FLINK-5690) protobuf is not shaded properly

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864303#comment-15864303 ] ASF GitHub Bot commented on FLINK-5690: --- GitHub user rmetzger opened a pull request:

[jira] [Commented] (FLINK-5690) protobuf is not shaded properly

2017-02-13 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864266#comment-15864266 ] Robert Metzger commented on FLINK-5690: --- 1) I'll open a pull request. Regarding 2) This is

[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...

2017-02-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3196#discussion_r100851830 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to

[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...

2017-02-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3196#discussion_r100851572 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-5566) Introduce structure to hold table and column level statistics

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864061#comment-15864061 ] ASF GitHub Bot commented on FLINK-5566: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5566) Introduce structure to hold table and column level statistics

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864060#comment-15864060 ] ASF GitHub Bot commented on FLINK-5566: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3196: [FLINK-5566] [Table API & SQL]Introduce structure ...

2017-02-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3196#discussion_r100851670 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/stats/ColumnStats.scala --- @@ -0,0 +1,52 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-5566) Introduce structure to hold table and column level statistics

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864062#comment-15864062 ] ASF GitHub Bot commented on FLINK-5566: --- Github user fhueske commented on a diff in the pull

[jira] [Comment Edited] (FLINK-1730) Add a FlinkTools.persist style method to the Data Set.

2017-02-13 Thread Kate Eri (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-1730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15863650#comment-15863650 ] Kate Eri edited comment on FLINK-1730 at 2/13/17 5:36 PM: -- Hello [~StephanEwen],

[GitHub] flink pull request #3271: [FLINK-5710] Add ProcTime() function to indicate S...

2017-02-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3271#discussion_r100849148 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/validate/FunctionCatalog.scala --- @@ -190,11 +192,14 @@ object FunctionCatalog

[jira] [Commented] (FLINK-5710) Add ProcTime() function to indicate StreamSQL

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864030#comment-15864030 ] ASF GitHub Bot commented on FLINK-5710: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5624) Support tumbling window on streaming tables in the SQL API

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864012#comment-15864012 ] ASF GitHub Bot commented on FLINK-5624: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5624) Support tumbling window on streaming tables in the SQL API

2017-02-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15864010#comment-15864010 ] ASF GitHub Bot commented on FLINK-5624: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3252: [FLINK-5624] Support tumbling window on streaming ...

2017-02-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3252#discussion_r100845516 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/streaming.scala --- @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] flink pull request #3252: [FLINK-5624] Support tumbling window on streaming ...

2017-02-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3252#discussion_r100844487 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/expressions/streaming.scala --- @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] flink pull request #3252: [FLINK-5624] Support tumbling window on streaming ...

2017-02-13 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3252#discussion_r100837291 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/FunctionGenerator.scala --- @@ -290,6 +291,15 @@ object

  1   2   3   >