[
https://issues.apache.org/jira/browse/FLINK-5690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15864303#comment-15864303
]
ASF GitHub Bot commented on FLINK-5690:
---------------------------------------
GitHub user rmetzger opened a pull request:
https://github.com/apache/flink/pull/3300
[FLINK-5690][docs] Add note on shading to best practices guide
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rmetzger/flink flink5690
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3300.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3300
----
commit 504cf17d28932921da9b27ea924d777107b248ed
Author: Robert Metzger <[email protected]>
Date: 2017-02-13T19:50:23Z
[FLINK-5690][docs] Add note on shading to best practices guide
----
> protobuf is not shaded properly
> -------------------------------
>
> Key: FLINK-5690
> URL: https://issues.apache.org/jira/browse/FLINK-5690
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.1.4, 1.3.0
> Reporter: Andrey
> Assignee: Robert Metzger
>
> Currently distributive contains com/google/protobuf package. Without proper
> shading client code could fail with:
> {code}
> Caused by: java.lang.IllegalAccessError: tried to access method
> com.google.protobuf.XXXX
> {code}
> Steps to reproduce:
> * create job class "com.google.protobuf.TestClass"
> * call com.google.protobuf.TextFormat.escapeText(String) method from this
> class
> * deploy job to flink cluster (usign web console for example)
> * run job. In logs IllegalAccessError.
> Issue in package protected method and different classloaders. TestClass
> loaded by FlinkUserCodeClassLoader, but TextFormat class loaded by
> sun.misc.Launcher$AppClassLoader
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
