[GitHub] flink issue #3459: [FLINK-5654] Add processing time OVER RANGE BETWEEN x PRE...

2017-03-03 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3459 @stefanobortoli One PR should has only one commit as soon as possible. If having so many commit, it's hard to review.. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895571#comment-15895571 ] ASF GitHub Bot commented on FLINK-5654: --- Github user shijinkui commented on the issue:

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895569#comment-15895569 ] ASF GitHub Bot commented on FLINK-5956: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3470: [FLINK-5956] [table] Add retract method for aggregateFunc...

2017-03-03 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3470 Hi @shaoxuan-wang, yes. That's a very good point. We should definitely add non-retractable `MIN` and `MAX` aggregates. Would be good to have them now to use them in batch queries. --- If your

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895566#comment-15895566 ] ASF GitHub Bot commented on FLINK-5956: --- Github user fhueske commented on the issue:

[GitHub] flink issue #3470: [FLINK-5956] [table] Add retract method for aggregateFunc...

2017-03-03 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/3470 Thanks for the PR @shaoxuan-wang. I haven't had a detailed look yet. I think we also need non-retract versions of `MIN` and `MAX`. The retracted version cannot be used to compute unbounded OVER

[GitHub] flink pull request #3459: [FLINK-5654] Add processing time OVER RANGE BETWEE...

2017-03-03 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/3459#discussion_r104282393 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/plan/nodes/datastream/DataStreamProcTimeTimeAggregate.java --- @@ -0,0 +1,162

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895563#comment-15895563 ] ASF GitHub Bot commented on FLINK-5654: --- Github user shijinkui commented on a diff in the pull

[jira] [Commented] (FLINK-5963) Remove preparation mapper of DataSetAggregate

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895561#comment-15895561 ] ASF GitHub Bot commented on FLINK-5963: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104282353 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -87,47 +89,67 @@ class

[jira] [Commented] (FLINK-5963) Remove preparation mapper of DataSetAggregate

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895558#comment-15895558 ] ASF GitHub Bot commented on FLINK-5963: --- Github user shaoxuan-wang commented on a diff in the pull

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on a diff in the pull request: https://github.com/apache/flink/pull/3472#discussion_r104282131 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala --- @@ -87,47 +89,67 @@ class

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895553#comment-15895553 ] ASF GitHub Bot commented on FLINK-4460: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #3438: [FLINK-4460] Allow ProcessFunction on non-keyed streams

2017-03-03 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/3438 @rmetzger Yes, it's unfortunate that in our model not all elements always have a timestamp. The other alternative is throwing an exception when trying to access a non-existing timestamp. --- If

[jira] [Commented] (FLINK-4810) Checkpoint Coordinator should fail ExecutionGraph after "n" unsuccessful checkpoints

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895513#comment-15895513 ] ASF GitHub Bot commented on FLINK-4810: --- Github user ramkrish86 commented on the issue:

[GitHub] flink issue #3334: FLINK-4810 Checkpoint Coordinator should fail ExecutionGr...

2017-03-03 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3334 Ping for reviews here!!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-5833) Support for Hive GenericUDF

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895498#comment-15895498 ] ASF GitHub Bot commented on FLINK-5833: --- GitHub user clarkyzl opened a pull request:

[GitHub] flink pull request #3473: [FLINK-5833] [table] Support for Hive GenericUDF

2017-03-03 Thread clarkyzl
GitHub user clarkyzl opened a pull request: https://github.com/apache/flink/pull/3473 [FLINK-5833] [table] Support for Hive GenericUDF Type: New Feature Priority: Major Components: table, udf Problem definition: Make Flink call Hive User-Defined Functions, support for

[GitHub] flink pull request #3408: [FLINK-5903][YARN]respect taskmanager.numberOfTask...

2017-03-03 Thread shijinkui
Github user shijinkui commented on a diff in the pull request: https://github.com/apache/flink/pull/3408#discussion_r104277608 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -317,6 +319,10 @@ public AbstractYarnClusterDescriptor

[jira] [Commented] (FLINK-5903) taskmanager.numberOfTaskSlots and yarn.containers.vcores did not work well in YARN mode

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895480#comment-15895480 ] ASF GitHub Bot commented on FLINK-5903: --- Github user shijinkui commented on a diff in the pull

[jira] [Closed] (FLINK-5586) Extend TableProgramsTestBase for object reuse modes

2017-03-03 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-5586. - > Extend TableProgramsTestBase for object reuse modes > --- >

[jira] [Resolved] (FLINK-5586) Extend TableProgramsTestBase for object reuse modes

2017-03-03 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young resolved FLINK-5586. --- Resolution: Implemented > Extend TableProgramsTestBase for object reuse modes >

[jira] [Updated] (FLINK-5586) Extend TableProgramsTestBase for object reuse modes

2017-03-03 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-5586: -- Fix Version/s: 1.3.0 > Extend TableProgramsTestBase for object reuse modes >

[jira] [Commented] (FLINK-5586) Extend TableProgramsTestBase for object reuse modes

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895399#comment-15895399 ] ASF GitHub Bot commented on FLINK-5586: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3339: [FLINK-5586] [table] Extend TableProgramsClusterTe...

2017-03-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895382#comment-15895382 ] ASF GitHub Bot commented on FLINK-5956: --- Github user shaoxuan-wang commented on the issue:

[GitHub] flink issue #3470: [FLINK-5956] [table] Add retract method for aggregateFunc...

2017-03-03 Thread shaoxuan-wang
Github user shaoxuan-wang commented on the issue: https://github.com/apache/flink/pull/3470 @fhueske, we should add different built-in aggregates for the ones that are not easy to be retracted (for instance Max and Min), one as withRetract(used for over window as # of items are

[GitHub] flink pull request #3472: [FLINK-5963] [table] Remove prepare mapper of Data...

2017-03-03 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/3472 [FLINK-5963] [table] Remove prepare mapper of DataSetAggregate. We remove the preparation mapper to - save one operator - be able to apply `AggregateFunction.accumulate()` in a

[jira] [Commented] (FLINK-5963) Remove preparation mapper of DataSetAggregate

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895178#comment-15895178 ] ASF GitHub Bot commented on FLINK-5963: --- GitHub user fhueske opened a pull request:

[jira] [Commented] (FLINK-5722) Implement DISTINCT as dedicated operator

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895177#comment-15895177 ] ASF GitHub Bot commented on FLINK-5722: --- GitHub user fhueske opened a pull request:

[GitHub] flink pull request #3471: [FLINK-5722] [table] Add dedicated DataSetDistinct...

2017-03-03 Thread fhueske
GitHub user fhueske opened a pull request: https://github.com/apache/flink/pull/3471 [FLINK-5722] [table] Add dedicated DataSetDistinct operator. A dedicated DISTINCT operator is more efficient because we can use a `ReduceFunction` which (optionally) support hash-based combining.

[jira] [Assigned] (FLINK-5963) Remove preparation mapper of DataSetAggregate

2017-03-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-5963: Assignee: Fabian Hueske > Remove preparation mapper of DataSetAggregate >

[jira] [Created] (FLINK-5963) Remove preparation mapper of DataSetAggregate

2017-03-03 Thread Fabian Hueske (JIRA)
Fabian Hueske created FLINK-5963: Summary: Remove preparation mapper of DataSetAggregate Key: FLINK-5963 URL: https://issues.apache.org/jira/browse/FLINK-5963 Project: Flink Issue Type:

[jira] [Assigned] (FLINK-5722) Implement DISTINCT as dedicated operator

2017-03-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-5722: Assignee: Fabian Hueske > Implement DISTINCT as dedicated operator >

[jira] [Commented] (FLINK-5838) Print shell script usage

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894992#comment-15894992 ] ASF GitHub Bot commented on FLINK-5838: --- Github user rmetzger commented on the issue:

[jira] [Commented] (FLINK-4460) Side Outputs in Flink

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894999#comment-15894999 ] ASF GitHub Bot commented on FLINK-4460: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #3438: [FLINK-4460] Allow ProcessFunction on non-keyed streams

2017-03-03 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3438 I looked over the changes and didn't find anything critical. The only thing that made me thinking was the boxed `Long` type for the timestamp(). I assume you decided for this approach to signal

[GitHub] flink issue #3352: [FLINK-5838] [scripts] Print shell script usage

2017-03-03 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3352 Changes look good in my opinion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[jira] [Commented] (FLINK-5067) Make Flink compile with 1.8 Java compiler

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894978#comment-15894978 ] ASF GitHub Bot commented on FLINK-5067: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #2804: [FLINK-5067] Make Flink compile with 1.8 Java compiler

2017-03-03 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/2804 Looks good to merge. I'm currently verifying the change, then, I'll merge it: https://travis-ci.org/rmetzger/flink/builds/207494237 --- If your project is set up for it, you can reply to

[jira] [Commented] (FLINK-4286) Have Kafka examples that use the Kafka 0.9 connector

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894967#comment-15894967 ] ASF GitHub Bot commented on FLINK-4286: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #3270: [FLINK-4286] Have Kafka examples that use the Kafka 0.9 c...

2017-03-03 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3270 Hi @mylog00, thanks a lot for your contribution. I wonder if it makes more sense to just upgrade the existing Kafka examples to use Kafka 0.9 instead of having two examples that are almost

[jira] [Commented] (FLINK-4286) Have Kafka examples that use the Kafka 0.9 connector

2017-03-03 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894965#comment-15894965 ] Robert Metzger commented on FLINK-4286: --- I would vote to not have two examples that basically differ

[jira] [Commented] (FLINK-5598) Return jar name when jar is uploaded

2017-03-03 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894932#comment-15894932 ] Robert Metzger commented on FLINK-5598: --- Thanks a lot for fixing this issue. I assigned the JIRA to

[jira] [Commented] (FLINK-5598) Return jar name when jar is uploaded

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894933#comment-15894933 ] ASF GitHub Bot commented on FLINK-5598: --- Github user rmetzger commented on the issue:

[jira] [Assigned] (FLINK-5598) Return jar name when jar is uploaded

2017-03-03 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-5598: - Assignee: Fabian Wollert > Return jar name when jar is uploaded >

[GitHub] flink issue #3469: [FLINK-5598] return filename after jar upload

2017-03-03 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3469 Good change. +1 to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-5956) Add retract method into the aggregateFunction

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894749#comment-15894749 ] ASF GitHub Bot commented on FLINK-5956: --- GitHub user shaoxuan-wang opened a pull request:

[GitHub] flink pull request #3470: [FLINK-5956] [table] Add retract method for aggreg...

2017-03-03 Thread shaoxuan-wang
GitHub user shaoxuan-wang opened a pull request: https://github.com/apache/flink/pull/3470 [FLINK-5956] [table] Add retract method for aggregateFunction This PR adds retraction method for AggregateFunction, it also implements retract methods as well as test cases for all built-in

[jira] [Created] (FLINK-5962) Cancel checkpoint canceller tasks in CheckpointCoordinator

2017-03-03 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-5962: Summary: Cancel checkpoint canceller tasks in CheckpointCoordinator Key: FLINK-5962 URL: https://issues.apache.org/jira/browse/FLINK-5962 Project: Flink

[jira] [Created] (FLINK-5961) Queryable State is broken for HeapKeyedStateBackend

2017-03-03 Thread Stefan Richter (JIRA)
Stefan Richter created FLINK-5961: - Summary: Queryable State is broken for HeapKeyedStateBackend Key: FLINK-5961 URL: https://issues.apache.org/jira/browse/FLINK-5961 Project: Flink Issue

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104188272 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java --- @@ -0,0 +1,63 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104156636 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104176638 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala --- @@ -0,0 +1,166 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104184922 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,108 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104158740 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104160007 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104166130 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogTable.scala --- @@ -0,0 +1,73 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104191673 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala --- @@ -68,6 +62,90 @@ object CommonTestData {

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104178022 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala --- @@ -0,0 +1,166 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104022427 --- Diff: flink-libraries/flink-table/pom.xml --- @@ -92,7 +92,12 @@ under the License. - +

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104167894 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,108 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104159675 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104194149 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala --- @@ -68,6 +62,90 @@ object CommonTestData {

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104159480 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104167970 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,108 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104177526 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalogSchema.scala --- @@ -0,0 +1,166 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104163154 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,108 @@ +/* + * Licensed to

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104158678 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/CatalogTableHelper.scala --- @@ -0,0 +1,139 @@ +/* + * Licensed

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104150546 --- Diff: flink-libraries/flink-table/src/main/java/org/apache/flink/table/annotation/ExternalCatalogCompatible.java --- @@ -0,0 +1,63 @@ +/* + *

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104191562 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/utils/CommonTestData.scala --- @@ -68,6 +62,90 @@ object CommonTestData {

[GitHub] flink pull request #3406: [flink-5568] [Table API & SQL]Introduce interface ...

2017-03-03 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3406#discussion_r104185348 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/catalog/ExternalCatalog.scala --- @@ -0,0 +1,108 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-5598) Return jar name when jar is uploaded

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894688#comment-15894688 ] ASF GitHub Bot commented on FLINK-5598: --- GitHub user drummerwolli opened a pull request:

[GitHub] flink pull request #3469: [FLINK-5598] return filename after jar upload

2017-03-03 Thread drummerwolli
GitHub user drummerwolli opened a pull request: https://github.com/apache/flink/pull/3469 [FLINK-5598] return filename after jar upload We use the Flink Web Backend to control Flink Jobs running in our Cluster. We would like to have more control in the API. This is the first change

[jira] [Commented] (FLINK-3089) OperatorState timeout

2017-03-03 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894682#comment-15894682 ] Aljoscha Krettek commented on FLINK-3089: - [~StephanEwen] you were also a great proponent of state

[jira] [Closed] (FLINK-4275) Generic Folding, Reducing and List states behave differently from other state backends

2017-03-03 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-4275. --- Resolution: Not A Problem Not a problem anymore since they are not in the code base anymore.

[jira] [Closed] (FLINK-5958) Asynchronous snapshots for heap-based keyed state backends

2017-03-03 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-5958. --- Resolution: Duplicate [~srichter] please transfer the text and PR to the older issue. (If you

[jira] [Created] (FLINK-5960) Make CheckpointCoordinator less blocking

2017-03-03 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-5960: Summary: Make CheckpointCoordinator less blocking Key: FLINK-5960 URL: https://issues.apache.org/jira/browse/FLINK-5960 Project: Flink Issue Type:

[jira] [Commented] (FLINK-3387) Replace all ByteArrayOutputStream and DataOutputStream use in State Backends by DataOutputSerializer

2017-03-03 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894614#comment-15894614 ] Stefan Richter commented on FLINK-3387: --- [~sbcd90] are you still working on this? [~StephanEwen] I

[jira] [Commented] (FLINK-5219) Add non-grouped session windows for batch tables

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894609#comment-15894609 ] ASF GitHub Bot commented on FLINK-5219: --- Github user asfgit closed the pull request at:

[jira] [Closed] (FLINK-5219) Add non-grouped session windows for batch tables

2017-03-03 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-5219. Resolution: Implemented Fix Version/s: 1.3.0 Implemented with

[GitHub] flink pull request #3266: [FLINK-5219][TableAPI] Add non-grouped session...

2017-03-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-3089) OperatorState timeout

2017-03-03 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894606#comment-15894606 ] Stefan Richter commented on FLINK-3089: --- Does this solve the problem and we can close this issue? >

[jira] [Commented] (FLINK-4760) Kafka 09 Consumer failed to initialize state because of corrupted operator state and not able to recover

2017-03-03 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894605#comment-15894605 ] Stefan Richter commented on FLINK-4760: --- [~zhenzhongxu] is this still a problem or can we close this

[jira] [Commented] (FLINK-4275) Generic Folding, Reducing and List states behave differently from other state backends

2017-03-03 Thread Stefan Richter (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894595#comment-15894595 ] Stefan Richter commented on FLINK-4275: --- One more ping on this. Can I close this issue? > Generic

[jira] [Commented] (FLINK-5904) jobmanager.heap.mb and taskmanager.heap.mb not work in YARN mode

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894555#comment-15894555 ] ASF GitHub Bot commented on FLINK-5904: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3414: [FLINK-5904][YARN]make jobmanager.heap.mb and task...

2017-03-03 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3414#discussion_r104174440 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -110,7 +110,12 @@ public static final String

[GitHub] flink pull request #3414: [FLINK-5904][YARN]make jobmanager.heap.mb and task...

2017-03-03 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3414#discussion_r104174086 --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java --- @@ -306,12 +308,16 @@ public AbstractYarnClusterDescriptor

[jira] [Commented] (FLINK-5904) jobmanager.heap.mb and taskmanager.heap.mb not work in YARN mode

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894554#comment-15894554 ] ASF GitHub Bot commented on FLINK-5904: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Created] (FLINK-5959) Verify that mesos-appmaster.sh respects env.java.opts(.jobmanager)

2017-03-03 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-5959: Summary: Verify that mesos-appmaster.sh respects env.java.opts(.jobmanager) Key: FLINK-5959 URL: https://issues.apache.org/jira/browse/FLINK-5959 Project: Flink

[jira] [Commented] (FLINK-5916) make env.java.opts.jobmanager and env.java.opts.taskmanager working in YARN mode

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894531#comment-15894531 ] ASF GitHub Bot commented on FLINK-5916: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3415: [FLINK-5916][YARN]make env.java.opts.jobmanager an...

2017-03-03 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3415#discussion_r104170895 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java --- @@ -360,6 +360,7 @@ public static String

[jira] [Commented] (FLINK-5916) make env.java.opts.jobmanager and env.java.opts.taskmanager working in YARN mode

2017-03-03 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894525#comment-15894525 ] Till Rohrmann commented on FLINK-5916: -- I think the {{mesos-taskmanager.sh}} script does but not the

[jira] [Commented] (FLINK-5936) Can't pass keyed vectors to KNN join algorithm

2017-03-03 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894510#comment-15894510 ] Till Rohrmann commented on FLINK-5936: -- Hi Alex, what do you mean by keyed vectors? Did you mean

[jira] [Updated] (FLINK-5936) Can't pass keyed vectors to KNN join algorithm

2017-03-03 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-5936: - Priority: Minor (was: Major) > Can't pass keyed vectors to KNN join algorithm >

[jira] [Commented] (FLINK-5949) Flink on YARN checks for Kerberos credentials for non-Kerberos authentication methods

2017-03-03 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894493#comment-15894493 ] Till Rohrmann commented on FLINK-5949: -- This should also be relevant for {{1.3.0}}, right? > Flink

[GitHub] flink pull request #3304: [FLINK-5791] [runtime] [FLIP-6] Slots should be st...

2017-03-03 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3304#discussion_r104160029 --- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java --- @@ -168,6 +168,11 @@ public static final String

[jira] [Commented] (FLINK-5791) Resource should be strictly matched when allocating for yarn

2017-03-03 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894462#comment-15894462 ] ASF GitHub Bot commented on FLINK-5791: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3304: [FLINK-5791] [runtime] [FLIP-6] Slots should be st...

2017-03-03 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3304#discussion_r104159696 --- Diff: flink-yarn/src/test/java/org/apache/flink/yarn/YarnResourceManagerTest.java --- @@ -0,0 +1,94 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3304: [FLINK-5791] [runtime] [FLIP-6] Slots should be st...

2017-03-03 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3304#discussion_r104160736 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/types/ResourceProfile.java --- @@ -119,6 +122,9 @@ public boolean

  1   2   3   >