[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940665#comment-15940665 ] ASF GitHub Bot commented on FLINK-6117: --- Github user EronWright commented on the issue:

[GitHub] flink issue #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disable' work...

2017-03-24 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/3600 To recap, when the ZK server is configured to use SASL, the client is challenged accordingly. The client checks for a login entry in the JAAS config to obtain a kerberos credential, and issues a

[jira] [Closed] (FLINK-6128) Optimize JVM options for improve test performance

2017-03-24 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-6128. - Resolution: Implemented Implemented in 976e03c1ee0c1ac03e7755aef6a38ee0abc35b2f > Optimize JVM options

[jira] [Closed] (FLINK-5890) GatherSumApply broken when object reuse enabled

2017-03-24 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-5890. - Resolution: Fixed Fixed in 524b20f2db70fc4afba3a539fbf249c6d768ab4f > GatherSumApply broken when object

[jira] [Commented] (FLINK-5890) GatherSumApply broken when object reuse enabled

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940657#comment-15940657 ] ASF GitHub Bot commented on FLINK-5890: --- Github user asfgit closed the pull request at:

[jira] [Updated] (FLINK-6128) Optimize JVM options for improve test performance

2017-03-24 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-6128: -- Fix Version/s: 1.3.0 > Optimize JVM options for improve test performance >

[jira] [Commented] (FLINK-6128) Optimize JVM options for improve test performance

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940656#comment-15940656 ] ASF GitHub Bot commented on FLINK-6128: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3515: [FLINK-5890] [gelly] GatherSumApply broken when ob...

2017-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3515 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] flink pull request #3571: [FLINK-6128] Optimize JVM options for improve test...

2017-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3571 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940649#comment-15940649 ] ASF GitHub Bot commented on FLINK-5654: --- Github user rtudoran commented on the issue:

[GitHub] flink issue #3607: [FLINK-5654] - Add processing time OVER RANGE BETWEEN x P...

2017-03-24 Thread rtudoran
Github user rtudoran commented on the issue: https://github.com/apache/flink/pull/3607 @fhueske @sunjincheng121 @stefanobortoli I have made an implementation also for implementing the management of the events in the buffer based on MapState as suggested in #3590 I also

[jira] [Commented] (FLINK-5654) Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940640#comment-15940640 ] ASF GitHub Bot commented on FLINK-5654: --- GitHub user rtudoran opened a pull request:

[GitHub] flink pull request #3607: [FLINK-5654] - Add processing time OVER RANGE BETW...

2017-03-24 Thread rtudoran
GitHub user rtudoran opened a pull request: https://github.com/apache/flink/pull/3607 [FLINK-5654] - Add processing time OVER RANGE BETWEEN x PRECEDING aggregation to SQL processing time with MapState for event handling Thanks for contributing to Apache Flink. Before you

[jira] [Commented] (FLINK-6169) yarnClient should be stopped in AbstractYarnClusterDescriptor in case of error

2017-03-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940609#comment-15940609 ] Till Rohrmann commented on FLINK-6169: -- Good point [~te...@apache.org]. Do you wanna take a stab at

[jira] [Commented] (FLINK-5715) Asynchronous snapshotting for HeapKeyedStateBackend

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940608#comment-15940608 ] ASF GitHub Bot commented on FLINK-5715: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #3602: [FLINK-5715] Asynchronous snapshots for heap keyed state ...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3602 Thanks for the review, @StephanEwen ! A agree with undoing `MemoryStateBackend` and `MathUtil` as proposed, but would argue for keeping the change in `TimeWindow`. This change fixes skew

[jira] [Commented] (FLINK-5715) Asynchronous snapshotting for HeapKeyedStateBackend

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940602#comment-15940602 ] ASF GitHub Bot commented on FLINK-5715: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #3602: [FLINK-5715] Asynchronous snapshots for heap keyed...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3602#discussion_r107935639 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/AbstractEventTimeWindowCheckpointingITCase.java --- @@ -115,6 +117,14 @@

[jira] [Commented] (FLINK-5715) Asynchronous snapshotting for HeapKeyedStateBackend

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940598#comment-15940598 ] ASF GitHub Bot commented on FLINK-5715: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #3602: [FLINK-5715] Asynchronous snapshots for heap keyed...

2017-03-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3602#discussion_r107931282 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/AbstractEventTimeWindowCheckpointingITCase.java --- @@ -115,6 +117,14 @@ public

[jira] [Commented] (FLINK-6107) Add custom checkstyle for flink-streaming-java

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940555#comment-15940555 ] ASF GitHub Bot commented on FLINK-6107: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #3567: [FLINK-6107] Add custom checkstyle for flink-strea...

2017-03-24 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/3567#discussion_r10860 --- Diff: tools/maven/strict-checkstyle.xml --- @@ -0,0 +1,550 @@ + + +http://www.puppycrawl.com/dtds/configuration_1_3.dtd;> + + +

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940546#comment-15940546 ] ASF GitHub Bot commented on FLINK-6117: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-6117) 'zookeeper.sasl.disable' not takes effet when starting CuratorFramework

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940547#comment-15940547 ] ASF GitHub Bot commented on FLINK-6117: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disable' work...

2017-03-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3600 @EronWright @vijikarthi If you find the time, what do you think about this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] flink issue #3600: [FLINK-6117]Make setting of 'zookeeper.sasl.disable' work...

2017-03-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3600 Yes, CI seems to be unstable. Can you try to push again to the branch (maybe change the commit message, force push then) to retrigger the CI? --- If your project is set up for it, you

[jira] [Commented] (FLINK-6174) Introduce a leader election service in yarn mode to make JobManager always available

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940522#comment-15940522 ] ASF GitHub Bot commented on FLINK-6174: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3599: [FLINK-6174][HA]introduce a new election service to make ...

2017-03-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3599 I would suggest to fix this the following way: - There is an upcoming patch that makes the Flink codebase use the `HighAvailabilityServices` properly in all places. - We

[jira] [Commented] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940518#comment-15940518 ] ASF GitHub Bot commented on FLINK-6103: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #3598: [FLINK-6103] LocalFileSystem rename() uses File.re...

2017-03-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3598#discussion_r107925602 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/local/LocalFileSystem.java --- @@ -262,8 +265,13 @@ public FSDataOutputStream create(

[jira] [Commented] (FLINK-6128) Optimize JVM options for improve test performance

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940503#comment-15940503 ] ASF GitHub Bot commented on FLINK-6128: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3571: [FLINK-6128] Optimize JVM options for improve test perfor...

2017-03-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3571 Merging ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] flink pull request #3605: [FLINK-6181][Start scripts] Fix regex in start scr...

2017-03-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3605#discussion_r107923309 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -164,7 +164,7 @@ watchdog () { # Check the final fat jar for illegal artifacts

[jira] [Commented] (FLINK-6181) Zookeeper scripts use invalid regex

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940501#comment-15940501 ] ASF GitHub Bot commented on FLINK-6181: --- Github user StephanEwen commented on a diff in the pull

[jira] [Commented] (FLINK-5998) Un-fat Hadoop from Flink fat jar

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940496#comment-15940496 ] ASF GitHub Bot commented on FLINK-5998: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3604: [FLINK-5998] Un-fat Hadoop from Flink fat jar

2017-03-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3604 @rmetzger, how would users know which Hadoop dependencies to include in `flink-dist-hadoop.jar`? Would they be copying multiple component jars into `lib/`? --- If your project is set up for it,

[GitHub] flink pull request #3605: [FLINK-6181][Start scripts] Fix regex in start scr...

2017-03-24 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3605#discussion_r107911796 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -164,7 +164,7 @@ watchdog () { # Check the final fat jar for illegal artifacts

[jira] [Commented] (FLINK-6181) Zookeeper scripts use invalid regex

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940436#comment-15940436 ] ASF GitHub Bot commented on FLINK-6181: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3605: [FLINK-6181][Start scripts] Fix regex in start scripts

2017-03-24 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3605 Thanks @rmetzger! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[jira] [Commented] (FLINK-6181) Zookeeper scripts use invalid regex

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940427#comment-15940427 ] ASF GitHub Bot commented on FLINK-6181: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6115) Need more helpful error message when trying to serialize a tuple with a null field

2017-03-24 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940376#comment-15940376 ] Greg Hogan commented on FLINK-6115: --- [~lukehutch] and [~fhueske], I'm not sure that versioning is

[jira] [Commented] (FLINK-5998) Un-fat Hadoop from Flink fat jar

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940331#comment-15940331 ] ASF GitHub Bot commented on FLINK-5998: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #3604: [FLINK-5998] Un-fat Hadoop from Flink fat jar

2017-03-24 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3604 I have tested this change locally, but it does not exactly what my intention was. What I want is that the `lib/` folder contains a `flink-dist.jar` with all the Flink runtime dependencies,

[jira] [Commented] (FLINK-6003) Add docker image based on the openjdk one (debian+alpine)

2017-03-24 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-6003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940298#comment-15940298 ] Ismaël Mejía commented on FLINK-6003: - Just for reference, the current work on this JIRA is pending

[jira] [Commented] (FLINK-5989) Protobuf in akka needs to be shaded

2017-03-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940291#comment-15940291 ] Robert Metzger commented on FLINK-5989: --- Yes, I've tried doing this some time ago, but without

[jira] [Commented] (FLINK-5989) Protobuf in akka needs to be shaded

2017-03-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940292#comment-15940292 ] Robert Metzger commented on FLINK-5989: --- Yes, I've tried doing this some time ago, but without

[jira] [Commented] (FLINK-6128) Optimize JVM options for improve test performance

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940287#comment-15940287 ] ASF GitHub Bot commented on FLINK-6128: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #3571: [FLINK-6128] Optimize JVM options for improve test perfor...

2017-03-24 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3571 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940258#comment-15940258 ] ASF GitHub Bot commented on FLINK-6103: --- Github user fpompermaier commented on a diff in the pull

[GitHub] flink pull request #3598: [FLINK-6103] LocalFileSystem rename() uses File.re...

2017-03-24 Thread fpompermaier
Github user fpompermaier commented on a diff in the pull request: https://github.com/apache/flink/pull/3598#discussion_r107894608 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/local/LocalFileSystem.java --- @@ -262,8 +265,13 @@ public FSDataOutputStream create(

[jira] [Commented] (FLINK-5990) Add [partitioned] event time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940193#comment-15940193 ] ASF GitHub Bot commented on FLINK-5990: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5990) Add [partitioned] event time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940196#comment-15940196 ] ASF GitHub Bot commented on FLINK-5990: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5990) Add [partitioned] event time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940195#comment-15940195 ] ASF GitHub Bot commented on FLINK-5990: --- Github user fhueske commented on a diff in the pull

[jira] [Commented] (FLINK-5990) Add [partitioned] event time OVER ROWS BETWEEN x PRECEDING aggregation to SQL

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940194#comment-15940194 ] ASF GitHub Bot commented on FLINK-5990: --- Github user fhueske commented on a diff in the pull

[GitHub] flink pull request #3585: [FLINK-5990][table]Add event time OVER ROWS BETWEE...

2017-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3585#discussion_r107877027 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/RowsClauseBoundedOverProcessFunction.scala --- @@ -0,0 +1,230

[GitHub] flink pull request #3585: [FLINK-5990][table]Add event time OVER ROWS BETWEE...

2017-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3585#discussion_r107879890 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -317,4 +422,24 @@ class SqlITCase

[GitHub] flink pull request #3585: [FLINK-5990][table]Add event time OVER ROWS BETWEE...

2017-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3585#discussion_r107866801 --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/datastream/DataStreamOverAggregate.scala --- @@ -130,32 +169,76 @@

[GitHub] flink pull request #3585: [FLINK-5990][table]Add event time OVER ROWS BETWEE...

2017-03-24 Thread fhueske
Github user fhueske commented on a diff in the pull request: https://github.com/apache/flink/pull/3585#discussion_r107880632 --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/SqlITCase.scala --- @@ -293,6 +297,107 @@ class SqlITCase

[jira] [Commented] (FLINK-6162) Fix bug in ByteArrayOutputStreamWithPos#setPosition

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940181#comment-15940181 ] ASF GitHub Bot commented on FLINK-6162: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #3595: [FLINK-6162]Fix bug in ByteArrayOutputStreamWithPos#setPo...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3595 I would suggest to introduce the analogue check also in `ByteArrayInputStreamWithPos`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[jira] [Closed] (FLINK-6182) Fix possible NPE in SourceStreamTask

2017-03-24 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ufuk Celebi closed FLINK-6182. -- Resolution: Fixed Fix Version/s: 1.2.1 1.3.0 Fixed in b703a24 (release-1.2),

[GitHub] flink pull request #3606: [FLINK-6182] Fix possible NPE in SourceStreamTask

2017-03-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3606 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6182) Fix possible NPE in SourceStreamTask

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940179#comment-15940179 ] ASF GitHub Bot commented on FLINK-6182: --- Github user asfgit closed the pull request at:

[jira] [Commented] (FLINK-6182) Fix possible NPE in SourceStreamTask

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940174#comment-15940174 ] ASF GitHub Bot commented on FLINK-6182: --- Github user rmetzger commented on the issue:

[GitHub] flink issue #3606: [FLINK-6182] Fix possible NPE in SourceStreamTask

2017-03-24 Thread rmetzger
Github user rmetzger commented on the issue: https://github.com/apache/flink/pull/3606 +1 to merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[jira] [Commented] (FLINK-6182) Fix possible NPE in SourceStreamTask

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940172#comment-15940172 ] ASF GitHub Bot commented on FLINK-6182: --- GitHub user uce opened a pull request:

[GitHub] flink pull request #3606: [FLINK-6182] Fix possible NPE in SourceStreamTask

2017-03-24 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/3606 [FLINK-6182] Fix possible NPE in SourceStreamTask A user ran into this and reported confusing NPEs in the logs. This could only happen if a source task is cancelled before it was invoked. You can

[jira] [Created] (FLINK-6182) Fix possible NPE in SourceStreamTask

2017-03-24 Thread Ufuk Celebi (JIRA)
Ufuk Celebi created FLINK-6182: -- Summary: Fix possible NPE in SourceStreamTask Key: FLINK-6182 URL: https://issues.apache.org/jira/browse/FLINK-6182 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940152#comment-15940152 ] ASF GitHub Bot commented on FLINK-6034: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for the sna...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3531 @shixiaogang I had a few more comments on the updated PR. When they are resolved, I think this can be merged immediately. --- If your project is set up for it, you can reply to this email

[jira] [Assigned] (FLINK-6181) Zookeeper scripts use invalid regex

2017-03-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger reassigned FLINK-6181: - Assignee: Robert Metzger > Zookeeper scripts use invalid regex >

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940151#comment-15940151 ] ASF GitHub Bot commented on FLINK-6034: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for ...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3531#discussion_r107877948 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/OperatorSnapshotResult.java --- @@ -30,7 +31,7 @@ */

[GitHub] flink pull request #3605: [FLINK-6181][Start scripts] Fix regex in start scr...

2017-03-24 Thread rmetzger
GitHub user rmetzger opened a pull request: https://github.com/apache/flink/pull/3605 [FLINK-6181][Start scripts] Fix regex in start scripts This issue has been reported by a user:

[jira] [Updated] (FLINK-6181) Zookeeper scripts use invalid regex

2017-03-24 Thread Robert Metzger (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-6181: -- Component/s: Startup Shell Scripts > Zookeeper scripts use invalid regex >

[jira] [Commented] (FLINK-6181) Zookeeper scripts use invalid regex

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940148#comment-15940148 ] ASF GitHub Bot commented on FLINK-6181: --- GitHub user rmetzger opened a pull request:

[GitHub] flink pull request #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for ...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3531#discussion_r107876739 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinatorTest.java --- @@ -57,6 +58,7 @@ import

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940145#comment-15940145 ] ASF GitHub Bot commented on FLINK-6034: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Created] (FLINK-6181) Zookeeper scripts use invalid regex

2017-03-24 Thread Robert Metzger (JIRA)
Robert Metzger created FLINK-6181: - Summary: Zookeeper scripts use invalid regex Key: FLINK-6181 URL: https://issues.apache.org/jira/browse/FLINK-6181 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940131#comment-15940131 ] ASF GitHub Bot commented on FLINK-6034: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for ...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3531#discussion_r107874660 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateHandle.java --- @@ -0,0 +1,40 @@ +/* + * Licensed to the

[GitHub] flink pull request #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for ...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3531#discussion_r107874353 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940129#comment-15940129 ] ASF GitHub Bot commented on FLINK-6034: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Created] (FLINK-6180) Remove TestingSerialRpcService

2017-03-24 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-6180: Summary: Remove TestingSerialRpcService Key: FLINK-6180 URL: https://issues.apache.org/jira/browse/FLINK-6180 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940124#comment-15940124 ] ASF GitHub Bot commented on FLINK-6034: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for ...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3531#discussion_r107873583 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java --- @@ -412,9 +421,15 @@ private void

[jira] [Closed] (FLINK-6179) Create SerialMainThreadValidatorUtil to support TestingSerialRpcService

2017-03-24 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-6179. Resolution: Won't Fix It is better to remove the {{TestingSerialRpcService}}, because it produces

[jira] [Commented] (FLINK-6043) Display time when exceptions/root cause of failure happened

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940116#comment-15940116 ] ASF GitHub Bot commented on FLINK-6043: --- Github user zentol commented on the issue:

[GitHub] flink issue #3583: [FLINK-6043] [web] Display exception timestamp

2017-03-24 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3583 @tillrohrmann I've addressed your comments regarding ErrorInfo being volatile/fields being final as well as markTimestamp generating and returning the timestamp. @StephanEwen @tillrohrmann

[jira] [Commented] (FLINK-6034) Add KeyedStateHandle for the snapshots in keyed streams

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940108#comment-15940108 ] ASF GitHub Bot commented on FLINK-6034: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #3531: [FLINK-6034][checkpoint] Add KeyedStateHandle for ...

2017-03-24 Thread StefanRRichter
Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/3531#discussion_r107870871 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/StateAssignmentOperation.java --- @@ -290,19 +291,19 @@ private static

[jira] [Commented] (FLINK-6019) Some log4j messages do not have a loglevel field set, so they can't be suppressed

2017-03-24 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940106#comment-15940106 ] Luke Hutchison commented on FLINK-6019: --- As far as I can tell, Akka uses a different log from Flink,

[jira] [Commented] (FLINK-6115) Need more helpful error message when trying to serialize a tuple with a null field

2017-03-24 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940101#comment-15940101 ] Luke Hutchison commented on FLINK-6115: --- Hi [~fhueske]], So the wire format of individual

[jira] [Commented] (FLINK-6159) Add Java/Scala FlinkLauncher

2017-03-24 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940068#comment-15940068 ] Stephan Ewen commented on FLINK-6159: - The Yarn Environment, Mesos Envitonment do not yet exist,

[jira] [Created] (FLINK-6179) Create SerialMainThreadValidatorUtil to support TestingSerialRpcService

2017-03-24 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-6179: Summary: Create SerialMainThreadValidatorUtil to support TestingSerialRpcService Key: FLINK-6179 URL: https://issues.apache.org/jira/browse/FLINK-6179 Project: Flink

[jira] [Commented] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940053#comment-15940053 ] ASF GitHub Bot commented on FLINK-6103: --- Github user StephanEwen commented on a diff in the pull

[GitHub] flink pull request #3598: [FLINK-6103] LocalFileSystem rename() uses File.re...

2017-03-24 Thread StephanEwen
Github user StephanEwen commented on a diff in the pull request: https://github.com/apache/flink/pull/3598#discussion_r107863788 --- Diff: flink-core/src/main/java/org/apache/flink/core/fs/local/LocalFileSystem.java --- @@ -262,8 +265,13 @@ public FSDataOutputStream create(

[jira] [Commented] (FLINK-3947) Provide low level access to RocksDB state backend

2017-03-24 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940044#comment-15940044 ] Stephan Ewen commented on FLINK-3947: - The use case was effectively {{MapState}}, so I would assume

[jira] [Commented] (FLINK-6043) Display time when exceptions/root cause of failure happened

2017-03-24 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15940033#comment-15940033 ] ASF GitHub Bot commented on FLINK-6043: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3583: [FLINK-6043] [web] Display exception timestamp

2017-03-24 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3583 Can we remove the `errorTimestamp` from the `notifyStateTransition`? I think it obfuscates the meaning a bit... --- If your project is set up for it, you can reply to this email and have your

<    1   2   3   >