[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-19 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 @zentol ready for another round. The build fails because there are a few unrelated flake tests timing out in travis build --- If your project is set up for it, you can reply to this email and

[GitHub] flink issue #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsu...

2017-04-19 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3738 @tzulitai You are very welcome . It is my pleasure ~ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976114#comment-15976114 ] ASF GitHub Bot commented on FLINK-6311: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976110#comment-15976110 ] ASF GitHub Bot commented on FLINK-6311: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsu...

2017-04-19 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3738 Thanks @zhangminglei. LGTM! Merging to {{master}} and {{release-1.2}} (will merge a bit later today ;) ) .. --- If your project is set up for it, you can reply to this email and have your

[GitHub] flink issue #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsu...

2017-04-19 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3738 @tzulitai Hi, I have updated the code. Please check it out. Thanks and appreciate it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976106#comment-15976106 ] ASF GitHub Bot commented on FLINK-6311: --- Github user zhangminglei commented on the issue:

[jira] [Commented] (FLINK-6264) Kafka consumer fails if can't find leader for partition

2017-04-19 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976105#comment-15976105 ] Tzu-Li (Gordon) Tai commented on FLINK-6264: [~autoaim800] I think the exception occurs when

[jira] [Commented] (FLINK-6303) Documentation support build in docker on OSX

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976031#comment-15976031 ] ASF GitHub Bot commented on FLINK-6303: --- Github user mtunique commented on the issue:

[GitHub] flink issue #3719: [FLINK-6303] Documentation support build in docker on OSX

2017-04-19 Thread mtunique
Github user mtunique commented on the issue: https://github.com/apache/flink/pull/3719 I will follow the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (FLINK-6264) Kafka consumer fails if can't find leader for partition

2017-04-19 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976012#comment-15976012 ] mingleizhang commented on FLINK-6264: - Hi, I would not think it is a bug when brokers failer and

[jira] [Commented] (FLINK-6333) Utilize Bloomfilters in RocksDb

2017-04-19 Thread Fang Yong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976008#comment-15976008 ] Fang Yong commented on FLINK-6333: -- Now flink uses RocksDb jni 4.11.2, and already support setFilter(new

[jira] [Commented] (FLINK-6228) Integrating the OVER windows in the Table API

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975987#comment-15975987 ] ASF GitHub Bot commented on FLINK-6228: --- GitHub user sunjincheng121 opened a pull request:

[GitHub] flink pull request #3743: [FLINK-6228][table] Integrating the OVER windows i...

2017-04-19 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3743 [FLINK-6228][table] Integrating the OVER windows in the Table API (st… In this PR I had integrating the OVER windows in the Table API, Implementation of the syntax and use examples are as

[jira] [Commented] (FLINK-6120) Implement heartbeat logic between JobManager and ResourceManager

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975934#comment-15975934 ] ASF GitHub Bot commented on FLINK-6120: --- Github user zhijiangW commented on the issue:

[GitHub] flink issue #3645: [FLINK-6120][Distributed Coordinator]Implement heartbeat ...

2017-04-19 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/3645 @tillrohrmann , just a kind reminder for this last heartbeat PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Updated] (FLINK-6334) Refactoring UDTF interface

2017-04-19 Thread Shaoxuan Wang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shaoxuan Wang updated FLINK-6334: - Description: The current UDTF leverages the table.join(expression) interface, which is not a

[jira] [Created] (FLINK-6334) Refactoring UDTF interface

2017-04-19 Thread Ruidong Li (JIRA)
Ruidong Li created FLINK-6334: - Summary: Refactoring UDTF interface Key: FLINK-6334 URL: https://issues.apache.org/jira/browse/FLINK-6334 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-6333) Utilize Bloomfilters in RocksDb

2017-04-19 Thread Ted Yu (JIRA)
Ted Yu created FLINK-6333: - Summary: Utilize Bloomfilters in RocksDb Key: FLINK-6333 URL: https://issues.apache.org/jira/browse/FLINK-6333 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975860#comment-15975860 ] ASF GitHub Bot commented on FLINK-6295: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-19 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3709 @zentol How do we know if a job requested is supended or not, as the status of jobs in backend is alway changing? --- If your project is set up for it, you can reply to this email and have

[jira] [Closed] (FLINK-6327) Bug in CommonCalc's estimateRowCount() method

2017-04-19 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young closed FLINK-6327. - Resolution: Fixed Fix Version/s: 1.3.0 > Bug in CommonCalc's estimateRowCount() method >

[jira] [Commented] (FLINK-6327) Bug in CommonCalc's estimateRowCount() method

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975845#comment-15975845 ] ASF GitHub Bot commented on FLINK-6327: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3740: [FLINK-6327] [table] Bug in CommonCalc's estimateR...

2017-04-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3740 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Updated] (FLINK-6327) Bug in CommonCalc's estimateRowCount() method

2017-04-19 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-6327: -- Component/s: Table API & SQL > Bug in CommonCalc's estimateRowCount() method >

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344921 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344622 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344522 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344359 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344296 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/utils/SerializationUtils.java --- @@ -0,0 +1,30 @@ +/*

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112344276 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/utils/TimestampUtils.java --- @@ -0,0 +1,27 @@ +/* +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112342781 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341874 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341697 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341399 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112341238 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340825 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,35 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340582 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,35 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340440 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340350 --- Diff: flink-metrics/flink-metrics-datadog/src/test/java/org/apache/flink/metrics/datadog/DatadogHttpReporterTests.java --- @@ -0,0 +1,40 @@ +/*

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340221 --- Diff: flink-metrics/flink-metrics-datadog/src/test/java/org/apache/flink/metrics/datadog/DatadogHttpReporterTests.java --- @@ -0,0 +1,40 @@ +/*

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112340046 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112339524 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMeter.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112339291 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112338938 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* +

[jira] [Created] (FLINK-6332) Upgrade Scala version to 2.11.11

2017-04-19 Thread Ted Yu (JIRA)
Ted Yu created FLINK-6332: - Summary: Upgrade Scala version to 2.11.11 Key: FLINK-6332 URL: https://issues.apache.org/jira/browse/FLINK-6332 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975645#comment-15975645 ] ASF GitHub Bot commented on FLINK-6311: --- Github user zhangminglei commented on the issue:

[GitHub] flink issue #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsu...

2017-04-19 Thread zhangminglei
Github user zhangminglei commented on the issue: https://github.com/apache/flink/pull/3738 @StephanEwen @tzulitai Thanks for telling me so useful information. I will fix it soon enough. Very appreciate it. --- If your project is set up for it, you can reply to this email and have

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112305453 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/utils/TimestampUtils.java --- @@ -0,0 +1,27 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112305482 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/utils/SerializationUtils.java --- @@ -0,0 +1,30 @@ +/*

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112305118 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112304098 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83 @@ +/* + *

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975434#comment-15975434 ] Seth Wiesman commented on FLINK-6315: - [~StephanEwen] So I guess this is the crux of the real issue,

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112303033 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975433#comment-15975433 ] ASF GitHub Bot commented on FLINK-6311: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKines...

2017-04-19 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/3738#discussion_r112302446 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/KinesisDataFetcher.java --- @@

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112301573 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112301542 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,79 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-6008) collection of BlobServer improvements

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975416#comment-15975416 ] ASF GitHub Bot commented on FLINK-6008: --- Github user NicoK commented on the issue:

[GitHub] flink issue #3512: [FLINK-6008] collection of BlobServer improvements

2017-04-19 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/3512 Found a race between `BlobCache#deleteAll(JobID)` and `BlobCache#getURL(BlobKey)` now that the former is actually being used - this needs to be fixed first before merging:

[jira] [Commented] (FLINK-6311) NPE in FlinkKinesisConsumer if source was closed before run

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975415#comment-15975415 ] ASF GitHub Bot commented on FLINK-6311: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #3738: [FLINK-6311] [Kinesis Connector] NPE in FlinkKinesisConsu...

2017-04-19 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/3738 LGTM after Stephan's comment on making `mainThread` variable `volatile` is addressed. Could you do that @zhangminglei? Once updated I'll proceed to merge this, thanks :) --- If your

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112300620 --- Diff: docs/monitoring/metrics.md --- @@ -436,6 +436,35 @@ metrics.reporter.stsd.port: 8125 {% endhighlight %} +### Datadog

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112300266 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112300022 --- Diff: flink-metrics/flink-metrics-datadog/src/test/java/org/apache/flink/metrics/datadog/DatadogHttpReporterTests.java --- @@ -0,0 +1,40 @@ +/*

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112299684 --- Diff: flink-metrics/flink-metrics-datadog/src/test/java/org/apache/flink/metrics/datadog/DatadogHttpReporterTests.java --- @@ -0,0 +1,40 @@ +/*

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112299390 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpClient.java --- @@ -0,0 +1,83 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112298655 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMeter.java --- @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112298482 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112298348 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112298056 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112297785 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,214 @@ +/* + *

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112296701 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975318#comment-15975318 ] Aljoscha Krettek commented on FLINK-6315: - In the {{BucketingSink}}, we move "pending" files to

[GitHub] flink issue #3736: [Flink-6013][metrics] Add Datadog HTTP metrics reporter

2017-04-19 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3736 Addressed @zentol and @StephanEwen 's comments. Ready for another round! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Comment Edited] (FLINK-3328) Incorrectly shaded dependencies in flink-runtime

2017-04-19 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975268#comment-15975268 ] Luke Hutchison edited comment on FLINK-3328 at 4/19/17 6:43 PM:

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112283099 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/metric/DGauge.java --- @@ -0,0 +1,30 @@ +/* + *

[jira] [Commented] (FLINK-3328) Incorrectly shaded dependencies in flink-runtime

2017-04-19 Thread Luke Hutchison (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975268#comment-15975268 ] Luke Hutchison commented on FLINK-3328: --- [~StephanEwen] It's only not a problem if you know that in

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112282965 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,85 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975260#comment-15975260 ] ASF GitHub Bot commented on FLINK-6103: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3598: [FLINK-6103] LocalFileSystem rename() uses File.renameTo(...

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3598 I would do the following: - log nothing - Catch the errors that are regular "move failed" exceptions and return false. - `FileNotFoundException` -

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-19 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3709 @WangTaoTheTonic The purpose of the cache is to reduce queries to the JobManager; and since the state of the job is available through the ExecutionGraph the cache still fulfills its purpose. --- If

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975259#comment-15975259 ] ASF GitHub Bot commented on FLINK-6295: --- Github user zentol commented on the issue:

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112280185 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,216 @@ +/* +

[GitHub] flink pull request #3736: [Flink-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-19 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r112279814 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DMetric.java --- @@ -0,0 +1,65 @@ +/* + * Licensed

[jira] [Commented] (FLINK-6103) LocalFileSystem rename() uses File.renameTo()

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975242#comment-15975242 ] ASF GitHub Bot commented on FLINK-6103: --- Github user fpompermaier commented on the issue:

[GitHub] flink issue #3598: [FLINK-6103] LocalFileSystem rename() uses File.renameTo(...

2017-04-19 Thread fpompermaier
Github user fpompermaier commented on the issue: https://github.com/apache/flink/pull/3598 Of course..but how should I handle them? should I catch just one exception? What should I log? --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Closed] (FLINK-5338) Make printing sinks non-parallel

2017-04-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-5338. --- Resolution: Won't Fix Fix Version/s: (was: 2.0.0) > Make printing sinks non-parallel >

[jira] [Commented] (FLINK-5338) Make printing sinks non-parallel

2017-04-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975235#comment-15975235 ] Stephan Ewen commented on FLINK-5338: - I am okay with closing it... > Make printing sinks

[jira] [Commented] (FLINK-3328) Incorrectly shaded dependencies in flink-runtime

2017-04-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975227#comment-15975227 ] Stephan Ewen commented on FLINK-3328: - That is not a problem. Guava and asm must be in each artifact

[jira] [Commented] (FLINK-5623) TempBarrier dam has been closed

2017-04-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975220#comment-15975220 ] Stephan Ewen commented on FLINK-5623: - I think the issue is that the "pipeline breaker" is not

[jira] [Commented] (FLINK-6315) Notify on checkpoint timeout

2017-04-19 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975203#comment-15975203 ] Stephan Ewen commented on FLINK-6315: - I think you are thinking about it the right way. When

[jira] [Commented] (FLINK-5481) Simplify Row creation

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975138#comment-15975138 ] ASF GitHub Bot commented on FLINK-5481: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3127: [FLINK-5481] Simplify Row creation

2017-04-19 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3127 Looks good, thank you! Merging this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (FLINK-6312) Update curator version to 2.12.0

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975121#comment-15975121 ] ASF GitHub Bot commented on FLINK-6312: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3727: [FLINK-6312]update curator version to 2.12.0 to avoid pot...

2017-04-19 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3727 Sure. Seems like it will take a little long time but i'll try my best :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Closed] (FLINK-6149) add additional flink logical relation nodes

2017-04-19 Thread Dmytro Shkvyra (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmytro Shkvyra closed FLINK-6149. - Resolution: Fixed Ok [~ykt836], I will close it. Thanks for clarification. > add additional

[jira] [Commented] (FLINK-6295) use LoadingCache instead of WeakHashMap to lower latency

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975118#comment-15975118 ] ASF GitHub Bot commented on FLINK-6295: --- Github user WangTaoTheTonic commented on the issue:

[GitHub] flink issue #3709: [FLINK-6295]use LoadingCache instead of WeakHashMap to lo...

2017-04-19 Thread WangTaoTheTonic
Github user WangTaoTheTonic commented on the issue: https://github.com/apache/flink/pull/3709 That means every time EGHolder received a request, it will check if the job status in request is suspended or not, right? This will make cache in EGHolder unmeaningful. --- If your

[jira] [Commented] (FLINK-5256) Extend DataSetSingleRowJoin to support Left and Right joins

2017-04-19 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15975114#comment-15975114 ] ASF GitHub Bot commented on FLINK-5256: --- Github user DmytroShkvyra commented on the issue:

  1   2   3   4   >