[
https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974260#comment-15974260
]
Till Rohrmann edited comment on FLINK-6319 at 4/19/17 7:50 AM:
---
I totally
[
https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974260#comment-15974260
]
Till Rohrmann commented on FLINK-6319:
--
This would then mean that we cannot guarantee that the
[
https://issues.apache.org/jira/browse/FLINK-6319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Till Rohrmann updated FLINK-6319:
-
Description:
A user noted that we simply call {{shutdownNow}} on the
[
https://issues.apache.org/jira/browse/FLINK-6064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nico Kruber closed FLINK-6064.
--
> wrong BlobServer hostname in TaskExecutor
> -
>
>
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974245#comment-15974245
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tony810430 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-6242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974244#comment-15974244
]
ASF GitHub Bot commented on FLINK-6242:
---
Github user fhueske commented on the issue:
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3735
Hi @shaoxuan-wang, I'm fine with both approaches, single method with
additional parameters or multiple methods. If you think the multiple methods
approach is better, let's go for it.
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112134112
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974231#comment-15974231
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tony810430 commented on a diff in the pull
Github user tony810430 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112132994
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974213#comment-15974213
]
Tzu-Li (Gordon) Tai edited comment on FLINK-6311 at 4/19/17 7:18 AM:
-
[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974213#comment-15974213
]
Tzu-Li (Gordon) Tai commented on FLINK-6311:
I think we can just do:
{code}
if (mainThread !=
[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974207#comment-15974207
]
mingleizhang edited comment on FLINK-6311 at 4/19/17 7:14 AM:
--
[~tzulitai]
[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974207#comment-15974207
]
mingleizhang edited comment on FLINK-6311 at 4/19/17 7:13 AM:
--
[~tzulitai]
[
https://issues.apache.org/jira/browse/FLINK-6311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974207#comment-15974207
]
mingleizhang commented on FLINK-6311:
-
[~tzulitai] Hi, here is the sample code I put here, please
[
https://issues.apache.org/jira/browse/FLINK-6196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974177#comment-15974177
]
ASF GitHub Bot commented on FLINK-6196:
---
Github user clarkyzl commented on a diff in the pull
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3623#discussion_r112126252
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/TableFunction.scala
---
@@ -135,8 +135,11 @@ abstract class
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974156#comment-15974156
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974157#comment-15974157
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974159#comment-15974159
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974152#comment-15974152
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974160#comment-15974160
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974155#comment-15974155
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974154#comment-15974154
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974161#comment-15974161
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974158#comment-15974158
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
[
https://issues.apache.org/jira/browse/FLINK-4821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15974153#comment-15974153
]
ASF GitHub Bot commented on FLINK-4821:
---
Github user tzulitai commented on a diff in the pull
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123126
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122515
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123595
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123170
--- Diff:
flink-connectors/flink-connector-kinesis/src/test/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumerTest.java
---
@@
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112121870
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112123765
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -194,26
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122128
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122730
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -66,31
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122336
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
Github user tzulitai commented on a diff in the pull request:
https://github.com/apache/flink/pull/3001#discussion_r112122018
--- Diff:
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java
---
@@ -267,38
301 - 337 of 337 matches
Mail list logo