[jira] [Commented] (FLINK-6392) Change the alias of Window from optional to essential.

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15986023#comment-15986023 ] ASF GitHub Bot commented on FLINK-6392: --- GitHub user sunjincheng121 opened a pull request:

[GitHub] flink pull request #3786: [FLINK-6392][table] Change the alias of Window fro...

2017-04-26 Thread sunjincheng121
GitHub user sunjincheng121 opened a pull request: https://github.com/apache/flink/pull/3786 [FLINK-6392][table] Change the alias of Window from optional to essen… In this PR refactoring the API definition using TYPE SYSTEM lead to constraint for the alias. - [x] General

[jira] [Commented] (FLINK-6387) Flink UI support access log

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985992#comment-15985992 ] ASF GitHub Bot commented on FLINK-6387: --- Github user shijinkui commented on the issue:

[GitHub] flink issue #3777: [FLINK-6387] [webfrontend]Flink UI support access log

2017-04-26 Thread shijinkui
Github user shijinkui commented on the issue: https://github.com/apache/flink/pull/3777 > I can see this flooding the logs like crazy, especially with things like metrics and watermarks that update often. Some kind of filtering is probably necessary here. You are right. The

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985934#comment-15985934 ] ASF GitHub Bot commented on FLINK-6288: --- Github user fanyon commented on the issue:

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-04-26 Thread fanyon
Github user fanyon commented on the issue: https://github.com/apache/flink/pull/3766 @gyfora For the method `int partition(T next, byte[] serializedKey, byte[] serializedValue, int partitionNum)` in KafkaPartitioner, the correct partition num of target topic can be used. But the

[GitHub] flink pull request #3785: [FLINK-6337][network] Remove the buffer provider f...

2017-04-26 Thread zhijiangW
GitHub user zhijiangW opened a pull request: https://github.com/apache/flink/pull/3785 [FLINK-6337][network] Remove the buffer provider from PartitionRequestServerHandler Currently, `PartitionRequestServerHandler` will create a `LocalBufferPool` when the channel is registered. The

[jira] [Commented] (FLINK-6337) Remove the buffer provider from PartitionRequestServerHandler

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985901#comment-15985901 ] ASF GitHub Bot commented on FLINK-6337: --- GitHub user zhijiangW opened a pull request:

[jira] [Commented] (FLINK-6247) Build a jar-with-dependencies for flink-table and put it into ./opt

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985890#comment-15985890 ] ASF GitHub Bot commented on FLINK-6247: --- Github user sunjincheng121 commented on the issue:

[GitHub] flink issue #3666: [FLINK-6247][table] Build a jar-with-dependencies for fli...

2017-04-26 Thread sunjincheng121
Github user sunjincheng121 commented on the issue: https://github.com/apache/flink/pull/3666 Hi @fhueske Thanks for your Reviewing. And sorry for late reply. I have updated the PR. Please take a look. Thanks a lot. Thanks, SunJincheng --- If your project is set up for

[jira] [Updated] (FLINK-6392) Change the alias of Window from optional to essential.

2017-04-26 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6392: --- Description: Currently, The window clause use case looks like as following: {code} tab

[jira] [Updated] (FLINK-6392) Change the alias of Window from optional to essential.

2017-04-26 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6392: --- Description: Currently, The window clause use case looks like as following: {code} tab

[jira] [Updated] (FLINK-6392) Change the alias of Window from optional to essential.

2017-04-26 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sunjincheng updated FLINK-6392: --- Issue Type: Sub-task (was: Improvement) Parent: FLINK-4557 > Change the alias of Window from

[jira] [Created] (FLINK-6392) Change the alias of Window from optional to essential.

2017-04-26 Thread sunjincheng (JIRA)
sunjincheng created FLINK-6392: -- Summary: Change the alias of Window from optional to essential. Key: FLINK-6392 URL: https://issues.apache.org/jira/browse/FLINK-6392 Project: Flink Issue Type:

[jira] [Commented] (FLINK-6391) fix build for scala 2.11 (gelly-examples)

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985714#comment-15985714 ] ASF GitHub Bot commented on FLINK-6391: --- Github user EronWright commented on the issue:

[GitHub] flink issue #3784: FLINK-6391

2017-04-26 Thread EronWright
Github user EronWright commented on the issue: https://github.com/apache/flink/pull/3784 @greghogan that might be a good idea but I don't know much about it. I'm merely focused on fixing the build break. --- If your project is set up for it, you can reply to this email and have

[jira] [Commented] (FLINK-6360) Failed to create assembly for Scala 2.11 due to tools/change-scala-version.sh not changing flink-gelly-examples_2.10

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985711#comment-15985711 ] Greg Hogan commented on FLINK-6360: --- [~jlaskowski], have you had a chance to work on this bug? It's

[jira] [Commented] (FLINK-6391) fix build for scala 2.11 (gelly-examples)

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985710#comment-15985710 ] ASF GitHub Bot commented on FLINK-6391: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3784: FLINK-6391

2017-04-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3784 Any ideas why we can't just reference `scala.binary.version` in the Maven configurations rather than specifying `2.10` and modifying this in the change script? I don't see why

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-04-26 Thread heytitle
Github user heytitle commented on the issue: https://github.com/apache/flink/pull/3511 I also think about the abstract class but I'm not sure how to do it properly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[jira] [Commented] (FLINK-6360) Failed to create assembly for Scala 2.11 due to tools/change-scala-version.sh not changing flink-gelly-examples_2.10

2017-04-26 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985700#comment-15985700 ] Eron Wright commented on FLINK-6360: - I fixed this and opened a PR at the same time as Greg marked it

[jira] [Comment Edited] (FLINK-6360) Failed to create assembly for Scala 2.11 due to tools/change-scala-version.sh not changing flink-gelly-examples_2.10

2017-04-26 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985700#comment-15985700 ] Eron Wright edited comment on FLINK-6360 at 4/26/17 10:55 PM: --- I fixed this

[jira] [Commented] (FLINK-6391) fix build for scala 2.11 (gelly-examples)

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985699#comment-15985699 ] ASF GitHub Bot commented on FLINK-6391: --- GitHub user EronWright opened a pull request:

[GitHub] flink pull request #3784: FLINK-6391

2017-04-26 Thread EronWright
GitHub user EronWright opened a pull request: https://github.com/apache/flink/pull/3784 FLINK-6391 FLINK-6391 Improve change-scala-version.sh to correctly deal with references to flink-gelly-examples. You can merge this pull request into a Git repository by running: $

[jira] [Closed] (FLINK-6391) fix build for scala 2.11 (gelly-examples)

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-6391. - Resolution: Duplicate > fix build for scala 2.11 (gelly-examples) >

[jira] [Created] (FLINK-6391) fix build for scala 2.11 (gelly-examples)

2017-04-26 Thread Eron Wright (JIRA)
Eron Wright created FLINK-6391: --- Summary: fix build for scala 2.11 (gelly-examples) Key: FLINK-6391 URL: https://issues.apache.org/jira/browse/FLINK-6391 Project: Flink Issue Type: Bug

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-04-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3511 @heytitle, you can `rebase -i dd20^` and then delete the first two lines which removes those commits from the history. An initial thought from skimming the code: should we create an

[jira] [Commented] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985629#comment-15985629 ] ASF GitHub Bot commented on FLINK-3722: --- Github user heytitle commented on the issue:

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-04-26 Thread heytitle
Github user heytitle commented on the issue: https://github.com/apache/flink/pull/3511 @greghogan May I ask you how to remove `FLINK-3722` commits?. Only way I can think of is `git rebase -i`, but this will rewrite history of this PR. --- If your project is set up for it, you can

[jira] [Closed] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-6390. --- > Add Trigger Hooks to the Checkpoint Coordinator > --- > >

[jira] [Resolved] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-6390. - Resolution: Fixed Implemented in 90ca438106e63c5032ee2ad27e54e9f573eac386 > Add Trigger Hooks to

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985621#comment-15985621 ] ASF GitHub Bot commented on FLINK-6390: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #3782: [FLINK-6390] [checkpoints] Add API for checkpoints...

2017-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/3782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-4370) Offer a default IntelliJ inspection profile with Flink

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985606#comment-15985606 ] ASF GitHub Bot commented on FLINK-4370: --- Github user greghogan commented on the issue:

[GitHub] flink issue #2352: [FLINK-4370] Add an IntelliJ Inspections Profile

2017-04-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/2352 @StephanEwen can these be shared under `tools/idea/...`? If they are installed by default then any user modifications will be noted by git. Conversely, most contributors won't notice these files

[jira] [Commented] (FLINK-6107) Add custom checkstyle for flink-streaming-java

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985578#comment-15985578 ] Greg Hogan commented on FLINK-6107: --- [~StephanEwen], I think there was a perception that import order

[jira] [Commented] (FLINK-6281) Create TableSink for JDBC

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985498#comment-15985498 ] ASF GitHub Bot commented on FLINK-6281: --- Github user haohui commented on the issue:

[GitHub] flink issue #3712: [FLINK-6281] Create TableSink for JDBC.

2017-04-26 Thread haohui
Github user haohui commented on the issue: https://github.com/apache/flink/pull/3712 Thanks for your pointer of the prototype! > Do you intend to provide exactly-once guarantees for arbitrary updates? As I think about it a little bit more, I think it might make sense

[jira] [Commented] (FLINK-6293) Flakey JobManagerITCase

2017-04-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985432#comment-15985432 ] Stephan Ewen commented on FLINK-6293: - Hitting this frequently on local builds as well: {code} Tests

[jira] [Updated] (FLINK-6293) Flakey JobManagerITCase

2017-04-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-6293: Priority: Critical (was: Major) > Flakey JobManagerITCase > --- > >

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985423#comment-15985423 ] ASF GitHub Bot commented on FLINK-6225: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3748: [FLINK-6225] [Cassandra Connector] add CassandraTa...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3748#discussion_r113541703 --- Diff: flink-connectors/flink-connector-cassandra/src/test/java/org/apache/flink/streaming/connectors/cassandra/CassandraConnectorITCase.java --- @@

[jira] [Commented] (FLINK-6287) Flakey JobManagerRegistrationTest

2017-04-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985404#comment-15985404 ] Stephan Ewen commented on FLINK-6287: - A recent PR has addressed some instability, but I am still

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985378#comment-15985378 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985379#comment-15985379 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985375#comment-15985375 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985381#comment-15985381 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985380#comment-15985380 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985376#comment-15985376 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-5969) Add savepoint backwards compatibility tests from 1.2 to 1.3

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985377#comment-15985377 ] ASF GitHub Bot commented on FLINK-5969: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #3778: [FLINK-5969] Add savepoint backwards compatibility...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3778#discussion_r113441899 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractUdfStreamOperator.java --- @@ -155,12 +155,14 @@ public void

[GitHub] flink pull request #3778: [FLINK-5969] Add savepoint backwards compatibility...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3778#discussion_r113435639 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java --- @@ -489,6 +489,39 @@ public JobExecutionResult

[GitHub] flink pull request #3778: [FLINK-5969] Add savepoint backwards compatibility...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3778#discussion_r113435697 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java --- @@ -489,6 +489,39 @@ public JobExecutionResult

[GitHub] flink pull request #3778: [FLINK-5969] Add savepoint backwards compatibility...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3778#discussion_r113446953 --- Diff: flink-tests/src/test/java/org/apache/flink/test/checkpointing/utils/StatefulUDFSavepointFrom12MigrationITCase.java --- @@ -0,0 +1,771 @@ +/*

[GitHub] flink pull request #3778: [FLINK-5969] Add savepoint backwards compatibility...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3778#discussion_r113442453 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractUdfStreamOperator.java --- @@ -155,12 +155,14 @@ public void

[GitHub] flink pull request #3778: [FLINK-5969] Add savepoint backwards compatibility...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3778#discussion_r113435588 --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java --- @@ -489,6 +489,39 @@ public JobExecutionResult

[GitHub] flink pull request #3778: [FLINK-5969] Add savepoint backwards compatibility...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3778#discussion_r113440360 --- Diff: flink-fs-tests/src/test/java/org/apache/flink/hdfstests/ContinuousFileProcessingFrom12MigrationTest.java --- @@ -0,0 +1,378 @@ +/* + *

[jira] [Commented] (FLINK-6175) HistoryServerTest.testFullArchiveLifecycle fails

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985286#comment-15985286 ] ASF GitHub Bot commented on FLINK-6175: --- Github user StephanEwen commented on the issue:

[jira] [Commented] (FLINK-5752) Support push down projections for HBaseTableSource

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985287#comment-15985287 ] ASF GitHub Bot commented on FLINK-5752: --- Github user ramkrish86 commented on the issue:

[GitHub] flink issue #3760: FLINK-5752 Support push down projections for HBaseTableSo...

2017-04-26 Thread ramkrish86
Github user ramkrish86 commented on the issue: https://github.com/apache/flink/pull/3760 I checked the recent failure. `Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 20.417 sec <<< FAILURE! - in org.apache.flink.runtime.jobmanager.JobManagerRegistrationTest`

[GitHub] flink issue #3655: [FLINK-6175] Harden HistoryServerTest#testFullArchiveLife...

2017-04-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3655 While at hardening: The test seems to work with a fix port. That is bound to cause failures due to conflicts (for example 8082 is common to be used if you have a local HA Flink for testing).

[jira] [Commented] (FLINK-6048) Asynchronous snapshots for heap-based operator state backends

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985265#comment-15985265 ] ASF GitHub Bot commented on FLINK-6048: --- Github user StefanRRichter closed the pull request at:

[GitHub] flink pull request #3536: [FLINK-6048] Asynchronous snapshots for heap-based...

2017-04-26 Thread StefanRRichter
Github user StefanRRichter closed the pull request at: https://github.com/apache/flink/pull/3536 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113519219 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,109 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985247#comment-15985247 ] ASF GitHub Bot commented on FLINK-6013: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-6338) SimpleStringUtils should be called StringValueUtils

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985245#comment-15985245 ] ASF GitHub Bot commented on FLINK-6338: --- Github user zentol commented on the issue:

[GitHub] flink issue #3783: [FLINK-6338] Add support for DISTINCT into Code Generated...

2017-04-26 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/3783 Please fix the PR title, you are referencing the wrong JIRA. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Commented] (FLINK-6048) Asynchronous snapshots for heap-based operator state backends

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985237#comment-15985237 ] ASF GitHub Bot commented on FLINK-6048: --- Github user StefanRRichter commented on the issue:

[GitHub] flink issue #3536: [FLINK-6048] Asynchronous snapshots for heap-based Operat...

2017-04-26 Thread StefanRRichter
Github user StefanRRichter commented on the issue: https://github.com/apache/flink/pull/3536 Thanks for the review @tillrohrmann. I addressed your comments concerning unregistration of streams. Will merge this now. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (FLINK-6107) Add custom checkstyle for flink-streaming-java

2017-04-26 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985221#comment-15985221 ] Stephan Ewen commented on FLINK-6107: - I would like to make a suggestion for an adjustment to the

[jira] [Commented] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985213#comment-15985213 ] ASF GitHub Bot commented on FLINK-3722: --- Github user greghogan commented on the issue:

[GitHub] flink issue #3511: [Flink-5734] code generation for normalizedkey sorter

2017-04-26 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/3511 @heytitle please remove the old FLINK-3722 commits and rebase to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985209#comment-15985209 ] ASF GitHub Bot commented on FLINK-6250: --- Github user stefanobortoli closed the pull request at:

[GitHub] flink pull request #3771: [FLINK-6250] Distinct procTime with Rows boundarie...

2017-04-26 Thread stefanobortoli
Github user stefanobortoli closed the pull request at: https://github.com/apache/flink/pull/3771 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Updated] (FLINK-6357) ParameterTool get unrequested parameters

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6357?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-6357: -- Summary: ParameterTool get unrequested parameters (was: Parametertool get unrequested parameters) >

[jira] [Commented] (FLINK-6250) Distinct procTime with Rows boundaries

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985208#comment-15985208 ] ASF GitHub Bot commented on FLINK-6250: --- Github user huawei-flink commented on the issue:

[GitHub] flink issue #3771: [FLINK-6250] Distinct procTime with Rows boundaries

2017-04-26 Thread huawei-flink
Github user huawei-flink commented on the issue: https://github.com/apache/flink/pull/3771 @fhueske I have created #3783 with just the code generation part. At least the GROUP BY distinct can move ahead. I will close this PR and wait for the merging of the Calcite fix. --- If your

[jira] [Updated] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-3722: -- Fix Version/s: 1.3.0 > The divisions in the InMemorySorters' swap/compare methods hurt performance >

[jira] [Closed] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2017-04-26 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan closed FLINK-3722. - Resolution: Implemented Implemented in 336b95d4eedc23e5ce37d1739165157e127c65f8 > The divisions in the

[jira] [Commented] (FLINK-3722) The divisions in the InMemorySorters' swap/compare methods hurt performance

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985203#comment-15985203 ] ASF GitHub Bot commented on FLINK-3722: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #2628: [FLINK-3722] [runtime] Don't / and % when sorting

2017-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/2628 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (FLINK-6338) SimpleStringUtils should be called StringValueUtils

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985198#comment-15985198 ] ASF GitHub Bot commented on FLINK-6338: --- Github user huawei-flink commented on the issue:

[GitHub] flink issue #3783: [FLINK-6338] Add support for DISTINCT into Code Generated...

2017-04-26 Thread huawei-flink
Github user huawei-flink commented on the issue: https://github.com/apache/flink/pull/3783 @fhueske please have a look at this PR, it contains just the code generation part with optional distinct. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Commented] (FLINK-6338) SimpleStringUtils should be called StringValueUtils

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985197#comment-15985197 ] ASF GitHub Bot commented on FLINK-6338: --- GitHub user huawei-flink opened a pull request:

[GitHub] flink pull request #3783: [FLINK-6338] Add support for DISTINCT into Code Ge...

2017-04-26 Thread huawei-flink
GitHub user huawei-flink opened a pull request: https://github.com/apache/flink/pull/3783 [FLINK-6338] Add support for DISTINCT into Code Generated Aggregations Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985190#comment-15985190 ] ASF GitHub Bot commented on FLINK-6013: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113512176 --- Diff: flink-metrics/flink-metrics-datadog/src/main/java/org/apache/flink/metrics/datadog/DatadogHttpReporter.java --- @@ -0,0 +1,199 @@ +/* +

[jira] [Commented] (FLINK-6013) Add Datadog HTTP metrics reporter

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985159#comment-15985159 ] ASF GitHub Bot commented on FLINK-6013: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #3736: [FLINK-6013][metrics] Add Datadog HTTP metrics rep...

2017-04-26 Thread bowenli86
Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/3736#discussion_r113510125 --- Diff: flink-metrics/flink-metrics-datadog/pom.xml --- @@ -0,0 +1,109 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985157#comment-15985157 ] ASF GitHub Bot commented on FLINK-6390: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #3782: [FLINK-6390] [checkpoints] Add API for checkpoints that a...

2017-04-26 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3782 Thanks a lot for the fast review. Agree with both issues raised. Will address them while merging... --- If your project is set up for it, you can reply to this email and have your reply appear

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985154#comment-15985154 ] ASF GitHub Bot commented on FLINK-6390: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985155#comment-15985155 ] ASF GitHub Bot commented on FLINK-6390: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #3782: [FLINK-6390] [checkpoints] Add API for checkpoints...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3782#discussion_r113504901 --- Diff: flink-core/src/main/java/org/apache/flink/core/io/SimpleVersionedSerializer.java --- @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache

[GitHub] flink pull request #3782: [FLINK-6390] [checkpoints] Add API for checkpoints...

2017-04-26 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/3782#discussion_r113507485 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/hooks/MasterHooks.java --- @@ -0,0 +1,272 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-6288) FlinkKafkaProducer's custom Partitioner is always invoked with number of partitions of default topic

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985138#comment-15985138 ] ASF GitHub Bot commented on FLINK-6288: --- Github user gyfora commented on the issue:

[GitHub] flink issue #3766: [FLINK-6288] fix FlinkKafkaProducer's custom Partitioner ...

2017-04-26 Thread gyfora
Github user gyfora commented on the issue: https://github.com/apache/flink/pull/3766 I think this is reasonable as the current implementation doesnt work for dynamic new topics. (we should also deprecate the current one) But let's hear what others say :) --- If your project

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985122#comment-15985122 ] Gyula Fora commented on FLINK-6390: --- we could call it completeCheckpoint for example > Add Trigger

[jira] [Commented] (FLINK-6390) Add Trigger Hooks to the Checkpoint Coordinator

2017-04-26 Thread Gyula Fora (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985119#comment-15985119 ] Gyula Fora commented on FLINK-6390: --- Hi Stephan, This looks pretty useful. One thing that came to my

[jira] [Commented] (FLINK-6225) Support Row Stream for CassandraSink

2017-04-26 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985117#comment-15985117 ] ASF GitHub Bot commented on FLINK-6225: --- Github user PangZhi commented on a diff in the pull

  1   2   3   4   >