[jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272291#comment-16272291 ] ASF GitHub Bot commented on FLINK-8149: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5069: [FLINK-8149][kinesis] Replace usages of deprecated Serial...

2017-11-29 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5069 LGTM, merging this .. ---

[jira] [Comment Edited] (FLINK-8167) Failing WikipediaEditsSourceTest on Travis

2017-11-29 Thread Hai Zhou UTC+8 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272233#comment-16272233 ] Hai Zhou UTC+8 edited comment on FLINK-8167 at 11/30/17 6:59 AM: - I agree

[jira] [Commented] (FLINK-8167) Failing WikipediaEditsSourceTest on Travis

2017-11-29 Thread Hai Zhou UTC+8 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272233#comment-16272233 ] Hai Zhou UTC+8 commented on FLINK-8167: --- I agree with "move some low popularity connectors to Apache

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272204#comment-16272204 ] ASF GitHub Bot commented on FLINK-8158: --- Github user hequn8128 commented on the issue:

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-29 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5094 Thanks for your replies. I agree with that it is valid to join late input data.What I concern is the watermark has not been hold back correctly. Take `testRowTimeJoinWithCommonBounds2`

[jira] [Updated] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2017-11-29 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8175: Description: I propose removing flink-streaming-contrib from flink-contrib, and migrating its classes to

[jira] [Updated] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2017-11-29 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8175: Description: I propose removing flink-streaming-contrib from flink-contrib, and migrating its classes to

[jira] [Comment Edited] (FLINK-7294) mesos.resourcemanager.framework.role not working

2017-11-29 Thread Bhumika Bayani (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272190#comment-16272190 ] Bhumika Bayani edited comment on FLINK-7294 at 11/30/17 5:34 AM: - Hi

[jira] [Commented] (FLINK-7294) mesos.resourcemanager.framework.role not working

2017-11-29 Thread Bhumika Bayani (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272190#comment-16272190 ] Bhumika Bayani commented on FLINK-7294: --- Hi [~eronwright], As per this link

[jira] [Commented] (FLINK-8167) Failing WikipediaEditsSourceTest on Travis

2017-11-29 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272182#comment-16272182 ] Bowen Li commented on FLINK-8167: - I also opened FLINK-8175. Let me know what you guys think > Failing

[jira] [Created] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala

2017-11-29 Thread Bowen Li (JIRA)
Bowen Li created FLINK-8175: --- Summary: remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala Key: FLINK-8175 URL: https://issues.apache.org/jira/browse/FLINK-8175 Project:

[jira] [Commented] (FLINK-8167) Failing WikipediaEditsSourceTest on Travis

2017-11-29 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272162#comment-16272162 ] Bowen Li commented on FLINK-8167: - I'm wondering why wikiedit has to be part of Flink itself? I don't see

[jira] [Commented] (FLINK-7294) mesos.resourcemanager.framework.role not working

2017-11-29 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16272120#comment-16272120 ] Eron Wright commented on FLINK-7294: - [~bbayani] I believe the fix we came up with is not correct.

[jira] [Created] (FLINK-8174) Mesos RM unable to accept offers for unreserved resources

2017-11-29 Thread Eron Wright (JIRA)
Eron Wright created FLINK-8174: --- Summary: Mesos RM unable to accept offers for unreserved resources Key: FLINK-8174 URL: https://issues.apache.org/jira/browse/FLINK-8174 Project: Flink Issue

[jira] [Commented] (FLINK-8173) InvalidProgramException: Table program cannot be compiled. This is a bug. Please file an issue.

2017-11-29 Thread Aegeaner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271988#comment-16271988 ] Aegeaner commented on FLINK-8173: - Assignment conversion not possible from type "java.lang.CharSequence"

[jira] [Created] (FLINK-8173) InvalidProgramException: Table program cannot be compiled. This is a bug. Please file an issue.

2017-11-29 Thread Tao Xia (JIRA)
Tao Xia created FLINK-8173: -- Summary: InvalidProgramException: Table program cannot be compiled. This is a bug. Please file an issue. Key: FLINK-8173 URL: https://issues.apache.org/jira/browse/FLINK-8173

[jira] [Commented] (FLINK-7907) Flink Metrics documentation missing Scala examples

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271580#comment-16271580 ] ASF GitHub Bot commented on FLINK-7907: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5071: [FLINK-7907][docs] The metrics documentation missi...

2017-11-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5071#discussion_r153923624 --- Diff: docs/monitoring/metrics.md --- @@ -94,8 +94,8 @@ Alternatively you can also use your own `Counter` implementation: {% highlight java %}

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271487#comment-16271487 ] ASF GitHub Bot commented on FLINK-4812: --- Github user zentol commented on the issue:

[GitHub] flink issue #5100: [FLINK-4812][metrics] Expose currentLowWatermark for all ...

2017-11-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5100 yes, we _could_ setup all IO metrics in the operator chain. But that will require some more changes there since the methods there never access 2 operators at the same time. For a chain A->B, to

[jira] [Commented] (FLINK-8151) [Table] Map equality check to use entrySet equality

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271417#comment-16271417 ] ASF GitHub Bot commented on FLINK-8151: --- Github user walterddr commented on the issue:

[GitHub] flink issue #5070: [FLINK-8151][table]Map equality check to use entrySet equ...

2017-11-29 Thread walterddr
Github user walterddr commented on the issue: https://github.com/apache/flink/pull/5070 @twalthr I think my previous unit test method was not correct. Since TableAPI always use `java.util.HashMap` per flink documentation. I think it is safe to directly use

[jira] [Updated] (FLINK-8151) [Table] Map equality check to use entrySet equality

2017-11-29 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-8151: - Summary: [Table] Map equality check to use entrySet equality (was: [Table] Clean up Map equality check)

[jira] [Updated] (FLINK-8151) [Table] Clean up Map equality check

2017-11-29 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-8151: - Description: Following up with FLINK-8038. The equality check currently is broken. Plan to support

[jira] [Updated] (FLINK-8151) [Table] Clean up Map equality check

2017-11-29 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-8151: - Summary: [Table] Clean up Map equality check (was: [Table] removing map value equality check) > [Table]

[jira] [Commented] (FLINK-7595) Removing stateless task from task chain breaks savepoint restore

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271279#comment-16271279 ] ASF GitHub Bot commented on FLINK-7595: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #5103: [FLINK-7595] [Savepoints] Allow removing stateless...

2017-11-29 Thread zentol
GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5103 [FLINK-7595] [Savepoints] Allow removing stateless operators This is a fixed version of #4651 for 1.4. It adds some checkstyle fixes and modifies the SavepointLoaderTest to actually have a

[jira] [Commented] (FLINK-8151) [Table] removing map value equality check

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271238#comment-16271238 ] ASF GitHub Bot commented on FLINK-8151: --- Github user walterddr commented on the issue:

[GitHub] flink issue #5070: [FLINK-8151][table]Remove Map type equality comparison.

2017-11-29 Thread walterddr
Github user walterddr commented on the issue: https://github.com/apache/flink/pull/5070 Ah. I see. `AbstractMap.equals` look very much similar to `Arrays.equals`. I will add it in and some more testings. thanks @fhueske for the great tips ---

[jira] [Comment Edited] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-11-29 Thread Christos Hadjinikolis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271183#comment-16271183 ] Christos Hadjinikolis edited comment on FLINK-5506 at 11/29/17 5:42 PM:

[jira] [Comment Edited] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-11-29 Thread Christos Hadjinikolis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271183#comment-16271183 ] Christos Hadjinikolis edited comment on FLINK-5506 at 11/29/17 5:38 PM:

[jira] [Comment Edited] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-11-29 Thread Christos Hadjinikolis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271183#comment-16271183 ] Christos Hadjinikolis edited comment on FLINK-5506 at 11/29/17 5:38 PM:

[jira] [Commented] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-11-29 Thread Christos Hadjinikolis (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271183#comment-16271183 ] Christos Hadjinikolis commented on FLINK-5506: -- Same issue here. I am running:

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271167#comment-16271167 ] ASF GitHub Bot commented on FLINK-7574: --- Github user yew1eb commented on a diff in the pull request:

[GitHub] flink pull request #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-29 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/5076#discussion_r153858786 --- Diff: pom.xml --- @@ -891,6 +905,41 @@ under the License. + +

[jira] [Commented] (FLINK-7762) Make WikipediaEditsSourceTest a proper test

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271151#comment-16271151 ] ASF GitHub Bot commented on FLINK-7762: --- Github user uce commented on the issue:

[GitHub] flink issue #5102: [FLINK-7762, FLINK-8167] Clean up and harden WikipediaEdi...

2017-11-29 Thread uce
Github user uce commented on the issue: https://github.com/apache/flink/pull/5102 I would be in favour of removing this or moving it to Bahir, but it is currently used in a [doc

[jira] [Commented] (FLINK-7907) Flink Metrics documentation missing Scala examples

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271136#comment-16271136 ] ASF GitHub Bot commented on FLINK-7907: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #5071: [FLINK-7907][docs] The metrics documentation missing scal...

2017-11-29 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5071 @zentol , thanks for your review. I have updated the PR according to your comments. ---

[jira] [Commented] (FLINK-7762) Make WikipediaEditsSourceTest a proper test

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271127#comment-16271127 ] ASF GitHub Bot commented on FLINK-7762: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271126#comment-16271126 ] ASF GitHub Bot commented on FLINK-8158: --- Github user fhueske commented on the issue:

[jira] [Created] (FLINK-8172) Remove unnecessary synchronisation in RecordSerializer

2017-11-29 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-8172: - Summary: Remove unnecessary synchronisation in RecordSerializer Key: FLINK-8172 URL: https://issues.apache.org/jira/browse/FLINK-8172 Project: Flink Issue

[GitHub] flink issue #5102: [FLINK-7762, FLINK-8167] Clean up and harden WikipediaEdi...

2017-11-29 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5102 The changes look good! But you comment about needing that IRC channel seem valid. If we don't have the test, however, we would have no way of knowing that the code at least works. (We could also

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-29 Thread fhueske
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/5094 I had a look at `testRowTimeJoinWithCommonBounds2`. The test processes starts by processing two watermarks for `6000` for the first and second input. After that three records are added for

[GitHub] flink issue #4985: [FLINK-8027] Generalize existing rest handlers to work wi...

2017-11-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/4985 Thanks for the review @shuai-xu. Will rebase it and once Travis gives green light, I'll merge it. ---

[jira] [Commented] (FLINK-8027) Generalize existing rest handlers to work with arbitrary RestfulGateway

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271117#comment-16271117 ] ASF GitHub Bot commented on FLINK-8027: --- Github user tillrohrmann commented on a diff in the pull

[jira] [Commented] (FLINK-8027) Generalize existing rest handlers to work with arbitrary RestfulGateway

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271118#comment-16271118 ] ASF GitHub Bot commented on FLINK-8027: --- Github user tillrohrmann commented on the issue:

[GitHub] flink pull request #4985: [FLINK-8027] Generalize existing rest handlers to ...

2017-11-29 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/4985#discussion_r153852356 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TestingTaskExecutorGateway.java --- @@ -0,0 +1,124 @@ +/* + *

[jira] [Commented] (FLINK-7652) Port CurrentJobIdsHandler to new REST endpoint

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271116#comment-16271116 ] ASF GitHub Bot commented on FLINK-7652: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #4734: [FLINK-7652] [flip6] Port CurrentJobIdsHandler to ...

2017-11-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/4734 ---

[jira] [Resolved] (FLINK-7652) Port CurrentJobIdsHandler to new REST endpoint

2017-11-29 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7652. -- Resolution: Done Added via 67aad88ee025ce02053ab560f2504762f53b87d9 > Port

[GitHub] flink issue #5100: [FLINK-4812][metrics] Expose currentLowWatermark for all ...

2017-11-29 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5100 I think the fact the the operator needs this in `setup()` is already problematic, the latency metrics implementation shouldn't have been merged like this. Wouldn't we need the output gauge only in

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271100#comment-16271100 ] ASF GitHub Bot commented on FLINK-4812: --- Github user aljoscha commented on the issue:

[jira] [Commented] (FLINK-8171) Remove work arounds in Flip6LocalStreamEnvironment

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271097#comment-16271097 ] ASF GitHub Bot commented on FLINK-8171: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5101: [FLINK-8171] [flip6] Remove work arounds from Flip6LocalS...

2017-11-29 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5101 I think we can remove the comment but not enabling the queued scheduling mode which is mandatory for Flip-6 to work. I'll remove the comment. ---

[GitHub] flink pull request #5102: [FLINK-7762, FLINK-8167] Clean up and harden Wikip...

2017-11-29 Thread uce
GitHub user uce opened a pull request: https://github.com/apache/flink/pull/5102 [FLINK-7762, FLINK-8167] Clean up and harden WikipediaEditsSource ## What is the purpose of the change This pull requests addresses two related issues with the WikipediaEditsSource. It makes

[jira] [Commented] (FLINK-7762) Make WikipediaEditsSourceTest a proper test

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271083#comment-16271083 ] ASF GitHub Bot commented on FLINK-7762: --- GitHub user uce opened a pull request:

[jira] [Commented] (FLINK-8148) Test instability in YarnFileStageTest

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271074#comment-16271074 ] ASF GitHub Bot commented on FLINK-8148: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5066: [FLINK-8148][yarn/s3] fix test instability in YarnFileSta...

2017-11-29 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5066 oh, sorry for that ---

[jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271050#comment-16271050 ] ASF GitHub Bot commented on FLINK-8149: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #5069: [FLINK-8149][kinesis] Replace usages of deprecated Serial...

2017-11-29 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5069 @tzulitai, thanks for your review. I have updated the PR according to your comments. ---

[jira] [Commented] (FLINK-8149) Replace usages of deprecated SerializationSchema

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271046#comment-16271046 ] ASF GitHub Bot commented on FLINK-8149: --- Github user yew1eb commented on a diff in the pull request:

[GitHub] flink pull request #5069: [FLINK-8149][kinesis] Replace usages of deprecated...

2017-11-29 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/5069#discussion_r153841399 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java --- @@ -41,7 +42,6

[jira] [Commented] (FLINK-7907) Flink Metrics documentation missing Scala examples

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271043#comment-16271043 ] ASF GitHub Bot commented on FLINK-7907: --- Github user zentol commented on a diff in the pull request:

[jira] [Commented] (FLINK-7907) Flink Metrics documentation missing Scala examples

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271042#comment-16271042 ] ASF GitHub Bot commented on FLINK-7907: --- Github user zentol commented on a diff in the pull request:

[GitHub] flink pull request #5071: [FLINK-7907][docs] The metrics documentation missi...

2017-11-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5071#discussion_r153839062 --- Diff: docs/monitoring/metrics.md --- @@ -61,9 +63,35 @@ public class MyMapper extends RichMapFunction { } {% endhighlight

[GitHub] flink pull request #5071: [FLINK-7907][docs] The metrics documentation missi...

2017-11-29 Thread zentol
Github user zentol commented on a diff in the pull request: https://github.com/apache/flink/pull/5071#discussion_r153838811 --- Diff: docs/monitoring/metrics.md --- @@ -61,9 +63,35 @@ public class MyMapper extends RichMapFunction { } {% endhighlight

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271030#comment-16271030 ] ASF GitHub Bot commented on FLINK-8158: --- Github user xccui commented on the issue:

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-29 Thread xccui
Github user xccui commented on the issue: https://github.com/apache/flink/pull/5094 Hi @hequn8128, as @fhueske explained, watermarks should not define the semantics of the join. We just emit join results, in spite of whether they are late and the join function should not care about

[jira] [Commented] (FLINK-8148) Test instability in YarnFileStageTest

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271028#comment-16271028 ] ASF GitHub Bot commented on FLINK-8148: --- Github user zentol commented on the issue:

[GitHub] flink issue #5066: [FLINK-8148][yarn/s3] fix test instability in YarnFileSta...

2017-11-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5066 will fix the checkstyle violation on the way. ---

[jira] [Commented] (FLINK-8148) Test instability in YarnFileStageTest

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271025#comment-16271025 ] ASF GitHub Bot commented on FLINK-8148: --- Github user zentol commented on the issue:

[GitHub] flink issue #5066: [FLINK-8148][yarn/s3] fix test instability in YarnFileSta...

2017-11-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5066 merging. ---

[jira] [Commented] (FLINK-8171) Remove work arounds in Flip6LocalStreamEnvironment

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16271021#comment-16271021 ] ASF GitHub Bot commented on FLINK-8171: --- Github user zentol commented on the issue:

[GitHub] flink issue #5101: [FLINK-8171] [flip6] Remove work arounds from Flip6LocalS...

2017-11-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5101 Can we also remove this bit ``` // temporary hack for FLIP-6 since slot-sharing isn't implemented yet jobGraph.setAllowQueuedScheduling(true); ``` from the `RestClusterClient`?

[jira] [Closed] (FLINK-7989) flink-dist jar is deployed twice onto YARN

2017-11-29 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-7989. --- Resolution: Fixed Fix Version/s: (was: 1.4.1) 1.4.0 1.4:

[jira] [Commented] (FLINK-8171) Remove work arounds in Flip6LocalStreamEnvironment

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270996#comment-16270996 ] ASF GitHub Bot commented on FLINK-8171: --- GitHub user tillrohrmann opened a pull request:

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270997#comment-16270997 ] ASF GitHub Bot commented on FLINK-7574: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-11-29 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5076 Hi @greghogan, You're quite right, Thanks for your advice. For a discussion of this improvement, you can see #4712. ---

[GitHub] flink pull request #5101: [FLINK-8171] [flip6] Remove work arounds from Flip...

2017-11-29 Thread tillrohrmann
GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5101 [FLINK-8171] [flip6] Remove work arounds from Flip6LocalStreamEnvironment ## What is the purpose of the change It is no longer needed to wait for the registration of task managers and

[jira] [Created] (FLINK-8171) Remove work arounds in Flip6LocalStreamEnvironment

2017-11-29 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8171: Summary: Remove work arounds in Flip6LocalStreamEnvironment Key: FLINK-8171 URL: https://issues.apache.org/jira/browse/FLINK-8171 Project: Flink Issue Type:

[jira] [Commented] (FLINK-7573) Introduce Http protocol connector for Elasticsearch2

2017-11-29 Thread Dylan Meissner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270979#comment-16270979 ] Dylan Meissner commented on FLINK-7573: --- Worth noting, as of Elasticsearch 5.6 there is an official

[jira] [Comment Edited] (FLINK-7573) Introduce Http protocol connector for Elasticsearch2

2017-11-29 Thread Dylan Meissner (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270979#comment-16270979 ] Dylan Meissner edited comment on FLINK-7573 at 11/29/17 3:52 PM: - Worth

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270976#comment-16270976 ] ASF GitHub Bot commented on FLINK-4812: --- Github user zentol commented on the issue:

[GitHub] flink issue #5100: [FLINK-4812][metrics] Expose currentLowWatermark for all ...

2017-11-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5100 the coupling of input to output gauge becomes rather tricky. The input gauge must be reachable in `Stream[Two]InputProcessor`, `OperatorChain#createChainedOperator`, and the output gauge in

[jira] [Commented] (FLINK-7762) Make WikipediaEditsSourceTest a proper test

2017-11-29 Thread Hai Zhou UTC+8 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270974#comment-16270974 ] Hai Zhou UTC+8 commented on FLINK-7762: --- Hi [~uce], yes. If you want, then you can work on it. >

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270954#comment-16270954 ] ASF GitHub Bot commented on FLINK-4812: --- Github user zentol commented on the issue:

[GitHub] flink issue #5100: [FLINK-4812][metrics] Expose currentLowWatermark for all ...

2017-11-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5100 ah, weÄ#re doing the same already for `numRecordsIn` maybe we can do this after all. ---

[jira] [Commented] (FLINK-7595) Removing stateless task from task chain breaks savepoint restore

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270939#comment-16270939 ] ASF GitHub Bot commented on FLINK-7595: --- Github user zentol commented on the issue:

[GitHub] flink issue #4651: [FLINK-7595] [Savepoints] Allow removing stateless operat...

2017-11-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/4651 Rebased on top of master, let's see what travis says. Didn't get any conflicts so 🤞 . ---

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270933#comment-16270933 ] ASF GitHub Bot commented on FLINK-4812: --- Github user zentol commented on the issue:

[jira] [Commented] (FLINK-8167) Failing WikipediaEditsSourceTest on Travis

2017-11-29 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270934#comment-16270934 ] Ufuk Celebi commented on FLINK-8167: I reproduced this locally. A nickname clash as indicated by the

[GitHub] flink issue #5100: [FLINK-4812][metrics] Expose currentLowWatermark for all ...

2017-11-29 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5100 You can't measure input metrics in the ChainingOutput (nicely) since for a chain A->B does B at no point have access to the output of A. We would need to have the task setup all watermark

[jira] [Commented] (FLINK-8158) Rowtime window inner join emits late data

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270924#comment-16270924 ] ASF GitHub Bot commented on FLINK-8158: --- Github user hequn8128 commented on the issue:

[GitHub] flink issue #5094: [FLINK-8158] [table] Fix rowtime window inner join emits ...

2017-11-29 Thread hequn8128
Github user hequn8128 commented on the issue: https://github.com/apache/flink/pull/5094 Thanks for your replies. @fhueske : The watermark must be aligned with timestamps, and it is the main reason why watermarks are hold back(right?). Current window join may output a record with

[jira] [Commented] (FLINK-7595) Removing stateless task from task chain breaks savepoint restore

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270923#comment-16270923 ] ASF GitHub Bot commented on FLINK-7595: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #4651: [FLINK-7595] [Savepoints] Allow removing stateless operat...

2017-11-29 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/4651 This change looks good! Does it still build when rebased on master/release-1.4? ---

[jira] [Commented] (FLINK-4812) Report Watermark metrics in all operators

2017-11-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16270898#comment-16270898 ] ASF GitHub Bot commented on FLINK-4812: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #5100: [FLINK-4812][metrics] Expose currentLowWatermark for all ...

2017-11-29 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5100 Ah stupid, so we have to do it in the chain and in the input processors. Because the problem of operators overriding `processWatermark()` is real. 😅 ---

  1   2   3   4   >