[jira] [Commented] (FLINK-8201) YarnResourceManagerTest causes license checking failure

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278165#comment-16278165 ] ASF GitHub Bot commented on FLINK-8201: --- GitHub user wenlong88 opened a pull request:

[GitHub] flink pull request #5123: [FLINK-8201] YarnResourceManagerTest causes licens...

2017-12-04 Thread wenlong88
GitHub user wenlong88 opened a pull request: https://github.com/apache/flink/pull/5123 [FLINK-8201] YarnResourceManagerTest causes license checking failure YarnResourceManagerTest generates a temporary taskmanager config file in flink-yarn module root folder and never clear

[jira] [Created] (FLINK-8201) YarnResourceManagerTest causes license checking failure

2017-12-04 Thread Wenlong Lyu (JIRA)
Wenlong Lyu created FLINK-8201: -- Summary: YarnResourceManagerTest causes license checking failure Key: FLINK-8201 URL: https://issues.apache.org/jira/browse/FLINK-8201 Project: Flink Issue

[jira] [Commented] (FLINK-8192) Properly annotate APIs of all Flink connectors with @Public / @PublicEvolving / @Internal

2017-12-04 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278159#comment-16278159 ] Tzu-Li (Gordon) Tai commented on FLINK-8192: Sure thing [~mingleizhang]. It would also be good

[jira] [Assigned] (FLINK-8200) RocksDBAsyncSnapshotTest should use temp fold instead of fold with fixed name

2017-12-04 Thread Wenlong Lyu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenlong Lyu reassigned FLINK-8200: -- Assignee: Wenlong Lyu > RocksDBAsyncSnapshotTest should use temp fold instead of fold with

[jira] [Commented] (FLINK-8200) RocksDBAsyncSnapshotTest should use temp fold instead of fold with fixed name

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278134#comment-16278134 ] ASF GitHub Bot commented on FLINK-8200: --- GitHub user wenlong88 opened a pull request:

[GitHub] flink pull request #5122: [FLINK-8200] RocksDBAsyncSnapshotTest should use t...

2017-12-04 Thread wenlong88
GitHub user wenlong88 opened a pull request: https://github.com/apache/flink/pull/5122 [FLINK-8200] RocksDBAsyncSnapshotTest should use temp fold instead of fold with fixed name Using fixed folder in test makes test fail when different users run the test in the same machine. We

[jira] [Created] (FLINK-8200) RocksDBAsyncSnapshotTest should use temp fold instead of fold with fixed name

2017-12-04 Thread Wenlong Lyu (JIRA)
Wenlong Lyu created FLINK-8200: -- Summary: RocksDBAsyncSnapshotTest should use temp fold instead of fold with fixed name Key: FLINK-8200 URL: https://issues.apache.org/jira/browse/FLINK-8200 Project:

[jira] [Commented] (FLINK-8017) High availability cluster-id option incorrect in documentation

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278092#comment-16278092 ] ASF GitHub Bot commented on FLINK-8017: --- Github user tony810430 commented on the issue:

[GitHub] flink issue #4976: [FLINK-8017] Fix High availability cluster-id key in docu...

2017-12-04 Thread tony810430
Github user tony810430 commented on the issue: https://github.com/apache/flink/pull/4976 Hi, @aljoscha Could you please merge this PR to `release-1.3` branch as well? Thank you. ---

[jira] [Created] (FLINK-8199) Annotation for Elasticsearch connector

2017-12-04 Thread mingleizhang (JIRA)
mingleizhang created FLINK-8199: --- Summary: Annotation for Elasticsearch connector Key: FLINK-8199 URL: https://issues.apache.org/jira/browse/FLINK-8199 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-5544) Implement Internal Timer Service in RocksDB

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278040#comment-16278040 ] ASF GitHub Bot commented on FLINK-5544: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #3359: [FLINK-5544][streaming] Add InternalTimerService implemen...

2017-12-04 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/3359 @shixiaogang Sounds nice! Can you please open a PR if possible? Thanks! ---

[jira] [Commented] (FLINK-8192) Properly annotate APIs of all Flink connectors with @Public / @PublicEvolving / @Internal

2017-12-04 Thread mingleizhang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278030#comment-16278030 ] mingleizhang commented on FLINK-8192: - [~tzulitai] I would create a subtask of Elasticsearch if you

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277998#comment-16277998 ] ASF GitHub Bot commented on FLINK-7574: --- Github user yew1eb commented on the issue:

[GitHub] flink issue #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-12-04 Thread yew1eb
Github user yew1eb commented on the issue: https://github.com/apache/flink/pull/5076 @zentol thanks for your review. I have updated the PR. `mvn clean verify -Dverbose -pl flink-clients`,No dependency problems found: ``` [INFO] ---

[jira] [Closed] (FLINK-8195) Add Redis Sink

2017-12-04 Thread Wind (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wind closed FLINK-8195. --- Resolution: Fixed > Add Redis Sink > -- > > Key: FLINK-8195 > URL:

[jira] [Created] (FLINK-8198) Useless check against -1 in LimitedConnectionsFileSystem#fromConfig

2017-12-04 Thread Ted Yu (JIRA)
Ted Yu created FLINK-8198: - Summary: Useless check against -1 in LimitedConnectionsFileSystem#fromConfig Key: FLINK-8198 URL: https://issues.apache.org/jira/browse/FLINK-8198 Project: Flink Issue

[jira] [Commented] (FLINK-7129) Dynamically changing patterns

2017-12-04 Thread Che Lui Shum (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277802#comment-16277802 ] Che Lui Shum commented on FLINK-7129: - Hi [~dawidwys], is there any plan to include this JIRA in the

[jira] [Commented] (FLINK-8197) Support include conf directories in flink config

2017-12-04 Thread Eron Wright (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277767#comment-16277767 ] Eron Wright commented on FLINK-8197: - Just an (obvious) suggestion: consider the included path to be

[jira] [Closed] (FLINK-8196) Fix Hadoop Servlet Dependency Exclusion

2017-12-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-8196. --- > Fix Hadoop Servlet Dependency Exclusion > --- > >

[jira] [Resolved] (FLINK-8196) Fix Hadoop Servlet Dependency Exclusion

2017-12-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-8196. - Resolution: Fixed Fix Version/s: 1.5.0 Fixed in - 1.4.0 via

[jira] [Created] (FLINK-8197) Support include conf directories in flink config

2017-12-04 Thread Hao Sun (JIRA)
Hao Sun created FLINK-8197: -- Summary: Support include conf directories in flink config Key: FLINK-8197 URL: https://issues.apache.org/jira/browse/FLINK-8197 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277305#comment-16277305 ] ASF GitHub Bot commented on FLINK-8176: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-04 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r154748301 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/DispatcherTest.java --- @@ -244,7 +302,32 @@ protected JobManagerRunner

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277300#comment-16277300 ] ASF GitHub Bot commented on FLINK-8176: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-04 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5107#discussion_r154747386 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -534,6 +536,40 @@ public void handleError(final Exception

[jira] [Commented] (FLINK-8176) Dispatcher does not start SubmittedJobGraphStore

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277296#comment-16277296 ] ASF GitHub Bot commented on FLINK-8176: --- GitHub user GJL reopened a pull request:

[GitHub] flink pull request #5107: [FLINK-8176][flip6] Start SubmittedJobGraphStore i...

2017-12-04 Thread GJL
GitHub user GJL reopened a pull request: https://github.com/apache/flink/pull/5107 [FLINK-8176][flip6] Start SubmittedJobGraphStore in Dispatcher ## What is the purpose of the change The FLIP-6 dispatcher never calls `start()` on its SubmittedJobGraphStore instance. Hence,

[jira] [Commented] (FLINK-6590) Integrate generated tables into documentation

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277285#comment-16277285 ] ASF GitHub Bot commented on FLINK-6590: --- Github user zentol closed the pull request at:

[GitHub] flink pull request #3916: [FLINK-6590] Integrate automatic docs generation

2017-12-04 Thread zentol
Github user zentol closed the pull request at: https://github.com/apache/flink/pull/3916 ---

[jira] [Commented] (FLINK-8116) Stale comments referring to Checkpointed interface

2017-12-04 Thread Ankit Parashar (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277280#comment-16277280 ] Ankit Parashar commented on FLINK-8116: --- Hi [~ggevay] , I have made the required changes, can you

[jira] [Commented] (FLINK-8116) Stale comments referring to Checkpointed interface

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277274#comment-16277274 ] ASF GitHub Bot commented on FLINK-8116: --- GitHub user ankitiitb1069 opened a pull request:

[GitHub] flink pull request #5121: [FLINK-8116] Stale comments referring to Checkpoin...

2017-12-04 Thread ankitiitb1069
GitHub user ankitiitb1069 opened a pull request: https://github.com/apache/flink/pull/5121 [FLINK-8116] Stale comments referring to Checkpointed interface ## What is the purpose of the change This pull request replaces the stale comments referring to Checkpointed interface

[jira] [Commented] (FLINK-8193) Rework quickstart exclusions

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277258#comment-16277258 ] ASF GitHub Bot commented on FLINK-8193: --- Github user zentol commented on the issue:

[GitHub] flink issue #5118: [FLINK-8193][quickstart] Cleanup quickstart poms

2017-12-04 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5118 I'll add flink-clients again with a comment. ---

[jira] [Commented] (FLINK-8193) Rework quickstart exclusions

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277250#comment-16277250 ] ASF GitHub Bot commented on FLINK-8193: --- Github user zentol commented on the issue:

[GitHub] flink issue #5118: [FLINK-8193][quickstart] Cleanup quickstart poms

2017-12-04 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5118 `flink-core` is a direct dependency due to the usage of the

[jira] [Updated] (FLINK-8196) Fix Hadoop Servlet Dependency Exclusion

2017-12-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-8196: -- Summary: Fix Hadoop Servlet Dependency Exclusion (was: Fix Hadoop Servled Dependency Exclusion) > Fix Hadoop

[jira] [Commented] (FLINK-8174) Mesos RM unable to accept offers for unreserved resources

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277150#comment-16277150 ] ASF GitHub Bot commented on FLINK-8174: --- Github user tillrohrmann commented on the issue:

[jira] [Created] (FLINK-8196) Fix Hadoop Servled Dependency Exclusion

2017-12-04 Thread Stephan Ewen (JIRA)
Stephan Ewen created FLINK-8196: --- Summary: Fix Hadoop Servled Dependency Exclusion Key: FLINK-8196 URL: https://issues.apache.org/jira/browse/FLINK-8196 Project: Flink Issue Type: Bug

[GitHub] flink issue #5114: [FLINK-8174] [mesos] Mesos RM unable to accept offers for...

2017-12-04 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5114 Thanks for your fast contribution @EronWright. I will take a closer look at the fix but from a first glance it seems that the `LaunchCoordinatorTest` fails. Could you fix this test case while I

[jira] [Commented] (FLINK-5297) Relocate Flink's Hadoop dependency and its transitive dependencies

2017-12-04 Thread Stephan Ewen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277149#comment-16277149 ] Stephan Ewen commented on FLINK-5297: - [~till.rohrmann] Is this still valid, or can we close this due

[jira] [Commented] (FLINK-8193) Rework quickstart exclusions

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277144#comment-16277144 ] ASF GitHub Bot commented on FLINK-8193: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5118: [FLINK-8193][quickstart] Cleanup quickstart poms

2017-12-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5118 Is there a way to fail the build if users do not use the `-Pbuild-jar` profile? I would assume that right now, at least half of the users build a mother-of-all-jars that includes all of Flink.

[jira] [Commented] (FLINK-8193) Rework quickstart exclusions

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277142#comment-16277142 ] ASF GitHub Bot commented on FLINK-8193: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5118: [FLINK-8193][quickstart] Cleanup quickstart poms

2017-12-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5118 I think that the change of `1.` is actually not necessary. The dependencies were good in my opinion: - `flink-core` is not directly needed, because it is a transitive dependency of

[jira] [Commented] (FLINK-8100) Consider introducing log4j-extras

2017-12-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277130#comment-16277130 ] Ted Yu commented on FLINK-8100: --- I did a brief search and found:

[jira] [Updated] (FLINK-8146) Potential resource leak in PythonPlanBinder#unzipPythonLibrary

2017-12-04 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-8146: -- Component/s: Python API > Potential resource leak in PythonPlanBinder#unzipPythonLibrary >

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277095#comment-16277095 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154710910 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -378,6 +381,11 @@ public void

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277089#comment-16277089 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154710187 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -378,6 +381,11 @@ public void

[jira] [Commented] (FLINK-7574) Remove unused dependencies from flink-clients

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277076#comment-16277076 ] ASF GitHub Bot commented on FLINK-7574: --- Github user yew1eb commented on a diff in the pull request:

[GitHub] flink pull request #5076: [FLINK-7574][build] POM Cleanup flink-clients

2017-12-04 Thread yew1eb
Github user yew1eb commented on a diff in the pull request: https://github.com/apache/flink/pull/5076#discussion_r154708511 --- Diff: pom.xml --- @@ -581,6 +581,20 @@ under the License. 0.9.10 test

[jira] [Closed] (FLINK-8190) Add extra FlinkKafkaConsumer constructors to expose pattern-based topic subscription functionality

2017-12-04 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai closed FLINK-8190. -- > Add extra FlinkKafkaConsumer constructors to expose pattern-based topic > subscription

[jira] [Commented] (FLINK-8190) Add extra FlinkKafkaConsumer constructors to expose pattern-based topic subscription functionality

2017-12-04 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277058#comment-16277058 ] Tzu-Li (Gordon) Tai commented on FLINK-8190: Merged. release-1.4:

[jira] [Resolved] (FLINK-8190) Add extra FlinkKafkaConsumer constructors to expose pattern-based topic subscription functionality

2017-12-04 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai resolved FLINK-8190. Resolution: Fixed > Add extra FlinkKafkaConsumer constructors to expose

[jira] [Commented] (FLINK-8190) Add extra FlinkKafkaConsumer constructors to expose pattern-based topic subscription functionality

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277055#comment-16277055 ] ASF GitHub Bot commented on FLINK-8190: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5117: [FLINK-8190] [kafka] Add constructors to expose to...

2017-12-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5117 ---

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277052#comment-16277052 ] ASF GitHub Bot commented on FLINK-7416: --- Github user pnowojski commented on a diff in the pull

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread pnowojski
Github user pnowojski commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154702193 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -244,54 +237,89 @@ public

[jira] [Commented] (FLINK-8190) Add extra FlinkKafkaConsumer constructors to expose pattern-based topic subscription functionality

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277045#comment-16277045 ] ASF GitHub Bot commented on FLINK-8190: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5117: [FLINK-8190] [kafka] Add constructors to expose topic pat...

2017-12-04 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5117 Thanks a lot for the review @aljoscha. I'm merging this to `master` and `release-1.4` (fixing the doc issue while merging). ---

[jira] [Updated] (FLINK-8173) Fix input unboxing and support Avro Utf8 in Table API

2017-12-04 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-8173: Summary: Fix input unboxing and support Avro Utf8 in Table API (was:

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277035#comment-16277035 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154697358 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -378,6 +381,11 @@ public void

[jira] [Commented] (FLINK-8193) Rework quickstart exclusions

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277030#comment-16277030 ] ASF GitHub Bot commented on FLINK-8193: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #5118: [FLINK-8193][quickstart] Cleanup quickstart poms

2017-12-04 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5118 The comment about "adding to the exclusions" under `a)` is outdated now. Should we maybe add the shade plugin in the profile, so that users don't accidentally build a super-fat jar?

[jira] [Commented] (FLINK-8195) Add Redis Sink

2017-12-04 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277020#comment-16277020 ] Fabian Hueske commented on FLINK-8195: -- A Redis connector is available in the Apache Bahir project:

[GitHub] flink pull request #:

2017-12-04 Thread aljoscha
Github user aljoscha commented on the pull request: https://github.com/apache/flink/commit/aa1f8f31c01d8fd4ae5bdaaf48c44aadc221#commitcomment-26036557 In flink-yarn/src/test/java/org/apache/flink/yarn/UtilsTest.java: In

[jira] [Commented] (FLINK-8186) AvroInputFormat regression: fails to deserialize GenericRecords on standalone cluster with hadoop27 compat

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276992#comment-16276992 ] ASF GitHub Bot commented on FLINK-8186: --- Github user aljoscha commented on the issue:

[jira] [Created] (FLINK-8195) Add Redis Sink

2017-12-04 Thread Wind (JIRA)
Wind created FLINK-8195: --- Summary: Add Redis Sink Key: FLINK-8195 URL: https://issues.apache.org/jira/browse/FLINK-8195 Project: Flink Issue Type: New Feature Reporter: Wind I think we

[GitHub] flink issue #5120: [FLINK-8186] Exclude flink-avro from flink-dist; fix Avro...

2017-12-04 Thread aljoscha
Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5120 @zentol I think so, yes. First, I only excluded, which led me to discover the problem with `AvroUtils` and them not using the right classloader to dynamically load the them. ---

[jira] [Closed] (FLINK-8194) Disable akka.actor.warn-about-java-serializer-usage to suppress akka warnings when using the Java serializer

2017-12-04 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-8194. Resolution: Fixed 1.5.0: 2d1d4dd763ddcc8166bf26492e4950089c10f64e 1.4.0:

[jira] [Created] (FLINK-8194) Disable akka.actor.warn-about-java-serializer-usage to suppress akka warnings when using the Java serializer

2017-12-04 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-8194: Summary: Disable akka.actor.warn-about-java-serializer-usage to suppress akka warnings when using the Java serializer Key: FLINK-8194 URL:

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276968#comment-16276968 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154685383 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -244,54 +237,89 @@ public void

[jira] [Commented] (FLINK-8186) AvroInputFormat regression: fails to deserialize GenericRecords on standalone cluster with hadoop27 compat

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276952#comment-16276952 ] ASF GitHub Bot commented on FLINK-8186: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5120: [FLINK-8186] Exclude flink-avro from flink-dist; fix Avro...

2017-12-04 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5120 Looks good to me. This is actually two fixes in one: 1. Avro should not be in `flink-dist`, because starting with `org.apache.flink`, it would always be loaded *"parent first"*. That

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154680022 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -378,6 +381,11 @@ public void

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276939#comment-16276939 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff in the pull

[jira] [Commented] (FLINK-8186) AvroInputFormat regression: fails to deserialize GenericRecords on standalone cluster with hadoop27 compat

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276932#comment-16276932 ] ASF GitHub Bot commented on FLINK-8186: --- Github user zentol commented on the issue:

[GitHub] flink issue #5120: [FLINK-8186] Exclude flink-avro from flink-dist; fix Avro...

2017-12-04 Thread zentol
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5120 is the exclusion from flink-dist still necessary? ---

[jira] [Commented] (FLINK-8186) AvroInputFormat regression: fails to deserialize GenericRecords on standalone cluster with hadoop27 compat

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276928#comment-16276928 ] ASF GitHub Bot commented on FLINK-8186: --- GitHub user aljoscha opened a pull request:

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276927#comment-16276927 ] ASF GitHub Bot commented on FLINK-7416: --- Github user zhijiangW commented on a diff in the pull

[GitHub] flink pull request #5120: [FLINK-8186] Exclude flink-avro from flink-dist; f...

2017-12-04 Thread aljoscha
GitHub user aljoscha opened a pull request: https://github.com/apache/flink/pull/5120 [FLINK-8186] Exclude flink-avro from flink-dist; fix AvroUtils loading Before, AvroUtils were loaded when the class was loaded which didn't take into account the user-code ClassLoader. Now, we

[jira] [Commented] (FLINK-8186) AvroInputFormat regression: fails to deserialize GenericRecords on standalone cluster with hadoop27 compat

2017-12-04 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276924#comment-16276924 ] Aljoscha Krettek commented on FLINK-8186: - I have a fix for this, PR coming up in a minute. >

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread zhijiangW
Github user zhijiangW commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154676972 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -244,54 +237,89 @@ public

[jira] [Assigned] (FLINK-8186) AvroInputFormat regression: fails to deserialize GenericRecords on standalone cluster with hadoop27 compat

2017-12-04 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek reassigned FLINK-8186: --- Assignee: Aljoscha Krettek > AvroInputFormat regression: fails to deserialize

[jira] [Commented] (FLINK-7395) NumBytesOut metric in RecordWriter call synchronized method

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276922#comment-16276922 ] ASF GitHub Bot commented on FLINK-7395: --- Github user NicoK commented on the issue:

[GitHub] flink issue #4504: [FLINK-7395] [metrics] Count bytesIn/Out without synchron...

2017-12-04 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/4504 or, we may add these fields as a metric, actually - but let's discuss this elsewhere ---

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276916#comment-16276916 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154675125 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/RemoteInputChannel.java --- @@ -280,94 +280,120 @@ public String

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276918#comment-16276918 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154674880 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java --- @@ -108,17 +117,75 @@ public void

[jira] [Commented] (FLINK-7416) Implement Netty receiver outgoing pipeline for credit-based

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276910#comment-16276910 ] ASF GitHub Bot commented on FLINK-7416: --- Github user NicoK commented on a diff in the pull request:

[GitHub] flink pull request #4533: [FLINK-7416][network] Implement Netty receiver out...

2017-12-04 Thread NicoK
Github user NicoK commented on a diff in the pull request: https://github.com/apache/flink/pull/4533#discussion_r154673167 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClient.java --- @@ -167,6 +167,13 @@ public void

[jira] [Commented] (FLINK-7692) Support user-defined variables in Metrics

2017-12-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276905#comment-16276905 ] ASF GitHub Bot commented on FLINK-7692: --- Github user tony810430 commented on a diff in the pull

[GitHub] flink pull request #5115: [FLINK-7692] [metrics] Support user-defined variab...

2017-12-04 Thread tony810430
Github user tony810430 commented on a diff in the pull request: https://github.com/apache/flink/pull/5115#discussion_r154672680 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java --- @@ -409,6 +404,22 @@ public MetricGroup

  1   2   3   >