[jira] [Assigned] (FLINK-8300) Make JobExecutionResult accessible in per-job cluster mode

2017-12-20 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao reassigned FLINK-8300: --- Assignee: (was: Gary Yao) Summary: Make JobExecutionResult accessible in per-job cluster

[jira] [Commented] (FLINK-8226) Dangling reference generated after NFA clean up timed out SharedBufferEntry

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299644#comment-16299644 ] ASF GitHub Bot commented on FLINK-8226: --- Github user dianfu commented on the issue:

[GitHub] flink issue #5141: [FLINK-8226] [cep] Dangling reference generated after NFA...

2017-12-20 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/5141 @dawidwys Could you help to take a look at this PR? This is a bug fix and the issue can be easily reproduced with the test case included in the PR. Thanks a lot. ---

[GitHub] flink issue #5142: [FLINK-8227] Optimize the performance of SharedBufferSeri...

2017-12-20 Thread dianfu
Github user dianfu commented on the issue: https://github.com/apache/flink/pull/5142 @dawidwys @StephanEwen Sorry for late response. For question 1 and 2, I have the same thought with @dawidwys and have updated the PR accordingly. For question 3, I think `int` is enough as we

[jira] [Commented] (FLINK-8227) Optimize the performance of SharedBufferSerializer

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299640#comment-16299640 ] ASF GitHub Bot commented on FLINK-8227: --- Github user dianfu commented on the issue:

[GitHub] flink pull request #5182: [FLINK-8162] [kinesis-connector] Emit Kinesis' mil...

2017-12-20 Thread casidiablo
Github user casidiablo commented on a diff in the pull request: https://github.com/apache/flink/pull/5182#discussion_r158194237 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -96,6

[jira] [Commented] (FLINK-8162) Kinesis Connector to report millisBehindLatest metric

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299527#comment-16299527 ] ASF GitHub Bot commented on FLINK-8162: --- Github user casidiablo commented on a diff in the pull

[jira] [Commented] (FLINK-8162) Kinesis Connector to report millisBehindLatest metric

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299514#comment-16299514 ] ASF GitHub Bot commented on FLINK-8162: --- Github user casidiablo commented on a diff in the pull

[GitHub] flink pull request #5182: [FLINK-8162] [kinesis-connector] Emit Kinesis' mil...

2017-12-20 Thread casidiablo
Github user casidiablo commented on a diff in the pull request: https://github.com/apache/flink/pull/5182#discussion_r158192923 --- Diff: docs/monitoring/metrics.md --- @@ -1293,6 +1293,29 @@ Thus, in order to infer the metric identifier: + Kinesis

[jira] [Updated] (FLINK-8037) Missing cast in integer arithmetic in TransactionalIdsGenerator#generateIdsToAbort

2017-12-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-8037: -- Description: {code} public Set generateIdsToAbort() { Set idsToAbort = new HashSet<>(); for (int i =

[jira] [Commented] (FLINK-8271) upgrade from deprecated classes to AmazonKinesis

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299275#comment-16299275 ] ASF GitHub Bot commented on FLINK-8271: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8271) upgrade from deprecated classes to AmazonKinesis

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299274#comment-16299274 ] ASF GitHub Bot commented on FLINK-8271: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5171: [FLINK-8271][Kinesis connector] upgrade deprecated...

2017-12-20 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5171#discussion_r158166090 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AWSUtil.java --- @@ -30,37 +30,44 @@

[GitHub] flink pull request #5171: [FLINK-8271][Kinesis connector] upgrade deprecated...

2017-12-20 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5171#discussion_r158164454 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AWSUtil.java --- @@ -30,37 +30,44 @@

[jira] [Commented] (FLINK-8271) upgrade from deprecated classes to AmazonKinesis

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299259#comment-16299259 ] ASF GitHub Bot commented on FLINK-8271: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5171: [FLINK-8271][Kinesis connector] upgrade deprecated...

2017-12-20 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5171#discussion_r158163793 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/AWSUtil.java --- @@ -30,37 +30,44 @@

[jira] [Commented] (FLINK-8162) Kinesis Connector to report millisBehindLatest metric

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299238#comment-16299238 ] ASF GitHub Bot commented on FLINK-8162: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5182: [FLINK-8162] [kinesis-connector] Emit Kinesis' mil...

2017-12-20 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5182#discussion_r158160866 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -96,6

[jira] [Commented] (FLINK-8162) Kinesis Connector to report millisBehindLatest metric

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299236#comment-16299236 ] ASF GitHub Bot commented on FLINK-8162: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8162) Kinesis Connector to report millisBehindLatest metric

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299240#comment-16299240 ] ASF GitHub Bot commented on FLINK-8162: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8162) Kinesis Connector to report millisBehindLatest metric

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299237#comment-16299237 ] ASF GitHub Bot commented on FLINK-8162: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5182: [FLINK-8162] [kinesis-connector] Emit Kinesis' mil...

2017-12-20 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5182#discussion_r158159640 --- Diff: docs/monitoring/metrics.md --- @@ -1293,6 +1293,29 @@ Thus, in order to infer the metric identifier: + Kinesis

[GitHub] flink pull request #5182: [FLINK-8162] [kinesis-connector] Emit Kinesis' mil...

2017-12-20 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5182#discussion_r158161267 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -96,6

[GitHub] flink pull request #5182: [FLINK-8162] [kinesis-connector] Emit Kinesis' mil...

2017-12-20 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5182#discussion_r158161564 --- Diff: flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/ShardConsumer.java --- @@ -96,6

[jira] [Commented] (FLINK-7795) Utilize error-prone to discover common coding mistakes

2017-12-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299208#comment-16299208 ] Ted Yu commented on FLINK-7795: --- https://github.com/google/error-prone/releases/tag/v2.1.3 was the latest

[jira] [Commented] (FLINK-7525) Add config option to disable Cancel functionality on UI

2017-12-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299205#comment-16299205 ] Ted Yu commented on FLINK-7525: --- What should be the next step ? > Add config option to disable Cancel

[GitHub] flink issue #5191: Release 1.4

2017-12-20 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5191 This seems like a mistakenly opened PR. Can you please close this, @czhxmz? Thanks! ---

[GitHub] flink issue #5187: Merge pull request #1 from apache/master

2017-12-20 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5187 This seems like a mistake. @laolang113 can you please close this PR? Thanks! ---

[GitHub] flink issue #5195: [hotfix] [build] Always include Kafka 0.11 connector

2017-12-20 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5195 +1, LGTM ---

[jira] [Commented] (FLINK-8283) FlinkKafkaConsumerBase failing on Travis with no output in 10min

2017-12-20 Thread Tzu-Li (Gordon) Tai (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16299058#comment-16299058 ] Tzu-Li (Gordon) Tai commented on FLINK-8283: I'm suspecting that the Travis infra updates on

[jira] [Commented] (FLINK-8297) RocksDBListState stores whole list in single byte[]

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298961#comment-16298961 ] ASF GitHub Bot commented on FLINK-8297: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5185: [FLINK-8297] [flink-rocksdb] optionally use RocksDBMapSta...

2017-12-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5185 This might be a great chance to start discussing how ListState APIs should evolve - specifically, is it time to consider adding `remove()` to ListState? ---

[GitHub] flink pull request #5195: [hotfix] [build] Always include Kafka 0.11 connect...

2017-12-20 Thread greghogan
GitHub user greghogan opened a pull request: https://github.com/apache/flink/pull/5195 [hotfix] [build] Always include Kafka 0.11 connector Now that Flink only supports builds for Scala 2.11+ we can unconditionally enable the Kafka 0.11 connector. You can merge this pull request

[jira] [Commented] (FLINK-8271) upgrade from deprecated classes to AmazonKinesis

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298835#comment-16298835 ] ASF GitHub Bot commented on FLINK-8271: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5171: [FLINK-8271][Kinesis connector] upgrade deprecated method...

2017-12-20 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5171 You are right. Thank you, Gordon. I updated the PR title ---

[jira] [Comment Edited] (FLINK-7588) Document RocksDB tuning for spinning disks

2017-12-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258309#comment-16258309 ] Ted Yu edited comment on FLINK-7588 at 12/20/17 6:02 PM: - bq. Be careful about

[jira] [Updated] (FLINK-7897) Consider using nio.Files for file deletion in TransientBlobCleanupTask

2017-12-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-7897: -- Description: nio.Files#delete() provides better clue as to why the deletion may fail:

[jira] [Resolved] (FLINK-8295) Netty shading does not work properly

2017-12-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther resolved FLINK-8295. - Resolution: Fixed Fix Version/s: 1.4.1 1.5.0 Fixed in 1.5:

[jira] [Commented] (FLINK-8295) Netty shading does not work properly

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298771#comment-16298771 ] ASF GitHub Bot commented on FLINK-8295: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5183: [FLINK-8295][cassandra][build] properly shade nett...

2017-12-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5183 ---

[jira] [Commented] (FLINK-8295) Netty shading does not work properly

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298765#comment-16298765 ] ASF GitHub Bot commented on FLINK-8295: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...

2017-12-20 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5183 I tested it locally. Will merge this now... ---

[jira] [Commented] (FLINK-8233) Expose JobExecutionResult via HTTP

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298752#comment-16298752 ] ASF GitHub Bot commented on FLINK-8233: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5194: [FLINK-8233][flip6] Add JobExecutionResultHandler

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5194#discussion_r158081176 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/JobExecutionResultDeserializer.java --- @@ -0,0 +1,153 @@ +/* + *

[GitHub] flink pull request #5194: [FLINK-8233][flip6] Add JobExecutionResultHandler

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5194#discussion_r158078273 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/json/JobExecutionResultDeserializer.java --- @@ -0,0 +1,153 @@ +/* + *

[jira] [Commented] (FLINK-8233) Expose JobExecutionResult via HTTP

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298732#comment-16298732 ] ASF GitHub Bot commented on FLINK-8233: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8281) org.apache.flink.runtime.fs.hdfs.HadoopDataOutputStream cannot be cast to org.apache.flink.core.fs.WrappingProxyCloseable

2017-12-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298723#comment-16298723 ] Timo Walther commented on FLINK-8281: - Sorry, I haven't seen that this issue is already resolved. >

[jira] [Updated] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

2017-12-20 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8234: Description: In order to serve the {{JobExecutionResults}} we have to cache them in the {{Dispatcher}}

[jira] [Commented] (FLINK-8281) org.apache.flink.runtime.fs.hdfs.HadoopDataOutputStream cannot be cast to org.apache.flink.core.fs.WrappingProxyCloseable

2017-12-20 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298716#comment-16298716 ] Timo Walther commented on FLINK-8281: - [~brucewoo] can you tell us a bit more about your environment?

[jira] [Updated] (FLINK-8300) Make JobExecutionResult accessible from JobMaster

2017-12-20 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8300: Description: In order to serve the {{JobExecutionResults}} we have to cache them in the {{JobMaster}} after

[jira] [Created] (FLINK-8300) Make JobExecutionResult accessible from JobMaster

2017-12-20 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8300: --- Summary: Make JobExecutionResult accessible from JobMaster Key: FLINK-8300 URL: https://issues.apache.org/jira/browse/FLINK-8300 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-8292) Remove unnecessary force cast in DataStreamSource

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298658#comment-16298658 ] ASF GitHub Bot commented on FLINK-8292: --- Github user greghogan commented on the issue:

[GitHub] flink issue #5180: [FLINK-8292] Remove unnecessary force cast in DataStreamS...

2017-12-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5180 +0 ---

[jira] [Updated] (FLINK-8233) Expose JobExecutionResult via HTTP

2017-12-20 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8233: Description: Expose {{JobExecutionResult}} from a finished Flink job via HTTP: * Add a new

[jira] [Updated] (FLINK-8233) Expose JobExecutionResult via HTTP

2017-12-20 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-8233: Summary: Expose JobExecutionResult via HTTP (was: Retrieve ExecutionResult by REST polling) > Expose

[jira] [Created] (FLINK-8299) Retrieve ExecutionResult by REST polling

2017-12-20 Thread Gary Yao (JIRA)
Gary Yao created FLINK-8299: --- Summary: Retrieve ExecutionResult by REST polling Key: FLINK-8299 URL: https://issues.apache.org/jira/browse/FLINK-8299 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-8280) Enable checkstyle for org.apache.flink.runtime.blob

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298650#comment-16298650 ] ASF GitHub Bot commented on FLINK-8280: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #5175: [FLINK-8280][checkstyle] fix checkstyle in BlobSer...

2017-12-20 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5175#discussion_r158056059 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/blob/BlobUtils.java --- @@ -150,8 +150,7 @@ static File initLocalStorageDirectory(String

[jira] [Created] (FLINK-8298) Shutdown MockEnvironment

2017-12-20 Thread Piotr Nowojski (JIRA)
Piotr Nowojski created FLINK-8298: - Summary: Shutdown MockEnvironment Key: FLINK-8298 URL: https://issues.apache.org/jira/browse/FLINK-8298 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-8079) Skip remaining E2E tests if one failed

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298598#comment-16298598 ] ASF GitHub Bot commented on FLINK-8079: --- Github user greghogan commented on a diff in the pull

[GitHub] flink pull request #5156: [FLINK-8079][tests] Stop end-to-end test execution...

2017-12-20 Thread greghogan
Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5156#discussion_r158037581 --- Diff: tools/travis_mvn_watchdog.sh --- @@ -543,35 +543,45 @@ case $TEST in printf "Running end-to-end tests\n"

[jira] [Commented] (FLINK-8222) Update Scala version

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298583#comment-16298583 ] ASF GitHub Bot commented on FLINK-8222: --- Github user greghogan commented on the issue:

[GitHub] flink issue #5136: [FLINK-8222] [build] Update Scala version

2017-12-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5136 I'll merge this to 1.5 only. ---

[jira] [Updated] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-12-20 Thread Greg Hogan (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Hogan updated FLINK-5506: -- Fix Version/s: 1.4.1 1.5.0 > Java 8 - CommunityDetection.java:158 -

[jira] [Commented] (FLINK-5506) Java 8 - CommunityDetection.java:158 - java.lang.NullPointerException

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298563#comment-16298563 ] ASF GitHub Bot commented on FLINK-5506: --- Github user greghogan commented on the issue:

[GitHub] flink issue #5126: [FLINK-5506] [gelly] Fix CommunityDetection NullPointerEx...

2017-12-20 Thread greghogan
Github user greghogan commented on the issue: https://github.com/apache/flink/pull/5126 @StephanEwen thanks for the tip. I'll remove the added `TypeHint` methods and commit to 1.4 and 1.5. ---

[jira] [Commented] (FLINK-8233) Retrieve ExecutionResult by REST polling

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298531#comment-16298531 ] ASF GitHub Bot commented on FLINK-8233: --- GitHub user GJL opened a pull request:

[GitHub] flink pull request #5194: [FLINK-8233][flip6] Add JobExecutionResultHandler

2017-12-20 Thread GJL
GitHub user GJL opened a pull request: https://github.com/apache/flink/pull/5194 [FLINK-8233][flip6] Add JobExecutionResultHandler ## What is the purpose of the change *Allow retrieval of the JobExecutionResult cached in Dispatcher via HTTP. This will be needed so that

[jira] [Assigned] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2017-12-20 Thread Piotr Nowojski (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-8268: - Assignee: Piotr Nowojski > Test instability for 'TwoPhaseCommitSinkFunctionTest' >

[jira] [Commented] (FLINK-8268) Test instability for 'TwoPhaseCommitSinkFunctionTest'

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298389#comment-16298389 ] ASF GitHub Bot commented on FLINK-8268: --- GitHub user pnowojski opened a pull request:

[GitHub] flink pull request #5193: [FLINK-8268][tests] Improve tests stability

2017-12-20 Thread pnowojski
GitHub user pnowojski opened a pull request: https://github.com/apache/flink/pull/5193 [FLINK-8268][tests] Improve tests stability This is a walk-around an error reported in the issue: https://issues.apache.org/jira/browse/FLINK-8268 . Instead of writing files to disk, this PR

[jira] [Commented] (FLINK-8257) Unify the value checks for setParallelism()

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298303#comment-16298303 ] ASF GitHub Bot commented on FLINK-8257: --- GitHub user xccui opened a pull request:

[GitHub] flink pull request #5192: [FLINK-8257] [conf] Unify the value checks for set...

2017-12-20 Thread xccui
GitHub user xccui opened a pull request: https://github.com/apache/flink/pull/5192 [FLINK-8257] [conf] Unify the value checks for setParallelism() ## What is the purpose of the change This PR unifies the value checks for `setParallelism()` methods in different components.

[GitHub] flink pull request #5191: Release 1.4

2017-12-20 Thread czhxmz
GitHub user czhxmz opened a pull request: https://github.com/apache/flink/pull/5191 Release 1.4 *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way,

[jira] [Commented] (FLINK-8289) The RestServerEndpoint should return the address with real ip when getRestAdddress

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298177#comment-16298177 ] ASF GitHub Bot commented on FLINK-8289: --- GitHub user shuai-xu opened a pull request:

[GitHub] flink pull request #5190: [FLINK-8289] [runtime] set the rest.address to the...

2017-12-20 Thread shuai-xu
GitHub user shuai-xu opened a pull request: https://github.com/apache/flink/pull/5190 [FLINK-8289] [runtime] set the rest.address to the host of the rest server machine ## What is the purpose of the change This pull request set the rest.address to the host of the

[jira] [Commented] (FLINK-8271) upgrade from deprecated classes to AmazonKinesis

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298162#comment-16298162 ] ASF GitHub Bot commented on FLINK-8271: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5171: [FLINK-8271][Kinesis connector] upgrade from deprecated c...

2017-12-20 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5171 Ah, I see. The `AmazonKinesisClient` class is not deprecated, but the constructors are. Alright, thanks for the clarification. I'll find some time to revisit this PR tomorrow. ---

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

2017-12-20 Thread cttestid41 (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298159#comment-16298159 ] cttestid41 commented on FLINK-8234: --- Test comment > Cache JobExecutionResult from finished

[jira] [Commented] (FLINK-8283) FlinkKafkaConsumerBase failing on Travis with no output in 10min

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298157#comment-16298157 ] ASF GitHub Bot commented on FLINK-8283: --- Github user tzulitai commented on the issue:

[GitHub] flink issue #5181: [FLINK-8283] [kafka] Fix mock verification on final metho...

2017-12-20 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5181 Also FYI: The stalling tests seems to have been fixed (indirectly?) by fixing the mocking issue. No failures have occurred anymore over 10 test local Travis runs. ---

[jira] [Commented] (FLINK-8283) FlinkKafkaConsumerBase failing on Travis with no output in 10min

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298155#comment-16298155 ] ASF GitHub Bot commented on FLINK-8283: --- Github user tzulitai closed the pull request at:

[jira] [Commented] (FLINK-8283) FlinkKafkaConsumerBase failing on Travis with no output in 10min

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298154#comment-16298154 ] ASF GitHub Bot commented on FLINK-8283: --- Github user tzulitai commented on the issue:

[GitHub] flink pull request #5181: [FLINK-8283] [kafka] Fix mock verification on fina...

2017-12-20 Thread tzulitai
Github user tzulitai closed the pull request at: https://github.com/apache/flink/pull/5181 ---

[GitHub] flink issue #5181: [FLINK-8283] [kafka] Fix mock verification on final metho...

2017-12-20 Thread tzulitai
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5181 Making the `AbstractFetcher::commitInternalOffsetsToKafka` non-final just for the sake of testing using mocks really is not ideal. I've opened a new PR #5189 that properly solves this by

[jira] [Commented] (FLINK-8283) FlinkKafkaConsumerBase failing on Travis with no output in 10min

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298151#comment-16298151 ] ASF GitHub Bot commented on FLINK-8283: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #5189: [FLINK-8283] [kafka] Introduce KafkaOffsetCommitte...

2017-12-20 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/5189 [FLINK-8283] [kafka] Introduce KafkaOffsetCommitter interface ## What is the purpose of the change This PR is built upon the reworked `FlinkKafkaConsumerBaseTest` in #5188. The broken

[GitHub] flink issue #4559: [FLINK-7468][network] Implement sender backlog logic for ...

2017-12-20 Thread zhijiangW
Github user zhijiangW commented on the issue: https://github.com/apache/flink/pull/4559 @NicoK , I have submitted the `hotfix` commit to address above comments. ---

[jira] [Commented] (FLINK-7468) Implement sender backlog logic for credit-based

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298149#comment-16298149 ] ASF GitHub Bot commented on FLINK-7468: --- Github user zhijiangW commented on the issue:

[jira] [Commented] (FLINK-8295) Netty shading does not work properly

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298145#comment-16298145 ] ASF GitHub Bot commented on FLINK-8295: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...

2017-12-20 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5183 Thanks for the fix @NicoK. I will have a look at it later today and merge this. ---

[jira] [Commented] (FLINK-8296) Rework FlinkKafkaConsumerBestTest to not use Java reflection for dependency injection

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298137#comment-16298137 ] ASF GitHub Bot commented on FLINK-8296: --- GitHub user tzulitai opened a pull request:

[GitHub] flink pull request #5188: [FLINK-8296] [kafka] Rework FlinkKafkaConsumerBase...

2017-12-20 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/5188 [FLINK-8296] [kafka] Rework FlinkKafkaConsumerBaseTest to not rely on Java reflection ## What is the purpose of the change Prior to this PR, reflection was mainly used to inject mocks

[jira] [Commented] (FLINK-8295) Netty shading does not work properly

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298135#comment-16298135 ] ASF GitHub Bot commented on FLINK-8295: --- Github user NicoK commented on the issue:

[GitHub] flink issue #5183: [FLINK-8295][cassandra][build] properly shade netty for t...

2017-12-20 Thread NicoK
Github user NicoK commented on the issue: https://github.com/apache/flink/pull/5183 true - I adapted the comment accordingly ---

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298092#comment-16298092 ] ASF GitHub Bot commented on FLINK-8234: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157963387 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java --- @@ -405,22 +407,27 @@ private void

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298081#comment-16298081 ] ASF GitHub Bot commented on FLINK-8234: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5184: [FLINK-8234][flip6] Cache JobExecutionResult in Di...

2017-12-20 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5184#discussion_r157962431 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniClusterJobDispatcher.java --- @@ -458,7 +465,14 @@ public JobExecutionResult

[jira] [Commented] (FLINK-8234) Cache JobExecutionResult from finished JobManagerRunners

2017-12-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16298065#comment-16298065 ] ASF GitHub Bot commented on FLINK-8234: --- Github user GJL commented on the issue:

  1   2   >