[jira] [Commented] (FLINK-7934) Upgrade Calcite dependency to 1.15

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340668#comment-16340668 ] ASF GitHub Bot commented on FLINK-7934: --- Github user suez1224 commented on the issue:

[GitHub] flink issue #5355: [FLINK-7934][Table & SQL API] Upgrade Flink to use Calcit...

2018-01-25 Thread suez1224
Github user suez1224 commented on the issue: https://github.com/apache/flink/pull/5355 @bowenli86 The following two features are related to this PR. [CALCITE-2016] Make item + dot operators work for array (e.g. SELECT orders[5].color FROM t (Shuyi Chen) [CALCITE-1867] Allow

[jira] [Commented] (FLINK-8514) move flink-connector-wikiedits to Apache Bahir

2018-01-25 Thread Ufuk Celebi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340667#comment-16340667 ] Ufuk Celebi commented on FLINK-8514: +1   > move flink-connector-wikiedits to Apache Bahir >

[jira] [Commented] (FLINK-7923) SQL parser exception when accessing subfields of a Composite element in an Object Array type column

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340658#comment-16340658 ] ASF GitHub Bot commented on FLINK-7923: --- GitHub user suez1224 opened a pull request:

[GitHub] flink pull request #5367: [FLINK-7923][Table API & SQL] Support field access...

2018-01-25 Thread suez1224
GitHub user suez1224 opened a pull request: https://github.com/apache/flink/pull/5367 [FLINK-7923][Table API & SQL] Support field access of composite array element in SQL Note: This is based on FLINK-7934, will rebase once FLINK-7934 is resolved. ## What is the purpose of

[jira] [Commented] (FLINK-6623) BlobCacheSuccessTest fails on Windows

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340637#comment-16340637 ] ASF GitHub Bot commented on FLINK-6623: --- Github user StephanEwen commented on the issue:

[GitHub] flink issue #5351: [FLINK-6623][Blob] BlobServer#putBuffer moves file after ...

2018-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5351 Cool, do you want to commit both changes (this PR and the referenced branch) together? ---

[GitHub] flink issue #5338: [FLINK-8476][config][HA] Deprecate HA config constants

2018-01-25 Thread StephanEwen
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/5338 Thanks, good change, +1 ---

[jira] [Commented] (FLINK-8476) ConfigConstants#DEFAULT_HA_JOB_MANAGER_PORT unused

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340631#comment-16340631 ] ASF GitHub Bot commented on FLINK-8476: --- Github user StephanEwen commented on the issue:

[GitHub] flink pull request #5366: [hotfix] improve javadoc and logging of RocksDBKey...

2018-01-25 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5366 [hotfix] improve javadoc and logging of RocksDBKeyedStateBackend ## What is the purpose of the change General improvements on javadoc and logging of RocksDBKeyedStateBackend ##

[jira] [Commented] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-01-25 Thread Thomas Weise (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340564#comment-16340564 ] Thomas Weise commented on FLINK-8516: - Relevant piece of code:

[jira] [Commented] (FLINK-8364) Add iterator() to ListState which returns empty iterator when it has no value

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340559#comment-16340559 ] ASF GitHub Bot commented on FLINK-8364: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5356: [FLINK-8364][state backend] Add iterator() to ListState w...

2018-01-25 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5356 cc @fhueske @aljoscha ---

[jira] [Commented] (FLINK-8515) update RocksDBMapState to replace deprecated remove() with delete()

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340557#comment-16340557 ] ASF GitHub Bot commented on FLINK-8515: --- GitHub user bowenli86 opened a pull request:

[GitHub] flink pull request #5365: [FLINK-8515] update RocksDBMapState to replace dep...

2018-01-25 Thread bowenli86
GitHub user bowenli86 opened a pull request: https://github.com/apache/flink/pull/5365 [FLINK-8515] update RocksDBMapState to replace deprecated remove() with delete() ## What is the purpose of the change RocksDBMapState is currently using `rocksdb#remove()` which is

[jira] [Comment Edited] (FLINK-4534) Lack of synchronization in BucketingSink#restoreState()

2018-01-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304163#comment-16304163 ] Ted Yu edited comment on FLINK-4534 at 1/26/18 4:27 AM: Can this get more review ?

[jira] [Comment Edited] (FLINK-6105) Properly handle InterruptedException in HadoopInputFormatBase

2018-01-25 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307281#comment-16307281 ] Ted Yu edited comment on FLINK-6105 at 1/26/18 4:26 AM: In

[jira] [Created] (FLINK-8516) FlinkKinesisConsumer does not balance shards over subtasks

2018-01-25 Thread Thomas Weise (JIRA)
Thomas Weise created FLINK-8516: --- Summary: FlinkKinesisConsumer does not balance shards over subtasks Key: FLINK-8516 URL: https://issues.apache.org/jira/browse/FLINK-8516 Project: Flink Issue

[jira] [Created] (FLINK-8515) update RocksDBMapState to replace deprecated remove() with delete()

2018-01-25 Thread Bowen Li (JIRA)
Bowen Li created FLINK-8515: --- Summary: update RocksDBMapState to replace deprecated remove() with delete() Key: FLINK-8515 URL: https://issues.apache.org/jira/browse/FLINK-8515 Project: Flink

[jira] [Created] (FLINK-8514) move flink-connector-wikiedits to Apache Bahir

2018-01-25 Thread Bowen Li (JIRA)
Bowen Li created FLINK-8514: --- Summary: move flink-connector-wikiedits to Apache Bahir Key: FLINK-8514 URL: https://issues.apache.org/jira/browse/FLINK-8514 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-8448) [flink-mesos] The flink-job jars uploaded in directory 'web.upload.dir' are deleted on flink-scheduler restart

2018-01-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340524#comment-16340524 ] Chesnay Schepler commented on FLINK-8448: - I'm not really into the specifics of flink-mesos, but

[jira] [Commented] (FLINK-8189) move flink-statebackend-rocksdb out of flink-contrib

2018-01-25 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340519#comment-16340519 ] Chesnay Schepler commented on FLINK-8189: - I'm tempted to close this as "Won't fix"/"Duplicate"

[jira] [Commented] (FLINK-3089) State API Should Support Data Expiration (State TTL)

2018-01-25 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340516#comment-16340516 ] Bowen Li commented on FLINK-3089: - So TtlDB can only support one TTL in one db opening. If you close Ttldb

[jira] [Updated] (FLINK-8189) move flink-statebackend-rocksdb out of flink-contrib

2018-01-25 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8189: Description: Move {{flink-statebackend-rocksdb}} into probably its own/state-backend module or

[jira] [Updated] (FLINK-8189) move flink-statebackend-rocksdb out of flink-contrib

2018-01-25 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-8189: Description: Move {{flink-statebackend-rocksdb}} into probably its own/state-backend module or

[jira] [Commented] (FLINK-8189) move flink-statebackend-rocksdb out of flink-contrib

2018-01-25 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340436#comment-16340436 ] Bowen Li commented on FLINK-8189: - [~till.rohrmann] [~aljoscha] [~srichter] Hi guys, I'm thinking of start

[jira] [Commented] (FLINK-8490) Allow custom docker parameters for docker tasks on Mesos

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340240#comment-16340240 ] ASF GitHub Bot commented on FLINK-8490: --- Github user joerg84 commented on the issue:

[GitHub] flink issue #5346: [FLINK-8490] [mesos] Allow custom docker parameters for d...

2018-01-25 Thread joerg84
Github user joerg84 commented on the issue: https://github.com/apache/flink/pull/5346 @tillrohrmann Could you take a final look? ---

[jira] [Commented] (FLINK-7386) Flink Elasticsearch 5 connector is not compatible with Elasticsearch 5.2+ client

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340113#comment-16340113 ] ASF GitHub Bot commented on FLINK-7386: --- Github user cjolif commented on the issue:

[GitHub] flink issue #4675: [FLINK-7386] FIx Elasticsearch 5 connector is not compati...

2018-01-25 Thread cjolif
Github user cjolif commented on the issue: https://github.com/apache/flink/pull/4675 FYI I rebased it and got working results on a sample of mine. ---

[jira] [Commented] (FLINK-8267) update Kinesis Producer example for setting Region key

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339853#comment-16339853 ] ASF GitHub Bot commented on FLINK-8267: --- Github user bowenli86 commented on the issue:

[GitHub] flink issue #5301: [FLINK-8267] [Kinesis Connector] update Kinesis Producer ...

2018-01-25 Thread bowenli86
Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5301 cc @tzulitai ---

[GitHub] flink pull request #5149: [FLINK-7858][flp6] Port JobVertexTaskManagersHandl...

2018-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5149 ---

[jira] [Resolved] (FLINK-8224) Should shudownApplication when job terminated in job mode

2018-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8224. -- Resolution: Fixed Fix Version/s: 1.5.0 Fixed via 

[jira] [Commented] (FLINK-7858) Port JobVertexTaskManagersHandler to REST endpoint

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339808#comment-16339808 ] ASF GitHub Bot commented on FLINK-7858: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5170: [FLINK-8266] [runtime] add network memory to Resou...

2018-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5170 ---

[jira] [Resolved] (FLINK-7858) Port JobVertexTaskManagersHandler to REST endpoint

2018-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-7858. -- Resolution: Fixed Fix Version/s: 1.5.0 Fixed via 

[jira] [Commented] (FLINK-8224) Should shudownApplication when job terminated in job mode

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339806#comment-16339806 ] ASF GitHub Bot commented on FLINK-8224: --- Github user asfgit closed the pull request at:

[jira] [Resolved] (FLINK-8266) Add network memory to ResourceProfile

2018-01-25 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-8266. -- Resolution: Fixed Fix Version/s: 1.5.0 Fixed via 

[jira] [Commented] (FLINK-8266) Add network memory to ResourceProfile

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339807#comment-16339807 ] ASF GitHub Bot commented on FLINK-8266: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5139: [FLINK-8224] [runtime] shutdown application when j...

2018-01-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5139 ---

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163938277 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastBackendStateMetaInfo.java --- @@ -0,0 +1,232 @@ +/* + *

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163933180 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendSerializationProxy.java --- @@ -77,16 +90,29 @@ public void

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163936390 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorStateHandle.java --- @@ -36,8 +36,9 @@ * The modes that determine

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163938102 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/RegisteredBroadcastBackendStateMetaInfo.java --- @@ -0,0 +1,232 @@ +/* + *

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163935065 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendSerializationProxy.java --- @@ -77,16 +90,29 @@ public void

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163935632 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendStateMetaInfoSnapshotReaderWriters.java --- @@ -211,4 +297,34 @@

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163932401 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendSerializationProxy.java --- @@ -64,11 +70,18 @@ public int

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339693#comment-16339693 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339698#comment-16339698 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163942745 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendSerializationProxy.java --- @@ -77,16 +90,29 @@ public void

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163932956 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendSerializationProxy.java --- @@ -35,18 +35,24 @@ public

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339695#comment-16339695 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339697#comment-16339697 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339691#comment-16339691 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163934364 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendStateMetaInfoSnapshotReaderWriters.java --- @@ -112,13 +142,40 @@

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339699#comment-16339699 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339702#comment-16339702 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339701#comment-16339701 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339690#comment-16339690 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339692#comment-16339692 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163930707 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultOperatorStateBackend.java --- @@ -137,7 +155,12 @@ public ExecutionConfig

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163932340 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendSerializationProxy.java --- @@ -64,11 +70,18 @@ public int

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339700#comment-16339700 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339696#comment-16339696 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...

2018-01-25 Thread tzulitai
Github user tzulitai commented on a diff in the pull request: https://github.com/apache/flink/pull/5230#discussion_r163936903 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorStateHandle.java --- @@ -36,8 +36,9 @@ * The modes that determine

[jira] [Commented] (FLINK-8345) Iterate over keyed state on broadcast side of connect with broadcast.

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339694#comment-16339694 ] ASF GitHub Bot commented on FLINK-8345: --- Github user tzulitai commented on a diff in the pull

[jira] [Updated] (FLINK-8513) Add documentation for connecting to non-AWS S3 endpoints

2018-01-25 Thread chris snow (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chris snow updated FLINK-8513: -- Description: It would be useful if the documentation provided information on connecting to non-AWS S3

[jira] [Updated] (FLINK-8513) Add documentation for connecting to non-AWS S3 endpoints

2018-01-25 Thread chris snow (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] chris snow updated FLINK-8513: -- Description: It would be useful if the documentation provided information on connecting to non-AWS S3

[jira] [Created] (FLINK-8513) Add documentation for connecting to non-AWS S3 endpoints

2018-01-25 Thread chris snow (JIRA)
chris snow created FLINK-8513: - Summary: Add documentation for connecting to non-AWS S3 endpoints Key: FLINK-8513 URL: https://issues.apache.org/jira/browse/FLINK-8513 Project: Flink Issue Type:

[jira] [Comment Edited] (FLINK-8506) fullRestarts Gauge not incremented when jobmanager got killed

2018-01-25 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339560#comment-16339560 ] Steven Zhen Wu edited comment on FLINK-8506 at 1/25/18 6:45 PM: Till,

[GitHub] flink issue #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphStore to D...

2018-01-25 Thread GJL
Github user GJL commented on the issue: https://github.com/apache/flink/pull/5310 Is it acceptable behavior that sometimes Graphs don't get deleted from disk? ---

[jira] [Commented] (FLINK-8453) Add SerializableExecutionGraphStore to Dispatcher

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339594#comment-16339594 ] ASF GitHub Bot commented on FLINK-8453: --- Github user GJL commented on the issue:

[GitHub] flink pull request #5311: [FLINK-8454] [flip6] Remove JobExecutionResultCach...

2018-01-25 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5311#discussion_r163923585 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -100,8 +97,6 @@ private final

[jira] [Commented] (FLINK-8454) Remove JobExecutionResultCache

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339591#comment-16339591 ] ASF GitHub Bot commented on FLINK-8454: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8453) Add SerializableExecutionGraphStore to Dispatcher

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339570#comment-16339570 ] ASF GitHub Bot commented on FLINK-8453: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphSto...

2018-01-25 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5310#discussion_r163919241 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStoreTest.java --- @@ -0,0 +1,319 @@ +/* + *

[jira] [Commented] (FLINK-8453) Add SerializableExecutionGraphStore to Dispatcher

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339572#comment-16339572 ] ASF GitHub Bot commented on FLINK-8453: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphSto...

2018-01-25 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5310#discussion_r163918048 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStoreTest.java --- @@ -0,0 +1,319 @@ +/* + *

[jira] [Commented] (FLINK-8453) Add SerializableExecutionGraphStore to Dispatcher

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339573#comment-16339573 ] ASF GitHub Bot commented on FLINK-8453: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8453) Add SerializableExecutionGraphStore to Dispatcher

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339569#comment-16339569 ] ASF GitHub Bot commented on FLINK-8453: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8453) Add SerializableExecutionGraphStore to Dispatcher

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339571#comment-16339571 ] ASF GitHub Bot commented on FLINK-8453: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8453) Add SerializableExecutionGraphStore to Dispatcher

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339567#comment-16339567 ] ASF GitHub Bot commented on FLINK-8453: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphSto...

2018-01-25 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5310#discussion_r163915273 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStore.java --- @@ -0,0 +1,298 @@ +/* + * Licensed

[GitHub] flink pull request #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphSto...

2018-01-25 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5310#discussion_r163911570 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java --- @@ -486,11 +510,22 @@ private void onFatalError(Throwable

[jira] [Commented] (FLINK-8453) Add SerializableExecutionGraphStore to Dispatcher

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339568#comment-16339568 ] ASF GitHub Bot commented on FLINK-8453: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphSto...

2018-01-25 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5310#discussion_r163921620 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/concurrent/ManuallyTriggeredScheduledExecutor.java --- @@ -0,0 +1,167 @@ +/* + *

[GitHub] flink pull request #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphSto...

2018-01-25 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5310#discussion_r163922121 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStoreTest.java --- @@ -0,0 +1,319 @@ +/* + *

[GitHub] flink pull request #5310: [FLINK-8453] [flip6] Add ArchivedExecutionGraphSto...

2018-01-25 Thread GJL
Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5310#discussion_r163919921 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/FileArchivedExecutionGraphStoreTest.java --- @@ -0,0 +1,319 @@ +/* + *

[jira] [Commented] (FLINK-8506) fullRestarts Gauge not incremented when jobmanager got killed

2018-01-25 Thread Steven Zhen Wu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339560#comment-16339560 ] Steven Zhen Wu commented on FLINK-8506: --- Till, thanks for the explanation. Looks like we should

[GitHub] flink pull request #5364: Flink 8472 1.4

2018-01-25 Thread tzulitai
GitHub user tzulitai opened a pull request: https://github.com/apache/flink/pull/5364 Flink 8472 1.4 ## What is the purpose of the change Extend all migration tests, to include verifying restore from Flink 1.4 savepoints. This includes extending: -

[jira] [Commented] (FLINK-8240) Create unified interfaces to configure and instatiate TableSources

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8240?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339532#comment-16339532 ] ASF GitHub Bot commented on FLINK-8240: --- Github user twalthr commented on the issue:

[GitHub] flink issue #5240: [FLINK-8240] [table] Create unified interfaces to configu...

2018-01-25 Thread twalthr
Github user twalthr commented on the issue: https://github.com/apache/flink/pull/5240 Thanks for the feedback @fhueske. I hope I could address most of it. I think we should merge this PR (if you agree) and add more PRs for this issue as the next steps. I suggest the following

[jira] [Commented] (FLINK-8450) Make JobMaster/DispatcherGateway#requestJob type safe

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339509#comment-16339509 ] ASF GitHub Bot commented on FLINK-8450: --- Github user tillrohrmann commented on the issue:

[GitHub] flink issue #5309: [FLINK-8450] [flip6] Make JobMaster/DispatcherGateway#req...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on the issue: https://github.com/apache/flink/pull/5309 Thanks for the review @GJL. I've addressed your comments in cf9d24d and rebased onto the latest master. ---

[jira] [Commented] (FLINK-8450) Make JobMaster/DispatcherGateway#requestJob type safe

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339507#comment-16339507 ] ASF GitHub Bot commented on FLINK-8450: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5309: [FLINK-8450] [flip6] Make JobMaster/DispatcherGate...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5309#discussion_r163905384 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java --- @@ -228,10 +246,10 @@ public void

[jira] [Commented] (FLINK-8450) Make JobMaster/DispatcherGateway#requestJob type safe

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339504#comment-16339504 ] ASF GitHub Bot commented on FLINK-8450: --- Github user tillrohrmann commented on a diff in the pull

[GitHub] flink pull request #5309: [FLINK-8450] [flip6] Make JobMaster/DispatcherGate...

2018-01-25 Thread tillrohrmann
Github user tillrohrmann commented on a diff in the pull request: https://github.com/apache/flink/pull/5309#discussion_r163904466 --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/rest/handler/legacy/ExecutionGraphCacheTest.java --- @@ -199,12 +212,17 @@ public void

[jira] [Commented] (FLINK-8450) Make JobMaster/DispatcherGateway#requestJob type safe

2018-01-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339499#comment-16339499 ] ASF GitHub Bot commented on FLINK-8450: --- Github user tillrohrmann commented on a diff in the pull

  1   2   3   >