[GitHub] flink pull request #5485: [FLINK-8411] Don't allow null in ListState.add()/a...

Github user aljoscha closed the pull request at: https://github.com/apache/flink/pull/5485 ---

[jira] [Commented] (FLINK-8411) Don't allow adding null in ListState.add()/addAll()

[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368131#comment-16368131 ] ASF GitHub Bot commented on FLINK-8411: --- Github user aljoscha closed the pull request at:

[jira] [Closed] (FLINK-8411) Don't allow adding null in ListState.add()/addAll()

[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek closed FLINK-8411. --- Resolution: Fixed Changed on master in f99c4dd395b71877eb70e7fc743d109957205a3d > Don't

[jira] [Commented] (FLINK-8607) Add a basic embedded SQL CLI client

[ https://issues.apache.org/jira/browse/FLINK-8607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16368123#comment-16368123 ] ASF GitHub Bot commented on FLINK-8607: --- Github user twalthr commented on a diff in the pull

[GitHub] flink pull request #5441: [FLINK-8607] [table] Add a basic embedded SQL CLI ...

Github user twalthr commented on a diff in the pull request: https://github.com/apache/flink/pull/5441#discussion_r168914688 --- Diff: flink-libraries/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/ResultStore.java --- @@ -0,0 +1,124 @@ +/* + *

[jira] [Created] (FLINK-8685) Code of method "processElement(Ljava/lang/Object;Lorg/apache/flink/streaming/api/functions/ProcessFunction$Context;Lorg/apache/flink/util/Collector;)V" of class "DataStre

Jahandar Musayev created FLINK-8685: --- Summary: Code of method "processElement(Ljava/lang/Object;Lorg/apache/flink/streaming/api/functions/ProcessFunction$Context;Lorg/apache/flink/util/Collector;)V" of class "DataStreamCalcRule$3069" grows

[jira] [Comment Edited] (FLINK-5486) Lack of synchronization in BucketingSink#handleRestoredBucketState()

[ https://issues.apache.org/jira/browse/FLINK-5486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16351986#comment-16351986 ] Ted Yu edited comment on FLINK-5486 at 2/17/18 2:09 AM: Can this get more review,

[jira] [Updated] (FLINK-8554) Upgrade AWS SDK

[ https://issues.apache.org/jira/browse/FLINK-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-8554: -- Description: AWS SDK 1.11.271 fixes a lot of bugs. One of which would exhibit the following: {code} Caused

[jira] [Updated] (FLINK-8394) Lack of synchronization accessing expectedRecord in ReceiverThread#shutdown

[ https://issues.apache.org/jira/browse/FLINK-8394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu updated FLINK-8394: -- Description: {code} public void shutdown() { running = false; interrupt();

[jira] [Commented] (FLINK-8683) Add test for configuration docs completeness

[ https://issues.apache.org/jira/browse/FLINK-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367999#comment-16367999 ] ASF GitHub Bot commented on FLINK-8683: --- GitHub user zentol opened a pull request:

[GitHub] flink pull request #5515: [FLINK-8683][docs] Add test for configuration docs...

GitHub user zentol opened a pull request: https://github.com/apache/flink/pull/5515 [FLINK-8683][docs] Add test for configuration docs completeness ## What is the purpose of the change This PR adds a test to verify that the documentation is complete and up-to-date. As a

[GitHub] flink issue #5501: [FLINK-6053][metrics] Add new Number-/StringGauge metric ...

Github user bowenli86 commented on the issue: https://github.com/apache/flink/pull/5501 LGTM generally. I still feel having all the `instanceof` in `notifyOfAddedMetric` and `notifyOfRemovedMetric` is a bit inelegant. I'm fine with it since there'll (hopefully) be only a

[jira] [Commented] (FLINK-6053) Gauge should only take subclasses of Number, rather than everything

[ https://issues.apache.org/jira/browse/FLINK-6053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367997#comment-16367997 ] ASF GitHub Bot commented on FLINK-6053: --- Github user bowenli86 commented on the issue:

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367983#comment-16367983 ] ASF GitHub Bot commented on FLINK-8360: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168891314 --- Diff: docs/ops/state/large_state_tuning.md --- @@ -234,4 +234,97 @@ Compression can be activated through the `ExecutionConfig`: **Notice:** The

[jira] [Created] (FLINK-8684) Rework MesosTaskManagerParameters#MESOS_RM_TASKS_SLOTS

Chesnay Schepler created FLINK-8684: --- Summary: Rework MesosTaskManagerParameters#MESOS_RM_TASKS_SLOTS Key: FLINK-8684 URL: https://issues.apache.org/jira/browse/FLINK-8684 Project: Flink

[jira] [Created] (FLINK-8683) Add test for configuration docs completeness

Chesnay Schepler created FLINK-8683: --- Summary: Add test for configuration docs completeness Key: FLINK-8683 URL: https://issues.apache.org/jira/browse/FLINK-8683 Project: Flink Issue Type:

[jira] [Created] (FLINK-8682) Make start/stop cluster scripts work without SSH for local HA setups

Stephan Ewen created FLINK-8682: --- Summary: Make start/stop cluster scripts work without SSH for local HA setups Key: FLINK-8682 URL: https://issues.apache.org/jira/browse/FLINK-8682 Project: Flink

[GitHub] flink pull request #5497: Propose fixing some typos

Github user jeis2497052 commented on a diff in the pull request: https://github.com/apache/flink/pull/5497#discussion_r168855898 --- Diff: docs/dev/migration.md --- @@ -145,16 +145,16 @@ public class BufferingSink implements SinkFunction>,

[GitHub] flink pull request #5500: [FLINK-8667] expose key in KeyedBroadcastProcessFu...

Github user bowenli86 commented on a diff in the pull request: https://github.com/apache/flink/pull/5500#discussion_r168855562 --- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/co/CoBroadcastWithKeyedOperator.java --- @@ -324,6 +324,11 @@

[jira] [Commented] (FLINK-8667) expose key in KeyedBroadcastProcessFunction#onTimer()

[ https://issues.apache.org/jira/browse/FLINK-8667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367802#comment-16367802 ] ASF GitHub Bot commented on FLINK-8667: --- Github user bowenli86 commented on a diff in the pull

[GitHub] flink pull request #5497: Propose fixing some typos

Github user jeis2497052 commented on a diff in the pull request: https://github.com/apache/flink/pull/5497#discussion_r168853984 --- Diff: docs/dev/migration.md --- @@ -145,16 +145,16 @@ public class BufferingSink implements SinkFunction>,

[GitHub] flink pull request #5497: Propose fixing some typos

Github user greghogan commented on a diff in the pull request: https://github.com/apache/flink/pull/5497#discussion_r168853239 --- Diff: docs/dev/migration.md --- @@ -145,16 +145,16 @@ public class BufferingSink implements SinkFunction>,

[jira] [Commented] (FLINK-8668) Remove "hadoop classpath" from config.sh

[ https://issues.apache.org/jira/browse/FLINK-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367783#comment-16367783 ] Stephan Ewen commented on FLINK-8668: - Could you also apply this to the HBase configuration, which is

[jira] [Created] (FLINK-8681) Remove planVisualizer.html move notice

Stephan Ewen created FLINK-8681: --- Summary: Remove planVisualizer.html move notice Key: FLINK-8681 URL: https://issues.apache.org/jira/browse/FLINK-8681 Project: Flink Issue Type: Improvement

[jira] [Created] (FLINK-8680) Name printing sinks by default.

Stephan Ewen created FLINK-8680: --- Summary: Name printing sinks by default. Key: FLINK-8680 URL: https://issues.apache.org/jira/browse/FLINK-8680 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-8668) Remove "hadoop classpath" from config.sh

[ https://issues.apache.org/jira/browse/FLINK-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367751#comment-16367751 ] Stephan Ewen commented on FLINK-8668: - I like this, it removes some hard to understand magic. It may

[jira] [Commented] (FLINK-7477) Use "hadoop classpath" to augment classpath when available

[ https://issues.apache.org/jira/browse/FLINK-7477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367750#comment-16367750 ] Ken Krugler commented on FLINK-7477: Hi [~aljoscha] - I encountered this issue when running locally

[jira] [Closed] (FLINK-8676) Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB

[ https://issues.apache.org/jira/browse/FLINK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas closed FLINK-8676. - Resolution: Fixed Merged at 4500bfd7729583c6a7cb5a6fb4f2d16ba8ba8cd4. > Memory Leak in

[jira] [Commented] (FLINK-8676) Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB

[ https://issues.apache.org/jira/browse/FLINK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367693#comment-16367693 ] ASF GitHub Bot commented on FLINK-8676: --- Github user asfgit closed the pull request at:

[GitHub] flink pull request #5513: [FLINK-8676][state]Memory Leak in AbstractKeyedSta...

Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/5513 ---

[jira] [Commented] (FLINK-8676) Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB

[ https://issues.apache.org/jira/browse/FLINK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367658#comment-16367658 ] ASF GitHub Bot commented on FLINK-8676: --- Github user kl0u commented on the issue:

[GitHub] flink issue #5513: [FLINK-8676][state]Memory Leak in AbstractKeyedStateBacke...

Github user kl0u commented on the issue: https://github.com/apache/flink/pull/5513 Thanks for the work @sihuazhou ! Changes look good! +1 to merge. ---

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367657#comment-16367657 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168826365 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -266,11

[jira] [Commented] (FLINK-8599) Improve the failure behavior of the ContinuousFileReaderOperator for bad files

[ https://issues.apache.org/jira/browse/FLINK-8599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367655#comment-16367655 ] ASF GitHub Bot commented on FLINK-8599: --- GitHub user ChengzhiZhao opened a pull request:

[GitHub] flink pull request #5514: [FLINK-8599] Improve the failure behavior of the C...

GitHub user ChengzhiZhao opened a pull request: https://github.com/apache/flink/pull/5514 [FLINK-8599] Improve the failure behavior of the ContinuousFileReader… ## What is the purpose of the change This pull request is intent to improve the failure behavior of the

[jira] [Created] (FLINK-8679) RocksDBKeyedBackend.getKeys(stateName, namespace) doesn't filter data with namespace

Sihua Zhou created FLINK-8679: - Summary: RocksDBKeyedBackend.getKeys(stateName, namespace) doesn't filter data with namespace Key: FLINK-8679 URL: https://issues.apache.org/jira/browse/FLINK-8679

[jira] [Commented] (FLINK-8676) Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB

[ https://issues.apache.org/jira/browse/FLINK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367642#comment-16367642 ] ASF GitHub Bot commented on FLINK-8676: --- Github user sihuazhou commented on the issue:

[GitHub] flink issue #5513: [FLINK-8676][state]Memory Leak in AbstractKeyedStateBacke...

Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/5513 @StefanRRichter Could you please have a look at this? ---

[GitHub] flink pull request #5513: [FLINK-8676][state]

GitHub user sihuazhou opened a pull request: https://github.com/apache/flink/pull/5513 [FLINK-8676][state] ## What is the purpose of the change This PR addressed issue [FLINK-8676](https://issues.apache.org/jira/browse/FLINK-8676).

[jira] [Commented] (FLINK-8676) Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB

[ https://issues.apache.org/jira/browse/FLINK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367638#comment-16367638 ] ASF GitHub Bot commented on FLINK-8676: --- GitHub user sihuazhou opened a pull request:

[jira] [Updated] (FLINK-8676) Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB

[ https://issues.apache.org/jira/browse/FLINK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-8676: -- Component/s: Streaming State Backends, Checkpointing > Memory Leak in

[jira] [Updated] (FLINK-8676) Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB

[ https://issues.apache.org/jira/browse/FLINK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-8676: -- Fix Version/s: 1.5.0 > Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend

[jira] [Updated] (FLINK-8676) Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB

[ https://issues.apache.org/jira/browse/FLINK-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kostas Kloudas updated FLINK-8676: -- Affects Version/s: 1.5.0 > Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when

[jira] [Created] (FLINK-8678) Make AkkaRpcService#stopService non-blocking

Till Rohrmann created FLINK-8678: Summary: Make AkkaRpcService#stopService non-blocking Key: FLINK-8678 URL: https://issues.apache.org/jira/browse/FLINK-8678 Project: Flink Issue Type:

[jira] [Commented] (FLINK-8677) Make ClusterEntrypoint shut down non-blocking

[ https://issues.apache.org/jira/browse/FLINK-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367628#comment-16367628 ] ASF GitHub Bot commented on FLINK-8677: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5512: [FLINK-8677] [flip6] Make ClusterEntrypoint shut d...

GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5512 [FLINK-8677] [flip6] Make ClusterEntrypoint shut down non-blocking ## What is the purpose of the change Makes the ClusterEntrypoint shut down method non-blocking. This also removes

[jira] [Created] (FLINK-8677) Make ClusterEntrypoint shut down non-blocking

Till Rohrmann created FLINK-8677: Summary: Make ClusterEntrypoint shut down non-blocking Key: FLINK-8677 URL: https://issues.apache.org/jira/browse/FLINK-8677 Project: Flink Issue Type:

[jira] [Commented] (FLINK-8675) Make shut down of RestServerEndpoint non blocking

[ https://issues.apache.org/jira/browse/FLINK-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367618#comment-16367618 ] ASF GitHub Bot commented on FLINK-8675: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5511: [FLINK-8675] Add non-blocking shut down method to ...

GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5511 [FLINK-8675] Add non-blocking shut down method to RestServerEndpoint ## What is the purpose of the change Make shut down method of RestServerEndpoint non blocking. This PR is

[jira] [Created] (FLINK-8676) Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB

Sihua Zhou created FLINK-8676: - Summary: Memory Leak in AbstractKeyedStateBackend.applyToAllKeys() when backend is base on RocksDB Key: FLINK-8676 URL: https://issues.apache.org/jira/browse/FLINK-8676

[jira] [Created] (FLINK-8675) Make shut down of RestServerEndpoint non blocking

Till Rohrmann created FLINK-8675: Summary: Make shut down of RestServerEndpoint non blocking Key: FLINK-8675 URL: https://issues.apache.org/jira/browse/FLINK-8675 Project: Flink Issue Type:

[jira] [Closed] (FLINK-6980) TypeExtractor.getForObject can't get typeinfo correctly.

[ https://issues.apache.org/jira/browse/FLINK-6980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sihua Zhou closed FLINK-6980. - Resolution: Won't Fix > TypeExtractor.getForObject can't get typeinfo correctly. >

[GitHub] flink issue #5497: Propose fixing some typos

Github user jeis2497052 commented on the issue: https://github.com/apache/flink/pull/5497 sorry about the space issue. What should I do? ---

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367441#comment-16367441 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168779711 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java --- @@ -0,0 +1,265 @@ +/* + *

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367437#comment-16367437 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168779365 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java --- @@ -0,0 +1,265 @@ +/* + *

[jira] [Created] (FLINK-8674) Efficiently handle alwaysFlush case (0ms flushTimeout)

Piotr Nowojski created FLINK-8674: - Summary: Efficiently handle alwaysFlush case (0ms flushTimeout) Key: FLINK-8674 URL: https://issues.apache.org/jira/browse/FLINK-8674 Project: Flink Issue

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168778447 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java --- @@ -0,0 +1,265 @@ +/* + *

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367430#comment-16367430 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367431#comment-16367431 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168778376 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367428#comment-16367428 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168778178 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367426#comment-16367426 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367427#comment-16367427 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r16849 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java --- @@ -0,0 +1,265 @@ +/* + *

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r16837 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -266,11

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367425#comment-16367425 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168777497 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java --- @@ -0,0 +1,265 @@ +/* + *

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367412#comment-16367412 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-8411) Don't allow adding null in ListState.add()/addAll()

[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367413#comment-16367413 ] ASF GitHub Bot commented on FLINK-8411: --- Github user aljoscha commented on the issue:

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168776176 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -266,11

[GitHub] flink issue #5485: [FLINK-8411] Don't allow null in ListState.add()/addAll()

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5485 @kl0u Thanks for the review, and very good catch about `update()`! ---

[jira] [Commented] (FLINK-8659) Add migration tests for Broadcast state.

[ https://issues.apache.org/jira/browse/FLINK-8659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367409#comment-16367409 ] ASF GitHub Bot commented on FLINK-8659: --- Github user aljoscha commented on the issue:

[GitHub] flink issue #5495: [FLINK-8659] Add migration itcases for broadcast state.

Github user aljoscha commented on the issue: https://github.com/apache/flink/pull/5495 It's hard to know the actual changes from the existing savepoint it case. I created a new history by tweezing apart the copying and the actual modifications:

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367403#comment-16367403 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff in the pull

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367402#comment-16367402 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168775173 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java --- @@ -0,0 +1,265 @@ +/* + *

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168774627 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/PrioritizedOperatorSubtaskState.java --- @@ -0,0 +1,265 @@ +/* + *

[jira] [Commented] (FLINK-8673) Don't let JobManagerRunner shut down itself

[ https://issues.apache.org/jira/browse/FLINK-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367391#comment-16367391 ] ASF GitHub Bot commented on FLINK-8673: --- GitHub user tillrohrmann opened a pull request:

[GitHub] flink pull request #5510: [FLINK-8673] [flip6] Use JobManagerRunner#resultFu...

GitHub user tillrohrmann opened a pull request: https://github.com/apache/flink/pull/5510 [FLINK-8673] [flip6] Use JobManagerRunner#resultFuture for success and failure communication ## What is the purpose of the change This commit removes the OnCompletionActions and

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367389#comment-16367389 ] ASF GitHub Bot commented on FLINK-8360: --- Github user StefanRRichter commented on a diff in the pull

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user StefanRRichter commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168773814 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@

[jira] [Commented] (FLINK-8360) Implement task-local state recovery

[ https://issues.apache.org/jira/browse/FLINK-8360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367385#comment-16367385 ] ASF GitHub Bot commented on FLINK-8360: --- Github user sihuazhou commented on a diff in the pull

[jira] [Created] (FLINK-8673) Don't let JobManagerRunner shut down itself

Till Rohrmann created FLINK-8673: Summary: Don't let JobManagerRunner shut down itself Key: FLINK-8673 URL: https://issues.apache.org/jira/browse/FLINK-8673 Project: Flink Issue Type:

[GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery

Github user sihuazhou commented on a diff in the pull request: https://github.com/apache/flink/pull/5239#discussion_r168773128 --- Diff: flink-contrib/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java --- @@ -266,11

[jira] [Commented] (FLINK-8411) Don't allow adding null in ListState.add()/addAll()

[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367382#comment-16367382 ] ASF GitHub Bot commented on FLINK-8411: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5485: [FLINK-8411] Don't allow null in ListState.add()/a...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5485#discussion_r168772337 --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaConsumerBaseTest.java --- @@

[jira] [Commented] (FLINK-8411) Don't allow adding null in ListState.add()/addAll()

[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367371#comment-16367371 ] ASF GitHub Bot commented on FLINK-8411: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #5485: [FLINK-8411] Don't allow null in ListState.add()/a...

Github user kl0u commented on a diff in the pull request: https://github.com/apache/flink/pull/5485#discussion_r168769781 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/UserFacingListState.java --- @@ -48,6 +49,7 @@ @Override public

[jira] [Commented] (FLINK-8411) Don't allow adding null in ListState.add()/addAll()

[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367365#comment-16367365 ] ASF GitHub Bot commented on FLINK-8411: --- Github user aljoscha commented on a diff in the pull

[GitHub] flink pull request #5485: [FLINK-8411] Don't allow null in ListState.add()/a...

Github user aljoscha commented on a diff in the pull request: https://github.com/apache/flink/pull/5485#discussion_r168769299 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/UserFacingListState.java --- @@ -48,6 +49,7 @@ @Override public

[jira] [Commented] (FLINK-7715) Port JarRunHandler to new REST endpoint

[ https://issues.apache.org/jira/browse/FLINK-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367358#comment-16367358 ] ASF GitHub Bot commented on FLINK-7715: --- Github user GJL commented on a diff in the pull request:

[GitHub] flink pull request #5509: [FLINK-7715][flip6] Port JarRunHandler to new REST...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5509#discussion_r168768261 --- Diff: flink-runtime-web/src/test/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandlerTest.java --- @@ -0,0 +1,99 @@ +/* + * Licensed to

[jira] [Commented] (FLINK-7715) Port JarRunHandler to new REST endpoint

[ https://issues.apache.org/jira/browse/FLINK-7715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367360#comment-16367360 ] ASF GitHub Bot commented on FLINK-7715: --- Github user GJL commented on a diff in the pull request:

[jira] [Commented] (FLINK-8411) Don't allow adding null in ListState.add()/addAll()

[ https://issues.apache.org/jira/browse/FLINK-8411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16367348#comment-16367348 ] ASF GitHub Bot commented on FLINK-8411: --- Github user kl0u commented on a diff in the pull request:

[GitHub] flink pull request #5509: [FLINK-7715][flip6] Port JarRunHandler to new REST...

Github user GJL commented on a diff in the pull request: https://github.com/apache/flink/pull/5509#discussion_r168768024 --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java --- @@ -1126,7 +1126,7 @@ public static void

  1   2   3   >