[jira] [Commented] (FLINK-9967) Snapshot release branches aren't deployed

2018-08-04 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569382#comment-16569382 ] Chesnay Schepler commented on FLINK-9967: - For future reference, previously we configured a

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569353#comment-16569353 ] ASF GitHub Bot commented on FLINK-10057: TisonKun commented on issue #6491: [FLINK-10057] Update

[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-08-04 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-410494126 cc @twalthr @StephanEwen This is an automated message from the Apache Git

[jira] [Commented] (FLINK-6847) Add TIMESTAMPDIFF supported in TableAPI

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569346#comment-16569346 ] ASF GitHub Bot commented on FLINK-6847: --- hequn8128 commented on issue #6282:

[GitHub] hequn8128 commented on issue #6282: [FLINK-6847][FLINK-6813] [table] TimestampDiff table api and sql support

2018-08-04 Thread GitBox
hequn8128 commented on issue #6282: [FLINK-6847][FLINK-6813] [table] TimestampDiff table api and sql support URL: https://github.com/apache/flink/pull/6282#issuecomment-410492932 It seems the `-` arithmetic is not very convenient for users. Maybe we need the `timestampDiff ` function?

[GitHub] yanghua commented on a change in pull request #6492: [FLINK-9962] [FS connector] allow users to specify TimeZone in DateTimeBucketer

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6492: [FLINK-9962] [FS connector] allow users to specify TimeZone in DateTimeBucketer URL: https://github.com/apache/flink/pull/6492#discussion_r207723967 ## File path:

[jira] [Commented] (FLINK-9962) allow users to specify TimeZone in DateTimeBucketer

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569343#comment-16569343 ] ASF GitHub Bot commented on FLINK-9962: --- yanghua commented on a change in pull request #6492:

[GitHub] yanghua commented on a change in pull request #6492: [FLINK-9962] [FS connector] allow users to specify TimeZone in DateTimeBucketer

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6492: [FLINK-9962] [FS connector] allow users to specify TimeZone in DateTimeBucketer URL: https://github.com/apache/flink/pull/6492#discussion_r207723921 ## File path:

[jira] [Commented] (FLINK-9962) allow users to specify TimeZone in DateTimeBucketer

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569342#comment-16569342 ] ASF GitHub Bot commented on FLINK-9962: --- yanghua commented on a change in pull request #6492:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569335#comment-16569335 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207723699 ## File path:

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569331#comment-16569331 ] ASF GitHub Bot commented on FLINK-10057: TisonKun commented on issue #6491: [FLINK-10057] Update

[GitHub] TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-08-04 Thread GitBox
TisonKun commented on issue #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#issuecomment-410489497 @lzqdename thanks for your PR! this change makes sense. you could pay attention to the code style by looking at code around, and it

[jira] [Commented] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569330#comment-16569330 ] ASF GitHub Bot commented on FLINK-10057: TisonKun commented on a change in pull request #6491:

[GitHub] TisonKun commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java

2018-08-04 Thread GitBox
TisonKun commented on a change in pull request #6491: [FLINK-10057] Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491#discussion_r207723189 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ## @@ -530,6

[jira] [Updated] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10057: --- Labels: pull-request-available (was: ) > optimalize >

[jira] [Commented] (FLINK-9962) allow users to specify TimeZone in DateTimeBucketer

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569322#comment-16569322 ] ASF GitHub Bot commented on FLINK-9962: --- bowenli86 opened a new pull request #6492: [FLINK-9962]

[jira] [Updated] (FLINK-9962) allow users to specify TimeZone in DateTimeBucketer

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-9962: -- Labels: pull-request-available (was: ) > allow users to specify TimeZone in DateTimeBucketer

[GitHub] bowenli86 opened a new pull request #6492: [FLINK-9962] [FS connector] allow users to specify TimeZone in DateTimeBucketer

2018-08-04 Thread GitBox
bowenli86 opened a new pull request #6492: [FLINK-9962] [FS connector] allow users to specify TimeZone in DateTimeBucketer URL: https://github.com/apache/flink/pull/6492 ## What is the purpose of the change allow users to specify TimeZone in DateTimeBucketer ## Brief change

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569248#comment-16569248 ] ASF GitHub Bot commented on FLINK-10056: TisonKun commented on issue #6490: [FLINK-10056] [test]

[GitHub] TisonKun commented on issue #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
TisonKun commented on issue #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#issuecomment-410464862 cc @zentol @tillrohrmann This is an automated message

[jira] [Commented] (FLINK-9990) Add regex_extract supported in TableAPI and SQL

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569224#comment-16569224 ] ASF GitHub Bot commented on FLINK-9990: --- walterddr commented on a change in pull request #6448:

[GitHub] walterddr commented on a change in pull request #6448: [FLINK-9990] [table] Add regex_extract supported in TableAPI and SQL

2018-08-04 Thread GitBox
walterddr commented on a change in pull request #6448: [FLINK-9990] [table] Add regex_extract supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6448#discussion_r207713222 ## File path: docs/dev/table/sql.md ## @@ -1842,6 +1842,16 @@ RPAD(text string,

[jira] [Updated] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread liuzq (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzq updated FLINK-10057: -- Affects Version/s: (was: 1.6.0) > optimalize >

[jira] [Updated] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread liuzq (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzq updated FLINK-10057: -- Description: --in function :

[jira] [Updated] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread liuzq (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzq updated FLINK-10057: -- Affects Version/s: 1.6.0 > optimalize >

[jira] [Updated] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread liuzq (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzq updated FLINK-10057: -- Affects Version/s: (was: 1.5.1) 1.5.2 > optimalize >

[jira] [Updated] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread liuzq (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzq updated FLINK-10057: -- Description: --in function :

[jira] [Created] (FLINK-10057) optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode

2018-08-04 Thread liuzq (JIRA)
liuzq created FLINK-10057: - Summary: optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode Key: FLINK-10057 URL: https://issues.apache.org/jira/browse/FLINK-10057 Project: Flink

[GitHub] lzqdename opened a new pull request #6491: Update FlinkYarnSessionCli.java

2018-08-04 Thread GitBox
lzqdename opened a new pull request #6491: Update FlinkYarnSessionCli.java URL: https://github.com/apache/flink/pull/6491 optimalize org.apache.flink.yarn.cli.FlinkYarnSessionCli.isYarnPropertiesFileMode *Thank you very much for contributing to Apache Flink - we are happy that

[jira] [Commented] (FLINK-6847) Add TIMESTAMPDIFF supported in TableAPI

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569188#comment-16569188 ] ASF GitHub Bot commented on FLINK-6847: --- xueyumusic edited a comment on issue #6282:

[GitHub] xueyumusic edited a comment on issue #6282: [FLINK-6847][FLINK-6813] [table] TimestampDiff table api and sql support

2018-08-04 Thread GitBox
xueyumusic edited a comment on issue #6282: [FLINK-6847][FLINK-6813] [table] TimestampDiff table api and sql support URL: https://github.com/apache/flink/pull/6282#issuecomment-410450506 @twalthr I am not sure how to express the `unit` parameter when using `-` arithmetic. How about

[jira] [Commented] (FLINK-6847) Add TIMESTAMPDIFF supported in TableAPI

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-6847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569186#comment-16569186 ] ASF GitHub Bot commented on FLINK-6847: --- xueyumusic commented on issue #6282:

[GitHub] xueyumusic commented on issue #6282: [FLINK-6847][FLINK-6813] [table] TimestampDiff table api and sql support

2018-08-04 Thread GitBox
xueyumusic commented on issue #6282: [FLINK-6847][FLINK-6813] [table] TimestampDiff table api and sql support URL: https://github.com/apache/flink/pull/6282#issuecomment-410450506 @twalthr I am not sure how to express the `unit` parameter when using `-` arithmetic. How about

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569183#comment-16569183 ] ASF GitHub Bot commented on FLINK-10056: TisonKun commented on issue #6490: [FLINK-10056] [test]

[GitHub] TisonKun commented on issue #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
TisonKun commented on issue #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#issuecomment-410449409 @yanghua thanks for review! suppressed comments and leave my thoughts. please review when you are free, thanks!

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569182#comment-16569182 ] ASF GitHub Bot commented on FLINK-10056: TisonKun commented on a change in pull request #6490:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569181#comment-16569181 ] ASF GitHub Bot commented on FLINK-10056: TisonKun commented on a change in pull request #6490:

[GitHub] TisonKun commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
TisonKun commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207708631 ## File path:

[GitHub] TisonKun commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
TisonKun commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207708631 ## File path:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569177#comment-16569177 ] ASF GitHub Bot commented on FLINK-10056: TisonKun commented on a change in pull request #6490:

[GitHub] TisonKun commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
TisonKun commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207708380 ## File path:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569171#comment-16569171 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707425 ## File path:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569169#comment-16569169 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707382 ## File path:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707131 ## File path:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569170#comment-16569170 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707318 ## File path:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569168#comment-16569168 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707425 ## File path:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569166#comment-16569166 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707152 ## File path:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569161#comment-16569161 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569162#comment-16569162 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707414 ## File path:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569163#comment-16569163 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569167#comment-16569167 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569165#comment-16569165 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569164#comment-16569164 ] ASF GitHub Bot commented on FLINK-10056: yanghua commented on a change in pull request #6490:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707125 ## File path:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707390 ## File path:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707284 ## File path:

[GitHub] yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490#discussion_r207707407 ## File path:

[jira] [Commented] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569151#comment-16569151 ] ASF GitHub Bot commented on FLINK-10056: TisonKun opened a new pull request #6490: [FLINK-10056]

[jira] [Updated] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10056: --- Labels: pull-request-available (was: ) > Add testRequestNextInputSplit >

[GitHub] TisonKun opened a new pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit

2018-08-04 Thread GitBox
TisonKun opened a new pull request #6490: [FLINK-10056] [test] Add JobMasterTest#testRequestNextInputSplit URL: https://github.com/apache/flink/pull/6490 ## Brief change log Add `JobMasterTest#testRequestNextInputSplit` to make sure that `JobMaster#requestNextInputSplit` works as

[jira] [Updated] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread JIRA
[ https://issues.apache.org/jira/browse/FLINK-10056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 陈梓立 updated FLINK-10056: Description: Add testRequestNextInputSplit to make sure JobMaster#requestNextInputSplit works as expected. (was:

[jira] [Created] (FLINK-10056) Add testRequestNextInputSplit

2018-08-04 Thread JIRA
陈梓立 created FLINK-10056: --- Summary: Add testRequestNextInputSplit Key: FLINK-10056 URL: https://issues.apache.org/jira/browse/FLINK-10056 Project: Flink Issue Type: Improvement Components:

[jira] [Commented] (FLINK-9999) Add ISNUMERIC supported in Table API/SQL

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569139#comment-16569139 ] ASF GitHub Bot commented on FLINK-: --- yanghua commented on issue #6473: [FLINK-] [table] Add

[GitHub] yanghua commented on issue #6473: [FLINK-9999] [table] Add ISNUMERIC supported in Table API/SQL

2018-08-04 Thread GitBox
yanghua commented on issue #6473: [FLINK-] [table] Add ISNUMERIC supported in Table API/SQL URL: https://github.com/apache/flink/pull/6473#issuecomment-410439596 @walterddr can you review this PR? This is an automated

[jira] [Commented] (FLINK-10054) Add getMaxParallelism/setMaxParallelism API for PythonStreamExecutionEnvironment

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569138#comment-16569138 ] ASF GitHub Bot commented on FLINK-10054: yanghua opened a new pull request #6489: [FLINK-10054]

[jira] [Updated] (FLINK-10054) Add getMaxParallelism/setMaxParallelism API for PythonStreamExecutionEnvironment

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10054: --- Labels: pull-request-available (was: ) > Add getMaxParallelism/setMaxParallelism API for

[GitHub] yanghua opened a new pull request #6489: [FLINK-10054] Add getMaxParallelism/setMaxParallelism API for PythonStreamExecutionEnvironment

2018-08-04 Thread GitBox
yanghua opened a new pull request #6489: [FLINK-10054] Add getMaxParallelism/setMaxParallelism API for PythonStreamExecutionEnvironment URL: https://github.com/apache/flink/pull/6489 ## What is the purpose of the change *This pull request adds getMaxParallelism/setMaxParallelism API

[jira] [Commented] (FLINK-8545) Implement upsert stream table source

2018-08-04 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569121#comment-16569121 ] Hequn Cheng commented on FLINK-8545: [~elevy] Hi, sorry about the delay. It's almost halfway done. I

[jira] [Commented] (FLINK-9134) Update Calcite dependency to 1.17

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569115#comment-16569115 ] ASF GitHub Bot commented on FLINK-9134: --- hequn8128 commented on issue #6484: [FLINK-9134] [table]

[GitHub] hequn8128 commented on issue #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17

2018-08-04 Thread GitBox
hequn8128 commented on issue #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17 URL: https://github.com/apache/flink/pull/6484#issuecomment-410431477 @suez1224 Hi, thanks for your PR. Only one question from my side: do we have any good ideas or plans about how to remove

[jira] [Commented] (FLINK-9134) Update Calcite dependency to 1.17

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569111#comment-16569111 ] ASF GitHub Bot commented on FLINK-9134: --- suez1224 commented on issue #6484: [FLINK-9134] [table]

[GitHub] suez1224 commented on issue #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17

2018-08-04 Thread GitBox
suez1224 commented on issue #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17 URL: https://github.com/apache/flink/pull/6484#issuecomment-410430674 @twalthr addressed the comments. Let me know what you think.

[jira] [Commented] (FLINK-9134) Update Calcite dependency to 1.17

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569110#comment-16569110 ] ASF GitHub Bot commented on FLINK-9134: --- suez1224 commented on a change in pull request #6484:

[GitHub] suez1224 commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17

2018-08-04 Thread GitBox
suez1224 commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17 URL: https://github.com/apache/flink/pull/6484#discussion_r207702177 ## File path:

[jira] [Commented] (FLINK-9134) Update Calcite dependency to 1.17

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569103#comment-16569103 ] ASF GitHub Bot commented on FLINK-9134: --- suez1224 commented on a change in pull request #6484:

[jira] [Commented] (FLINK-9134) Update Calcite dependency to 1.17

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569101#comment-16569101 ] ASF GitHub Bot commented on FLINK-9134: --- suez1224 commented on a change in pull request #6484:

[GitHub] suez1224 commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17

2018-08-04 Thread GitBox
suez1224 commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17 URL: https://github.com/apache/flink/pull/6484#discussion_r207701611 ## File path:

[GitHub] suez1224 commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17

2018-08-04 Thread GitBox
suez1224 commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17 URL: https://github.com/apache/flink/pull/6484#discussion_r207701618 ## File path:

[GitHub] suez1224 commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17

2018-08-04 Thread GitBox
suez1224 commented on a change in pull request #6484: [FLINK-9134] [table] upgrade Calcite dependency to 1.17 URL: https://github.com/apache/flink/pull/6484#discussion_r207701607 ## File path:

[jira] [Commented] (FLINK-9134) Update Calcite dependency to 1.17

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569102#comment-16569102 ] ASF GitHub Bot commented on FLINK-9134: --- suez1224 commented on a change in pull request #6484:

[jira] [Commented] (FLINK-10051) SQL client E2E test is missing dependencies

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569100#comment-16569100 ] ASF GitHub Bot commented on FLINK-10051: yanghua commented on issue #6486:

[GitHub] yanghua commented on issue #6486: [FLINK-10051][tests][sql] Add missing depenendeices for sql client E2E test

2018-08-04 Thread GitBox
yanghua commented on issue #6486: [FLINK-10051][tests][sql] Add missing depenendeices for sql client E2E test URL: https://github.com/apache/flink/pull/6486#issuecomment-410428717 +1 This is an automated message from the

[jira] [Commented] (FLINK-10055) incorrect in-progress file suffix in BucketingSink's java doc

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569099#comment-16569099 ] ASF GitHub Bot commented on FLINK-10055: yanghua commented on issue #6488: [FLINK-10055]

[GitHub] yanghua commented on issue #6488: [FLINK-10055] incorrect in-progress file suffix in BucketingSink's java doc

2018-08-04 Thread GitBox
yanghua commented on issue #6488: [FLINK-10055] incorrect in-progress file suffix in BucketingSink's java doc URL: https://github.com/apache/flink/pull/6488#issuecomment-410428669 +1 This is an automated message from the

[jira] [Commented] (FLINK-9990) Add regex_extract supported in TableAPI and SQL

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569097#comment-16569097 ] ASF GitHub Bot commented on FLINK-9990: --- yanghua commented on a change in pull request #6448:

[GitHub] yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add regex_extract supported in TableAPI and SQL

2018-08-04 Thread GitBox
yanghua commented on a change in pull request #6448: [FLINK-9990] [table] Add regex_extract supported in TableAPI and SQL URL: https://github.com/apache/flink/pull/6448#discussion_r207701539 ## File path: docs/dev/table/sql.md ## @@ -1842,6 +1842,16 @@ RPAD(text string,

[GitHub] yanghua commented on issue #6476: [FLINK-10025] Add getCheckpointConfig API for PythonStreamExecutionEnvironment

2018-08-04 Thread GitBox
yanghua commented on issue #6476: [FLINK-10025] Add getCheckpointConfig API for PythonStreamExecutionEnvironment URL: https://github.com/apache/flink/pull/6476#issuecomment-410428408 OK, Can you review PR #6475 so that I can write a test with Java?

[jira] [Commented] (FLINK-10025) Add getCheckpointConfig API for PythonStreamExecutionEnvironment

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569094#comment-16569094 ] ASF GitHub Bot commented on FLINK-10025: yanghua commented on issue #6476: [FLINK-10025] Add

[jira] [Commented] (FLINK-10025) Add getCheckpointConfig API for PythonStreamExecutionEnvironment

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569092#comment-16569092 ] ASF GitHub Bot commented on FLINK-10025: zentol edited a comment on issue #6476: [FLINK-10025]

[GitHub] zentol commented on issue #6476: [FLINK-10025] Add getCheckpointConfig API for PythonStreamExecutionEnvironment

2018-08-04 Thread GitBox
zentol commented on issue #6476: [FLINK-10025] Add getCheckpointConfig API for PythonStreamExecutionEnvironment URL: https://github.com/apache/flink/pull/6476#issuecomment-410428229 This still needs a _python_ test to verify that all properties can be properly set from the python side.

[GitHub] zentol edited a comment on issue #6476: [FLINK-10025] Add getCheckpointConfig API for PythonStreamExecutionEnvironment

2018-08-04 Thread GitBox
zentol edited a comment on issue #6476: [FLINK-10025] Add getCheckpointConfig API for PythonStreamExecutionEnvironment URL: https://github.com/apache/flink/pull/6476#issuecomment-410428229 This still needs a _python_ test to verify that all properties can be properly set and retrieved

[jira] [Commented] (FLINK-10025) Add getCheckpointConfig API for PythonStreamExecutionEnvironment

2018-08-04 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569091#comment-16569091 ] ASF GitHub Bot commented on FLINK-10025: zentol commented on issue #6476: [FLINK-10025] Add

[jira] [Commented] (FLINK-5315) Support distinct aggregations in table api

2018-08-04 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-5315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569082#comment-16569082 ] Hequn Cheng commented on FLINK-5315: Hi [~walterddr], good thinking. I agree that sql is more

  1   2   >