[jira] [Commented] (FLINK-10143) date_format throws CodeGenException

2018-12-12 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719879#comment-16719879 ] vinoyang commented on FLINK-10143: -- Hi [~twalthr]  We also encountered this problem and then found this

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241286479 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241279604 ## File path: docs/dev/table/tableApi.md ## @@ -550,6 +550,82 @@ val

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241281902 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241293061 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241280067 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241281516 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241285918 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241286801 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241280390 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241291444 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241281679 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241289780 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241293985 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241287190 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241290354 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241279917 ## File path: docs/dev/table/tableApi.md ## @@ -550,6 +550,82 @@ val

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241284274 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241286060 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241281005 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241280457 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241289558 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241283978 ## File path:

[GitHub] dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

2018-12-12 Thread GitBox
dianfu commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API URL: https://github.com/apache/flink/pull/7209#discussion_r241280112 ## File path:

[GitHub] zhijiangW commented on issue #7199: [FLINK-10662][network] Refactor the ChannelSelector interface for single selected channel

2018-12-12 Thread GitBox
zhijiangW commented on issue #7199: [FLINK-10662][network] Refactor the ChannelSelector interface for single selected channel URL: https://github.com/apache/flink/pull/7199#issuecomment-446865059 Thanks for your reviews! @pnowojski I would consider your above suggestions and double

[GitHub] zhijiangW commented on a change in pull request #7199: [FLINK-10662][network] Refactor the ChannelSelector interface for single selected channel

2018-12-12 Thread GitBox
zhijiangW commented on a change in pull request #7199: [FLINK-10662][network] Refactor the ChannelSelector interface for single selected channel URL: https://github.com/apache/flink/pull/7199#discussion_r241289363 ## File path:

[jira] [Comment Edited] (FLINK-11128) Methods of org.apache.flink.table.expressions.Expression are private[flink]

2018-12-12 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719822#comment-16719822 ] vinoyang edited comment on FLINK-11128 at 12/13/18 6:45 AM: [~dfakhritdinov]

[jira] [Commented] (FLINK-11128) Methods of org.apache.flink.table.expressions.Expression are private[flink]

2018-12-12 Thread vinoyang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719822#comment-16719822 ] vinoyang commented on FLINK-11128: -- [~dfakhritdinov] I tried it. However, it did not cause any problem.

[jira] [Closed] (FLINK-11062) web ui log error

2018-12-12 Thread lining (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lining closed FLINK-11062. -- Resolution: Fixed > web ui log error > > > Key: FLINK-11062 >

[GitHub] dianfu commented on issue #7253: [FLINK-11074] [table][tests] Enable harness tests with RocksdbStateBackend and add harness tests for CollectAggFunction

2018-12-12 Thread GitBox
dianfu commented on issue #7253: [FLINK-11074] [table][tests] Enable harness tests with RocksdbStateBackend and add harness tests for CollectAggFunction URL: https://github.com/apache/flink/pull/7253#issuecomment-446850114 @twalthr @sunjincheng121 Could you help to take a look at this PR?

[jira] [Assigned] (FLINK-9462) Disentangle flink-json and flink-table

2018-12-12 Thread boshu Zheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] boshu Zheng reassigned FLINK-9462: -- Assignee: boshu Zheng > Disentangle flink-json and flink-table >

[GitHub] hequn8128 commented on issue #6236: [FLINK-9699] [table] Add api to replace registered table

2018-12-12 Thread GitBox
hequn8128 commented on issue #6236: [FLINK-9699] [table] Add api to replace registered table URL: https://github.com/apache/flink/pull/6236#issuecomment-446846572 @zjffdu Thanks for the update. I will take a look within next week.

[jira] [Commented] (FLINK-11035) Notify data available to network stack immediately after finishing BufferBuilder

2018-12-12 Thread zhijiang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719746#comment-16719746 ] zhijiang commented on FLINK-11035: -- [~pnowojski], thanks for your explanation! I am just not sure

[GitHub] yanghua commented on issue #6329: [FLINK-9841] Web UI only show partial taskmanager log

2018-12-12 Thread GitBox
yanghua commented on issue #6329: [FLINK-9841] Web UI only show partial taskmanager log URL: https://github.com/apache/flink/pull/6329#issuecomment-446841558 @jinglining Not currently, I encountered this problem in our production environment, and I fixed it and verified it. It has been

[jira] [Closed] (FLINK-11136) Fix the logical of merge for DISTINCT aggregates

2018-12-12 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-11136. - Resolution: Fixed Fix Version/s: 1.7.1 1.8.0 1.6.3

[GitHub] ifndef-SleePy commented on issue #7290: [FLINK-11137] [runtime] Fix unexpected RegistrationTimeoutException of TaskExecutor

2018-12-12 Thread GitBox
ifndef-SleePy commented on issue #7290: [FLINK-11137] [runtime] Fix unexpected RegistrationTimeoutException of TaskExecutor URL: https://github.com/apache/flink/pull/7290#issuecomment-446838962 Travis testing build failed in connectors model. I checked the failed case, it works well in my

[jira] [Closed] (FLINK-11001) Window rowtime attribute can't be renamed in Java

2018-12-12 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske closed FLINK-11001. - Resolution: Fixed Fix Version/s: 1.8.0 Fixed for 1.8.0 with

[GitHub] fhueske commented on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs

2018-12-12 Thread GitBox
fhueske commented on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs URL: https://github.com/apache/flink/pull/7248#issuecomment-446837983 Consistent documentation is a good point. However, I'd rather change the other examples than indicating

[jira] [Created] (FLINK-11146) Get rid of legacy codes from ClusterClient

2018-12-12 Thread TisonKun (JIRA)
TisonKun created FLINK-11146: Summary: Get rid of legacy codes from ClusterClient Key: FLINK-11146 URL: https://issues.apache.org/jira/browse/FLINK-11146 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-11139) stream non window join support state ttl

2018-12-12 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719735#comment-16719735 ] Fabian Hueske commented on FLINK-11139: --- [~zhaoshijie] I gave you contributor permissions. >

[jira] [Commented] (FLINK-11139) stream non window join support state ttl

2018-12-12 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719734#comment-16719734 ] Fabian Hueske commented on FLINK-11139: --- [~zhaoshijie], I assume you configured a [idle state

[GitHub] dianfu commented on issue #7284: [FLINK-11136] [table] Fix the merge logic of DISTINCT aggregates

2018-12-12 Thread GitBox
dianfu commented on issue #7284: [FLINK-11136] [table] Fix the merge logic of DISTINCT aggregates URL: https://github.com/apache/flink/pull/7284#issuecomment-446836298 Thanks a lot for the review and merge @fhueske ! This

[GitHub] asfgit closed pull request #7284: [FLINK-11136] [table] Fix the merge logic of DISTINCT aggregates

2018-12-12 Thread GitBox
asfgit closed pull request #7284: [FLINK-11136] [table] Fix the merge logic of DISTINCT aggregates URL: https://github.com/apache/flink/pull/7284 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] asfgit closed pull request #7297: [hotfix] [docs] Fix typos in Table and SQL docs

2018-12-12 Thread GitBox
asfgit closed pull request #7297: [hotfix] [docs] Fix typos in Table and SQL docs URL: https://github.com/apache/flink/pull/7297 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] asfgit closed pull request #7282: [hotfix][docs] imporve docs of batch overview

2018-12-12 Thread GitBox
asfgit closed pull request #7282: [hotfix][docs] imporve docs of batch overview URL: https://github.com/apache/flink/pull/7282 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] jinglining commented on issue #6329: [FLINK-9841] Web UI only show partial taskmanager log

2018-12-12 Thread GitBox
jinglining commented on issue #6329: [FLINK-9841] Web UI only show partial taskmanager log URL: https://github.com/apache/flink/pull/6329#issuecomment-446836098 > @zentol yes, you are right, sorry about my expression. here we should not use try-with-resource, because the listener will

[jira] [Updated] (FLINK-11146) Get rid of legacy codes from ClusterClient

2018-12-12 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TisonKun updated FLINK-11146: - Description: As [~StephanEwen] mentioned in ML, the client needs big refactoring / cleanup. It should

[jira] [Updated] (FLINK-11146) Get rid of legacy codes from ClusterClient

2018-12-12 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] TisonKun updated FLINK-11146: - Issue Type: Task (was: Sub-task) Parent: (was: FLINK-10392) > Get rid of legacy codes from

[jira] [Commented] (FLINK-11139) stream non window join support state ttl

2018-12-12 Thread Hequn Cheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719728#comment-16719728 ] Hequn Cheng commented on FLINK-11139: - [~zhaoshijie] Hi, thanks for reporting and trying to fix the

[GitHub] hequn8128 commented on issue #7289: [FLINK-11001][table] Fix window rowtime attribute can't be renamed bug in Java

2018-12-12 Thread GitBox
hequn8128 commented on issue #7289: [FLINK-11001][table] Fix window rowtime attribute can't be renamed bug in Java URL: https://github.com/apache/flink/pull/7289#issuecomment-446833240 @fhueske Thanks a lot for your review!

[jira] [Commented] (FLINK-11138) RocksDB's wal seems to be useless in rocksdb-state-backend that reduce the disk's overhead

2018-12-12 Thread Yun Tang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719713#comment-16719713 ] Yun Tang commented on FLINK-11138: -- Yes, you are right. But we already disable the WAL of rocksDB. You

[jira] [Updated] (FLINK-11088) Improve Kerberos Authentication using Keytab in YARN proxy user mode

2018-12-12 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong updated FLINK-11088: -- Description: Currently flink-yarn assumes keytab is shipped as application master environment local

[jira] [Assigned] (FLINK-9529) Do not expose keyed operations on ProcessFunction.Context

2018-12-12 Thread boshu Zheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] boshu Zheng reassigned FLINK-9529: -- Assignee: boshu Zheng > Do not expose keyed operations on ProcessFunction.Context >

[jira] [Commented] (FLINK-11143) AskTimeoutException is thrown during job submission and completion

2018-12-12 Thread Qi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719694#comment-16719694 ] Qi commented on FLINK-11143: The hard code I’ve found is [1] and [2]. I think they should be changed to

[jira] [Commented] (FLINK-10882) Misleading job/task state for scheduled jobs

2018-12-12 Thread lining (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719670#comment-16719670 ] lining commented on FLINK-10882: See code, now org.apache.flink.runtime.jobgraph.JobStatus define

[jira] [Commented] (FLINK-10882) Misleading job/task state for scheduled jobs

2018-12-12 Thread lining (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719654#comment-16719654 ] lining commented on FLINK-10882: Hi [~Zentol], I'm interested in this. Can assign this Jira to me? >

[jira] [Commented] (FLINK-11127) Make metrics query service establish connection to JobManager

2018-12-12 Thread Sergei Poganshev (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719651#comment-16719651 ] Sergei Poganshev commented on FLINK-11127: -- Here's a (slightly tricky) workaround that works:

[jira] [Closed] (FLINK-7293) Support custom order by in PatternStream

2018-12-12 Thread Dian Fu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu closed FLINK-7293. -- > Support custom order by in PatternStream > > > Key:

[GitHub] fhueske commented on issue #7289: [FLINK-11001][table] Fix window rowtime attribute can't be renamed bug in Java

2018-12-12 Thread GitBox
fhueske commented on issue #7289: [FLINK-11001][table] Fix window rowtime attribute can't be renamed bug in Java URL: https://github.com/apache/flink/pull/7289#issuecomment-446810382 Thanks for the fix @hequn8128! I'll merge this PR.

[GitHub] yanghua edited a comment on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs

2018-12-12 Thread GitBox
yanghua edited a comment on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs URL: https://github.com/apache/flink/pull/7248#issuecomment-446808073 @fhueske you are right. But there may be some points that can be misleading for some users:

[GitHub] yanghua commented on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs

2018-12-12 Thread GitBox
yanghua commented on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs URL: https://github.com/apache/flink/pull/7248#issuecomment-446808073 @fhueske you are right. But there may be some points that can be misleading for some users: *

[jira] [Updated] (FLINK-11136) Fix the logical of merge for DISTINCT aggregates

2018-12-12 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske updated FLINK-11136: -- Issue Type: Bug (was: Test) > Fix the logical of merge for DISTINCT aggregates >

[GitHub] fhueske commented on issue #7284: [FLINK-11136] [table] Fix the merge logic of DISTINCT aggregates

2018-12-12 Thread GitBox
fhueske commented on issue #7284: [FLINK-11136] [table] Fix the merge logic of DISTINCT aggregates URL: https://github.com/apache/flink/pull/7284#issuecomment-446804905 Thanks for fixing this bug @dianfu! Will merge this fix.

[jira] [Closed] (FLINK-9232) Add harness test for AggregationCodeGenerator

2018-12-12 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rong Rong closed FLINK-9232. Resolution: Duplicate > Add harness test for AggregationCodeGenerator >

[GitHub] fhueske commented on issue #7282: [hotfix][docs] imporve docs of batch overview

2018-12-12 Thread GitBox
fhueske commented on issue #7282: [hotfix][docs] imporve docs of batch overview URL: https://github.com/apache/flink/pull/7282#issuecomment-446795624 Thanks for the PR @KarmaGYZ. I'll merge it. This is an automated

[GitHub] fhueske commented on issue #7297: [hotfix] [docs] Fix typos in Table and SQL docs

2018-12-12 Thread GitBox
fhueske commented on issue #7297: [hotfix] [docs] Fix typos in Table and SQL docs URL: https://github.com/apache/flink/pull/7297#issuecomment-446791047 Thanks for the PR @afedulov. I'll merge it. This is an automated

[GitHub] fhueske commented on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs

2018-12-12 Thread GitBox
fhueske commented on issue #7248: [hotfix][tableApi] Fix the description information of intersect in tableApi docs URL: https://github.com/apache/flink/pull/7248#issuecomment-446785876 Hi @maqingxiang, thanks for this PR. The current documentation is correct. For `intersect` /

[GitHub] zentol commented on a change in pull request #7295: [FLINK-10748] Decouple RestServerEndpoint from Dispatcher

2018-12-12 Thread GitBox
zentol commented on a change in pull request #7295: [FLINK-10748] Decouple RestServerEndpoint from Dispatcher URL: https://github.com/apache/flink/pull/7295#discussion_r241158558 ## File path:

[GitHub] zentol commented on a change in pull request #7295: [FLINK-10748] Decouple RestServerEndpoint from Dispatcher

2018-12-12 Thread GitBox
zentol commented on a change in pull request #7295: [FLINK-10748] Decouple RestServerEndpoint from Dispatcher URL: https://github.com/apache/flink/pull/7295#discussion_r241160578 ## File path:

[GitHub] afedulov opened a new pull request #7297: [hotfix] [docs] Fix typos in Table and SQL docs

2018-12-12 Thread GitBox
afedulov opened a new pull request #7297: [hotfix] [docs] Fix typos in Table and SQL docs URL: https://github.com/apache/flink/pull/7297 ## What is the purpose of the change Fix typos in Table and SQL docs. ## Verifying this change This change is a trivial

[GitHub] fhueske commented on issue #7276: [FLINK-10566] Fix exponential planning time of large programs

2018-12-12 Thread GitBox
fhueske commented on issue #7276: [FLINK-10566] Fix exponential planning time of large programs URL: https://github.com/apache/flink/pull/7276#issuecomment-446699926 There was a discussion about a 1.5.6 on the dev ML (started by Till) a few days ago and it was concluded that there will be

[jira] [Created] (FLINK-11145) Fix Hadoop version handling in binary release script

2018-12-12 Thread Thomas Weise (JIRA)
Thomas Weise created FLINK-11145: Summary: Fix Hadoop version handling in binary release script Key: FLINK-11145 URL: https://issues.apache.org/jira/browse/FLINK-11145 Project: Flink Issue

[GitHub] tweise commented on issue #7278: [FLINK-11145] Allow for override of HADOOP_VERSION for single variant binary release build

2018-12-12 Thread GitBox
tweise commented on issue #7278: [FLINK-11145] Allow for override of HADOOP_VERSION for single variant binary release build URL: https://github.com/apache/flink/pull/7278#issuecomment-446677083 @zentol PTAL - with fix for the version duplication

[GitHub] lamber-ken commented on issue #7279: [hotfix] add hadoop user name to yarn logs command

2018-12-12 Thread GitBox
lamber-ken commented on issue #7279: [hotfix] add hadoop user name to yarn logs command URL: https://github.com/apache/flink/pull/7279#issuecomment-446672016 hi, @zentol @tillrohrmann, cc. This is an automated message from

[GitHub] lamber-ken opened a new pull request #7296: [hotfix][web] fix the desc about restart strategy in web

2018-12-12 Thread GitBox
lamber-ken opened a new pull request #7296: [hotfix][web] fix the desc about restart strategy in web URL: https://github.com/apache/flink/pull/7296 ## What is the purpose of the change int flink job configuration page, it's better use `Restart strategy`.

[GitHub] zentol commented on a change in pull request #7293: [FLINK-11144][tests] Make tests run on Java 9

2018-12-12 Thread GitBox
zentol commented on a change in pull request #7293: [FLINK-11144][tests] Make tests run on Java 9 URL: https://github.com/apache/flink/pull/7293#discussion_r241106082 ## File path: pom.xml ## @@ -1602,7 +1616,7 @@ under the License.

[GitHub] mxm commented on issue #7276: [FLINK-10566] Fix exponential planning time of large programs

2018-12-12 Thread GitBox
mxm commented on issue #7276: [FLINK-10566] Fix exponential planning time of large programs URL: https://github.com/apache/flink/pull/7276#issuecomment-44924 Btw, I also want to backport this to 1.5 and 1.6. Do you know if there is another 1.5 release planned? Or is 1.5 already end of

[jira] [Commented] (FLINK-11127) Make metrics query service establish connection to JobManager

2018-12-12 Thread Sergei Poganshev (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719153#comment-16719153 ] Sergei Poganshev commented on FLINK-11127: -- [~uce] Ah. Thanks for the heads up. We'll probably

[jira] [Updated] (FLINK-10748) Jobmanager in HA setup, redirects (307) don't work when behind a load balancer

2018-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10748: --- Labels: pull-request-available (was: ) > Jobmanager in HA setup, redirects (307) don't

[GitHub] tillrohrmann opened a new pull request #7295: [FLINK-10748] Decouple RestServerEndpoint from Dispatcher

2018-12-12 Thread GitBox
tillrohrmann opened a new pull request #7295: [FLINK-10748] Decouple RestServerEndpoint from Dispatcher URL: https://github.com/apache/flink/pull/7295 ## What is the purpose of the change This commits decouples the RestServerEndpoint from the Dispatcher by converting the

[GitHub] yanghua commented on issue #7263: [FLINK-11081] Support binding port range for REST server

2018-12-12 Thread GitBox
yanghua commented on issue #7263: [FLINK-11081] Support binding port range for REST server URL: https://github.com/apache/flink/pull/7263#issuecomment-446645970 @zentol updated this PR This is an automated message from the

[GitHub] yanghua commented on a change in pull request #7263: [FLINK-11081] Support binding port range for REST server

2018-12-12 Thread GitBox
yanghua commented on a change in pull request #7263: [FLINK-11081] Support binding port range for REST server URL: https://github.com/apache/flink/pull/7263#discussion_r241075877 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/rest/RestServerEndpoint.java

[GitHub] yanghua commented on a change in pull request #7263: [FLINK-11081] Support binding port range for REST server

2018-12-12 Thread GitBox
yanghua commented on a change in pull request #7263: [FLINK-11081] Support binding port range for REST server URL: https://github.com/apache/flink/pull/7263#discussion_r241074645 ## File path: flink-core/src/main/java/org/apache/flink/configuration/RestOptions.java ## @@

[jira] [Assigned] (FLINK-10748) Jobmanager in HA setup, redirects (307) don't work when behind a load balancer

2018-12-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-10748: - Assignee: Till Rohrmann > Jobmanager in HA setup, redirects (307) don't work when

[jira] [Commented] (FLINK-10748) Jobmanager in HA setup, redirects (307) don't work when behind a load balancer

2018-12-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719118#comment-16719118 ] Till Rohrmann commented on FLINK-10748: --- Thanks for reporting this issue [~jeroens]. I think you

[jira] [Comment Edited] (FLINK-11067) Port TableEnvironments to Java

2018-12-12 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719091#comment-16719091 ] Dawid Wysakowicz edited comment on FLINK-11067 at 12/12/18 3:29 PM:

[jira] [Commented] (FLINK-11067) Port TableEnvironments to Java

2018-12-12 Thread Dawid Wysakowicz (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719091#comment-16719091 ] Dawid Wysakowicz commented on FLINK-11067: -- I think as user should only import either

[jira] [Updated] (FLINK-11126) Filter out AMRMToken in the TaskManager credentials

2018-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11126: --- Labels: pull-request-available (was: ) > Filter out AMRMToken in the TaskManager

[GitHub] link3280 opened a new pull request #7294: [FLINK-11126][YARN][security] Filter out AMRMToken in the TaskManager credentials

2018-12-12 Thread GitBox
link3280 opened a new pull request #7294: [FLINK-11126][YARN][security] Filter out AMRMToken in the TaskManager credentials URL: https://github.com/apache/flink/pull/7294 ## What is the purpose of the change Currently, Flink JobManager propagates its storage tokens to TaskManager to

[jira] [Updated] (FLINK-11144) Run Tests on Java 9

2018-12-12 Thread Gary Yao (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Yao updated FLINK-11144: - Description: When using Java 9, tests should run when invoking {{mvn clean install -Dfast}} Acceptance

[jira] [Updated] (FLINK-11144) Run Tests on Java 9

2018-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11144: --- Labels: pull-request-available (was: ) > Run Tests on Java 9 > --- > >

[GitHub] GJL opened a new pull request #7293: [FLINK-11144][tests] Make tests run on Java 9

2018-12-12 Thread GitBox
GJL opened a new pull request #7293: [FLINK-11144][tests] Make tests run on Java 9 URL: https://github.com/apache/flink/pull/7293 ## What is the purpose of the change *Make tests run on Java 9 by upgrading plugins to minimum supported version for Java 9:

[jira] [Resolved] (FLINK-11085) NoClassDefFoundError in presto-s3 filesystem

2018-12-12 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann resolved FLINK-11085. --- Resolution: Fixed Fixed via 1.8.0:

[GitHub] tillrohrmann closed pull request #7261: [FLINK-11085][s3] Fix inclusion of presto hadoop classes

2018-12-12 Thread GitBox
tillrohrmann closed pull request #7261: [FLINK-11085][s3] Fix inclusion of presto hadoop classes URL: https://github.com/apache/flink/pull/7261 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[jira] [Commented] (FLINK-11028) Disable deployment of flink-fs-tests

2018-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719029#comment-16719029 ] Chesnay Schepler commented on FLINK-11028: -- eh maybe not :D the tests required

[GitHub] zentol commented on issue #6880: [FLINK-10571][storm] Remove topology support

2018-12-12 Thread GitBox
zentol commented on issue #6880: [FLINK-10571][storm] Remove topology support URL: https://github.com/apache/flink/pull/6880#issuecomment-446609832 @TisonKun Someone has to review the PR to check that only topology-related parts have been removed, without impacting the bolt/spout wrapper

[GitHub] tweise commented on a change in pull request #7249: [FLINK-11048] Ability to programmatically execute streaming pipeline with savepoint restore

2018-12-12 Thread GitBox
tweise commented on a change in pull request #7249: [FLINK-11048] Ability to programmatically execute streaming pipeline with savepoint restore URL: https://github.com/apache/flink/pull/7249#discussion_r241037567 ## File path:

[jira] [Commented] (FLINK-11028) Disable deployment of flink-fs-tests

2018-12-12 Thread Chesnay Schepler (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719024#comment-16719024 ] Chesnay Schepler commented on FLINK-11028: -- The contained test are exclusively for HDFS, so

[jira] [Updated] (FLINK-11101) Ineffective openjdk exclusion Presto S3 FileSystem module

2018-12-12 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11101: --- Labels: pull-request-available (was: ) > Ineffective openjdk exclusion Presto S3

[GitHub] zentol opened a new pull request #7292: [FLINK-11101][S3] Ban openjdk.jol dependencies

2018-12-12 Thread GitBox
zentol opened a new pull request #7292: [FLINK-11101][S3] Ban openjdk.jol dependencies URL: https://github.com/apache/flink/pull/7292 ## What is the purpose of the change This PR removes a redundant exclusion for `openjdk.jol` from the presto-s3-filesystem pom, and adds a safeguard

  1   2   3   >