[jira] [Created] (FLINK-12123) Upgrade Jepsen to 0.1.13 in flink-jepsen

2019-04-08 Thread Gary Yao (JIRA)
Gary Yao created FLINK-12123: Summary: Upgrade Jepsen to 0.1.13 in flink-jepsen Key: FLINK-12123 URL: https://issues.apache.org/jira/browse/FLINK-12123 Project: Flink Issue Type: Improvement

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272965384 ## File path:

[GitHub] [flink] twalthr commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-08 Thread GitBox
twalthr commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272964598 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272964014 ## File path:

[jira] [Commented] (FLINK-7464) Add useful build-in Aggregate function into TabalAPI

2019-04-08 Thread Lifei Chen (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812283#comment-16812283 ] Lifei Chen commented on FLINK-7464: --- Hi,  [~sunjincheng121],  I think `FIRST_VALUE` and `LAST_VALUE`

[jira] [Assigned] (FLINK-12122) Spread out tasks evenly across all available registered TaskManagers

2019-04-08 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-12122: - Assignee: Till Rohrmann > Spread out tasks evenly across all available registered

[jira] [Created] (FLINK-12122) Spread out tasks evenly across all available registered TaskManagers

2019-04-08 Thread Till Rohrmann (JIRA)
Till Rohrmann created FLINK-12122: - Summary: Spread out tasks evenly across all available registered TaskManagers Key: FLINK-12122 URL: https://issues.apache.org/jira/browse/FLINK-12122 Project:

[jira] [Comment Edited] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted

2019-04-08 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812271#comment-16812271 ] Ji Liu edited comment on FLINK-10437 at 4/8/19 9:34 AM: [~Tison] I have checked

[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted

2019-04-08 Thread Ji Liu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812271#comment-16812271 ] Ji Liu commented on FLINK-10437: [~Tison] I have checked usages of _ConfigOption.withDeparecatedKeys_

[jira] [Commented] (FLINK-10984) Move flink-shaded-hadoop to flink-shaded

2019-04-08 Thread sunjincheng (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812268#comment-16812268 ] sunjincheng commented on FLINK-10984: - +1 for this proposal. I think this JIRA should first add the

[GitHub] [flink] tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers

2019-04-08 Thread GitBox
tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers URL: https://github.com/apache/flink/pull/8002#discussion_r272951340 ## File path:

[jira] [Commented] (FLINK-12008) Support read a whole directory or multiple input data files for read apis of HadoopInputs

2019-04-08 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812265#comment-16812265 ] Fabian Hueske commented on FLINK-12008: --- Yes, IIRC we recently added support for multiple paths to

[GitHub] [flink] tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers

2019-04-08 Thread GitBox
tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers URL: https://github.com/apache/flink/pull/8002#discussion_r272955876 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers

2019-04-08 Thread GitBox
tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers URL: https://github.com/apache/flink/pull/8002#discussion_r272954758 ## File path:

[jira] [Updated] (FLINK-10984) Move flink-shaded-hadoop to flink-shaded

2019-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10984: --- Labels: pull-request-available (was: ) > Move flink-shaded-hadoop to flink-shaded >

[GitHub] [flink] tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers

2019-04-08 Thread GitBox
tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers URL: https://github.com/apache/flink/pull/8002#discussion_r272951210 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers

2019-04-08 Thread GitBox
tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers URL: https://github.com/apache/flink/pull/8002#discussion_r272956271 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers

2019-04-08 Thread GitBox
tillrohrmann commented on a change in pull request #8002: [FLINK-11923][metrics] MetricRegistryConfiguration provides MetricReporters Suppliers URL: https://github.com/apache/flink/pull/8002#discussion_r272950654 ## File path:

[GitHub] [flink] flinkbot commented on issue #8121: [FLINK-10437]Some of keys under withDeprecatedKeys aren't marked as @…

2019-04-08 Thread GitBox
flinkbot commented on issue #8121: [FLINK-10437]Some of keys under withDeprecatedKeys aren't marked as @… URL: https://github.com/apache/flink/pull/8121#issuecomment-480754474 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] tianchen92 opened a new pull request #8121: [FLINK-10437]Some of keys under withDeprecatedKeys aren't marked as @…

2019-04-08 Thread GitBox
tianchen92 opened a new pull request #8121: [FLINK-10437]Some of keys under withDeprecatedKeys aren't marked as @… URL: https://github.com/apache/flink/pull/8121 …depreacted ## What is the purpose of the change *RestOptions#BIND_ADDRESS is

[jira] [Updated] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted

2019-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-10437: --- Labels: pull-request-available (was: ) > Some of keys under withDeprecatedKeys aren't

[GitHub] [flink] tzulitai commented on a change in pull request #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends

2019-04-08 Thread GitBox
tzulitai commented on a change in pull request #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends URL: https://github.com/apache/flink/pull/8078#discussion_r272922134 ## File path:

[GitHub] [flink] tzulitai commented on a change in pull request #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends

2019-04-08 Thread GitBox
tzulitai commented on a change in pull request #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends URL: https://github.com/apache/flink/pull/8078#discussion_r272921407 ## File path:

[GitHub] [flink] tzulitai commented on a change in pull request #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends

2019-04-08 Thread GitBox
tzulitai commented on a change in pull request #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends URL: https://github.com/apache/flink/pull/8078#discussion_r272922020 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-08 Thread GitBox
zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272944389 ## File path:

[jira] [Commented] (FLINK-12121) Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-08 Thread Yu Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812243#comment-16812243 ] Yu Li commented on FLINK-12121: --- Mark as a blocker of FLINK-12066 > Use composition instead of

[jira] [Created] (FLINK-12121) Use composition instead of inheritance for the InternalKeyContext logic in backend

2019-04-08 Thread Yu Li (JIRA)
Yu Li created FLINK-12121: - Summary: Use composition instead of inheritance for the InternalKeyContext logic in backend Key: FLINK-12121 URL: https://issues.apache.org/jira/browse/FLINK-12121 Project: Flink

[GitHub] [flink] KurtYoung commented on issue #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on issue #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#issuecomment-480743717 BTW, i think we need some dedicated tests for all rank functions.

[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted

2019-04-08 Thread TisonKun (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812233#comment-16812233 ] TisonKun commented on FLINK-10437: -- Yes. You might decide whether replace with {{withFallbackKeys}} or

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272878173 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272880935 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272879137 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272878814 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272879175 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272878861 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272882131 ## File path:

[GitHub] [flink] KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation

2019-04-08 Thread GitBox
KurtYoung commented on a change in pull request #8109: [FLINK-12017][table-planner-blink] Support translation from Rank/Deduplicate to StreamTransformation URL: https://github.com/apache/flink/pull/8109#discussion_r272878296 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem

2019-04-08 Thread GitBox
pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem URL: https://github.com/apache/flink/pull/8038#discussion_r272922309 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem

2019-04-08 Thread GitBox
pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem URL: https://github.com/apache/flink/pull/8038#discussion_r272925609 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem

2019-04-08 Thread GitBox
pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem URL: https://github.com/apache/flink/pull/8038#discussion_r272927404 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem

2019-04-08 Thread GitBox
pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem URL: https://github.com/apache/flink/pull/8038#discussion_r272923859 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem

2019-04-08 Thread GitBox
pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem URL: https://github.com/apache/flink/pull/8038#discussion_r272921337 ## File path:

[jira] [Commented] (FLINK-4785) Flink string parser doesn't handle string fields containing two consecutive double quotes

2019-04-08 Thread Flavio Pompermaier (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-4785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1681#comment-1681 ] Flavio Pompermaier commented on FLINK-4785: --- Which url is no longer valid?

[GitHub] [flink] pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem

2019-04-08 Thread GitBox
pnowojski commented on a change in pull request #8038: [FLINK-11953] Introduce Plugin/Loading system and integrate it with FileSystem URL: https://github.com/apache/flink/pull/8038#discussion_r272927782 ## File path:

[jira] [Commented] (FLINK-10684) Improve the CSV reading process

2019-04-08 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812221#comment-16812221 ] Fabian Hueske commented on FLINK-10684: --- Hi, please have a look at

[jira] [Commented] (FLINK-8801) S3's eventual consistent read-after-write may fail yarn deployment of resources to S3

2019-04-08 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812220#comment-16812220 ] Till Rohrmann commented on FLINK-8801: -- Hi [~Tao Yang] and [~yanyan300300], thanks for reporting

[GitHub] [flink] JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-08 Thread GitBox
JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480731189 I try implement it like "immediately determine the left and right boundary", but even if we

[jira] [Updated] (FLINK-12010) Kinesis Producer problems on Alpine Linux image

2019-04-08 Thread Mario Georgiev (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Georgiev updated FLINK-12010: --- Description: {code:java} Error relocating

[jira] [Updated] (FLINK-11855) Race condition in EmbeddedLeaderService

2019-04-08 Thread Aljoscha Krettek (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aljoscha Krettek updated FLINK-11855: - Fix Version/s: (was: 1.8.1) (was: 1.9.0)

[GitHub] [flink] zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-08 Thread GitBox
zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272919268 ## File path:

[GitHub] [flink] flinkbot edited a comment on issue #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends

2019-04-08 Thread GitBox
flinkbot edited a comment on issue #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends URL: https://github.com/apache/flink/pull/8078#issuecomment-477977949 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I

[GitHub] [flink] tzulitai commented on issue #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends

2019-04-08 Thread GitBox
tzulitai commented on issue #8078: [FLINK-12066] [State Backends] Remove StateSerializerProvider field in keyed state backends URL: https://github.com/apache/flink/pull/8078#issuecomment-480712590 @flinkbot approve description @flinkbot approve consensus

[jira] [Commented] (FLINK-8033) Build Flink with JDK 9

2019-04-08 Thread Takanobu Asanuma (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812167#comment-16812167 ] Takanobu Asanuma commented on FLINK-8033: - bq. because you still have to solve most of the issues

[jira] [Commented] (FLINK-3991) Remove deprecated configuration keys from ConfigConstants

2019-04-08 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812161#comment-16812161 ] LiuJi commented on FLINK-3991: -- Hi [~Zentol] It seems now in ConfigConstants, some deprecated keys have no

[jira] [Commented] (FLINK-7916) Remove NetworkStackThroughputITCase

2019-04-08 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812155#comment-16812155 ] LiuJi commented on FLINK-7916: -- Agree, I think move these tests to _org.apache.flink.test.manual_ under

[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-08 Thread GitBox
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480705151 I don't think it's an optimization. I would say it's intuition every reader will have in the first

[GitHub] [flink] dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-08 Thread GitBox
dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272903193 ## File path:

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-08 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272878771 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-08 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272875577 ## File path: docs/dev/table/tableApi.md ## @@ -1847,6 +1847,22 @@ Table table = input

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-08 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272877997 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-08 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272899748 ## File path:

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-08 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272878971 ## File path:

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-08 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272877780 ## File path: docs/dev/table/tableApi.md ## @@ -1847,6 +1847,22 @@ Table table = input

[GitHub] [flink] hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API

2019-04-08 Thread GitBox
hequn8128 commented on a change in pull request #7196: [FLINK-10974] [table] Add support for flatMap to table API URL: https://github.com/apache/flink/pull/7196#discussion_r272878215 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java

[GitHub] [flink] dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-08 Thread GitBox
dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272902524 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions

2019-04-08 Thread GitBox
dawidwys commented on a change in pull request #8062: [FLINK-11884][table] Implement expression resolution on top of new Expressions URL: https://github.com/apache/flink/pull/8062#discussion_r272901252 ## File path:

[GitHub] [flink] JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-08 Thread GitBox
JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480702530 >> As I said before, you can immediately determine the left and right boundary with currentIndex -

[GitHub] [flink] JingsongLi edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-08 Thread GitBox
JingsongLi edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480702530 >> As I said before, you can immediately determine the left and right boundary with

[jira] [Commented] (FLINK-9787) Change ExecutionConfig#getGlobalJobParameters to return an instance of GlobalJobParameters instead of null if no custom globalJobParameters are set yet

2019-04-08 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-9787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812145#comment-16812145 ] LiuJi commented on FLINK-9787: -- Agree, it's a good idea to avoid NPE when invoke

[jira] [Updated] (FLINK-12120) Support queries like "select sum(b), count(c) from T group by a" run in batch mode

2019-04-08 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12120: --- Labels: pull-request-available (was: ) > Support queries like "select sum(b), count(c)

[GitHub] [flink] KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-08 Thread GitBox
KurtYoung commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480699105 I think the problem is the methods you proposed: `isLeftBoundRowInWindow` and

[GitHub] [flink] flinkbot commented on issue #8120: [FLINK-12120][table-planner-blink] Support queries like "select sum(b), count(c) from T group by a" run in batch mode

2019-04-08 Thread GitBox
flinkbot commented on issue #8120: [FLINK-12120][table-planner-blink] Support queries like "select sum(b), count(c) from T group by a" run in batch mode URL: https://github.com/apache/flink/pull/8120#issuecomment-480699193 Thanks a lot for your contribution to the Apache Flink project. I'm

[jira] [Commented] (FLINK-10437) Some of keys under withDeprecatedKeys aren't marked as @depreacted

2019-04-08 Thread LiuJi (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16812138#comment-16812138 ] LiuJi commented on FLINK-10437: --- You mean we should check all classes which use _withDeprecatedKeys_,if

[GitHub] [flink] JingsongLi opened a new pull request #8120: [FLINK-12120][table-planner-blink] Introduce "select sum(b), count(c) from T group by a" in Blink batch

2019-04-08 Thread GitBox
JingsongLi opened a new pull request #8120: [FLINK-12120][table-planner-blink] Introduce "select sum(b), count(c) from T group by a" in Blink batch URL: https://github.com/apache/flink/pull/8120 ## What is the purpose of the change Introduce "select sum(b), count(c) from T group by

[jira] [Updated] (FLINK-12120) Support queries like "select sum(b), count(c) from T group by a" run in batch mode

2019-04-08 Thread Kurt Young (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kurt Young updated FLINK-12120: --- Summary: Support queries like "select sum(b), count(c) from T group by a" run in batch mode (was:

[jira] [Created] (FLINK-12120) Introduce "select sum(b), count(c) from T group by a" in Blink batch

2019-04-08 Thread Jingsong Lee (JIRA)
Jingsong Lee created FLINK-12120: Summary: Introduce "select sum(b), count(c) from T group by a" in Blink batch Key: FLINK-12120 URL: https://issues.apache.org/jira/browse/FLINK-12120 Project: Flink

[GitHub] [flink] zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment

2019-04-08 Thread GitBox
zhijiangW commented on a change in pull request #8090: [FLINK-12067][network] Refactor the constructor of NetworkEnvironment URL: https://github.com/apache/flink/pull/8090#discussion_r272894672 ## File path:

[GitHub] [flink] JingsongLi edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-08 Thread GitBox
JingsongLi edited a comment on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480694448 Consider a new `BaseSlidingOverFrame`: It has two abstract method: 1.`public abstract

[GitHub] [flink] JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch

2019-04-08 Thread GitBox
JingsongLi commented on issue #8102: [FLINK-12087][table-runtime-blink] Introduce over window operators to blink batch URL: https://github.com/apache/flink/pull/8102#issuecomment-480694448 Consider a new `BaseSlidingOverFrame`: It has two abstract method: 1.`public abstract boolean

<    1   2   3