[jira] [Commented] (FLINK-12342) Yarn Resource Manager Acquires Too Many Containers

2019-04-30 Thread Zhenqiu Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830875#comment-16830875 ] Zhenqiu Huang commented on FLINK-12342: --- [~till.rohrmann] After reading the AMRMAsynclient, I just

[jira] [Commented] (FLINK-12260) Slot allocation failure by taskmanager registration timeout and race

2019-04-30 Thread Hwanju Kim (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830862#comment-16830862 ] Hwanju Kim commented on FLINK-12260: Thanks for the clarification. I thought you meant it without

[GitHub] [flink] xuefuz commented on issue #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-30 Thread GitBox
xuefuz commented on issue #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#issuecomment-488209732 did a forced push and now it seems good. This is an automated message

[GitHub] [flink] xuefuz removed a comment on issue #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-30 Thread GitBox
xuefuz removed a comment on issue #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#issuecomment-488206199 > Hi @xuefuz , can you properly rebase to master? the commit history has some unrelated commits What unrelated commits

[GitHub] [flink] xuefuz commented on issue #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-30 Thread GitBox
xuefuz commented on issue #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#issuecomment-488206199 > Hi @xuefuz , can you properly rebase to master? the commit history has some unrelated commits What unrelated commits you saw?

[GitHub] [flink] bowenli86 commented on issue #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-30 Thread GitBox
bowenli86 commented on issue #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#issuecomment-488205589 Hi @xuefuz , can you properly rebase to master? the commit history has some unrelated commits

[GitHub] [flink] piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-30 Thread GitBox
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#issuecomment-488195295 Seems like the missing ingredient was this commit:

[jira] [Updated] (FLINK-12375) flink-container job jar does not have read permissions

2019-04-30 Thread Adam Lamar (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Lamar updated FLINK-12375: --- Description: When building a custom job container using flink-container, the job can't be launched

[GitHub] [flink] piyushnarang edited a comment on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-30 Thread GitBox
piyushnarang edited a comment on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#issuecomment-488128359 P.S. @tillrohrmann / @shuai-xu - I was able to test this out on a hadoop cluster. I had to copy the following jars to my

[GitHub] [flink] stevenzwu edited a comment on issue #8315: [FLINK-12368] add subtask index to FlinkKafkaConsumerBase logging, wh…

2019-04-30 Thread GitBox
stevenzwu edited a comment on issue #8315: [FLINK-12368] add subtask index to FlinkKafkaConsumerBase logging, wh… URL: https://github.com/apache/flink/pull/8315#issuecomment-488149092 @Myasuka that is good to know. This can be an option. but I am not sure if we always want to enable

[GitHub] [flink] stevenzwu commented on issue #8315: [FLINK-12368] add subtask index to FlinkKafkaConsumerBase logging, wh…

2019-04-30 Thread GitBox
stevenzwu commented on issue #8315: [FLINK-12368] add subtask index to FlinkKafkaConsumerBase logging, wh… URL: https://github.com/apache/flink/pull/8315#issuecomment-488149092 @Myasuka that is good to know.enable thread name in each log line can be an option. but I am not sure if we

[jira] [Updated] (FLINK-12379) Parallelism in job/GCS/Hadoop: Could not finalize the pending checkpoint

2019-04-30 Thread Henrik (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrik updated FLINK-12379: --- Description: When running one standalone-job w/ parallelism=1 + one taskmanager, you will shortly get this

[GitHub] [flink] xuefuz commented on a change in pull request #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste…

2019-04-30 Thread GitBox
xuefuz commented on a change in pull request #8312: [FLINK-12366][table] Clean up Catalog APIs to make them more consiste… URL: https://github.com/apache/flink/pull/8312#discussion_r279961356 ## File path:

[jira] [Created] (FLINK-12379) Parallelism in job/GCS/Hadoop: Could not finalize the pending checkpoint

2019-04-30 Thread Henrik (JIRA)
Henrik created FLINK-12379: -- Summary: Parallelism in job/GCS/Hadoop: Could not finalize the pending checkpoint Key: FLINK-12379 URL: https://issues.apache.org/jira/browse/FLINK-12379 Project: Flink

[jira] [Updated] (FLINK-12376) GCS runtime exn: Request payload size exceeds the limit

2019-04-30 Thread Henrik (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrik updated FLINK-12376: --- Environment: FROM flink:1.8.0-scala_2.11 ARG version=0.17 ADD

[GitHub] [flink] xuefuz commented on issue #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-30 Thread GitBox
xuefuz commented on issue #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#issuecomment-488133623 I updated the PR with the following reworking: 1. Modified CatalogColumnStatistics class to enclose statistical info of all columns

[GitHub] [flink] flinkbot edited a comment on issue #8326: [FLINK-12378][docs] Consolidate FileSystem Documentation

2019-04-30 Thread GitBox
flinkbot edited a comment on issue #8326: [FLINK-12378][docs] Consolidate FileSystem Documentation URL: https://github.com/apache/flink/pull/8326#issuecomment-488131875 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review

[jira] [Commented] (FLINK-8513) Add documentation for connecting to non-AWS S3 endpoints

2019-04-30 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830731#comment-16830731 ] Seth Wiesman commented on FLINK-8513: - Included as part of

[GitHub] [flink] sjwiesman commented on issue #8326: [FLINK-12378][docs] Consolidate FileSystem Documentation

2019-04-30 Thread GitBox
sjwiesman commented on issue #8326: [FLINK-12378][docs] Consolidate FileSystem Documentation URL: https://github.com/apache/flink/pull/8326#issuecomment-488131970 @flinkbot attention @fhueske This is an automated message

[GitHub] [flink] flinkbot commented on issue #8326: [FLINK-12378][docs] Consolidate FileSystem Documentation

2019-04-30 Thread GitBox
flinkbot commented on issue #8326: [FLINK-12378][docs] Consolidate FileSystem Documentation URL: https://github.com/apache/flink/pull/8326#issuecomment-488131875 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull

[GitHub] [flink] sjwiesman opened a new pull request #8326: Flink 12378

2019-04-30 Thread GitBox
sjwiesman opened a new pull request #8326: Flink 12378 URL: https://github.com/apache/flink/pull/8326 ## What is the purpose of the change Currently flink's filesystem documentation is spread across a number of pages without any clear connection. A non-exhaustive list of

[GitHub] [flink] piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-30 Thread GitBox
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#issuecomment-488128359 P.S. @tillrohrmann / @shuai-xu - I was able to test this out on a hadoop cluster. I had to copy the following jars to my lib

[jira] [Created] (FLINK-12378) Consolidate FileSystem Documentation

2019-04-30 Thread Seth Wiesman (JIRA)
Seth Wiesman created FLINK-12378: Summary: Consolidate FileSystem Documentation Key: FLINK-12378 URL: https://issues.apache.org/jira/browse/FLINK-12378 Project: Flink Issue Type: Improvement

[jira] [Assigned] (FLINK-8513) Add documentation for connecting to non-AWS S3 endpoints

2019-04-30 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-8513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman reassigned FLINK-8513: --- Assignee: Seth Wiesman > Add documentation for connecting to non-AWS S3 endpoints >

[jira] [Created] (FLINK-12377) Outdated docs (Flink 0.10) for Google Compute Engine

2019-04-30 Thread Henrik (JIRA)
Henrik created FLINK-12377: -- Summary: Outdated docs (Flink 0.10) for Google Compute Engine Key: FLINK-12377 URL: https://issues.apache.org/jira/browse/FLINK-12377 Project: Flink Issue Type: Bug

[jira] [Assigned] (FLINK-10249) Document hadoop/presto s3 file system configuration forwarding

2019-04-30 Thread Seth Wiesman (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seth Wiesman reassigned FLINK-10249: Assignee: Seth Wiesman > Document hadoop/presto s3 file system configuration forwarding

[jira] [Updated] (FLINK-12376) GCS runtime exn: Request payload size exceeds the limit

2019-04-30 Thread Henrik (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henrik updated FLINK-12376: --- Description: I'm trying to use the google cloud storage file system, but it would seem that the FLINK /

[jira] [Commented] (FLINK-12355) KafkaITCase.testTimestamps is unstable

2019-04-30 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830686#comment-16830686 ] Bowen Li commented on FLINK-12355: -- saw another failure

[jira] [Updated] (FLINK-12355) KafkaITCase.testTimestamps is unstable

2019-04-30 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12355: - Affects Version/s: 1.9.0 > KafkaITCase.testTimestamps is unstable >

[jira] [Updated] (FLINK-12355) KafkaITCase.testTimestamps is unstable

2019-04-30 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12355: - Fix Version/s: 1.9.0 > KafkaITCase.testTimestamps is unstable > --

[GitHub] [flink] piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-30 Thread GitBox
piyushnarang commented on issue #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#issuecomment-488112927 @tillrohrmann do you know if there's any special setup required for the flink e2e tests to run on developer machines? I'm

[GitHub] [flink] yanyan300300 commented on issue #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem

2019-04-30 Thread GitBox
yanyan300300 commented on issue #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem URL: https://github.com/apache/flink/pull/8215#issuecomment-488111519 @tillrohrmann @aljoscha Could you kindly review this change? Thanks!

[jira] [Created] (FLINK-12376) GCS runtime exn: Request payload size exceeds the limit

2019-04-30 Thread Henrik (JIRA)
Henrik created FLINK-12376: -- Summary: GCS runtime exn: Request payload size exceeds the limit Key: FLINK-12376 URL: https://issues.apache.org/jira/browse/FLINK-12376 Project: Flink Issue Type: Bug

[GitHub] [flink] piyushnarang commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-04-30 Thread GitBox
piyushnarang commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#discussion_r279896298 ## File path:

[jira] [Created] (FLINK-12375) flink-container job jar does not have read permissions

2019-04-30 Thread Adam Lamar (JIRA)
Adam Lamar created FLINK-12375: -- Summary: flink-container job jar does not have read permissions Key: FLINK-12375 URL: https://issues.apache.org/jira/browse/FLINK-12375 Project: Flink Issue

[GitHub] [flink] yanyan300300 commented on issue #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem

2019-04-30 Thread GitBox
yanyan300300 commented on issue #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem URL: https://github.com/apache/flink/pull/8215#issuecomment-488062731 > Indeed, it looks like this is the better approach. Aside from some minor details

[GitHub] [flink] yanyan300300 edited a comment on issue #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem

2019-04-30 Thread GitBox
yanyan300300 edited a comment on issue #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem URL: https://github.com/apache/flink/pull/8215#issuecomment-488062731 > Indeed, it looks like this is the better approach. Aside from some minor

[GitHub] [flink] yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem

2019-04-30 Thread GitBox
yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem URL: https://github.com/apache/flink/pull/8215#discussion_r279876022 ## File path:

[GitHub] [flink] yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem

2019-04-30 Thread GitBox
yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem URL: https://github.com/apache/flink/pull/8215#discussion_r279873137 ## File path:

[GitHub] [flink] yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem

2019-04-30 Thread GitBox
yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem URL: https://github.com/apache/flink/pull/8215#discussion_r279865426 ## File path:

[GitHub] [flink] yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem

2019-04-30 Thread GitBox
yanyan300300 commented on a change in pull request #8215: [FLINK-8801][yarn/s3] Fix jars downloading issues due to inconsistent timestamp in S3 Filesystem URL: https://github.com/apache/flink/pull/8215#discussion_r279864771 ## File path:

[GitHub] [flink] flinkbot commented on issue #8325: [hotfix] [table] Refactor GenericInMemoryCatalogTest to prepare for moving common tests to CatalogTestBase

2019-04-30 Thread GitBox
flinkbot commented on issue #8325: [hotfix] [table] Refactor GenericInMemoryCatalogTest to prepare for moving common tests to CatalogTestBase URL: https://github.com/apache/flink/pull/8325#issuecomment-488043959 Thanks a lot for your contribution to the Apache Flink project. I'm the

[GitHub] [flink] bowenli86 opened a new pull request #8325: [hotfix] [table] Refactor GenericInMemoryCatalogTest to prepare for moving common tests to CatalogTestBase

2019-04-30 Thread GitBox
bowenli86 opened a new pull request #8325: [hotfix] [table] Refactor GenericInMemoryCatalogTest to prepare for moving common tests to CatalogTestBase URL: https://github.com/apache/flink/pull/8325 ## What is the purpose of the change This PR refactors existing

[jira] [Closed] (FLINK-11475) Adapt existing InMemoryExternalCatalog to GenericInMemoryCatalog

2019-04-30 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li closed FLINK-11475. Resolution: Won't Fix created GenericInMemoryCatalog from scratch > Adapt existing

[jira] [Commented] (FLINK-11921) Upgrade Calcite dependency to 1.19

2019-04-30 Thread Rong Rong (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830474#comment-16830474 ] Rong Rong commented on FLINK-11921: --- Thanks for the follow up [~ykt836]. I found the issue and it is

[GitHub] [flink] flinkbot commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-04-30 Thread GitBox
flinkbot commented on issue #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324#issuecomment-488032392 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We

[jira] [Updated] (FLINK-11921) Upgrade Calcite dependency to 1.19

2019-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-11921: --- Labels: pull-request-available (was: ) > Upgrade Calcite dependency to 1.19 >

[GitHub] [flink] walterddr opened a new pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19

2019-04-30 Thread GitBox
walterddr opened a new pull request #8324: [FLINK-11921][table] Upgrade to calcite 1.19 URL: https://github.com/apache/flink/pull/8324 ## What is the purpose of the change This change upgrades apache calcite dependencies to 1.19.0 release. ## Brief change log -

[GitHub] [flink] bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs

2019-04-30 Thread GitBox
bowenli86 commented on a change in pull request #8314: [FLINK-12365][table] Add stats related catalog APIs URL: https://github.com/apache/flink/pull/8314#discussion_r279839941 ## File path:

[GitHub] [flink] zhijiangW commented on issue #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-30 Thread GitBox
zhijiangW commented on issue #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#issuecomment-488025285 I updated the codes for addressing the left comments. @azagrebin Regarding

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-30 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r279837029 ## File path:

[jira] [Commented] (FLINK-11637) Translate "Checkpoints" page into Chinese

2019-04-30 Thread dalongliu (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-11637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830423#comment-16830423 ] dalongliu commented on FLINK-11637: --- Hi, [~klion26] Is anyone doing the work now? > Translate

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-30 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r279816732 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-30 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r279814078 ## File path:

[GitHub] [flink] zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment

2019-04-30 Thread GitBox
zhijiangW commented on a change in pull request #7822: [FLINK-11726][network] Refactor the creation of ResultPartition and InputGate into NetworkEnvironment URL: https://github.com/apache/flink/pull/7822#discussion_r279814078 ## File path:

[GitHub] [flink] flinkbot commented on issue #8323: [BP-1.7][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators

2019-04-30 Thread GitBox
flinkbot commented on issue #8323: [BP-1.7][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators URL: https://github.com/apache/flink/pull/8323#issuecomment-488000878 Thanks a lot for your contribution to the Apache Flink project. I'm

[GitHub] [flink] klion26 opened a new pull request #8323: [BP-1.7][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators

2019-04-30 Thread GitBox
klion26 opened a new pull request #8323: [BP-1.7][FLINK-12296][StateBackend] Fix local state directory collision with state loss for chained keyed operators URL: https://github.com/apache/flink/pull/8323 ## What is the purpose of the change manual cherry-pick #8263 to

[GitHub] [flink] klion26 commented on issue #8313: [FLINK-12184][Coordination]HistoryServerArchieFetcher incompatible with old version

2019-04-30 Thread GitBox
klion26 commented on issue #8313: [FLINK-12184][Coordination]HistoryServerArchieFetcher incompatible with old version URL: https://github.com/apache/flink/pull/8313#issuecomment-487998692 @tillrohrmann thanks for the quick review.

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-48798 I opened a issuse before, it describe a scene that containts two steps.

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-48798 I opened a issuse before, it describe a scene that containts two steps.

[GitHub] [flink] flinkbot edited a comment on issue #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
flinkbot edited a comment on issue #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#issuecomment-485317615 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to

[GitHub] [flink] GJL commented on issue #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL commented on issue #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#issuecomment-487985822 @flinkbot approve-until architecture This is an automated

[GitHub] [flink] GJL edited a comment on issue #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL edited a comment on issue #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#issuecomment-487985288 Thanks for your contribution to Apache Flink, @shuai-xu! The changes look overall good, and I have left a few minor

[GitHub] [flink] GJL commented on issue #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL commented on issue #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#issuecomment-487985288 Thanks for your contribution to Apache Flink @shuai-xu. The changes look overall good, and I have left a few minor comments.

[GitHub] [flink] GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#discussion_r279792812 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#discussion_r279786441 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#discussion_r279758565 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#discussion_r279788463 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#discussion_r279633733 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#discussion_r279792342 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface

2019-04-30 Thread GitBox
GJL commented on a change in pull request #8233: [FLINK-12227] [runtime] introduce SchedulingStrategy interface URL: https://github.com/apache/flink/pull/8233#discussion_r279787045 ## File path:

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-48798 I opened a issuse before, it describe a scene that containts two steps.

[jira] [Commented] (FLINK-12343) Allow set file.replication in Yarn Configuration

2019-04-30 Thread Zhenqiu Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830362#comment-16830362 ] Zhenqiu Huang commented on FLINK-12343: --- [~till.rohrmann] I agree that we shouldn't define a

[jira] [Created] (FLINK-12374) Support translation from StreamExecTableSourceScan/BatchExecTableSourceScan to StreamTransformation.

2019-04-30 Thread Jing Zhang (JIRA)
Jing Zhang created FLINK-12374: -- Summary: Support translation from StreamExecTableSourceScan/BatchExecTableSourceScan to StreamTransformation. Key: FLINK-12374 URL: https://issues.apache.org/jira/browse/FLINK-12374

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487979406 ok,I agree with you

[GitHub] [flink] tillrohrmann commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
tillrohrmann commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487977504 It is true that Yarn could try to restart the cluster depending on the

[jira] [Commented] (FLINK-12343) Allow set file.replication in Yarn Configuration

2019-04-30 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830343#comment-16830343 ] Till Rohrmann commented on FLINK-12343: --- I think the {{ResourceManager}} also sets up some local

[GitHub] [flink] azagrebin commented on a change in pull request #8320: [FLINK-12201][network][metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric

2019-04-30 Thread GitBox
azagrebin commented on a change in pull request #8320: [FLINK-12201][network][metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric URL: https://github.com/apache/flink/pull/8320#discussion_r279770711 ## File path:

[GitHub] [flink] azagrebin commented on a change in pull request #8320: [FLINK-12201][network][metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric

2019-04-30 Thread GitBox
azagrebin commented on a change in pull request #8320: [FLINK-12201][network][metrics] Introduce InputGateWithMetrics in Task to increment numBytesIn metric URL: https://github.com/apache/flink/pull/8320#discussion_r279764419 ## File path:

[jira] [Commented] (FLINK-12343) Allow set file.replication in Yarn Configuration

2019-04-30 Thread Zhenqiu Huang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830330#comment-16830330 ] Zhenqiu Huang commented on FLINK-12343: --- [~till.rohrmann][~rmetzger] I think we can set the

[GitHub] [flink] HuangZhenQiu commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration

2019-04-30 Thread GitBox
HuangZhenQiu commented on issue #8303: [FLINK-12343]add file replication config for yarn configuration URL: https://github.com/apache/flink/pull/8303#issuecomment-487964624 @rmetzger @tillrohrmann I think we can set the hdfs.replication in YarnConfiguration of

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487951795 I have a question that if use `System.exit` to kill the JobManager,the Yarn

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487951795 I have a question that if use `System.exit` to kill the JobManager,the Yarn

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487951795 I have a question that if use `System.exit` to kill the JobManager,the

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487951795 but, another problem is I can't re-open this issue again

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487950703 Your solution is fantastic @tillrohrmann! I known the reason,but I'm

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487950703 Your solution is fantastic @tillrohrmann! I known the reason,but I'm sorry

[jira] [Assigned] (FLINK-12184) HistoryServerArchiveFetcher isn't compatible with old version

2019-04-30 Thread Till Rohrmann (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-12184: - Assignee: Congxian Qiu(klion26) > HistoryServerArchiveFetcher isn't compatible with

[GitHub] [flink] tillrohrmann commented on a change in pull request #8313: [FLINK-12184][Coordination]HistoryServerArchieFetcher incompatible with old version

2019-04-30 Thread GitBox
tillrohrmann commented on a change in pull request #8313: [FLINK-12184][Coordination]HistoryServerArchieFetcher incompatible with old version URL: https://github.com/apache/flink/pull/8313#discussion_r279748455 ## File path:

[GitHub] [flink] yanghua commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-04-30 Thread GitBox
yanghua commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#issuecomment-487947096 @StefanRRichter This is the second step's PR of the checkpoint failure process improvement.

[jira] [Updated] (FLINK-12364) Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12364: --- Labels: pull-request-available (was: ) > Introduce a CheckpointFailureManager to

[GitHub] [flink] flinkbot commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-04-30 Thread GitBox
flinkbot commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#issuecomment-487944247 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[GitHub] [flink] yanghua opened a new pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure

2019-04-30 Thread GitBox
yanghua opened a new pull request #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322 ## What is the purpose of the change *This pull request introduces a CheckpointFailureManager to

[jira] [Commented] (FLINK-10317) Configure Metaspace size by default

2019-04-30 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16830265#comment-16830265 ] Nico Kruber commented on FLINK-10317: - I'm actually unsure whether we should set a default now, It

[GitHub] [flink] tillrohrmann commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-04-30 Thread GitBox
tillrohrmann commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-487940319 As I've said before, the archiving handlers belong to Flink and if they are

[jira] [Comment Edited] (FLINK-10317) Configure Metaspace size by default

2019-04-30 Thread Nico Kruber (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725939#comment-16725939 ] Nico Kruber edited comment on FLINK-10317 at 4/30/19 12:51 PM: --- -Actually

[GitHub] [flink] hequn8128 commented on issue #8230: [FLINK-10977][table] Add streaming non-window FlatAggregate to Table API

2019-04-30 Thread GitBox
hequn8128 commented on issue #8230: [FLINK-10977][table] Add streaming non-window FlatAggregate to Table API URL: https://github.com/apache/flink/pull/8230#issuecomment-487938937 @sunjincheng121 Thank you very much for your continues review and suggestions. I have addressed all your

[GitHub] [flink] flinkbot commented on issue #8321: [FLINK-12351][DataStream] Fix AsyncWaitOperator to deep copy StreamElement when object reuse is enabled

2019-04-30 Thread GitBox
flinkbot commented on issue #8321: [FLINK-12351][DataStream] Fix AsyncWaitOperator to deep copy StreamElement when object reuse is enabled URL: https://github.com/apache/flink/pull/8321#issuecomment-487935686 Thanks a lot for your contribution to the Apache Flink project. I'm the

[jira] [Updated] (FLINK-12351) AsyncWaitOperator should deep copy StreamElement when object reuse is enabled

2019-04-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12351: --- Labels: pull-request-available (was: ) > AsyncWaitOperator should deep copy StreamElement

[GitHub] [flink] wuchong opened a new pull request #8321: [FLINK-12351][DataStream] Fix AsyncWaitOperator to deep copy StreamElement when object reuse is enabled

2019-04-30 Thread GitBox
wuchong opened a new pull request #8321: [FLINK-12351][DataStream] Fix AsyncWaitOperator to deep copy StreamElement when object reuse is enabled URL: https://github.com/apache/flink/pull/8321 ## What is the purpose of the change Currently, AsyncWaitOperator directly put

  1   2   3   >