[GitHub] [flink] dawidwys commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-05-02 Thread GitBox
dawidwys commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r280663142 ## File path:

[GitHub] [flink] flinkbot commented on issue #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-02 Thread GitBox
flinkbot commented on issue #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337#issuecomment-488921461 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help

[GitHub] [flink] bowenli86 opened a new pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog

2019-05-02 Thread GitBox
bowenli86 opened a new pull request #8337: [FLINK-12232][hive] Create HiveCatalog and support database related operations in HiveCatalog URL: https://github.com/apache/flink/pull/8337 ## What is the purpose of the change This PR creates HiveCatalog in flink-connector-hive module and

[jira] [Updated] (FLINK-12232) Support database related operations in HiveCatalog

2019-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12232: --- Labels: pull-request-available (was: ) > Support database related operations in

[GitHub] [flink] bowenli86 commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog

2019-05-02 Thread GitBox
bowenli86 commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8329#discussion_r280604389 ## File path:

[jira] [Updated] (FLINK-12395) Reconcile description and detailed description in CatalogBaseTable

2019-05-02 Thread Bowen Li (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bowen Li updated FLINK-12395: - Description: CatalogBaseTable has {{getDescritpion()}} and {{getDetailedDescription()}} API, which

[GitHub] [flink] bowenli86 commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog

2019-05-02 Thread GitBox
bowenli86 commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8329#discussion_r280606701 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog

2019-05-02 Thread GitBox
bowenli86 commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8329#discussion_r280606701 ## File path:

[jira] [Created] (FLINK-12395) Reconcile description and detailed description in CatalogBaseTable

2019-05-02 Thread Bowen Li (JIRA)
Bowen Li created FLINK-12395: Summary: Reconcile description and detailed description in CatalogBaseTable Key: FLINK-12395 URL: https://issues.apache.org/jira/browse/FLINK-12395 Project: Flink

[GitHub] [flink] bowenli86 commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog

2019-05-02 Thread GitBox
bowenli86 commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8329#discussion_r280604389 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-05-02 Thread GitBox
bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r280525021 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-05-02 Thread GitBox
bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r280525021 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-05-02 Thread GitBox
bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r280600786 ## File path:

[jira] [Comment Edited] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-05-02 Thread Cliff Resnick (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831932#comment-16831932 ] Cliff Resnick edited comment on FLINK-12334 at 5/2/19 8:28 PM: --- Hi

[jira] [Comment Edited] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-05-02 Thread Cliff Resnick (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831932#comment-16831932 ] Cliff Resnick edited comment on FLINK-12334 at 5/2/19 8:27 PM: --- Hi

[jira] [Comment Edited] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-05-02 Thread Cliff Resnick (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831932#comment-16831932 ] Cliff Resnick edited comment on FLINK-12334 at 5/2/19 8:27 PM: --- Hi

[jira] [Comment Edited] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-05-02 Thread Cliff Resnick (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831932#comment-16831932 ] Cliff Resnick edited comment on FLINK-12334 at 5/2/19 8:26 PM: --- Hi

[jira] [Commented] (FLINK-12334) change to MockStreamTask breaks OneInputStreamOperatorTestHarness

2019-05-02 Thread Cliff Resnick (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831932#comment-16831932 ] Cliff Resnick commented on FLINK-12334: --- Hi [~fan_li_ya] We have a custom StreamOperator with an

[GitHub] [flink] Xeli commented on a change in pull request #8259: [FLINK-12325][metrics] Fix bug in statsd exporter when using negative values

2019-05-02 Thread GitBox
Xeli commented on a change in pull request #8259: [FLINK-12325][metrics] Fix bug in statsd exporter when using negative values URL: https://github.com/apache/flink/pull/8259#discussion_r280538063 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-05-02 Thread GitBox
dawidwys commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r280532280 ## File path:

[GitHub] [flink] bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema

2019-05-02 Thread GitBox
bowenli86 commented on a change in pull request #8214: [FLINK-11476] [table] Create CatalogManager to manage multiple catalogs and encapsulate Calcite schema URL: https://github.com/apache/flink/pull/8214#discussion_r280525021 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog

2019-05-02 Thread GitBox
xuefuz commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8329#discussion_r280505199 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog

2019-05-02 Thread GitBox
xuefuz commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8329#discussion_r280508961 ## File path:

[GitHub] [flink] xuefuz commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog

2019-05-02 Thread GitBox
xuefuz commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8329#discussion_r280508513 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280475679 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280471611 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280481421 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280480963 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280479507 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280482206 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280481073 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280480320 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280481273 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8242: [FLINK-6227][network] Introduce the DataConsumptionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#discussion_r280473083 ## File path:

[jira] [Comment Edited] (FLINK-12389) flink codegen set String type for ByteBuffer fields

2019-05-02 Thread Yu Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831745#comment-16831745 ] Yu Yang edited comment on FLINK-12389 at 5/2/19 4:42 PM: - [~twalthr], [~fhueske]

[GitHub] [flink] xuefuz commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog

2019-05-02 Thread GitBox
xuefuz commented on a change in pull request #8329: [FLINK-12239][hive] Support table related operations in GenericHiveMetastoreCatalog URL: https://github.com/apache/flink/pull/8329#discussion_r280503007 ## File path:

[GitHub] [flink] flinkbot commented on issue #8336: [FLINK-12305][docs][table] Improve Table API/SQL time attribute documentation.

2019-05-02 Thread GitBox
flinkbot commented on issue #8336: [FLINK-12305][docs][table] Improve Table API/SQL time attribute documentation. URL: https://github.com/apache/flink/pull/8336#issuecomment-488744275 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community

[jira] [Updated] (FLINK-12305) Table API Clarification

2019-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12305: --- Labels: pull-request-available (was: ) > Table API Clarification > ---

[GitHub] [flink] fhueske opened a new pull request #8336: [FLINK-12305][docs][table] Improve Table API/SQL time attribute documentation.

2019-05-02 Thread GitBox
fhueske opened a new pull request #8336: [FLINK-12305][docs][table] Improve Table API/SQL time attribute documentation. URL: https://github.com/apache/flink/pull/8336 ## Contribution Checklist ## What is the purpose of the change * Improve introduction of processing time and

[jira] [Commented] (FLINK-12389) flink codegen set String type for ByteBuffer fields

2019-05-02 Thread Yu Yang (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16831745#comment-16831745 ] Yu Yang commented on FLINK-12389: - [~twalthr], [~fhueske] thanks for the reply! given that this issue

[jira] [Assigned] (FLINK-12305) Table API Clarification

2019-05-02 Thread Fabian Hueske (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fabian Hueske reassigned FLINK-12305: - Assignee: Fabian Hueske > Table API Clarification > --- > >

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-02 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280485979 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-02 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280484675 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-02 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280487361 ## File path:

[GitHub] [flink] dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-02 Thread GitBox
dawidwys commented on a change in pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#discussion_r280480232 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory

2019-05-02 Thread GitBox
pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory URL: https://github.com/apache/flink/pull/8295#discussion_r280463187 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory

2019-05-02 Thread GitBox
pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory URL: https://github.com/apache/flink/pull/8295#discussion_r280472961 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory

2019-05-02 Thread GitBox
pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory URL: https://github.com/apache/flink/pull/8295#discussion_r280466736 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory

2019-05-02 Thread GitBox
pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory URL: https://github.com/apache/flink/pull/8295#discussion_r280467152 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory

2019-05-02 Thread GitBox
pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory URL: https://github.com/apache/flink/pull/8295#discussion_r280470782 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory

2019-05-02 Thread GitBox
pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory URL: https://github.com/apache/flink/pull/8295#discussion_r280474556 ## File path:

[GitHub] [flink] pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory

2019-05-02 Thread GitBox
pnowojski commented on a change in pull request #8295: [FLINK-11974][runtime] Introduce StreamOperatorFactory URL: https://github.com/apache/flink/pull/8295#discussion_r280467451 ## File path:

[GitHub] [flink] piyushnarang commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS

2019-05-02 Thread GitBox
piyushnarang commented on a change in pull request #8117: [FLINK-12115] [filesystems]: Add support for AzureFS URL: https://github.com/apache/flink/pull/8117#discussion_r280465958 ## File path:

[jira] [Created] (FLINK-12394) Update FileSystem factory classes to use HadoopConfigLoader

2019-05-02 Thread Piyush Narang (JIRA)
Piyush Narang created FLINK-12394: - Summary: Update FileSystem factory classes to use HadoopConfigLoader Key: FLINK-12394 URL: https://issues.apache.org/jira/browse/FLINK-12394 Project: Flink

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-05-02 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-488708907 ok This is an

[GitHub] [flink] tillrohrmann commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-05-02 Thread GitBox
tillrohrmann commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-488708092 The commit message and the PR title were a bit misleading. I've updated them.

[GitHub] [flink] rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-05-02 Thread GitBox
rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r280451532 ## File path:

[GitHub] [flink] rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-05-02 Thread GitBox
rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r280450967 ## File path:

[GitHub] [flink] rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-05-02 Thread GitBox
rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r280449150 ## File path: docs/dev/connectors/pubsub.md ## @@

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280432286 ## File path:

[GitHub] [flink] rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-05-02 Thread GitBox
rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r280448443 ## File path: docs/dev/connectors/pubsub.md ## @@

[GitHub] [flink] rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-05-02 Thread GitBox
rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r280448936 ## File path: docs/dev/connectors/pubsub.md ## @@

[GitHub] [flink] rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-05-02 Thread GitBox
rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r280449898 ## File path:

[GitHub] [flink] rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE)

2019-05-02 Thread GitBox
rmetzger commented on a change in pull request #6594: [FLINK-9311] [pubsub] Added PubSub source connector with support for checkpointing (ATLEAST_ONCE) URL: https://github.com/apache/flink/pull/6594#discussion_r280454402 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280434081 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280432648 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280447981 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280453988 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280453953 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280434680 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280438925 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280433723 ## File path:

[GitHub] [flink] tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it

2019-05-02 Thread GitBox
tillrohrmann commented on a change in pull request #8318: [FLINK-12231][runtime] Introduce Scheduler interface and adapt ExecutionGraph to it URL: https://github.com/apache/flink/pull/8318#discussion_r280434123 ## File path:

[GitHub] [flink] lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-05-02 Thread GitBox
lamber-ken edited a comment on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-488702391 hi, @tillrohrmann,  Sorry, it's ok, I just think you just add a

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-05-02 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-488702391 hi, @tillrohrmann, Sorry, it's ok, I just think you just add a future tool

[jira] [Created] (FLINK-12393) Add the user-facing classes of the new type system

2019-05-02 Thread Timo Walther (JIRA)
Timo Walther created FLINK-12393: Summary: Add the user-facing classes of the new type system Key: FLINK-12393 URL: https://issues.apache.org/jira/browse/FLINK-12393 Project: Flink Issue

[GitHub] [flink] lamber-ken commented on issue #8334: [FLINK-12219] Add utility to check for normal future completion

2019-05-02 Thread GitBox
lamber-ken commented on issue #8334: [FLINK-12219] Add utility to check for normal future completion URL: https://github.com/apache/flink/pull/8334#issuecomment-488700701 @tillrohrmann, LGTM.  This is an automated message

[GitHub] [flink] flinkbot commented on issue #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-02 Thread GitBox
flinkbot commented on issue #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335#issuecomment-488698361 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the

[GitHub] [flink] lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode

2019-05-02 Thread GitBox
lamber-ken commented on issue #8254: [FLINK-12219][runtime] Yarn application can't stop when flink job failed in per-job yarn cluste mode URL: https://github.com/apache/flink/pull/8254#issuecomment-488698323 hi, @tillrohrmann, I think your fix is fantastic

[jira] [Updated] (FLINK-12253) Setup a class hierarchy for the new logical type system

2019-05-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-12253: --- Labels: pull-request-available (was: ) > Setup a class hierarchy for the new logical type

[GitHub] [flink] twalthr opened a new pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system

2019-05-02 Thread GitBox
twalthr opened a new pull request #8335: [FLINK-12253][table-common] Setup a class hierarchy for the new logical type system URL: https://github.com/apache/flink/pull/8335 ## What is the purpose of the change This PR implements all logical types that Flink's type system should

[jira] [Updated] (FLINK-12253) Setup a class hierarchy for the new logical type system

2019-05-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-12253: - Description: Setup a new class hierarchy around {{LogicalType}} in {{table-common}}. The

[jira] [Updated] (FLINK-12253) Setup a class hierarchy for the new logical type system

2019-05-02 Thread Timo Walther (JIRA)
[ https://issues.apache.org/jira/browse/FLINK-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-12253: - Summary: Setup a class hierarchy for the new logical type system (was: Setup a class hierarchy

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280416137 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r279634373 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280435403 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280430217 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r279718029 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280423763 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r279731809 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r279724405 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280319208 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r279728912 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280310271 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r279729385 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280310078 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r279718671 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280430142 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r280426220 ## File path:

[GitHub] [flink] GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy

2019-05-02 Thread GitBox
GJL commented on a change in pull request #8296: [FLINK-12228] [runtime] Implement Eager Scheduling Strategy URL: https://github.com/apache/flink/pull/8296#discussion_r279733104 ## File path:

  1   2   >