[GitHub] [flink] flinkbot edited a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-647010602 ## CI report: * e57e583260e23ec0c0b4bbbdabd51ec2a08ac726 Azure:

[GitHub] [flink] XBaith commented on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
XBaith commented on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-649224082 Thank you @RocMarshal. LGTM. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] XBaith commented on a change in pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
XBaith commented on a change in pull request #12727: URL: https://github.com/apache/flink/pull/12727#discussion_r445307991 ## File path: docs/learn-flink/fault_tolerance.zh.md ## @@ -29,180 +29,137 @@ under the License. ## State Backends -The keyed state managed by Flink

[GitHub] [flink] RocMarshal removed a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
RocMarshal removed a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-649217684 @klion26 , @XBaith Thank you for your help. I have made some alterations according to your suggestions, please take a look.

[GitHub] [flink] RocMarshal commented on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
RocMarshal commented on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-649218289 @klion26 , @XBaith Thank you for your help. I have made some alterations according to your suggestions, please take a look.

[GitHub] [flink] RocMarshal closed pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
RocMarshal closed pull request #12727: URL: https://github.com/apache/flink/pull/12727 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] RocMarshal commented on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
RocMarshal commented on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-649217684 @klion26 , @XBaith Thank you for your help. I have made some alterations according to your suggestions, please take a look.

[GitHub] [flink] flinkbot edited a comment on pull request #12768: [FLINK-17804][parquet] Follow Parquet spec when decoding DECIMAL

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12768: URL: https://github.com/apache/flink/pull/12768#issuecomment-649142405 ## CI report: * 066e41b9e06caf58e4ef5a8fbe6ea49b0bc9168e Azure:

[jira] [Commented] (FLINK-18433) From the end-to-end performance test results, 1.11 has a regression

2020-06-24 Thread Congxian Qiu(klion26) (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144611#comment-17144611 ] Congxian Qiu(klion26) commented on FLINK-18433: --- [~Aihua] thanks for the work, maybe the

[GitHub] [flink] klion26 commented on a change in pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
klion26 commented on a change in pull request #12727: URL: https://github.com/apache/flink/pull/12727#discussion_r445279543 ## File path: docs/learn-flink/fault_tolerance.zh.md ## @@ -29,180 +29,137 @@ under the License. ## State Backends -The keyed state managed by Flink

[GitHub] [flink] klion26 commented on a change in pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
klion26 commented on a change in pull request #12727: URL: https://github.com/apache/flink/pull/12727#discussion_r445280354 ## File path: docs/learn-flink/fault_tolerance.zh.md ## @@ -29,180 +29,137 @@ under the License. ## State Backends -The keyed state managed by Flink

[GitHub] [flink] klion26 commented on a change in pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
klion26 commented on a change in pull request #12727: URL: https://github.com/apache/flink/pull/12727#discussion_r445279543 ## File path: docs/learn-flink/fault_tolerance.zh.md ## @@ -29,180 +29,137 @@ under the License. ## State Backends -The keyed state managed by Flink

[jira] [Updated] (FLINK-18433) From the end-to-end performance test results, 1.11 has a regression

2020-06-24 Thread Aihua Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aihua Li updated FLINK-18433: - Summary: From the end-to-end performance test results, 1.11 has a regression (was: From the end-to-end

[GitHub] [flink] flinkbot edited a comment on pull request #12768: [FLINK-17804][parquet] Follow Parquet spec when decoding DECIMAL

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12768: URL: https://github.com/apache/flink/pull/12768#issuecomment-649142405 ## CI report: * 066e41b9e06caf58e4ef5a8fbe6ea49b0bc9168e Azure:

[GitHub] [flink] flinkbot commented on pull request #12768: [FLINK-17804][parquet] Follow Parquet spec when decoding DECIMAL

2020-06-24 Thread GitBox
flinkbot commented on pull request #12768: URL: https://github.com/apache/flink/pull/12768#issuecomment-649142405 ## CI report: * 066e41b9e06caf58e4ef5a8fbe6ea49b0bc9168e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Updated] (FLINK-18427) Job failed under java 11

2020-06-24 Thread Zhang Hao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhang Hao updated FLINK-18427: -- Summary: Job failed under java 11 (was: Job failed on java 11) > Job failed under java 11 >

[jira] [Updated] (FLINK-18427) Job failed on java 11

2020-06-24 Thread Zhang Hao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhang Hao updated FLINK-18427: -- Summary: Job failed on java 11 (was: Job failed under java 11) > Job failed on java 11 >

[jira] [Reopened] (FLINK-18116) Manually test E2E performance on Flink 1.11

2020-06-24 Thread Aihua Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aihua Li reopened FLINK-18116: -- I ran end-to-end performance tests between the Release-1.10 and Release-1.11 and found 1.11 has a

[jira] [Updated] (FLINK-18433) From the end-to-end performance test results, 1.11 has a

2020-06-24 Thread Aihua Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aihua Li updated FLINK-18433: - Summary: From the end-to-end performance test results, 1.11 has a (was: 1.11 has a regression) >

[jira] [Created] (FLINK-18433) 1.11 has a regression

2020-06-24 Thread Aihua Li (Jira)
Aihua Li created FLINK-18433: Summary: 1.11 has a regression Key: FLINK-18433 URL: https://issues.apache.org/jira/browse/FLINK-18433 Project: Flink Issue Type: Bug Components: API /

[jira] [Commented] (FLINK-17804) Follow the spec when decoding Parquet logical DECIMAL type

2020-06-24 Thread Sergii Mikhtoniuk (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144545#comment-17144545 ] Sergii Mikhtoniuk commented on FLINK-17804: --- I've created [a

[GitHub] [flink] flinkbot commented on pull request #12768: [FLINK-17804][parquet] Follow Parquet spec when decoding DECIMAL

2020-06-24 Thread GitBox
flinkbot commented on pull request #12768: URL: https://github.com/apache/flink/pull/12768#issuecomment-649137157 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-17804) Follow the spec when decoding Parquet logical DECIMAL type

2020-06-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-17804: --- Labels: decimal parquet pull-request-available spark (was: decimal parquet spark) >

[GitHub] [flink] sergiimk opened a new pull request #12768: [FLINK-17804][parquet] Follow Parquet spec when decoding DECIMAL

2020-06-24 Thread GitBox
sergiimk opened a new pull request #12768: URL: https://github.com/apache/flink/pull/12768 ## What is the purpose of the change Current implementation of the Parquet reader decodes DECIMAL types incorrectly. It doesn't follow the spec and will either throw `NumberFormatException`

[GitHub] [flink] flinkbot edited a comment on pull request #12722: [FLINK-18064][docs] Added unaligned checkpointing to docs.

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12722: URL: https://github.com/apache/flink/pull/12722#issuecomment-646626465 ## CI report: * 91dfe90937ec1c2680022a12a1c4984fd59e61cf UNKNOWN * f818134b647f6e34bade6189640bd81575f0162c Azure:

[jira] [Issue Comment Deleted] (FLINK-18116) Manually test E2E performance on Flink 1.11

2020-06-24 Thread Aihua Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aihua Li updated FLINK-18116: - Comment: was deleted (was: I mainly ran the stability test developed by Ali: by simulating online

[jira] [Closed] (FLINK-18115) Manually test fault-tolerance stability on Flink 1.11

2020-06-24 Thread Aihua Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aihua Li closed FLINK-18115. Resolution: Done I mainly ran the stability test developed by Ali: by simulating online abnormal

[GitHub] [flink] flinkbot edited a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-647010602 ## CI report: * e57e583260e23ec0c0b4bbbdabd51ec2a08ac726 Azure:

[jira] [Commented] (FLINK-9278) Allow restore savepoint with some SQL queries added/removed

2020-06-24 Thread Samrat Bhattacharya (Jira)
[ https://issues.apache.org/jira/browse/FLINK-9278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144418#comment-17144418 ] Samrat Bhattacharya commented on FLINK-9278: [~fhueske]: Any update on this issue? > Allow

[GitHub] [flink] flinkbot edited a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-647010602 ## CI report: * 99d95bf94b1604274c75ad4193aec6ece9416d6d Azure:

[jira] [Created] (FLINK-18432) add open and close methods for ElasticsearchSinkFunction interface

2020-06-24 Thread rinkako (Jira)
rinkako created FLINK-18432: --- Summary: add open and close methods for ElasticsearchSinkFunction interface Key: FLINK-18432 URL: https://issues.apache.org/jira/browse/FLINK-18432 Project: Flink

[GitHub] [flink] zentol closed pull request #7820: [FLINK-11742][Metrics]Push metrics to Pushgateway without "instance"

2020-06-24 Thread GitBox
zentol closed pull request #7820: URL: https://github.com/apache/flink/pull/7820 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] zentol commented on pull request #7820: [FLINK-11742][Metrics]Push metrics to Pushgateway without "instance"

2020-06-24 Thread GitBox
zentol commented on pull request #7820: URL: https://github.com/apache/flink/pull/7820#issuecomment-649039991 I will close this PR for now. Without all components having a well-defined and exposed ID we cannot provide a proper container ID (see FLINK-9543). Any interim solution would just

[GitHub] [flink] flinkbot edited a comment on pull request #12722: [FLINK-18064][docs] Added unaligned checkpointing to docs.

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12722: URL: https://github.com/apache/flink/pull/12722#issuecomment-646626465 ## CI report: * 91dfe90937ec1c2680022a12a1c4984fd59e61cf UNKNOWN * 8718566c0b74fd6c3c6327980c1ee1d2abc8eda8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12722: [FLINK-18064][docs] Added unaligned checkpointing to docs.

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12722: URL: https://github.com/apache/flink/pull/12722#issuecomment-646626465 ## CI report: * 91dfe90937ec1c2680022a12a1c4984fd59e61cf UNKNOWN * 8718566c0b74fd6c3c6327980c1ee1d2abc8eda8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-647010602 ## CI report: * 89242d0d76ab11a8d36234835ff121e16c92b17e Azure:

[jira] [Resolved] (FLINK-18428) StreamExecutionEnvironment#continuousSource() method should be renamed to source()

2020-06-24 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-18428. -- Resolution: Fixed Fixed in - 1.11.0 via 369d4a6ce46dddfd2a14ad66ac2e189bd4827158 - 1.12.0

[jira] [Closed] (FLINK-18428) StreamExecutionEnvironment#continuousSource() method should be renamed to source()

2020-06-24 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-18428. > StreamExecutionEnvironment#continuousSource() method should be renamed to > source() >

[jira] [Resolved] (FLINK-18430) Upgrade stability to @Public for CheckpointedFunction and CheckpointListener

2020-06-24 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-18430. -- Resolution: Fixed Fixed in - 1.11.0 via 25cad5fb517bc8a6a6e2a37c78e43c474a99bbd9 - 1.12.0

[jira] [Closed] (FLINK-18430) Upgrade stability to @Public for CheckpointedFunction and CheckpointListener

2020-06-24 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-18430. > Upgrade stability to @Public for CheckpointedFunction and CheckpointListener >

[jira] [Closed] (FLINK-18429) Add default method for CheckpointListener.notifyCheckpointAborted(checkpointId)

2020-06-24 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen closed FLINK-18429. > Add default method for > CheckpointListener.notifyCheckpointAborted(checkpointId) >

[jira] [Resolved] (FLINK-18429) Add default method for CheckpointListener.notifyCheckpointAborted(checkpointId)

2020-06-24 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen resolved FLINK-18429. -- Resolution: Fixed Fixed in - 1.11.0 via a60a4a9c71a2648176ca46a25230920674130d01 - 1.12.0

[GitHub] [flink] asfgit closed pull request #12767: [FLINK-18429][DataStream API] Make CheckpointListener.notifyCheckpointAborted(checkpointId) a default method.

2020-06-24 Thread GitBox
asfgit closed pull request #12767: URL: https://github.com/apache/flink/pull/12767 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] asfgit closed pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
asfgit closed pull request #12766: URL: https://github.com/apache/flink/pull/12766 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] flinkbot edited a comment on pull request #12699: [FLINK-18349][docs] Add release notes for Flink 1.11

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12699: URL: https://github.com/apache/flink/pull/12699#issuecomment-645525540 ## CI report: * d182fc4331b08fc00e5d7ad339e1f3ae79d6f7bc UNKNOWN * 768b439c76d6e261294a63b5e5d10738419054c1 UNKNOWN *

[GitHub] [flink] wanglijie95 commented on pull request #12754: [FLINK-5717][streaming] Fix NPE on SessionWindows with ContinuousProc…

2020-06-24 Thread GitBox
wanglijie95 commented on pull request #12754: URL: https://github.com/apache/flink/pull/12754#issuecomment-648976755 > Thanks for the fix! I think, however, that `WindowOperatorTest` is not the right place to put the test, it should be added in `ContinuousProcessingTimeTriggerTest`. I

[GitHub] [flink] flinkbot edited a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-647010602 ## CI report: * 89242d0d76ab11a8d36234835ff121e16c92b17e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12765: [FLINK-18417][table] Support List as a conversion class for ARRAY

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12765: URL: https://github.com/apache/flink/pull/12765#issuecomment-648778671 ## CI report: * 29e7c8685d8218fa538e14772fc32d945cf1c56a Azure:

[GitHub] [flink] RocMarshal commented on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
RocMarshal commented on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-648963595 Hi,@XBaith I have made some changes based on your suggestions, which is very helpful for improvement. Thank you so much.

[GitHub] [flink] flinkbot edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005 ## CI report: * 71eefff46a38b7b50afb251e5fb338f64134a821 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-647010602 ## CI report: * 89242d0d76ab11a8d36234835ff121e16c92b17e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-647010602 ## CI report: * 89242d0d76ab11a8d36234835ff121e16c92b17e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12767: [FLINK-18429][DataStream API] Make CheckpointListener.notifyCheckpointAborted(checkpointId) a default method.

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12767: URL: https://github.com/apache/flink/pull/12767#issuecomment-648936333 ## CI report: * cf0c7ecf53413b9051bb02138515dce579f533f4 Azure:

[GitHub] [flink] StephanEwen commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
StephanEwen commented on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648947003 Merging this as part of the current batch of fixes... This is an automated message from the Apache Git

[GitHub] [flink] flinkbot commented on pull request #12767: [FLINK-18429][DataStream API] Make CheckpointListener.notifyCheckpointAborted(checkpointId) a default method.

2020-06-24 Thread GitBox
flinkbot commented on pull request #12767: URL: https://github.com/apache/flink/pull/12767#issuecomment-648936333 ## CI report: * cf0c7ecf53413b9051bb02138515dce579f533f4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] pnowojski commented on pull request #12736: [FLINK-17800][rocksdb] Ensure total order seek to avoid user misuse

2020-06-24 Thread GitBox
pnowojski commented on pull request #12736: URL: https://github.com/apache/flink/pull/12736#issuecomment-648935901 +1 to merge this to `release-1.11`, just please take an extra care to not destabilise the build again. This

[jira] [Closed] (FLINK-18116) Manually test E2E performance on Flink 1.11

2020-06-24 Thread Aihua Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aihua Li closed FLINK-18116. Resolution: Done I mainly ran the stability test developed by Ali: by simulating online abnormal

[GitHub] [flink] StephanEwen commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
StephanEwen commented on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648925287 +1 from my side This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] flinkbot edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005 ## CI report: * 71eefff46a38b7b50afb251e5fb338f64134a821 Azure:

[jira] [Commented] (FLINK-18429) Add default method for CheckpointListener.notifyCheckpointAborted(checkpointId)

2020-06-24 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144001#comment-17144001 ] Stephan Ewen commented on FLINK-18429: -- With apologies to [~yunta] for the confusion I caused here.

[jira] [Updated] (FLINK-18429) Add default method for CheckpointListener.notifyCheckpointAborted(checkpointId)

2020-06-24 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephan Ewen updated FLINK-18429: - Description: The {{CheckpointListener}} interface is implemented by many users. Adding a new

[GitHub] [flink] flinkbot commented on pull request #12767: [FLINK-18429][DataStream API] Make CheckpointListener.notifyCheckpointAborted(checkpointId) a default method.

2020-06-24 Thread GitBox
flinkbot commented on pull request #12767: URL: https://github.com/apache/flink/pull/12767#issuecomment-648922022 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Closed] (FLINK-18431) Provide default empty implementation of notifyCheckpointAborted

2020-06-24 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-18431. -- Resolution: Duplicate > Provide default empty implementation of notifyCheckpointAborted >

[jira] [Created] (FLINK-18431) Provide default empty implementation of notifyCheckpointAborted

2020-06-24 Thread Piotr Nowojski (Jira)
Piotr Nowojski created FLINK-18431: -- Summary: Provide default empty implementation of notifyCheckpointAborted Key: FLINK-18431 URL: https://issues.apache.org/jira/browse/FLINK-18431 Project: Flink

[jira] [Assigned] (FLINK-18431) Provide default empty implementation of notifyCheckpointAborted

2020-06-24 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-18431: -- Assignee: Piotr Nowojski > Provide default empty implementation of

[jira] [Updated] (FLINK-18429) Add default method for CheckpointListener.notifyCheckpointAborted(checkpointId)

2020-06-24 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-18429: --- Labels: pull-request-available (was: ) > Add default method for >

[GitHub] [flink] StephanEwen opened a new pull request #12767: [FLINK-18429][DataStream API] Make CheckpointListener.notifyCheckpointAborted(checkpointId) a default method.

2020-06-24 Thread GitBox
StephanEwen opened a new pull request #12767: URL: https://github.com/apache/flink/pull/12767 ## Purpose / Brief change log This PR prevents breaking existing user programs by making the newly added method `CheckpointListener.notifyCheckpointAborted(checkpointId)` a default method.

[jira] [Created] (FLINK-18430) Upgrade stability to @Public for CheckpointedFunction and CheckpointListener

2020-06-24 Thread Stephan Ewen (Jira)
Stephan Ewen created FLINK-18430: Summary: Upgrade stability to @Public for CheckpointedFunction and CheckpointListener Key: FLINK-18430 URL: https://issues.apache.org/jira/browse/FLINK-18430

[GitHub] [flink] flinkbot edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005 ## CI report: * 71eefff46a38b7b50afb251e5fb338f64134a821 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12758: [FLINK-18386][docs-zh] Translate "Print SQL Connector" page into Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12758: URL: https://github.com/apache/flink/pull/12758#issuecomment-648346882 ## CI report: * ca0cfac41e49d373d70c9e62bf6edc6ba9337ac8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12765: [FLINK-18417][table] Support List as a conversion class for ARRAY

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12765: URL: https://github.com/apache/flink/pull/12765#issuecomment-648778671 ## CI report: * 07e0fd5e74dda6415cab5445c2ec41c1ee3375c2 Azure:

[GitHub] [flink] XBaith commented on a change in pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
XBaith commented on a change in pull request #12727: URL: https://github.com/apache/flink/pull/12727#discussion_r444988317 ## File path: docs/learn-flink/fault_tolerance.zh.md ## @@ -29,180 +29,137 @@ under the License. ## State Backends -The keyed state managed by Flink

[GitHub] [flink] austince commented on pull request #12056: [FLINK-17502] [flink-connector-rabbitmq] RMQSource refactor

2020-06-24 Thread GitBox
austince commented on pull request #12056: URL: https://github.com/apache/flink/pull/12056#issuecomment-648908629 @senegalo feel better! I don't think there's any rush for our stuff since it's 1.11 release season as well!

[jira] [Commented] (FLINK-18427) Job failed under java 11

2020-06-24 Thread Stephan Ewen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17143951#comment-17143951 ] Stephan Ewen commented on FLINK-18427: -- Thanks for reporting this. I think the reason is that

[GitHub] [flink] becketqin commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
becketqin commented on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648897424 @twalthr @dawidwys Thanks for the review. I'll merge the patch after the CI tests pass. This is an automated

[jira] [Created] (FLINK-18429) Add default method for CheckpointListener.notifyCheckpointAborted(checkpointId)

2020-06-24 Thread Stephan Ewen (Jira)
Stephan Ewen created FLINK-18429: Summary: Add default method for CheckpointListener.notifyCheckpointAborted(checkpointId) Key: FLINK-18429 URL: https://issues.apache.org/jira/browse/FLINK-18429

[GitHub] [flink] becketqin commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
becketqin commented on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648890887 @twalthr I think the clearest naming is either `StreamExecutionEnvironment#dataStreamFromSource()` or `DataStream#fromSource()`. But given the current status, I agree that

[GitHub] [flink] StephanEwen commented on pull request #12736: [FLINK-17800][rocksdb] Ensure total order seek to avoid user misuse

2020-06-24 Thread GitBox
StephanEwen commented on pull request #12736: URL: https://github.com/apache/flink/pull/12736#issuecomment-64155 Looks fine from my side, thanks. +1 to merge into `master`. About merging to `release-1.11` - this is up to @pnowojski and @zhijiangW as release managers.

[GitHub] [flink] flinkbot edited a comment on pull request #12699: [FLINK-18349][docs] Add release notes for Flink 1.11

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12699: URL: https://github.com/apache/flink/pull/12699#issuecomment-645525540 ## CI report: * d182fc4331b08fc00e5d7ad339e1f3ae79d6f7bc UNKNOWN * 2a876970e69c0f14f31125441e92432aab3ac817 Azure:

[GitHub] [flink] dawidwys commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
dawidwys commented on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648871161 +1 from my side Personally I am fine with either `fromSource`/`addSource`/`source`. This is an

[GitHub] [flink] flinkbot edited a comment on pull request #12758: [FLINK-18386][docs-zh] Translate "Print SQL Connector" page into Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12758: URL: https://github.com/apache/flink/pull/12758#issuecomment-648346882 ## CI report: * e14e00b7039fbac4800a8ef83d04e02bd621824c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12699: [FLINK-18349][docs] Add release notes for Flink 1.11

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12699: URL: https://github.com/apache/flink/pull/12699#issuecomment-645525540 ## CI report: * d182fc4331b08fc00e5d7ad339e1f3ae79d6f7bc UNKNOWN * 2a876970e69c0f14f31125441e92432aab3ac817 Azure:

[GitHub] [flink] twalthr edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
twalthr edited a comment on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648860657 Why don't we call this method `fromSource`? We have `fromElements`, `fromCollection`, `fromParallelCollection`. It is confusing that we also have `addSource`,

[GitHub] [flink] twalthr commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
twalthr commented on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648860657 Why don't we call this method `fromSource`? We have `fromElements`, `fromCollection`, `fromParallelCollection`. It is confusing that we also have `addSource`, `readFile`, and

[jira] [Closed] (FLINK-18426) Incompatible deprecated key type for registration cluster options

2020-06-24 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann closed FLINK-18426. - Resolution: Fixed Fixed via 1.12.0: ca534016f90efd348bc9596671f067f99ff3ae19 1.11.1:

[GitHub] [flink] tillrohrmann closed pull request #12763: [FLINK-18426] Remove incompatible deprecated keys from ClusterOptions

2020-06-24 Thread GitBox
tillrohrmann closed pull request #12763: URL: https://github.com/apache/flink/pull/12763 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] tillrohrmann commented on pull request #12763: [FLINK-18426] Remove incompatible deprecated keys from ClusterOptions

2020-06-24 Thread GitBox
tillrohrmann commented on pull request #12763: URL: https://github.com/apache/flink/pull/12763#issuecomment-648854167 Thanks for the review @zentol. The failing test case is unrelated. Merging this PR now. This is an

[GitHub] [flink] RocMarshal commented on pull request #12764: [FLINK-18423][docs] Fix Prefer tag in document "Detecting Patterns" age of "Streaming Concepts"

2020-06-24 Thread GitBox
RocMarshal commented on pull request #12764: URL: https://github.com/apache/flink/pull/12764#issuecomment-648846910 Hi, @wuchong I have updated 'Prefer tag' in documentation "Detecting Patterns" page of "Streaming Concepts" according to [Prefer

[GitHub] [flink] flinkbot edited a comment on pull request #12758: [FLINK-18386][docs-zh] Translate "Print SQL Connector" page into Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12758: URL: https://github.com/apache/flink/pull/12758#issuecomment-648346882 ## CI report: * e14e00b7039fbac4800a8ef83d04e02bd621824c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005 ## CI report: * 71eefff46a38b7b50afb251e5fb338f64134a821 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12765: [FLINK-18417][table] Support List as a conversion class for ARRAY

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12765: URL: https://github.com/apache/flink/pull/12765#issuecomment-648778671 ## CI report: * 07e0fd5e74dda6415cab5445c2ec41c1ee3375c2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12761: [FLINK-17465][doc-zh] Update Chinese translations for memory configuration documents.

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12761: URL: https://github.com/apache/flink/pull/12761#issuecomment-648644461 ## CI report: * 5231e75f7bbc13756b825a82ec7394521d75d5ad Azure:

[GitHub] [flink] twalthr commented on a change in pull request #12542: [FLINK-18168][table-runtime-blink] return a copy of reuseArray in ObjectArrayConverter.toBinaryArray()

2020-06-24 Thread GitBox
twalthr commented on a change in pull request #12542: URL: https://github.com/apache/flink/pull/12542#discussion_r444918058 ## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/data/conversion/ArrayObjectArrayConverter.java ## @@ -154,7

[GitHub] [flink] flinkbot edited a comment on pull request #12727: [FLINK-17292][docs] Translate Fault Tolerance training lesson to Chinese

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12727: URL: https://github.com/apache/flink/pull/12727#issuecomment-647010602 ## CI report: * 89242d0d76ab11a8d36234835ff121e16c92b17e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #12699: [FLINK-18349][docs] Add release notes for Flink 1.11

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12699: URL: https://github.com/apache/flink/pull/12699#issuecomment-645525540 ## CI report: * d182fc4331b08fc00e5d7ad339e1f3ae79d6f7bc UNKNOWN * 2a876970e69c0f14f31125441e92432aab3ac817 Azure:

[GitHub] [flink] flinkbot commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
flinkbot commented on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648833005 ## CI report: * 71eefff46a38b7b50afb251e5fb338f64134a821 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #12765: [FLINK-18417][table] Support List as a conversion class for ARRAY

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12765: URL: https://github.com/apache/flink/pull/12765#issuecomment-648778671 ## CI report: * 07e0fd5e74dda6415cab5445c2ec41c1ee3375c2 Azure:

[GitHub] [flink] twalthr commented on pull request #12765: [FLINK-18417][table] Support List as a conversion class for ARRAY

2020-06-24 Thread GitBox
twalthr commented on pull request #12765: URL: https://github.com/apache/flink/pull/12765#issuecomment-648824075 Thanks @aljoscha and @dawidwys. I addressed your comments. Will merge this once the build is green. This is an

[GitHub] [flink] flinkbot commented on pull request #12766: [FLINK-18428][API/DataStream] Rename StreamExecutionEnvironment#continuousSource() to StreamExecutionEnvironment#source().

2020-06-24 Thread GitBox
flinkbot commented on pull request #12766: URL: https://github.com/apache/flink/pull/12766#issuecomment-648821613 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #12764: [FLINK-18423][docs] Fix Prefer tag in document "Detecting Patterns" age of "Streaming Concepts"

2020-06-24 Thread GitBox
flinkbot edited a comment on pull request #12764: URL: https://github.com/apache/flink/pull/12764#issuecomment-648708396 ## CI report: * f9febcc443a0d401e5ce2f296d817311268e1b12 Azure:

  1   2   3   >