[GitHub] [flink] zentol merged pull request #14882: [FLINK-21303][coordination] Maybe remove LogicalSlot#getPhysicalSlotNumber

2021-02-08 Thread GitBox
zentol merged pull request #14882: URL: https://github.com/apache/flink/pull/14882 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] zentol commented on a change in pull request #14790: [FLINK-21134] Introduce 'scheduler-mode' config option

2021-02-08 Thread GitBox
zentol commented on a change in pull request #14790: URL: https://github.com/apache/flink/pull/14790#discussion_r571941281 ## File path: flink-runtime/src/test/java/org/apache/flink/runtime/entrypoint/ClusterEntrypointTest.java ## @@ -0,0 +1,66 @@ +/* + * Licensed to the

[jira] [Created] (FLINK-21320) Stream from FlinkKafkaShuffle.persistentKeyBy does not end if upstream ends

2021-02-08 Thread Kezhu Wang (Jira)
Kezhu Wang created FLINK-21320: -- Summary: Stream from FlinkKafkaShuffle.persistentKeyBy does not end if upstream ends Key: FLINK-21320 URL: https://issues.apache.org/jira/browse/FLINK-21320 Project:

[GitHub] [flink] tillrohrmann closed pull request #14855: [FLINK-21155][tests] Fix FileSourceTextLinesITCase

2021-02-08 Thread GitBox
tillrohrmann closed pull request #14855: URL: https://github.com/apache/flink/pull/14855 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] tillrohrmann commented on pull request #14856: [BP-1.12][FLINK-21155][tests] Fix FileSourceTextLinesITCase

2021-02-08 Thread GitBox
tillrohrmann commented on pull request #14856: URL: https://github.com/apache/flink/pull/14856#issuecomment-775044298 @XComp approved the PR #14855. Merging this backport PR as well. This is an automated message from the

[jira] [Commented] (FLINK-18634) FlinkKafkaProducerITCase.testRecoverCommittedTransaction failed with "Timeout expired after 60000milliseconds while awaiting InitProducerId"

2021-02-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280929#comment-17280929 ] Till Rohrmann commented on FLINK-18634: --- Another instance of the {{testScaleUpAfterScalingDown}}

[GitHub] [flink] tillrohrmann commented on pull request #14855: [FLINK-21155][tests] Fix FileSourceTextLinesITCase

2021-02-08 Thread GitBox
tillrohrmann commented on pull request #14855: URL: https://github.com/apache/flink/pull/14855#issuecomment-775043894 Thanks for the review @XComp. The failing test seems to be unrelated. Merging this PR now. This is an

[jira] [Assigned] (FLINK-21100) Add DeclarativeScheduler skeleton

2021-02-08 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-21100: Assignee: Chesnay Schepler > Add DeclarativeScheduler skeleton >

[jira] [Commented] (FLINK-20663) Managed memory may not be released in time when operators use managed memory frequently

2021-02-08 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280927#comment-17280927 ] Xintong Song commented on FLINK-20663: -- [~trohrmann], [~ykt836], I'm afraid implementing our own

[jira] [Updated] (FLINK-21274) At per-job mode, during the exit of the JobManager process, if ioExecutor exits at the end, the System.exit() method will not be executed.

2021-02-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21274: -- Fix Version/s: 1.13.0 1.12.2 1.11.4 > At per-job mode,

[jira] [Commented] (FLINK-21274) At per-job mode, during the exit of the JobManager process, if ioExecutor exits at the end, the System.exit() method will not be executed.

2021-02-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280925#comment-17280925 ] Till Rohrmann commented on FLINK-21274: --- I've assigned you to this ticket [~wjc920]. Happy coding!

[jira] [Assigned] (FLINK-21274) At per-job mode, during the exit of the JobManager process, if ioExecutor exits at the end, the System.exit() method will not be executed.

2021-02-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann reassigned FLINK-21274: - Assignee: Jichao Wang > At per-job mode, during the exit of the JobManager process, if

[jira] [Commented] (FLINK-21274) At per-job mode, during the exit of the JobManager process, if ioExecutor exits at the end, the System.exit() method will not be executed.

2021-02-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280924#comment-17280924 ] Till Rohrmann commented on FLINK-21274: --- Thanks for reporting and analysing this problem so

[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #14891: URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149 ## CI report: * 9c2009b345b3c138b83d25d2ca929a33f5918ab8 Azure:

[jira] [Commented] (FLINK-21108) Flink runtime rest server and history server webmonitor do not require authentication.

2021-02-08 Thread Xiaoguang Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280918#comment-17280918 ] Xiaoguang Sun commented on FLINK-21108: --- Sure > Flink runtime rest server and history server

[jira] [Updated] (FLINK-21221) Deduplication of ResourceCounter

2021-02-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21221: --- Labels: pull-request-available starter (was: starter) > Deduplication of ResourceCounter >

[jira] [Commented] (FLINK-21201) Creating BoundedBlockingSubpartition blocks TaskManager’s main thread

2021-02-08 Thread Zhilong Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280903#comment-17280903 ] Zhilong Hong commented on FLINK-21201: -- Sorry for making it confusing. I mean moving the

[GitHub] [flink] flinkbot commented on pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-08 Thread GitBox
flinkbot commented on pull request #14897: URL: https://github.com/apache/flink/pull/14897#issuecomment-775027203 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] KarmaGYZ opened a new pull request #14897: [FLINK-21221][runtime] Deduplication for multiple ResourceCounters

2021-02-08 Thread GitBox
KarmaGYZ opened a new pull request #14897: URL: https://github.com/apache/flink/pull/14897 ## What is the purpose of the change Deduplication for multiple ResourceCounters. ## Brief change log Introduce the `org.apache.flink.runtime.util.ResourceCounter` to

[GitHub] [flink] flinkbot edited a comment on pull request #14896: [FLINK-21176][docs] translate the updates of 'avro-confluent.zh.md' to Chinese

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #14896: URL: https://github.com/apache/flink/pull/14896#issuecomment-775006223 ## CI report: * 3fc334c1fe49196ce9c9be922b62296b7b1e0f09 Azure:

[jira] [Updated] (FLINK-21289) Application mode ignores the pipeline.classpaths configuration

2021-02-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Till Rohrmann updated FLINK-21289: -- Issue Type: Bug (was: Improvement) > Application mode ignores the pipeline.classpaths

[jira] [Commented] (FLINK-21108) Flink runtime rest server and history server webmonitor do not require authentication.

2021-02-08 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280894#comment-17280894 ] Till Rohrmann commented on FLINK-21108: --- The easier something is to configure the better I think.

[GitHub] [flink] tillrohrmann commented on pull request #14798: [FLINK-21187] Provide exception history for root causes

2021-02-08 Thread GitBox
tillrohrmann commented on pull request #14798: URL: https://github.com/apache/flink/pull/14798#issuecomment-775012926 Ok, then let's first fix this instability before merging this PR @XComp. Ping once the instability has been fixed.

[GitHub] [flink] tillrohrmann commented on a change in pull request #14837: [FLINK-20417][k8s] Create a new watcher when the old one is closed with HTTP_GONE

2021-02-08 Thread GitBox
tillrohrmann commented on a change in pull request #14837: URL: https://github.com/apache/flink/pull/14837#discussion_r571896290 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderRetrievalDriver.java ## @@ -114,10

[GitHub] [flink] jjiey commented on pull request #14896: [FLINK-21176][docs] translate the updates of 'avro-confluent.zh.md' to Chinese

2021-02-08 Thread GitBox
jjiey commented on pull request #14896: URL: https://github.com/apache/flink/pull/14896#issuecomment-775007853 Hi, @wuchong , could you help to review this? thanks. This is an automated message from the Apache Git Service.

[GitHub] [flink] flinkbot commented on pull request #14896: [FLINK-21176][docs] translate the updates of 'avro-confluent.zh.md' to Chinese

2021-02-08 Thread GitBox
flinkbot commented on pull request #14896: URL: https://github.com/apache/flink/pull/14896#issuecomment-775006223 ## CI report: * 3fc334c1fe49196ce9c9be922b62296b7b1e0f09 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[jira] [Commented] (FLINK-21309) Metrics of JobManager and TaskManager overwrite each other in pushgateway

2021-02-08 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280881#comment-17280881 ] Chesnay Schepler commented on FLINK-21309: -- 1) Use the option that appends a random suffix. >

[GitHub] [flink] pnowojski merged pull request #14887: [FLINK-21033][checkpointing] Remove PendingCheckpoint.statsCallback

2021-02-08 Thread GitBox
pnowojski merged pull request #14887: URL: https://github.com/apache/flink/pull/14887 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Closed] (FLINK-21033) Remove PendingCheckpoint.statsCallback

2021-02-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-21033. -- Resolution: Fixed merged commit 35757ed into apache:master > Remove

[jira] [Commented] (FLINK-21201) Creating BoundedBlockingSubpartition blocks TaskManager’s main thread

2021-02-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280879#comment-17280879 ] Piotr Nowojski commented on FLINK-21201: What do you mean by "the first approach"? Using

[jira] [Updated] (FLINK-21053) Prevent potential RejectedExecutionExceptions in CheckpointCoordinator failing JM

2021-02-08 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-21053: -- Description: In the past, there were multiple bugs caused by throwing/handling

[jira] [Updated] (FLINK-21053) Prevent potential RejectedExecutionExceptions in CheckpointCoordinator failing JM

2021-02-08 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-21053: -- Summary: Prevent potential RejectedExecutionExceptions in CheckpointCoordinator

[GitHub] [flink] flinkbot commented on pull request #14896: [FLINK-21176][docs] translate the updates of 'avro-confluent.zh.md' to Chinese

2021-02-08 Thread GitBox
flinkbot commented on pull request #14896: URL: https://github.com/apache/flink/pull/14896#issuecomment-774993801 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-21176) Translate updates on Confluent Avro Format page

2021-02-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-21176: --- Labels: pull-request-available (was: ) > Translate updates on Confluent Avro Format page >

[GitHub] [flink] jjiey opened a new pull request #14896: [FLINK-21176][docs] translate the updates of 'avro-confluent.zh.md' to Chinese

2021-02-08 Thread GitBox
jjiey opened a new pull request #14896: URL: https://github.com/apache/flink/pull/14896 ## What is the purpose of the change [FLINK-21176](https://issues.apache.org/jira/browse/FLINK-21176) Translate the updates of 'avro-confluent.zh.md' to Chinese ## Brief change

[jira] [Commented] (FLINK-17726) Scheduler should take care of tasks directly canceled by TaskManager

2021-02-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280870#comment-17280870 ] Piotr Nowojski commented on FLINK-17726: Yes/maybe [~zhuzh]. I think you summarised the gist of

[GitHub] [flink] wangyang0918 edited a comment on pull request #14837: [FLINK-20417][k8s] Create a new watcher when the old one is closed with HTTP_GONE

2021-02-08 Thread GitBox
wangyang0918 edited a comment on pull request #14837: URL: https://github.com/apache/flink/pull/14837#issuecomment-774945693 @tillrohrmann Thanks for your nice review of this PR. I force pushed again and please have a look. I think now I realized what is problem of this PR or some

[jira] [Commented] (FLINK-21317) Downstream keyed state not work after FlinkKafkaShuffle

2021-02-08 Thread Kezhu Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280863#comment-17280863 ] Kezhu Wang commented on FLINK-21317: Hi [~ym], I found this in code reading not production use case.

[GitHub] [flink] gaoyunhaii commented on pull request #14831: [FLINK-21086][runtime][checkpoint] CheckpointBarrierHandler Insert barriers for channels received EndOfPartition

2021-02-08 Thread GitBox
gaoyunhaii commented on pull request #14831: URL: https://github.com/apache/flink/pull/14831#issuecomment-774983012 Got it~ I'll go with the subsume~ This is an automated message from the Apache Git Service. To respond to

[GitHub] [flink] flinkbot edited a comment on pull request #14790: [FLINK-21134] Introduce 'scheduler-mode' config option

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #14790: URL: https://github.com/apache/flink/pull/14790#issuecomment-768914005 ## CI report: * 91d2fe95d95e5e3874ac056cc4ebd6d8dbc5d406 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14754: [FLINK-21127][runtime][checkpoint] Stores finished status for fully finished operators in checkpoint

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #14754: URL: https://github.com/apache/flink/pull/14754#issuecomment-766965862 ## CI report: * 13548fbb8d09727b172ebdf26a90c56d409fa1f2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #13341: [FLINK-15854][hive][table-planner-blink] Use the new type inference f…

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #13341: URL: https://github.com/apache/flink/pull/13341#issuecomment-688346241 ## CI report: * ee58a70cab9c228ed0bfeb861b6b9ba120383b57 Azure:

[GitHub] [flink] pnowojski commented on pull request #14831: [FLINK-21086][runtime][checkpoint] CheckpointBarrierHandler Insert barriers for channels received EndOfPartition

2021-02-08 Thread GitBox
pnowojski commented on pull request #14831: URL: https://github.com/apache/flink/pull/14831#issuecomment-774975886 Subsuming is fine. It can happen right now just as well pretty frequently (especially with part of the job heavy backpressured).

[GitHub] [flink] flinkbot edited a comment on pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #14891: URL: https://github.com/apache/flink/pull/14891#issuecomment-774628149 ## CI report: * 9c2009b345b3c138b83d25d2ca929a33f5918ab8 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14790: [FLINK-21134] Introduce 'scheduler-mode' config option

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #14790: URL: https://github.com/apache/flink/pull/14790#issuecomment-768914005 ## CI report: * 91d2fe95d95e5e3874ac056cc4ebd6d8dbc5d406 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14754: [FLINK-21127][runtime][checkpoint] Stores finished status for fully finished operators in checkpoint

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #14754: URL: https://github.com/apache/flink/pull/14754#issuecomment-766965862 ## CI report: * 13548fbb8d09727b172ebdf26a90c56d409fa1f2 Azure:

[GitHub] [flink] gaoyunhaii commented on pull request #14754: [FLINK-21127][runtime][checkpoint] Stores finished status for fully finished operators in checkpoint

2021-02-08 Thread GitBox
gaoyunhaii commented on pull request #14754: URL: https://github.com/apache/flink/pull/14754#issuecomment-774955426 Hi Roman @rkhachatryan, very thanks for the review! I addressed the comments and added the missing test in

[jira] [Updated] (FLINK-21134) Reactive mode: Introduce execution mode configuration key and check for supported ClusterEntrypoint type

2021-02-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-21134: --- Description: According to the FLIP, introduce a "scheduler-mode" configuration key, and

[GitHub] [flink] rmetzger commented on pull request #14790: [FLINK-21134] Introduce 'execution-mode' config option

2021-02-08 Thread GitBox
rmetzger commented on pull request #14790: URL: https://github.com/apache/flink/pull/14790#issuecomment-774952882 Thanks for your feedback! I addressed all comments and rebased to the latest master. This is an automated

[GitHub] [flink] flinkbot edited a comment on pull request #14837: [FLINK-20417][k8s] Create a new watcher when the old one is closed with HTTP_GONE

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #14837: URL: https://github.com/apache/flink/pull/14837#issuecomment-771773023 ## CI report: * 5ffb46d41bd707a693ac347e62c37770665c61ad Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #14740: [FLINK-21067][runtime][checkpoint] Modify the logic of computing which tasks to trigger/ack/commit to support finished tasks

2021-02-08 Thread GitBox
flinkbot edited a comment on pull request #14740: URL: https://github.com/apache/flink/pull/14740#issuecomment-766340750 ## CI report: * c7e6b28b249f85cf52740d5201a769e0982a60aa UNKNOWN * bebd298009b12a9d5ac6518902f5534f8e00ff32 UNKNOWN *

[GitHub] [flink] gaoyunhaii commented on pull request #14831: [FLINK-21086][runtime][checkpoint] CheckpointBarrierHandler Insert barriers for channels received EndOfPartition

2021-02-08 Thread GitBox
gaoyunhaii commented on pull request #14831: URL: https://github.com/apache/flink/pull/14831#issuecomment-774951378 Yes, subsume would indeed be easier, the only concern is that it might cause some checkpoint failures that might introduce some confusion to users. Do you think this would

<    1   2   3   4