[jira] [Commented] (FLINK-24163) PartiallyFinishedSourcesITCase fails due to timeout

2021-09-08 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411749#comment-17411749 ] Yun Gao commented on FLINK-24163: - Hi [~dwysakowicz] the issue should be fixed after we also merge 

[jira] [Commented] (FLINK-23874) JM did not store latest checkpiont id into Zookeeper, silently

2021-09-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411747#comment-17411747 ] Piotr Nowojski commented on FLINK-23874: One more note [~ubyyj]. Next time if you want to get a

[jira] [Updated] (FLINK-24113) Introduce option in Application Mode to disable shutdown

2021-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Metzger updated FLINK-24113: --- Summary: Introduce option in Application Mode to disable shutdown (was: Introduce option

[GitHub] [flink] dawidwys commented on a change in pull request #17135: [FLINK-24098] Document FLIP-147 capabiliites and limitations

2021-09-08 Thread GitBox
dawidwys commented on a change in pull request #17135: URL: https://github.com/apache/flink/pull/17135#discussion_r704130575 ## File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md ## @@ -147,6 +154,11 @@

[jira] [Comment Edited] (FLINK-24113) Introduce option in Application Mode to request cluster shutdown

2021-09-08 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17408654#comment-17408654 ] Robert Metzger edited comment on FLINK-24113 at 9/8/21, 7:35 AM: -

[GitHub] [flink] dawidwys commented on a change in pull request #17135: [FLINK-24098] Document FLIP-147 capabiliites and limitations

2021-09-08 Thread GitBox
dawidwys commented on a change in pull request #17135: URL: https://github.com/apache/flink/pull/17135#discussion_r704130575 ## File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md ## @@ -147,6 +154,11 @@

[GitHub] [flink] dawidwys commented on a change in pull request #17135: [FLINK-24098] Document FLIP-147 capabiliites and limitations

2021-09-08 Thread GitBox
dawidwys commented on a change in pull request #17135: URL: https://github.com/apache/flink/pull/17135#discussion_r704130575 ## File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md ## @@ -147,6 +154,11 @@

[jira] [Closed] (FLINK-23874) JM did not store latest checkpiont id into Zookeeper, silently

2021-09-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23874?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski closed FLINK-23874. -- Resolution: Duplicate > JM did not store latest checkpiont id into Zookeeper, silently >

[jira] [Commented] (FLINK-23874) JM did not store latest checkpiont id into Zookeeper, silently

2021-09-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411745#comment-17411745 ] Piotr Nowojski commented on FLINK-23874: Ok, sorry [~ubyyj]. I think this is exactly what

[jira] [Comment Edited] (FLINK-23874) JM did not store latest checkpiont id into Zookeeper, silently

2021-09-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411745#comment-17411745 ] Piotr Nowojski edited comment on FLINK-23874 at 9/8/21, 7:32 AM: - Ok,

[jira] [Commented] (FLINK-23946) Application mode fails fatally when being shut down

2021-09-08 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-23946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411743#comment-17411743 ] David Morávek commented on FLINK-23946: --- Would result in test flakiness without resolving

[GitHub] [flink] dmvk commented on a change in pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

2021-09-08 Thread GitBox
dmvk commented on a change in pull request #17181: URL: https://github.com/apache/flink/pull/17181#discussion_r704124241 ## File path: NOTICE ## @@ -43,3 +43,22 @@ The Apache Flink project contains or reuses code that is licensed under the Apac - Google Cloud Client Library

[GitHub] [flink] dmvk commented on a change in pull request #17181: [FLINK-24183][legal] Add aws-java-sdk-s3 to source NOTICE

2021-09-08 Thread GitBox
dmvk commented on a change in pull request #17181: URL: https://github.com/apache/flink/pull/17181#discussion_r704124241 ## File path: NOTICE ## @@ -43,3 +43,22 @@ The Apache Flink project contains or reuses code that is licensed under the Apac - Google Cloud Client Library

[jira] [Resolved] (FLINK-23949) first incremental checkpoint after a savepoint will degenerate into a full checkpoint

2021-09-08 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-23949. -- Resolution: Fixed merged master: d2007b74d543edb05af203f115459c51378867d3 release-1.14:

[jira] [Updated] (FLINK-23949) first incremental checkpoint after a savepoint will degenerate into a full checkpoint

2021-09-08 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-23949: - Fix Version/s: 1.15.0 1.13.3 1.12.6 1.14.0 >

[GitHub] [flink] dawidwys commented on pull request #17120: [FLINK-24065][connector] Upgrade the state of TwoPhaseCommitSink to support empty transaction after finished

2021-09-08 Thread GitBox
dawidwys commented on pull request #17120: URL: https://github.com/apache/flink/pull/17120#issuecomment-914985789 My personal take is that 2 and 3 are the same. In either case the end goal is to have no transaction. What I find a bit confusing if we use a `TransactionHolder#empty` is the

[GitHub] [flink] flinkbot commented on pull request #17194: [FLINK-24034] Upgrade commons-compress to 1.21 and other apache.commons updates

2021-09-08 Thread GitBox
flinkbot commented on pull request #17194: URL: https://github.com/apache/flink/pull/17194#issuecomment-914985643 ## CI report: * 6e0471172aecaa4f4dfd4a31f90e1c74fd5e6a98 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #17192: [FLINK-24195][doc]Translate "DESCRIBE Statements" page of "SQL" into …

2021-09-08 Thread GitBox
flinkbot commented on pull request #17192: URL: https://github.com/apache/flink/pull/17192#issuecomment-914985462 ## CI report: * a5cb09d36ca9a5e91a896532e83500aa02b4ca4c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #17193: [FLINK-24203][runtime][tests] Resolve AbstractServerTest fails due to port conflict

2021-09-08 Thread GitBox
flinkbot commented on pull request #17193: URL: https://github.com/apache/flink/pull/17193#issuecomment-914985560 ## CI report: * 431885c512aa376be12ffc08bd042c1aab33a3e3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-08 Thread GitBox
flinkbot edited a comment on pull request #17186: URL: https://github.com/apache/flink/pull/17186#issuecomment-914384307 ## CI report: * 9a740a5445fc0dbf1799c5388525b58721da4a62 UNKNOWN * 0a44a1d73f9dec54cf272e7c0355654a3c0012fb Azure:

[GitHub] [flink] dawidwys commented on pull request #17189: [FLINK-23528][connectors/kinesis] Improving and reenable FlinkKinesisITCase

2021-09-08 Thread GitBox
dawidwys commented on pull request #17189: URL: https://github.com/apache/flink/pull/17189#issuecomment-914984634 Commenting only on cfe1b10f4c0ef4f1beb82ff53ce641a722dcae52 First of all I'd change the commit message. It is not a revert. It does change the semantics slightly. After

[GitHub] [flink] Myasuka closed pull request #16969: [FLINK-23949][runtime][checkpoint] fix first incremental checkpoint degenerate into full checkpoint after savepont

2021-09-08 Thread GitBox
Myasuka closed pull request #16969: URL: https://github.com/apache/flink/pull/16969 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zentol commented on a change in pull request #17184: [FLINK-24193][tests] Add ClassLoaderExtension

2021-09-08 Thread GitBox
zentol commented on a change in pull request #17184: URL: https://github.com/apache/flink/pull/17184#discussion_r704116516 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/extensions/ClassLoaderExtension.java ## @@

[jira] [Updated] (FLINK-17321) Support for casting collection types.

2021-09-08 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu updated FLINK-17321: Priority: Critical (was: Major) > Support for casting collection types. >

[jira] [Closed] (FLINK-24204) Failed to insert nested types using value construction functions

2021-09-08 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-24204. --- Resolution: Duplicate > Failed to insert nested types using value construction functions >

[jira] [Commented] (FLINK-24204) Failed to insert nested types using value construction functions

2021-09-08 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411735#comment-17411735 ] Jark Wu commented on FLINK-24204: - [~twalthr] you are right. I close this issue then and increase

[GitHub] [flink] xmarker commented on pull request #17193: [FLINK-24203][runtime][tests] Resolve AbstractServerTest fails due to port conflict

2021-09-08 Thread GitBox
xmarker commented on pull request #17193: URL: https://github.com/apache/flink/pull/17193#issuecomment-914975516 > This doesn't really address the issue. > > The first server should be started on port 0 so that it uses some open port. Thinks for reply,some new code pushed

[jira] [Commented] (FLINK-24163) PartiallyFinishedSourcesITCase fails due to timeout

2021-09-08 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411734#comment-17411734 ] Dawid Wysakowicz commented on FLINK-24163: -- [~gaoyunhaii] Did we fix this issue with the PR you

[jira] [Commented] (FLINK-23391) KafkaSourceReaderTest.testKafkaSourceMetrics fails on azure

2021-09-08 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411731#comment-17411731 ] Dawid Wysakowicz commented on FLINK-23391: -- cc [~arvid] >

[jira] [Updated] (FLINK-23391) KafkaSourceReaderTest.testKafkaSourceMetrics fails on azure

2021-09-08 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-23391: - Affects Version/s: 1.14.0 > KafkaSourceReaderTest.testKafkaSourceMetrics fails on azure

[jira] [Commented] (FLINK-23391) KafkaSourceReaderTest.testKafkaSourceMetrics fails on azure

2021-09-08 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411730#comment-17411730 ] Dawid Wysakowicz commented on FLINK-23391: --

[jira] [Created] (FLINK-24206) PulsarSourceITCase fails with "Consumer not found"

2021-09-08 Thread Dawid Wysakowicz (Jira)
Dawid Wysakowicz created FLINK-24206: Summary: PulsarSourceITCase fails with "Consumer not found" Key: FLINK-24206 URL: https://issues.apache.org/jira/browse/FLINK-24206 Project: Flink

[jira] [Issue Comment Deleted] (FLINK-23971) PulsarSourceITCase.testIdleReader failed on azure

2021-09-08 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz updated FLINK-23971: - Comment: was deleted (was:

[jira] [Commented] (FLINK-23971) PulsarSourceITCase.testIdleReader failed on azure

2021-09-08 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411727#comment-17411727 ] Dawid Wysakowicz commented on FLINK-23971: --

[GitHub] [flink] Airblader commented on a change in pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-08 Thread GitBox
Airblader commented on a change in pull request #17186: URL: https://github.com/apache/flink/pull/17186#discussion_r704106009 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-08 Thread GitBox
flinkbot edited a comment on pull request #17186: URL: https://github.com/apache/flink/pull/17186#issuecomment-914384307 ## CI report: * 9a740a5445fc0dbf1799c5388525b58721da4a62 UNKNOWN * 0a44a1d73f9dec54cf272e7c0355654a3c0012fb Azure:

[GitHub] [flink] flinkbot commented on pull request #17194: [FLINK-24034] Upgrade commons-compress to 1.21 and other apache.commons updates

2021-09-08 Thread GitBox
flinkbot commented on pull request #17194: URL: https://github.com/apache/flink/pull/17194#issuecomment-914969570 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #16969: [FLINK-23949][runtime][checkpoint] fix first incremental checkpoint degenerate into full checkpoint after savepont

2021-09-08 Thread GitBox
flinkbot edited a comment on pull request #16969: URL: https://github.com/apache/flink/pull/16969#issuecomment-904867960 ## CI report: * e2e83d6db7cc3b15e946862a510aca393096e942 UNKNOWN * 3125a2df1fde0b2fbd8aa27b71786d2b089a04c3 Azure:

[GitHub] [flink] amazingJing commented on pull request #16969: [FLINK-23949][runtime][checkpoint] fix first incremental checkpoint degenerate into full checkpoint after savepont

2021-09-08 Thread GitBox
amazingJing commented on pull request #16969: URL: https://github.com/apache/flink/pull/16969#issuecomment-914968797 > @amazingJing I think the failure might be something already fixed in master branch. You can try to rebase the https://github.com/zoltar9264/flink/tree/FLINK-23949 branch

[GitHub] [flink] Airblader commented on a change in pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-08 Thread GitBox
Airblader commented on a change in pull request #17186: URL: https://github.com/apache/flink/pull/17186#discussion_r704103712 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java ## @@

[jira] [Updated] (FLINK-24034) Upgrade commons-compress to 1.21

2021-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24034: --- Labels: pull-request-available (was: ) > Upgrade commons-compress to 1.21 >

[GitHub] [flink] flinkbot commented on pull request #17193: [FLINK-24203][runtime][tests] Resolve AbstractServerTest fails due to port conflict

2021-09-08 Thread GitBox
flinkbot commented on pull request #17193: URL: https://github.com/apache/flink/pull/17193#issuecomment-914968375 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] MartijnVisser opened a new pull request #17194: [FLINK-24034] Upgrade commons-compress to 1.21 and other apache.commons updates

2021-09-08 Thread GitBox
MartijnVisser opened a new pull request #17194: URL: https://github.com/apache/flink/pull/17194 ## What is the purpose of the change * Update commons-compress to 1.21 due to CVE-2021-35517 * Updated other apache.commons dependencies to latest version ## Brief change log

[GitHub] [flink] pnowojski commented on a change in pull request #17135: [FLINK-24098] Document FLIP-147 capabiliites and limitations

2021-09-08 Thread GitBox
pnowojski commented on a change in pull request #17135: URL: https://github.com/apache/flink/pull/17135#discussion_r704100504 ## File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md ## @@ -239,8 +239,9 @@ important observation that puts certain

[GitHub] [flink] Airblader commented on a change in pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-08 Thread GitBox
Airblader commented on a change in pull request #17186: URL: https://github.com/apache/flink/pull/17186#discussion_r704102162 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Expressions.java ## @@ -562,6 +563,43 @@ public static

[jira] [Updated] (FLINK-24204) Failed to insert nested types using value construction functions

2021-09-08 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-24204: - Parent: FLINK-12251 Issue Type: Sub-task (was: Bug) > Failed to insert nested types

[jira] [Assigned] (FLINK-24034) Upgrade commons-compress to 1.21

2021-09-08 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler reassigned FLINK-24034: Assignee: Martijn Visser (was: Chesnay Schepler) > Upgrade commons-compress to

[jira] [Commented] (FLINK-24204) Failed to insert nested types using value construction functions

2021-09-08 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411722#comment-17411722 ] Timo Walther commented on FLINK-24204: -- This is kind of a duplicate of FLINK-17321. We are planning

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17184: [FLINK-24193][tests] Add ClassLoaderExtension

2021-09-08 Thread GitBox
ruanhang1993 commented on a change in pull request #17184: URL: https://github.com/apache/flink/pull/17184#discussion_r704099530 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/testutils/junit/extensions/ClassLoaderExtension.java ##

[jira] [Updated] (FLINK-24203) AbstractServerTest fails due to port conflict

2021-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24203: --- Labels: pull-request-available test-stability (was: test-stability) > AbstractServerTest

[jira] [Updated] (FLINK-24168) Rowtime type is not correct for windowTableFunction or OverAggregate follows after Match because the output type does not updated after input rowtime attribute changed f

2021-09-08 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timo Walther updated FLINK-24168: - Priority: Critical (was: Blocker) > Rowtime type is not correct for windowTableFunction or

[jira] [Commented] (FLINK-24168) Rowtime type is not correct for windowTableFunction or OverAggregate follows after Match because the output type does not updated after input rowtime attribute changed

2021-09-08 Thread Timo Walther (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411719#comment-17411719 ] Timo Walther commented on FLINK-24168: -- We don't need to block 1.14. This issue was present in 1.13

[GitHub] [flink] xmarker opened a new pull request #17193: [FLINK-24203][runtime][tests] Resolve AbstractServerTest fails due to port conflict

2021-09-08 Thread GitBox
xmarker opened a new pull request #17193: URL: https://github.com/apache/flink/pull/17193 ## What is the purpose of the change *This pull request for fix AbstractServerTest.testServerInitializationFailure falls due to port conflict* ## Brief change log *

[GitHub] [flink] flinkbot commented on pull request #17192: [FLINK-24195][doc]Translate "DESCRIBE Statements" page of "SQL" into …

2021-09-08 Thread GitBox
flinkbot commented on pull request #17192: URL: https://github.com/apache/flink/pull/17192#issuecomment-914959905 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24195) Translate "DESCRIBE Statements" page of "SQL" into Chinese

2021-09-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24195: --- Labels: pull-request-available (was: ) > Translate "DESCRIBE Statements" page of "SQL"

[GitHub] [flink] hapihu opened a new pull request #17192: [FLINK-24195][doc]Translate "DESCRIBE Statements" page of "SQL" into …

2021-09-08 Thread GitBox
hapihu opened a new pull request #17192: URL: https://github.com/apache/flink/pull/17192 Translate "DESCRIBE Statements" page of "SQL" into Chinese https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/table/sql/describe/

[GitHub] [flink] pnowojski commented on a change in pull request #17135: [FLINK-24098] Document FLIP-147 capabiliites and limitations

2021-09-08 Thread GitBox
pnowojski commented on a change in pull request #17135: URL: https://github.com/apache/flink/pull/17135#discussion_r704089770 ## File path: docs/content/docs/dev/datastream/fault-tolerance/checkpointing.md ## @@ -147,6 +154,11 @@

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-08 Thread GitBox
slinkydeveloper commented on a change in pull request #17186: URL: https://github.com/apache/flink/pull/17186#discussion_r704089572 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java ##

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-08 Thread GitBox
slinkydeveloper commented on a change in pull request #17186: URL: https://github.com/apache/flink/pull/17186#discussion_r704088995 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/SpecificInputTypeStrategies.java ##

[jira] [Commented] (FLINK-24182) Tasks canceler should not immediately interrupt

2021-09-08 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411718#comment-17411718 ] Piotr Nowojski commented on FLINK-24182: Yes. We would have to allow {{TaskInterrupter}} to

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-08 Thread GitBox
slinkydeveloper commented on a change in pull request #17186: URL: https://github.com/apache/flink/pull/17186#discussion_r704083943 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Expressions.java ## @@ -562,6 +563,43 @@ public static

[GitHub] [flink] PatrickRen commented on pull request #16940: [FLINK-23914][connector/testing-framework] Improve logging and error message in testing framework

2021-09-08 Thread GitBox
PatrickRen commented on pull request #16940: URL: https://github.com/apache/flink/pull/16940#issuecomment-914952450 Thanks @AHeise for the review! I made some refactor since your last review so you may want to review the PR again. I split changes into 4 commits: - 47e181c changes the

[GitHub] [flink] flinkbot edited a comment on pull request #17186: [FLINK-16203][table] Support JSON_OBJECT()

2021-09-08 Thread GitBox
flinkbot edited a comment on pull request #17186: URL: https://github.com/apache/flink/pull/17186#issuecomment-914384307 ## CI report: * 9a740a5445fc0dbf1799c5388525b58721da4a62 UNKNOWN * 0a44a1d73f9dec54cf272e7c0355654a3c0012fb Azure:

[GitHub] [flink] Myasuka commented on pull request #17151: [FLINK-23180] Do not initialize checkpoint base locations when checkp…

2021-09-08 Thread GitBox
Myasuka commented on pull request #17151: URL: https://github.com/apache/flink/pull/17151#issuecomment-914950626 @Jiayi-Liao , I think you still need add a test, and you can debug the `SavepointITCase#testTriggerSavepointWithCheckpointingDisabled()` to see whether your changes have been

[GitHub] [flink] flinkbot edited a comment on pull request #17155: [FLINK-19883][table] Support 'IF EXISTS' in DDL for ALTER TABLE

2021-09-08 Thread GitBox
flinkbot edited a comment on pull request #17155: URL: https://github.com/apache/flink/pull/17155#issuecomment-913385726 ## CI report: * 001d8c3dbc6d3344aa26baff0deebe3343c87318 UNKNOWN * 34424f3a53dcfd09dfaa0b0ecb30b86d3f3b75d3 Azure:

[jira] [Commented] (FLINK-24182) Tasks canceler should not immediately interrupt

2021-09-08 Thread Arvid Heise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17411711#comment-17411711 ] Arvid Heise commented on FLINK-24182: - I also saw another source of interrupts. Not too sure on this

[jira] [Assigned] (FLINK-24199) Expose StreamExecutionEnvironment#configure in Python API

2021-09-08 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-24199: --- Assignee: Nicholas Jiang > Expose StreamExecutionEnvironment#configure in Python API >

[GitHub] [flink] PatrickRen closed pull request #16488: [FLINK-21117][connector/kafka] Set checkpoint timeout to Long.MAX to reveal thread dump on CI if test get stuck

2021-09-08 Thread GitBox
PatrickRen closed pull request #16488: URL: https://github.com/apache/flink/pull/16488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] PatrickRen closed pull request #15943: [FLINK-20655][e2e] Add E2E test for new KafkaSource based on FLIP-27

2021-09-08 Thread GitBox
PatrickRen closed pull request #15943: URL: https://github.com/apache/flink/pull/15943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

<    1   2   3   4   5