[GitHub] [flink] flinkbot commented on pull request #17637: [FLINK-24708][planner] Fix wrong results of the IN operator

2021-11-02 Thread GitBox
flinkbot commented on pull request #17637: URL: https://github.com/apache/flink/pull/17637#issuecomment-957122792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] syhily commented on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-02 Thread GitBox
syhily commented on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957908355 I don't think this fixed the data loss issue. Pulsar internally wrap the CompletableFuture in `receiveAsync()` with a `CompletableFutureCancellationHandler`. The pending

[GitHub] [flink] AHeise commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
AHeise commented on a change in pull request #17580: URL: https://github.com/apache/flink/pull/17580#discussion_r741062579 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java ## @@ -279,6 +282,10 @@ public void start() throws

[GitHub] [flink] tillrohrmann commented on a change in pull request #14891: [FLINK-21289][deployment] FIX missing load pipeline.classpaths in app…

2021-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #14891: URL: https://github.com/apache/flink/pull/14891#discussion_r740955044 ## File path: flink-clients/src/main/java/org/apache/flink/client/program/DefaultPackagedProgramRetriever.java ## @@ -217,4 +221,13 @@ public

[GitHub] [flink] alisdlyc removed a comment on pull request #17639: [FLINK-24731] add a blank space

2021-11-02 Thread GitBox
alisdlyc removed a comment on pull request #17639: URL: https://github.com/apache/flink/pull/17639#issuecomment-957282820 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot commented on pull request #17644: [FLINK-24725] Update Cython to the latest version

2021-11-02 Thread GitBox
flinkbot commented on pull request #17644: URL: https://github.com/apache/flink/pull/17644#issuecomment-957523411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] MartijnVisser commented on pull request #17626: [FLINK-24715] Update multiple Jackson dependencies to latest version

2021-11-02 Thread GitBox
MartijnVisser commented on pull request #17626: URL: https://github.com/apache/flink/pull/17626#issuecomment-957480841 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-954752065 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] echauchot commented on pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-02 Thread GitBox
echauchot commented on pull request #17640: URL: https://github.com/apache/flink/pull/17640#issuecomment-957262094 R: @AHeise as discussed :slightly_smiling_face: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] flinkbot edited a comment on pull request #17642: [hotfix][table-common] Add `DataType#excludeFields`

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17642: URL: https://github.com/apache/flink/pull/17642#issuecomment-957339647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] CrynetLogistics commented on a change in pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
CrynetLogistics commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r740973594 ## File path: flink-connectors/flink-connector-aws/src/main/java/org/apache/flink/streaming/connectors/kinesis/unified/KinesisDataStreamsSink.java

[GitHub] [flink] flinkbot edited a comment on pull request #17646: [FLINK-24740] Update testcontainers dependency to the latest version

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17646: URL: https://github.com/apache/flink/pull/17646#issuecomment-957837700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17645: [FLINK-24667][runtime] Fix error handling in ChannelStateCheckpointWriter

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17645: URL: https://github.com/apache/flink/pull/17645#issuecomment-957822962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise commented on a change in pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

2021-11-02 Thread GitBox
AHeise commented on a change in pull request #17501: URL: https://github.com/apache/flink/pull/17501#discussion_r740847332 ## File path: flink-formats/flink-parquet/src/main/java/org/apache/flink/formats/parquet/avro/AvroParquetRecordFormat.java ## @@ -0,0 +1,189 @@ +/* + *

[GitHub] [flink] tsreaper commented on a change in pull request #17571: [FLINK-23015][table-runtime-blink] Implement streaming window Deduplicate operator

2021-11-02 Thread GitBox
tsreaper commented on a change in pull request #17571: URL: https://github.com/apache/flink/pull/17571#discussion_r740698131 ## File path:

[GitHub] [flink] flinkbot commented on pull request #17647: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot commented on pull request #17647: URL: https://github.com/apache/flink/pull/17647#issuecomment-957881822 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] ashulin commented on pull request #17634: [FLINK-24691][table-common] Fix precision for sum on decimal types

2021-11-02 Thread GitBox
ashulin commented on pull request #17634: URL: https://github.com/apache/flink/pull/17634#issuecomment-957140297 It looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] zentol merged pull request #17602: [FLINK-24699][build] Run scalastyle in validate phase

2021-11-02 Thread GitBox
zentol merged pull request #17602: URL: https://github.com/apache/flink/pull/17602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17639: [FLINK-24731] add a blank space

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17639: URL: https://github.com/apache/flink/pull/17639#issuecomment-957242723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot commented on pull request #17646: [FLINK-24740] Update testcontainers dependency to the latest version

2021-11-02 Thread GitBox
flinkbot commented on pull request #17646: URL: https://github.com/apache/flink/pull/17646#issuecomment-957835052 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] fapaul commented on pull request #17626: [FLINK-24715] Update multiple Jackson dependencies to latest version

2021-11-02 Thread GitBox
fapaul commented on pull request #17626: URL: https://github.com/apache/flink/pull/17626#issuecomment-957191317 Can you also check this failing test it might be that our elastic version does not play nice with this new Jackson version? -- This is an automated message from the Apache

[GitHub] [flink] flinkbot edited a comment on pull request #17624: [FLINK-24714][table-api-java] Validate partition keys for ResolvedCatalogTable

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17624: URL: https://github.com/apache/flink/pull/17624#issuecomment-956206702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] godfreyhe commented on pull request #17444: [FLINK-24492][table-planner]incorrect implicit type conversion between numeric and (var)char

2021-11-02 Thread GitBox
godfreyhe commented on pull request #17444: URL: https://github.com/apache/flink/pull/17444#issuecomment-957391630 @twalthr Thanks for driving this. I will pay more attention to the code quality of test cases. Currently, `select 1 = '1'` will generate wrong result, and all Flink (SQL)

[GitHub] [flink] fapaul commented on pull request #17583: [FLINK-24639][kinesis] Add UniformShardAssigner

2021-11-02 Thread GitBox
fapaul commented on pull request #17583: URL: https://github.com/apache/flink/pull/17583#issuecomment-957322519 @dannycranmer @CrynetLogistics can one of you take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] beyond1920 commented on a change in pull request #17571: [FLINK-23015][table-runtime-blink] Implement streaming window Deduplicate operator

2021-11-02 Thread GitBox
beyond1920 commented on a change in pull request #17571: URL: https://github.com/apache/flink/pull/17571#discussion_r740950486 ## File path:

[GitHub] [flink] flinkbot edited a comment on pull request #17632: [FLINK-23014][table-planner] Support streaming window Deduplicate in planner

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17632: URL: https://github.com/apache/flink/pull/17632#issuecomment-956326604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] akalash commented on pull request #17627: [FLINK-15550][runtime] Don't ignore the interruption for testCancelTa…

2021-11-02 Thread GitBox
akalash commented on pull request #17627: URL: https://github.com/apache/flink/pull/17627#issuecomment-957350370 As I can see tests are good, the one failed test is also present in main branch(https://issues.apache.org/jira/browse/FLINK-24734) -- This is an automated message from the

[GitHub] [flink] flinkbot edited a comment on pull request #17544: [FLINK-24165][table] Add infrastructure to support metadata for filesystem connector

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17544: URL: https://github.com/apache/flink/pull/17544#issuecomment-949353495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17644: [FLINK-24725] Update Cython to the latest version

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17644: URL: https://github.com/apache/flink/pull/17644#issuecomment-957525049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17637: [FLINK-24708][planner] Fix wrong results of the IN operator

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17637: URL: https://github.com/apache/flink/pull/17637#issuecomment-957122792 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] fapaul commented on a change in pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
fapaul commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r740884341 ## File path: flink-connectors/flink-connector-aws/src/main/java/org/apache/flink/streaming/connectors/kinesis/unified/KinesisDataStreamsSink.java ## @@

[GitHub] [flink] fapaul commented on pull request #17625: [FLINK-24719] Update Postgres test dependencies

2021-11-02 Thread GitBox
fapaul commented on pull request #17625: URL: https://github.com/apache/flink/pull/17625#issuecomment-957183965 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] tillrohrmann edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957663355 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot commented on pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-02 Thread GitBox
flinkbot commented on pull request #17640: URL: https://github.com/apache/flink/pull/17640#issuecomment-957264269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17624: [FLINK-24714][table-api-java] Validate partition keys for ResolvedCatalogTable

2021-11-02 Thread GitBox
slinkydeveloper commented on a change in pull request #17624: URL: https://github.com/apache/flink/pull/17624#discussion_r740795671 ## File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/CatalogManager.java ## @@ -874,7 +876,24 @@ public

[GitHub] [flink] tillrohrmann commented on a change in pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #17606: URL: https://github.com/apache/flink/pull/17606#discussion_r740889079 ## File path: flink-rpc/flink-rpc-akka/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaInvocationHandler.java ## @@ -240,17 +241,20 @@ private

[GitHub] [flink] zentol commented on pull request #17633: [FLINK-24723][archetype] Add ServicesResourceTransformer transformer

2021-11-02 Thread GitBox
zentol commented on pull request #17633: URL: https://github.com/apache/flink/pull/17633#issuecomment-957182630 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot edited a comment on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957416596 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17542: URL: https://github.com/apache/flink/pull/17542#issuecomment-949170131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] liming30 commented on pull request #17179: [FLINK-24086][checkpoint] Rebuilding the SharedStateRegistry only when the restore method is called for the first time.

2021-11-02 Thread GitBox
liming30 commented on pull request #17179: URL: https://github.com/apache/flink/pull/17179#issuecomment-957115416 Hi, @dawidwys, I checked the registration of the shared state again. Maybe the shared state in `CompletedCheckpointStore` only needs to be re-registered in the

[GitHub] [flink] flinkbot commented on pull request #17639: [FLINK-24731] add a blank space

2021-11-02 Thread GitBox
flinkbot commented on pull request #17639: URL: https://github.com/apache/flink/pull/17639#issuecomment-957242407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] hililiwei commented on pull request #17613: [FLINK-24536][Table SQL/Planner] flink sql support bang equal '!='

2021-11-02 Thread GitBox
hililiwei commented on pull request #17613: URL: https://github.com/apache/flink/pull/17613#issuecomment-957839301 @MartijnVisser added two test case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] xuyangzhong commented on a change in pull request #17632: [FLINK-23014][table-planner] Support streaming window Deduplicate in planner

2021-11-02 Thread GitBox
xuyangzhong commented on a change in pull request #17632: URL: https://github.com/apache/flink/pull/17632#discussion_r740708151 ## File path:

[GitHub] [flink] curcur merged pull request #17620: [FLINK-24671][runtime] Return 0 buffers in use until subpartition vie…

2021-11-02 Thread GitBox
curcur merged pull request #17620: URL: https://github.com/apache/flink/pull/17620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17641: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-02 Thread GitBox
flinkbot commented on pull request #17641: URL: https://github.com/apache/flink/pull/17641#issuecomment-957270143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #16962: URL: https://github.com/apache/flink/pull/16962#issuecomment-904541061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] Aitozi commented on pull request #17428: [hotfix]Refactor the registerJobManager to registerJobMaster

2021-11-02 Thread GitBox
Aitozi commented on pull request #17428: URL: https://github.com/apache/flink/pull/17428#issuecomment-957485338 Could you also help review this minor refactor, thanks @tillrohrmann -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] tillrohrmann commented on a change in pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…

2021-11-02 Thread GitBox
tillrohrmann commented on a change in pull request #17426: URL: https://github.com/apache/flink/pull/17426#discussion_r740964619 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/heartbeat/HeartbeatReceiver.java ## @@ -0,0 +1,40 @@ +/* + * Licensed to the

[GitHub] [flink] dannycranmer commented on a change in pull request #17345: [FLINK-24227][connectors] Added Kinesis Data Streams Sink i…

2021-11-02 Thread GitBox
dannycranmer commented on a change in pull request #17345: URL: https://github.com/apache/flink/pull/17345#discussion_r741246342 ## File path: flink-connectors/flink-connector-aws/pom.xml ## @@ -0,0 +1,130 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] akalash commented on a change in pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
akalash commented on a change in pull request #17541: URL: https://github.com/apache/flink/pull/17541#discussion_r739087076 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] [flink] pnowojski merged pull request #17629: [FLINK-15550][runtime] Don't ignore the interruption for testCancelTa…

2021-11-02 Thread GitBox
pnowojski merged pull request #17629: URL: https://github.com/apache/flink/pull/17629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17648: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot commented on pull request #17648: URL: https://github.com/apache/flink/pull/17648#issuecomment-957889509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] AHeise commented on pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

2021-11-02 Thread GitBox
AHeise commented on pull request #17501: URL: https://github.com/apache/flink/pull/17501#issuecomment-957254354 > > > > @echauchot > > > > > Sure, I saw the comments about split and data types etc... But I feel unconfortable about draft PRs because they usually cannot be merged as is.

[GitHub] [flink] meetjunsu removed a comment on pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-11-02 Thread GitBox
meetjunsu removed a comment on pull request #17542: URL: https://github.com/apache/flink/pull/17542#issuecomment-956078481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] flinkbot edited a comment on pull request #17630: [hotfix][javadocs] Improve JavaDocs of SupportsAggregatePushDown

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17630: URL: https://github.com/apache/flink/pull/17630#issuecomment-956266960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
zentol commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957180521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] iyupeng commented on pull request #17630: [hotfix][javadocs] Improve JavaDocs of SupportsAggregatePushDown

2021-11-02 Thread GitBox
iyupeng commented on pull request #17630: URL: https://github.com/apache/flink/pull/17630#issuecomment-957109574 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] zentol edited a comment on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
zentol edited a comment on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957620163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17641: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17641: URL: https://github.com/apache/flink/pull/17641#issuecomment-957270143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-benchmarks] dawidwys commented on pull request #40: [FLINK-24732] Remove scala suffix from respective benchmarks dependencies

2021-11-02 Thread GitBox
dawidwys commented on pull request #40: URL: https://github.com/apache/flink-benchmarks/pull/40#issuecomment-957252066 duplicate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #17642: [hotfix][table-common] Add `DataType#excludeFields`

2021-11-02 Thread GitBox
flinkbot commented on pull request #17642: URL: https://github.com/apache/flink/pull/17642#issuecomment-957339647 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on a change in pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
zentol commented on a change in pull request #17606: URL: https://github.com/apache/flink/pull/17606#discussion_r740932666 ## File path: flink-tests/src/test/java/org/apache/flink/test/recovery/TaskManagerProcessFailureBatchRecoveryITCase.java ## @@ -67,7 +67,7 @@ public void

[GitHub] [flink] dawidwys commented on pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
dawidwys commented on pull request #17541: URL: https://github.com/apache/flink/pull/17541#issuecomment-957321556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] alisdlyc commented on pull request #17639: [FLINK-24731] add a blank space

2021-11-02 Thread GitBox
alisdlyc commented on pull request #17639: URL: https://github.com/apache/flink/pull/17639#issuecomment-957282820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] fapaul commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
fapaul commented on a change in pull request #17580: URL: https://github.com/apache/flink/pull/17580#discussion_r741067353 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java ## @@ -279,6 +282,10 @@ public void start() throws

[GitHub] [flink] tillrohrmann closed pull request #17428: [hotfix]Refactor the registerJobManager to registerJobMaster

2021-11-02 Thread GitBox
tillrohrmann closed pull request #17428: URL: https://github.com/apache/flink/pull/17428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] fapaul commented on a change in pull request #17626: [FLINK-24715] Update multiple Jackson dependencies to latest version

2021-11-02 Thread GitBox
fapaul commented on a change in pull request #17626: URL: https://github.com/apache/flink/pull/17626#discussion_r740798571 ## File path: flink-table/flink-table-planner/pom.xml ## @@ -356,6 +356,7 @@ under the License.

[GitHub] [flink] flinkbot edited a comment on pull request #17647: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17647: URL: https://github.com/apache/flink/pull/17647#issuecomment-957882505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] pnowojski merged pull request #17627: [FLINK-15550][runtime] Don't ignore the interruption for testCancelTa…

2021-11-02 Thread GitBox
pnowojski merged pull request #17627: URL: https://github.com/apache/flink/pull/17627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17648: [FLINK-20443][API/DataStream] ContinuousProcessingTimeTrigger doesn't fire at the end of the window

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17648: URL: https://github.com/apache/flink/pull/17648#issuecomment-957889509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-benchmarks] dawidwys closed pull request #40: [FLINK-24732] Remove scala suffix from respective benchmarks dependencies

2021-11-02 Thread GitBox
dawidwys closed pull request #40: URL: https://github.com/apache/flink-benchmarks/pull/40 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17607: [FLINK-24543][runtime] Avoid possible inconsistencies of ZookeeperSta…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17607: URL: https://github.com/apache/flink/pull/17607#issuecomment-954762085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] GOODBOY008 commented on pull request #17622: [FLINK-24407][doc-zh]Pulsar connector chinese document link to Pulsar document location incorrectly.

2021-11-02 Thread GitBox
GOODBOY008 commented on pull request #17622: URL: https://github.com/apache/flink/pull/17622#issuecomment-957187711 @wuchong Please cc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] meetjunsu commented on pull request #17542: [FLINK-17782] Add array,map,row types support for parquet row writer

2021-11-02 Thread GitBox
meetjunsu commented on pull request #17542: URL: https://github.com/apache/flink/pull/17542#issuecomment-957024848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] sjwiesman closed pull request #17633: [FLINK-24723][archetype] Add ServicesResourceTransformer transformer

2021-11-02 Thread GitBox
sjwiesman closed pull request #17633: URL: https://github.com/apache/flink/pull/17633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-02 Thread GitBox
flinkbot commented on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957412578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17638: [FLINK-24728][table-runtime] Close output stream in batch SQL file sink

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17638: URL: https://github.com/apache/flink/pull/17638#issuecomment-957219037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] mayuehappy commented on pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-11-02 Thread GitBox
mayuehappy commented on pull request #17525: URL: https://github.com/apache/flink/pull/17525#issuecomment-957040774 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] AHeise commented on a change in pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-02 Thread GitBox
AHeise commented on a change in pull request #17538: URL: https://github.com/apache/flink/pull/17538#discussion_r740484286 ## File path: flink-connectors/flink-connector-elasticsearch-base/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/table/IndexGeneratorTest.java

[GitHub] [flink] echauchot commented on pull request #17641: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-02 Thread GitBox
echauchot commented on pull request #17641: URL: https://github.com/apache/flink/pull/17641#issuecomment-957268928 R: @AHeise as discussed slightly_smiling_face -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] flinkbot edited a comment on pull request #17640: [FLINK-21407][doc][formats] Add formats to DataStream connectors doc

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17640: URL: https://github.com/apache/flink/pull/17640#issuecomment-957264269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] tillrohrmann commented on pull request #17606: [FLINK-24706][rpc] Forward deserialization errors to returned future

2021-11-02 Thread GitBox
tillrohrmann commented on pull request #17606: URL: https://github.com/apache/flink/pull/17606#issuecomment-957309354 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] dawidwys commented on a change in pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
dawidwys commented on a change in pull request #17541: URL: https://github.com/apache/flink/pull/17541#discussion_r741117079 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/TimeToConsumeGauge.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to

[GitHub] [flink] flinkbot commented on pull request #17638: [FLINK-24728][table-runtime] Close output stream in batch SQL file sink

2021-11-02 Thread GitBox
flinkbot commented on pull request #17638: URL: https://github.com/apache/flink/pull/17638#issuecomment-957219037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] beyond1920 commented on a change in pull request #17632: [FLINK-23014][table-planner] Support streaming window Deduplicate in planner

2021-11-02 Thread GitBox
beyond1920 commented on a change in pull request #17632: URL: https://github.com/apache/flink/pull/17632#discussion_r740955153 ## File path: flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalWindowDeduplicate.scala

[GitHub] [flink] flinkbot edited a comment on pull request #17509: [FLINK-24501][table-runtime] Stores window progress into state in order to check whether an input element is late or not for window-t

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17509: URL: https://github.com/apache/flink/pull/17509#issuecomment-945571594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17580: URL: https://github.com/apache/flink/pull/17580#issuecomment-952991532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol merged pull request #17631: [FLINK-24720][tests] Remove flink-runtime-web dependency

2021-11-02 Thread GitBox
zentol merged pull request #17631: URL: https://github.com/apache/flink/pull/17631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] AHeise commented on pull request #17538: [FLINK-24325][connectors/elasticsearch] Create Elasticsearch 6 Sink

2021-11-02 Thread GitBox
AHeise commented on pull request #17538: URL: https://github.com/apache/flink/pull/17538#issuecomment-957933362 Btw it's hard to see if all comments of @fapaul have been addressed. Please always respond to feedback, so it's easier to follow what has been improved already. I use  reaction

[GitHub] [flink] MartijnVisser commented on a change in pull request #17626: [FLINK-24715] Update multiple Jackson dependencies to latest version

2021-11-02 Thread GitBox
MartijnVisser commented on a change in pull request #17626: URL: https://github.com/apache/flink/pull/17626#discussion_r741022824 ## File path: flink-table/flink-table-planner/pom.xml ## @@ -356,6 +356,7 @@ under the License.

[GitHub] [flink] flinkbot edited a comment on pull request #17426: [FLINK-24167][Runtime]Add default HeartbeatReceiver and HeartbeatSend…

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17426: URL: https://github.com/apache/flink/pull/17426#issuecomment-938516939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17626: [FLINK-24715] Update multiple Jackson dependencies to latest version

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17626: URL: https://github.com/apache/flink/pull/17626#issuecomment-956209711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] zentol commented on a change in pull request #17580: [FLINK-11470][runtime] Pass configurations to filesystems when executing in LocalStreamEnvironment

2021-11-02 Thread GitBox
zentol commented on a change in pull request #17580: URL: https://github.com/apache/flink/pull/17580#discussion_r741004140 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java ## @@ -279,6 +282,10 @@ public void start() throws

[GitHub] [flink] syhily edited a comment on pull request #17643: [FLINK-24733][connector/pulsar] Data loss in pulsar source when using shared mode

2021-11-02 Thread GitBox
syhily edited a comment on pull request #17643: URL: https://github.com/apache/flink/pull/17643#issuecomment-957908355 I don't think this fixed the data loss issue. Pulsar [internally

[GitHub] [flink] flinkbot edited a comment on pull request #17501: [Draft][FLINK-21406][RecordFormat] build AvroParquetRecordFormat for the new FileSource

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17501: URL: https://github.com/apache/flink/pull/17501#issuecomment-944297212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17525: [FLINK-24597][state] fix the problem that RocksStateKeysAndNamespaceIterator would return duplicate data

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17525: URL: https://github.com/apache/flink/pull/17525#issuecomment-947380227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-web] sjwiesman commented on a change in pull request #478: add Flink Backward blog post

2021-11-02 Thread GitBox
sjwiesman commented on a change in pull request #478: URL: https://github.com/apache/flink-web/pull/478#discussion_r740478608 ## File path: _posts/2021-11-03-flink-backward.md ## @@ -0,0 +1,79 @@ +--- +layout: post +title: "Flink Backward - The Apache Flink Retrospective"

[GitHub] [flink] flinkbot edited a comment on pull request #17541: [FLINK-24189] Perform buffer debloating per single gate

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17541: URL: https://github.com/apache/flink/pull/17541#issuecomment-948765818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17625: [FLINK-24719] Update Postgres test dependencies

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17625: URL: https://github.com/apache/flink/pull/17625#issuecomment-956206829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #17634: [FLINK-24691][table-common] Fix precision for sum on decimal types

2021-11-02 Thread GitBox
flinkbot edited a comment on pull request #17634: URL: https://github.com/apache/flink/pull/17634#issuecomment-956440201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

<    1   2   3   4   5   6   7   8   >