[GitHub] [flink] zjureel opened a new pull request #18303: [FLINK-25085][runtime] Add a scheduled thread pool for periodic tasks in RpcEndpoint

2022-01-08 Thread GitBox
zjureel opened a new pull request #18303: URL: https://github.com/apache/flink/pull/18303 ## What is the purpose of the change This PR adds a scheduled thread pool which will used to hold the periodic tasks and send them to akka with gateway when they should be executed. The thread

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] RocMarshal commented on a change in pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2022-01-08 Thread GitBox
RocMarshal commented on a change in pull request #16962: URL: https://github.com/apache/flink/pull/16962#discussion_r780672989 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/mysql/MySQLTypeMapper.java ## @@ -0,0

[GitHub] [flink] RocMarshal commented on a change in pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2022-01-08 Thread GitBox
RocMarshal commented on a change in pull request #16962: URL: https://github.com/apache/flink/pull/16962#discussion_r780672989 ## File path: flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/dialect/mysql/MySQLTypeMapper.java ## @@ -0,0

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] RocMarshal commented on a change in pull request #16962: [FLINK-15352][connector-jdbc] Develop MySQLCatalog to connect Flink with MySQL tables and ecosystem.

2022-01-08 Thread GitBox
RocMarshal commented on a change in pull request #16962: URL: https://github.com/apache/flink/pull/16962#discussion_r780672647 ## File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/catalog/MySQLCatalogITCase.java ## @@ -0,0 +1,337

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink-benchmarks] Aitozi commented on pull request #41: [FLINK-24918][Runtime/State Backends]Support to specify the data dir for state benchmark

2022-01-08 Thread GitBox
Aitozi commented on pull request #41: URL: https://github.com/apache/flink-benchmarks/pull/41#issuecomment-1007996637 @pnowojski Sorry for the late response, I have done the work to add support for a dedicated config file. Please take a look when you are free. I have check the ci

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * a77fc0cfacabdf3e72de818510350e144d55501c Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * c56b607fcc8f53cad38621478de6d43abf445f52 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18294: FLINK-25565 Read Parquet INT64 timestamp

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18294: URL: https://github.com/apache/flink/pull/18294#issuecomment-1007294314 ## CI report: * c56b607fcc8f53cad38621478de6d43abf445f52 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * d9f475a81c4df915a3ca1d943c885bdd296182cb Azure:

[jira] [Commented] (FLINK-25307) Resuming Savepoint (hashmap, async, no parallelism change) end-to-end test timeout on azure

2022-01-08 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17471119#comment-17471119 ] Yun Gao commented on FLINK-25307: - The PR is added on master: 8b62a6267569bb417db21b75d5e6482341fea665

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] gaoyunhaii closed pull request #18298: [FLINK-25307][Test] Print the curl logs is querying dispatcher startup failed

2022-01-08 Thread GitBox
gaoyunhaii closed pull request #18298: URL: https://github.com/apache/flink/pull/18298 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17936: [FLINK-24954][network] Reset read buffer request timeout on buffer recycling for sort-shuffle

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #17936: URL: https://github.com/apache/flink/pull/17936#issuecomment-980533423 ## CI report: * 52333d291058310d84b19cef804268a59c2a4da9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18220: URL: https://github.com/apache/flink/pull/18220#issuecomment-1001978981 ## CI report: * 9398f91265e32754bb7f4159855024353c036b01 Azure:

[jira] [Updated] (FLINK-16080) Translate "Table API & SQL" pages into Chinese

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-16080: --- Labels: auto-unassigned pull-request-available stale-major (was: auto-unassigned

[jira] [Updated] (FLINK-24457) FileSourceTextLinesITCase.testContinuousTextFileSourceWithJobManagerFailover fails with NoSuchElement

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-24457: --- Labels: stale-major test-stability (was: test-stability) I am the [Flink Jira

[jira] [Updated] (FLINK-5086) Clean dead snapshot files produced by the tasks failing to acknowledge checkpoints

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5086: -- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-5094) Support RichReduceFunction and RichFoldFunction as incremental window aggregation functions

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5094: -- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-5078) Introduce annotations for classes copied from Calcite

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5078: -- Labels: auto-deprioritized-major auto-deprioritized-minor auto-unassigned (was:

[jira] [Updated] (FLINK-5089) Introduce Loop functions and Enforce Nesting on Data Streams

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5089: -- Labels: auto-deprioritized-major auto-deprioritized-minor auto-unassigned (was:

[jira] [Updated] (FLINK-18894) StateFun job stalls on stop-with-savepoint

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-18894: --- Labels: auto-deprioritized-critical auto-deprioritized-major auto-unassigned stale-minor

[jira] [Updated] (FLINK-5062) Ensure that all created threads have a proper name

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5062: -- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-22785) Kafka transaction failing when there are two producers

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-22785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-22785: --- Labels: auto-deprioritized-major stale-minor (was: auto-deprioritized-major) I am the

[jira] [Updated] (FLINK-24750) Single quotes converted to left/right single quotes during docs generation

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-24750: --- Labels: pull-request-available stale-major (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-5065) Resource leaks in case of lost checkpoint messages

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5065: -- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-5105) Improve ReduceState: value put into ReducingState should always be a copy

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5105: -- Labels: auto-deprioritized-major auto-deprioritized-minor auto-unassigned (was:

[jira] [Updated] (FLINK-5121) Integrate YARN application ID with web interface

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5121: -- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-5120) Show TM PID in web frontend

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5120: -- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[jira] [Updated] (FLINK-5092) Add integration with Sonarqube and code coverage

2022-01-08 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-5092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-5092: -- Labels: auto-deprioritized-major auto-deprioritized-minor (was: auto-deprioritized-major

[GitHub] [flink] flinkbot edited a comment on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18296: URL: https://github.com/apache/flink/pull/18296#issuecomment-1007312371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] afedulov commented on pull request #17598: [FLINK-24703][connectors][formats] Add CSV format support for filesystem based on StreamFormat and BulkWriter interfaces.

2022-01-08 Thread GitBox
afedulov commented on pull request #17598: URL: https://github.com/apache/flink/pull/17598#issuecomment-1007555875 @fapaul I addressed all of the comments. The only remaining open points from my perspective: - clarify if imposing a strict `Serializable` requirement on the

[GitHub] [flink] Myasuka merged pull request #18276: [FLINK-25536] Adjust the order of variable declaration and…

2022-01-08 Thread GitBox
Myasuka merged pull request #18276: URL: https://github.com/apache/flink/pull/18276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18283: [FLINK-25390][table] Add API to support merging options from catalog table

2022-01-08 Thread GitBox
slinkydeveloper commented on a change in pull request #18283: URL: https://github.com/apache/flink/pull/18283#discussion_r780295708 ## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/FactoryUtil.java ## @@ -1035,8 +1124,62 @@ private

[GitHub] [flink] cuibo01 commented on pull request #18279: FLINK-25535 The JVM parameter does not take effect

2022-01-08 Thread GitBox
cuibo01 commented on pull request #18279: URL: https://github.com/apache/flink/pull/18279#issuecomment-1007267850 > Thanks for creating this PR @cuibo01. I think the fix itself is good. I am wondering whether it actually fixes a problem. Did you observe a problem with splitting `-D

[GitHub] [flink] dmvk commented on pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-08 Thread GitBox
dmvk commented on pull request #18189: URL: https://github.com/apache/flink/pull/18189#issuecomment-1007482147 It would be executed in the same thread that has called the complete method (which belongs to the pool). Passing the executor directly allows for picking another thread from

[GitHub] [flink] XComp commented on a change in pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters

2022-01-08 Thread GitBox
XComp commented on a change in pull request #17819: URL: https://github.com/apache/flink/pull/17819#discussion_r780084427 ## File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesLabel.java ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache

[GitHub] [flink] Chromico commented on pull request #18300: Update H2 to 2.0.206 to address CVE-2021-42392.

2022-01-08 Thread GitBox
Chromico commented on pull request #18300: URL: https://github.com/apache/flink/pull/18300#issuecomment-1007489335 Done :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] slinkydeveloper edited a comment on pull request #18287: [FLINK-17321][table] Add support casting of map to map and multiset to multiset

2022-01-08 Thread GitBox
slinkydeveloper edited a comment on pull request #18287: URL: https://github.com/apache/flink/pull/18287#issuecomment-1007282991 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] fapaul commented on pull request #18105: [FLINK-25266][e2e] Convert StreamingKafkaITCase to SmokeKafkaITCase covering application packaging

2022-01-08 Thread GitBox
fapaul commented on pull request #18105: URL: https://github.com/apache/flink/pull/18105#issuecomment-1007428110 @JingGe thanks for your review can you take another look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot edited a comment on pull request #18288: [FLINK-20188][Connectors][Docs][FileSystem] Added documentation for File Source

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18288: URL: https://github.com/apache/flink/pull/18288#issuecomment-1006578426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] dmvk commented on pull request #18296: [FLINK-25486][Runtime/Coordination] Fix the bug that flink will lost state when zookeeper leader changes

2022-01-08 Thread GitBox
dmvk commented on pull request #18296: URL: https://github.com/apache/flink/pull/18296#issuecomment-1007388314 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] MartijnVisser commented on pull request #18285: [FLINK-21407][docs][formats] Move MongoDb to formats section in release 1.14

2022-01-08 Thread GitBox
MartijnVisser commented on pull request #18285: URL: https://github.com/apache/flink/pull/18285#issuecomment-1007473477 @fapaul Previous PRs added MongoDb as a format for DataStream. However, it was added under Connectors, not under Connectors > Formats. This PR moves the documentation to

[GitHub] [flink] gaoyunhaii commented on pull request #18302: [FLINK-25569][core] Add decomposed Sink V2 interface

2022-01-08 Thread GitBox
gaoyunhaii commented on pull request #18302: URL: https://github.com/apache/flink/pull/18302#issuecomment-1007585748 Very thanks @fapaul for drafting the PR! I'll also have a look soon~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] TJX2014 closed pull request #18273: [FLINK-25311][core] Deal with compressed file

2022-01-08 Thread GitBox
TJX2014 closed pull request #18273: URL: https://github.com/apache/flink/pull/18273 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] cuibo01 closed pull request #18279: FLINK-25535 The JVM parameter does not take effect

2022-01-08 Thread GitBox
cuibo01 closed pull request #18279: URL: https://github.com/apache/flink/pull/18279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #17676: [FLINK-14100][connectors] Add Oracle dialect

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #17676: URL: https://github.com/apache/flink/pull/17676#issuecomment-960641444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] MartijnVisser commented on pull request #13918: [FLINK-19943][table-planner-blink]add parallelism config of elasticsearch dynamitic table sink

2022-01-08 Thread GitBox
MartijnVisser commented on pull request #13918: URL: https://github.com/apache/flink/pull/13918#issuecomment-1007197535 This PR is superseded by https://github.com/apache/flink/pull/18033 @fapaul Can you close this one? -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] flinkbot edited a comment on pull request #17819: [FLINK-15816][k8s] Limit kubernetes.cluster-id to a maximum of 40 characters

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #17819: URL: https://github.com/apache/flink/pull/17819#issuecomment-971446182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18291: [FLINK-25227][table-runtime] Boxed numeric type should be considered when generating code for equality checking

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18291: URL: https://github.com/apache/flink/pull/18291#issuecomment-1007087098 ## CI report: * 83604f544f5ff5e5d8b1857313fee595c32ce37a Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18298: [FLINK-25307][Test] Print the curl logs is querying dispatcher startup failed

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18298: URL: https://github.com/apache/flink/pull/18298#issuecomment-1007324030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] XComp commented on a change in pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-08 Thread GitBox
XComp commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r780310849 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java ## @@ -868,6 +867,14 @@ private void

[GitHub] [flink] fapaul merged pull request #18125: [FLINK-25210][pulsar][e2e][tests] add resource file to test jar

2022-01-08 Thread GitBox
fapaul merged pull request #18125: URL: https://github.com/apache/flink/pull/18125 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] slinkydeveloper commented on pull request #18283: [FLINK-25390][table] Add API to support merging options from catalog table

2022-01-08 Thread GitBox
slinkydeveloper commented on pull request #18283: URL: https://github.com/apache/flink/pull/18283#issuecomment-1007478134 @twalthr all the comments have been addressed in the last commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot edited a comment on pull request #18295: [hotfix][rpc] Use AtomicLong#getAndIncrement to simplify increment number

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18295: URL: https://github.com/apache/flink/pull/18295#issuecomment-1007309008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zuston commented on pull request #18276: [FLINK-25536] Adjust the order of variable declaration and…

2022-01-08 Thread GitBox
zuston commented on pull request #18276: URL: https://github.com/apache/flink/pull/18276#issuecomment-1007354466 Thanks @Myasuka -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] echauchot commented on pull request #18285: [FLINK-21407][docs][formats] Move MongoDb to formats section in release 1.14

2022-01-08 Thread GitBox
echauchot commented on pull request #18285: URL: https://github.com/apache/flink/pull/18285#issuecomment-1007475056 @fapaul sorry, the discussion was left in the [ticket](https://issues.apache.org/jira/browse/FLINK-21407). The aim of the PR is to fix a doc issue where `MongoDb` was

[GitHub] [flink] flinkbot edited a comment on pull request #18274: [FLINK-25230][table-planner] Harden type serialization for LogicalType and DataType

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18274: URL: https://github.com/apache/flink/pull/18274#issuecomment-1005845834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] zuston commented on a change in pull request #18220: [FLINK-25410] Flink CLI should exit when app is accepted with detach …

2022-01-08 Thread GitBox
zuston commented on a change in pull request #18220: URL: https://github.com/apache/flink/pull/18220#discussion_r780222160 ## File path: flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterClientFactory.java ## @@ -87,6 +87,6 @@ private YarnClusterDescriptor

[GitHub] [flink] flinkbot edited a comment on pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18189: URL: https://github.com/apache/flink/pull/18189#issuecomment-1000280224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] fapaul commented on a change in pull request #18201: [FLINK-25167][API / DataStream]Expose StreamOperatorFactory in Connec…

2022-01-08 Thread GitBox
fapaul commented on a change in pull request #18201: URL: https://github.com/apache/flink/pull/18201#discussion_r780186335 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/TwoInputStreamOperatorFactory.java ## @@ -0,0 +1,31 @@ +/* + *

[GitHub] [flink] flinkbot commented on pull request #18297: [FLINK-25395][state] Don't discard shared state on TM

2022-01-08 Thread GitBox
flinkbot commented on pull request #18297: URL: https://github.com/apache/flink/pull/18297#issuecomment-1007315437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] dmvk commented on a change in pull request #18189: [FLINK-25430] Replace RunningJobRegistry by JobResultStore

2022-01-08 Thread GitBox
dmvk commented on a change in pull request #18189: URL: https://github.com/apache/flink/pull/18189#discussion_r780210722 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/ApplicationStatus.java ## @@ -59,20 +72,25 @@ public int

[GitHub] [flink] flinkbot edited a comment on pull request #18153: [FLINK-25568][connectors/elasticsearch] Add Elasticsearch 7 Source

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18153: URL: https://github.com/apache/flink/pull/18153#issuecomment-997756404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink-web] gaoyunhaii commented on pull request #493: Add flink-ml 2.0.0

2022-01-08 Thread GitBox
gaoyunhaii commented on pull request #493: URL: https://github.com/apache/flink-web/pull/493#issuecomment-1007213447 @lindong28 I added the translation~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] slinkydeveloper commented on a change in pull request #17598: [FLINK-24703][connectors][formats] Add CSV format support for filesystem based on StreamFormat and BulkWriter interfaces.

2022-01-08 Thread GitBox
slinkydeveloper commented on a change in pull request #17598: URL: https://github.com/apache/flink/pull/17598#discussion_r780071456 ## File path: flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/TableCsvFormatITCase.java ## @@ -0,0 +1,204 @@ +/* + * Licensed

[GitHub] [flink] fapaul merged pull request #18281: [FLINK-25519][Connectors] Promote StreamExecutionEnvironment#fromSour…

2022-01-08 Thread GitBox
fapaul merged pull request #18281: URL: https://github.com/apache/flink/pull/18281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] MartijnVisser commented on pull request #18301: [FLINK-25576][Connectors][JDBC] Upgrade com.h2database:h2 to 2.0.206

2022-01-08 Thread GitBox
MartijnVisser commented on pull request #18301: URL: https://github.com/apache/flink/pull/18301#issuecomment-1007628177 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot edited a comment on pull request #18253: FLINK-24900

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18253: URL: https://github.com/apache/flink/pull/18253#issuecomment-1003855117 ## CI report: * bf6b56b1cd6591e7b3fad6fddd3f701a06c64868 Azure:

[GitHub] [flink] deadwind4 edited a comment on pull request #18300: Update H2 to 2.0.206 to address CVE-2021-42392.

2022-01-08 Thread GitBox
deadwind4 edited a comment on pull request #18300: URL: https://github.com/apache/flink/pull/18300#issuecomment-1007421253 https://github.com/apache/flink/pull/18301 duplicated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] deadwind4 commented on a change in pull request #18033: [FLINK-25141][connector/elasticsearch][docs] Add sink parallelism option

2022-01-08 Thread GitBox
deadwind4 commented on a change in pull request #18033: URL: https://github.com/apache/flink/pull/18033#discussion_r780231023 ## File path:

[GitHub] [flink] flinkbot edited a comment on pull request #18105: [FLINK-25266][e2e] Convert StreamingKafkaITCase to SmokeKafkaITCase covering application packaging

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18105: URL: https://github.com/apache/flink/pull/18105#issuecomment-993417620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] MartijnVisser commented on pull request #18282: [FLINK-25553][filesystem][mapr] Remove MapR filesystem

2022-01-08 Thread GitBox
MartijnVisser commented on pull request #18282: URL: https://github.com/apache/flink/pull/18282#issuecomment-1007260528 > I still found a mention in flink-python/pyflink/datastream/stream_execution_environment:303 There are also some in the Kafka Connector but I am unsure if it is safe to

[GitHub] [flink] flinkbot edited a comment on pull request #18283: [FLINK-25390][table] Add API to support merging options from catalog table

2022-01-08 Thread GitBox
flinkbot edited a comment on pull request #18283: URL: https://github.com/apache/flink/pull/18283#issuecomment-1006442061 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

<    1   2   3   >