[GitHub] [flink] flinkbot edited a comment on pull request #18415: Atlas changes

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18415: URL: https://github.com/apache/flink/pull/18415#issuecomment-1017200363 ## CI report: * b6b983201168ccd9a5c4c019094562867855d1fb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18413: URL: https://github.com/apache/flink/pull/18413#issuecomment-1017179392 ## CI report: * 9d960019b5f391580eb36849b8a42d45721c517a Azure:

[GitHub] [flink] Airblader commented on a change in pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
Airblader commented on a change in pull request #18413: URL: https://github.com/apache/flink/pull/18413#discussion_r788463913 ## File path: flink-runtime-web/web-dashboard/src/app/share/customize/job-badge/job-badge.component.spec.ts ## @@ -22,10 +22,8 @@ import {

[GitHub] [flink] flinkbot edited a comment on pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18413: URL: https://github.com/apache/flink/pull/18413#issuecomment-1017179392 ## CI report: * 9d960019b5f391580eb36849b8a42d45721c517a Azure:

[jira] [Commented] (FLINK-11838) Create RecoverableWriter for GCS

2022-01-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479153#comment-17479153 ] Martijn Visser commented on FLINK-11838: Thanks for taking of this [~galenwarren]  We should

[GitHub] [flink] flinkbot edited a comment on pull request #18415: Atlas changes

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18415: URL: https://github.com/apache/flink/pull/18415#issuecomment-1017200363 ## CI report: * b6b983201168ccd9a5c4c019094562867855d1fb Azure:

[GitHub] [flink] dawidwys commented on pull request #18405: [FLINK-25683][streaming-java] wrong result if table transfrom to Data…

2022-01-19 Thread GitBox
dawidwys commented on pull request #18405: URL: https://github.com/apache/flink/pull/18405#issuecomment-1017202257 @paul8263 I investigated it a bit further and I posted a comment in JIRA. Could you please take a look there? -- This is an automated message from the Apache Git Service.

[jira] [Commented] (FLINK-25683) wrong result if table transfrom to DataStream then window process in batch mode

2022-01-19 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479152#comment-17479152 ] Dawid Wysakowicz commented on FLINK-25683: -- Sorry, I have not spotted that before. Actually, I

[GitHub] [flink] flinkbot commented on pull request #18415: Atlas changes

2022-01-19 Thread GitBox
flinkbot commented on pull request #18415: URL: https://github.com/apache/flink/pull/18415#issuecomment-1017200363 ## CI report: * b6b983201168ccd9a5c4c019094562867855d1fb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18137: URL: https://github.com/apache/flink/pull/18137#issuecomment-996615034 ## CI report: * 66280958ba0046cbef940e575fc61a4ec6d62253 Azure:

[GitHub] [flink] yangjunhan commented on a change in pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
yangjunhan commented on a change in pull request #18413: URL: https://github.com/apache/flink/pull/18413#discussion_r788451618 ## File path: flink-runtime-web/web-dashboard/src/app/share/customize/job-badge/job-badge.component.spec.ts ## @@ -22,10 +22,8 @@ import {

[GitHub] [flink] flinkbot commented on pull request #18415: Atlas changes

2022-01-19 Thread GitBox
flinkbot commented on pull request #18415: URL: https://github.com/apache/flink/pull/18415#issuecomment-1017198785 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18137: URL: https://github.com/apache/flink/pull/18137#issuecomment-996615034 ## CI report: * 66280958ba0046cbef940e575fc61a4ec6d62253 Azure:

[GitHub] [flink] Jesuitry opened a new pull request #18415: Atlas changes

2022-01-19 Thread GitBox
Jesuitry opened a new pull request #18415: URL: https://github.com/apache/flink/pull/18415 If Flink 1.10 is used, this JobListener is not used after it is created, so the Hook does not take effect. It can take effect after adding the following code. JobListener listener =

[GitHub] [flink] PatrickRen commented on pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-19 Thread GitBox
PatrickRen commented on pull request #18137: URL: https://github.com/apache/flink/pull/18137#issuecomment-1017194128 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] PatrickRen commented on pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-19 Thread GitBox
PatrickRen commented on pull request #18137: URL: https://github.com/apache/flink/pull/18137#issuecomment-1017193996 Thanks for the reminder @leonardBang ! I made some force pushes and the CI has been green in my own pipeline. I will trigger another CI run via flinkbot. -- This is an

[GitHub] [flink] flinkbot edited a comment on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1009752905 ## CI report: * d07846bf2cc1c1925b7cacc1f9d7f186ba58b0e0 Azure:

[jira] [Closed] (FLINK-25660) Failed to build flink-runtime-web

2022-01-19 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi closed FLINK-25660. -- Resolution: Not A Bug > Failed to build flink-runtime-web > - > >

[GitHub] [flink] Airblader commented on a change in pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
Airblader commented on a change in pull request #18413: URL: https://github.com/apache/flink/pull/18413#discussion_r788439553 ## File path: flink-runtime-web/web-dashboard/src/app/share/customize/job-badge/job-badge.component.spec.ts ## @@ -22,10 +22,8 @@ import {

[jira] [Commented] (FLINK-25660) Failed to build flink-runtime-web

2022-01-19 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479140#comment-17479140 ] Aitozi commented on FLINK-25660: [~guoyangze] , [~junhany] Thanks for your guidance, I have addressed

[GitHub] [flink] dawidwys commented on a change in pull request #18405: [FLINK-25683][streaming-java] wrong result if table transfrom to Data…

2022-01-19 Thread GitBox
dawidwys commented on a change in pull request #18405: URL: https://github.com/apache/flink/pull/18405#discussion_r788440766 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java ## @@ -323,7 +323,9 @@ protected

[jira] [Commented] (FLINK-25200) Implement duplicating for s3 filesystem

2022-01-19 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479139#comment-17479139 ] Yun Tang commented on FLINK-25200: -- [~akalashnikov] I think we should run tests to mock the condition

[GitHub] [flink] flinkbot edited a comment on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1009752905 ## CI report: * ce08a46add96553021558f2af3ecebc74a93e4e4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18137: URL: https://github.com/apache/flink/pull/18137#issuecomment-996615034 ## CI report: * 66280958ba0046cbef940e575fc61a4ec6d62253 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1009752905 ## CI report: * ce08a46add96553021558f2af3ecebc74a93e4e4 Azure:

[jira] [Comment Edited] (FLINK-24163) PartiallyFinishedSourcesITCase fails due to timeout

2022-01-19 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479115#comment-17479115 ] Yun Gao edited comment on FLINK-24163 at 1/20/22, 7:22 AM: --- Thanks [~roman] 

[GitHub] [flink] paul8263 commented on a change in pull request #18405: [FLINK-25683][streaming-java] wrong result if table transfrom to Data…

2022-01-19 Thread GitBox
paul8263 commented on a change in pull request #18405: URL: https://github.com/apache/flink/pull/18405#discussion_r788434023 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java ## @@ -323,7 +323,9 @@ protected

[GitHub] [flink] gaoyunhaii closed pull request #18403: [FLINK-24163][tests] Reduce key space in PartiallyFinishedSourcesITCase

2022-01-19 Thread GitBox
gaoyunhaii closed pull request #18403: URL: https://github.com/apache/flink/pull/18403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-19 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r788432483 ## File path: flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18414: URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067 ## CI report: * 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18405: [FLINK-25683][streaming-java] wrong result if table transfrom to Data…

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18405: URL: https://github.com/apache/flink/pull/18405#issuecomment-1017071379 ## CI report: * 6229193f6adeedd62e7d5f0dcee9e6098e49ed9e Azure:

[GitHub] [flink] simenliuxing commented on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception

2022-01-19 Thread GitBox
simenliuxing commented on pull request #18414: URL: https://github.com/apache/flink/pull/18414#issuecomment-1017183560 @wenlong88 hello, can you help me review the code -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] yangjunhan commented on pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
yangjunhan commented on pull request #18413: URL: https://github.com/apache/flink/pull/18413#issuecomment-1017183214 I have to explicitly add `@ant-design/icons-angular` as a dependency for `flink-runtime-web` even thought it is a dependency for NG-ZORRO. When I ran `npm install`

[GitHub] [flink] flinkbot commented on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception

2022-01-19 Thread GitBox
flinkbot commented on pull request #18414: URL: https://github.com/apache/flink/pull/18414#issuecomment-1017182067 ## CI report: * 3c3aedefda07bea1b5cf7223b4f0305f469d9e15 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18413: URL: https://github.com/apache/flink/pull/18413#issuecomment-1017179392 ## CI report: * 9d960019b5f391580eb36849b8a42d45721c517a Azure:

[GitHub] [flink] Zakelly commented on pull request #18402: [FLINK-25678][runtime] Make TaskExecutorStateChangelogStoragesManager.shutdown thread-safe

2022-01-19 Thread GitBox
Zakelly commented on pull request #18402: URL: https://github.com/apache/flink/pull/18402#issuecomment-1017181880 Thanks for the PR! Overall it looks good to me. Would you mind removing the "No thread-safe" from the java doc of this class? Thanks. -- This is an automated message from

[jira] [Commented] (FLINK-25700) flinksql Cascading Window TVF Aggregation exception

2022-01-19 Thread simenliuxing (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479129#comment-17479129 ] simenliuxing commented on FLINK-25700: -- [~wenlong.lwl]  Thank you for your reply, I have fixed this

[GitHub] [flink] flinkbot commented on pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception

2022-01-19 Thread GitBox
flinkbot commented on pull request #18414: URL: https://github.com/apache/flink/pull/18414#issuecomment-1017180731 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
flinkbot commented on pull request #18413: URL: https://github.com/apache/flink/pull/18413#issuecomment-1017179392 ## CI report: * 9d960019b5f391580eb36849b8a42d45721c517a UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
flinkbot commented on pull request #18413: URL: https://github.com/apache/flink/pull/18413#issuecomment-1017179083 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] simenliuxing opened a new pull request #18414: [hotfix][docs]fix flink sql Cascading Window TVF Aggregation exception

2022-01-19 Thread GitBox
simenliuxing opened a new pull request #18414: URL: https://github.com/apache/flink/pull/18414 ## What is the purpose of the change Aliases need to be used under Cascading Window Aggregation, otherwise an error will be reported, but there is no such thing in the documentation, so I

[jira] [Updated] (FLINK-24768) Upgrade Web Frontend to Angular v13 and NG-Zorro v13

2022-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24768: --- Labels: pull-request-available (was: ) > Upgrade Web Frontend to Angular v13 and NG-Zorro

[GitHub] [flink] yangjunhan opened a new pull request #18413: [FLINK-24768][runtime-web] upgrade Angular and NG-ZORRO versions to 13

2022-01-19 Thread GitBox
yangjunhan opened a new pull request #18413: URL: https://github.com/apache/flink/pull/18413 ## What is the purpose of the change Upgrade Flink Runtime Web's dependencies Angular and NG-ZORRO versions to 13. Close

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-19 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r788418063 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/StateObject.java ## @@ -63,4 +63,14 @@ * @return Size of the state in

[GitHub] [flink] Myasuka commented on a change in pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-19 Thread GitBox
Myasuka commented on a change in pull request #18324: URL: https://github.com/apache/flink/pull/18324#discussion_r788417725 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/IncrementalRemoteKeyedStateHandle.java ## @@ -204,6 +203,21 @@ public long

[GitHub] [flink-ml] lindong28 edited a comment on pull request #54: [FLINK-25552] Add Estimator and Transformer for MinMaxScaler in FlinkML

2022-01-19 Thread GitBox
lindong28 edited a comment on pull request #54: URL: https://github.com/apache/flink-ml/pull/54#issuecomment-1017123834 Thanks for the PR. Before we continue to add more and more algorithm, what's our plan to make sure these algorithm's implementation could meet our performance

[GitHub] [flink-ml] lindong28 edited a comment on pull request #56: [FLINK-25616] Add Transformer for VectorAssembler in FlinkML

2022-01-19 Thread GitBox
lindong28 edited a comment on pull request #56: URL: https://github.com/apache/flink-ml/pull/56#issuecomment-1017123440 Thanks for the PR. Before we continue to add more and more algorithm, what's our plan to make sure these algorithm's implementation could meet our performance

[GitHub] [flink] dawidwys commented on a change in pull request #18405: [FLINK-25683][streaming-java] wrong result if table transfrom to Data…

2022-01-19 Thread GitBox
dawidwys commented on a change in pull request #18405: URL: https://github.com/apache/flink/pull/18405#discussion_r788410349 ## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java ## @@ -323,7 +323,9 @@ protected

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17994: [FLINK-24456][Connectors / Kafka,Table SQL / Ecosystem] Support bound…

2022-01-19 Thread GitBox
ruanhang1993 commented on a change in pull request #17994: URL: https://github.com/apache/flink/pull/17994#discussion_r788393552 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptions.java ##

[GitHub] [flink] ruanhang1993 commented on a change in pull request #17994: [FLINK-24456][Connectors / Kafka,Table SQL / Ecosystem] Support bound…

2022-01-19 Thread GitBox
ruanhang1993 commented on a change in pull request #17994: URL: https://github.com/apache/flink/pull/17994#discussion_r788383759 ## File path: flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/streaming/connectors/kafka/table/KafkaConnectorOptions.java ##

[jira] [Commented] (FLINK-18356) Exit code 137 returned from process

2022-01-19 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479121#comment-17479121 ] Dawid Wysakowicz commented on FLINK-18356: -- [~trohrmann] No, we have not merged any changes to

[jira] [Assigned] (FLINK-15455) Enable TCP connection reuse across multiple jobs.

2022-01-19 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo reassigned FLINK-15455: -- Assignee: Yangze Guo > Enable TCP connection reuse across multiple jobs. >

[GitHub] [flink] flinkbot edited a comment on pull request #18388: [FLINK-25530][python][connector/pulsar] Support Pulsar source connector in Python DataStream API.

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18388: URL: https://github.com/apache/flink/pull/18388#issuecomment-1015205179 ## CI report: * 669c93d03ad065091bd30bbd9d3032244ee075df Azure:

[jira] [Commented] (FLINK-24163) PartiallyFinishedSourcesITCase fails due to timeout

2022-01-19 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479115#comment-17479115 ] Yun Gao commented on FLINK-24163: - Thanks [~roman]  for the PR! I'll have a look~ >

[GitHub] [flink] flinkbot edited a comment on pull request #18404: [FLINK-25681][table-planner] Remove failure test in CodeSplitITCase to avoid deep exception stack

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18404: URL: https://github.com/apache/flink/pull/18404#issuecomment-1017066728 ## CI report: * 511330acce13b111458ea01a6182ab2749d1d1a6 Azure:

[GitHub] [flink] chen-yu342 edited a comment on pull request #8400: [FLINK-12472][yarn] Support setting attemptFailuresValidityInterval o…

2022-01-19 Thread GitBox
chen-yu342 edited a comment on pull request #8400: URL: https://github.com/apache/flink/pull/8400#issuecomment-1017157122 > @zhengyifanvp

[GitHub] [flink] chen-yu342 edited a comment on pull request #8400: [FLINK-12472][yarn] Support setting attemptFailuresValidityInterval o…

2022-01-19 Thread GitBox
chen-yu342 edited a comment on pull request #8400: URL: https://github.com/apache/flink/pull/8400#issuecomment-1017157122 > @zhengyifanvp

[GitHub] [flink] LadyForest commented on a change in pull request #18394: [FLINK-25520][Table SQL/API] Implement "ALTER TABLE ... COMPACT" SQL

2022-01-19 Thread GitBox
LadyForest commented on a change in pull request #18394: URL: https://github.com/apache/flink/pull/18394#discussion_r788392600 ## File path: flink-table/flink-table-common/src/test/java/org/apache/flink/table/connector/source/TestManagedTableSource.java ## @@ -0,0 +1,69 @@

[GitHub] [flink-ml] weibozhao commented on pull request #56: [FLINK-25616] Add Transformer for VectorAssembler in FlinkML

2022-01-19 Thread GitBox
weibozhao commented on pull request #56: URL: https://github.com/apache/flink-ml/pull/56#issuecomment-1017159409 I get your idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] ZhangChaoming commented on pull request #18386: [FLINK-25684][table] Support enhanced `show databases` syntax

2022-01-19 Thread GitBox
ZhangChaoming commented on pull request #18386: URL: https://github.com/apache/flink/pull/18386#issuecomment-1017159215 @wuchong Hi, Could you please help give a review ? Thanks very much ! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] chen-yu342 edited a comment on pull request #8400: [FLINK-12472][yarn] Support setting attemptFailuresValidityInterval o…

2022-01-19 Thread GitBox
chen-yu342 edited a comment on pull request #8400: URL: https://github.com/apache/flink/pull/8400#issuecomment-1017157122 > @zhengyifanvp

[GitHub] [flink] chen-yu342 edited a comment on pull request #8400: [FLINK-12472][yarn] Support setting attemptFailuresValidityInterval o…

2022-01-19 Thread GitBox
chen-yu342 edited a comment on pull request #8400: URL: https://github.com/apache/flink/pull/8400#issuecomment-1017157122 > @zhengyifanvp

[GitHub] [flink] wenlong88 commented on pull request #18331: [FLINK-25614][table/runtime] Let LocalWindowAggregate be chained with upstream

2022-01-19 Thread GitBox
wenlong88 commented on pull request #18331: URL: https://github.com/apache/flink/pull/18331#issuecomment-1017157780 @lmagic233 could you help create another issue to track fix of other operators. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] chen-yu342 commented on pull request #8400: [FLINK-12472][yarn] Support setting attemptFailuresValidityInterval o…

2022-01-19 Thread GitBox
chen-yu342 commented on pull request #8400: URL: https://github.com/apache/flink/pull/8400#issuecomment-1017157122 > @zhengyifanvp

[GitHub] [flink] flinkbot edited a comment on pull request #18137: [FLINK-25287][connector-testing-framework] Refactor interfaces of connector testing framework to support more scenarios

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18137: URL: https://github.com/apache/flink/pull/18137#issuecomment-996615034 ## CI report: * a51d94fece908d30c5295d2046b8e19807972dcb Azure:

[jira] [Commented] (FLINK-25700) flinksql Cascading Window TVF Aggregation exception

2022-01-19 Thread Wenlong Lyu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17479110#comment-17479110 ] Wenlong Lyu commented on FLINK-25700: - [~simen] it is not a bug actually, you should rename

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788380094 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/manifest/ManifestEntry.java ## @@ -38,6 +38,7 @@

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788377304 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreCommitImpl.java ## @@ -0,0 +1,376 @@

[jira] [Assigned] (FLINK-21789) Make FileChannelManagerImpl#getNextPathNum select data directories fairly

2022-01-19 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao reassigned FLINK-21789: --- Assignee: Yuxin Tan > Make FileChannelManagerImpl#getNextPathNum select data directories

[GitHub] [flink] LadyForest commented on a change in pull request #18394: [FLINK-25520][Table SQL/API] Implement "ALTER TABLE ... COMPACT" SQL

2022-01-19 Thread GitBox
LadyForest commented on a change in pull request #18394: URL: https://github.com/apache/flink/pull/18394#discussion_r788376320 ## File path: flink-table/flink-table-planner/src/test/resources/META-INF/services/org.apache.flink.table.factories.Factory ## @@ -13,8 +13,8 @@ #

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788375580 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/Snapshot.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the

[jira] [Assigned] (FLINK-21790) Shuffle data directories to make directory selection of different TaskManagers fairer

2022-01-19 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21790?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yingjie Cao reassigned FLINK-21790: --- Assignee: Yuxin Tan > Shuffle data directories to make directory selection of different >

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788375174 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/Snapshot.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the

[GitHub] [flink-table-store] JingsongLi commented on a change in pull request #12: [FLINK-25689] Introduce atomic commit

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #12: URL: https://github.com/apache/flink-table-store/pull/12#discussion_r788374933 ## File path: flink-table-store-core/src/main/java/org/apache/flink/table/store/file/Snapshot.java ## @@ -0,0 +1,132 @@ +/* + * Licensed to the

[GitHub] [flink] flinkbot edited a comment on pull request #18412: [FLINK-25696][datastream] Introduce MetadataPublisher interface to SinkWriter

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18412: URL: https://github.com/apache/flink/pull/18412#issuecomment-1017147201 ## CI report: * 91a7a1406e7d09b6914bff1caeaf4ec92a798d8d Azure:

[GitHub] [flink] LadyForest commented on a change in pull request #18394: [FLINK-25520][Table SQL/API] Implement "ALTER TABLE ... COMPACT" SQL

2022-01-19 Thread GitBox
LadyForest commented on a change in pull request #18394: URL: https://github.com/apache/flink/pull/18394#discussion_r788373476 ## File path: flink-formats/flink-orc/pom.xml ## @@ -145,6 +145,19 @@ under the License. test test-jar

[GitHub] [flink] flinkbot commented on pull request #18412: [FLINK-25696][datastream] Introduce MetadataPublisher interface to SinkWriter

2022-01-19 Thread GitBox
flinkbot commented on pull request #18412: URL: https://github.com/apache/flink/pull/18412#issuecomment-1017147201 ## CI report: * 91a7a1406e7d09b6914bff1caeaf4ec92a798d8d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18412: [FLINK-25696][datastream] Introduce MetadataPublisher interface to SinkWriter

2022-01-19 Thread GitBox
flinkbot commented on pull request #18412: URL: https://github.com/apache/flink/pull/18412#issuecomment-1017146317 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Closed] (FLINK-25184) Introduce setDeliveryCallback to KafkaWriter

2022-01-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-25184. Resolution: Duplicate > Introduce setDeliveryCallback to KafkaWriter >

[jira] [Updated] (FLINK-25696) Introduce MetadataPublisher interface to SinkWriter

2022-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25696: --- Labels: pull-request-available (was: ) > Introduce MetadataPublisher interface to

[GitHub] [flink] JingsongLi opened a new pull request #18412: [FLINK-25696][datastream] Introduce MetadataPublisher interface to SinkWriter

2022-01-19 Thread GitBox
JingsongLi opened a new pull request #18412: URL: https://github.com/apache/flink/pull/18412 ## What is the purpose of the change In Table Store, we want to get the offsets of kafka writer, only the offset returned by the callback inside the KafkaWriter is accurate, so we need this

[jira] [Updated] (FLINK-25696) Introduce MetadataPublisher interface to SinkWriter

2022-01-19 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee updated FLINK-25696: - Component/s: Connectors / Kafka > Introduce MetadataPublisher interface to SinkWriter >

[GitHub] [flink] flinkbot edited a comment on pull request #18411: [FLINK-23944][test][pulsar] 1. change the Matcher to validate both size and data 2. pulsar IT test generate deterministic data

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18411: URL: https://github.com/apache/flink/pull/18411#issuecomment-1017137635 ## CI report: * b4fc1c8ab69a6bfaec27d5044d1aef7c1453b2ac Azure:

[GitHub] [flink] flinkbot commented on pull request #18411: [FLINK-23944][test][pulsar] 1. change the Matcher to validate both size and data 2. pulsar IT test generate deterministic data

2022-01-19 Thread GitBox
flinkbot commented on pull request #18411: URL: https://github.com/apache/flink/pull/18411#issuecomment-1017137635 ## CI report: * b4fc1c8ab69a6bfaec27d5044d1aef7c1453b2ac UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18410: introduce file_uid for part file description

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18410: URL: https://github.com/apache/flink/pull/18410#issuecomment-1017135994 ## CI report: * f93c8b81862c1b744c3599c706a482186e541ae9 Azure:

[GitHub] [flink] flinkbot commented on pull request #18411: [FLINK-23944][test][pulsar] 1. change the Matcher to validate both size and data 2. pulsar IT test generate deterministic data

2022-01-19 Thread GitBox
flinkbot commented on pull request #18411: URL: https://github.com/apache/flink/pull/18411#issuecomment-1017137392 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18410: introduce file_uid for part file description

2022-01-19 Thread GitBox
flinkbot commented on pull request #18410: URL: https://github.com/apache/flink/pull/18410#issuecomment-1017135994 ## CI report: * f93c8b81862c1b744c3599c706a482186e541ae9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] imaffe opened a new pull request #18411: [FLINK-23944][test][pulsar] 1. change the Matcher to validate both size and data 2. pulsar IT test generate deterministic data

2022-01-19 Thread GitBox
imaffe opened a new pull request #18411: URL: https://github.com/apache/flink/pull/18411 ## What is the purpose of the change 1. change the pulsar IT to generate fixed test data 2. change the TestDataMatcher to validate both size and data. ## Brief change log

[GitHub] [flink] flinkbot commented on pull request #18410: introduce file_uid for part file description

2022-01-19 Thread GitBox
flinkbot commented on pull request #18410: URL: https://github.com/apache/flink/pull/18410#issuecomment-1017135283 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot edited a comment on pull request #18409: [hotfix][dist] Fix that flink-gs-fs-hadoop not included in flink-dist

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18409: URL: https://github.com/apache/flink/pull/18409#issuecomment-1017132626 ## CI report: * 6243757360488011ac597bf09956ee48fd2fa826 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18408: [FLINK-24865][cep] Support MATCH_RECOGNIZE in Batch mode

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18408: URL: https://github.com/apache/flink/pull/18408#issuecomment-1017132556 ## CI report: * 98deafafc7a332577c3172844e38b98c445be6b9 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1009752905 ## CI report: * ce08a46add96553021558f2af3ecebc74a93e4e4 Azure:

[GitHub] [flink] EugeneChung opened a new pull request #18410: introduce file_uid for part file description

2022-01-19 Thread GitBox
EugeneChung opened a new pull request #18410: URL: https://github.com/apache/flink/pull/18410 ## What is the purpose of the change To clarify description about the part file name ## Brief change log introduce file_uid for in-progress files ## Verifying this change

[GitHub] [flink] JingsongLi commented on a change in pull request #18394: [FLINK-25520][Table SQL/API] Implement "ALTER TABLE ... COMPACT" SQL

2022-01-19 Thread GitBox
JingsongLi commented on a change in pull request #18394: URL: https://github.com/apache/flink/pull/18394#discussion_r788360886 ## File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/utils/TableTestBase.scala ## @@ -701,6 +701,23 @@

[GitHub] [flink] flinkbot commented on pull request #18409: [hotfix][dist] Fix that flink-gs-fs-hadoop not included in flink-dist

2022-01-19 Thread GitBox
flinkbot commented on pull request #18409: URL: https://github.com/apache/flink/pull/18409#issuecomment-1017133076 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[GitHub] [flink] flinkbot commented on pull request #18409: [hotfix][dist] Fix that flink-gs-fs-hadoop not included in flink-dist

2022-01-19 Thread GitBox
flinkbot commented on pull request #18409: URL: https://github.com/apache/flink/pull/18409#issuecomment-1017132626 ## CI report: * 6243757360488011ac597bf09956ee48fd2fa826 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot commented on pull request #18408: [FLINK-24865][cep] Support MATCH_RECOGNIZE in Batch mode

2022-01-19 Thread GitBox
flinkbot commented on pull request #18408: URL: https://github.com/apache/flink/pull/18408#issuecomment-1017132556 ## CI report: * 98deafafc7a332577c3172844e38b98c445be6b9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot

[GitHub] [flink] flinkbot edited a comment on pull request #18324: [FLINK-25557][checkpoint] Introduce incremental/full checkpoint size stats

2022-01-19 Thread GitBox
flinkbot edited a comment on pull request #18324: URL: https://github.com/apache/flink/pull/18324#issuecomment-1009752905 ## CI report: * ce08a46add96553021558f2af3ecebc74a93e4e4 Azure:

[GitHub] [flink] flinkbot commented on pull request #18408: [FLINK-24865][cep] Support MATCH_RECOGNIZE in Batch mode

2022-01-19 Thread GitBox
flinkbot commented on pull request #18408: URL: https://github.com/apache/flink/pull/18408#issuecomment-1017131827 Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community to review your pull request. We will use this comment to track the

[jira] [Updated] (FLINK-24865) Support MATCH_RECOGNIZE in Batch mode

2022-01-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24865: --- Labels: pull-request-available (was: ) > Support MATCH_RECOGNIZE in Batch mode >

  1   2   3   4   5   6   >