[GitHub] [flink] flinkbot edited a comment on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885710999 ## CI report: * Unknown: [CANCELED](TBD) * 82860fda96c0e0d5931be169f1e664ec61349564 Azure:

[GitHub] [flink-benchmarks] pnowojski commented on a change in pull request #49: [FLINK-25959] Add micro-benchmarks for the sort-based blocking shuffle

2022-02-10 Thread GitBox
pnowojski commented on a change in pull request #49: URL: https://github.com/apache/flink-benchmarks/pull/49#discussion_r803619263 ## File path: src/main/java/org/apache/flink/benchmark/BlockingPartitionRemoteChannelBenchmark.java ## @@ -49,7 +49,15 @@ public static void

[GitHub] [flink] rmetzger edited a comment on pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
rmetzger edited a comment on pull request #18692: URL: https://github.com/apache/flink/pull/18692#issuecomment-1034859586 Sadly, the JRS still doesn't work on K8s, using a minio s3 implementation: ``` 2022-02-10 12:20:23,679 INFO

[GitHub] [flink] rmetzger commented on pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
rmetzger commented on pull request #18692: URL: https://github.com/apache/flink/pull/18692#issuecomment-1034859586 Sadly, the JRS still doesn't work on K8s, using a minio s3 implementation: ``` 2022-02-10 12:20:23,679 INFO

[GitHub] [flink] flinkbot edited a comment on pull request #18702: [FLINK-24441][source] Block SourceOperator when watermarks are out of alignment

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18702: URL: https://github.com/apache/flink/pull/18702#issuecomment-1034842544 ## CI report: * 1c798c2c84e8285f7a7784038583a194bc42b3ea Azure:

[GitHub] [flink] gaborgsomogyi commented on pull request #18664: [FLINK-25907][runtime][security] Add pluggable delegation token manager

2022-02-10 Thread GitBox
gaborgsomogyi commented on pull request #18664: URL: https://github.com/apache/flink/pull/18664#issuecomment-1034857628 Oh gosh, resolving the conflict... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] flinkbot edited a comment on pull request #18698: [FLINK-25782] [docs] Translate datastream filesystem.md page into Chinese.

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18698: URL: https://github.com/apache/flink/pull/18698#issuecomment-1034521527 ## CI report: * 146bd830e84ad8c2a521f2edf5e32741d7aa45b5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18697: [FLINK-26034][Build System]Add maven wrapper for flink

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18697: URL: https://github.com/apache/flink/pull/18697#issuecomment-1034510296 ## CI report: * 34a2b1811fd7bc75e2c1e9c8462ab9573d506559 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18689: [FLINK-21439][runtime] Exception history adaptive scheduler

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18689: URL: https://github.com/apache/flink/pull/18689#issuecomment-1033918208 ## CI report: * 45c9c7931377fa16988a1a25985c028907047274 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18688: [FLINK-26060][table-planner] Remove persisted plan feature support for Python UDFs

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18688: URL: https://github.com/apache/flink/pull/18688#issuecomment-1033917965 ## CI report: * f2aeb29764801267d7cb8463724464e49774ee28 Azure:

[jira] [Closed] (FLINK-26035) Rework loader-bundle into separate module

2022-02-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-26035. Resolution: Fixed master: c0ce5506758605b1acff9e6931f7e7df0e519a09 > Rework

[GitHub] [flink] zentol merged pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module

2022-02-10 Thread GitBox
zentol merged pull request #18676: URL: https://github.com/apache/flink/pull/18676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot edited a comment on pull request #18670: [FLINK-25999] Deprecate Per-Job Mode

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18670: URL: https://github.com/apache/flink/pull/18670#issuecomment-1033075650 ## CI report: * 360c74aff2caa70284a90375a17519dc4843d4b2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18664: [FLINK-25907][runtime][security] Add pluggable delegation token manager

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18664: URL: https://github.com/apache/flink/pull/18664#issuecomment-1032585099 ## CI report: * e882713639b8f7541793d802c52d8c354ddf9ea2 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18649: [FLINK-25844][table-api-java] Introduce StatementSet#compilePlan

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18649: URL: https://github.com/apache/flink/pull/18649#issuecomment-1031570072 ## CI report: * 7abbdf54df75a8e9e0041e908ab61d785d800410 Azure:

[jira] [Comment Edited] (FLINK-26051) one sql has row_number =1 and the subsequent SQL has "case when" and "where" statement result Exception : The window can only be ordered in ASCENDING mode

2022-02-10 Thread zhangbin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490165#comment-17490165 ] zhangbin edited comment on FLINK-26051 at 2/10/22, 12:17 PM: - Using the

[GitHub] [flink] flinkbot edited a comment on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885710999 ## CI report: * Unknown: [CANCELED](TBD) * 82860fda96c0e0d5931be169f1e664ec61349564 Azure:

[GitHub] [flink] gaborgsomogyi commented on a change in pull request #18664: [FLINK-25907][runtime][security] Add pluggable delegation token manager

2022-02-10 Thread GitBox
gaborgsomogyi commented on a change in pull request #18664: URL: https://github.com/apache/flink/pull/18664#discussion_r803614366 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DelegationTokenManager.java ## @@ -0,0 +1,119 @@ +/* + *

[GitHub] [flink] gaborgsomogyi commented on a change in pull request #18664: [FLINK-25907][runtime][security] Add pluggable delegation token manager

2022-02-10 Thread GitBox
gaborgsomogyi commented on a change in pull request #18664: URL: https://github.com/apache/flink/pull/18664#discussion_r803613786 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/security/token/DelegationTokenManager.java ## @@ -0,0 +1,119 @@ +/* + *

[GitHub] [flink] gaborgsomogyi commented on a change in pull request #18664: [FLINK-25907][runtime][security] Add pluggable delegation token manager

2022-02-10 Thread GitBox
gaborgsomogyi commented on a change in pull request #18664: URL: https://github.com/apache/flink/pull/18664#discussion_r803613571 ## File path: flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java ## @@ -205,6 +212,14 @@ public

[jira] [Commented] (FLINK-26051) one sql has row_number =1 and the subsequent SQL has "case when" and "where" statement result Exception : The window can only be ordered in ASCENDING mode

2022-02-10 Thread zhangbinzaifendou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490165#comment-17490165 ] zhangbinzaifendou commented on FLINK-26051: --- Using the Flink1.12.2 test on the idea, the debug

[jira] [Commented] (FLINK-26046) Link to OpenAPI specification is dead

2022-02-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490166#comment-17490166 ] Chesnay Schepler commented on FLINK-26046: -- Meh, still didn't work because of a missing slash.

[jira] [Closed] (FLINK-26065) org.apache.flink.table.api.PlanReference$ContentPlanReference $FilePlanReference $ResourcePlanReference violation the api rules

2022-02-10 Thread Francesco Guardiani (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Guardiani closed FLINK-26065. --- Resolution: Fixed > org.apache.flink.table.api.PlanReference$ContentPlanReference

[jira] [Commented] (FLINK-26065) org.apache.flink.table.api.PlanReference$ContentPlanReference $FilePlanReference $ResourcePlanReference violation the api rules

2022-02-10 Thread Francesco Guardiani (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490164#comment-17490164 ] Francesco Guardiani commented on FLINK-26065: - Fixed by

[jira] [Updated] (FLINK-26051) one sql has row_number =1 and the subsequent SQL has "case when" and "where" statement result Exception : The window can only be ordered in ASCENDING mode

2022-02-10 Thread zhangbinzaifendou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhangbinzaifendou updated FLINK-26051: -- Attachment: image-2022-02-10-20-13-14-424.png > one sql has row_number =1 and the

[GitHub] [flink] flinkbot edited a comment on pull request #18702: [FLINK-24441][source] Block SourceOperator when watermarks are out of alignment

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18702: URL: https://github.com/apache/flink/pull/18702#issuecomment-1034842544 ## CI report: * 1c798c2c84e8285f7a7784038583a194bc42b3ea UNKNOWN Bot commands The @flinkbot bot supports the following commands: -

[GitHub] [flink] flinkbot edited a comment on pull request #18697: [FLINK-26034][Build System]Add maven wrapper for flink

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18697: URL: https://github.com/apache/flink/pull/18697#issuecomment-1034510296 ## CI report: * 34a2b1811fd7bc75e2c1e9c8462ab9573d506559 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18653: [FLINK-25825][connector-jdbc] MySqlCatalogITCase fails on azure

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18653: URL: https://github.com/apache/flink/pull/18653#issuecomment-1032212433 ## CI report: * 9261ad675d1c9e6f0ea94df829f94f25f18bafc4 Azure:

[GitHub] [flink] adiaixin commented on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2022-02-10 Thread GitBox
adiaixin commented on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-1034848279 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] afedulov commented on a change in pull request #18153: [FLINK-25568][connectors/elasticsearch] Add Elasticsearch 7 Source

2022-02-10 Thread GitBox
afedulov commented on a change in pull request #18153: URL: https://github.com/apache/flink/pull/18153#discussion_r803608850 ## File path: flink-connectors/flink-connector-elasticsearch-base/src/main/java/org/apache/flink/connector/elasticsearch/common/ElasticsearchUtil.java

[GitHub] [flink] flinkbot edited a comment on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885710999 ## CI report: * Unknown: [CANCELED](TBD) * 82860fda96c0e0d5931be169f1e664ec61349564 Azure:

[GitHub] [flink] XComp commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
XComp commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r803608001 ## File path: flink-filesystems/flink-s3-fs-presto/pom.xml ## @@ -46,6 +46,36 @@ under the License. provided +

[GitHub] [flink] MrWhiteSike commented on a change in pull request #17943: [FLINK-24693][docs-zh] Translate "checkpoints" and "checkpointing" page to Chinese

2022-02-10 Thread GitBox
MrWhiteSike commented on a change in pull request #17943: URL: https://github.com/apache/flink/pull/17943#discussion_r803606329 ## File path: docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md ## @@ -43,34 +43,40 @@ Flink 的 checkpoint 机制会和持久化存储进行交互,读写流与状

[jira] [Commented] (FLINK-25962) Flink generated Avro schemas can't be parsed using Python

2022-02-10 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490162#comment-17490162 ] Ryan Skraba commented on FLINK-25962: - I forgot to ask whether this could be assigned to me; the PR

[GitHub] [flink] zentol commented on a change in pull request #18678: [FLINK-24474] Default rest.bind-address to localhost in flink-conf.yaml

2022-02-10 Thread GitBox
zentol commented on a change in pull request #18678: URL: https://github.com/apache/flink/pull/18678#discussion_r803605847 ## File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh ## @@ -225,4 +225,9 @@ function get_host_machine_address { fi } +function

[GitHub] [flink] slinkydeveloper commented on a change in pull request #18653: [FLINK-25825][connector-jdbc] MySqlCatalogITCase fails on azure

2022-02-10 Thread GitBox
slinkydeveloper commented on a change in pull request #18653: URL: https://github.com/apache/flink/pull/18653#discussion_r803604728 ## File path: flink-connectors/flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/UnsignedTypeConversionITCase.java ## @@

[GitHub] [flink] RocMarshal commented on pull request #18653: [FLINK-25825][connector-jdbc] MySqlCatalogITCase fails on azure

2022-02-10 Thread GitBox
RocMarshal commented on pull request #18653: URL: https://github.com/apache/flink/pull/18653#issuecomment-1034842632 @slinkydeveloper It's grateful to get better for the PR based on your comments. I appreciate with your checking. -- This is an automated message from the Apache Git

[GitHub] [flink] flinkbot commented on pull request #18702: [FLINK-24441][source] Block SourceOperator when watermarks are out of alignment

2022-02-10 Thread GitBox
flinkbot commented on pull request #18702: URL: https://github.com/apache/flink/pull/18702#issuecomment-1034842544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] flinkbot edited a comment on pull request #18699: [FLINK-25937] Restore the environment parallelism before transforming in SinkExpander#expand.

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18699: URL: https://github.com/apache/flink/pull/18699#issuecomment-1034581144 ## CI report: * 5b0d16d20a8db053d7aedfd9a4384511a074a5eb Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18701: [FLINK-26071][table-api-java][table-planner] Now Planner#compilePlan fails if the plan cannot be serialized

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18701: URL: https://github.com/apache/flink/pull/18701#issuecomment-1034766277 ## CI report: * 1dd05d2b0f15ae91f251248c9eb6a48cd87fe0ba Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18697: [FLINK-26034][Build System]Add maven wrapper for flink

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18697: URL: https://github.com/apache/flink/pull/18697#issuecomment-1034510296 ## CI report: * 34a2b1811fd7bc75e2c1e9c8462ab9573d506559 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18653: [FLINK-25825][connector-jdbc] MySqlCatalogITCase fails on azure

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18653: URL: https://github.com/apache/flink/pull/18653#issuecomment-1032212433 ## CI report: * 9261ad675d1c9e6f0ea94df829f94f25f18bafc4 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885710999 ## CI report: * 3556331fec7ec8ca1139085a136035a45b2d0977 Azure:

[jira] [Updated] (FLINK-24441) Block SourceReader when watermarks are out of alignment

2022-02-10 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-24441: --- Labels: pull-request-available (was: ) > Block SourceReader when watermarks are out of

[GitHub] [flink] pnowojski opened a new pull request #18702: [FLINK-24441][source] Block SourceOperator when watermarks are out of alignment

2022-02-10 Thread GitBox
pnowojski opened a new pull request #18702: URL: https://github.com/apache/flink/pull/18702 ## What is the purpose of the change This PR integrates with FLINK-24440 and it implements `SourceOperator` level handling of watermark alignment. ## Verifying this change This

[GitHub] [flink] flinkbot edited a comment on pull request #18701: [FLINK-26071][table-api-java][table-planner] Now Planner#compilePlan fails if the plan cannot be serialized

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18701: URL: https://github.com/apache/flink/pull/18701#issuecomment-1034766277 ## CI report: * 1dd05d2b0f15ae91f251248c9eb6a48cd87fe0ba Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18697: [FLINK-26034][Build System]Add maven wrapper for flink

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18697: URL: https://github.com/apache/flink/pull/18697#issuecomment-1034510296 ## CI report: * 34a2b1811fd7bc75e2c1e9c8462ab9573d506559 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18700: [FLINK-26070][Python] Update dependency numpy to >=1.21.0,<1.22

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18700: URL: https://github.com/apache/flink/pull/18700#issuecomment-1034649114 ## CI report: * a03576e0a414443a0174b4f3240aedb5520fe3b5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18624: [FLINK-25388][table-planner] Add consumedOptions to ExecNodeMetadata

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18624: URL: https://github.com/apache/flink/pull/18624#issuecomment-1029176049 ## CI report: * 0b72f73fa08b2f2f8d28518677a8e36f1f348572 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885710999 ## CI report: * 3556331fec7ec8ca1139085a136035a45b2d0977 Azure:

[GitHub] [flink] autophagy commented on a change in pull request #18678: [FLINK-24474] Default rest.bind-address to localhost in flink-conf.yaml

2022-02-10 Thread GitBox
autophagy commented on a change in pull request #18678: URL: https://github.com/apache/flink/pull/18678#discussion_r803595185 ## File path: flink-end-to-end-tests/test-scripts/common_kubernetes.sh ## @@ -225,4 +225,9 @@ function get_host_machine_address { fi }

[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-10 Thread GitBox
dmvk commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r803594934 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -267,18 +267,31 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18701: [FLINK-26071][table-api-java][table-planner] Now Planner#compilePlan fails if the plan cannot be serialized

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18701: URL: https://github.com/apache/flink/pull/18701#issuecomment-1034766277 ## CI report: * 1dd05d2b0f15ae91f251248c9eb6a48cd87fe0ba Azure:

[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-10 Thread GitBox
dmvk commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r803594934 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -267,18 +267,31 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18700: [FLINK-26070][Python] Update dependency numpy to >=1.21.0,<1.22

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18700: URL: https://github.com/apache/flink/pull/18700#issuecomment-1034649114 ## CI report: * a03576e0a414443a0174b4f3240aedb5520fe3b5 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18680: [FLINK-25583] Support compacting small files for FileSink.

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18680: URL: https://github.com/apache/flink/pull/18680#issuecomment-1033512635 ## CI report: * e50fb694ce8cf0ae952973693bcbf17b1cb75b25 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18697: [FLINK-26034][Build System]Add maven wrapper for flink

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18697: URL: https://github.com/apache/flink/pull/18697#issuecomment-1034510296 ## CI report: * 34a2b1811fd7bc75e2c1e9c8462ab9573d506559 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18153: [FLINK-25568][connectors/elasticsearch] Add Elasticsearch 7 Source

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18153: URL: https://github.com/apache/flink/pull/18153#issuecomment-997756404 ## CI report: * fc2c5d6d82d21eb7dc97ae6556e797d8fd2675ac Azure:

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r803592814 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -267,18

[GitHub] [flink] flinkbot edited a comment on pull request #18700: [FLINK-26070][Python] Update dependency numpy to >=1.21.0,<1.22

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18700: URL: https://github.com/apache/flink/pull/18700#issuecomment-1034649114 ## CI report: * a03576e0a414443a0174b4f3240aedb5520fe3b5 Azure:

[GitHub] [flink] dannycranmer commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-10 Thread GitBox
dannycranmer commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r803589880 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -267,18

[GitHub] [flink] flinkbot edited a comment on pull request #18701: [FLINK-26071][table-api-java][table-planner] Now Planner#compilePlan fails if the plan cannot be serialized

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18701: URL: https://github.com/apache/flink/pull/18701#issuecomment-1034766277 ## CI report: * 1dd05d2b0f15ae91f251248c9eb6a48cd87fe0ba Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18692: URL: https://github.com/apache/flink/pull/18692#issuecomment-1034131249 ## CI report: * 7645e2a83b9789816399536fbf369dc65eafcbf7 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18680: [FLINK-25583] Support compacting small files for FileSink.

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18680: URL: https://github.com/apache/flink/pull/18680#issuecomment-1033512635 ## CI report: * e50fb694ce8cf0ae952973693bcbf17b1cb75b25 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18676: [FLINK-26035][build][planner] Add table-planner-loader-helper module

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18676: URL: https://github.com/apache/flink/pull/18676#issuecomment-1033442314 ## CI report: * f76952a792331a65c0152be8bced92e9dbd45659 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18153: [FLINK-25568][connectors/elasticsearch] Add Elasticsearch 7 Source

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18153: URL: https://github.com/apache/flink/pull/18153#issuecomment-997756404 ## CI report: * fc2c5d6d82d21eb7dc97ae6556e797d8fd2675ac Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18516: [FLINK-25288][tests] add savepoint and metric test cases in source suite of connector testframe

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18516: URL: https://github.com/apache/flink/pull/18516#issuecomment-1022021934 ## CI report: * 42bf48fdbba63580ec0d5418579e2e65c413cf38 Azure:

[jira] [Comment Edited] (FLINK-25875) "StatsDReporter. FilterCharacters" for special processing of the characters are comprehensive enough

2022-02-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490147#comment-17490147 ] Chesnay Schepler edited comment on FLINK-25875 at 2/10/22, 11:42 AM: -

[jira] [Commented] (FLINK-25875) "StatsDReporter. FilterCharacters" for special processing of the characters are comprehensive enough

2022-02-10 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490147#comment-17490147 ] Chesnay Schepler commented on FLINK-25875: -- What I'm looking for a is a specification of the

[GitHub] [flink] XComp commented on pull request #18644: [FLINK-25974] Makes job cancellation rely on JobResultStore entry

2022-02-10 Thread GitBox
XComp commented on pull request #18644: URL: https://github.com/apache/flink/pull/18644#issuecomment-1034821588 I went through the code once more after you raised valid concerns. I reverted my changes and investigated the cancellation code path for the `JobMasterServiceLeadershipRunner`.

[GitHub] [flink] pltbkd commented on pull request #18680: [FLINK-25583] Support compacting small files for FileSink.

2022-02-10 Thread GitBox
pltbkd commented on pull request #18680: URL: https://github.com/apache/flink/pull/18680#issuecomment-1034821469 @gaoyunhaii Thanks for the suggestions. The commits are reorgnized to be more clear, and about 2/3 comments are resolved. I'm still working on the remaining ones. --

[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-10 Thread GitBox
dmvk commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r803587452 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -267,18 +267,31 @@

[GitHub] [flink] alpreu commented on a change in pull request #18153: [FLINK-25568][connectors/elasticsearch] Add Elasticsearch 7 Source

2022-02-10 Thread GitBox
alpreu commented on a change in pull request #18153: URL: https://github.com/apache/flink/pull/18153#discussion_r803586116 ## File path: flink-connectors/flink-connector-elasticsearch7/src/main/java/org/apache/flink/connector/elasticsearch/source/reader/Elasticsearch7Record.java

[GitHub] [flink] GOODBOY008 commented on a change in pull request #18697: [FLINK-26034][Build System]Add maven wrapper for flink

2022-02-10 Thread GitBox
GOODBOY008 commented on a change in pull request #18697: URL: https://github.com/apache/flink/pull/18697#discussion_r803584962 ## File path: mvnw ## @@ -0,0 +1,310 @@ +#!/bin/sh +# +# Licensed to the

[GitHub] [flink] flinkbot edited a comment on pull request #18701: [FLINK-26071][table-api-java][table-planner] Now Planner#compilePlan fails if the plan cannot be serialized

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18701: URL: https://github.com/apache/flink/pull/18701#issuecomment-1034766277 ## CI report: * 1dd05d2b0f15ae91f251248c9eb6a48cd87fe0ba Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18697: [FLINK-26034][Build System]Add maven wrapper for flink

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18697: URL: https://github.com/apache/flink/pull/18697#issuecomment-1034510296 ## CI report: * 34a2b1811fd7bc75e2c1e9c8462ab9573d506559 Azure:

[GitHub] [flink] pltbkd commented on a change in pull request #18680: [FLINK-25583] Support compacting small files for FileSink.

2022-02-10 Thread GitBox
pltbkd commented on a change in pull request #18680: URL: https://github.com/apache/flink/pull/18680#discussion_r803584223 ## File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/compactor/operator/CompactorOperator.java ## @@

[GitHub] [flink] flinkbot edited a comment on pull request #18648: [FLINK-25845][table] Introduce EXECUTE PLAN

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18648: URL: https://github.com/apache/flink/pull/18648#issuecomment-1031569879 ## CI report: * 2e7e7a66ce145cfbbe8449e30502f0b2f75c7b90 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18644: [FLINK-25974] Makes job cancellation rely on JobResultStore entry

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18644: URL: https://github.com/apache/flink/pull/18644#issuecomment-1031433646 ## CI report: * 68a106239b32be93ec21cfa4723b802b34d6aa20 Azure:

[GitHub] [flink] GOODBOY008 commented on pull request #18697: [FLINK-26034][Build System]Add maven wrapper for flink

2022-02-10 Thread GitBox
GOODBOY008 commented on pull request #18697: URL: https://github.com/apache/flink/pull/18697#issuecomment-1034814261 > Thanks for opening this PR @GOODBOY008. Could you add a short description of what the script does? Is it copied from somewhere or did you develop it from scratch? If yes,

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r803581562 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -267,18

[GitHub] [flink] dmvk commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-10 Thread GitBox
dmvk commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r803580523 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -267,18 +267,31 @@

[GitHub] [flink] flinkbot edited a comment on pull request #18701: [FLINK-26071][table-api-java][table-planner] Now Planner#compilePlan fails if the plan cannot be serialized

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18701: URL: https://github.com/apache/flink/pull/18701#issuecomment-1034766277 ## CI report: * 1dd05d2b0f15ae91f251248c9eb6a48cd87fe0ba Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18697: [FLINK-26034][Build System]Add maven wrapper for flink

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18697: URL: https://github.com/apache/flink/pull/18697#issuecomment-1034510296 ## CI report: * 34a2b1811fd7bc75e2c1e9c8462ab9573d506559 Azure:

[GitHub] [flink] zentol commented on a change in pull request #18696: [hotfix][docs] project config pages

2022-02-10 Thread GitBox
zentol commented on a change in pull request #18696: URL: https://github.com/apache/flink/pull/18696#discussion_r803578123 ## File path: docs/content/docs/dev/configuration/testing.md ## @@ -31,8 +31,30 @@ Flink provides utilities for testing your job that you can add as

[jira] [Commented] (FLINK-25875) "StatsDReporter. FilterCharacters" for special processing of the characters are comprehensive enough

2022-02-10 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490137#comment-17490137 ] 赵富午 commented on FLINK-25875: - In my opinion, we should not only filter space characters, but also filter

[GitHub] [flink] flinkbot edited a comment on pull request #18644: [FLINK-25974] Makes job cancellation rely on JobResultStore entry

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18644: URL: https://github.com/apache/flink/pull/18644#issuecomment-1031433646 ## CI report: * 68a106239b32be93ec21cfa4723b802b34d6aa20 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #17452: URL: https://github.com/apache/flink/pull/17452#issuecomment-940136217 ## CI report: * b84065861ec8af6e9f35ffdc548ce3203a21534e Azure:

[GitHub] [flink] vahmed-hamdy commented on a change in pull request #18669: [FLINK-25943][connector/common] Add buffered requests to snapshot state in AsyncSyncWriter.

2022-02-10 Thread GitBox
vahmed-hamdy commented on a change in pull request #18669: URL: https://github.com/apache/flink/pull/18669#discussion_r803575849 ## File path:

[GitHub] [flink] flinkbot edited a comment on pull request #18701: [FLINK-26071][table-api-java][table-planner] Now Planner#compilePlan fails if the plan cannot be serialized

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18701: URL: https://github.com/apache/flink/pull/18701#issuecomment-1034766277 ## CI report: * 1dd05d2b0f15ae91f251248c9eb6a48cd87fe0ba Azure:

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r803573163 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -267,18

[GitHub] [flink] CrynetLogistics commented on a change in pull request #18651: [FLINK-25792][connectors] Only flushing the async sink base if it is …

2022-02-10 Thread GitBox
CrynetLogistics commented on a change in pull request #18651: URL: https://github.com/apache/flink/pull/18651#discussion_r803573163 ## File path: flink-connectors/flink-connector-base/src/main/java/org/apache/flink/connector/base/sink/writer/AsyncSinkWriter.java ## @@ -267,18

[jira] [Commented] (FLINK-25875) "StatsDReporter. FilterCharacters" for special processing of the characters are comprehensive enough

2022-02-10 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-25875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490134#comment-17490134 ] 赵富午 commented on FLINK-25875: - The first thing you need to filter is space characters.  Some of the metrics

[GitHub] [flink] flinkbot edited a comment on pull request #17452: [FLINK-20732][connector/pulsar] Introduction of Pulsar Sink

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #17452: URL: https://github.com/apache/flink/pull/17452#issuecomment-940136217 ## CI report: * b84065861ec8af6e9f35ffdc548ce3203a21534e Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18701: [FLINK-26071][table-api-java][table-planner] Now Planner#compilePlan fails if the plan cannot be serialized

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18701: URL: https://github.com/apache/flink/pull/18701#issuecomment-1034766277 ## CI report: * 1dd05d2b0f15ae91f251248c9eb6a48cd87fe0ba Azure:

[jira] [Commented] (FLINK-26036) LocalRecoveryITCase.testRecoverLocallyFromProcessCrashWithWorkingDirectory timeout on azure

2022-02-10 Thread Till Rohrmann (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17490131#comment-17490131 ] Till Rohrmann commented on FLINK-26036: --- Thanks for the pointer [~gaoyunhaii]. I will take another

[GitHub] [flink] flinkbot edited a comment on pull request #18649: [FLINK-25844][table-api-java] Introduce StatementSet#compilePlan

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18649: URL: https://github.com/apache/flink/pull/18649#issuecomment-1031570072 ## CI report: * 7abbdf54df75a8e9e0041e908ab61d785d800410 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #16584: [FLINK-22781][table-planner-blink] Fix bug that when implements the L…

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #16584: URL: https://github.com/apache/flink/pull/16584#issuecomment-885710999 ## CI report: * 3556331fec7ec8ca1139085a136035a45b2d0977 Azure:

[GitHub] [flink] flinkbot edited a comment on pull request #18701: [FLINK-26071][table-api-java][table-planner] Now Planner#compilePlan fails if the plan cannot be serialized

2022-02-10 Thread GitBox
flinkbot edited a comment on pull request #18701: URL: https://github.com/apache/flink/pull/18701#issuecomment-1034766277 ## CI report: * 1dd05d2b0f15ae91f251248c9eb6a48cd87fe0ba Azure:

[GitHub] [flink] zentol commented on a change in pull request #18692: [FLINK-26015] Fixes object store bug

2022-02-10 Thread GitBox
zentol commented on a change in pull request #18692: URL: https://github.com/apache/flink/pull/18692#discussion_r803564915 ## File path: flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/util/DockerImageVersions.java ## @@ -45,4 +45,6 @@

<    4   5   6   7   8   9   10   11   >