[GitHub] [flink] RocMarshal commented on a diff in pull request #19493: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese.

RocMarshal commented on code in PR #19493: URL: https://github.com/apache/flink/pull/19493#discussion_r867470521 ## docs/content.zh/docs/concepts/glossary.md: ## @@ -27,15 +27,13 @@ under the License. Flink Application Cluster Review Comment: `` -- This is

[GitHub] [flink] RocMarshal commented on a diff in pull request #19493: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese.

RocMarshal commented on code in PR #19493: URL: https://github.com/apache/flink/pull/19493#discussion_r867470521 ## docs/content.zh/docs/concepts/glossary.md: ## @@ -27,15 +27,13 @@ under the License. Flink Application Cluster Review Comment: -- This is an

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #111: [FLINK-27540] Let FileStoreSource accept pre-planned manifest entries

JingsongLi commented on code in PR #111: URL: https://github.com/apache/flink-table-store/pull/111#discussion_r867464932 ## flink-table-store-connector/src/main/java/org/apache/flink/table/store/connector/source/FileStoreSource.java: ## @@ -61,6 +66,13 @@ @Nullable

[GitHub] [flink] gaoyunhaii commented on pull request #19671: (1.15) [release] Generates snapshot for migration tests on 1.15

gaoyunhaii commented on PR #19671: URL: https://github.com/apache/flink/pull/19671#issuecomment-1120380391 Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] gaoyunhaii closed pull request #19671: (1.15) [release] Generates snapshot for migration tests on 1.15

gaoyunhaii closed pull request #19671: (1.15) [release] Generates snapshot for migration tests on 1.15 URL: https://github.com/apache/flink/pull/19671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #196: [FLINK-27500] Validation errors should not block reconciliation

gyfora commented on code in PR #196: URL: https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867450242 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -62,14 +66,20 @@ void

[jira] [Closed] (FLINK-26915) Extend the Reconciler and Observer interface

[ https://issues.apache.org/jira/browse/FLINK-26915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aitozi closed FLINK-26915. -- Resolution: Won't Fix > Extend the Reconciler and Observer interface >

[jira] [Commented] (FLINK-26915) Extend the Reconciler and Observer interface

[ https://issues.apache.org/jira/browse/FLINK-26915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533425#comment-17533425 ] Aitozi commented on FLINK-26915: I have the same sense not to do this now, The main reason is that we

[jira] [Commented] (FLINK-27483) Support adding custom HTTP header for HTTP based Jar fetch

[ https://issues.apache.org/jira/browse/FLINK-27483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533420#comment-17533420 ] Aitozi commented on FLINK-27483: [~wangyang0918] I check the code again I found I mess them up, also

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #196: [FLINK-27500] Validation errors should not block reconciliation

Aitozi commented on code in PR #196: URL: https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867444180 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +257,34 @@ public

[jira] [Assigned] (FLINK-27497) Track terminal job states in the observer

[ https://issues.apache.org/jira/browse/FLINK-27497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-27497: -- Assignee: Aitozi > Track terminal job states in the observer >

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #196: [FLINK-27500] Validation errors should not block reconciliation

Aitozi commented on code in PR #196: URL: https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867443955 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -112,21 +122,11 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #196: [FLINK-27500] Validation errors should not block reconciliation

gyfora commented on code in PR #196: URL: https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867443705 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +257,34 @@ public

[jira] [Commented] (FLINK-27497) Track terminal job states in the observer

[ https://issues.apache.org/jira/browse/FLINK-27497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533416#comment-17533416 ] Aitozi commented on FLINK-27497: I think it will be very useful improvements, I would like to give a try

[jira] [Comment Edited] (FLINK-27497) Track terminal job states in the observer

[ https://issues.apache.org/jira/browse/FLINK-27497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17533416#comment-17533416 ] Aitozi edited comment on FLINK-27497 at 5/8/22 6:39 AM: I think it will be a

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #196: [FLINK-27500] Validation errors should not block reconciliation

gyfora commented on code in PR #196: URL: https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867443035 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -112,21 +122,11 @@ public

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #196: [FLINK-27500] Validation errors should not block reconciliation

gyfora commented on code in PR #196: URL: https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867442856 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +257,34 @@ public

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #196: [FLINK-27500] Validation errors should not block reconciliation

Aitozi commented on code in PR #196: URL: https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867442186 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -62,14 +66,20 @@ void

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #196: [FLINK-27500] Validation errors should not block reconciliation

Aitozi commented on code in PR #196: URL: https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867441326 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +257,34 @@ public

[GitHub] [flink-kubernetes-operator] Aitozi commented on a diff in pull request #196: [FLINK-27500] Validation errors should not block reconciliation

Aitozi commented on code in PR #196: URL: https://github.com/apache/flink-kubernetes-operator/pull/196#discussion_r867441326 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/ReconciliationUtils.java: ## @@ -255,4 +257,34 @@ public

[GitHub] [flink] RocMarshal commented on a diff in pull request #19493: [FLINK-27205][docs-zh] Translate "Concepts -> Glossary" page into Chinese.

RocMarshal commented on code in PR #19493: URL: https://github.com/apache/flink/pull/19493#discussion_r867441186 ## docs/content.zh/docs/concepts/glossary.md: ## @@ -27,15 +27,13 @@ under the License. Flink Application Cluster Review Comment: link tag ,here. --

<    1   2