[GitHub] [flink] tisonkun commented on a diff in pull request #21075: [FLINK-28085][Connector/Pulsar] Close the pending Pulsar transactions before closing pipeline

2022-10-17 Thread GitBox
tisonkun commented on code in PR #21075: URL: https://github.com/apache/flink/pull/21075#discussion_r997746983 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/utils/PulsarTransactionUtils.java: ## @@ -60,6 +60,8 @@ public static

[GitHub] [flink] syhily commented on a diff in pull request #21075: [FLINK-28085][Connector/Pulsar] Close the pending Pulsar transactions before closing pipeline

2022-10-17 Thread GitBox
syhily commented on code in PR #21075: URL: https://github.com/apache/flink/pull/21075#discussion_r997745089 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/utils/PulsarTransactionUtils.java: ## @@ -60,6 +60,8 @@ public static

[jira] [Commented] (FLINK-29580) pulsar.consumer.autoUpdatePartitionsIntervalSeconds doesn't works and should be removed

2022-10-17 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619242#comment-17619242 ] Yufan Sheng commented on FLINK-29580: - OK, I think you are right. >

[jira] [Closed] (FLINK-29580) pulsar.consumer.autoUpdatePartitionsIntervalSeconds doesn't works and should be removed

2022-10-17 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yufan Sheng closed FLINK-29580. --- > pulsar.consumer.autoUpdatePartitionsIntervalSeconds doesn't works and should > be removed >

[jira] [Resolved] (FLINK-29580) pulsar.consumer.autoUpdatePartitionsIntervalSeconds doesn't works and should be removed

2022-10-17 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yufan Sheng resolved FLINK-29580. - Resolution: Fixed > pulsar.consumer.autoUpdatePartitionsIntervalSeconds doesn't works and

[GitHub] [flink] tisonkun commented on a diff in pull request #21075: [FLINK-28085][Connector/Pulsar] Close the pending Pulsar transactions before closing pipeline

2022-10-17 Thread GitBox
tisonkun commented on code in PR #21075: URL: https://github.com/apache/flink/pull/21075#discussion_r997742396 ## flink-connectors/flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/common/utils/PulsarTransactionUtils.java: ## @@ -60,6 +60,8 @@ public static

[GitHub] [flink] flinkbot commented on pull request #21093: [BP-1.16][FLINK-28960][Connector/Pulsar] Add jaxb-api back to pulsar-client-all dependencies

2022-10-17 Thread GitBox
flinkbot commented on PR #21093: URL: https://github.com/apache/flink/pull/21093#issuecomment-1281845599 ## CI report: * 4ccfa593898bfe628956eae7ea7f991f799fc039 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21092: [BP-1.15][FLINK-28960][Connector/Pulsar] Add jaxb-api back to pulsar-client-all dependencies

2022-10-17 Thread GitBox
flinkbot commented on PR #21092: URL: https://github.com/apache/flink/pull/21092#issuecomment-1281845006 ## CI report: * e178958e65e6ca571a89d2395957e69897ff02f1 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21091: [BP-1.14][FLINK-28960][Connector/Pulsar] Add jaxb-api back to pulsar-client-all dependencies

2022-10-17 Thread GitBox
flinkbot commented on PR #21091: URL: https://github.com/apache/flink/pull/21091#issuecomment-1281844486 ## CI report: * b85a2713aa6272a16934e6d84a14b454a97c7b9d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21090: Bump snakeyaml from 1.27 to 1.31

2022-10-17 Thread GitBox
flinkbot commented on PR #21090: URL: https://github.com/apache/flink/pull/21090#issuecomment-1281843997 ## CI report: * 366a8af55b68c20bc9f4c3ca51d73e4d5a611aa9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] syhily commented on pull request #21069: [FLINK-29613][Connector/Pulsar] Fix wrong batch size assertion.

2022-10-17 Thread GitBox
syhily commented on PR #21069: URL: https://github.com/apache/flink/pull/21069#issuecomment-1281843417 The main cause of this fix is just because some bugs in Pulsar. Pulsar always wrap single message id into a batch message id. This fix will throws detailed exception with batch message

[jira] [Assigned] (FLINK-28820) Pulsar Connector PulsarSink performance issue when delivery guarantee is not NONE

2022-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-28820: - Assignee: Yufan Sheng > Pulsar Connector PulsarSink performance issue when delivery guarantee

[jira] [Assigned] (FLINK-28960) Pulsar throws java.lang.NoClassDefFoundError: javax/xml/bind/annotation/XmlElement

2022-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-28960: - Assignee: Yufan Sheng > Pulsar throws java.lang.NoClassDefFoundError: >

[GitHub] [flink] dependabot[bot] opened a new pull request, #21090: Bump snakeyaml from 1.27 to 1.31

2022-10-17 Thread GitBox
dependabot[bot] opened a new pull request, #21090: URL: https://github.com/apache/flink/pull/21090 Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.27 to 1.31. Commits

[GitHub] [flink] tisonkun merged pull request #21072: [FLINK-28960][Connector/Pulsar] Add jaxb-api back to pulsar-client-all dependencies.

2022-10-17 Thread GitBox
tisonkun merged PR #21072: URL: https://github.com/apache/flink/pull/21072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-29433) Support Auth through the builder pattern in Pulsar connector

2022-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-29433. - Resolution: Fixed master via 25c429734f5beeafda482463e2b61326b7216261 > Support Auth through the

[GitHub] [flink] tisonkun merged pull request #21071: [FLINK-29433][Connector/Pulsar] Support Auth through the builder pattern in Pulsar connector.

2022-10-17 Thread GitBox
tisonkun merged PR #21071: URL: https://github.com/apache/flink/pull/21071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-29433) Support Auth through the builder pattern in Pulsar connector

2022-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-29433: - Assignee: Yufan Sheng > Support Auth through the builder pattern in Pulsar connector >

[jira] [Commented] (FLINK-29580) pulsar.consumer.autoUpdatePartitionsIntervalSeconds doesn't works and should be removed

2022-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619232#comment-17619232 ] Zili Chen commented on FLINK-29580: --- master via 2bab5adc1a1d36d35ed971a007db9e311dc0363b >

[GitHub] [flink] tisonkun merged pull request #21070: [FLINK-29580][Connector/Pulsar] Remove pulsar.consumer.autoUpdatePartitionsIntervalSeconds option.

2022-10-17 Thread GitBox
tisonkun merged PR #21070: URL: https://github.com/apache/flink/pull/21070 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-29580) pulsar.consumer.autoUpdatePartitionsIntervalSeconds doesn't works and should be removed

2022-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619230#comment-17619230 ] Zili Chen commented on FLINK-29580: --- It's OK to apply on new minor releases. But will it cause

[jira] [Assigned] (FLINK-29613) Wrong message size assertion in Pulsar's batch message

2022-10-17 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen reassigned FLINK-29613: - Assignee: Yufan Sheng > Wrong message size assertion in Pulsar's batch message >

[GitHub] [flink] XComp commented on pull request #20168: [FLINK-28324][flink-sql-client][JUnit5 Migration] Module: flink-sql-client

2022-10-17 Thread GitBox
XComp commented on PR #20168: URL: https://github.com/apache/flink/pull/20168#issuecomment-1281823045 Thanks for your contribution @zhoulii. Just a minor comment about the timeouts: Keep in mind that we actually want to remove timeouts from JUnit tests (see [coding

[jira] [Commented] (FLINK-29620) Flink deployment stuck in UPGRADING state when changing configuration

2022-10-17 Thread liad shachoach (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619222#comment-17619222 ] liad shachoach commented on FLINK-29620: not solved by 1.2.0, I will try to upgrade to flink

[jira] [Commented] (FLINK-10929) Add support for Apache Arrow

2022-10-17 Thread Aitozi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-10929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619217#comment-17619217 ] Aitozi commented on FLINK-10929: Nice to see a good discussion about Arrow support here. I have one

[jira] [Updated] (FLINK-28440) EventTimeWindowCheckpointingITCase.testSlidingTimeWindow failed with restore

2022-10-17 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yanfei Lei updated FLINK-28440: --- Component/s: Runtime / Checkpointing > EventTimeWindowCheckpointingITCase.testSlidingTimeWindow

[GitHub] [flink] Samrat002 commented on pull request #20937: [FLINK-29478][flink-connector/hive] Flink connector hive upgrade to 3.1.3

2022-10-17 Thread GitBox
Samrat002 commented on PR #20937: URL: https://github.com/apache/flink/pull/20937#issuecomment-1281758305 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] wsry commented on pull request #21083: [FLINK-29641] SortMergeResultPartitionReadSchedulerTest#testCreateSubpartitionReader is not stable.

2022-10-17 Thread GitBox
wsry commented on PR #21083: URL: https://github.com/apache/flink/pull/21083#issuecomment-1281753232 @reswqa Thanks for the fix. Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] wsry merged pull request #21083: [FLINK-29641] SortMergeResultPartitionReadSchedulerTest#testCreateSubpartitionReader is not stable.

2022-10-17 Thread GitBox
wsry merged PR #21083: URL: https://github.com/apache/flink/pull/21083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] lindong28 commented on pull request #163: [FLINK-29591] Add built-in UDFs to convert between arrays and vectors

2022-10-17 Thread GitBox
lindong28 commented on PR #163: URL: https://github.com/apache/flink-ml/pull/163#issuecomment-1281747469 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-ml] lindong28 merged pull request #163: [FLINK-29591] Add built-in UDFs to convert between arrays and vectors

2022-10-17 Thread GitBox
lindong28 merged PR #163: URL: https://github.com/apache/flink-ml/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-27998) Upgrade Calcite version to 1.30

2022-10-17 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619204#comment-17619204 ] godfrey he commented on FLINK-27998: Can this ticket be closed since "Upgrade Calcite version to

[jira] [Closed] (FLINK-21239) Upgrade Calcite version to 1.28

2022-10-17 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-21239. -- Resolution: Won't Fix This ticket can be closed since "Upgrade Calcite version to 1.32" has been

[jira] [Closed] (FLINK-20873) Upgrade Calcite version to 1.27

2022-10-17 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] godfrey he closed FLINK-20873. -- Resolution: Won't Fix > Upgrade Calcite version to 1.27 > --- > >

[GitHub] [flink] zhoulii commented on pull request #20168: [FLINK-28324][flink-sql-client][JUnit5 Migration] Module: flink-sql-client

2022-10-17 Thread GitBox
zhoulii commented on PR #20168: URL: https://github.com/apache/flink/pull/20168#issuecomment-1281741638 Thanks for reviewing, I will rebase the change and address the comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-20873) Upgrade Calcite version to 1.27

2022-10-17 Thread godfrey he (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619201#comment-17619201 ] godfrey he commented on FLINK-20873: This ticket can be closed since "Upgrade Calcite version to

[GitHub] [flink] zhuzhurk commented on pull request #20168: [FLINK-28324][flink-sql-client][JUnit5 Migration] Module: flink-sql-client

2022-10-17 Thread GitBox
zhuzhurk commented on PR #20168: URL: https://github.com/apache/flink/pull/20168#issuecomment-1281737718 Thanks for opening this PR! @zhoulii Now the Flink master is ready to merge changes for Flink 1.17 and we can continue with this migration work. Would you rebase the change to the

[jira] [Updated] (FLINK-29674) Apache Kafka Connector‘s “ setBounded” not valid

2022-10-17 Thread hongcha (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hongcha updated FLINK-29674: Summary: Apache Kafka Connector‘s “ setBounded” not valid (was: Apache Kafka 连接器的“ setBounded”不生效) >

[GitHub] [flink] LadyForest commented on pull request #20652: [FLINK-22315][table] Support add/modify column/constraint/watermark for ALTER TABLE statement

2022-10-17 Thread GitBox
LadyForest commented on PR #20652: URL: https://github.com/apache/flink/pull/20652#issuecomment-1281732704 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-29674) Apache Kafka 连接器的“ setBounded”不生效

2022-10-17 Thread jiangwei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiangwei updated FLINK-29674: - Description: When I'm using the official Apache Kafka connector, I see that the official means to set

[GitHub] [flink] klion26 commented on a diff in pull request #21050: [FLINK-29095][state] Improve logging in SharedStateRegistry

2022-10-17 Thread GitBox
klion26 commented on code in PR #21050: URL: https://github.com/apache/flink/pull/21050#discussion_r997655058 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -95,60 +95,78 @@ public StreamStateHandle registerReference(

[GitHub] [flink] klion26 commented on a diff in pull request #21050: [FLINK-29095][state] Improve logging in SharedStateRegistry

2022-10-17 Thread GitBox
klion26 commented on code in PR #21050: URL: https://github.com/apache/flink/pull/21050#discussion_r997655058 ## flink-runtime/src/main/java/org/apache/flink/runtime/state/SharedStateRegistryImpl.java: ## @@ -95,60 +95,78 @@ public StreamStateHandle registerReference(

[GitHub] [flink] zoltar9264 commented on pull request #20965: [FLINK-29244][state/changelog] Add metric lastMaterializationDuration…

2022-10-17 Thread GitBox
zoltar9264 commented on PR #20965: URL: https://github.com/apache/flink/pull/20965#issuecomment-1281721537 Hi @Myasuka , can you help me merge this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] zoltar9264 commented on pull request #20975: [FLINK-29526][state/changelog] fix java doc mistake in SequenceNumber…

2022-10-17 Thread GitBox
zoltar9264 commented on PR #20975: URL: https://github.com/apache/flink/pull/20975#issuecomment-1281721579 Hi @Myasuka , can you help me merge this pr ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Closed] (FLINK-26668) Unsupportedoperation exception caused by createActualEdge error in adaptive batch scheduler

2022-10-17 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-26668. -- Resolution: Invalid > Unsupportedoperation exception caused by createActualEdge error in adaptive >

[jira] [Commented] (FLINK-26668) Unsupportedoperation exception caused by createActualEdge error in adaptive batch scheduler

2022-10-17 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619187#comment-17619187 ] Lijie Wang commented on FLINK-26668: This issue was caused by applying a deprecated PR

[jira] [Commented] (FLINK-29653) close DynamicResult but it was already closed

2022-10-17 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619188#comment-17619188 ] luoyuxia commented on FLINK-29653: -- cc [~fsk119]  > close DynamicResult but it was already closed >

[jira] [Updated] (FLINK-29674) Apache Kafka 连接器的“ setBounded”不生效

2022-10-17 Thread jiangwei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jiangwei updated FLINK-29674: - Description: 我在使用官方提供的Apache Kafka

[jira] [Created] (FLINK-29674) Apache Kafka 连接器的“ setBounded”不生效

2022-10-17 Thread jiangwei (Jira)
jiangwei created FLINK-29674: Summary: Apache Kafka 连接器的“ setBounded”不生效 Key: FLINK-29674 URL: https://issues.apache.org/jira/browse/FLINK-29674 Project: Flink Issue Type: Bug

[jira] [Commented] (FLINK-29657) Flink hive parser considers literal floating point number differently than Hive SQL

2022-10-17 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619186#comment-17619186 ] luoyuxia commented on FLINK-29657: -- I see.  The most Hive sql statements in Hive 1.2 should also work

[GitHub] [flink] flinkbot commented on pull request #21089: [FLINK-29644] [docs] Adding flink k8s operator documentation link

2022-10-17 Thread GitBox
flinkbot commented on PR #21089: URL: https://github.com/apache/flink/pull/21089#issuecomment-1281702271 ## CI report: * 68f62b647fe793d1a54eb40d3cc6062c3cd85d36 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-29644) Reference Kubernetes operator from Flink Kubernetes deploy docs

2022-10-17 Thread Sriram Ganesh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619183#comment-17619183 ] Sriram Ganesh commented on FLINK-29644: --- Please check the PR.

[jira] [Updated] (FLINK-29644) Reference Kubernetes operator from Flink Kubernetes deploy docs

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29644: --- Labels: pull-request-available starter (was: starter) > Reference Kubernetes operator from

[GitHub] [flink] rgsriram opened a new pull request, #21089: [FLINK-29644] [docs] Adding flink k8s operator documentation link

2022-10-17 Thread GitBox
rgsriram opened a new pull request, #21089: URL: https://github.com/apache/flink/pull/21089 ## What is the purpose of the change *Flink docs don't have any documentation link related to Flink Kubernetes operator. This change lets us see the Flink Kubernetes operator and how to use

[jira] [Commented] (FLINK-29673) Support sqlserver catalog

2022-10-17 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619181#comment-17619181 ] waywtdcc commented on FLINK-29673: -- please assign this to me. > Support sqlserver catalog >

[jira] [Created] (FLINK-29673) Support sqlserver catalog

2022-10-17 Thread waywtdcc (Jira)
waywtdcc created FLINK-29673: Summary: Support sqlserver catalog Key: FLINK-29673 URL: https://issues.apache.org/jira/browse/FLINK-29673 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-29652) get duplicate result from sql-client in BATCH mode

2022-10-17 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619179#comment-17619179 ] luoyuxia commented on FLINK-29652: -- Thanks for the explanation. [~fsk119] Could you please have a look

[jira] [Commented] (FLINK-28985) support create table like view

2022-10-17 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619177#comment-17619177 ] waywtdcc commented on FLINK-28985: -- Please assign this to me. > support create table like view >

[jira] [Commented] (FLINK-29672) Support oracle catalog

2022-10-17 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619176#comment-17619176 ] waywtdcc commented on FLINK-29672: -- please assign this to me > Support oracle catalog >

[jira] [Updated] (FLINK-29672) Support oracle catalog

2022-10-17 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] waywtdcc updated FLINK-29672: - Fix Version/s: (was: 1.16.1) > Support oracle catalog > --- > >

[jira] [Created] (FLINK-29672) Support oracle catalog

2022-10-17 Thread waywtdcc (Jira)
waywtdcc created FLINK-29672: Summary: Support oracle catalog Key: FLINK-29672 URL: https://issues.apache.org/jira/browse/FLINK-29672 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-29672) Support oracle catalog

2022-10-17 Thread waywtdcc (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] waywtdcc updated FLINK-29672: - Fix Version/s: 1.16.1 > Support oracle catalog > --- > > Key:

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #163: [FLINK-29591] Add built-in UDFs to convert between arrays and vectors

2022-10-17 Thread GitBox
lindong28 commented on code in PR #163: URL: https://github.com/apache/flink-ml/pull/163#discussion_r997598885 ## flink-ml-python/pyflink/ml/core/wrapper.py: ## @@ -22,16 +22,15 @@ from pyflink.common import typeinfo, Time from pyflink.common.typeinfo import _from_java_type,

[GitHub] [flink-connector-dynamodb] nirtsruya commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-17 Thread GitBox
nirtsruya commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r997544803 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkBuilder.java: ## @@ -0,0 +1,134 @@ +/* + *

[GitHub] [flink] kristoffSC commented on a diff in pull request #21052: [Flink 29627][streaming] Fix duplicate key exception during recover more than 1 committable.

2022-10-17 Thread GitBox
kristoffSC commented on code in PR #21052: URL: https://github.com/apache/flink/pull/21052#discussion_r997537278 ## flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/streaming/util/CheckpointCountingSource.java: ## @@ -0,0 +1,165 @@ +/* + * Licensed to the

[GitHub] [flink-connector-dynamodb] nirtsruya commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-17 Thread GitBox
nirtsruya commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r997534733 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkBuilder.java: ## @@ -0,0 +1,134 @@ +/* + *

[GitHub] [flink] kristoffSC commented on a diff in pull request #21052: [Flink 29627][streaming] Fix duplicate key exception during recover more than 1 committable.

2022-10-17 Thread GitBox
kristoffSC commented on code in PR #21052: URL: https://github.com/apache/flink/pull/21052#discussion_r997534738 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/TestSink.java: ## @@ -397,6 +400,54 @@ public void endOfInput() { }

[GitHub] [flink] kristoffSC commented on a diff in pull request #21052: [Flink 29627][streaming] Fix duplicate key exception during recover more than 1 committable.

2022-10-17 Thread GitBox
kristoffSC commented on code in PR #21052: URL: https://github.com/apache/flink/pull/21052#discussion_r997505723 ## flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkITCase.java: ## @@ -113,6 +122,69 @@ public void init() {

[GitHub] [flink] kristoffSC commented on a diff in pull request #21052: [Flink 29627][streaming] Fix duplicate key exception during recover more than 1 committable.

2022-10-17 Thread GitBox
kristoffSC commented on code in PR #21052: URL: https://github.com/apache/flink/pull/21052#discussion_r997503519 ## flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/SinkITCase.java: ## @@ -113,6 +122,69 @@ public void init() {

[GitHub] [flink] kristoffSC commented on pull request #21052: [Flink 29627][streaming] Fix duplicate key exception during recover more than 1 committable.

2022-10-17 Thread GitBox
kristoffSC commented on PR #21052: URL: https://github.com/apache/flink/pull/21052#issuecomment-1281474855 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-17 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r997401172 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSink.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-17 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r997400104 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSink.java: ## @@ -0,0 +1,162 @@ +/* + * Licensed

[GitHub] [flink-connector-dynamodb] hlteoh37 commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-17 Thread GitBox
hlteoh37 commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r997399953 ## flink-connector-aws-dynamodb/src/main/java/org/apache/flink/streaming/connectors/dynamodb/sink/DynamoDbSinkBuilder.java: ## @@ -0,0 +1,134 @@ +/* + *

[jira] [Commented] (FLINK-29629) FlameGraph is empty for Legacy Source Threads

2022-10-17 Thread Peter Vary (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17619053#comment-17619053 ] Peter Vary commented on FLINK-29629: [~chesnay]: Does that mean that some of the code below uses

[GitHub] [flink-connector-dynamodb] YuriGusev commented on a diff in pull request #1: [FLINK-24229][Connectors][DynamoDB] - Add AWS DynamoDB connector

2022-10-17 Thread GitBox
YuriGusev commented on code in PR #1: URL: https://github.com/apache/flink-connector-dynamodb/pull/1#discussion_r997398631 ## pom.xml: ## @@ -0,0 +1,1140 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +

[GitHub] [flink] kristoffSC commented on a diff in pull request #21052: [Flink 29627][streaming] Fix duplicate key exception during recover more than 1 committable.

2022-10-17 Thread GitBox
kristoffSC commented on code in PR #21052: URL: https://github.com/apache/flink/pull/21052#discussion_r997246807 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/committables/CommittableCollectorSerializerTest.java: ## @@ -134,55 +190,78

[jira] [Commented] (FLINK-29671) Kubernetes e2e test fails during test initialization

2022-10-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618978#comment-17618978 ] Matthias Pohl commented on FLINK-29671: --- FLINK-28269 had a similar error message > Kubernetes e2e

[GitHub] [flink] kristoffSC commented on a diff in pull request #21052: [Flink 29627][streaming] Fix duplicate key exception during recover more than 1 committable.

2022-10-17 Thread GitBox
kristoffSC commented on code in PR #21052: URL: https://github.com/apache/flink/pull/21052#discussion_r997239119 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/committables/CommittableCollectorSerializerTest.java: ## @@ -134,55 +190,78

[jira] [Commented] (FLINK-29671) Kubernetes e2e test fails during test initialization

2022-10-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618977#comment-17618977 ] Matthias Pohl commented on FLINK-29671: --- It doesn't seem to happen regularly. Other more recent

[jira] [Comment Edited] (FLINK-29671) Kubernetes e2e test fails during test initialization

2022-10-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618977#comment-17618977 ] Matthias Pohl edited comment on FLINK-29671 at 10/17/22 3:52 PM: - It

[jira] [Updated] (FLINK-29671) Kubernetes e2e test fails during test initialization

2022-10-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-29671: -- Priority: Critical (was: Major) > Kubernetes e2e test fails during test initialization >

[GitHub] [flink] kristoffSC commented on a diff in pull request #21052: [Flink 29627][streaming] Fix duplicate key exception during recover more than 1 committable.

2022-10-17 Thread GitBox
kristoffSC commented on code in PR #21052: URL: https://github.com/apache/flink/pull/21052#discussion_r997239119 ## flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/operators/sink/committables/CommittableCollectorSerializerTest.java: ## @@ -134,55 +190,78

[jira] [Created] (FLINK-29671) Kubernetes e2e test fails during test initialization

2022-10-17 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-29671: - Summary: Kubernetes e2e test fails during test initialization Key: FLINK-29671 URL: https://issues.apache.org/jira/browse/FLINK-29671 Project: Flink Issue

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-10-17 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r997229049 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/IteratorSourceReaderBase.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] afedulov commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-10-17 Thread GitBox
afedulov commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r997229049 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/IteratorSourceReaderBase.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-29398) Utilize Rack Awareness in Flink Consumer

2022-10-17 Thread Jeremy DeGroot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618962#comment-17618962 ] Jeremy DeGroot commented on FLINK-29398: [~martijnvisser] I just signed into the Confluence and

[GitHub] [flink] zentol commented on a diff in pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

2022-10-17 Thread GitBox
zentol commented on code in PR #20757: URL: https://github.com/apache/flink/pull/20757#discussion_r997215784 ## flink-core/src/main/java/org/apache/flink/api/connector/source/lib/util/IteratorSourceReaderBase.java: ## @@ -0,0 +1,187 @@ +/* + * Licensed to the Apache Software

[jira] [Closed] (FLINK-29645) BatchExecutionKeyedStateBackend is using incorrect ExecutionConfig when creating serializer

2022-10-17 Thread Dawid Wysakowicz (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Wysakowicz closed FLINK-29645. Fix Version/s: 1.16.0 1.17.0 1.15.3

[GitHub] [flink] dawidwys merged pull request #21082: [FLINK-29645] BatchExecutionKeyedStateBackend is using incorrect ExecutionConfig when creating serializer

2022-10-17 Thread GitBox
dawidwys merged PR #21082: URL: https://github.com/apache/flink/pull/21082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (FLINK-29670) Add CRD compatibility check against 1.2.0

2022-10-17 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-29670: -- Summary: Add CRD compatibility check against 1.2.0 Key: FLINK-29670 URL: https://issues.apache.org/jira/browse/FLINK-29670 Project: Flink Issue Type:

[jira] (FLINK-29545) kafka consuming stop when trigger first checkpoint

2022-10-17 Thread xiaogang zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29545 ] xiaogang zhou deleted comment on FLINK-29545: --- was (Author: zhoujira86): [~pnowojski]  [https://github.com/apache/flink/pull/21080] Hi Master, I have modified the commit a little bit.

[GitHub] [flink] zhougit86 commented on pull request #21080: [FLINK-29545][runtime] add netty idle state handler

2022-10-17 Thread GitBox
zhougit86 commented on PR #21080: URL: https://github.com/apache/flink/pull/21080#issuecomment-1281021051 > Could you elaborate more on the motivation behind this? I'm not sure how useful is the idle information provided by this PR. From one hand, if there is some data waiting to be

[jira] [Commented] (FLINK-29655) Split Flink CRD from flink-kubernates-operator module

2022-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618949#comment-17618949 ] Márton Balassi commented on FLINK-29655: Makes sense, this way you could also make the

[jira] [Assigned] (FLINK-29655) Split Flink CRD from flink-kubernates-operator module

2022-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-29655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi reassigned FLINK-29655: -- Assignee: Zhenqiu Huang > Split Flink CRD from flink-kubernates-operator module >

[jira] [Comment Edited] (FLINK-29655) Split Flink CRD from flink-kubernates-operator module

2022-10-17 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618947#comment-17618947 ] Zhenqiu Huang edited comment on FLINK-29655 at 10/17/22 2:58 PM: -

[jira] [Commented] (FLINK-29655) Split Flink CRD from flink-kubernates-operator module

2022-10-17 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17618947#comment-17618947 ] Zhenqiu Huang commented on FLINK-29655: --- [~gyfora] I feel flink-kubernetes-operator-api is more

[GitHub] [flink] flinkbot commented on pull request #21088: [FLINK-29582][state-processor] Relax 1+ operator requirement

2022-10-17 Thread GitBox
flinkbot commented on PR #21088: URL: https://github.com/apache/flink/pull/21088#issuecomment-1280994587 ## CI report: * d88bda59f249ad786262ba0c267041994ab463e6 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-29582) SavepointWriter should be usable without any transformation

2022-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29582: --- Labels: pull-request-available (was: ) > SavepointWriter should be usable without any

[GitHub] [flink] zentol merged pull request #21087: [hotfix] Use getParameterCount rather than getParameterTypes().length

2022-10-17 Thread GitBox
zentol merged PR #21087: URL: https://github.com/apache/flink/pull/21087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zentol opened a new pull request, #21088: [FLINK-29582][state-processor] Relax 1+ operator requirement

2022-10-17 Thread GitBox
zentol opened a new pull request, #21088: URL: https://github.com/apache/flink/pull/21088 Based on #21085. The SavepointWriter previously had to enforce that the user provides at least 1 operator because we used them to get access to the execution environment. No operator -> no

  1   2   3   >