[jira] [Closed] (FLINK-30029) Notice/ShadeParser parse version/classifier separately

2022-11-17 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-30029. Resolution: Fixed master: f734fa717a818968ad811e7ccd88f8aa09d50663 > Notice/ShadeParser

[GitHub] [flink] zentol merged pull request #21336: [FLINK-30029][ci] Parse version/classifier separately

2022-11-17 Thread GitBox
zentol merged PR #21336: URL: https://github.com/apache/flink/pull/21336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025564871 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/enumerator/splitter/MongoSplitters.java: ## @@ -0,0 +1,110 @@ +/* + *

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025554030 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/MongoDynamicTableSource.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to

[jira] [Updated] (FLINK-29939) Add metrics for Kubernetes Client Response 5xx count and rate

2022-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29939: --- Labels: pull-request-available (was: ) > Add metrics for Kubernetes Client Response 5xx

[GitHub] [flink-kubernetes-operator] jiangzho opened a new pull request, #445: [FLINK-29939]Add metrics for Kubernetes Client Response 5xx count and…

2022-11-17 Thread GitBox
jiangzho opened a new pull request, #445: URL: https://github.com/apache/flink-kubernetes-operator/pull/445 ## What is the purpose of the change This PR adds metrics of `count` and `rate` for Kubernetes Client HTTP response code 1xx / 2xx / 3xx / 4xx / 5xx. It also

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025533564 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/common/utils/MongoUtils.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025508153 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/common/utils/MongoUtils.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025492765 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/common/utils/MongoUtils.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025492765 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/common/utils/MongoUtils.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025484017 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/common/utils/MongoUtils.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025476043 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/common/utils/MongoUtils.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the

[GitHub] [flink] ericxiao251 commented on pull request #21077: [FLINK-29498] Add Scala Async Retry Strategies and ResultPredicates Helper Classes

2022-11-17 Thread GitBox
ericxiao251 commented on PR #21077: URL: https://github.com/apache/flink/pull/21077#issuecomment-1318864487 @gaoyunhaii Thank you so much for helping me with my first ever open source contribution :)! -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink-web] fapaul commented on a diff in pull request #581: Add 1.15.3 release

2022-11-17 Thread GitBox
fapaul commented on code in PR #581: URL: https://github.com/apache/flink-web/pull/581#discussion_r1025373235 ## _posts/2022-11-10-release-1.15.3.md: ## @@ -0,0 +1,185 @@ +--- +layout: post +title: "Apache Flink 1.15.3 Release Announcement" +date: 2022-11-10T22:00:00.000Z

[GitHub] [flink-web] MartijnVisser commented on a diff in pull request #581: Add 1.15.3 release

2022-11-17 Thread GitBox
MartijnVisser commented on code in PR #581: URL: https://github.com/apache/flink-web/pull/581#discussion_r1025366133 ## _posts/2022-11-10-release-1.15.3.md: ## @@ -0,0 +1,185 @@ +--- +layout: post +title: "Apache Flink 1.15.3 Release Announcement" +date:

[jira] [Commented] (FLINK-30073) Managed memory can be wasted if RocksDB memory is fixed-per-slot

2022-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635403#comment-17635403 ] Roman Khachatryan commented on FLINK-30073: --- According to the ticket (FLINK-14484), the

[jira] [Commented] (FLINK-26088) Add Elasticsearch 8.0 support

2022-11-17 Thread zhenzhenhua (Jira)
[ https://issues.apache.org/jira/browse/FLINK-26088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635399#comment-17635399 ] zhenzhenhua commented on FLINK-26088: - [~martijnvisser] The current flink-connector-elasticsearch

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21339: [FLINK-30024][tests] Build local test KDC docker image

2022-11-17 Thread GitBox
gaborgsomogyi commented on code in PR #21339: URL: https://github.com/apache/flink/pull/21339#discussion_r1025324405 ## flink-end-to-end-tests/test-scripts/common_yarn_docker.sh: ## @@ -100,13 +100,10 @@ function build_image() { echo "Pre-downloading Hadoop tarball"

[GitHub] [flink] gaborgsomogyi commented on a diff in pull request #21339: [FLINK-30024][tests] Build local test KDC docker image

2022-11-17 Thread GitBox
gaborgsomogyi commented on code in PR #21339: URL: https://github.com/apache/flink/pull/21339#discussion_r1025316443 ## flink-end-to-end-tests/test-scripts/common_yarn_docker.sh: ## @@ -100,13 +100,10 @@ function build_image() { echo "Pre-downloading Hadoop tarball"

[GitHub] [flink] MartijnVisser commented on pull request #21254: Update docker.md

2022-11-17 Thread GitBox
MartijnVisser commented on PR #21254: URL: https://github.com/apache/flink/pull/21254#issuecomment-1318771863 > Did you test on v1.16? @dianfu @HuangXingBo I'm assuming we've done that, but you're the Python experts :) -- This is an automated message from the Apache Git Service.

[jira] [Closed] (FLINK-30067) DelegatingConfiguration#set should return itself

2022-11-17 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-30067. Resolution: Fixed master: 38c6a4bb8af37f5a05e9d57d9787f0b25334abbf >

[GitHub] [flink] zentol merged pull request #21340: [FLINK-30067][conf] DelegatingConfiguration#set returns itself

2022-11-17 Thread GitBox
zentol merged PR #21340: URL: https://github.com/apache/flink/pull/21340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-mongodb] zentol commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025246587 ## flink-connector-mongodb/src/test/java/org/apache/flink/connector/mongodb/source/splitter/MongoShardedSplitterTest.java: ## @@ -0,0 +1,145 @@ +/* + *

[GitHub] [flink-connector-mongodb] zentol commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1025027441 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/common/utils/MongoUtils.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache

[GitHub] [flink] MartijnVisser commented on a diff in pull request #21339: [FLINK-30024][tests] Build local test KDC docker image

2022-11-17 Thread GitBox
MartijnVisser commented on code in PR #21339: URL: https://github.com/apache/flink/pull/21339#discussion_r1025282921 ## flink-end-to-end-tests/test-scripts/common_yarn_docker.sh: ## @@ -100,13 +100,10 @@ function build_image() { echo "Pre-downloading Hadoop tarball"

[GitHub] [flink] wanglijie95 commented on pull request #20097: [FLINK-28284][Connectors/Jdbc] Add JdbcSink with new format

2022-11-17 Thread GitBox
wanglijie95 commented on PR #20097: URL: https://github.com/apache/flink/pull/20097#issuecomment-1318737459 @MartijnVisser I started. I may still need one more week to complete the first round review. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [flink] reswqa commented on pull request #21331: [FLINK-29639] Print resourceId of remote taskmanager when encounter transport exception.

2022-11-17 Thread GitBox
reswqa commented on PR #21331: URL: https://github.com/apache/flink/pull/21331#issuecomment-1318723729 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025247156 ## flink-sql-connector-opensearch/pom.xml: ## @@ -0,0 +1,159 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] gaborgsomogyi commented on pull request #21128: [FLINK-29710] Bump minimum supported Hadoop version to 2.10.2

2022-11-17 Thread GitBox
gaborgsomogyi commented on PR #21128: URL: https://github.com/apache/flink/pull/21128#issuecomment-1318699210 @MartijnVisser I was digging why the YARN tests are failing and I think I've found one issue :) Namely I have the feeling that the

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025247156 ## flink-sql-connector-opensearch/pom.xml: ## @@ -0,0 +1,159 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-24273) Relocate io.fabric8 dependency

2022-11-17 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-24273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635371#comment-17635371 ] Robert Metzger commented on FLINK-24273: +1 to fix this. I'm facing a similar issue when trying

[GitHub] [flink] rmetzger commented on pull request #17262: [FLINK-24273][kubernetes] Relocate io.fabric8 dependency.

2022-11-17 Thread GitBox
rmetzger commented on PR #17262: URL: https://github.com/apache/flink/pull/17262#issuecomment-1318695643 It seems that the issue in the maven shade plugin has been fixed: https://github.com/apache/maven-shade-plugin/pull/150 / https://issues.apache.org/jira/browse/MSHADE-425 in 3.4.0. We

[GitHub] [flink] zhuzhurk commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-17 Thread GitBox
zhuzhurk commented on PR #21197: URL: https://github.com/apache/flink/pull/21197#issuecomment-1318684788 > @zhuzhurk I checked with https://issues.apache.org/jira/browse/FLINK-21000 some question: > > 1. this issue is just for the source coordinator, it's not a common way for every

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025226180 ## pom.xml: ## @@ -327,6 +327,12 @@ under the License. + +

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025222309 ## flink-connector-opensearch-e2e-tests/pom.xml: ## @@ -0,0 +1,190 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025220389 ## flink-connector-opensearch-e2e-tests/pom.xml: ## @@ -0,0 +1,190 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Updated] (FLINK-21000) set MetricGroup in SourceCoordinatorContext

2022-11-17 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-21000: Labels: (was: auto-deprioritized-major auto-deprioritized-minor stale-assigned) > set MetricGroup in

[GitHub] [flink] lincoln-lil commented on a diff in pull request #20745: [FLINK-28988] Don't push above filters down into the right table for temporal join

2022-11-17 Thread GitBox
lincoln-lil commented on code in PR #20745: URL: https://github.com/apache/flink/pull/20745#discussion_r1025213523 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java: ## @@ -128,7 +129,9 @@ protected void

[GitHub] [flink-connector-opensearch] zentol commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025211246 ## flink-connector-opensearch-e2e-tests/pom.xml: ## @@ -0,0 +1,190 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025210263 ## flink-sql-connector-opensearch/pom.xml: ## @@ -0,0 +1,159 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink-connector-mongodb] zentol commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2022-11-17 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1022827705 ## flink-connector-mongodb-e2e-tests/pom.xml: ## @@ -0,0 +1,157 @@ + + +http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd; +

[GitHub] [flink-connector-opensearch] zentol commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025205947 ## pom.xml: ## @@ -327,6 +327,12 @@ under the License. + +

[GitHub] [flink] snuyanzin commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2022-11-17 Thread GitBox
snuyanzin commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1318656114 As I see there are some conflicts could you please resolve them? Also it seems build failed because of `spotless` issues could you please run `mvn spotless:apply` before commit. It

[GitHub] [flink] gaborgsomogyi commented on pull request #21339: [FLINK-30024][tests] Build local test KDC docker image

2022-11-17 Thread GitBox
gaborgsomogyi commented on PR #21339: URL: https://github.com/apache/flink/pull/21339#issuecomment-1318652666 @MartijnVisser The tests passed. If you think the PR is good to go we can merge it and retry https://github.com/apache/flink/pull/21128 at top of this. -- This is an automated

[GitHub] [flink] xintongsong commented on pull request #21331: [FLINK-29639] Print resourceId of remote taskmanager when encounter transport exception.

2022-11-17 Thread GitBox
xintongsong commented on PR #21331: URL: https://github.com/apache/flink/pull/21331#issuecomment-1318634320 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-30069) Expected prune behavior for matches with same priority

2022-11-17 Thread Juntao Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juntao Hu updated FLINK-30069: -- Description: When a pattern produces several matches with same priority, is it the expected behavior

[jira] [Updated] (FLINK-30069) Expected prune behavior for matches with same priority

2022-11-17 Thread Juntao Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Juntao Hu updated FLINK-30069: -- Description: When a pattern produces several matches with same priority, is it the expected behavior

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #444: [hotfix][doc] keep the yaml format consistent

2022-11-17 Thread GitBox
gyfora merged PR #444: URL: https://github.com/apache/flink-kubernetes-operator/pull/444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025147669 ## pom.xml: ## @@ -327,6 +327,12 @@ under the License. + +

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
reta commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025146467 ## flink-connector-opensearch-e2e-tests/pom.xml: ## @@ -0,0 +1,190 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-29801) OperatorCoordinator need open the way to operate metricGroup interface

2022-11-17 Thread yuemeng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635341#comment-17635341 ] yuemeng commented on FLINK-29801: - [~ruanhang1993] [~zhuzh]  Firstly, thanks a lot for your reply The

[GitHub] [flink-table-store] zjureel commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-17 Thread GitBox
zjureel commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1025135334 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaFieldTypeExtractor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the

[GitHub] [flink-connector-opensearch] zentol commented on a diff in pull request #1: [FLINK-25756] [connectors/opensearch] Dedicated Opensearch connectors

2022-11-17 Thread GitBox
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-opensearch/pull/1#discussion_r1025102141 ## flink-connector-opensearch-e2e-tests/pom.xml: ## @@ -0,0 +1,190 @@ + + +http://maven.apache.org/POM/4.0.0; +

[jira] [Commented] (FLINK-30048) MapState.remove(UK key) is better to return the old value.

2022-11-17 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635320#comment-17635320 ] Hangxiang Yu commented on FLINK-30048: -- For RocksDBStateBackend, 'Remove' just add a delete flag to

[jira] [Closed] (FLINK-30074) ES e2e tests are never run

2022-11-17 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-30074. Fix Version/s: (was: elasticsearch-4.0.0) (was:

[jira] [Created] (FLINK-30074) ES e2e tests are never run

2022-11-17 Thread Chesnay Schepler (Jira)
Chesnay Schepler created FLINK-30074: Summary: ES e2e tests are never run Key: FLINK-30074 URL: https://issues.apache.org/jira/browse/FLINK-30074 Project: Flink Issue Type: Technical

[GitHub] [flink-table-store] JingsongLi commented on pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-17 Thread GitBox
JingsongLi commented on PR #376: URL: https://github.com/apache/flink-table-store/pull/376#issuecomment-1318530861 Thanks for the update. We can improve `Extractor` a little bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #376: [FLINK-27843] Schema evolution for data file meta

2022-11-17 Thread GitBox
JingsongLi commented on code in PR #376: URL: https://github.com/apache/flink-table-store/pull/376#discussion_r1025098163 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/schema/SchemaFieldTypeExtractor.java: ## @@ -0,0 +1,43 @@ +/* + * Licensed to the

[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-17 Thread GitBox
JerryYue-M commented on PR #21197: URL: https://github.com/apache/flink/pull/21197#issuecomment-1318528698 @zhuzhurk I checked with https://issues.apache.org/jira/browse/FLINK-21000 some question: 1. this issue is just for the source coordinator, it's not a common way for every

[GitHub] [flink] shuiqiangchen commented on a diff in pull request #20745: [FLINK-28988] Don't push above filters down into the right table for temporal join

2022-11-17 Thread GitBox
shuiqiangchen commented on code in PR #20745: URL: https://github.com/apache/flink/pull/20745#discussion_r1025086254 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/FlinkFilterJoinRule.java: ## @@ -128,7 +129,9 @@ protected

[GitHub] [flink] JerryYue-M commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-17 Thread GitBox
JerryYue-M commented on PR #21197: URL: https://github.com/apache/flink/pull/21197#issuecomment-1318514095 @zhuzhurk thanks for reply I will take a talk with @arunans23 later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] zhuzhurk commented on pull request #21197: [FLINK-29801] OperatorCoordinator need open the way to operate metric…

2022-11-17 Thread GitBox
zhuzhurk commented on PR #21197: URL: https://github.com/apache/flink/pull/21197#issuecomment-1318483995 Hi @JerryYue-M, I had a discussion with @PatrickRen offline and got quite some feedbacks. The conclusions is that, to better support future operator coordinator metrics, we need a

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #386: [FLINK-30071] Throw exception at compile time when sequence field does not exist

2022-11-17 Thread GitBox
JingsongLi commented on code in PR #386: URL: https://github.com/apache/flink-table-store/pull/386#discussion_r1025060627 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/table/ChangelogWithKeyFileStoreTable.java: ## @@ -77,6 +78,11 @@ public class

[GitHub] [flink] HuangXingBo commented on pull request #21332: [FLINK-21223][python] Support to specify the output types of Python UDFs via string

2022-11-17 Thread GitBox
HuangXingBo commented on PR #21332: URL: https://github.com/apache/flink/pull/21332#issuecomment-1318477532 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] flinkbot commented on pull request #21342: [FLINK-29817][python] Fix the metadata in PyFlink requirements

2022-11-17 Thread GitBox
flinkbot commented on PR #21342: URL: https://github.com/apache/flink/pull/21342#issuecomment-1318471505 ## CI report: * b5aa3ef2ad3ad74e9cd787dd82f95e0270a3e83b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-30073) Managed memory can be wasted if RocksDB memory is fixed-per-slot

2022-11-17 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635294#comment-17635294 ] Xintong Song commented on FLINK-30073: -- I'd consider this more a design limitation, rather than a

[jira] [Comment Edited] (FLINK-29801) OperatorCoordinator need open the way to operate metricGroup interface

2022-11-17 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635287#comment-17635287 ] Hang Ruan edited comment on FLINK-29801 at 11/17/22 11:02 AM: -- Hi,

[jira] [Commented] (FLINK-21000) set MetricGroup in SourceCoordinatorContext

2022-11-17 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635288#comment-17635288 ] Hang Ruan commented on FLINK-21000: --- Hi, [~kbendick] , Sorry for my late response. I will continue to

[jira] [Comment Edited] (FLINK-21000) set MetricGroup in SourceCoordinatorContext

2022-11-17 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-21000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635288#comment-17635288 ] Hang Ruan edited comment on FLINK-21000 at 11/17/22 10:59 AM: -- Hi,

[jira] [Commented] (FLINK-29801) OperatorCoordinator need open the way to operate metricGroup interface

2022-11-17 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635287#comment-17635287 ] Hang Ruan commented on FLINK-29801: --- Hi, [~MengYue] , I may rely on this feature to accomplish

[jira] [Updated] (FLINK-29817) Published metadata for apache-flink in pypi are inconsistent and causes poetry to fail

2022-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-29817: --- Labels: pull-request-available (was: ) > Published metadata for apache-flink in pypi are

[GitHub] [flink] HuangXingBo opened a new pull request, #21342: [FLINK-29817][python] Fix the metadata in PyFlink requirements

2022-11-17 Thread GitBox
HuangXingBo opened a new pull request, #21342: URL: https://github.com/apache/flink/pull/21342 ## What is the purpose of the change *This pull request will fix the metadata in PyFlink requirements* ## Brief change log - *Update the metadata of install_requirement

[GitHub] [flink] xintongsong commented on a diff in pull request #21233: [FLINK-29870] [ResourceManager]Split ResourceNotEnoughNotifier from ResourceActions

2022-11-17 Thread GitBox
xintongsong commented on code in PR #21233: URL: https://github.com/apache/flink/pull/21233#discussion_r1024913334 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/ResourceNotEnoughNotifier.java: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-28695) Fail to send partition request to restarted taskmanager

2022-11-17 Thread nobleyd (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635285#comment-17635285 ] nobleyd commented on FLINK-28695: - We also encounter this problem in production, and task failures will

[jira] [Closed] (FLINK-30055) Move existing Cassandra connector code from Flink repo to dedicated Cassandra repo

2022-11-17 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler closed FLINK-30055. Resolution: Duplicate > Move existing Cassandra connector code from Flink repo to

[jira] [Updated] (FLINK-29982) Move cassandra connector to dedicated repo

2022-11-17 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chesnay Schepler updated FLINK-29982: - Parent: FLINK-30050 Issue Type: Sub-task (was: Technical Debt) > Move

[jira] [Updated] (FLINK-30071) Throw exception at compile time when sequence field does not exist

2022-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30071: --- Labels: pull-request-available (was: ) > Throw exception at compile time when sequence

[GitHub] [flink-table-store] LadyForest opened a new pull request, #386: [FLINK-30071] Throw exception at compile time when sequence field does not exist

2022-11-17 Thread GitBox
LadyForest opened a new pull request, #386: URL: https://github.com/apache/flink-table-store/pull/386 This trivial improvement performs the sequence field existence check at compile time rather than runtime. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Updated] (FLINK-30073) Managed memory can be wasted if RocksDB memory is fixed-per-slot

2022-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-30073: -- Description: When

[jira] [Commented] (FLINK-30073) Managed memory can be wasted if RocksDB memory is fixed-per-slot

2022-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635278#comment-17635278 ] Roman Khachatryan commented on FLINK-30073: --- [~xtsong], can you please confirm that? >

[jira] [Comment Edited] (FLINK-30048) MapState.remove(UK key) is better to return the old value.

2022-11-17 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635241#comment-17635241 ] Lijie Wang edited comment on FLINK-30048 at 11/17/22 10:31 AM: --- I think it

[jira] [Updated] (FLINK-30073) Managed memory can be wasted if RocksDB memory is fixed-per-slot

2022-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-30073: -- Description: When

[jira] [Created] (FLINK-30073) Managed memory can be wasted if rocksdb memory is fixed-per-slot

2022-11-17 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-30073: - Summary: Managed memory can be wasted if rocksdb memory is fixed-per-slot Key: FLINK-30073 URL: https://issues.apache.org/jira/browse/FLINK-30073 Project:

[jira] [Updated] (FLINK-30073) Managed memory can be wasted if RocksDB memory is fixed-per-slot

2022-11-17 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Khachatryan updated FLINK-30073: -- Summary: Managed memory can be wasted if RocksDB memory is fixed-per-slot (was:

[jira] [Closed] (FLINK-29975) Let hybrid full spilling strategy supports partition reuse

2022-11-17 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-29975. Fix Version/s: 1.17.0 Resolution: Done master (1.17):

[jira] [Created] (FLINK-30072) Cannot assign instance of SerializedLambda to field KeyGroupStreamPartitioner.keySelector

2022-11-17 Thread Nico Kruber (Jira)
Nico Kruber created FLINK-30072: --- Summary: Cannot assign instance of SerializedLambda to field KeyGroupStreamPartitioner.keySelector Key: FLINK-30072 URL: https://issues.apache.org/jira/browse/FLINK-30072

[GitHub] [flink] xintongsong closed pull request #21284: [FLINK-29975] Let hybrid full spilling strategy supports partition reuse

2022-11-17 Thread GitBox
xintongsong closed pull request #21284: [FLINK-29975] Let hybrid full spilling strategy supports partition reuse URL: https://github.com/apache/flink/pull/21284 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Created] (FLINK-30071) Throw exception at compile time when sequence field does not exist

2022-11-17 Thread Jane Chan (Jira)
Jane Chan created FLINK-30071: - Summary: Throw exception at compile time when sequence field does not exist Key: FLINK-30071 URL: https://issues.apache.org/jira/browse/FLINK-30071 Project: Flink

[jira] [Commented] (FLINK-29884) Flaky test failure in finegrained_resource_management/SortMergeResultPartitionTest.testRelease

2022-11-17 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635272#comment-17635272 ] Yingjie Cao commented on FLINK-29884: - I will try to reproduce it and will update if any progress.

[jira] [Commented] (FLINK-29984) Flink Histogram not emitting min and max when using Prometheus Reporter

2022-11-17 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635271#comment-17635271 ] Xintong Song commented on FLINK-29984: -- [~qingwei91], You can add a config option in

[GitHub] [flink] Stephen0421 commented on pull request #21334: [FLINK-29971][HBase] Fix hbase sink will lose data at some extreme case.

2022-11-17 Thread GitBox
Stephen0421 commented on PR #21334: URL: https://github.com/apache/flink/pull/21334#issuecomment-1318388540 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-30014) Fix the NPE from aggregate util

2022-11-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30014: --- Labels: pull-request-available (was: ) > Fix the NPE from aggregate util >

[jira] [Comment Edited] (FLINK-29572) Flink Task Manager skip loopback interface for resource manager registration

2022-11-17 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635269#comment-17635269 ] Yun Gao edited comment on FLINK-29572 at 11/17/22 10:04 AM: Hi all, very

[GitHub] [flink-ml] yunfengzhou-hub opened a new pull request, #177: [FLINK-30014][hotfix] ensure saving non-null value in aggregate util function state

2022-11-17 Thread GitBox
yunfengzhou-hub opened a new pull request, #177: URL: https://github.com/apache/flink-ml/pull/177 ## What is the purpose of the change This PR fixes the NPE that would possibly be thrown when using `DataStreamUtils.aggregate`. ## Brief change log *(for example:)* -

[jira] [Commented] (FLINK-30068) Allow users to configure what to do with errors while committing transactions during recovery in KafkaSink

2022-11-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635270#comment-17635270 ] Martijn Visser commented on FLINK-30068: [~renqs] It's probably worthwhile to pick this up

[jira] [Closed] (FLINK-29572) Flink Task Manager skip loopback interface for resource manager registration

2022-11-17 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao closed FLINK-29572. --- Resolution: Duplicate > Flink Task Manager skip loopback interface for resource manager registration >

[jira] [Commented] (FLINK-29572) Flink Task Manager skip loopback interface for resource manager registration

2022-11-17 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635269#comment-17635269 ] Yun Gao commented on FLINK-29572: - Hi all, I'll first close this issue for its duplicated. Let's head to

[GitHub] [flink] wsry commented on a diff in pull request #21217: [FLINK-29565]Repair that the web ui log is not highlighted

2022-11-17 Thread GitBox
wsry commented on code in PR #21217: URL: https://github.com/apache/flink/pull/21217#discussion_r1024983871 ## flink-runtime/src/main/java/org/apache/flink/runtime/util/EnvironmentInformation.java: ## @@ -469,7 +469,9 @@ public static void logEnvironmentInfo( }

[jira] [Commented] (FLINK-29610) Infinite timeout is used in SavepointHandlers and CheckpointTriggerHandler calls to RestfulGateway

2022-11-17 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635265#comment-17635265 ] Yun Gao commented on FLINK-29610: - Thanks [~Jiale] for the PR! I'll have a look > Infinite timeout is

[jira] [Commented] (FLINK-29845) ThroughputCalculator throws java.lang.IllegalArgumentException: Time should be non negative under very low throughput cluster

2022-11-17 Thread Yingjie Cao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17635261#comment-17635261 ] Yingjie Cao commented on FLINK-29845: - I think it is not guaranteed that System.currentTimeMillis is

<    1   2   3   >