[GitHub] [flink] Myasuka commented on a diff in pull request #21498: [FLINK-30392] Replace default thread dump depth to 24

2022-12-29 Thread GitBox
Myasuka commented on code in PR #21498: URL: https://github.com/apache/flink/pull/21498#discussion_r1059279745 ## docs/layouts/shortcodes/generated/cluster_configuration.html: ## @@ -70,7 +70,7 @@ cluster.thread-dump.stacktrace-max-depth -

[jira] [Resolved] (FLINK-30468) The SortOrder of BusyRatio should be descend by default

2022-12-29 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-30468. -- Fix Version/s: 1.17.0 Resolution: Fixed merged in master:

[GitHub] [flink] Myasuka merged pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-29 Thread GitBox
Myasuka merged PR #21540: URL: https://github.com/apache/flink/pull/21540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] Myasuka commented on pull request #21540: [FLINK-30468][web] Change the SortOrder of BusyRatio to descend by default

2022-12-29 Thread GitBox
Myasuka commented on PR #21540: URL: https://github.com/apache/flink/pull/21540#issuecomment-136765 @yuchen-ecnu thanks for the review, merging... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] yuchen-ecnu commented on a diff in pull request #21498: [FLINK-30392] Replace default thread dump depth to 24

2022-12-29 Thread GitBox
yuchen-ecnu commented on code in PR #21498: URL: https://github.com/apache/flink/pull/21498#discussion_r1059278748 ## docs/layouts/shortcodes/generated/cluster_configuration.html: ## @@ -70,7 +70,7 @@ cluster.thread-dump.stacktrace-max-depth -

[jira] [Updated] (FLINK-30533) SourceOperator#emitNext() should push records to DataOutput in a while loop

2022-12-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30533: - Description: Currently, each invocation of SourceOperator#emitNext() push at most one record to the

[jira] [Updated] (FLINK-30531) Reduce operator chain call stack depth

2022-12-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30531: - Description: Benchmark results show that Flink time to execute simple programs is more than 3X slower

[jira] [Updated] (FLINK-30533) SourceOperator#emitNext() should push records to DataOutput in a while loop

2022-12-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30533: - Description: Currently, each invocation of SourceOperator#emitNext() push at most one record to the

[jira] [Updated] (FLINK-30533) SourceOperator#emitNext() should push records to DataOutput in a while loop

2022-12-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30533: - Summary: SourceOperator#emitNext() should push records to DataOutput in a while loop (was:

[jira] [Updated] (FLINK-30533) IteratorSourceReaderBase#pollNext() should push records to ReaderOutput in a while loop

2022-12-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30533: - Description: Currently, each invocation of IteratorSourceReaderBase#pollNext() push at most one record

[GitHub] [flink] Mulavar commented on pull request #21545: [FLINK-30396][table]make alias hint take effect in correlate

2022-12-29 Thread GitBox
Mulavar commented on PR #21545: URL: https://github.com/apache/flink/pull/21545#issuecomment-1367773355 @godfreyhe hi, could u check this pr again? I've add a new test case to verify the change. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink-ml] Fanoid commented on pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-29 Thread GitBox
Fanoid commented on PR #191: URL: https://github.com/apache/flink-ml/pull/191#issuecomment-1367755587 @jiangxin369 Thanks for you valuable comments. I've updated PR based on your suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-29 Thread GitBox
Fanoid commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1059263315 ## docs/content/docs/operators/feature/minhashlsh.md: ## @@ -0,0 +1,276 @@ +--- +title: "MinHash LSH" +weight: 1 +type: docs +aliases: +-

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-29 Thread GitBox
Fanoid commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1059263123 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/lsh/LSHParams.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-29 Thread GitBox
Fanoid commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1059262975 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/lsh/LSHModel.java: ## @@ -0,0 +1,427 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-29 Thread GitBox
Fanoid commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1059261844 ## flink-ml-lib/src/main/java/org/apache/flink/ml/feature/lsh/LSHParams.java: ## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-29 Thread GitBox
Fanoid commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1059261634 ## docs/content/docs/operators/feature/minhashlsh.md: ## @@ -0,0 +1,276 @@ +--- +title: "MinHash LSH" +weight: 1 +type: docs +aliases: +-

[GitHub] [flink-ml] Fanoid commented on a diff in pull request #191: [FLINK-30401] Add Estimator and Transformer for MinHashLSH

2022-12-29 Thread GitBox
Fanoid commented on code in PR #191: URL: https://github.com/apache/flink-ml/pull/191#discussion_r1059261237 ## flink-ml-python/pyflink/ml/lib/feature/lsh.py: ## @@ -0,0 +1,191 @@ + +# Licensed to

[jira] [Resolved] (FLINK-30345) Improve the serializer performace of state change of changelog

2022-12-29 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-30345. -- Fix Version/s: 1.17.0 Resolution: Fixed > Improve the serializer performace of state change of

[jira] [Commented] (FLINK-30345) Improve the serializer performace of state change of changelog

2022-12-29 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17653030#comment-17653030 ] Yun Tang commented on FLINK-30345: -- merged in master: a5c12c5589b92d5e8b22a4aa952a0c06543424a3 >

[GitHub] [flink] Myasuka merged pull request #21468: [FLINK-30345][state/changelog] Avoid using sync DataOutputViewStreamWrapper to serialize records to changelog

2022-12-29 Thread GitBox
Myasuka merged PR #21468: URL: https://github.com/apache/flink/pull/21468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-30533) IteratorSourceReaderBase#pollNext() should push records to ReaderOutput in a while loop

2022-12-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30533: - Description: Currently, each invocation of IteratorSourceReaderBase#pollNext() push at most one record

[GitHub] [flink] LadyForest commented on a diff in pull request #21571: [FLINK-22317][table] Support DROP column/constraint/watermark for ALTER TABLE statement

2022-12-29 Thread GitBox
LadyForest commented on code in PR #21571: URL: https://github.com/apache/flink/pull/21571#discussion_r1059237170 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -604,24 +703,90 @@ private void

[GitHub] [flink] luoyuxia commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1059237050 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectAggITCase.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] [flink] luoyuxia commented on a diff in pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21401: URL: https://github.com/apache/flink/pull/21401#discussion_r1059237050 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveDialectAggITCase.java: ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache

[GitHub] [flink] fsk119 commented on pull request #21566: [FLINK-30495][table-api] Introduce TableChange to represent ADD change

2022-12-29 Thread GitBox
fsk119 commented on PR #21566: URL: https://github.com/apache/flink/pull/21566#issuecomment-1367709296 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-30531) Reduce operator chain call stack depth

2022-12-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30531: - Description: Benchmark results show that Flink time to execute simple programs is more than 3X slower

[GitHub] [flink] yangjunhan commented on pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-29 Thread GitBox
yangjunhan commented on PR #21447: URL: https://github.com/apache/flink/pull/21447#issuecomment-1367708053 Hi, @1996fanrui . Sorry for the late review. I left a few comments to be improved regarding the last commit (ui). The rest looks good to me :) -- This is an automated message from

[GitHub] [flink] yangjunhan commented on a diff in pull request #21447: [FLINK-30185] Provide the flame graph to the subtask level

2022-12-29 Thread GitBox
yangjunhan commented on code in PR #21447: URL: https://github.com/apache/flink/pull/21447#discussion_r1059229187 ## flink-runtime-web/web-dashboard/src/app/pages/job/overview/flamegraph/job-overview-drawer-flamegraph.component.ts: ## @@ -100,9 +118,38 @@ export class

[jira] [Updated] (FLINK-30531) Reduce operator chain call stack depth

2022-12-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30531: - Description: Benchmark results show that Flink time to execute simple programs is more than 3X slower

[GitHub] [flink] fsk119 commented on a diff in pull request #21566: [FLINK-30495][table-api] Introduce TableChange to represent ADD change

2022-12-29 Thread GitBox
fsk119 commented on code in PR #21566: URL: https://github.com/apache/flink/pull/21566#discussion_r1059226965 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/utils/OperationConverterUtils.java: ## @@ -106,13 +117,17 @@ public static Operation

[jira] [Commented] (FLINK-29718) Supports hive sum function by native implementation

2022-12-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652998#comment-17652998 ] Jing Zhang commented on FLINK-29718: Merged in master: 4c0f5e63775074c87f3a834b22d6c9eb296721e6 >

[jira] [Resolved] (FLINK-29718) Supports hive sum function by native implementation

2022-12-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang resolved FLINK-29718. Assignee: dalongliu Resolution: Fixed > Supports hive sum function by native implementation

[jira] [Closed] (FLINK-29718) Supports hive sum function by native implementation

2022-12-29 Thread Jing Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhang closed FLINK-29718. -- > Supports hive sum function by native implementation >

[GitHub] [flink] beyond1920 closed pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation

2022-12-29 Thread GitBox
beyond1920 closed pull request #21401: [FLINK-29718][table] Supports hive sum function by native implementation URL: https://github.com/apache/flink/pull/21401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] fsk119 commented on a diff in pull request #21571: [FLINK-22317][table] Support DROP column/constraint/watermark for ALTER TABLE statement

2022-12-29 Thread GitBox
fsk119 commented on code in PR #21571: URL: https://github.com/apache/flink/pull/21571#discussion_r105976 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -115,77 +120,135 @@ public Schema

[GitHub] [flink] lsyldliu commented on a diff in pull request #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of columnar

2022-12-29 Thread GitBox
lsyldliu commented on code in PR #21563: URL: https://github.com/apache/flink/pull/21563#discussion_r1059217459 ## flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/HiveTableSourceITCase.java: ## @@ -447,6 +447,51 @@ public void

[GitHub] [flink-table-store] JingsongLi merged pull request #448: [hotfix] Remove incorrect check in FullChangelogStoreSinkWrite

2022-12-29 Thread GitBox
JingsongLi merged PR #448: URL: https://github.com/apache/flink-table-store/pull/448 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] LadyForest commented on a diff in pull request #21571: [FLINK-22317][table] Support DROP column/constraint/watermark for ALTER TABLE statement

2022-12-29 Thread GitBox
LadyForest commented on code in PR #21571: URL: https://github.com/apache/flink/pull/21571#discussion_r1059214774 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -115,77 +120,135 @@ public Schema

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1059211731 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactOperator.java: ## @@ -0,0 +1,145 @@ +/* + *

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1059211343 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/CompactFileUtils.java: ## @@ -0,0 +1,119 @@ +/* + *

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1059211343 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/CompactFileUtils.java: ## @@ -0,0 +1,119 @@ +/* + *

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #448: [hotfix] Remove incorrect check in FullChangelogStoreSinkWrite

2022-12-29 Thread GitBox
JingsongLi opened a new pull request, #448: URL: https://github.com/apache/flink-table-store/pull/448 Incorrect check between snapshot id and checkpoint id. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (FLINK-30489) flink-sql-connector-pulsar doesn't shade all dependencies

2022-12-29 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652982#comment-17652982 ] Yufan Sheng commented on FLINK-30489: - We didn't shade these dependencies because these dependencies

[jira] [Comment Edited] (FLINK-30489) flink-sql-connector-pulsar doesn't shade all dependencies

2022-12-29 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652982#comment-17652982 ] Yufan Sheng edited comment on FLINK-30489 at 12/30/22 1:03 AM: --- We didn't

[GitHub] [flink] lindong28 commented on pull request #21576: [FLINK-30533][runtime] IteratorSourceReaderBase#pollNext() should push records to ReaderOutput in a while loop

2022-12-29 Thread GitBox
lindong28 commented on PR #21576: URL: https://github.com/apache/flink/pull/21576#issuecomment-1367668762 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-benchmarks] rkhachatryan commented on pull request #55: [FLINK-27571] Parse "lessisbetter" when detecting regression

2022-12-29 Thread GitBox
rkhachatryan commented on PR #55: URL: https://github.com/apache/flink-benchmarks/pull/55#issuecomment-1367633797 Superseded by #63. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-benchmarks] rkhachatryan closed pull request #55: [FLINK-27571] Parse "lessisbetter" when detecting regression

2022-12-29 Thread GitBox
rkhachatryan closed pull request #55: [FLINK-27571] Parse "lessisbetter" when detecting regression URL: https://github.com/apache/flink-benchmarks/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-benchmarks] rkhachatryan commented on a diff in pull request #63: [FLINK-27571][benchmark] Recognize 'less is better' benchmarks in regression detection script

2022-12-29 Thread GitBox
rkhachatryan commented on code in PR #63: URL: https://github.com/apache/flink-benchmarks/pull/63#discussion_r1059186216 ## update_benchmark_fileds.py: ## @@ -0,0 +1,56 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*-

[jira] [Commented] (FLINK-27571) Recognize "less is better" benchmarks in regression detection script

2022-12-29 Thread Roman Khachatryan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652971#comment-17652971 ] Roman Khachatryan commented on FLINK-27571: --- Thanks for picking this up [~Yanfei Lei]! I'll

[jira] [Commented] (FLINK-30483) Make Avro format support for TIMESTAMP_LTZ

2022-12-29 Thread Mingliang Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652926#comment-17652926 ] Mingliang Liu commented on FLINK-30483: --- Thanks [~jadireddi] ! I started making changes in a local

[GitHub] [flink-connector-opensearch] boring-cyborg[bot] commented on pull request #4: Update Opensearch dependency to version 2.3

2022-12-29 Thread GitBox
boring-cyborg[bot] commented on PR #4: URL: https://github.com/apache/flink-connector-opensearch/pull/4#issuecomment-1367509656 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This

[GitHub] [flink-connector-opensearch] amirhalatzi opened a new pull request, #4: Update Opensearch dependency to version 2.3

2022-12-29 Thread GitBox
amirhalatzi opened a new pull request, #4: URL: https://github.com/apache/flink-connector-opensearch/pull/4 Hi! During a project we're working on we decided to use Flink over Opensearch 2.3, which seems to have a breaking change of removing the `type` property from responses.

[GitHub] [flink] fsk119 commented on a diff in pull request #21571: [FLINK-22317][table] Support DROP column/constraint/watermark for ALTER TABLE statement

2022-12-29 Thread GitBox
fsk119 commented on code in PR #21571: URL: https://github.com/apache/flink/pull/21571#discussion_r1058978409 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/AlterSchemaConverter.java: ## @@ -115,77 +120,135 @@ public Schema

[jira] [Assigned] (FLINK-30404) Do not redeploy taskmanagers on standalone application scaling

2022-12-29 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30404: -- Assignee: (was: Gyula Fora) > Do not redeploy taskmanagers on standalone application

[jira] [Closed] (FLINK-30430) Remove the useless dependencies in flink-connector-pulsar's dependencyManagement

2022-12-29 Thread Zili Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zili Chen closed FLINK-30430. - Resolution: Fixed master via https://github.com/apache/flink-connector-pulsar/pull/9 > Remove the

[GitHub] [flink-connector-pulsar] boring-cyborg[bot] commented on pull request #9: [FLINK-30430][Connector/Pulsar] Remove all the useless dependencies, drop mock runtime.

2022-12-29 Thread GitBox
boring-cyborg[bot] commented on PR #9: URL: https://github.com/apache/flink-connector-pulsar/pull/9#issuecomment-1367390477 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink-connector-pulsar] tisonkun merged pull request #9: [FLINK-30430][Connector/Pulsar] Remove all the useless dependencies, drop mock runtime.

2022-12-29 Thread GitBox
tisonkun merged PR #9: URL: https://github.com/apache/flink-connector-pulsar/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] beyond1920 commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
beyond1920 commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058998147 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/CompactFileUtils.java: ## @@ -0,0 +1,119 @@ +/* + *

[GitHub] [flink] beyond1920 commented on a diff in pull request #21059: [FLINK-29635][hive] Hive sink should support merge small files in bat…

2022-12-29 Thread GitBox
beyond1920 commented on code in PR #21059: URL: https://github.com/apache/flink/pull/21059#discussion_r1058997349 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/CompactFileUtils.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the

[jira] [Closed] (FLINK-30429) Flink command stops with IllegalArgumentException

2022-12-29 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30429. -- Fix Version/s: 1.17.0 Resolution: Fixed merged to master:

[GitHub] [flink] gyfora merged pull request #21515: [FLINK-30429][client] Fix IllegalArgumentException when no argument in flink executable

2022-12-29 Thread GitBox
gyfora merged PR #21515: URL: https://github.com/apache/flink/pull/21515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-30527) Last-state suspend followed by flinkVersion change may lead to state loss

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30527: --- Labels: pull-request-available (was: ) > Last-state suspend followed by flinkVersion

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #496: [FLINK-30527] Validate flinkVersion change for suspended jobs

2022-12-29 Thread GitBox
gyfora opened a new pull request, #496: URL: https://github.com/apache/flink-kubernetes-operator/pull/496 ## What is the purpose of the change The PR adds validation for flinkVersion changes on SUSPENDED application. If the flinkVersion is changed for an application that was

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-29 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1058985956 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/proxy/KinesisProxyAsyncV2Interface.java: ## @@ -0,0 +1,41 @@ +/* + *

[GitHub] [flink] beyond1920 commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
beyond1920 commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058985398 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactOperator.java: ## @@ -0,0 +1,145 @@ +/* + *

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-29 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1058982468 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/StreamConsumerRegistrar.java: ## @@ -218,7

[GitHub] [flink-connector-aws] darenwkt commented on a diff in pull request #39: [FLINK-30418] Implement synchronous KinesisClient in EFO

2022-12-29 Thread GitBox
darenwkt commented on code in PR #39: URL: https://github.com/apache/flink-connector-aws/pull/39#discussion_r1058982327 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/internals/publisher/fanout/StreamConsumerRegistrar.java: ## @@ -77,8

[jira] [Commented] (FLINK-30234) SourceReaderBase should provide an option to disable numRecordsIn metric registration

2022-12-29 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652854#comment-17652854 ] Wencong Liu commented on FLINK-30234: - Hello [~renqs] , I think this is a reasonable improvement.

[jira] [Commented] (FLINK-30257) SqlClientITCase#testMatchRecognize failed

2022-12-29 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652852#comment-17652852 ] Wencong Liu commented on FLINK-30257: - Hello [~martijnvisser]. In the situation of resource

[jira] [Updated] (FLINK-30257) SqlClientITCase#testMatchRecognize failed

2022-12-29 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wencong Liu updated FLINK-30257: Attachment: image-2022-12-29-21-47-31-606.png > SqlClientITCase#testMatchRecognize failed >

[jira] [Comment Edited] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2022-12-29 Thread Tomoyuki NAKAMURA (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652848#comment-17652848 ] Tomoyuki NAKAMURA edited comment on FLINK-30093 at 12/29/22 1:30 PM: -

[jira] [Comment Edited] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2022-12-29 Thread Tomoyuki NAKAMURA (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652848#comment-17652848 ] Tomoyuki NAKAMURA edited comment on FLINK-30093 at 12/29/22 1:29 PM: -

[jira] [Commented] (FLINK-30093) [Flink SQL][Protobuf] CompileException when querying Kafka topic using google.protobuf.Timestamp

2022-12-29 Thread Tomoyuki NAKAMURA (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652848#comment-17652848 ] Tomoyuki NAKAMURA commented on FLINK-30093: --- I am not sure if 1.16 can handle the

[jira] [Updated] (FLINK-30430) Remove the useless dependencies in flink-connector-pulsar's dependencyManagement

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30430: --- Labels: pull-request-available (was: ) > Remove the useless dependencies in

[GitHub] [flink-connector-pulsar] boring-cyborg[bot] commented on pull request #9: [FLINK-30430][Connector/Pulsar] Remove all the useless dependencies, drop mock runtime.

2022-12-29 Thread GitBox
boring-cyborg[bot] commented on PR #9: URL: https://github.com/apache/flink-connector-pulsar/pull/9#issuecomment-1367304205 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[jira] [Closed] (FLINK-29665) Support flexible subpartition range divisions

2022-12-29 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang closed FLINK-29665. -- Resolution: Done > Support flexible subpartition range divisions >

[jira] [Commented] (FLINK-29665) Support flexible subpartition range divisions

2022-12-29 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652833#comment-17652833 ] Lijie Wang commented on FLINK-29665: Done via master: 3881e53003adce22fd0a0fbd9a229d70d27a9cce

[jira] [Assigned] (FLINK-30528) Job may be stuck in upgrade loop when last-state fallback is disabled and deployment is missing

2022-12-29 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30528: -- Assignee: Gyula Fora > Job may be stuck in upgrade loop when last-state fallback is disabled

[GitHub] [flink] wanglijie95 closed pull request #21162: [FLINK-29665][runtime] Support flexible subpartion range division

2022-12-29 Thread GitBox
wanglijie95 closed pull request #21162: [FLINK-29665][runtime] Support flexible subpartion range division URL: https://github.com/apache/flink/pull/21162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] flinkbot commented on pull request #21577: [FLINK-30496][table-api] Introduce TableChange to represent MODIFY change

2022-12-29 Thread GitBox
flinkbot commented on PR #21577: URL: https://github.com/apache/flink/pull/21577#issuecomment-1367299309 ## CI report: * d5a2d2426b44a608d76e2c540145c511d53d94fb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30496) Introduce TableChange to represent MODIFY change

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30496: --- Labels: pull-request-available (was: ) > Introduce TableChange to represent MODIFY change

[GitHub] [flink] fsk119 opened a new pull request, #21577: [FLINK-30496][table-api] Introduce TableChange to represent MODIFY change

2022-12-29 Thread GitBox
fsk119 opened a new pull request, #21577: URL: https://github.com/apache/flink/pull/21577 ## What is the purpose of the change *Introduce TableChange to represent ALTER TABLE MODIFY syntax.* ## Brief change log - *Collect table changes during the sql to

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058927115 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/PartitionTempFileManager.java: ## @@ -75,6 +76,19 @@ public class

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058926736 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactOperator.java: ## @@ -0,0 +1,145 @@ +/* + *

[GitHub] [flink] beyond1920 commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
beyond1920 commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058863360 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/PartitionTempFileManager.java: ## @@ -75,6 +76,19 @@ public class

[GitHub] [flink] luoyuxia commented on pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on PR #21257: URL: https://github.com/apache/flink/pull/21257#issuecomment-1367265931 @beyond1920 @Aitozi @Tartarus0zm Thanks for you guys reviewing. I have addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] flinkbot commented on pull request #21576: [FLINK-30533][runtime] IteratorSourceReaderBase#pollNext() should push records to ReaderOutput in a while loop

2022-12-29 Thread GitBox
flinkbot commented on PR #21576: URL: https://github.com/apache/flink/pull/21576#issuecomment-1367262465 ## CI report: * 2a19c695367931933b54a858ffd62d55f3978b76 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30533) IteratorSourceReaderBase#pollNext() should push records to ReaderOutput in a while loop

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30533: --- Labels: pull-request-available (was: ) > IteratorSourceReaderBase#pollNext() should push

[GitHub] [flink] lindong28 commented on pull request #21576: [FLINK-30533][runtime] IteratorSourceReaderBase#pollNext() should push records to ReaderOutput in a while loop

2022-12-29 Thread GitBox
lindong28 commented on PR #21576: URL: https://github.com/apache/flink/pull/21576#issuecomment-1367260609 @gaoyunhaii Would you have time to review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] lindong28 opened a new pull request, #21576: [FLINK-30533][runtime] IteratorSourceReaderBase#pollNext() should push records to ReaderOutput in a while loop

2022-12-29 Thread GitBox
lindong28 opened a new pull request, #21576: URL: https://github.com/apache/flink/pull/21576 ## What is the purpose of the change Improve the performance of Flink programs that reads data from IteratorSourceReaderBase. ## Brief change log Updated

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058901588 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchPartitionCommitter.java: ## @@ -0,0 +1,141 @@ +/* + *

[jira] [Updated] (FLINK-30533) IteratorSourceReaderBase#pollNext() should push records to ReaderOutput in a while loop

2022-12-29 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-30533: - Description: Currently, each invocation of IteratorSourceReaderBase#pollNext() push at most one record

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058901029 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactOperator.java: ## @@ -0,0 +1,114 @@ +/* + *

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058900263 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactCoordinator.java: ## @@ -0,0 +1,155 @@ +/* + *

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058899053 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/batch/compact/BatchCompactCoordinator.java: ## @@ -0,0 +1,155 @@ +/* + *

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058898389 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/PartitionLoader.java: ## @@ -148,23 +150,35 @@ private void

[GitHub] [flink] lsyldliu commented on a diff in pull request #21563: [FLINK-19889][connectors/hive/filesystem][format/parquet] Supports nested projection pushdown for filesystem connector of columnar

2022-12-29 Thread GitBox
lsyldliu commented on code in PR #21563: URL: https://github.com/apache/flink/pull/21563#discussion_r1058777527 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/FlinkStreamRuleSets.scala: ## @@ -211,6 +211,29 @@ object

[GitHub] [flink] luoyuxia commented on a diff in pull request #21257: [FLINK-29879][filesystem] introduce operators for merging files in batch mode.

2022-12-29 Thread GitBox
luoyuxia commented on code in PR #21257: URL: https://github.com/apache/flink/pull/21257#discussion_r1058894608 ## flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/table/CompactFileUtils.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-30520) Arguments contains with '#' will error split in loadYAMLResource

2022-12-29 Thread tanjialiang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652797#comment-17652797 ] tanjialiang commented on FLINK-30520: - [~xtsong], thanks for your reply, it is the best way to

  1   2   >