[jira] [Comment Edited] (FLINK-30884) GetTable from Flink catalog should be judged whether it is a sink table

2023-02-03 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684104#comment-17684104 ] luoyuxia edited comment on FLINK-30884 at 2/4/23 6:19 AM: -- I think now I

[jira] [Commented] (FLINK-30884) GetTable from Flink catalog should be judged whether it is a sink table

2023-02-03 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684104#comment-17684104 ] luoyuxia commented on FLINK-30884: -- I think now I understand your case. It's valid, but I still don't

[GitHub] [flink] flinkbot commented on pull request #21852: [BP-1.16][FLINK-29427][table] Let reload task to always use user code classloader in full caching

2023-02-03 Thread via GitHub
flinkbot commented on PR #21852: URL: https://github.com/apache/flink/pull/21852#issuecomment-1416670305 ## CI report: * 8542949555cddfcad06018f98d7b0fa97057c407 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #21851: [BP-1.16][FLINK-29405][table] Fix unstable test InputFormatCacheLoaderTest

2023-02-03 Thread via GitHub
flinkbot commented on PR #21851: URL: https://github.com/apache/flink/pull/21851#issuecomment-1416669132 ## CI report: * fbab53f8e54663a2ae2600a3e22ed5f8d9ba16c4 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] PatrickRen opened a new pull request, #21852: [BP-1.16][FLINK-29427][table] Let reload task to always use user code classloader in full caching

2023-02-03 Thread via GitHub
PatrickRen opened a new pull request, #21852: URL: https://github.com/apache/flink/pull/21852 Unchanged backport of #21806 on release-1.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] PatrickRen opened a new pull request, #21851: [BP-1.16][FLINK-29405][table] Fix unstable test InputFormatCacheLoaderTest

2023-02-03 Thread via GitHub
PatrickRen opened a new pull request, #21851: URL: https://github.com/apache/flink/pull/21851 Unchanged backport of #20919 on release-1.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] flinkbot commented on pull request #21850: Bump http-cache-semantics from 4.1.0 to 4.1.1 in /flink-runtime-web/web-dashboard

2023-02-03 Thread via GitHub
flinkbot commented on PR #21850: URL: https://github.com/apache/flink/pull/21850#issuecomment-1416665791 ## CI report: * cfeb56179bad23c0e05783ddd61ba6240ee2a098 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] dependabot[bot] opened a new pull request, #21850: Bump http-cache-semantics from 4.1.0 to 4.1.1 in /flink-runtime-web/web-dashboard

2023-02-03 Thread via GitHub
dependabot[bot] opened a new pull request, #21850: URL: https://github.com/apache/flink/pull/21850 Bumps [http-cache-semantics](https://github.com/kornelski/http-cache-semantics) from 4.1.0 to 4.1.1. Commits

[jira] [Commented] (FLINK-30884) GetTable from Flink catalog should be judged whether it is a sink table

2023-02-03 Thread yuanfenghu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17684088#comment-17684088 ] yuanfenghu commented on FLINK-30884: In one case, we used an external catalog to manage my kafka

[GitHub] [flink-kubernetes-operator] ideal commented on a diff in pull request #517: [FLINK-30825] Change Ingress to work with Kubernetes version < 1.19

2023-02-03 Thread via GitHub
ideal commented on code in PR #517: URL: https://github.com/apache/flink-kubernetes-operator/pull/517#discussion_r1096478202 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java: ## @@ -175,4 +233,16 @@ private static String

[jira] [Closed] (FLINK-30846) SpeculativeSchedulerITCase.testSpeculativeExecutionOfInputFormatSource fails

2023-02-03 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-30846. --- Fix Version/s: 1.17.0 Resolution: Fixed Fixed via b1e70aebd3e248d68cf41a43db385ec9c9b6235a >

[GitHub] [flink] zhuzhurk closed pull request #21814: [FLINK-30846][runtime] Fix the getSchedulerType when test with flink.tests.enable-adaptive-scheduler

2023-02-03 Thread via GitHub
zhuzhurk closed pull request #21814: [FLINK-30846][runtime] Fix the getSchedulerType when test with flink.tests.enable-adaptive-scheduler URL: https://github.com/apache/flink/pull/21814 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Closed] (FLINK-30858) Kubernetes operator does not update reconciled generation

2023-02-03 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-30858. -- Resolution: Fixed b45122c in main > Kubernetes operator does not update reconciled

[jira] [Updated] (FLINK-30858) Kubernetes operator does not update reconciled generation

2023-02-03 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-30858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi updated FLINK-30858: --- Fix Version/s: kubernetes-operator-1.4.0 > Kubernetes operator does not update reconciled

[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #523: [FLINK-30858] Always record reconciled spec generation

2023-02-03 Thread via GitHub
mbalassi merged PR #523: URL: https://github.com/apache/flink-kubernetes-operator/pull/523 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-30563) Update training exercises to use Flink 1.16

2023-02-03 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson resolved FLINK-30563. Resolution: Implemented Implemented with 412283a43682cdbef4dddf46257f18c6750787df >

[jira] [Assigned] (FLINK-30563) Update training exercises to use Flink 1.16

2023-02-03 Thread David Anderson (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Anderson reassigned FLINK-30563: -- Assignee: Yuxin Tan > Update training exercises to use Flink 1.16 >

[GitHub] [flink-training] alpinegizmo commented on pull request #50: [FLINK-30563] Update to Flink 1.16

2023-02-03 Thread via GitHub
alpinegizmo commented on PR #50: URL: https://github.com/apache/flink-training/pull/50#issuecomment-1416498384 This look good! Thank you for your contribution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-training] alpinegizmo merged pull request #50: [FLINK-30563] Update to Flink 1.16

2023-02-03 Thread via GitHub
alpinegizmo merged PR #50: URL: https://github.com/apache/flink-training/pull/50 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] ashmeet-kandhari commented on pull request #20991: [FLINK-25538][flink-connector-kafka] JUnit5 Migration

2023-02-03 Thread via GitHub
ashmeet-kandhari commented on PR #20991: URL: https://github.com/apache/flink/pull/20991#issuecomment-1416496203 Hi @snuyanzin I am thinking of creating new branch and start slowly -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #525: [FLINK-27491] Support env replacement in flink-kubernetes-operator

2023-02-03 Thread via GitHub
morhidi commented on PR #525: URL: https://github.com/apache/flink-kubernetes-operator/pull/525#issuecomment-1416450912 cc @gaborgsomogyi @pvary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink-kubernetes-operator] morhidi merged pull request #526: [FLINK-30898] Only build required modules in docker image

2023-02-03 Thread via GitHub
morhidi merged PR #526: URL: https://github.com/apache/flink-kubernetes-operator/pull/526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] jeremyber-aws commented on pull request #21792: [FLINK-30830][docs] Temporal Table Function Samples for Java Do Not Work As-Is, And Some Functions Are Deprecated

2023-02-03 Thread via GitHub
jeremyber-aws commented on PR #21792: URL: https://github.com/apache/flink/pull/21792#issuecomment-1416422158 commits squashed  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Updated] (FLINK-30898) Do not include and build examples in operator image

2023-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30898: --- Labels: pull-request-available (was: ) > Do not include and build examples in operator

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #526: [FLINK-30898] Only build required modules in docker image

2023-02-03 Thread via GitHub
gyfora opened a new pull request, #526: URL: https://github.com/apache/flink-kubernetes-operator/pull/526 ## What is the purpose of the change Only build required modules in docker build to speed up process ## Does this pull request potentially affect one of the following

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #524: [FLINK-30405] Add ResourceLifecycleStatus to CommonStatus and printer column

2023-02-03 Thread via GitHub
morhidi commented on code in PR #524: URL: https://github.com/apache/flink-kubernetes-operator/pull/524#discussion_r1096203728 ## helm/flink-kubernetes-operator/crds/flinkdeployments.flink.apache.org-v1.yml: ## @@ -9243,6 +9242,19 @@ spec: type: object

[jira] [Updated] (FLINK-27491) Support env replacement in flink-kubernetes-operator CR

2023-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-27491: --- Labels: pull-request-available (was: ) > Support env replacement in

[GitHub] [flink-kubernetes-operator] morhidi opened a new pull request, #525: [FLINK-27491] Support env replacement in flink-kubernetes-operator

2023-02-03 Thread via GitHub
morhidi opened a new pull request, #525: URL: https://github.com/apache/flink-kubernetes-operator/pull/525 ## What is the purpose of the change Flink deployment resources support env interpolation natively using $() syntax. Users expected this to "just work" like other resources when

[GitHub] [flink-web] zentol commented on a diff in pull request #597: [FLINK-22922] Migrate project website from Jekyll to Hugo

2023-02-03 Thread via GitHub
zentol commented on code in PR #597: URL: https://github.com/apache/flink-web/pull/597#discussion_r1096150139 ## docs/content.zh/roadmap.md: ## @@ -1,5 +1,5 @@ --- -title: Apache Flink 开发计划(Roadmap) +title: Roadmap Review Comment: Why not use `开发计划` as the title? O.o --

[GitHub] [flink] flinkbot commented on pull request #21849: [FLINK-30596][Runtime/REST] Fix duplicate jobs when submitting with the same jobId

2023-02-03 Thread via GitHub
flinkbot commented on PR #21849: URL: https://github.com/apache/flink/pull/21849#issuecomment-1416212254 ## CI report: * 9620dd95a9ef0c33f1dd3ab5e3660bbcfd055ec3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30596) Multiple POST /jars/:jarid/run requests with the same jobId, runs duplicate jobs

2023-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30596: --- Labels: pull-request-available (was: ) > Multiple POST /jars/:jarid/run requests with the

[GitHub] [flink] mohsenrezaeithe opened a new pull request, #21849: [FLINK-30596][Runtime/REST] Fix duplicate jobs when submitting with the same jobId

2023-02-03 Thread via GitHub
mohsenrezaeithe opened a new pull request, #21849: URL: https://github.com/apache/flink/pull/21849 ## What is the purpose of the change The goal of this PR is to protect job submission when multiple `POST /jars/:jarid/run` requests with the same `jobId` have been submitted to a

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1096065712 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/converter/BsonToRowDataConverters.java: ## @@ -0,0 +1,426 @@ +/* + *

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1096059827 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/enumerator/splitter/MongoSampleSplitter.java: ## @@ -0,0 +1,131 @@ +/*

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1096043565 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/enumerator/assigner/MongoScanSplitAssigner.java: ## @@ -0,0 +1,143 @@

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1096032548 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/reader/deserializer/MongoJsonDeserializationSchema.java: ## @@ -0,0

[GitHub] [flink-connector-aws] z3d1k commented on pull request #52: [FLINK 30777] [Connectors/Kinesis] Allow Kinesis Table API Connector to specify shard assigner

2023-02-03 Thread via GitHub
z3d1k commented on PR #52: URL: https://github.com/apache/flink-connector-aws/pull/52#issuecomment-1416136869 PR title missing `-` in issue id. Should be `[FLINK-30777] [Connectors/Kinesis] Allow Kinesis Table API Connector to specify shard assigner` -- This is an automated message

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1096019431 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/enumerator/assigner/MongoScanSplitAssigner.java: ## @@ -0,0 +1,143 @@

[GitHub] [flink-connector-aws] karthitect commented on a diff in pull request #52: [FLINK 30777] [Connectors/Kinesis] Allow Kinesis Table API Connector to specify shard assigner

2023-02-03 Thread via GitHub
karthitect commented on code in PR #52: URL: https://github.com/apache/flink-connector-aws/pull/52#discussion_r1096011540 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java: ## @@ -242,6 +244,8 @@ public

[GitHub] [flink] dannycranmer commented on pull request #21792: [FLINK-30830][docs] Temporal Table Function Samples for Java Do Not Work As-Is, And Some Functions Are Deprecated

2023-02-03 Thread via GitHub
dannycranmer commented on PR #21792: URL: https://github.com/apache/flink/pull/21792#issuecomment-1416113739 Please rewrite the commit message to comply with the rules. If there is no ticket this should be `[hotfix][docs] ` -- This is an automated message from the Apache Git Service.

[GitHub] [flink-connector-aws] z3d1k commented on a diff in pull request #52: [FLINK 30777] [Connectors/Kinesis] Allow Kinesis Table API Connector to specify shard assigner

2023-02-03 Thread via GitHub
z3d1k commented on code in PR #52: URL: https://github.com/apache/flink-connector-aws/pull/52#discussion_r1096006869 ## flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/FlinkKinesisConsumer.java: ## @@ -242,6 +244,8 @@ public

[GitHub] [flink] dannycranmer commented on pull request #21792: [FLINK-30830][docs] Temporal Table Function Samples for Java Do Not Work As-Is, And Some Functions Are Deprecated

2023-02-03 Thread via GitHub
dannycranmer commented on PR #21792: URL: https://github.com/apache/flink/pull/21792#issuecomment-1416091944 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-connector-aws] dannycranmer commented on pull request #52: [FLINK 30777] [Connectors/Kinesis] Allow Kinesis Table API Connector to specify shard assigner

2023-02-03 Thread via GitHub
dannycranmer commented on PR #52: URL: https://github.com/apache/flink-connector-aws/pull/52#issuecomment-1416088836 Your build is failing due to spotbugs errors. Please run `mvn clean package` and verify the full build before pushing PR -- This is an automated message from the Apache

[GitHub] [flink-connector-aws] dannycranmer commented on a diff in pull request #52: [FLINK 30777] [Connectors/Kinesis] Allow Kinesis Table API Connector to specify shard assigner

2023-02-03 Thread via GitHub
dannycranmer commented on code in PR #52: URL: https://github.com/apache/flink-connector-aws/pull/52#discussion_r1095976283 ## docs/content/docs/connectors/table/kinesis.md: ## @@ -352,6 +352,14 @@ Connector Options Integer Maximum number of allowed concurrent

[GitHub] [flink-connector-aws] dannycranmer commented on pull request #52: [FLINK 30777] [Connectors/Kinesis] Allow Kinesis Table API Connector to specify shard assigner

2023-02-03 Thread via GitHub
dannycranmer commented on PR #52: URL: https://github.com/apache/flink-connector-aws/pull/52#issuecomment-1416078473 @karthitect please fix commit message as per the check. The PR title looks good: `[FLINK 30777][Connectors/Kinesis] Allow Kinesis Table API Connector to specify shard

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1095969209 ## flink-connector-mongodb-e2e-tests/src/test/resources/e2e_append_only.sql: ## @@ -0,0 +1,44 @@ +--/* +-- * Licensed to the Apache Software Foundation

[jira] [Updated] (FLINK-30405) Add ResourceLifecycleStatus to CommonStatus and printer column

2023-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30405: --- Labels: pull-request-available starter (was: starter) > Add ResourceLifecycleStatus to

[GitHub] [flink-kubernetes-operator] zch93 opened a new pull request, #524: [FLINK-30405] Add ResourceLifecycleStatus to CommonStatus and printer column

2023-02-03 Thread via GitHub
zch93 opened a new pull request, #524: URL: https://github.com/apache/flink-kubernetes-operator/pull/524 ## What is the purpose of the change *I had to remove the JsonIgnore annotation above the ResourceLifecycleState getter in CommonStatus and also I had to expose this as a printer

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1095898919 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/converter/RowDataToBsonConverters.java: ## @@ -0,0 +1,317 @@ +/* + *

[GitHub] [flink-table-store] JingsongLi merged pull request #497: [FLINK-30882] Introduce partition.expiration-time to automatically delete expired partitions

2023-02-03 Thread via GitHub
JingsongLi merged PR #497: URL: https://github.com/apache/flink-table-store/pull/497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] JingsongLi merged pull request #503: [hotfix] Limit pushdown in Flink not work good

2023-02-03 Thread via GitHub
JingsongLi merged PR #503: URL: https://github.com/apache/flink-table-store/pull/503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-table-store] JingsongLi merged pull request #502: [hotfix] Limit pushdown in Flink not work good

2023-02-03 Thread via GitHub
JingsongLi merged PR #502: URL: https://github.com/apache/flink-table-store/pull/502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-27273) Support both configMap and zookeeper based HA data clean up

2023-02-03 Thread Anton Ippolitov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683913#comment-17683913 ] Anton Ippolitov commented on FLINK-27273: - FYI for those who are interested, the

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1095898919 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/converter/RowDataToBsonConverters.java: ## @@ -0,0 +1,317 @@ +/* + *

[GitHub] [flink-connector-mongodb] Jiabao-Sun commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
Jiabao-Sun commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1095888644 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/table/converter/RowDataToBsonConverters.java: ## @@ -0,0 +1,317 @@ +/* + *

[GitHub] [flink-table-store] JingsongLi opened a new pull request, #501: [FLINK-30882] Introduce partition.expiration-time to automatically delete expired partitions

2023-02-03 Thread via GitHub
JingsongLi opened a new pull request, #501: URL: https://github.com/apache/flink-table-store/pull/501 Cherry-pick: https://github.com/apache/flink-table-store/pull/497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Closed] (FLINK-30770) OUTER join generates partial results

2023-02-03 Thread Thomas Erlenbach (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Erlenbach closed FLINK-30770. Resolution: Workaround > OUTER join generates partial results >

[jira] [Comment Edited] (FLINK-30770) OUTER join generates partial results

2023-02-03 Thread Thomas Erlenbach (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683823#comment-17683823 ] Thomas Erlenbach edited comment on FLINK-30770 at 2/3/23 2:28 PM: -- Hi

[GitHub] [flink] kristoffSC commented on pull request #21393: [FLINK-27246][TableSQL/Runtime][master] - Include WHILE blocks in split generated java methods

2023-02-03 Thread via GitHub
kristoffSC commented on PR #21393: URL: https://github.com/apache/flink/pull/21393#issuecomment-1415919713 Hi @tsreaper I've implemented test you requested for. It's 'CodeSplitITCase ::testManyAggregationsWithGroupBy' CI/CD is green. Anything else you would like me to do?

[jira] [Assigned] (FLINK-30609) Add ephemeral storage to CRD

2023-02-03 Thread Matyas Orhidi (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matyas Orhidi reassigned FLINK-30609: - Assignee: Matyas Orhidi > Add ephemeral storage to CRD >

[GitHub] [flink-connector-jdbc] eskabetxe commented on pull request #18: [FLINK-30790] Improve performance and extensibility in tests

2023-02-03 Thread via GitHub
eskabetxe commented on PR #18: URL: https://github.com/apache/flink-connector-jdbc/pull/18#issuecomment-1415916849 rebased to pass workflows -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-jdbc] eskabetxe commented on a diff in pull request #18: [FLINK-30790] Improve performance and extensibility in tests

2023-02-03 Thread via GitHub
eskabetxe commented on code in PR #18: URL: https://github.com/apache/flink-connector-jdbc/pull/18#discussion_r1095834884 ## flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/databases/h2/H2Metadata.java: ## @@ -15,25 +15,46 @@ * limitations under the

[jira] [Closed] (FLINK-30867) Support streaming read changes from overwrite

2023-02-03 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-30867. Fix Version/s: table-store-0.4.0 Assignee: yuzelin Resolution: Fixed master:

[GitHub] [flink-table-store] JingsongLi merged pull request #493: [FLINK-30867] Support streaming read changes from overwrite

2023-02-03 Thread via GitHub
JingsongLi merged PR #493: URL: https://github.com/apache/flink-table-store/pull/493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-30518) [flink-operator] Kubernetes HA Service not working with standalone mode

2023-02-03 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30518: -- Assignee: Usamah Jassat > [flink-operator] Kubernetes HA Service not working with standalone

[jira] [Closed] (FLINK-30518) [flink-operator] Kubernetes HA Service not working with standalone mode

2023-02-03 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-30518. -- Fix Version/s: kubernetes-operator-1.4.0 Resolution: Fixed merged to main

[GitHub] [flink-connector-jdbc] zentol merged pull request #19: [FLINK-30880] Update flink version to 1.16.1

2023-02-03 Thread via GitHub
zentol merged PR #19: URL: https://github.com/apache/flink-connector-jdbc/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-30518) [flink-operator] Kubernetes HA Service not working with standalone mode

2023-02-03 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30518: --- Priority: Critical (was: Major) > [flink-operator] Kubernetes HA Service not working with

[jira] [Closed] (FLINK-30841) Incorrect calc merge generate wrong plan

2023-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-30841. --- Resolution: Fixed fixed in master: c3a376f5380ee85c9d34a8e72806e6ce6893be6a > Incorrect calc merge

[GitHub] [flink] XComp commented on pull request #21768: [FLINK-30801][runtime] Migrating LeaderElection/Retrieval-related tests to JUnit5

2023-02-03 Thread via GitHub
XComp commented on PR #21768: URL: https://github.com/apache/flink/pull/21768#issuecomment-1415882621 FYI: I'm basing this PR on PR #21757. That's why there's this addition FLINK-30788 commit in the diff. I'm planning to merge PR#21757 into `master` before going ahead with this PR here

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #518: [FLINK-30518] Pass JM Pod IP to Flink when starting up with K8s HA

2023-02-03 Thread via GitHub
gyfora merged PR #518: URL: https://github.com/apache/flink-kubernetes-operator/pull/518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] lincoln-lil commented on a diff in pull request #21641: [FLINK-30006][table-planner] Make all pure dynamic functions non-deterministic in streaming mode to avoid wrong plans

2023-02-03 Thread via GitHub
lincoln-lil commented on code in PR #21641: URL: https://github.com/apache/flink/pull/21641#discussion_r1095805830 ## docs/content/docs/dev/table/functions/udfs.md: ## @@ -647,15 +647,15 @@ The following system functions are always non-deterministic(evaluated per record -

[GitHub] [flink-connector-mongodb] zentol commented on a diff in pull request #1: [FLINK-6573][connectors/mongodb] Flink MongoDB Connector

2023-02-03 Thread via GitHub
zentol commented on code in PR #1: URL: https://github.com/apache/flink-connector-mongodb/pull/1#discussion_r1094408110 ## flink-connector-mongodb-e2e-tests/src/test/resources/e2e_append_only.sql: ## @@ -0,0 +1,44 @@ +--/* +-- * Licensed to the Apache Software Foundation (ASF)

[GitHub] [flink] XComp commented on pull request #21768: [FLINK-30801][runtime] Migrating LeaderElection/Retrieval-related tests to JUnit5

2023-02-03 Thread via GitHub
XComp commented on PR #21768: URL: https://github.com/apache/flink/pull/21768#issuecomment-1415879868 I rebased this change to `master`. There was also a change necessary (see

[GitHub] [flink-table-store] zhangjun0x01 commented on pull request #471: [FLINK-30608] support rename table

2023-02-03 Thread via GitHub
zhangjun0x01 commented on PR #471: URL: https://github.com/apache/flink-table-store/pull/471#issuecomment-1415878025 > @zhangjun0x01 Thanks! You should modify tests too. And I think you can document object store in renaming page. > > ``` > If you use object storage, such as S3 or

[GitHub] [flink-table-store] JingsongLi merged pull request #500: [hotfix] Fix checkstyle error in flink-table-store-hive module

2023-02-03 Thread via GitHub
JingsongLi merged PR #500: URL: https://github.com/apache/flink-table-store/pull/500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #21848: [bp-1.16][FLINK-29038][datastream] Remove local timeout in AsyncWaitOperatorTest for testing guideline

2023-02-03 Thread via GitHub
flinkbot commented on PR #21848: URL: https://github.com/apache/flink/pull/21848#issuecomment-1415866169 ## CI report: * abd2238c66fea5fd3c7eb8bd0b5a9d330063ee1f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30898) Do not include and build examples in operator image

2023-02-03 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-30898: --- Issue Type: Improvement (was: New Feature) > Do not include and build examples in operator image >

[jira] [Assigned] (FLINK-30898) Do not include and build examples in operator image

2023-02-03 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-30898: -- Assignee: Gyula Fora > Do not include and build examples in operator image >

[GitHub] [flink] lincoln-lil merged pull request #21799: [FLINK-30841][table-planner] Fix incorrect calc merge to avoid wrong plans

2023-02-03 Thread via GitHub
lincoln-lil merged PR #21799: URL: https://github.com/apache/flink/pull/21799 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] JunRuiLee commented on pull request #21814: [FLINK-30846][runtime] Fix the getSchedulerType when test with flink.tests.enable-adaptive-scheduler

2023-02-03 Thread via GitHub
JunRuiLee commented on PR #21814: URL: https://github.com/apache/flink/pull/21814#issuecomment-1415855763 @zhuzhurk I've addressed all comments, PTAL! Thx! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (FLINK-29038) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteOrderedWithRetry failed with AssertionError

2023-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-29038: Fix Version/s: 1.17.0 > AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteOrderedWithRetry

[jira] [Commented] (FLINK-29038) AsyncWaitOperatorTest.testProcessingTimeRepeatedCompleteOrderedWithRetry failed with AssertionError

2023-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683873#comment-17683873 ] lincoln lee commented on FLINK-29038: - fixed in master: b138c82a464d825ec51587e57f136f91128d6bba >

[GitHub] [flink] lincoln-lil opened a new pull request, #21848: [bp-1.16][FLINK-29038][datastream] Remove local timeout in AsyncWaitOperatorTest for testing guideline

2023-02-03 Thread via GitHub
lincoln-lil opened a new pull request, #21848: URL: https://github.com/apache/flink/pull/21848 This is backport pr of FLINK-29038 to 1.16, it aims to remove the local timeout in AsyncWaitOperatorTest which may cause instability for testing. -- This is an automated message from the

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #517: [FLINK-30825] Change Ingress to work with Kubernetes version < 1.19

2023-02-03 Thread via GitHub
morhidi commented on PR #517: URL: https://github.com/apache/flink-kubernetes-operator/pull/517#issuecomment-1415852417 > @morhidi can you please review this when you have time? I think the improvement makes sense I agree, the change is reasonable. I remember 1.19 was already in

[GitHub] [flink-kubernetes-operator] morhidi commented on a diff in pull request #517: [FLINK-30825] Change Ingress to work with Kubernetes version < 1.19

2023-02-03 Thread via GitHub
morhidi commented on code in PR #517: URL: https://github.com/apache/flink-kubernetes-operator/pull/517#discussion_r1095776890 ## flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/utils/IngressUtils.java: ## @@ -175,4 +233,16 @@ private static String

[GitHub] [flink] XComp commented on pull request #21757: [FLINK-30788][runtime] Refactors AbstractHaServices.createLeaderElectionService to return LeaderElectionDriverFactory

2023-02-03 Thread via GitHub
XComp commented on PR #21757: URL: https://github.com/apache/flink/pull/21757#issuecomment-1415845019 Rebase to most-recent `master` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-30673) Add documentation for "EXPLAIN PLAN_ADVICE" statement

2023-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-30673. --- Resolution: Fixed fixed in master: dfedb1eeab4697aad947aa798b26657d44a2d958 > Add documentation

[jira] [Closed] (FLINK-30650) FLIP-280: Introduce EXPLAIN PLAN_ADVICE to provide SQL advice

2023-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee closed FLINK-30650. --- Resolution: Fixed > FLIP-280: Introduce EXPLAIN PLAN_ADVICE to provide SQL advice >

[GitHub] [flink] lincoln-lil merged pull request #21739: [FLINK-30673][docs][table] Add documentation for "EXPLAIN PLAN_ADVICE" statement

2023-02-03 Thread via GitHub
lincoln-lil merged PR #21739: URL: https://github.com/apache/flink/pull/21739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] lincoln-lil merged pull request #21842: [hotfix][FLINK-29038][datastream] Remove local timeout in AsyncWaitOperatorTest for testing guideline

2023-02-03 Thread via GitHub
lincoln-lil merged PR #21842: URL: https://github.com/apache/flink/pull/21842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-30770) OUTER join generates partial results

2023-02-03 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683864#comment-17683864 ] lincoln lee commented on FLINK-30770: - [~terlenbach] Good to hear you found a solution! Actually

[jira] [Created] (FLINK-30898) Do not include and build examples in operator image

2023-02-03 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-30898: -- Summary: Do not include and build examples in operator image Key: FLINK-30898 URL: https://issues.apache.org/jira/browse/FLINK-30898 Project: Flink Issue Type:

[jira] [Updated] (FLINK-30858) Kubernetes operator does not update reconciled generation

2023-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30858: --- Labels: pull-request-available (was: ) > Kubernetes operator does not update reconciled

[GitHub] [flink-kubernetes-operator] gyfora opened a new pull request, #523: [FLINK-30858] Always record reconciled spec generation

2023-02-03 Thread via GitHub
gyfora opened a new pull request, #523: URL: https://github.com/apache/flink-kubernetes-operator/pull/523 ## What is the purpose of the change Record reconciled generation even if no Flink deployment took place in order to allow users to determine whether a given spec version has

[GitHub] [flink] lincoln-lil commented on pull request #21842: [hotfix][FLINK-29038][datastream] Remove local timeout in AsyncWaitOperatorTest for testing guideline

2023-02-03 Thread via GitHub
lincoln-lil commented on PR #21842: URL: https://github.com/apache/flink/pull/21842#issuecomment-1415809962 @XComp thanks for reviewing this! I'll update the commit message after ci tests passed and open the backport pr to 1.16. In addition to this pr related test class, I checked that

[jira] [Created] (FLINK-30897) Avoid timeouts in JUnit tests

2023-02-03 Thread lincoln lee (Jira)
lincoln lee created FLINK-30897: --- Summary: Avoid timeouts in JUnit tests Key: FLINK-30897 URL: https://issues.apache.org/jira/browse/FLINK-30897 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-29405) InputFormatCacheLoaderTest is unstable

2023-02-03 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17683857#comment-17683857 ] Matthias Pohl commented on FLINK-29405: --- 1.16:

[GitHub] [flink] flinkbot commented on pull request #21847: [FLINK-30896][table] Reduce usage of CatalogViewImpl in table-planner

2023-02-03 Thread via GitHub
flinkbot commented on PR #21847: URL: https://github.com/apache/flink/pull/21847#issuecomment-1415802167 ## CI report: * 28aab2ccd904f10af95c5927cc104261ad5f96a3 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30896) Reduce usage of CatalogViewImpl in planner

2023-02-03 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30896: --- Labels: pull-request-available (was: ) > Reduce usage of CatalogViewImpl in planner >

  1   2   3   >