[GitHub] [flink] reswqa commented on pull request #21953: [FLINK-30989][runtime] Some config options related to sorting and spilling are not valid.

2023-02-17 Thread via GitHub
reswqa commented on PR #21953: URL: https://github.com/apache/flink/pull/21953#issuecomment-1435495267 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-31041) Race condition in DefaultScheduler results in memory leak and busy loop

2023-02-17 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690678#comment-17690678 ] Zhu Zhu commented on FLINK-31041: - I have assigned you the ticket. [~huwh] Feel free to open a pr for

[jira] [Assigned] (FLINK-31041) Race condition in DefaultScheduler results in memory leak and busy loop

2023-02-17 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-31041: --- Assignee: Weihua Hu (was: Danny Cranmer) > Race condition in DefaultScheduler results in memory

[jira] [Commented] (FLINK-31124) Add it case for HiveTableSink speculative execution

2023-02-17 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690677#comment-17690677 ] Zhu Zhu commented on FLINK-31124: - [~csq] Thanks for volunteering! I have assigned you the ticket. >

[jira] [Updated] (FLINK-31124) Add it case for HiveTableSink speculative execution

2023-02-17 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-31124: Priority: Major (was: Minor) > Add it case for HiveTableSink speculative execution >

[jira] [Assigned] (FLINK-31124) Add it case for HiveTableSink speculative execution

2023-02-17 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-31124: --- Assignee: chenshuiqiang > Add it case for HiveTableSink speculative execution >

[GitHub] [flink] 1996fanrui commented on pull request #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
1996fanrui commented on PR #21960: URL: https://github.com/apache/flink/pull/21960#issuecomment-1435470941 Record some CI here to compare the running time: First CI: https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=46277=results -- This is an automated

[jira] [Assigned] (FLINK-31049) Add support for Kafka record headers to KafkaSink

2023-02-17 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-31049: --- Assignee: Alex Gout > Add support for Kafka record headers to KafkaSink >

[jira] [Commented] (FLINK-30945) FTS does not support multiple writers into the same table and topic

2023-02-17 Thread Xinbin Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690568#comment-17690568 ] Xinbin Huang commented on FLINK-30945: -- [~lzljs3620320] would you assign this to me? > FTS does

[GitHub] [flink-connector-opensearch] lilyevsky commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
lilyevsky commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110240788 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchSinkBuilder.java: ## @@ -148,6 +150,7 @@ public

[jira] [Updated] (FLINK-31120) ConcurrentModificationException occurred in StringFunctionsITCase.test

2023-02-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31120: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] flinkbot commented on pull request #21961: [FLINK-31120] Add concurrent access control for collectorIterators in StreamExecutionEnvironment

2023-02-17 Thread via GitHub
flinkbot commented on PR #21961: URL: https://github.com/apache/flink/pull/21961#issuecomment-1435091671 ## CI report: * d48d6ecdba52849419a0c4a53a977b2ce7562a97 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] shuiqiangchen opened a new pull request, #21961: [FLINK-29879] Add concurrent access control for collectorIterators in StreamExecutionEnvironment

2023-02-17 Thread via GitHub
shuiqiangchen opened a new pull request, #21961: URL: https://github.com/apache/flink/pull/21961 ## What is the purpose of the change *This change mainly to add a concurrent access control for the static list `collectIterators` in `StreamExecutionEnvironment`. There are still

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110194101 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchSinkBuilder.java: ## @@ -148,6 +150,7 @@ public

[GitHub] [flink-connector-opensearch] lilyevsky commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
lilyevsky commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110179327 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchSinkBuilder.java: ## @@ -148,6 +150,7 @@ public

[jira] [Comment Edited] (FLINK-31120) ConcurrentModificationException occurred in StringFunctionsITCase.test

2023-02-17 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690523#comment-17690523 ] Shuiqiang Chen edited comment on FLINK-31120 at 2/17/23 6:17 PM: - Maybe

[jira] [Commented] (FLINK-31124) Add it case for HiveTableSink speculative execution

2023-02-17 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690524#comment-17690524 ] Shuiqiang Chen commented on FLINK-31124: Hi [~zhuzh] I would like to help finish to issue, could

[jira] [Commented] (FLINK-31120) ConcurrentModificationException occurred in StringFunctionsITCase.test

2023-02-17 Thread Shuiqiang Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690523#comment-17690523 ] Shuiqiang Chen commented on FLINK-31120: Maybe tt needs concurrent control for access to the

[GitHub] [flink] pgaref commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-02-17 Thread via GitHub
pgaref commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1110168340 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -215,6 +215,9 @@ */ private final

[GitHub] [flink] akalash commented on a diff in pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-02-17 Thread via GitHub
akalash commented on code in PR #21923: URL: https://github.com/apache/flink/pull/21923#discussion_r1110137878 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java: ## @@ -215,6 +215,9 @@ */ private final

[jira] [Assigned] (FLINK-13871) Consolidate isRunning, canceled, isFinished fields in StreamTask and SourceStreamTask

2023-02-17 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13871?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Kalashnikov reassigned FLINK-13871: - Assignee: Panagiotis Garefalakis > Consolidate isRunning, canceled, isFinished

[GitHub] [flink] pgaref commented on pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-02-17 Thread via GitHub
pgaref commented on PR #21923: URL: https://github.com/apache/flink/pull/21923#issuecomment-1434978767 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] pgaref commented on pull request #21923: FLINK-13871: Consolidate volatile status fields in StreamTask

2023-02-17 Thread via GitHub
pgaref commented on PR #21923: URL: https://github.com/apache/flink/pull/21923#issuecomment-1434911355 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] liuyongvs commented on pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-02-17 Thread via GitHub
liuyongvs commented on PR #21958: URL: https://github.com/apache/flink/pull/21958#issuecomment-1434909262 > Thanks for your contribution. > > To be honest i didn't get the logic. What i did: > > 1. Built it from the PR's branch > 2. Started standalone Flink > 3. Via

[GitHub] [flink] liuyongvs closed pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-02-17 Thread via GitHub
liuyongvs closed pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function. URL: https://github.com/apache/flink/pull/21958 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110068155 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchSinkBuilder.java: ## @@ -148,6 +150,7 @@ public

[GitHub] [flink] liuyongvs commented on pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-02-17 Thread via GitHub
liuyongvs commented on PR #21958: URL: https://github.com/apache/flink/pull/21958#issuecomment-1434905063 > ```sql > SELECT array_union(array[1], array[array[1, 2, 3]]); > ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110066429 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchWriter.java: ## @@ -122,10 +128,11 @@ } catch

[GitHub] [flink] liuyongvs commented on a diff in pull request #21947: [FLINK-31098][table] Add ARRAY_SIZE function.

2023-02-17 Thread via GitHub
liuyongvs commented on code in PR #21947: URL: https://github.com/apache/flink/pull/21947#discussion_r1110053725 ## docs/data/sql_functions.yml: ## @@ -617,6 +617,12 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink-connector-opensearch] lilyevsky commented on pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
lilyevsky commented on PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1434889977 @reta I committed the changes you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] liuyongvs commented on a diff in pull request #21947: [FLINK-31098][table] Add ARRAY_SIZE function.

2023-02-17 Thread via GitHub
liuyongvs commented on code in PR #21947: URL: https://github.com/apache/flink/pull/21947#discussion_r1110050019 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java: ## @@ -178,6 +178,35 @@ ANY,

[GitHub] [flink-connector-opensearch] lilyevsky commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
lilyevsky commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110040361 ## flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchWriterITCase.java: ## @@ -174,7 +175,8 @@ void

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110047438 ## flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchWriterITCase.java: ## @@ -174,7 +175,8 @@ void

[GitHub] [flink-connector-opensearch] lilyevsky commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
lilyevsky commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1110040361 ## flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchWriterITCase.java: ## @@ -174,7 +175,8 @@ void

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
1996fanrui commented on code in PR #21960: URL: https://github.com/apache/flink/pull/21960#discussion_r1110001094 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java: ## @@ -199,6 +200,9 @@ private void startMiniCluster() throws Exception

[GitHub] [flink] pnowojski commented on a diff in pull request #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
pnowojski commented on code in PR #21960: URL: https://github.com/apache/flink/pull/21960#discussion_r1110017809 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java: ## @@ -199,6 +200,9 @@ private void startMiniCluster() throws Exception {

[GitHub] [flink] snuyanzin commented on a diff in pull request #21947: [FLINK-31098][table] Add ARRAY_SIZE function.

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21947: URL: https://github.com/apache/flink/pull/21947#discussion_r1110013444 ## docs/data/sql_functions.yml: ## @@ -617,6 +617,12 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
1996fanrui commented on code in PR #21960: URL: https://github.com/apache/flink/pull/21960#discussion_r1110001094 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java: ## @@ -199,6 +200,9 @@ private void startMiniCluster() throws Exception

[GitHub] [flink] liuyongvs commented on a diff in pull request #21947: [FLINK-31098][table] Add ARRAY_SIZE function.

2023-02-17 Thread via GitHub
liuyongvs commented on code in PR #21947: URL: https://github.com/apache/flink/pull/21947#discussion_r1109996439 ## docs/data/sql_functions.yml: ## @@ -617,6 +617,12 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink-connector-mongodb] zentol commented on a diff in pull request #3: [FLINK-31063] Prevent duplicate reading when restoring from a checkpoint.

2023-02-17 Thread via GitHub
zentol commented on code in PR #3: URL: https://github.com/apache/flink-connector-mongodb/pull/3#discussion_r1109995851 ## flink-connector-mongodb/src/main/java/org/apache/flink/connector/mongodb/source/split/MongoSourceSplitState.java: ## @@ -19,28 +19,19 @@ import

[GitHub] [flink] pnowojski commented on a diff in pull request #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
pnowojski commented on code in PR #21960: URL: https://github.com/apache/flink/pull/21960#discussion_r1109989565 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java: ## @@ -199,6 +200,9 @@ private void startMiniCluster() throws Exception {

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
1996fanrui commented on code in PR #21960: URL: https://github.com/apache/flink/pull/21960#discussion_r1109958093 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java: ## @@ -199,6 +200,9 @@ private void startMiniCluster() throws Exception

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1109964501 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/schema/TimeIndicatorRelDataType.scala: ## @@ -28,11 +28,11 @@ import java.lang

[GitHub] [flink] 1996fanrui commented on a diff in pull request #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
1996fanrui commented on code in PR #21960: URL: https://github.com/apache/flink/pull/21960#discussion_r1109958093 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java: ## @@ -199,6 +200,9 @@ private void startMiniCluster() throws Exception

[jira] [Closed] (FLINK-15550) testCancelTaskExceptionAfterTaskMarkedFailed failed on azure

2023-02-17 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anton Kalashnikov closed FLINK-15550. - Fix Version/s: 1.16.2 Resolution: Fixed >

[jira] [Commented] (FLINK-15550) testCancelTaskExceptionAfterTaskMarkedFailed failed on azure

2023-02-17 Thread Anton Kalashnikov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690444#comment-17690444 ] Anton Kalashnikov commented on FLINK-15550: --- Merged to release-1.16: 658ba8eb, a3c9eb40,

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1109948032 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/FailureHandler.java: ## @@ -0,0 +1,30 @@ +/* + * Licensed to the

[GitHub] [flink-connector-opensearch] reta commented on pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1434782202 @lilyevsky a few minor comments, LGTM otherwise! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1109943802 ## flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchWriterITCase.java: ## @@ -174,7 +175,8 @@ void

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1109940919 ## flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchWriterITCase.java: ## @@ -238,19 +240,68 @@ void

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1109941466 ## flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchWriterITCase.java: ## @@ -238,19 +240,68 @@ void

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1109940526 ## flink-connector-opensearch/src/test/java/org/apache/flink/connector/opensearch/sink/OpensearchWriterITCase.java: ## @@ -238,19 +240,68 @@ void

[GitHub] [flink-connector-opensearch] reta commented on a diff in pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
reta commented on code in PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#discussion_r1109939155 ## flink-connector-opensearch/src/main/java/org/apache/flink/connector/opensearch/sink/OpensearchWriter.java: ## @@ -103,7 +107,8 @@

[GitHub] [flink] akalash merged pull request #21919: [FLINK-15550][runtime] The static latches in TaskTest were replaced by latches from invokable objects

2023-02-17 Thread via GitHub
akalash merged PR #21919: URL: https://github.com/apache/flink/pull/21919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] lindong28 commented on pull request #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-17 Thread via GitHub
lindong28 commented on PR #212: URL: https://github.com/apache/flink-ml/pull/212#issuecomment-1434767219 @zhipeng93 Can you help review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [flink] pnowojski commented on a diff in pull request #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
pnowojski commented on code in PR #21960: URL: https://github.com/apache/flink/pull/21960#discussion_r1109920354 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/MiniClusterResource.java: ## @@ -199,6 +200,9 @@ private void startMiniCluster() throws Exception {

[jira] [Commented] (FLINK-31095) FileSink doesn't work with s3a on EKS

2023-02-17 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690431#comment-17690431 ] Martijn Visser commented on FLINK-31095: I did a quick check on the PR belonging to FLINK-23487

[jira] [Updated] (FLINK-31036) StateCheckpointedITCase timed out

2023-02-17 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski updated FLINK-31036: --- Fix Version/s: 1.17.0 1.18.0 > StateCheckpointedITCase timed out >

[jira] [Updated] (FLINK-31125) Flink ML benchmark framework should minimize the source operator overhead

2023-02-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31125: --- Labels: pull-request-available (was: ) > Flink ML benchmark framework should minimize the

[GitHub] [flink-ml] lindong28 opened a new pull request, #212: [FLINK-31125] Flink ML benchmark framework should minimize the source operator overhead

2023-02-17 Thread via GitHub
lindong28 opened a new pull request, #212: URL: https://github.com/apache/flink-ml/pull/212 ## What is the purpose of the change Minimize the source operator overhead in Flink ML benchmark. ## Brief change log - Updated RowGenerator to generate row value once and re-use

[jira] [Updated] (FLINK-31125) Flink ML benchmark framework should minimize the source operator overhead

2023-02-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31125: - Description: Flink ML benchmark framework estimates the throughput by having a source operator

[GitHub] [flink-connector-opensearch] lilyevsky commented on pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-02-17 Thread via GitHub
lilyevsky commented on PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1434732687 @reta Added the test. I think now it is good. I also tested the test itself, by simulating the "bad" handler, making the test fail, just to make sure it checks it

[jira] [Updated] (FLINK-31125) Flink ML benchmark framework should minimize the source operator overhead

2023-02-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31125: - Summary: Flink ML benchmark framework should minimize the source operator overhead (was: Flink ML

[jira] [Updated] (FLINK-31125) Flink ML benchmark result should not include data generation overhead

2023-02-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31125: - Description: Flink ML benchmark framework estimates the throughput by having a source operator

[jira] [Commented] (FLINK-31084) DataGen sequence generator requires the definition of start/end values

2023-02-17 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690427#comment-17690427 ] xzw0223 commented on FLINK-31084: - My idea is that we don't have to pre-load all the data, we generate

[jira] [Commented] (FLINK-31084) DataGen sequence generator requires the definition of start/end values

2023-02-17 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690426#comment-17690426 ] xzw0223 commented on FLINK-31084: - There is another problem, because we need to write the data

[jira] [Created] (FLINK-31125) Flink ML benchmark result should not include data generation overhead

2023-02-17 Thread Dong Lin (Jira)
Dong Lin created FLINK-31125: Summary: Flink ML benchmark result should not include data generation overhead Key: FLINK-31125 URL: https://issues.apache.org/jira/browse/FLINK-31125 Project: Flink

[jira] [Assigned] (FLINK-31125) Flink ML benchmark result should not include data generation overhead

2023-02-17 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-31125: Assignee: Dong Lin > Flink ML benchmark result should not include data generation overhead >

[GitHub] [flink-connector-opensearch] lilyevsky commented on pull request #12: [FLINK-30998] Add test for FailureHandler

2023-02-17 Thread via GitHub
lilyevsky commented on PR #12: URL: https://github.com/apache/flink-connector-opensearch/pull/12#issuecomment-1434706713 Opened by mistake -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-opensearch] lilyevsky closed pull request #12: [FLINK-30998] Add test for FailureHandler

2023-02-17 Thread via GitHub
lilyevsky closed pull request #12: [FLINK-30998] Add test for FailureHandler URL: https://github.com/apache/flink-connector-opensearch/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-opensearch] reta commented on pull request #10: [FLINK-31068] Document how to use Opensearch connector with OpenSearch 1.x / 2.x / 3.x (upcoming) clusters

2023-02-17 Thread via GitHub
reta commented on PR #10: URL: https://github.com/apache/flink-connector-opensearch/pull/10#issuecomment-1434684899 @MartijnVisser could you have a second to look (only docs update), thank you -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] akalash commented on pull request #21919: [FLINK-15550][runtime] The static latches in TaskTest were replaced by latches from invokable objects

2023-02-17 Thread via GitHub
akalash commented on PR #21919: URL: https://github.com/apache/flink/pull/21919#issuecomment-1434659103 @pnowojski, Can you take a look at it please? it is just a backport of the ticket which you have reviewed already. There was no any conflicts -- This is an automated message from the

[GitHub] [flink] flinkbot commented on pull request #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
flinkbot commented on PR #21960: URL: https://github.com/apache/flink/pull/21960#issuecomment-1434642730 ## CI report: * 52974fcfa9fa636359d179eb556af6f82bf1ff96 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31036) StateCheckpointedITCase timed out

2023-02-17 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-31036: Component/s: Tests > StateCheckpointedITCase timed out > - > >

[jira] [Updated] (FLINK-31036) StateCheckpointedITCase timed out

2023-02-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31036: --- Labels: pull-request-available test-stability (was: test-stability) >

[GitHub] [flink] 1996fanrui opened a new pull request, #21960: [FLINK-31036][test][checkpoint] FileSystemCheckpointStorage as the default for test

2023-02-17 Thread via GitHub
1996fanrui opened a new pull request, #21960: URL: https://github.com/apache/flink/pull/21960 ## What is the purpose of the change FileSystemCheckpointStorage as the default for test, because the checkpoint size of JobManagerCheckpointStorage isn't enough in some tests. ##

[jira] [Created] (FLINK-31124) Add it case for HiveTableSink speculative execution

2023-02-17 Thread Biao Liu (Jira)
Biao Liu created FLINK-31124: Summary: Add it case for HiveTableSink speculative execution Key: FLINK-31124 URL: https://issues.apache.org/jira/browse/FLINK-31124 Project: Flink Issue Type:

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1109781704 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/FlinkLogicalRelFactories.scala: ## @@ -174,6 +174,7 @@ object

[jira] [Commented] (FLINK-31084) DataGen sequence generator requires the definition of start/end values

2023-02-17 Thread xzw0223 (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690380#comment-17690380 ] xzw0223 commented on FLINK-31084: - [~mapohl]  Hi, I have encountered a problem, and I would like to ask

[jira] [Created] (FLINK-31123) Add it case for FileSink speculative execution

2023-02-17 Thread Biao Liu (Jira)
Biao Liu created FLINK-31123: Summary: Add it case for FileSink speculative execution Key: FLINK-31123 URL: https://issues.apache.org/jira/browse/FLINK-31123 Project: Flink Issue Type:

[jira] [Commented] (FLINK-31041) Race condition in DefaultScheduler results in memory leak and busy loop

2023-02-17 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690379#comment-17690379 ] Danny Cranmer commented on FLINK-31041: --- Hey [~zhuzh] / [~huwh] . Thank-you for the deep dive and

[jira] [Comment Edited] (FLINK-31041) Race condition in DefaultScheduler results in memory leak and busy loop

2023-02-17 Thread Danny Cranmer (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690379#comment-17690379 ] Danny Cranmer edited comment on FLINK-31041 at 2/17/23 12:58 PM: - Hey

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1109761449 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/sql/SqlRowConstructor.java: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the

[jira] [Commented] (FLINK-31121) KafkaSink should be able to catch and ignore exp via config on/off

2023-02-17 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690378#comment-17690378 ] Jing Ge commented on FLINK-31121: - [~zjureel] it's your, thanks! > KafkaSink should be able to catch

[jira] [Assigned] (FLINK-31121) KafkaSink should be able to catch and ignore exp via config on/off

2023-02-17 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge reassigned FLINK-31121: --- Assignee: Shammon > KafkaSink should be able to catch and ignore exp via config on/off >

[jira] [Comment Edited] (FLINK-31119) JobRecoveryITCase.testTaskFailureRecovery failed due to the job not finishing successfully

2023-02-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690355#comment-17690355 ] Matthias Pohl edited comment on FLINK-31119 at 2/17/23 12:30 PM: -

[jira] [Commented] (FLINK-31120) ConcurrentModificationException occurred in StringFunctionsITCase.test

2023-02-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690372#comment-17690372 ] Weijie Guo commented on FLINK-31120: Sorry, I accidentally touched it. >

[jira] [Updated] (FLINK-31120) ConcurrentModificationException occurred in StringFunctionsITCase.test

2023-02-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31120: --- Description:

[jira] [Updated] (FLINK-31120) ConcurrentModificationException occurred in StringFunctionsITCase.test

2023-02-17 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-31120: --- Description: #

[jira] [Comment Edited] (FLINK-31119) JobRecoveryITCase.testTaskFailureRecovery failed due to the job not finishing successfully

2023-02-17 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17690314#comment-17690314 ] Matthias Pohl edited comment on FLINK-31119 at 2/17/23 12:24 PM: -

[jira] [Created] (FLINK-31122) Expose MetricGroup to Committer of new Unified Sink v2

2023-02-17 Thread Theo Diefenthal (Jira)
Theo Diefenthal created FLINK-31122: --- Summary: Expose MetricGroup to Committer of new Unified Sink v2 Key: FLINK-31122 URL: https://issues.apache.org/jira/browse/FLINK-31122 Project: Flink

[GitHub] [flink] snuyanzin commented on a diff in pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21958: URL: https://github.com/apache/flink/pull/21958#discussion_r1109698942 ## flink-python/pyflink/table/expression.py: ## @@ -1487,6 +1487,13 @@ def array_distinct(self) -> 'Expression': """ return

[GitHub] [flink] snuyanzin commented on pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-02-17 Thread via GitHub
snuyanzin commented on PR #21958: URL: https://github.com/apache/flink/pull/21958#issuecomment-1434551541 Thanks for your contribution. To be honest i didn't get the logic. What i did: 1. Built it from the PR's branch 2. Started standalone Flink 3. Via sqlClient submitted

[GitHub] [flink-table-store] SteNicholas closed pull request #209: [FLINK-27103] Don't store redundant primary key fields

2023-02-17 Thread via GitHub
SteNicholas closed pull request #209: [FLINK-27103] Don't store redundant primary key fields URL: https://github.com/apache/flink-table-store/pull/209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] snuyanzin commented on a diff in pull request #21958: [FLINK-31118][table] Add ARRAY_UNION function.

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21958: URL: https://github.com/apache/flink/pull/21958#discussion_r1109698642 ## docs/data/sql_functions.yml: ## @@ -617,6 +617,9 @@ collection: - sql: ARRAY_DISTINCT(haystack) table: haystack.arrayDistinct() description: Returns

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1109660825 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/plan/utils/FlinkRexUtilTest.scala: ## @@ -206,7 +206,7 @@ class FlinkRexUtilTest {

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1109660535 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/FlinkSubQueryRemoveRule.scala: ## @@ -304,13 +304,13 @@ class

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1109652438 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/trait/FlinkRelDistribution.scala: ## @@ -119,7 +119,7 @@ class

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1109652438 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/trait/FlinkRelDistribution.scala: ## @@ -119,7 +119,7 @@ class

[GitHub] [flink] snuyanzin commented on a diff in pull request #21934: [FLINK-27998][table] Upgrade Calcite to 1.30.0

2023-02-17 Thread via GitHub
snuyanzin commented on code in PR #21934: URL: https://github.com/apache/flink/pull/21934#discussion_r1109651676 ## flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/rules/logical/DecomposeGroupingSetsRule.scala: ## @@ -328,7 +328,7 @@ class

  1   2   >