[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-14 Thread via GitHub
SteNicholas commented on code in PR #584: URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1136549744 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java: ## @@ -82,6

[GitHub] [flink] chucheng92 commented on pull request #21904: [FLINK-30935][connectors/kafka] Add Kafka serializers deserialize check when using SimpleVersionedSerializer

2023-03-14 Thread via GitHub
chucheng92 commented on PR #21904: URL: https://github.com/apache/flink/pull/21904#issuecomment-1469368342 @leonardBang Hi, Xu, Can u help me to review it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-14 Thread via GitHub
SteNicholas commented on code in PR #584: URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1136549744 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java: ## @@ -82,6

[GitHub] [flink-table-store] SteNicholas commented on a diff in pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-14 Thread via GitHub
SteNicholas commented on code in PR #584: URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1136549744 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java: ## @@ -82,6

[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-03-14 Thread via GitHub
chucheng92 commented on PR #21442: URL: https://github.com/apache/flink/pull/21442#issuecomment-1469359601 > hi. @MartijnVisser i have updated the pr. And i searched the source code didn't find any other occurs using `org.apache.commons.collections`. PTAL. thanks. hi. @MartijnVisser

[GitHub] [flink] chucheng92 commented on pull request #22091: [FLINK-31319][connectors/kafka] Fix kafka partitionDiscoveryIntervalMs error condition check cause not set noMoreNewPartitionSplits

2023-03-14 Thread via GitHub
chucheng92 commented on PR #22091: URL: https://github.com/apache/flink/pull/22091#issuecomment-1469355704 @PatrickRen hi, qingsheng. PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-31457) Support waiting for required resources in DefaultScheduler during job restart

2023-03-14 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700503#comment-17700503 ] Junrui Li commented on FLINK-31457: --- [~a.pilipenko] I'm not sure what is the scenario where

[jira] [Comment Edited] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-14 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700500#comment-17700500 ] Jark Wu edited comment on FLINK-31368 at 3/15/23 4:26 AM: -- [~luoyuxia], you are

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-14 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700500#comment-17700500 ] Jark Wu commented on FLINK-31368: - [~luoyuxia], you are right. I think we can create another issue for

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #219: [FLINK-31422] Add Servable for Logistic Regression Model

2023-03-14 Thread via GitHub
lindong28 commented on code in PR #219: URL: https://github.com/apache/flink-ml/pull/219#discussion_r1136518610 ## flink-ml-servable-lib/src/test/java/org/apache/flink/ml/classification/logisticregression/LogisticRegressionModelServableTest.java: ## @@ -0,0 +1,153 @@ +/* + *

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #219: [FLINK-31422] Add Servable for Logistic Regression Model

2023-03-14 Thread via GitHub
lindong28 commented on code in PR #219: URL: https://github.com/apache/flink-ml/pull/219#discussion_r1136518610 ## flink-ml-servable-lib/src/test/java/org/apache/flink/ml/classification/logisticregression/LogisticRegressionModelServableTest.java: ## @@ -0,0 +1,153 @@ +/* + *

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #219: [FLINK-31422] Add Servable for Logistic Regression Model

2023-03-14 Thread via GitHub
lindong28 commented on code in PR #219: URL: https://github.com/apache/flink-ml/pull/219#discussion_r1136518106 ## flink-ml-lib/src/test/java/org/apache/flink/ml/classification/LogisticRegressionTest.java: ## @@ -253,6 +255,25 @@ public void testSaveLoadAndPredict() throws

[jira] [Commented] (FLINK-31380) Add filter support for ShowOperations

2023-03-14 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700499#comment-17700499 ] Ran Tao commented on FLINK-31380: - [~jark]  Hi, Jark. I added a lot of test cases and did integration

[jira] [Commented] (FLINK-31380) Add filter support for ShowOperations

2023-03-14 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700498#comment-17700498 ] Ran Tao commented on FLINK-31380: - show catalogs; +-+ |    catalog name |

[GitHub] [flink] flinkbot commented on pull request #22182: [BP-1.16][FLINK-31420][test] Fix unstable test ThreadInfoRequestCoordinatorTest#testShutDown.

2023-03-14 Thread via GitHub
flinkbot commented on PR #22182: URL: https://github.com/apache/flink/pull/22182#issuecomment-1469299098 ## CI report: * d1a3c2ef7490c7da79c7a1db446d983a6c0413fb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22181: [FLINK-31437][docs] Fix wrong key 'lookup.cache.caching-missing-key' in 'hbase.md'.

2023-03-14 Thread via GitHub
flinkbot commented on PR #22181: URL: https://github.com/apache/flink/pull/22181#issuecomment-1469299023 ## CI report: * 86c7796294d58dd44e189bf8ba4c3b105ea8725e UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] chucheng92 commented on pull request #22179: [FLIP-297][FLINK-31380][table] Add filter support for show operations

2023-03-14 Thread via GitHub
chucheng92 commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1469298702 @wuchong hi, jark. I added a lot of test cases and did integration testing for a while. Can u help me to review this feature? -- This is an automated message from the Apache Git

[GitHub] [flink] leonardBang commented on a diff in pull request #22170: [FLINK-30959][doc] Improve the documentation of UNIX_TIMESTAMP for different argument format

2023-03-14 Thread via GitHub
leonardBang commented on code in PR #22170: URL: https://github.com/apache/flink/pull/22170#discussion_r1136511081 ## docs/data/sql_functions.yml: ## @@ -499,7 +499,24 @@ temporal: description: Gets current Unix timestamp in seconds. This function is not deterministic

[GitHub] [flink] JunRuiLee commented on pull request #22174: [FLINK-31437][docs] Fix wrong key 'lookup.cache.caching-missing-key' in 'jdbc.md' and 'hbase.md'.

2023-03-14 Thread via GitHub
JunRuiLee commented on PR #22174: URL: https://github.com/apache/flink/pull/22174#issuecomment-1469296655 @leonardBang Thanks for the quick code review. Sure, I've opened three pr: release-1.16:https://github.com/apache/flink/pull/22174 release-1.17:

[GitHub] [flink] reswqa opened a new pull request, #22182: [BP-1.16][FLINK-31420][test] Fix unstable test ThreadInfoRequestCoordinatorTest#testShutDown.

2023-03-14 Thread via GitHub
reswqa opened a new pull request, #22182: URL: https://github.com/apache/flink/pull/22182 Backport FLINK-31420 to release-1.16. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] JunRuiLee opened a new pull request, #22181: [FLINK-31437][docs] Fix wrong key 'lookup.cache.caching-missing-key' in 'hbase.md'.

2023-03-14 Thread via GitHub
JunRuiLee opened a new pull request, #22181: URL: https://github.com/apache/flink/pull/22181 ## What is the purpose of the change Fix wrong key 'lookup.cache.caching-missing-key' in 'hbase.md'. ## Does this pull request potentially affect one of the following

[GitHub] [flink] flinkbot commented on pull request #22180: [FLINK-31420][test] Fix unstable test ThreadInfoRequestCoordinatorTest#testShutDown.

2023-03-14 Thread via GitHub
flinkbot commented on PR #22180: URL: https://github.com/apache/flink/pull/22180#issuecomment-1469281187 ## CI report: * c3cfa5253042e03aee0a7d07d1e91d52838a5bfa UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Comment Edited] (FLINK-31461) Supports schema historical version expiring

2023-03-14 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700494#comment-17700494 ] Jingsong Lee edited comment on FLINK-31461 at 3/15/23 3:48 AM: --- I think

[jira] [Commented] (FLINK-31461) Supports schema historical version expiring

2023-03-14 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700494#comment-17700494 ] Jingsong Lee commented on FLINK-31461: -- I think this is good > Supports schema historical version

[GitHub] [flink] WencongLiu commented on pull request #21645: [FLINK-30556] Improve the logic for enumerating splits for Hive source to avoid potential OOM

2023-03-14 Thread via GitHub
WencongLiu commented on PR #21645: URL: https://github.com/apache/flink/pull/21645#issuecomment-1469274967 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] reswqa opened a new pull request, #22180: [FLINK-31420][test] Fix unstable test ThreadInfoRequestCoordinatorTest#testShutDown.

2023-03-14 Thread via GitHub
reswqa opened a new pull request, #22180: URL: https://github.com/apache/flink/pull/22180 Backport FLINK-31420 to release-1.17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-table-store] JingsongLi commented on a diff in pull request #605: [FLINK-31430] Support migrating states between different instances of TableWriteImpl and AbstractFileStoreWrite

2023-03-14 Thread via GitHub
JingsongLi commented on code in PR #605: URL: https://github.com/apache/flink-table-store/pull/605#discussion_r1136499298 ## flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/AbstractFileStoreWrite.java: ## @@ -232,50 +210,131 @@ public void

[GitHub] [flink-table-store] JingsongLi merged pull request #606: [hotfix] Fix FlinkActionsE2eTest

2023-03-14 Thread via GitHub
JingsongLi merged PR #606: URL: https://github.com/apache/flink-table-store/pull/606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #22179: [FLIP-297][FLINK-31380][table] Add filter support for show operations

2023-03-14 Thread via GitHub
flinkbot commented on PR #22179: URL: https://github.com/apache/flink/pull/22179#issuecomment-1469265690 ## CI report: * fc06fe6b36ebdb7bf9b16842c3e6cc94cbeddfa2 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] chucheng92 opened a new pull request, #22179: [FLIP-297][FLINK-31380][table] Add filter support for show operations

2023-03-14 Thread via GitHub
chucheng92 opened a new pull request, #22179: URL: https://github.com/apache/flink/pull/22179 ## What is the purpose of the change Add filter support for show operations for [FLIP-297](https://cwiki.apache.org/confluence/display/FLINK/FLIP-297%3A+Improve+Auxiliary+Sql+Statements)

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #219: [FLINK-31422] Add Servable for Logistic Regression Model

2023-03-14 Thread via GitHub
jiangxin369 commented on code in PR #219: URL: https://github.com/apache/flink-ml/pull/219#discussion_r1136491018 ## flink-ml-lib/src/test/java/org/apache/flink/ml/classification/LogisticRegressionTest.java: ## @@ -253,6 +255,25 @@ public void testSaveLoadAndPredict() throws

[GitHub] [flink] wuchong closed pull request #22156: [FLINK-30129][table] Push projection through ChangelogNormalize

2023-03-14 Thread via GitHub
wuchong closed pull request #22156: [FLINK-30129][table] Push projection through ChangelogNormalize URL: https://github.com/apache/flink/pull/22156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Closed] (FLINK-30129) Push projection through ChangelogNormalize

2023-03-14 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jark Wu closed FLINK-30129. --- Resolution: Fixed Fixed in master:

[jira] [Commented] (FLINK-30181) MultiInputCheckpointingTimeBenchmark.checkpointMultiInput benchmark failed

2023-03-14 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700474#comment-17700474 ] Yanfei Lei commented on FLINK-30181:

[jira] [Commented] (FLINK-30805) SplitEnumerator#handleSplitRequest() should be called automatically

2023-03-14 Thread Mason Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700473#comment-17700473 ] Mason Chen commented on FLINK-30805: [~echauchot] left a comment, I'm not sure this change makes

[GitHub] [flink] PatrickRen commented on a diff in pull request #22146: [FLINK-31157][release] Add release note for version 1.17

2023-03-14 Thread via GitHub
PatrickRen commented on code in PR #22146: URL: https://github.com/apache/flink/pull/22146#discussion_r1136479162 ## docs/content.zh/release-notes/flink-1.17.md: ## @@ -0,0 +1,203 @@ +--- +title: "Release Notes - Flink 1.17" +--- + + +# Release notes - Flink 1.17 + +These

[GitHub] [flink] wuchong commented on a diff in pull request #22156: [FLINK-30129][table] Push projection through ChangelogNormalize

2023-03-14 Thread via GitHub
wuchong commented on code in PR #22156: URL: https://github.com/apache/flink/pull/22156#discussion_r1136478001 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/PushCalcPastChangelogNormalizeRule.java: ## @@ -0,0 +1,333

[GitHub] [flink] zhuzhurk closed pull request #22167: [hotfix] [doc] Fix the configuration item error of docs/content/docs/connectors/table/hbase.md

2023-03-14 Thread via GitHub
zhuzhurk closed pull request #22167: [hotfix] [doc] Fix the configuration item error of docs/content/docs/connectors/table/hbase.md URL: https://github.com/apache/flink/pull/22167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #219: [FLINK-31422] Add Servable for Logistic Regression Model

2023-03-14 Thread via GitHub
jiangxin369 commented on code in PR #219: URL: https://github.com/apache/flink-ml/pull/219#discussion_r1136472957 ## flink-ml-servable-lib/src/test/java/org/apache/flink/ml/classification/logisticregression/LogisticRegressionModelServableTest.java: ## @@ -0,0 +1,153 @@ +/* + *

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #219: [FLINK-31422] Add Servable for Logistic Regression Model

2023-03-14 Thread via GitHub
jiangxin369 commented on code in PR #219: URL: https://github.com/apache/flink-ml/pull/219#discussion_r1136472041 ## flink-ml-servable-lib/src/test/java/org/apache/flink/ml/classification/logisticregression/LogisticRegressionModelServableTest.java: ## @@ -0,0 +1,153 @@ +/* + *

[GitHub] [flink] godfreyhe commented on a diff in pull request #22156: [FLINK-30129][table] Push projection through ChangelogNormalize

2023-03-14 Thread via GitHub
godfreyhe commented on code in PR #22156: URL: https://github.com/apache/flink/pull/22156#discussion_r1136471769 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/physical/stream/PushCalcPastChangelogNormalizeRule.java: ## @@ -0,0 +1,333

[jira] [Created] (FLINK-31461) Supports schema historical version expiring

2023-03-14 Thread Shammon (Jira)
Shammon created FLINK-31461: --- Summary: Supports schema historical version expiring Key: FLINK-31461 URL: https://issues.apache.org/jira/browse/FLINK-31461 Project: Flink Issue Type: Improvement

[GitHub] [flink-table-store] yuzelin opened a new pull request, #606: [hotfix] fix FlinkActionsE2eTest

2023-03-14 Thread via GitHub
yuzelin opened a new pull request, #606: URL: https://github.com/apache/flink-table-store/pull/606 Delete misused `--detached` argument. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-table-store] JingsongLi merged pull request #590: [core] Introduce lookup changelog producer

2023-03-14 Thread via GitHub
JingsongLi merged PR #590: URL: https://github.com/apache/flink-table-store/pull/590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-31430) Support migrating states between different instances of TableWriteImpl and AbstractFileStoreWrite

2023-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31430: --- Labels: pull-request-available (was: ) > Support migrating states between different

[GitHub] [flink-table-store] tsreaper opened a new pull request, #605: [FLINK-31430] Support migrating states between different instances of TableWriteImpl and AbstractFileStoreWrite

2023-03-14 Thread via GitHub
tsreaper opened a new pull request, #605: URL: https://github.com/apache/flink-table-store/pull/605 Currently `Table` and `TableWrite` in Flink Table Store have a fixed schema. However to consume schema changes, Flink Table Store CDC sinks should have the ability to change its schema

[jira] [Closed] (FLINK-31453) Update the test utils to call methods explicitly

2023-03-14 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin closed FLINK-31453. Resolution: Fixed > Update the test utils to call methods explicitly >

[jira] [Commented] (FLINK-31453) Update the test utils to call methods explicitly

2023-03-14 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700460#comment-17700460 ] Dong Lin commented on FLINK-31453: -- Merged to apache/flink-ml master branch

[jira] [Closed] (FLINK-31431) Support copying a FileStoreTable with latest schema

2023-03-14 Thread Caizhi Weng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Caizhi Weng closed FLINK-31431. --- Resolution: Fixed master: c155b9d7c0a6ef40327116cac88659c6be975919 > Support copying a

[GitHub] [flink-ml] lindong28 merged pull request #225: [FLINK-31453] Update the test utils to call methods explicitly

2023-03-14 Thread via GitHub
lindong28 merged PR #225: URL: https://github.com/apache/flink-ml/pull/225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-ml] lindong28 commented on pull request #225: [FLINK-31453] Update the test utils to call methods explicitly

2023-03-14 Thread via GitHub
lindong28 commented on PR #225: URL: https://github.com/apache/flink-ml/pull/225#issuecomment-1469195403 Thanks for the PR. LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-31453) Improve the test utils to call methods explicitly

2023-03-14 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin reassigned FLINK-31453: Assignee: Jiang Xin > Improve the test utils to call methods explicitly >

[jira] [Updated] (FLINK-31453) Update the test utils to call methods explicitly

2023-03-14 Thread Dong Lin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dong Lin updated FLINK-31453: - Summary: Update the test utils to call methods explicitly (was: Improve the test utils to call methods

[jira] [Commented] (FLINK-31368) Move operation execution logic out from TableEnvironmentImpl

2023-03-14 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700458#comment-17700458 ] luoyuxia commented on FLINK-31368: -- [~jark] Also noticed `SqlToOperationConverter` has a similiar

[GitHub] [flink-table-store] tsreaper merged pull request #600: [FLINK-31431] Support copying a FileStoreTable with latest schema

2023-03-14 Thread via GitHub
tsreaper merged PR #600: URL: https://github.com/apache/flink-table-store/pull/600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] zoltar9264 commented on pull request #22168: [FLINK-31414][checkpointing] exceptions in the alignment timer are ig…

2023-03-14 Thread via GitHub
zoltar9264 commented on PR #22168: URL: https://github.com/apache/flink/pull/22168#issuecomment-1469191958 Thanks for your @pnowojski , I change the test as you commented and squash the commits. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (FLINK-31460) Fix hive catalog and connector jar name in the create release script for table store

2023-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31460: --- Labels: pull-request-available (was: ) > Fix hive catalog and connector jar name in the

[GitHub] [flink-table-store] zhuangchong opened a new pull request, #604: [FLINK-31460] Fix hive catalog and connector jar name in the create release script for table store

2023-03-14 Thread via GitHub
zhuangchong opened a new pull request, #604: URL: https://github.com/apache/flink-table-store/pull/604 Fix hive catalog and connector jar name in the create release script for table store -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (FLINK-31460) Fix hive catalog and connector jar name in the create release script for table store

2023-03-14 Thread zhuangchong (Jira)
zhuangchong created FLINK-31460: --- Summary: Fix hive catalog and connector jar name in the create release script for table store Key: FLINK-31460 URL: https://issues.apache.org/jira/browse/FLINK-31460

[jira] [Updated] (FLINK-31453) Improve the test utils to call methods explicitly

2023-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31453: --- Labels: pull-request-available (was: ) > Improve the test utils to call methods explicitly

[GitHub] [flink-ml] jiangxin369 opened a new pull request, #225: [FLINK-31453] Improve the test utils to call methods explicitly

2023-03-14 Thread via GitHub
jiangxin369 opened a new pull request, #225: URL: https://github.com/apache/flink-ml/pull/225 ## What is the purpose of the change Refactor the `TestUtils.saveAndReload` method to call the static `load` method of specific Stage explicitly. ## Brief change log

[GitHub] [flink-table-store] zhangjun0x01 commented on a diff in pull request #584: [FLINK-31338] support infer parallelism for flink table store

2023-03-14 Thread via GitHub
zhangjun0x01 commented on code in PR #584: URL: https://github.com/apache/flink-table-store/pull/584#discussion_r1136446719 ## flink-table-store-flink/flink-table-store-flink-common/src/main/java/org/apache/flink/table/store/connector/FlinkConnectorOptions.java: ## @@ -82,6

[jira] [Updated] (FLINK-31459) add UPDATE COLUMN POSITION for flink table store

2023-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31459: --- Labels: pull-request-available (was: ) > add UPDATE COLUMN POSITION for flink table store

[GitHub] [flink-table-store] zhangjun0x01 opened a new pull request, #603: [FLINK-31459]add UPDATE COLUMN POSITION for flink table store

2023-03-14 Thread via GitHub
zhangjun0x01 opened a new pull request, #603: URL: https://github.com/apache/flink-table-store/pull/603 add UPDATE COLUMN POSITION for flink table store -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (FLINK-31459) add UPDATE COLUMN POSITION for flink table store

2023-03-14 Thread Jun Zhang (Jira)
Jun Zhang created FLINK-31459: - Summary: add UPDATE COLUMN POSITION for flink table store Key: FLINK-31459 URL: https://issues.apache.org/jira/browse/FLINK-31459 Project: Flink Issue Type:

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #219: [FLINK-31422] Add Servable for Logistic Regression Model

2023-03-14 Thread via GitHub
lindong28 commented on code in PR #219: URL: https://github.com/apache/flink-ml/pull/219#discussion_r1136431138 ## flink-ml-servable-lib/src/main/java/org/apache/flink/ml/classification/logisticregression/LogisticRegressionModelServable.java: ## @@ -0,0 +1,148 @@ +/* + *

[jira] [Commented] (FLINK-29541) [JUnit5 Migration] Module: flink-table-planner

2023-03-14 Thread Jark Wu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700452#comment-17700452 ] Jark Wu commented on FLINK-29541: - Hi [~rskraba], I would suggest keeping this issue as is and creating

[jira] [Closed] (FLINK-31440) Split hive catalog to each module of each version

2023-03-14 Thread zhuangchong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zhuangchong closed FLINK-31440. --- Resolution: Won't Do > Split hive catalog to each module of each version >

[jira] [Commented] (FLINK-31440) Split hive catalog to each module of each version

2023-03-14 Thread zhuangchong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700449#comment-17700449 ] zhuangchong commented on FLINK-31440: - In 

[GitHub] [flink-table-store] zhuangchong closed pull request #601: [FLINK-31440] Split hive catalog to each module of each version

2023-03-14 Thread via GitHub
zhuangchong closed pull request #601: [FLINK-31440] Split hive catalog to each module of each version URL: https://github.com/apache/flink-table-store/pull/601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-table-store] zhuangchong commented on pull request #601: [FLINK-31440] Split hive catalog to each module of each version

2023-03-14 Thread via GitHub
zhuangchong commented on PR #601: URL: https://github.com/apache/flink-table-store/pull/601#issuecomment-1469111629 > Hi @zhuangchong Thanks for the contribution. In #569 , we found hive catalog with hive-2.3.9 can be used for every hive metastore versions, so we just keep one version for

[jira] [Closed] (FLINK-31438) Improved exception assertion for ContinuousFileStoreITCase

2023-03-14 Thread Jingsong Lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jingsong Lee closed FLINK-31438. Fix Version/s: table-store-0.4.0 Assignee: zhuangchong Resolution: Fixed master:

[GitHub] [flink-table-store] JingsongLi merged pull request #599: [FLINK-31438] Improved exception assertion for ContinuousFileStoreITCase

2023-03-14 Thread via GitHub
JingsongLi merged PR #599: URL: https://github.com/apache/flink-table-store/pull/599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] RamanVerma commented on a diff in pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-14 Thread via GitHub
RamanVerma commented on code in PR #22150: URL: https://github.com/apache/flink/pull/22150#discussion_r1136426195 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -241,6 +246,8 @@ public void close() throws

[GitHub] [flink-table-store] JingsongLi commented on pull request #601: [FLINK-31440] Split hive catalog to each module of each version

2023-03-14 Thread via GitHub
JingsongLi commented on PR #601: URL: https://github.com/apache/flink-table-store/pull/601#issuecomment-1469088058 Hi @zhuangchong Thanks for the contribution. In https://github.com/apache/flink-table-store/pull/569 , we found hive catalog with hive-2.3.9 can be used for every hive

[GitHub] [flink-table-store] JingsongLi merged pull request #602: [core] Introduce StreamTableScan to support checkpoint and restore

2023-03-14 Thread via GitHub
JingsongLi merged PR #602: URL: https://github.com/apache/flink-table-store/pull/602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] RamanVerma commented on a diff in pull request #22150: [FLINK-31305] Propagate producer exceptions outside of mailbox execut…

2023-03-14 Thread via GitHub
RamanVerma commented on code in PR #22150: URL: https://github.com/apache/flink/pull/22150#discussion_r1136403399 ## flink-connectors/flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/KafkaWriter.java: ## @@ -397,36 +409,57 @@ private void

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-14 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1136395017 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/WaitingForResources.java: ## @@ -144,12 +135,17 @@ public Logger getLogger() { }

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-14 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1136382696 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -216,11 +218,16 @@ private final

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-14 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1136373675 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -123,9 +123,18 @@ private void

[GitHub] [flink] dongjoon-hyun commented on pull request #19844: [FLINK-27805][Connectors/ORC] bump orc version to 1.7.5

2023-03-14 Thread via GitHub
dongjoon-hyun commented on PR #19844: URL: https://github.com/apache/flink/pull/19844#issuecomment-1469026424 Thank you, @pgaref and @liujiawinds . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (FLINK-31428) Add user callbacks to PulsarSource and PulsarSink

2023-03-14 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700406#comment-17700406 ] Yufan Sheng commented on FLINK-31428: - Add a `AutoCloseable` do make sense to me. BTW, I don't think

[GitHub] [flink] flinkbot commented on pull request #22178: [FLINK-30950][connectors][aws] Remove flink-connector-aws-base since …

2023-03-14 Thread via GitHub
flinkbot commented on PR #22178: URL: https://github.com/apache/flink/pull/22178#issuecomment-1468822240 ## CI report: * dfd76d47460ee60ac544397fe7e65e6017437028 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-30950) Remove flink-connector-aws-base from Flink main repo

2023-03-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-30950: --- Labels: pull-request-available (was: ) > Remove flink-connector-aws-base from Flink main

[GitHub] [flink] hlteoh37 opened a new pull request, #22178: [FLINK-30950][connectors][aws] Remove flink-connector-aws-base since …

2023-03-14 Thread via GitHub
hlteoh37 opened a new pull request, #22178: URL: https://github.com/apache/flink/pull/22178 …it has been migrated to flink-connector-aws ## What is the purpose of the change Remove flink-connector-aws-base from main Flink repository since it has been externalized to

[jira] [Closed] (FLINK-30949) Sync flink-connector-aws-base from Flink main to flink-connector-aws

2023-03-14 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hong Liang Teoh closed FLINK-30949. --- Resolution: Not A Problem > Sync flink-connector-aws-base from Flink main to

[jira] [Commented] (FLINK-30949) Sync flink-connector-aws-base from Flink main to flink-connector-aws

2023-03-14 Thread Hong Liang Teoh (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700370#comment-17700370 ] Hong Liang Teoh commented on FLINK-30949: - Did a diff between

[jira] [Commented] (FLINK-31428) Add user callbacks to PulsarSource and PulsarSink

2023-03-14 Thread Alpha Diallo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700359#comment-17700359 ] Alpha Diallo commented on FLINK-31428: -- Ok I see. Yes, the reason we added the factory is in case

[jira] [Closed] (FLINK-31458) Support waiting for required resources in DefaultScheduler during job restart

2023-03-14 Thread Aleksandr Pilipenko (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aleksandr Pilipenko closed FLINK-31458. --- Resolution: Duplicate > Support waiting for required resources in DefaultScheduler

[jira] [Created] (FLINK-31458) Support waiting for required resources in DefaultScheduler during job restart

2023-03-14 Thread Aleksandr Pilipenko (Jira)
Aleksandr Pilipenko created FLINK-31458: --- Summary: Support waiting for required resources in DefaultScheduler during job restart Key: FLINK-31458 URL: https://issues.apache.org/jira/browse/FLINK-31458

[jira] [Created] (FLINK-31457) Support waiting for required resources in DefaultScheduler during job restart

2023-03-14 Thread Aleksandr Pilipenko (Jira)
Aleksandr Pilipenko created FLINK-31457: --- Summary: Support waiting for required resources in DefaultScheduler during job restart Key: FLINK-31457 URL: https://issues.apache.org/jira/browse/FLINK-31457

[GitHub] [flink] kevincherian closed pull request #22177: Kc/issue 32

2023-03-14 Thread via GitHub
kevincherian closed pull request #22177: Kc/issue 32 URL: https://github.com/apache/flink/pull/22177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] kevincherian opened a new pull request, #22177: Kc/issue 32

2023-03-14 Thread via GitHub
kevincherian opened a new pull request, #22177: URL: https://github.com/apache/flink/pull/22177 ## What is the purpose of the change *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring

[jira] [Commented] (FLINK-31428) Add user callbacks to PulsarSource and PulsarSink

2023-03-14 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700323#comment-17700323 ] Yufan Sheng commented on FLINK-31428: - It's better to extend the {{ConsumerInterceptor}} and

[jira] [Comment Edited] (FLINK-31428) Add user callbacks to PulsarSource and PulsarSink

2023-03-14 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700319#comment-17700319 ] Yufan Sheng edited comment on FLINK-31428 at 3/14/23 5:36 PM: -- I don't

[jira] [Commented] (FLINK-31428) Add user callbacks to PulsarSource and PulsarSink

2023-03-14 Thread Yufan Sheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17700319#comment-17700319 ] Yufan Sheng commented on FLINK-31428: - I don't think it's ok to expose the deserialized/serialized

[GitHub] [flink] gaoyunhaii commented on pull request #21736: [FLINK-27518][tests] Refactor migration tests to support version update automatically

2023-03-14 Thread via GitHub
gaoyunhaii commented on PR #21736: URL: https://github.com/apache/flink/pull/21736#issuecomment-1468528005 Hi @XComp sorry for the long delay due to being bound recently, I have merged the previous commits except for the last change that reads latest published version from the file. I'll

[jira] [Assigned] (FLINK-28758) FlinkKafkaConsumer fails to stop with savepoint

2023-03-14 Thread Piotr Nowojski (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Piotr Nowojski reassigned FLINK-28758: -- Assignee: Mark Cho > FlinkKafkaConsumer fails to stop with savepoint >

[jira] [Updated] (FLINK-31319) Inconsistent condition judgement about kafka partitionDiscoveryIntervalMs cause potential bug

2023-03-14 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-31319: Affects Version/s: 1.17.0 1.16.2 > Inconsistent condition judgement about kafka

[jira] [Updated] (FLINK-31452) Show databases should better return sorted results

2023-03-14 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ran Tao updated FLINK-31452: Description: Currently TableEnv support return sorted views and tables.   {code:java} @Override public

  1   2   3   4   >