[jira] [Updated] (FLINK-31602) Add ARRAY_POSITION supported in SQL & Table API

2023-03-23 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] jackylau updated FLINK-31602: - Description: array_position(array, element) - Returns the (1-based) index of the first element of the

[jira] [Created] (FLINK-31602) Add ARRAY_POSITION supported in SQL & Table API

2023-03-23 Thread jackylau (Jira)
jackylau created FLINK-31602: Summary: Add ARRAY_POSITION supported in SQL & Table API Key: FLINK-31602 URL: https://issues.apache.org/jira/browse/FLINK-31602 Project: Flink Issue Type:

[GitHub] [flink] liuyongvs commented on pull request #22250: [FLINK-26945][table] Add built-in DATE_SUB function.

2023-03-23 Thread via GitHub
liuyongvs commented on PR #22250: URL: https://github.com/apache/flink/pull/22250#issuecomment-1482259513 hi @twalthr @wuchong do you have time to help review it ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] FangYongs commented on pull request #22235: [FLINK-31554][docs-zh] Translate "Overview" page of "sql-gateway" into Chinese

2023-03-23 Thread via GitHub
FangYongs commented on PR #22235: URL: https://github.com/apache/flink/pull/22235#issuecomment-1482256743 Thanks @fsk119 DONE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Assigned] (FLINK-31600) Fix producer leaks in flink-connector-kafka tests

2023-03-23 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-31600: --- Assignee: Alex Sorokoumov > Fix producer leaks in flink-connector-kafka

[jira] [Comment Edited] (FLINK-31600) Fix producer leaks in flink-connector-kafka tests

2023-03-23 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704460#comment-17704460 ] Tzu-Li (Gordon) Tai edited comment on FLINK-31600 at 3/24/23 5:01 AM:

[jira] [Commented] (FLINK-31600) Fix producer leaks in flink-connector-kafka tests

2023-03-23 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704460#comment-17704460 ] Tzu-Li (Gordon) Tai commented on FLINK-31600: - List of commits merged to

[GitHub] [flink-connector-kafka] tzulitai closed pull request #14: [FLINK-31600] Fix a producer leak in InfiniteStringsGenerator

2023-03-23 Thread via GitHub
tzulitai closed pull request #14: [FLINK-31600] Fix a producer leak in InfiniteStringsGenerator URL: https://github.com/apache/flink-connector-kafka/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink-connector-kafka] tzulitai closed pull request #13: [FLINK-31600] Fix a producer leak in KafkaMetricMutableWrapperTest

2023-03-23 Thread via GitHub
tzulitai closed pull request #13: [FLINK-31600] Fix a producer leak in KafkaMetricMutableWrapperTest URL: https://github.com/apache/flink-connector-kafka/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-connector-kafka] tzulitai closed pull request #12: [FLINK-31600] Fix a producer leak in KafkaCommitterTest

2023-03-23 Thread via GitHub
tzulitai closed pull request #12: [FLINK-31600] Fix a producer leak in KafkaCommitterTest URL: https://github.com/apache/flink-connector-kafka/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink] slfan1989 commented on pull request #22207: [FLINK-31510][yarn] Use getMemorySize instead of getMemory.

2023-03-23 Thread via GitHub
slfan1989 commented on PR #22207: URL: https://github.com/apache/flink/pull/22207#issuecomment-1482249297 > Thanks @slfan1989 for creating this. > > How did you manually verify this issue, could you describe it in detail? > > By the way, would you mind resolving conflict in

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #14: [FLINK-31600] Fix a producer leak in InfiniteStringsGenerator

2023-03-23 Thread via GitHub
tzulitai commented on PR #14: URL: https://github.com/apache/flink-connector-kafka/pull/14#issuecomment-1482248538 +1, LGTM. Thanks again @Ge :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #13: [FLINK-31600] Fix a producer leak in KafkaMetricMutableWrapperTest

2023-03-23 Thread via GitHub
tzulitai commented on PR #13: URL: https://github.com/apache/flink-connector-kafka/pull/13#issuecomment-1482242048 +1, LGTM. Merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-31600) Fix producer leaks in flink-connector-kafka tests

2023-03-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31600: --- Labels: pull-request-available (was: ) > Fix producer leaks in flink-connector-kafka tests

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #12: [FLINK-31600] Fix a producer leak in KafkaCommitterTest

2023-03-23 Thread via GitHub
tzulitai commented on PR #12: URL: https://github.com/apache/flink-connector-kafka/pull/12#issuecomment-1482240786 +1, LGTM. Thanks @Ge, merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [flink] xintongsong commented on a diff in pull request #22176: [FLINK-31441][runtime]FineGrainedSlotManager support evenly slot selection.

2023-03-23 Thread via GitHub
xintongsong commented on code in PR #22176: URL: https://github.com/apache/flink/pull/22176#discussion_r1147090634 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -237,27 +239,133 @@ &&

[jira] [Commented] (FLINK-31594) Updates the docs stable version

2023-03-23 Thread Wencong Liu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704452#comment-17704452 ] Wencong Liu commented on FLINK-31594: - Hello [~mapohl] , I'd like to take this ticket. > Updates

[GitHub] [flink] FangYongs commented on pull request #22237: [FLINK-31556][docs-zh] Translate "rest" page of "sql-gateway" into Chinese

2023-03-23 Thread via GitHub
FangYongs commented on PR #22237: URL: https://github.com/apache/flink/pull/22237#issuecomment-1482223497 Thanks @fsk119 , updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink] huwh commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-23 Thread via GitHub
huwh commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1147098151 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -730,15 +748,49 @@ public CompletableFuture

[jira] [Assigned] (FLINK-31572) Other announcements

2023-03-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-31572: - Assignee: Qingsheng Ren > Other announcements > --- > >

[jira] [Resolved] (FLINK-31572) Other announcements

2023-03-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren resolved FLINK-31572. --- Resolution: Fixed > Other announcements > --- > > Key:

[jira] [Commented] (FLINK-31572) Other announcements

2023-03-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704450#comment-17704450 ] Qingsheng Ren commented on FLINK-31572: --- * 1.17.0 has been registered with release date

[GitHub] [flink] flinkbot commented on pull request #22260: [hotfix] Revert some unexpected changes.

2023-03-23 Thread via GitHub
flinkbot commented on PR #22260: URL: https://github.com/apache/flink/pull/22260#issuecomment-1482211820 ## CI report: * fd7cc72b7fe90ad6ed16993c4e0652bbf7851076 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] WencongLiu commented on pull request #22121: [FLINK-27051] fix CompletedCheckpoint.DiscardObject.discard is not idempotent

2023-03-23 Thread via GitHub
WencongLiu commented on PR #22121: URL: https://github.com/apache/flink/pull/22121#issuecomment-1482210191 cc @XComp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Comment Edited] (FLINK-31577) Upgrade documentation to improve Operator

2023-03-23 Thread Jeff Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704445#comment-17704445 ] Jeff Yang edited comment on FLINK-31577 at 3/24/23 3:49 AM: Honestly, when

[GitHub] [flink] chucheng92 commented on pull request #22254: [FLINK-31597][table] Cleanup usage of deprecated TableEnvironment#registerFunction

2023-03-23 Thread via GitHub
chucheng92 commented on PR #22254: URL: https://github.com/apache/flink/pull/22254#issuecomment-1482209920 ci failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] WencongLiu closed pull request #21624: [FLINK-29125] Add rest port to the ResponseBody of ClusterOverview

2023-03-23 Thread via GitHub
WencongLiu closed pull request #21624: [FLINK-29125] Add rest port to the ResponseBody of ClusterOverview URL: https://github.com/apache/flink/pull/21624 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (FLINK-31577) Upgrade documentation to improve Operator

2023-03-23 Thread Jeff Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Yang updated FLINK-31577: -- Attachment: screenshot-1.png > Upgrade documentation to improve Operator >

[jira] [Commented] (FLINK-31577) Upgrade documentation to improve Operator

2023-03-23 Thread Jeff Yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704445#comment-17704445 ] Jeff Yang commented on FLINK-31577: --- Honestly, when users upgrade the version of operator, I would

[GitHub] [flink] WencongLiu closed pull request #19708: [hot-fix][flink-streaming-java] Delete the udfname not used in the reduce function of AllWindowedStream.

2023-03-23 Thread via GitHub
WencongLiu closed pull request #19708: [hot-fix][flink-streaming-java] Delete the udfname not used in the reduce function of AllWindowedStream. URL: https://github.com/apache/flink/pull/19708 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] huwh commented on pull request #22260: [hotfix] Revert some unexpected changes.

2023-03-23 Thread via GitHub
huwh commented on PR #22260: URL: https://github.com/apache/flink/pull/22260#issuecomment-1482208820 @1996fanrui Could you please take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink] WencongLiu commented on pull request #21645: [FLINK-30556] Introduce the StaticHivePartitionSplitEnumerator

2023-03-23 Thread via GitHub
WencongLiu commented on PR #21645: URL: https://github.com/apache/flink/pull/21645#issuecomment-1482208760 cc @luoyuxia -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] huwh opened a new pull request, #22260: [hotfix] Revert some unexpected changes.

2023-03-23 Thread via GitHub
huwh opened a new pull request, #22260: URL: https://github.com/apache/flink/pull/22260 ## What is the purpose of the change Take back the following submitted changes: db3a0a59519b279d016489e1bf29927a4f62a6ed 1993ad0c968efa60ad5071e8472f630b247251f0

[jira] [Commented] (FLINK-31596) Cleanup usage of deprecated methods in TableEnvironment

2023-03-23 Thread Ran Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704441#comment-17704441 ] Ran Tao commented on FLINK-31596: - hi, jark. it's a good improvement to remove deprecated methods in

[jira] [Commented] (FLINK-31570) Remove outdated versions

2023-03-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704436#comment-17704436 ] Qingsheng Ren commented on FLINK-31570: --- I'm wondering if we should remove 1.15 from svn and CI

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-23 Thread via GitHub
1996fanrui commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1147080699 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -844,7 +846,7 @@ private ApplicationReport startAppMaster( final

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-23 Thread via GitHub
1996fanrui commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1147080385 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1265,11 +1266,9 @@ private ApplicationReport startAppMaster(

[jira] [Assigned] (FLINK-31570) Remove outdated versions

2023-03-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Qingsheng Ren reassigned FLINK-31570: - Assignee: Qingsheng Ren > Remove outdated versions > > >

[jira] [Updated] (FLINK-31598) Cleanup usage of deprecated TableEnvironment#registerTable

2023-03-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31598: --- Labels: pull-request-available (was: ) > Cleanup usage of deprecated

[GitHub] [flink] chucheng92 commented on pull request #22255: [FLINK-31598][table] Cleanup usage of deprecated TableEnvironment#registerTable

2023-03-23 Thread via GitHub
chucheng92 commented on PR #22255: URL: https://github.com/apache/flink/pull/22255#issuecomment-1482194877 @wuchong hi, jark. Another question, do we have a timeline (e.g. 1.18) to remove these deprecate methods, otherwise it is still possible for implementors to call these methods. (In

[GitHub] [flink] huwh commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-23 Thread via GitHub
huwh commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1147075029 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -1265,11 +1266,9 @@ private ApplicationReport startAppMaster( if

[GitHub] [flink] reswqa commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-23 Thread via GitHub
reswqa commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1147076155 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22084: [FLINK-31293][runtime] LocalBufferPool request overdraft buffer only when no available buffer and pool size is reached

2023-03-23 Thread via GitHub
1996fanrui commented on code in PR #22084: URL: https://github.com/apache/flink/pull/22084#discussion_r1147074854 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -503,12 +508,11 @@ private void onGlobalPoolAvailable() {

[GitHub] [flink] fredia commented on pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-03-23 Thread via GitHub
fredia commented on PR #21822: URL: https://github.com/apache/flink/pull/21822#issuecomment-1482183186 @zoltar9264 Thanks for the review, I refactored all `persist(sqn)` to `persist(sqn,long)`, and sorry for the misunderstood, I added null check before registering local handle as you

[jira] [Commented] (FLINK-31566) Publish the Dockerfiles for the new release

2023-03-23 Thread Qingsheng Ren (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704421#comment-17704421 ] Qingsheng Ren commented on FLINK-31566: --- Image is online now: 

[GitHub] [flink] 1996fanrui commented on a diff in pull request #22028: [FLINK-31230] Improve YarnClusterDescriptor memory unit display.

2023-03-23 Thread via GitHub
1996fanrui commented on code in PR #22028: URL: https://github.com/apache/flink/pull/22028#discussion_r1147066605 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -844,7 +846,7 @@ private ApplicationReport startAppMaster( final

[jira] [Closed] (FLINK-31555) Translate "hiveserver2" page of "sql-gateway" into Chinese

2023-03-23 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang closed FLINK-31555. - Fix Version/s: 1.18.0 Resolution: Implemented Merged into master:

[jira] [Assigned] (FLINK-31555) Translate "hiveserver2" page of "sql-gateway" into Chinese

2023-03-23 Thread Shengkai Fang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shengkai Fang reassigned FLINK-31555: - Assignee: Fang Yong > Translate "hiveserver2" page of "sql-gateway" into Chinese >

[GitHub] [flink] fsk119 commented on a diff in pull request #22235: [FLINK-31554][docs-zh] Translate "Overview" page of "sql-gateway" into Chinese

2023-03-23 Thread via GitHub
fsk119 commented on code in PR #22235: URL: https://github.com/apache/flink/pull/22235#discussion_r1147059425 ## docs/content.zh/docs/dev/table/sql-gateway/overview.md: ## @@ -27,35 +27,33 @@ under the License. Introduction Review Comment: 我感觉每一小节的标题也可以翻译一下?以及第二行整个页面的标题

[GitHub] [flink] fsk119 merged pull request #22236: [FLINK-31555][docs-zh] Translate "hiveserver2" page of "sql-gateway" into Chinese

2023-03-23 Thread via GitHub
fsk119 merged PR #22236: URL: https://github.com/apache/flink/pull/22236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] fsk119 commented on a diff in pull request #22237: [FLINK-31556][docs-zh] Translate "rest" page of "sql-gateway" into Chinese

2023-03-23 Thread via GitHub
fsk119 commented on code in PR #22237: URL: https://github.com/apache/flink/pull/22237#discussion_r1147045166 ## docs/content.zh/docs/dev/table/sql-gateway/rest.md: ## @@ -123,9 +120,9 @@ The OpenAPI specification is still experimental. Data Type Mapping

[jira] [Commented] (FLINK-18996) Avoid disorder for time interval join

2023-03-23 Thread Lyn Zhang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704410#comment-17704410 ] Lyn Zhang commented on FLINK-18996: --- [~lincoln.86xy] , I have updated [this

[GitHub] [flink] chucheng92 commented on pull request #21442: [FLINK-30274] Bump commons-collections 3.x to commons-collections4

2023-03-23 Thread via GitHub
chucheng92 commented on PR #21442: URL: https://github.com/apache/flink/pull/21442#issuecomment-1482162760 @MartijnVisser thanks for explanations. make sense. we will be watching closely about kafka externalization. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink-web] EricBrzezenski commented on pull request #625: [FLINK-31081][Documentation] Updating Jira Dashboard links to point to the #Issue-tracker

2023-03-23 Thread via GitHub
EricBrzezenski commented on PR #625: URL: https://github.com/apache/flink-web/pull/625#issuecomment-1482159235 I believe i addressed all the comments, thank you for the review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] DavidLiu001 commented on pull request #22241: [FLINK-31542][connectors] Fix FatalExceptionClassifier semantics of r…

2023-03-23 Thread via GitHub
DavidLiu001 commented on PR #22241: URL: https://github.com/apache/flink/pull/22241#issuecomment-1482158456 @flinkbot please run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (FLINK-31589) Reduce the pressure of the list pod method on the k8s cluster

2023-03-23 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704406#comment-17704406 ] liuzhuo commented on FLINK-31589: - [~huwh]  Thank you for your reminder, it is indeed the same problem,

[jira] [Updated] (FLINK-31589) Reduce the pressure of the list pod method on the k8s cluster

2023-03-23 Thread liuzhuo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liuzhuo updated FLINK-31589: Attachment: (was: image-2023-03-23-19-45-56-532.png) > Reduce the pressure of the list pod method on

[GitHub] [flink] FangYongs commented on pull request #22259: [FLINK-31522] Introduce FlinkResultSet for jdbc driver

2023-03-23 Thread via GitHub
FangYongs commented on PR #22259: URL: https://github.com/apache/flink/pull/22259#issuecomment-1482115641 Hi @libenchao Please help to review this PR when you are free -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] FangYongs commented on pull request #22233: [FLINK-31538][jdbc-driver] Supports parse catalog/database and properties for uri

2023-03-23 Thread via GitHub
FangYongs commented on PR #22233: URL: https://github.com/apache/flink/pull/22233#issuecomment-1482115252 Hi @libenchao Please help to review this PR when you are free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [flink] flinkbot commented on pull request #22259: [FLINK-31522] Introduce FlinkResultSet for jdbc driver

2023-03-23 Thread via GitHub
flinkbot commented on PR #22259: URL: https://github.com/apache/flink/pull/22259#issuecomment-1482114819 ## CI report: * 29e85520f4073c4e1b14f63b2fa52d1f00cd124c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31522) Introduce FlinkResultSet and related classes for jdbc driver

2023-03-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31522: --- Labels: pull-request-available (was: ) > Introduce FlinkResultSet and related classes for

[GitHub] [flink] FangYongs opened a new pull request, #22259: [FLINK-31522] Introduce FlinkResultSet for jdbc driver

2023-03-23 Thread via GitHub
FangYongs opened a new pull request, #22259: URL: https://github.com/apache/flink/pull/22259 ## What is the purpose of the change This PR aims to introduce FlinkResultSet for jdbc driver ## Brief change log - Added BaseResultSet for unsupported feature in ResultSet -

[GitHub] [flink] xuzhiwen1255 commented on a diff in pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-23 Thread via GitHub
xuzhiwen1255 commented on code in PR #22208: URL: https://github.com/apache/flink/pull/22208#discussion_r1147018992 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/operations/converters/SqlCreateTableAsConverter.java: ## @@ -0,0 +1,82 @@ +/* + *

[GitHub] [flink] xuzhiwen1255 commented on pull request #22208: [FLINK-31499] [table-planner] Move SqlCreateTable conversion logic to SqlCreateTableConverter

2023-03-23 Thread via GitHub
xuzhiwen1255 commented on PR #22208: URL: https://github.com/apache/flink/pull/22208#issuecomment-1482107532 @wuchong Compiled through. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Assigned] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-03-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-30859: -- Assignee: Tzu-Li (Gordon) Tai > Remove flink-connector-kafka from master branch >

[GitHub] [flink] MartijnVisser commented on pull request #22228: [FLINK-31049] [flink-connector-kafka]Add support for Kafka record headers to KafkaSink

2023-03-23 Thread via GitHub
MartijnVisser commented on PR #8: URL: https://github.com/apache/flink/pull/8#issuecomment-1482016410 @AlexAxeman Given that https://issues.apache.org/jira/browse/FLINK-30859 will be worked on shortly, could you open this PR towards `apache/flink-connector-kafka:main` -- This is

[jira] [Commented] (FLINK-31600) Fix producer leaks in flink-connector-kafka tests

2023-03-23 Thread Alex Sorokoumov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704379#comment-17704379 ] Alex Sorokoumov commented on FLINK-31600: - Patches: *

[jira] [Commented] (FLINK-31599) Update Kafka dependency in flink-connector-kafka to 3.4.0

2023-03-23 Thread Alex Sorokoumov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704378#comment-17704378 ] Alex Sorokoumov commented on FLINK-31599: - Patch -

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #15: [FLINK-31363] Do not checkpoint a KafkaCommittable if the transaction was empty

2023-03-23 Thread via GitHub
tzulitai commented on PR #15: URL: https://github.com/apache/flink-connector-kafka/pull/15#issuecomment-1481995033 cc @RamanVerma @Ge for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-connector-kafka] boring-cyborg[bot] commented on pull request #15: [FLINK-31363] Do not checkpoint a KafkaCommittable if the transaction was empty

2023-03-23 Thread via GitHub
boring-cyborg[bot] commented on PR #15: URL: https://github.com/apache/flink-connector-kafka/pull/15#issuecomment-1481994152 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[GitHub] [flink-connector-kafka] tzulitai opened a new pull request, #15: [FLINK-31363] Do not checkpoint a KafkaCommittable if the transaction was empty

2023-03-23 Thread via GitHub
tzulitai opened a new pull request, #15: URL: https://github.com/apache/flink-connector-kafka/pull/15 This PR fixes FLINK-31363 by changing how we handle empty transactions on `prepareCommit`. Previously, regardless of whether the current transaction is empty or non-empty, we always

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-23 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1146928351 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -1051,35 +1109,25 @@ private ExecutionGraph

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-23 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1146928351 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -1051,35 +1109,25 @@ private ExecutionGraph

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-23 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1146926263 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -123,9 +123,18 @@ private void

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-23 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1146919051 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/WaitingForResources.java: ## @@ -144,12 +135,17 @@ public Logger getLogger() { }

[jira] [Created] (FLINK-31601) While waiting for resources, resources check might be scheduled unlimited number of times (Adaptive Scheduler)

2023-03-23 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-31601: - Summary: While waiting for resources, resources check might be scheduled unlimited number of times (Adaptive Scheduler) Key: FLINK-31601 URL:

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-23 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1146911825 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java: ## @@ -730,15 +748,49 @@ public CompletableFuture

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22169: [FLINK-31399] AdaptiveScheduler is able to handle changes in job resource requirements.

2023-03-23 Thread via GitHub
rkhachatryan commented on code in PR #22169: URL: https://github.com/apache/flink/pull/22169#discussion_r1146909587 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/Executing.java: ## @@ -123,9 +123,18 @@ private void

[jira] [Updated] (FLINK-31599) Update Kafka dependency in flink-connector-kafka to 3.4.0

2023-03-23 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-31599: --- Issue Type: Technical Debt (was: New Feature) > Update Kafka dependency in

[GitHub] [flink] MartijnVisser commented on pull request #21035: [FLINK-29563] Add a timeout in the wait of metrics counter in SourceTestSuiteBase#testSourceMetrics

2023-03-23 Thread via GitHub
MartijnVisser commented on PR #21035: URL: https://github.com/apache/flink/pull/21035#issuecomment-1481949504 @tzulitai Also any thoughts on this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] MartijnVisser commented on pull request #22124: [FLINK-30805] Ask for a new split when one has finished in SourceReader default implementation

2023-03-23 Thread via GitHub
MartijnVisser commented on PR #22124: URL: https://github.com/apache/flink/pull/22124#issuecomment-1481948846 @tzulitai WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-31600) Fix producer leaks in flink-connector-kafka tests

2023-03-23 Thread Alex Sorokoumov (Jira)
Alex Sorokoumov created FLINK-31600: --- Summary: Fix producer leaks in flink-connector-kafka tests Key: FLINK-31600 URL: https://issues.apache.org/jira/browse/FLINK-31600 Project: Flink

[jira] [Commented] (FLINK-23978) FieldAccessor has direct scala dependency

2023-03-23 Thread Alexey Novakov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-23978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704357#comment-17704357 ] Alexey Novakov commented on FLINK-23978: I do not have flink-scala on the classpath. I guess the

[GitHub] [flink-web] JingGe commented on a diff in pull request #624: remove Jekyll toc

2023-03-23 Thread via GitHub
JingGe commented on code in PR #624: URL: https://github.com/apache/flink-web/pull/624#discussion_r1146846867 ## docs/content/posts/2019-08-22-release-1.9.0.md: ## @@ -42,7 +42,7 @@ lists](https://flink.apache.org/community.html#mailing-lists) or feedback is very much

[GitHub] [flink] flinkbot commented on pull request #22258: [BP-1.17][FLINK-31593][tests] Upgraded migration test data

2023-03-23 Thread via GitHub
flinkbot commented on PR #22258: URL: https://github.com/apache/flink/pull/22258#issuecomment-1481832256 ## CI report: * adb0aa875f71b1797f9e00dca1a58992f512274c UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] flinkbot commented on pull request #22257: [FLINK-31593][tests] Upgraded migration test data

2023-03-23 Thread via GitHub
flinkbot commented on PR #22257: URL: https://github.com/apache/flink/pull/22257#issuecomment-1481832101 ## CI report: * 955497b34cf9d9463da0cd09b7560fc31e88808d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] XComp opened a new pull request, #22258: [FLINK-31593][tests] Upgraded migration test data

2023-03-23 Thread via GitHub
XComp opened a new pull request, #22258: URL: https://github.com/apache/flink/pull/22258 The data was generated based on release-1.17.0. corresponding `master` PR: #22257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] XComp opened a new pull request, #22257: [FLINK-31593][tests] Upgraded migration test data

2023-03-23 Thread via GitHub
XComp opened a new pull request, #22257: URL: https://github.com/apache/flink/pull/22257 The data was generated based on `release-1.17.0`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (FLINK-31593) Update reference data for Migration Tests

2023-03-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31593: --- Labels: pull-request-available (was: ) > Update reference data for Migration Tests >

[jira] [Commented] (FLINK-31566) Publish the Dockerfiles for the new release

2023-03-23 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704328#comment-17704328 ] Robert Metzger commented on FLINK-31566: Opened a PR with the official docker library:

[GitHub] [flink-docker] XComp merged pull request #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles

2023-03-23 Thread via GitHub
XComp merged PR #153: URL: https://github.com/apache/flink-docker/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink-docker] XComp commented on pull request #153: [FLINK-31566][docker] Removes 1.15 and adds 1.17 Dockerfiles

2023-03-23 Thread via GitHub
XComp commented on PR #153: URL: https://github.com/apache/flink-docker/pull/153#issuecomment-1481747319 Thanks for the review, @PatrickRen and @rmetzger . I squashed the changes into meaningful chunks (and left 1.15 data in for now). @rmetzger will pick up the work on FLINK-31566 after

[jira] [Commented] (FLINK-31593) Update reference data for Migration Tests

2023-03-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704318#comment-17704318 ] Matthias Pohl commented on FLINK-31593: --- {{FlinkKafkaProducerMigrationTest}} is missed in the

[jira] [Assigned] (FLINK-31599) Update Kafka dependency in flink-connector-kafka to 3.4.0

2023-03-23 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tzu-Li (Gordon) Tai reassigned FLINK-31599: --- Assignee: Alex Sorokoumov > Update Kafka dependency in

[GitHub] [flink-kubernetes-operator] kingsathurthi opened a new pull request, #552: Fixing the container vulnerability by updating maven dependency

2023-03-23 Thread via GitHub
kingsathurthi opened a new pull request, #552: URL: https://github.com/apache/flink-kubernetes-operator/pull/552 ## What is the purpose of the change *This Pull request updates the SnakeYaml Maven dependency from 1.33 to 2.0 to fix the container vulnerability

[jira] [Created] (FLINK-31599) Update Kafka dependency in flink-connector-kafka to 3.4.0

2023-03-23 Thread Alex Sorokoumov (Jira)
Alex Sorokoumov created FLINK-31599: --- Summary: Update Kafka dependency in flink-connector-kafka to 3.4.0 Key: FLINK-31599 URL: https://issues.apache.org/jira/browse/FLINK-31599 Project: Flink

[jira] [Commented] (FLINK-31593) Update reference data for Migration Tests

2023-03-23 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704292#comment-17704292 ] Matthias Pohl commented on FLINK-31593: --- {{BucketingSinkMigrationTest}} not available anymore? >

[jira] [Comment Edited] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-03-23 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704287#comment-17704287 ] Tzu-Li (Gordon) Tai edited comment on FLINK-30859 at 3/23/23 5:59 PM:

[jira] [Comment Edited] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-03-23 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704287#comment-17704287 ] Tzu-Li (Gordon) Tai edited comment on FLINK-30859 at 3/23/23 5:59 PM:

[jira] [Commented] (FLINK-30859) Remove flink-connector-kafka from master branch

2023-03-23 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17704287#comment-17704287 ] Tzu-Li (Gordon) Tai commented on FLINK-30859: - [~mason6345] yeh for FLINK-31305 we don't

  1   2   3   4   5   6   7   8   9   >