[GitHub] [flink-ml] zhipeng93 commented on a diff in pull request #216: [FLINK-31173] Fix serveral iteration bugs

2023-04-19 Thread via GitHub
zhipeng93 commented on code in PR #216: URL: https://github.com/apache/flink-ml/pull/216#discussion_r1172105766 ## flink-ml-tests/src/test/java/org/apache/flink/test/iteration/BoundedTailOperatorWithUnionInputIterationITCase.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the

[jira] [Assigned] (FLINK-31708) RuntimeException/KryoException thrown when deserializing an empty protobuf record

2023-04-19 Thread Yun Gao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Gao reassigned FLINK-31708: --- Assignee: shen > RuntimeException/KryoException thrown when deserializing an empty protobuf >

[jira] [Created] (FLINK-31861) Introduce ByteArraySchema which serialize/deserialize data of type byte array

2023-04-19 Thread Dian Fu (Jira)
Dian Fu created FLINK-31861: --- Summary: Introduce ByteArraySchema which serialize/deserialize data of type byte array Key: FLINK-31861 URL: https://issues.apache.org/jira/browse/FLINK-31861 Project: Flink

[jira] [Closed] (FLINK-20038) Rectify the usage of ResultPartitionType#isPipelined() in partition tracker.

2023-04-19 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-20038. -- Resolution: Resolved Closed as this has been already covered by FLINK-27902. > Rectify the usage of

[GitHub] [flink] MartijnVisser commented on pull request #22400: [FLINK-31689][flink-connector-files] Check expired file state before …

2023-04-19 Thread via GitHub
MartijnVisser commented on PR #22400: URL: https://github.com/apache/flink/pull/22400#issuecomment-1515696575 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Closed] (FLINK-31853) Remove use of ExecutionAttemptMappingProvider

2023-04-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-31853. --- Resolution: Done > Remove use of ExecutionAttemptMappingProvider >

[jira] [Commented] (FLINK-31853) Remove use of ExecutionAttemptMappingProvider

2023-04-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714400#comment-17714400 ] Zhu Zhu commented on FLINK-31853: - Thanks for reporting this issue and fixing it! [~JunRuiLi] Done via

[jira] [Commented] (FLINK-30863) Register local recovery files of changelog before notifyCheckpointComplete()

2023-04-19 Thread Yanfei Lei (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714399#comment-17714399 ] Yanfei Lei commented on FLINK-30863: [~Feifan Wang] Thanks for your proposal!  “2. delete by not

[GitHub] [flink] zhuzhurk closed pull request #22429: [FLINK-31853][runtime] Remove use of ExecutionAttemptMappingProvider

2023-04-19 Thread via GitHub
zhuzhurk closed pull request #22429: [FLINK-31853][runtime] Remove use of ExecutionAttemptMappingProvider URL: https://github.com/apache/flink/pull/22429 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink-ml] jiangxin369 commented on a diff in pull request #233: [FLINK-31373] Fix NPE thrown in ProxyOutput

2023-04-19 Thread via GitHub
jiangxin369 commented on code in PR #233: URL: https://github.com/apache/flink-ml/pull/233#discussion_r1172048915 ## flink-ml-iteration/src/main/java/org/apache/flink/iteration/operator/allround/OneInputAllRoundWrapperOperator.java: ## @@ -87,7 +90,9 @@ public void

[jira] [Updated] (FLINK-31853) Remove use of ExecutionAttemptMappingProvider

2023-04-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-31853: Issue Type: Technical Debt (was: Improvement) > Remove use of ExecutionAttemptMappingProvider >

[jira] [Updated] (FLINK-31860) FlinkDeployments never finalize when namespace is deleted

2023-04-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-31860: --- Priority: Blocker (was: Minor) > FlinkDeployments never finalize when namespace is deleted >

[jira] [Assigned] (FLINK-31860) FlinkDeployments never finalize when namespace is deleted

2023-04-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-31860: -- Assignee: Gyula Fora > FlinkDeployments never finalize when namespace is deleted >

[jira] [Commented] (FLINK-31860) FlinkDeployments never finalize when namespace is deleted

2023-04-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714393#comment-17714393 ] Gyula Fora commented on FLINK-31860: Thank you for the detailed analysis , event triggering seems to

[jira] [Commented] (FLINK-30863) Register local recovery files of changelog before notifyCheckpointComplete()

2023-04-19 Thread Feifan Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714392#comment-17714392 ] Feifan Wang commented on FLINK-30863: - There are two known issues with dstl file cleanup: # local

[jira] [Assigned] (FLINK-30815) BatchTestBase/BatchAbstractTestBase are using JUnit4 while some child tests are using JUnit5

2023-04-19 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan reassigned FLINK-30815: - Assignee: (was: Yuxin Tan) > BatchTestBase/BatchAbstractTestBase are using JUnit4 while

[GitHub] [flink] fsk119 commented on pull request #22063: [FLINK-24909][Table SQL/Client] Add syntax highlighting

2023-04-19 Thread via GitHub
fsk119 commented on PR #22063: URL: https://github.com/apache/flink/pull/22063#issuecomment-1515662255 Thanks for your update. The new change LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #567: [FLINK-31815] Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency

2023-04-19 Thread via GitHub
yangjf2019 commented on PR #567: URL: https://github.com/apache/flink-kubernetes-operator/pull/567#issuecomment-1515659259 I understand that although I was able to compile the project locally, the CI was running with the lower version of the `org.yaml:snakeyaml:1.33` dependency in

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #567: [FLINK-31815] Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency

2023-04-19 Thread via GitHub
yangjf2019 commented on PR #567: URL: https://github.com/apache/flink-kubernetes-operator/pull/567#issuecomment-1515657414 The following exception was found in the error log and looks like a conflict with the snakeyaml package in `org.apache.flink:flink-kubernetes`.

[jira] [Commented] (FLINK-31858) Add Autoscaler support for Session Job

2023-04-19 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714383#comment-17714383 ] Weihua Hu commented on FLINK-31858: --- Hi, [~phoebemaomao] Can you describe the scenario in more detail? 

[GitHub] [flink] meijies closed pull request #14501: [FLINK-20778] the comment for the type of kafka consumer is wrong at KafkaPartitionSplit

2023-04-19 Thread via GitHub
meijies closed pull request #14501: [FLINK-20778] the comment for the type of kafka consumer is wrong at KafkaPartitionSplit URL: https://github.com/apache/flink/pull/14501 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Commented] (FLINK-31846) Support cancel final checkpoint when all tasks are finished

2023-04-19 Thread Fan Hong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714369#comment-17714369 ] Fan Hong commented on FLINK-31846: -- In essence, I am using Flink for processing bounded data streams.

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #567: [FLINK-31815] Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency

2023-04-19 Thread via GitHub
yangjf2019 commented on PR #567: URL: https://github.com/apache/flink-kubernetes-operator/pull/567#issuecomment-1515584808 Well ,thank you,maybe i should check the unit tests.But when I run the mvn command locally, I can compile the project normally.

[jira] [Created] (FLINK-31860) FlinkDeployments never finalize when namespace is deleted

2023-04-19 Thread Jayme Howard (Jira)
Jayme Howard created FLINK-31860: Summary: FlinkDeployments never finalize when namespace is deleted Key: FLINK-31860 URL: https://issues.apache.org/jira/browse/FLINK-31860 Project: Flink

[jira] [Resolved] (FLINK-31859) Update maven cyclonedx plugin to 2.7.7

2023-04-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-31859. - Fix Version/s: 1.18.0 Resolution: Fixed > Update maven cyclonedx plugin to 2.7.7

[jira] [Commented] (FLINK-31859) Update maven cyclonedx plugin to 2.7.7

2023-04-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714286#comment-17714286 ] Sergey Nuyanzin commented on FLINK-31859: - Merged to master at

[jira] [Closed] (FLINK-31859) Update maven cyclonedx plugin to 2.7.7

2023-04-19 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-31859. --- > Update maven cyclonedx plugin to 2.7.7 > -- > >

[GitHub] [flink] snuyanzin merged pull request #22430: [FLINK-31859][build] Update cyclonedx-maven-plugin from 2.7.3 to 2.7.7

2023-04-19 Thread via GitHub
snuyanzin merged PR #22430: URL: https://github.com/apache/flink/pull/22430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] snuyanzin commented on pull request #22430: [FLINK-31859][build] Update cyclonedx-maven-plugin from 2.7.3 to 2.7.7

2023-04-19 Thread via GitHub
snuyanzin commented on PR #22430: URL: https://github.com/apache/flink/pull/22430#issuecomment-1515268772 Thanks for having a look! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-web] MartijnVisser commented on a diff in pull request #640: Add MongoDB v1.0.1 for Flink 1.16.x and Flink 1.17.x

2023-04-19 Thread via GitHub
MartijnVisser commented on code in PR #640: URL: https://github.com/apache/flink-web/pull/640#discussion_r1171728568 ## docs/data/release_archive.yml: ## @@ -428,6 +428,11 @@ release_archive: version: 1.0.0 release_date: 2022-12-21 filename: "opensearch" +

[jira] [Commented] (FLINK-31717) Unit tests running with local kube config

2023-04-19 Thread Mate Czagany (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714250#comment-17714250 ] Mate Czagany commented on FLINK-31717: -- Sorry, I didn't have much time to work on this ticket so

[jira] [Closed] (FLINK-31839) It's not possible to add flink-s3-fs-hadoop and flink-s3-fs-presto plugins at the same time

2023-04-19 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Márton Balassi closed FLINK-31839. -- Resolution: Fixed af4c68a in release-1.17. > It's not possible to add flink-s3-fs-hadoop and

[jira] [Assigned] (FLINK-31832) Add benchmarks for end to end  restarting tasks

2023-04-19 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-31832: -- Assignee: Weihua Hu > Add benchmarks for end to end  restarting tasks >

[GitHub] [flink] mbalassi merged pull request #22428: [BP-1.17][FLINK-31839][filesystems] Fix flink-s3-fs-hadoop and flink-s3-fs-presto plugin collision

2023-04-19 Thread via GitHub
mbalassi merged PR #22428: URL: https://github.com/apache/flink/pull/22428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (FLINK-31842) calculate task executor's utilization only in EvenlySpreadOutLocationPreferenceSlotSelectionStrategy

2023-04-19 Thread Lijie Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lijie Wang reassigned FLINK-31842: -- Assignee: Weihua Hu > calculate task executor's utilization only in >

[GitHub] [flink] flinkbot commented on pull request #22430: [FLINK-31859][build] Update cyclonedx-maven-plugin from 2.7.3 to 2.7.7

2023-04-19 Thread via GitHub
flinkbot commented on PR #22430: URL: https://github.com/apache/flink/pull/22430#issuecomment-1515038543 ## CI report: * ce6918262baebd49ecf5f3ce0a7edaa38470d57b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31859) Update maven cyclonedx plugin to 2.7.7

2023-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31859: --- Labels: pull-request-available (was: ) > Update maven cyclonedx plugin to 2.7.7 >

[GitHub] [flink] snuyanzin opened a new pull request, #22430: [FLINK-31859][build] Update cyclonedx-maven-plugin from 2.7.3 to 2.7.7

2023-04-19 Thread via GitHub
snuyanzin opened a new pull request, #22430: URL: https://github.com/apache/flink/pull/22430 ## What is the purpose of the change The PR updates cyclonedx-maven-plugin there are at least a couple of issues fixing by this update 1. cyclonedx-maven-plugin depends on

[jira] [Created] (FLINK-31859) Update maven cyclonedx plugin to 2.7.7

2023-04-19 Thread Sergey Nuyanzin (Jira)
Sergey Nuyanzin created FLINK-31859: --- Summary: Update maven cyclonedx plugin to 2.7.7 Key: FLINK-31859 URL: https://issues.apache.org/jira/browse/FLINK-31859 Project: Flink Issue Type:

[jira] [Created] (FLINK-31858) Add Autoscaler support for Session Job

2023-04-19 Thread phoebe chen (Jira)
phoebe chen created FLINK-31858: --- Summary: Add Autoscaler support for Session Job Key: FLINK-31858 URL: https://issues.apache.org/jira/browse/FLINK-31858 Project: Flink Issue Type: Improvement

[GitHub] [flink] zoltar9264 commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-04-19 Thread via GitHub
zoltar9264 commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1171517547 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingStateChangeFsUploader.java: ## @@ -51,14 +52,15 @@ * Store the meta of

[jira] [Commented] (FLINK-31857) Support pluginable observers mechanism

2023-04-19 Thread Daren Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714156#comment-17714156 ] Daren Wong commented on FLINK-31857: Pull Request:

[GitHub] [flink] XComp commented on pull request #22422: [FLINK-31838][runtime] Moves thread handling for leader event listener calls from DefaultMultipleComponentLeaderElectionService into DefaultLea

2023-04-19 Thread via GitHub
XComp commented on PR #22422: URL: https://github.com/apache/flink/pull/22422#issuecomment-1514911066 I will reiterate over the `LeaderElectionEventHandler` interface tomorrow and address @reswqa 's comments. No need to review this PR, yet. Sorry for the poor interface design proposal.

[GitHub] [flink] XComp commented on a diff in pull request #22422: [FLINK-31838][runtime] Moves thread handling for leader event listener calls from DefaultMultipleComponentLeaderElectionService into

2023-04-19 Thread via GitHub
XComp commented on code in PR #22422: URL: https://github.com/apache/flink/pull/22422#discussion_r1171487006 ## flink-kubernetes/src/main/java/org/apache/flink/kubernetes/highavailability/KubernetesLeaderElectionDriver.java: ## @@ -195,12 +196,14 @@ private class

[GitHub] [flink] XComp commented on a diff in pull request #22422: [FLINK-31838][runtime] Moves thread handling for leader event listener calls from DefaultMultipleComponentLeaderElectionService into

2023-04-19 Thread via GitHub
XComp commented on code in PR #22422: URL: https://github.com/apache/flink/pull/22422#discussion_r1171485508 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -67,7 +72,20 @@ // this.running=true ensures that

[GitHub] [flink-kubernetes-operator] darenwkt opened a new pull request, #570: Observer plugin

2023-04-19 Thread via GitHub
darenwkt opened a new pull request, #570: URL: https://github.com/apache/flink-kubernetes-operator/pull/570 ## What is the purpose of the change Support pluginable Observer to allow user to load a plugin JAR to run custom observer logic. ## Brief change log

[GitHub] [flink] XComp commented on a diff in pull request #22422: [FLINK-31838][runtime] Moves thread handling for leader event listener calls from DefaultMultipleComponentLeaderElectionService into

2023-04-19 Thread via GitHub
XComp commented on code in PR #22422: URL: https://github.com/apache/flink/pull/22422#discussion_r1171482791 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionService.java: ## @@ -67,7 +72,20 @@ // this.running=true ensures that

[GitHub] [flink] XComp commented on a diff in pull request #22422: [FLINK-31838][runtime] Moves thread handling for leader event listener calls from DefaultMultipleComponentLeaderElectionService into

2023-04-19 Thread via GitHub
XComp commented on code in PR #22422: URL: https://github.com/apache/flink/pull/22422#discussion_r1171481171 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/LeaderElectionEventHandler.java: ## @@ -36,14 +37,44 @@ public interface

[jira] [Created] (FLINK-31857) Support pluginable observers mechanism

2023-04-19 Thread Daren Wong (Jira)
Daren Wong created FLINK-31857: -- Summary: Support pluginable observers mechanism Key: FLINK-31857 URL: https://issues.apache.org/jira/browse/FLINK-31857 Project: Flink Issue Type: Improvement

[jira] [Updated] (FLINK-30920) K8 cluster autoscaler | exclude operator ids from scaler

2023-04-19 Thread Maximilian Michels (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Maximilian Michels updated FLINK-30920: --- Fix Version/s: kubernetes-operator-1.5.0 > K8 cluster autoscaler | exclude operator

[GitHub] [flink-kubernetes-operator] mxm merged pull request #569: [FLINK-30920] Prevent clearing any manually defined vertex exclusions

2023-04-19 Thread via GitHub
mxm merged PR #569: URL: https://github.com/apache/flink-kubernetes-operator/pull/569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] flinkbot commented on pull request #22429: [FLINK-31853][runtime] Remove use of ExecutionAttemptMappingProvider

2023-04-19 Thread via GitHub
flinkbot commented on PR #22429: URL: https://github.com/apache/flink/pull/22429#issuecomment-1514874007 ## CI report: * 66b998403858c913b90bfa2d44ed20113e2629e7 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-31853) Remove use of ExecutionAttemptMappingProvider

2023-04-19 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31853: --- Labels: pull-request-available (was: ) > Remove use of ExecutionAttemptMappingProvider >

[GitHub] [flink] JunRuiLee opened a new pull request, #22429: [FLINK-31853][runtime] Remove use of ExecutionAttemptMappingProvider

2023-04-19 Thread via GitHub
JunRuiLee opened a new pull request, #22429: URL: https://github.com/apache/flink/pull/22429 ## What is the purpose of the change After Flink-17295, we refactored ExecutionAttemptID to consist of executionGraphId, executionVertexId, and attemptNumber. Therefore, the

[GitHub] [flink-web] echauchot commented on a diff in pull request #641: Add blog article: Howto create a batch source with the new Source framework

2023-04-19 Thread via GitHub
echauchot commented on code in PR #641: URL: https://github.com/apache/flink-web/pull/641#discussion_r1171447070 ## docs/content/posts/2023-04-13-howto-create-batch-source.md: ## @@ -0,0 +1,221 @@ +--- +title: "Howto create a batch source with the new Source framework" +date:

[jira] [Commented] (FLINK-31820) Support data source sub-database and sub-table

2023-04-19 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714125#comment-17714125 ] Martijn Visser commented on FLINK-31820: I don't immediately see the use cases that adding this

[GitHub] [flink-web] echauchot commented on a diff in pull request #641: Add blog article: Howto create a batch source with the new Source framework

2023-04-19 Thread via GitHub
echauchot commented on code in PR #641: URL: https://github.com/apache/flink-web/pull/641#discussion_r1171428815 ## docs/content/posts/2023-04-13-howto-create-batch-source.md: ## @@ -0,0 +1,221 @@ +--- +title: "Howto create a batch source with the new Source framework" +date:

[GitHub] [flink-web] echauchot commented on a diff in pull request #641: Add blog article: Howto create a batch source with the new Source framework

2023-04-19 Thread via GitHub
echauchot commented on code in PR #641: URL: https://github.com/apache/flink-web/pull/641#discussion_r1171427168 ## docs/content/posts/2023-04-13-howto-create-batch-source.md: ## @@ -0,0 +1,221 @@ +--- +title: "Howto create a batch source with the new Source framework" +date:

[jira] [Created] (FLINK-31856) Add support for Opensearch Connector REST client customization

2023-04-19 Thread Jira
Michael Hempel-Jørgensen created FLINK-31856: Summary: Add support for Opensearch Connector REST client customization Key: FLINK-31856 URL: https://issues.apache.org/jira/browse/FLINK-31856

[GitHub] [flink-web] echauchot commented on a diff in pull request #641: Add blog article: Howto create a batch source with the new Source framework

2023-04-19 Thread via GitHub
echauchot commented on code in PR #641: URL: https://github.com/apache/flink-web/pull/641#discussion_r1171417949 ## docs/content/posts/2023-04-13-howto-create-batch-source.md: ## @@ -0,0 +1,221 @@ +--- +title: "Howto create a batch source with the new Source framework" +date:

[GitHub] [flink-web] echauchot commented on a diff in pull request #641: Add blog article: Howto create a batch source with the new Source framework

2023-04-19 Thread via GitHub
echauchot commented on code in PR #641: URL: https://github.com/apache/flink-web/pull/641#discussion_r1171412720 ## docs/content/posts/2023-04-13-howto-create-batch-source.md: ## @@ -0,0 +1,221 @@ +--- +title: "Howto create a batch source with the new Source framework" +date:

[jira] [Commented] (FLINK-31855) Canceling a job through the UI isn't possible in standalone

2023-04-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714118#comment-17714118 ] Gyula Fora commented on FLINK-31855: The cancel button should never exist. > Canceling a job

[jira] [Created] (FLINK-31855) Canceling a job through the UI isn't possible in standalone

2023-04-19 Thread Gil Shmaya (Jira)
Gil Shmaya created FLINK-31855: -- Summary: Canceling a job through the UI isn't possible in standalone Key: FLINK-31855 URL: https://issues.apache.org/jira/browse/FLINK-31855 Project: Flink

[GitHub] [flink] reswqa merged pull request #22425: [BP-1.17][hotfix] Fix some broken links in docs

2023-04-19 Thread via GitHub
reswqa merged PR #22425: URL: https://github.com/apache/flink/pull/22425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] reswqa commented on a diff in pull request #22422: [FLINK-31838][runtime] Moves thread handling for leader event listener calls from DefaultMultipleComponentLeaderElectionService into

2023-04-19 Thread via GitHub
reswqa commented on code in PR #22422: URL: https://github.com/apache/flink/pull/22422#discussion_r1171387869 ## flink-runtime/src/test/java/org/apache/flink/runtime/leaderelection/DefaultLeaderElectionServiceTest.java: ## @@ -301,35 +383,119 @@ void

[GitHub] [flink] reswqa commented on a diff in pull request #22422: [FLINK-31838][runtime] Moves thread handling for leader event listener calls from DefaultMultipleComponentLeaderElectionService into

2023-04-19 Thread via GitHub
reswqa commented on code in PR #22422: URL: https://github.com/apache/flink/pull/22422#discussion_r1171309501 ## flink-runtime/src/main/java/org/apache/flink/runtime/leaderelection/LeaderElectionEventHandler.java: ## @@ -36,14 +37,44 @@ public interface

[GitHub] [flink-connector-cassandra] echauchot commented on a diff in pull request #12: [FLINK-31807] Include all test code in architecture tests

2023-04-19 Thread via GitHub
echauchot commented on code in PR #12: URL: https://github.com/apache/flink-connector-cassandra/pull/12#discussion_r1171293507 ## flink-connector-cassandra/archunit-violations/dc1ba6f4-3d84-498c-a085-e02ba5936201: ## @@ -1,6 +1,12 @@

[GitHub] [flink-kubernetes-operator] mxm opened a new pull request, #569: [FLINK-30920] Prevent overrding any manually defined vertex exclusions

2023-04-19 Thread via GitHub
mxm opened a new pull request, #569: URL: https://github.com/apache/flink-kubernetes-operator/pull/569 This fixes an unreleased bug which would clear user-set vertex exclusions from the config for non-legacy sources. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink] echauchot commented on pull request #22399: [FLINK-31804] Allow MiniClusterTestEnvironment

2023-04-19 Thread via GitHub
echauchot commented on PR #22399: URL: https://github.com/apache/flink/pull/22399#issuecomment-1514715881 > Updated, correctness is shown by the removed violation for `AvroBulkFormatITCase`. > yes I see that. AvroBulkFormatITCase belongs to one of the connectors that are using

[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #567: [FLINK-31815] Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency

2023-04-19 Thread via GitHub
mbalassi commented on PR #567: URL: https://github.com/apache/flink-kubernetes-operator/pull/567#issuecomment-1514696875 Hi @yangjf2019! Running the e2es for hours is certainly unintended, we might be running out of CI instance quota on the Apache github account.  However in your

[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #567: [FLINK-31815] Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency

2023-04-19 Thread via GitHub
yangjf2019 commented on PR #567: URL: https://github.com/apache/flink-kubernetes-operator/pull/567#issuecomment-1514677539 Hello @mbalassi , may I ask why flink e2e tests will run for more than 5 hours? And I can't see the run log.

[jira] [Commented] (FLINK-31794) Ignore unknown CRD fields

2023-04-19 Thread Daren Wong (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714086#comment-17714086 ] Daren Wong commented on FLINK-31794: Hi Gyula, as discussed on Slack and reposting here for clarity,

[GitHub] [flink] gaborgsomogyi commented on pull request #22428: [FLINK-31839][filesystems] Fix flink-s3-fs-hadoop and flink-s3-fs-presto plugin collision

2023-04-19 Thread via GitHub
gaborgsomogyi commented on PR #22428: URL: https://github.com/apache/flink/pull/22428#issuecomment-1514661633 cc @mbalassi -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] gaborgsomogyi commented on pull request #22428: [FLINK-31839][filesystems] Fix flink-s3-fs-hadoop and flink-s3-fs-presto plugin collision

2023-04-19 Thread via GitHub
gaborgsomogyi commented on PR #22428: URL: https://github.com/apache/flink/pull/22428#issuecomment-1514661403 This is backport of https://github.com/apache/flink/pull/22420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] flinkbot commented on pull request #22428: [FLINK-31839][filesystems] Fix flink-s3-fs-hadoop and flink-s3-fs-presto plugin collision

2023-04-19 Thread via GitHub
flinkbot commented on PR #22428: URL: https://github.com/apache/flink/pull/22428#issuecomment-1514660279 ## CI report: * a755be199de6ba8cdce5f103ca648dfab6815d1d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] gaborgsomogyi opened a new pull request, #22428: [FLINK-31839][filesystems] Fix flink-s3-fs-hadoop and flink-s3-fs-presto plugin collision

2023-04-19 Thread via GitHub
gaborgsomogyi opened a new pull request, #22428: URL: https://github.com/apache/flink/pull/22428 ## What is the purpose of the change At the moment it's not possible to add `flink-s3-fs-hadoop` and `flink-s3-fs-presto` plugins at the same time. ## Brief change log * Now

[GitHub] [flink] zoltar9264 commented on a diff in pull request #21822: [FLINK-30863][state] Register local recovery files of changelog before notifyCheckpointComplete()

2023-04-19 Thread via GitHub
zoltar9264 commented on code in PR #21822: URL: https://github.com/apache/flink/pull/21822#discussion_r1171258522 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/DuplicatingStateChangeFsUploader.java: ## @@ -51,14 +52,15 @@ * Store the meta of

[jira] [Commented] (FLINK-31839) It's not possible to add flink-s3-fs-hadoop and flink-s3-fs-presto plugins at the same time

2023-04-19 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714075#comment-17714075 ] Márton Balassi commented on FLINK-31839: 839b3b9 in master > It's not possible to add

[GitHub] [flink] zentol commented on pull request #22399: [FLINK-31804] Allow MiniClusterTestEnvironment

2023-04-19 Thread via GitHub
zentol commented on PR #22399: URL: https://github.com/apache/flink/pull/22399#issuecomment-1514629936 Updated, correctness is shown by the removed violation for `AvroBulkFormatITCase`. Other violations in the kafka IT cases are not addressed because the MiniClusterEnvironment is

[GitHub] [flink] mbalassi merged pull request #22420: [FLINK-31839][filesystems] Fix flink-s3-fs-hadoop and flink-s3-fs-presto plugin collision

2023-04-19 Thread via GitHub
mbalassi merged PR #22420: URL: https://github.com/apache/flink/pull/22420 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (FLINK-31848) And Operator has side effect when operands have udf

2023-04-19 Thread zju_zsx (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714067#comment-17714067 ] zju_zsx commented on FLINK-31848: - [~csq] null check is checked in left.code,  left.resultTerm also set

[jira] [Created] (FLINK-31854) Flink connector redshift

2023-04-19 Thread Samrat Deb (Jira)
Samrat Deb created FLINK-31854: -- Summary: Flink connector redshift Key: FLINK-31854 URL: https://issues.apache.org/jira/browse/FLINK-31854 Project: Flink Issue Type: New Feature

[GitHub] [flink] zentol commented on pull request #22399: [FLINK-31804] Allow MiniClusterTestEnvironment

2023-04-19 Thread via GitHub
zentol commented on PR #22399: URL: https://github.com/apache/flink/pull/22399#issuecomment-1514604512 Working on a v2; the rule wasn't adjusted correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (FLINK-31852) NumRecordsOut metrics broken for multiple outout chains

2023-04-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-31852: --- Summary: NumRecordsOut metrics broken for multiple outout chains (was: NumRecordsOut metrics

[jira] [Updated] (FLINK-31852) NumRecordsOut metrics broken

2023-04-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-31852: --- Description: The numRecordsOut task metrics seem to be incorrect when there are multiple outputs

[jira] [Commented] (FLINK-31852) NumRecordsOut metrics broken

2023-04-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714060#comment-17714060 ] Gyula Fora commented on FLINK-31852: I will modify the ticket for that   > NumRecordsOut metrics

[jira] [Commented] (FLINK-31852) NumRecordsOut metrics broken

2023-04-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714059#comment-17714059 ] Gyula Fora commented on FLINK-31852: Part of it, but the part related to the chained output is a

[GitHub] [flink-web] zentol commented on a diff in pull request #631: Add blog article: Howto migrate a real-life batch pipeline from the DataSet API to the DataStream API

2023-04-19 Thread via GitHub
zentol commented on code in PR #631: URL: https://github.com/apache/flink-web/pull/631#discussion_r1171189504 ## docs/content/posts/2023-04-12-howto-migrate-to-datastream.md: ## @@ -0,0 +1,190 @@ +--- +title: "Howto migrate a real-life batch pipeline from the DataSet API to

[GitHub] [flink-web] zentol commented on a diff in pull request #631: Add blog article: Howto migrate a real-life batch pipeline from the DataSet API to the DataStream API

2023-04-19 Thread via GitHub
zentol commented on code in PR #631: URL: https://github.com/apache/flink-web/pull/631#discussion_r1171187297 ## docs/content/posts/2023-04-12-howto-migrate-to-datastream.md: ## @@ -0,0 +1,190 @@ +--- +title: "Howto migrate a real-life batch pipeline from the DataSet API to

[jira] [Commented] (FLINK-31852) NumRecordsOut metrics broken

2023-04-19 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714055#comment-17714055 ] Weihua Hu commented on FLINK-31852: --- I think it's same with 

[GitHub] [flink-web] zentol commented on a diff in pull request #631: Add blog article: Howto migrate a real-life batch pipeline from the DataSet API to the DataStream API

2023-04-19 Thread via GitHub
zentol commented on code in PR #631: URL: https://github.com/apache/flink-web/pull/631#discussion_r1171187297 ## docs/content/posts/2023-04-12-howto-migrate-to-datastream.md: ## @@ -0,0 +1,190 @@ +--- +title: "Howto migrate a real-life batch pipeline from the DataSet API to

[jira] [Assigned] (FLINK-31853) Remove use of ExecutionAttemptMappingProvider

2023-04-19 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu reassigned FLINK-31853: --- Assignee: Junrui Li > Remove use of ExecutionAttemptMappingProvider >

[jira] [Created] (FLINK-31853) Remove use of ExecutionAttemptMappingProvider

2023-04-19 Thread Junrui Li (Jira)
Junrui Li created FLINK-31853: - Summary: Remove use of ExecutionAttemptMappingProvider Key: FLINK-31853 URL: https://issues.apache.org/jira/browse/FLINK-31853 Project: Flink Issue Type:

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #12: [FLINK-31807] Include all test code in architecture tests

2023-04-19 Thread via GitHub
echauchot commented on PR #12: URL: https://github.com/apache/flink-connector-cassandra/pull/12#issuecomment-1514523727 @zentol taking a look after lunch break -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] TanYuxin-tyx commented on pull request #22330: [FLINK-31635][network] Support writing records to the new tiered store architecture

2023-04-19 Thread via GitHub
TanYuxin-tyx commented on PR #22330: URL: https://github.com/apache/flink/pull/22330#issuecomment-1514523678 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-web] echauchot commented on pull request #631: Add blog article: Howto migrate a real-life batch pipeline from the DataSet API to the DataStream API

2023-04-19 Thread via GitHub
echauchot commented on PR #631: URL: https://github.com/apache/flink-web/pull/631#issuecomment-1514520348 @zentol I have fixed a bug I mentioned earlier : missing windowing (it was not obvious to me that DataStream API in batch mode required windowing even if there is no event timestamps

[GitHub] [flink] fredia commented on pull request #21858: [FLINK-30729][state/changelog] Refactor checkState() to WARN of StateChangelogWriter to avoid confusing IllegalException

2023-04-19 Thread via GitHub
fredia commented on PR #21858: URL: https://github.com/apache/flink/pull/21858#issuecomment-1514504005 @masteryhx Thanks for the review, also refactor the `checkState()` in method `append()`, please take a look again. -- This is an automated message from the Apache Git Service. To

[GitHub] [flink] masteryhx commented on a diff in pull request #21858: [FLINK-30729][state/changelog] Refactor checkState() to WARN of StateChangelogWriter to avoid confusing IllegalException

2023-04-19 Thread via GitHub
masteryhx commented on code in PR #21858: URL: https://github.com/apache/flink/pull/21858#discussion_r1171137916 ## flink-dstl/flink-dstl-dfs/src/main/java/org/apache/flink/changelog/fs/FsStateChangelogWriter.java: ## @@ -169,8 +169,11 @@ class FsStateChangelogWriter implements

[jira] [Updated] (FLINK-31852) NumRecordsOut metrics broken

2023-04-19 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora updated FLINK-31852: --- Issue Type: Bug (was: New Feature) > NumRecordsOut metrics broken > >

[jira] [Created] (FLINK-31852) NumRecordsOut metrics broken

2023-04-19 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31852: -- Summary: NumRecordsOut metrics broken Key: FLINK-31852 URL: https://issues.apache.org/jira/browse/FLINK-31852 Project: Flink Issue Type: New Feature

  1   2   >