[GitHub] [flink] WencongLiu commented on a diff in pull request #22316: [FLINK-31638][network] Downstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22316: URL: https://github.com/apache/flink/pull/22316#discussion_r1184919001 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageConsumerClient.java: ## @@ -32,6 +34,8 @@ public

[GitHub] [flink] WencongLiu commented on a diff in pull request #22316: [FLINK-31638][network] Downstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22316: URL: https://github.com/apache/flink/pull/22316#discussion_r1184917806 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStoreSubpartitionConsumerClient.java: ## @@ -0,0 +1,77 @@

[GitHub] [flink] WencongLiu commented on a diff in pull request #22316: [FLINK-31638][network] Downstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22316: URL: https://github.com/apache/flink/pull/22316#discussion_r1184915835 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java: ## @@ -895,6 +898,52 @@ public String toString() { } } +

[GitHub] [flink] WencongLiu commented on a diff in pull request #22316: [FLINK-31638][network] Downstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22316: URL: https://github.com/apache/flink/pull/22316#discussion_r1184915359 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/EndOfSegmentEvent.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] WencongLiu commented on a diff in pull request #22316: [FLINK-31638][network] Downstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22316: URL: https://github.com/apache/flink/pull/22316#discussion_r1184915359 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/EndOfSegmentEvent.java: ## @@ -0,0 +1,62 @@ +/* + * Licensed to the Apache Software

[GitHub] [flink] WencongLiu commented on a diff in pull request #22316: [FLINK-31638][network] Downstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22316: URL: https://github.com/apache/flink/pull/22316#discussion_r1184914268 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java: ## @@ -289,7 +289,10 @@ enum DataType { * Indicates that this

[GitHub] [flink] WencongLiu commented on a diff in pull request #22316: [FLINK-31638][network] Downstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22316: URL: https://github.com/apache/flink/pull/22316#discussion_r1184914268 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/Buffer.java: ## @@ -289,7 +289,10 @@ enum DataType { * Indicates that this

[GitHub] [flink] WencongLiu commented on a diff in pull request #22316: [FLINK-31638][network] Downstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22316: URL: https://github.com/apache/flink/pull/22316#discussion_r1184913898 ## flink-architecture-tests/flink-architecture-tests-production/archunit-violations/7602816f-5c01-4b7a-9e3e-235dfedec245: ## @@ -173,6 +173,7 @@

[jira] [Updated] (FLINK-31996) Chaining operators with different max parallelism prevents rescaling

2023-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31996: --- Labels: pull-request-available (was: ) > Chaining operators with different max parallelism

[GitHub] [flink] dmvk opened a new pull request, #22520: [FLINK-31996] Chaining operators with different max parallelism prevents rescaling

2023-05-04 Thread via GitHub
dmvk opened a new pull request, #22520: URL: https://github.com/apache/flink/pull/22520 https://issues.apache.org/jira/browse/FLINK-31996 Introduce a new opt-in flag that can disable the chaining of operators with different max parallelism, which prevents rescaling in some cases when

[jira] [Comment Edited] (FLINK-31984) Savepoint on S3 should be relocatable if entropy injection is not effective

2023-05-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719276#comment-17719276 ] Matthias Pohl edited comment on FLINK-31984 at 5/4/23 11:54 AM: I'm

[GitHub] [flink] WencongLiu commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1184909916 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/BufferContext.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the

[GitHub] [flink] WencongLiu commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1184909667 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/BufferContext.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the

[GitHub] [flink] WencongLiu commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1184909295 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/BufferContext.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the

[GitHub] [flink] WencongLiu commented on a diff in pull request #22342: [FLINK-31636][network] Upstream supports reading buffers from tiered store

2023-05-04 Thread via GitHub
WencongLiu commented on code in PR #22342: URL: https://github.com/apache/flink/pull/22342#discussion_r1184908682 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/BufferContext.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the

[GitHub] [flink] XComp commented on pull request #22422: [FLINK-31838][runtime] Moves thread handling for leader event listener calls from DefaultMultipleComponentLeaderElectionService into DefaultLea

2023-05-04 Thread via GitHub
XComp commented on PR #22422: URL: https://github.com/apache/flink/pull/22422#issuecomment-1534632811 Squashed the commits together again to prepare the PR for the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [flink] XComp commented on pull request #22422: [FLINK-31838][runtime] Moves thread handling for leader event listener calls from DefaultMultipleComponentLeaderElectionService into DefaultLea

2023-05-04 Thread via GitHub
XComp commented on PR #22422: URL: https://github.com/apache/flink/pull/22422#issuecomment-1534630265 I had to rebase because of FLINK-31962. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-31999) CI fails in preparing the e2e test runs due openssl unavailable

2023-05-04 Thread Robert Metzger (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719282#comment-17719282 ] Robert Metzger commented on FLINK-31999: I think some e2e test was failing with the ubuntu

[jira] [Closed] (FLINK-31999) CI fails in preparing the e2e test runs due openssl unavailable

2023-05-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl closed FLINK-31999. - Resolution: Duplicate > CI fails in preparing the e2e test runs due openssl unavailable >

[jira] [Commented] (FLINK-31999) CI fails in preparing the e2e test runs due openssl unavailable

2023-05-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719279#comment-17719279 ] Matthias Pohl commented on FLINK-31999: --- [~rmetzger] what was the reason for us to rely on

[jira] [Updated] (FLINK-31999) CI fails in preparing the e2e test runs due openssl unavailable

2023-05-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31999: -- Priority: Critical (was: Major) > CI fails in preparing the e2e test runs due openssl

[jira] [Assigned] (FLINK-31999) CI fails in preparing the e2e test runs due openssl unavailable

2023-05-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reassigned FLINK-31999: - Assignee: Matthias Pohl > CI fails in preparing the e2e test runs due openssl

[jira] [Updated] (FLINK-31999) CI fails in preparing the e2e test runs due openssl unavailable

2023-05-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-31999: -- Description: We experience build failures due to the openssl download URL causing a 404:

[jira] [Created] (FLINK-31999) CI fails in preparing the e2e test runs due openssl unavailable

2023-05-04 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-31999: - Summary: CI fails in preparing the e2e test runs due openssl unavailable Key: FLINK-31999 URL: https://issues.apache.org/jira/browse/FLINK-31999 Project: Flink

[jira] [Updated] (FLINK-31953) FLIP-288: Enable Dynamic Partition Discovery by Default in Kafka Source

2023-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31953: --- Labels: Connector kafka-source pull-request-available (was: Connector kafka-source) >

[GitHub] [flink-connector-kafka] loserwang1024 opened a new pull request, #27: [FLINK-31953][Connector/Kafka] EARLIEST offset strategy for partitions discoveried later based on FLIP-288

2023-05-04 Thread via GitHub
loserwang1024 opened a new pull request, #27: URL: https://github.com/apache/flink-connector-kafka/pull/27 # EARLIEST offset strategy for partitions discoveried later based on FLIP-288 ### What is the purpose of the change As described in

[jira] [Comment Edited] (FLINK-31984) Savepoint on S3 should be relocatable if entropy injection is not effective

2023-05-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719276#comment-17719276 ] Matthias Pohl edited comment on FLINK-31984 at 5/4/23 11:23 AM: I'm

[GitHub] [flink] XComp commented on pull request #22519: [BP-1.16][FLINK-31984] Revert "[FLINK-31984][fs][checkpoint] Savepoint should be relocatable if entropy injection is not effective"

2023-05-04 Thread via GitHub
XComp commented on PR #22519: URL: https://github.com/apache/flink/pull/22519#issuecomment-1534595312 I merged without review to fix the branches immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] XComp commented on pull request #22518: [BP-1.17][FLINK-31984] Revert "[FLINK-31984][fs][checkpoint] Savepoint should be relocatable if entropy injection is not effective"

2023-05-04 Thread via GitHub
XComp commented on PR #22518: URL: https://github.com/apache/flink/pull/22518#issuecomment-1534595164 I merged without review to fix the branches immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] XComp merged pull request #22519: [BP-1.16][FLINK-31984] Revert "[FLINK-31984][fs][checkpoint] Savepoint should be relocatable if entropy injection is not effective"

2023-05-04 Thread via GitHub
XComp merged PR #22519: URL: https://github.com/apache/flink/pull/22519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] XComp merged pull request #22518: [BP-1.17][FLINK-31984] Revert "[FLINK-31984][fs][checkpoint] Savepoint should be relocatable if entropy injection is not effective"

2023-05-04 Thread via GitHub
XComp merged PR #22518: URL: https://github.com/apache/flink/pull/22518 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Reopened] (FLINK-31984) Savepoint on S3 should be relocatable if entropy injection is not effective

2023-05-04 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl reopened FLINK-31984: --- I'm reopening the issue because it seems that the backports are breaking API constraints. >

[GitHub] [flink] XComp commented on pull request #22518: [BP-1.17][FLINK-31984] Revert "[FLINK-31984][fs][checkpoint] Savepoint should be relocatable if entropy injection is not effective"

2023-05-04 Thread via GitHub
XComp commented on PR #22518: URL: https://github.com/apache/flink/pull/22518#issuecomment-1534591731 Yes, there's the revert for 1.16 as well in https://github.com/apache/flink/pull/22519 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [flink] XComp opened a new pull request, #22519: [FLINK-31984] Revert "[FLINK-31984][fs][checkpoint] Savepoint should be relocatable if entropy injection is not effective"

2023-05-04 Thread via GitHub
XComp opened a new pull request, #22519: URL: https://github.com/apache/flink/pull/22519 This reverts commit cccef2da73e0a12e7e19bac182497919c72e46f0. API change causes build failures. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] snuyanzin commented on pull request #22518: Revert "[FLINK-31984][fs][checkpoint] Savepoint should be relocatable if entropy injection is not effective"

2023-05-04 Thread via GitHub
snuyanzin commented on PR #22518: URL: https://github.com/apache/flink/pull/22518#issuecomment-1534589612 +1 also seems same is for 1.16 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-04 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719275#comment-17719275 ] Márton Balassi commented on FLINK-31974: In the specific case I much prefer the behaviour

[GitHub] [flink] XComp opened a new pull request, #22518: Revert "[FLINK-31984][fs][checkpoint] Savepoint should be relocatable if entropy injection is not effective"

2023-05-04 Thread via GitHub
XComp opened a new pull request, #22518: URL: https://github.com/apache/flink/pull/22518 This reverts commit 5c0a53534edb344bbff09fc5ea4dcc5983c8. API change causes build failures. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Assigned] (FLINK-31996) Chaining operators with different max parallelism prevents rescaling

2023-05-04 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek reassigned FLINK-31996: - Assignee: David Morávek > Chaining operators with different max parallelism prevents

[GitHub] [flink-kubernetes-operator] X-czh commented on a diff in pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-04 Thread via GitHub
X-czh commented on code in PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#discussion_r1184861589 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -98,6 +98,13

[GitHub] [flink-kubernetes-operator] X-czh commented on a diff in pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-04 Thread via GitHub
X-czh commented on code in PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#discussion_r1184861589 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -98,6 +98,13

[jira] [Assigned] (FLINK-31997) Update to Fabric8 6.5.1+ in flink-kubernetes

2023-05-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora reassigned FLINK-31997: -- Assignee: Gyula Fora > Update to Fabric8 6.5.1+ in flink-kubernetes >

[GitHub] [flink] akalash commented on a diff in pull request #22447: [FLINK-31764][runtime] Get rid of numberOfRequestedOverdraftMemorySegments in LocalBufferPool

2023-05-04 Thread via GitHub
akalash commented on code in PR #22447: URL: https://github.com/apache/flink/pull/22447#discussion_r1184841754 ## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/buffer/LocalBufferPool.java: ## @@ -470,7 +467,7 @@ private MemorySegment

[GitHub] [flink-kubernetes-operator] X-czh commented on a diff in pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-04 Thread via GitHub
X-czh commented on code in PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#discussion_r1184844425 ## flink-kubernetes-operator-autoscaler/src/test/java/org/apache/flink/kubernetes/operator/autoscaler/BacklogBasedScalingTest.java: ## @@ -100,6 +100,7

[jira] [Updated] (FLINK-31998) Flink Operator Deadlock on run job Failure

2023-05-04 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ahmed Hamdy updated FLINK-31998: Description: h2. Description FlinkOperator Reconciler goes into deadlock situation where it

[jira] [Commented] (FLINK-31998) Flink Operator Deadlock on run job Failure

2023-05-04 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719258#comment-17719258 ] Ahmed Hamdy commented on FLINK-31998: - CC [~gyfora] > Flink Operator Deadlock on run job Failure >

[GitHub] [flink-kubernetes-operator] X-czh commented on a diff in pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-04 Thread via GitHub
X-czh commented on code in PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#discussion_r1184838281 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -98,6 +98,13

[GitHub] [flink-kubernetes-operator] X-czh commented on a diff in pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-04 Thread via GitHub
X-czh commented on code in PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#discussion_r1184838281 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -98,6 +98,13

[jira] [Created] (FLINK-31998) Flink Operator Deadlock on run job Failure

2023-05-04 Thread Ahmed Hamdy (Jira)
Ahmed Hamdy created FLINK-31998: --- Summary: Flink Operator Deadlock on run job Failure Key: FLINK-31998 URL: https://issues.apache.org/jira/browse/FLINK-31998 Project: Flink Issue Type: Bug

[GitHub] [flink-connector-aws] z3d1k commented on a diff in pull request #49: [FLINK-24438] Add Kinesis connector using FLIP-27

2023-05-04 Thread via GitHub
z3d1k commented on code in PR #49: URL: https://github.com/apache/flink-connector-aws/pull/49#discussion_r1183487489 ## flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/KinesisStreamsSource.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed

[GitHub] [flink-kubernetes-operator] X-czh commented on a diff in pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-04 Thread via GitHub
X-czh commented on code in PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#discussion_r1184836070 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -98,6 +98,13

[GitHub] [flink] cy2008 commented on pull request #22499: [FLINK-31928][build] Upgrade okhttp3 to 4.11.0

2023-05-04 Thread via GitHub
cy2008 commented on PR #22499: URL: https://github.com/apache/flink/pull/22499#issuecomment-1534493340 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] cy2008 commented on pull request #22500: [FLINK-31928][build] Upgrade okhttp3 to 4.11.0

2023-05-04 Thread via GitHub
cy2008 commented on PR #22500: URL: https://github.com/apache/flink/pull/22500#issuecomment-1534492372 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719249#comment-17719249 ] Gyula Fora commented on FLINK-31974: cc [~mbalassi] [~mxm] [~thw]  > JobManager crashes after

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719247#comment-17719247 ] Gyula Fora commented on FLINK-31974: Flink treats only very few errors fatal. IO errors, connector

[jira] [Commented] (FLINK-20794) Support to select distinct columns in the Table API

2023-05-04 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719245#comment-17719245 ] Dian Fu commented on FLINK-20794: - [~supercmmetry] Thanks for taking this ticket. Have assigned it to

[jira] [Assigned] (FLINK-20794) Support to select distinct columns in the Table API

2023-05-04 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-20794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-20794: --- Assignee: Vishaal Selvaraj > Support to select distinct columns in the Table API >

[GitHub] [flink] cy2008 commented on pull request #22498: [FLINK-31928][build] Upgrade okhttp3 to 4.11.0

2023-05-04 Thread via GitHub
cy2008 commented on PR #22498: URL: https://github.com/apache/flink/pull/22498#issuecomment-1534452732 > * @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-04 Thread via GitHub
mxm commented on code in PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#discussion_r1184795632 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -98,6 +98,13 @@

[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #581: [FLINK-31936] Support setting scale up max factor

2023-05-04 Thread via GitHub
mxm commented on code in PR #581: URL: https://github.com/apache/flink-kubernetes-operator/pull/581#discussion_r1184795632 ## flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java: ## @@ -98,6 +98,13 @@

[jira] [Resolved] (FLINK-31928) flink-kubernetes works not properly in k8s with IPv6 stack

2023-05-04 Thread Yi Cai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yi Cai resolved FLINK-31928. Resolution: Fixed > flink-kubernetes works not properly in k8s with IPv6 stack >

[jira] [Commented] (FLINK-31908) cast expr to type with not null should not change nullable of expr

2023-05-04 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719236#comment-17719236 ] jackylau commented on FLINK-31908: -- why i found this is here i supports the flink builtin functions

[jira] [Comment Edited] (FLINK-31908) cast expr to type with not null should not change nullable of expr

2023-05-04 Thread jackylau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719236#comment-17719236 ] jackylau edited comment on FLINK-31908 at 5/4/23 9:40 AM: -- [~jark]  why i

[GitHub] [flink-connector-kafka] boring-cyborg[bot] commented on pull request #26: [FLINK-31208][Connectors/Kafka] KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits)

2023-05-04 Thread via GitHub
boring-cyborg[bot] commented on PR #26: URL: https://github.com/apache/flink-connector-kafka/pull/26#issuecomment-1534403431 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[GitHub] [flink-connector-kafka] loserwang1024 opened a new pull request, #26: [FLINK-31208][Connectors/Kafka] KafkaSourceReader overrides meaninglessly a method(pauseOrResumeSplits)

2023-05-04 Thread via GitHub
loserwang1024 opened a new pull request, #26: URL: https://github.com/apache/flink-connector-kafka/pull/26 ### What is the purpose of the change As described in [FLINK-31208](https://issues.apache.org/jira/browse/FLINK-31208?filter=-2), an override method named pauseOrResumeSplits in

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-04 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719228#comment-17719228 ] Xintong Song commented on FLINK-31974: -- [~gyfora], IMO, errors that Flink cannot recover from by

[GitHub] [flink] XComp commented on pull request #22517: [FLINK-31995][tests] Adds shutdown check to DirectExecutorService

2023-05-04 Thread via GitHub
XComp commented on PR #22517: URL: https://github.com/apache/flink/pull/22517#issuecomment-1534374593 I'm keeping this PR as a draft for now to check whether the change causes test failures which we need to fix before finally reviewing the PR. -- This is an automated message from the

[GitHub] [flink] zhuzhurk commented on a diff in pull request #22506: [FLINK-31890][runtime] Introduce JobMaster per-task failure enrichment/labeling

2023-05-04 Thread via GitHub
zhuzhurk commented on code in PR #22506: URL: https://github.com/apache/flink/pull/22506#discussion_r1184723091 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -473,26 +500,50 @@ public CompletableFuture cancel(Time timeout) {

[jira] [Comment Edited] (FLINK-31977) If scaling.effectiveness.detection.enabled is false, the call to the detectIneffectiveScaleUp() function is unnecessary

2023-05-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719221#comment-17719221 ] Gyula Fora edited comment on FLINK-31977 at 5/4/23 8:55 AM: The problem here

[jira] [Commented] (FLINK-31977) If scaling.effectiveness.detection.enabled is false, the call to the detectIneffectiveScaleUp() function is unnecessary

2023-05-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719221#comment-17719221 ] Gyula Fora commented on FLINK-31977: The problem here is that you need to call the detection logic

[jira] [Closed] (FLINK-31984) Savepoint on S3 should be relocatable if entropy injection is not effective

2023-05-04 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song closed FLINK-31984. Fix Version/s: 1.16.2 1.18.0 1.17.1 Resolution: Done

[jira] [Assigned] (FLINK-31984) Savepoint on S3 should be relocatable if entropy injection is not effective

2023-05-04 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xintong Song reassigned FLINK-31984: Assignee: Mingliang Liu > Savepoint on S3 should be relocatable if entropy injection is

[GitHub] [flink] xintongsong closed pull request #22510: [FLINK-31984][checkpoint] Savepoint should be relocatable if entropy injection is not effective

2023-05-04 Thread via GitHub
xintongsong closed pull request #22510: [FLINK-31984][checkpoint] Savepoint should be relocatable if entropy injection is not effective URL: https://github.com/apache/flink/pull/22510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] xintongsong commented on pull request #22510: [FLINK-31984][checkpoint] Savepoint should be relocatable if entropy injection is not effective

2023-05-04 Thread via GitHub
xintongsong commented on PR #22510: URL: https://github.com/apache/flink/pull/22510#issuecomment-1534332655 7cdbfce8d1b8f222f42229a533282f1e8a0ed95a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (FLINK-31996) Chaining operators with different max parallelism prevents rescaling

2023-05-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719217#comment-17719217 ] Gyula Fora commented on FLINK-31996: Fair point [~chesnay] , I think you are completely right this

[jira] [Comment Edited] (FLINK-31996) Chaining operators with different max parallelism prevents rescaling

2023-05-04 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719216#comment-17719216 ] Chesnay Schepler edited comment on FLINK-31996 at 5/4/23 8:48 AM: -- ??So

[jira] [Commented] (FLINK-31996) Chaining operators with different max parallelism prevents rescaling

2023-05-04 Thread Chesnay Schepler (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719216#comment-17719216 ] Chesnay Schepler commented on FLINK-31996: -- ?? So I would expect this to not be a breaking

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719213#comment-17719213 ] Gyula Fora commented on FLINK-31974: [~xtsong] what errors would you consider actually fatal in

[jira] [Commented] (FLINK-31996) Chaining operators with different max parallelism prevents rescaling

2023-05-04 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-31996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719212#comment-17719212 ] David Morávek commented on FLINK-31996: --- The main question is whether we need an opt-out feature

[GitHub] [flink] zoltar9264 commented on pull request #22458: [FLINK-31743][statebackend/rocksdb] disable rocksdb log relocating wh…

2023-05-04 Thread via GitHub
zoltar9264 commented on PR #22458: URL: https://github.com/apache/flink/pull/22458#issuecomment-1534320074 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (FLINK-31927) Cassandra source raises an exception on Flink 1.16.0 if the user enables the metrics in the cassandra driver

2023-05-04 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Etienne Chauchot resolved FLINK-31927. -- Fix Version/s: cassandra-3.1.0 Resolution: Fixed commits on main:

[jira] [Commented] (FLINK-31974) JobManager crashes after KubernetesClientException exception with FatalExitExceptionHandler

2023-05-04 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719209#comment-17719209 ] Xintong Song commented on FLINK-31974: -- Not sure about never giving fatal exceptions. I personally

[GitHub] [flink-kubernetes-operator] dependabot[bot] commented on pull request #583: Bump snakeyaml from 1.33 to 2.0 in /flink-kubernetes-standalone

2023-05-04 Thread via GitHub
dependabot[bot] commented on PR #583: URL: https://github.com/apache/flink-kubernetes-operator/pull/583#issuecomment-1534298072 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or

[GitHub] [flink-kubernetes-operator] gyfora closed pull request #583: Bump snakeyaml from 1.33 to 2.0 in /flink-kubernetes-standalone

2023-05-04 Thread via GitHub
gyfora closed pull request #583: Bump snakeyaml from 1.33 to 2.0 in /flink-kubernetes-standalone URL: https://github.com/apache/flink-kubernetes-operator/pull/583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #13: [FLINK-31927] Disable cassandra driver metrics as they are not integrated with Flink metrics

2023-05-04 Thread via GitHub
echauchot commented on PR #13: URL: https://github.com/apache/flink-connector-cassandra/pull/13#issuecomment-1534298918 > > yes, as I wrote above, I was too quick in merging this PR. Sorry about that. Thanks for pointing out the wrong ticket number. > > Take it easy, everyone might

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #583: Bump snakeyaml from 1.33 to 2.0 in /flink-kubernetes-standalone

2023-05-04 Thread via GitHub
gyfora commented on PR #583: URL: https://github.com/apache/flink-kubernetes-operator/pull/583#issuecomment-1534297921 Unfortunately this is not that simple. See: https://issues.apache.org/jira/browse/FLINK-31997 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [flink-connector-cassandra] leonardBang commented on pull request #13: [FLINK-31927] Disable cassandra driver metrics as they are not integrated with Flink metrics

2023-05-04 Thread via GitHub
leonardBang commented on PR #13: URL: https://github.com/apache/flink-connector-cassandra/pull/13#issuecomment-1534292383 > yes, as I wrote above, I was too quick in merging this PR. Sorry about that. Thanks for pointing out the wrong ticket number. Take it easy, everyone might miss

[jira] [Commented] (FLINK-31996) Chaining operators with different max parallelism prevents rescaling

2023-05-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719206#comment-17719206 ] Gyula Fora commented on FLINK-31996: In theory user can also break the operator chain by redeploying

[jira] [Closed] (FLINK-31815) Fixing the container vulnerability by upgrade the SnakeYaml Maven dependency

2023-05-04 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31815?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gyula Fora closed FLINK-31815. -- Resolution: Fixed >From the operator side this is now fixed in

[jira] [Created] (FLINK-31997) Update to Fabric8 6.5.1+ in flink-kubernetes

2023-05-04 Thread Gyula Fora (Jira)
Gyula Fora created FLINK-31997: -- Summary: Update to Fabric8 6.5.1+ in flink-kubernetes Key: FLINK-31997 URL: https://issues.apache.org/jira/browse/FLINK-31997 Project: Flink Issue Type:

[jira] [Created] (FLINK-31996) Chaining operators with different max parallelism prevents rescaling

2023-05-04 Thread Jira
David Morávek created FLINK-31996: - Summary: Chaining operators with different max parallelism prevents rescaling Key: FLINK-31996 URL: https://issues.apache.org/jira/browse/FLINK-31996 Project:

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #13: [FLINK-31927] Disable cassandra driver metrics as they are not integrated with Flink metrics

2023-05-04 Thread via GitHub
echauchot commented on PR #13: URL: https://github.com/apache/flink-connector-cassandra/pull/13#issuecomment-1534281270 > > @leonardBang with 3 approvals I'll self merge > > Yeah, you should have the access, but the commit message you forget to update the issue, please keep in mind

[GitHub] [flink-connector-cassandra] leonardBang commented on pull request #13: [FLINK-31927] Disable cassandra driver metrics as they are not integrated with Flink metrics

2023-05-04 Thread via GitHub
leonardBang commented on PR #13: URL: https://github.com/apache/flink-connector-cassandra/pull/13#issuecomment-1534277967 > @leonardBang with 3 approvals I'll self merge Yeah, you should have the access, but the commit message you forget to update the issue, please keep in mind in

[GitHub] [flink-kubernetes-operator] dependabot[bot] opened a new pull request, #583: Bump snakeyaml from 1.33 to 2.0 in /flink-kubernetes-standalone

2023-05-04 Thread via GitHub
dependabot[bot] opened a new pull request, #583: URL: https://github.com/apache/flink-kubernetes-operator/pull/583 Bumps [snakeyaml](https://bitbucket.org/snakeyaml/snakeyaml) from 1.33 to 2.0. Commits

[GitHub] [flink-kubernetes-operator] gyfora merged pull request #580: [FLINK-31815] Bump jackson version to eliminate snakeyaml vulnerability

2023-05-04 Thread via GitHub
gyfora merged PR #580: URL: https://github.com/apache/flink-kubernetes-operator/pull/580 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-31927) Cassandra source raises an exception on Flink 1.16.0 if the user enables the metrics in the cassandra driver

2023-05-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-31927: --- Labels: pull-request-available (was: ) > Cassandra source raises an exception on Flink

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #13: [FLINK-31927] Disable cassandra driver metrics as they are not integrated with Flink metrics

2023-05-04 Thread via GitHub
echauchot commented on PR #13: URL: https://github.com/apache/flink-connector-cassandra/pull/13#issuecomment-1534274611 > LGTM, But please note that The issue should be [FLINK-31927](https://issues.apache.org/jira/browse/FLINK-31927) instead of

[GitHub] [flink-connector-cassandra] echauchot merged pull request #13: [FLINK-31749] Disable cassandra driver metrics as they are not integrated with Flink metrics

2023-05-04 Thread via GitHub
echauchot merged PR #13: URL: https://github.com/apache/flink-connector-cassandra/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Reopened] (FLINK-12869) Add yarn acls capability to flink containers

2023-05-04 Thread Jira
[ https://issues.apache.org/jira/browse/FLINK-12869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Morávek reopened FLINK-12869: --- Assignee: Archit Goyal > Add yarn acls capability to flink containers >

[GitHub] [flink-connector-cassandra] echauchot commented on pull request #13: [FLINK-31749] Disable cassandra driver metrics as they are not integrated with Flink metrics

2023-05-04 Thread via GitHub
echauchot commented on PR #13: URL: https://github.com/apache/flink-connector-cassandra/pull/13#issuecomment-1534267130 @leonardBang with 3 approvals I can definitely self merge no ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [flink] flinkbot commented on pull request #22517: [FLINK-31995][tests] Adds shutdown check to DirectExecutorService

2023-05-04 Thread via GitHub
flinkbot commented on PR #22517: URL: https://github.com/apache/flink/pull/22517#issuecomment-1534261982 ## CI report: * 6ff7e059049d76c8aeec13efd712e1a21172ead9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

<    1   2   3   >