reswqa commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186787331
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
tisonkun commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186784205
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
reswqa commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186784005
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
reswqa commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186783570
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
reswqa commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186783570
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
reswqa opened a new pull request, #61:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/61
…ed in externalized repository
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
reswqa opened a new pull request, #60:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/60
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tisonkun commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186780749
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
reswqa opened a new pull request, #11:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/11
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reswqa opened a new pull request, #10:
URL: https://github.com/apache/flink-connector-rabbitmq/pull/10
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
reswqa opened a new pull request, #47:
URL: https://github.com/apache/flink-connector-pulsar/pull/47
Backport to v3.0 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
reswqa opened a new pull request, #46:
URL: https://github.com/apache/flink-connector-pulsar/pull/46
## Purpose of the change
*As title.*
## Verifying this change
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup
[
https://issues.apache.org/jira/browse/FLINK-31764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo updated FLINK-31764:
---
Fix Version/s: 1.16.2
> Get rid of numberOfRequestedOverdraftMemorySegments in LocalBufferPool
>
[
https://issues.apache.org/jira/browse/FLINK-31764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weijie Guo updated FLINK-31764:
---
Affects Version/s: 1.16.1
(was: 1.18.0)
> Get rid of
[
https://issues.apache.org/jira/browse/FLINK-31764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720065#comment-17720065
]
Weijie Guo edited comment on FLINK-31764 at 5/7/23 3:14 AM:
master(1.18) via
reswqa merged PR #22535:
URL: https://github.com/apache/flink/pull/22535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
reswqa commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186774616
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
reswqa commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186774616
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
reswqa commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186774433
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
tisonkun commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186769978
##
flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581:
##
@@ -10,3 +10,15 @@
tisonkun commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186769897
##
.github/workflows/daily.yml:
##
@@ -21,10 +21,13 @@ on:
schedule:
- cron: "0 0 * * *"
workflow_dispatch:
+ pull_request: ## !!! TODO
venkata91 commented on code in PR #22509:
URL: https://github.com/apache/flink/pull/22509#discussion_r1186738477
##
docs/layouts/shortcodes/generated/yarn_config_configuration.html:
##
@@ -182,5 +182,15 @@
String
Specify YARN node label for the Flink
venkata91 commented on code in PR #22509:
URL: https://github.com/apache/flink/pull/22509#discussion_r1186730308
##
flink-yarn/src/main/java/org/apache/flink/yarn/Utils.java:
##
@@ -620,4 +623,30 @@ public static YarnConfiguration getYarnConfiguration(
return
flinkbot commented on PR #22539:
URL: https://github.com/apache/flink/pull/22539#issuecomment-1537175882
## CI report:
* 7847fbbb95ea29f8c9a13360de49f72953dc5f14 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
xishuaidelin opened a new pull request, #22539:
URL: https://github.com/apache/flink/pull/22539
## What is the purpose of the change
* This pull request Extend the CompiledPlan to read from/write to Flink's
FileSystem which contributes to the FLINK-31791
## Brief
xishuaidelin closed pull request #22538: [FLINK-31956][table] Extend the
CompiledPlan to read from/write to Fl…
URL: https://github.com/apache/flink/pull/22538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nathantalewis closed pull request #328: [statefun-sdk-js] Fix value spec's name
error message
URL: https://github.com/apache/flink-statefun/pull/328
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nathantalewis commented on PR #328:
URL: https://github.com/apache/flink-statefun/pull/328#issuecomment-1537167894
Closing as duplicate of https://github.com/apache/flink-statefun/pull/318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
nathantalewis opened a new pull request, #328:
URL: https://github.com/apache/flink-statefun/pull/328
The error message doesn't match the regex or JSDoc comments. This commit
corrects the error message.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/FLINK-31976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720205#comment-17720205
]
Tan Kim commented on FLINK-31976:
-
I see, so I guess I'll have to test and decide whether or not to turn
zoltar9264 commented on PR #22458:
URL: https://github.com/apache/flink/pull/22458#issuecomment-1537127032
Thanks for meticulous suggestion @Myasuka , I have updated the PR and the CI
passed. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message,
zhuzhurk commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1186678825
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##
@@ -473,26 +500,50 @@ public CompletableFuture cancel(Time
timeout) {
flinkbot commented on PR #22538:
URL: https://github.com/apache/flink/pull/22538#issuecomment-1537107965
## CI report:
* 77364b83b0316a5d3b7b9ced7118039b87df5314 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-31956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-31956:
---
Labels: pull-request-available (was: )
> Extend the CompiledPlan to read from/write to
xishuaidelin opened a new pull request, #22538:
URL: https://github.com/apache/flink/pull/22538
## What is the purpose of the change
* This pull request Extend the CompiledPlan to read from/write to Flink's
FileSystem which contributes to the FLINK-31791
## Brief
xishuaidelin closed pull request #22493: Flink 31952
URL: https://github.com/apache/flink/pull/22493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gyfora commented on code in PR #584:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/584#discussion_r1186672269
##
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java:
##
@@ -52,6 +52,13
[
https://issues.apache.org/jira/browse/FLINK-31976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720186#comment-17720186
]
Gyula Fora commented on FLINK-31976:
What I meant by off is that it may be incorrect and
flinkbot commented on PR #22537:
URL: https://github.com/apache/flink/pull/22537#issuecomment-1537099878
## CI report:
* 202e011d42a54622083c41e489ce6b2fe422c931 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
wForget opened a new pull request, #22537:
URL: https://github.com/apache/flink/pull/22537
## What is the purpose of the change
Replace empty hashset with EMPTY_SET for consistent code style
## Brief change log
Replace `new HashSet<>()` with
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537095518
Pending for merging...
Although, I suggest a release is required to deliver this fix to downstream
users.
cc @MartijnVisser @leonardBang @dannycranmer what do
[
https://issues.apache.org/jira/browse/FLINK-32016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720171#comment-17720171
]
Tan Kim commented on FLINK-32016:
-
When I went to forward the yaml config you requested, I realized that
[
https://issues.apache.org/jira/browse/FLINK-32016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720170#comment-17720170
]
Tan Kim edited comment on FLINK-32016 at 5/6/23 8:40 AM:
-
{code:java}
# yaml
[ https://issues.apache.org/jira/browse/FLINK-32016 ]
Tan Kim deleted comment on FLINK-32016:
-
was (Author: JIRAUSER300108):
{code:java}
# yaml
spec:
flinkConfiguration:
execution.checkpointing.interval: 10s
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537091245
I'm feeling lucky now ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/FLINK-32016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720170#comment-17720170
]
Tan Kim commented on FLINK-32016:
-
{code:java}
# yaml
spec:
flinkConfiguration:
tisonkun commented on code in PR #45:
URL:
https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186664577
##
.github/workflows/daily.yml:
##
@@ -21,10 +21,13 @@ on:
schedule:
- cron: "0 0 * * *"
workflow_dispatch:
+ pull_request: ## !!! TODO
[
https://issues.apache.org/jira/browse/FLINK-32016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720169#comment-17720169
]
Gyula Fora commented on FLINK-32016:
That sounds strange can you share you yaml config?
> Logs are
[
https://issues.apache.org/jira/browse/FLINK-32016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720168#comment-17720168
]
Tan Kim commented on FLINK-32016:
-
The above log is being printed periodically, even though I am not
[
https://issues.apache.org/jira/browse/FLINK-31953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720167#comment-17720167
]
Leonard Xu commented on FLINK-31953:
Assigned to you.
> FLIP-288: Enable Dynamic Partition
[
https://issues.apache.org/jira/browse/FLINK-32020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu reassigned FLINK-32020:
--
Assignee: Hongshun Wang
> Enable Dynamic Partition Discovery by Default in Kafka Source
[
https://issues.apache.org/jira/browse/FLINK-32019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu reassigned FLINK-32019:
--
Assignee: Hongshun Wang
> EARLIEST offset strategy for partitions discoveried later based on
[
https://issues.apache.org/jira/browse/FLINK-32021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Leonard Xu reassigned FLINK-32021:
--
Assignee: Hongshun Wang
> Improvement the Javadoc for SpecifiedOffsetsInitializer and
>
[
https://issues.apache.org/jira/browse/FLINK-31976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720166#comment-17720166
]
Tan Kim commented on FLINK-31976:
-
Turning off inefficient scaling is easy.
What I'm trying to figure
dmvk commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1186661023
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##
@@ -473,26 +500,50 @@ public CompletableFuture cancel(Time
timeout) {
@Override
[
https://issues.apache.org/jira/browse/FLINK-32012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720165#comment-17720165
]
Gyula Fora commented on FLINK-32012:
Hey!
This is an unfortunate limitation of the rollback
reswqa commented on code in PR #22457:
URL: https://github.com/apache/flink/pull/22457#discussion_r1186655970
##
flink-queryable-state/flink-queryable-state-runtime/src/test/java/org/apache/flink/queryablestate/itcases/AbstractQueryableStateTestBase.java:
##
@@ -99,24 +101,23
[
https://issues.apache.org/jira/browse/FLINK-32016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720163#comment-17720163
]
Gyula Fora edited comment on FLINK-32016 at 5/6/23 7:37 AM:
This looks
[
https://issues.apache.org/jira/browse/FLINK-32016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720163#comment-17720163
]
Gyula Fora commented on FLINK-32016:
This looks correct, autoscaler is disabled by session clusters.
[
https://issues.apache.org/jira/browse/FLINK-31976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720162#comment-17720162
]
Gyula Fora commented on FLINK-31976:
Sorry I don’t understand the suggestion. The increased
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537078809
Still a few breaking things.
I'm trying to pick https://github.com/apache/flink/pull/21204.
--
This is an automated message from the Apache Git Service.
To respond
zhuzhurk commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1186656051
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##
@@ -473,26 +500,50 @@ public CompletableFuture cancel(Time
timeout) {
[
https://issues.apache.org/jira/browse/FLINK-32022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gyula Fora closed FLINK-32022.
--
Resolution: Duplicate
> Source level scaling is not applied to operators with chaining applied
>
zhuzhurk commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1186655239
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##
@@ -473,26 +500,50 @@ public CompletableFuture cancel(Time
timeout) {
Liu created FLINK-32023:
---
Summary: execution.buffer-timeout cannot be set to -1 ms
Key: FLINK-32023
URL: https://issues.apache.org/jira/browse/FLINK-32023
Project: Flink
Issue Type: Improvement
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537073378
@reswqa I manually disable skip. But the default config seems:
```
com.diffplug.spotless
reswqa commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537072197
> Werid. I run already mvn spotless:apply and no diff report.
Did you manually execute `mvn spotless: apply`, which successfully fixed the
formatting issue on my mac.
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537071531
Emm...It seems that plugin is default to skip.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537071088
Werid. I run already `mvn spotless:apply` and no diff report.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
reswqa commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537070591
It seems that we have some format violations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dmvk commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1186649483
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##
@@ -473,26 +500,50 @@ public CompletableFuture cancel(Time
timeout) {
@Override
dmvk commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1186649257
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##
@@ -473,26 +500,50 @@ public CompletableFuture cancel(Time
timeout) {
@Override
dmvk commented on code in PR #22506:
URL: https://github.com/apache/flink/pull/22506#discussion_r1186649257
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java:
##
@@ -473,26 +500,50 @@ public CompletableFuture cancel(Time
timeout) {
@Override
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537068806
Change to builder which is a compatible way - test compile from 2.10.1 to
2.10.4.
--
This is an automated message from the Apache Git Service.
To respond to the message,
tisonkun opened a new pull request, #45:
URL: https://github.com/apache/flink-connector-pulsar/pull/45
## Purpose of the change
AS TITLE
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Significant changes
tisonkun commented on PR #44:
URL:
https://github.com/apache/flink-connector-pulsar/pull/44#issuecomment-1537065990
@nlu90 No luck - Pulsar patch release breaks interface:
```
Error: COMPILATION ERROR :
[INFO] -
[
https://issues.apache.org/jira/browse/FLINK-32010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Morávek resolved FLINK-32010.
---
Fix Version/s: 1.16.2
1.18.0
1.17.1
Resolution:
[
https://issues.apache.org/jira/browse/FLINK-32010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17719968#comment-17719968
]
David Morávek edited comment on FLINK-32010 at 5/6/23 6:20 AM:
---
master:
dmvk merged PR #22530:
URL: https://github.com/apache/flink/pull/22530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dmvk merged PR #22529:
URL: https://github.com/apache/flink/pull/22529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/FLINK-32003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17720101#comment-17720101
]
Zili Chen commented on FLINK-32003:
---
Thanks for reporting this issue [~nlu90]! It's reasonable to
[
https://issues.apache.org/jira/browse/FLINK-32003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zili Chen reassigned FLINK-32003:
-
Assignee: Zili Chen
> Release 3.0.0-1.16 and 1.16.1 doesn't work with OAuth2
>
82 matches
Mail list logo
