[GitHub] [flink] huwh commented on pull request #22861: [FLINK-32387][runtime] InputGateDeploymentDescriptor uses cache to avoid deserializing shuffle descriptors multiple times

2023-07-11 Thread via GitHub
huwh commented on PR #22861: URL: https://github.com/apache/flink/pull/22861#issuecomment-1631882530 @wanglijie95, Thanks for the review. I made the changes as you suggested. PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [flink] masteryhx commented on a diff in pull request #22744: [FLINK-29802][state] Changelog supports native savepoint

2023-07-11 Thread via GitHub
masteryhx commented on code in PR #22744: URL: https://github.com/apache/flink/pull/22744#discussion_r1260611912 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java: ## @@ -375,6 +378,49 @@ public

[GitHub] [flink] masteryhx commented on a diff in pull request #22801: [FLINK-23484][benchmark] Supports base benchmark for ChangelogStateBackend

2023-07-11 Thread via GitHub
masteryhx commented on code in PR #22801: URL: https://github.com/apache/flink/pull/22801#discussion_r1260563718 ## flink-test-utils-parent/flink-test-utils/src/test/java/org/apache/flink/state/benchmark/RescalingBenchmark.java: ## @@ -16,7 +16,7 @@ * limitations under the

[GitHub] [flink-benchmarks] masteryhx commented on a diff in pull request #75: [FLINK-23484] Supports to test ChangelogStateBackend

2023-07-11 Thread via GitHub
masteryhx commented on code in PR #75: URL: https://github.com/apache/flink-benchmarks/pull/75#discussion_r1260562329 ## src/main/java/org/apache/flink/state/benchmark/StateBenchmarkBase.java: ## @@ -57,7 +56,7 @@ public class StateBenchmarkBase extends BenchmarkBase {

[GitHub] [flink] FangYongs commented on a diff in pull request #22937: [FLINK-32428][table] Introduce base interfaces for CatalogStore

2023-07-11 Thread via GitHub
FangYongs commented on code in PR #22937: URL: https://github.com/apache/flink/pull/22937#discussion_r1260545206 ## flink-table/flink-table-common/src/main/java/org/apache/flink/table/factories/CatalogStoreFactory.java: ## @@ -0,0 +1,144 @@ +/* + * Licensed to the Apache

[GitHub] [flink] FangYongs commented on a diff in pull request #22937: [FLINK-32428][table] Introduce base interfaces for CatalogStore

2023-07-11 Thread via GitHub
FangYongs commented on code in PR #22937: URL: https://github.com/apache/flink/pull/22937#discussion_r1260543524 ## flink-table/flink-table-common/src/test/java/org/apache/flink/table/factories/CatalogStoreFactoryTest.java: ## @@ -0,0 +1,9 @@ +package

[jira] [Closed] (FLINK-32549) Tiered storage memory manager supports ownership transfer for buffers

2023-07-11 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuxin Tan closed FLINK-32549. - Fix Version/s: 1.18.0 Resolution: Fixed > Tiered storage memory manager supports ownership

[GitHub] [flink] FangYongs commented on a diff in pull request #22937: [FLINK-32428][table] Introduce base interfaces for CatalogStore

2023-07-11 Thread via GitHub
FangYongs commented on code in PR #22937: URL: https://github.com/apache/flink/pull/22937#discussion_r1260537362 ## flink-table/flink-table-api-java/src/test/java/org/apache/flink/table/catalog/GenericInMemoryCatalogStoreTest.java: ## @@ -0,0 +1,45 @@ +/* + * Licensed to the

[GitHub] [flink] wanglijie95 commented on pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on PR #22966: URL: https://github.com/apache/flink/pull/22966#issuecomment-1631802657 Thanks for review @lsyldliu @swuferhong . All comments have been addressed or replied ,PTAL. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260529924 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgram.java: ## @@ -0,0 +1,571 @@ +/* + *

[GitHub] [flink] xuzifu666 commented on a diff in pull request #22980: [FLINK-31035] add warn info to user when NoNodeException happend

2023-07-11 Thread via GitHub
xuzifu666 commented on code in PR #22980: URL: https://github.com/apache/flink/pull/22980#discussion_r1260521926 ## flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java: ## @@ -364,6 +364,7 @@ public Collection getAllHandles() throws

[GitHub] [flink] flinkbot commented on pull request #22982: [FLINK-32576][network] ProducerMergedPartitionFileIndex supports caching regions and spilling regions to file when the cache is too large

2023-07-11 Thread via GitHub
flinkbot commented on PR #22982: URL: https://github.com/apache/flink/pull/22982#issuecomment-1631791507 ## CI report: * 96c12bd159b3cfe3f9785557badba75928e79803 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260518408 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java: ## @@ -165,6 +167,51 @@ public class

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260517558 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgram.java: ## @@ -0,0 +1,571 @@ +/* + *

[jira] [Updated] (FLINK-32576) ProducerMergedPartitionFileIndex supports spilling to file

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32576: --- Labels: pull-request-available (was: ) > ProducerMergedPartitionFileIndex supports

[GitHub] [flink] TanYuxin-tyx opened a new pull request, #22982: [FLINK-32576][network] ProducerMergedPartitionFileIndex supports caching regions and spilling regions to file when the cache is too lar

2023-07-11 Thread via GitHub
TanYuxin-tyx opened a new pull request, #22982: URL: https://github.com/apache/flink/pull/22982 ## What is the purpose of the change *ProducerMergedPartitionFileIndex supports caching regions and spilling regions to file when the cache is too large* ## Brief change

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260516947 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgramTest.java: ## @@ -0,0 +1,271 @@ +/*

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260516252 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgramTest.java: ## @@ -0,0 +1,271 @@ +/*

[jira] [Commented] (FLINK-32549) Tiered storage memory manager supports ownership transfer for buffers

2023-07-11 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742244#comment-17742244 ] Weijie Guo commented on FLINK-32549: master(1.18) via 2dfff436c09821fb658bf8d289206b9ef85bb25b. >

[GitHub] [flink] reswqa merged pull request #22960: [FLINK-32549][network] Tiered storage memory manager supports ownership transfer for buffers

2023-07-11 Thread via GitHub
reswqa merged PR #22960: URL: https://github.com/apache/flink/pull/22960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260510568 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgramTest.java: ## @@ -0,0 +1,271 @@ +/*

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260509411 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgramTest.java: ## @@ -0,0 +1,271 @@ +/*

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260508642 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgramTest.java: ## @@ -0,0 +1,271 @@ +/*

[jira] [Created] (FLINK-32581) Add document for atomic CTAS

2023-07-11 Thread tartarus (Jira)
tartarus created FLINK-32581: Summary: Add document for atomic CTAS Key: FLINK-32581 URL: https://issues.apache.org/jira/browse/FLINK-32581 Project: Flink Issue Type: Sub-task

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260504822 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgramTest.java: ## @@ -0,0 +1,271 @@ +/*

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260503747 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgram.java: ## @@ -0,0 +1,571 @@ +/* + *

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260503527 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/optimize/program/FlinkRuntimeFilterProgram.java: ## @@ -0,0 +1,571 @@ +/* + *

[jira] [Updated] (FLINK-32349) Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-07-11 Thread tartarus (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] tartarus updated FLINK-32349: - Parent: FLINK-32580 Issue Type: Sub-task (was: New Feature) > Support atomic for CREATE TABLE

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260501061 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java: ## @@ -165,6 +167,51 @@ public class

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260500938 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java: ## @@ -165,6 +167,51 @@ public class

[jira] [Created] (FLINK-32580) FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS)

2023-07-11 Thread tartarus (Jira)
tartarus created FLINK-32580: Summary: FLIP-305: Support atomic for CREATE TABLE AS SELECT(CTAS) Key: FLINK-32580 URL: https://issues.apache.org/jira/browse/FLINK-32580 Project: Flink Issue

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260499124 ## flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/OptimizerConfigOptions.java: ## @@ -165,6 +167,51 @@ public class

[jira] [Commented] (FLINK-32157) Replaces LeaderConnectionInfo with LeaderInformation

2023-07-11 Thread Jiadong Lu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742235#comment-17742235 ] Jiadong Lu commented on FLINK-32157: hi [~mapohl] , i would like to address this issue, would you

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260498717 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/batch/runtimefilter/BatchPhysicalGlobalRuntimeFilterBuilder.java:

[GitHub] [flink] Tartarus0zm commented on pull request #22839: [FLINK-32349][table] Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-07-11 Thread via GitHub
Tartarus0zm commented on PR #22839: URL: https://github.com/apache/flink/pull/22839#issuecomment-1631766550 > Please don't forget to create a jira to add a doc for the atomic CTAS statement and put the jira and [FLINK-32349](https://issues.apache.org/jira/browse/FLINK-32349) under a

[GitHub] [flink] wanglijie95 commented on a diff in pull request #22966: [FLINK-32492][table-planner] Introduce FlinkRuntimeFilterProgram to apply the runtime filter optimization.

2023-07-11 Thread via GitHub
wanglijie95 commented on code in PR #22966: URL: https://github.com/apache/flink/pull/22966#discussion_r1260497685 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/runtimefilter/BatchExecLocalRuntimeFilterBuilder.java: ## @@

[jira] [Created] (FLINK-32579) The filter criteria on the lookup table of Lookup join has no effect

2023-07-11 Thread jasonliangyc (Jira)
jasonliangyc created FLINK-32579: Summary: The filter criteria on the lookup table of Lookup join has no effect Key: FLINK-32579 URL: https://issues.apache.org/jira/browse/FLINK-32579 Project: Flink

[GitHub] [flink] xuzifu666 commented on pull request #22980: [FLINK-31035] add warn info to user when NoNodeException happend

2023-07-11 Thread via GitHub
xuzifu666 commented on PR #22980: URL: https://github.com/apache/flink/pull/22980#issuecomment-1631732406 @rkhachatryan had changed format style,thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [flink] luoyuxia commented on pull request #22839: [FLINK-32349][table] Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-07-11 Thread via GitHub
luoyuxia commented on PR #22839: URL: https://github.com/apache/flink/pull/22839#issuecomment-1631729536 Please don't forget to create a jira to add a doc for the atomic CTAS statement and put the jira and FLINK-32349 under a umbrella jira. -- This is an automated message from the Apache

[jira] [Closed] (FLINK-28460) Flink SQL supports atomic CREATE TABLE AS SELECT(CTAS)

2023-07-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia closed FLINK-28460. Resolution: Fixed > Flink SQL supports atomic CREATE TABLE AS SELECT(CTAS) >

[jira] [Resolved] (FLINK-32349) Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-07-11 Thread luoyuxia (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] luoyuxia resolved FLINK-32349. -- Resolution: Fixed master: e6f77bea70682d1f2d708abee75a0dc33de16ee7 > Support atomic for CREATE

[GitHub] [flink] luoyuxia merged pull request #22839: [FLINK-32349][table] Support atomic for CREATE TABLE AS SELECT(CTAS) statement

2023-07-11 Thread via GitHub
luoyuxia merged PR #22839: URL: https://github.com/apache/flink/pull/22839 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (FLINK-32578) Cascaded group by window time columns on a proctime window aggregate may result hang for ever

2023-07-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-32578: Component/s: Table SQL / Runtime (was: Table SQL / Planner) > Cascaded group

[jira] [Comment Edited] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742098#comment-17742098 ] Martijn Visser edited comment on FLINK-30998 at 7/11/23 11:11 PM: --

[jira] [Closed] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30998. -- Resolution: Fixed > Add optional exception handler to flink-connector-opensearch >

[GitHub] [flink-connector-opensearch] MartijnVisser merged pull request #30: [Backport] [1.0] [FLINK-30998] Apply adding failureHandler on top of current apache:main branch

2023-07-11 Thread via GitHub
MartijnVisser merged PR #30: URL: https://github.com/apache/flink-connector-opensearch/pull/30 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22772: [FLINK-19010][metric] Introduce subtask level restore metric

2023-07-11 Thread via GitHub
rkhachatryan commented on code in PR #22772: URL: https://github.com/apache/flink/pull/22772#discussion_r1260137154 ## flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskIOMetricGroup.java: ## @@ -67,10 +70,12 @@ public class TaskIOMetricGroup extends

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22744: [FLINK-29802][state] Changelog supports native savepoint

2023-07-11 Thread via GitHub
rkhachatryan commented on code in PR #22744: URL: https://github.com/apache/flink/pull/22744#discussion_r1260099896 ## flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogKeyedStateBackend.java: ## @@ -375,6 +378,49 @@

[GitHub] [flink-connector-opensearch] reta commented on pull request #30: [Backport] [1.0] [FLINK-30998] Apply adding failureHandler on top of current apache:main branch

2023-07-11 Thread via GitHub
reta commented on PR #30: URL: https://github.com/apache/flink-connector-opensearch/pull/30#issuecomment-1631239695 > > @MartijnVisser I think we could backport to 1.0, low risk change, thank you > > Fine with me, will you fix the CI? Yes! -- This is an automated message

[GitHub] [flink-kubernetes-operator] afedulov opened a new pull request, #629: [hotfix][docs] Add a 'Build from Source' page

2023-07-11 Thread via GitHub
afedulov opened a new pull request, #629: URL: https://github.com/apache/flink-kubernetes-operator/pull/629 ## What is the purpose of the change Adds a page with instructions and requirements for building from source similar to Flink's

[jira] [Commented] (FLINK-32348) MongoDB tests are flaky and time out

2023-07-11 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742108#comment-17742108 ] Jiabao Sun commented on FLINK-32348: [~martijnvisser] Sorry for the late reply. The root cause of

[jira] [Updated] (FLINK-32348) MongoDB tests are flaky and time out

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32348: --- Labels: pull-request-available test-stability (was: test-stability) > MongoDB tests are

[GitHub] [flink] rkhachatryan commented on a diff in pull request #22980: [FLINK-31035] add warn info to user when NoNodeException happend

2023-07-11 Thread via GitHub
rkhachatryan commented on code in PR #22980: URL: https://github.com/apache/flink/pull/22980#discussion_r1260009895 ## flink-runtime/src/main/java/org/apache/flink/runtime/zookeeper/ZooKeeperStateHandleStore.java: ## @@ -364,6 +364,7 @@ public Collection getAllHandles() throws

[jira] [Commented] (FLINK-32563) Allow connectors CI to specify the main supported Flink version

2023-07-11 Thread Etienne Chauchot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742101#comment-17742101 ] Etienne Chauchot commented on FLINK-32563: -- [~martijnvisser] I had in mind to be slightly more

[jira] [Comment Edited] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742098#comment-17742098 ] Martijn Visser edited comment on FLINK-30998 at 7/11/23 4:48 PM: - Fixed

[jira] [Comment Edited] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742098#comment-17742098 ] Martijn Visser edited comment on FLINK-30998 at 7/11/23 4:48 PM: - Fixed

[jira] [Updated] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser updated FLINK-30998: --- Fix Version/s: opensearch-1.0.2 (was: opensearch-1.1.0) > Add

[jira] [Reopened] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reopened FLINK-30998: > Add optional exception handler to flink-connector-opensearch >

[GitHub] [flink-connector-opensearch] MartijnVisser commented on pull request #30: [Backport] [1.0] [FLINK-30998] Apply adding failureHandler on top of current apache:main branch

2023-07-11 Thread via GitHub
MartijnVisser commented on PR #30: URL: https://github.com/apache/flink-connector-opensearch/pull/30#issuecomment-1631158945 > @MartijnVisser I think we could backport to 1.0, low risk change, thank you Fine with me, will you fix the CI? -- This is an automated message from the

[GitHub] [flink-connector-opensearch] boring-cyborg[bot] commented on pull request #11: [FLINK-30998] Add optional exception handler to flink-connector-opensearch

2023-07-11 Thread via GitHub
boring-cyborg[bot] commented on PR #11: URL: https://github.com/apache/flink-connector-opensearch/pull/11#issuecomment-1631144197 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Closed] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser closed FLINK-30998. -- Fix Version/s: opensearch-1.1.0 Resolution: Fixed Fixed in:

[jira] [Assigned] (FLINK-30998) Add optional exception handler to flink-connector-opensearch

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-30998: -- Assignee: Leonid Ilyevsky > Add optional exception handler to

[jira] [Assigned] (FLINK-32564) Support cast from BYTES to BIGINT

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-32564: -- Assignee: Hanyu Zheng > Support cast from BYTES to BIGINT >

[jira] [Assigned] (FLINK-32565) Support cast from BYTES to DOUBLE

2023-07-11 Thread Martijn Visser (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martijn Visser reassigned FLINK-32565: -- Assignee: Hanyu Zheng > Support cast from BYTES to DOUBLE >

[jira] [Commented] (FLINK-30238) Unified Sink committer does not clean up state on final savepoint

2023-07-11 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-30238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742095#comment-17742095 ] Jing Ge commented on FLINK-30238: - [~ConradJam] would you like to describe the issue you got. We'd like

[jira] [Assigned] (FLINK-32458) support mixed use of JSON_OBJECTAGG & JSON_ARRAYAGG with other aggregate functions

2023-07-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-32458: --- Assignee: Yunhong Zheng > support mixed use of JSON_OBJECTAGG & JSON_ARRAYAGG with other

[jira] [Created] (FLINK-32578) Cascaded group by window time columns on a proctime window aggregate may result hang for ever

2023-07-11 Thread lincoln lee (Jira)
lincoln lee created FLINK-32578: --- Summary: Cascaded group by window time columns on a proctime window aggregate may result hang for ever Key: FLINK-32578 URL: https://issues.apache.org/jira/browse/FLINK-32578

[jira] [Updated] (FLINK-32501) Wrong execution plan of a proctime window aggregation generated due to incorrect cost evaluation

2023-07-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee updated FLINK-32501: Fix Version/s: (was: 1.17.2) > Wrong execution plan of a proctime window aggregation

[GitHub] [flink] flinkbot commented on pull request #22981: [FLINK-28743][table-planner] Supports validating the determinism for StreamPhysicalMatchRecognize

2023-07-11 Thread via GitHub
flinkbot commented on PR #22981: URL: https://github.com/apache/flink/pull/22981#issuecomment-1630953554 ## CI report: * 4a09b912e7aaa9acdc874b6232551c9b63fa188f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-28743) Support validating the determinism for StreamPhysicalMatchRecognize

2023-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-28743: --- Labels: pull-request-available (was: ) > Support validating the determinism for

[GitHub] [flink] lincoln-lil opened a new pull request, #22981: [FLINK-28743][table-planner] Supports validating the determinism for StreamPhysicalMatchRecognize

2023-07-11 Thread via GitHub
lincoln-lil opened a new pull request, #22981: URL: https://github.com/apache/flink/pull/22981 ## What is the purpose of the change This is an minor addition to the FLINK-27849 implementation to support the analysis of the `MatchRecognize` node. Since the `MatchRecognize` will not

[jira] [Assigned] (FLINK-28743) Support validating the determinism for StreamPhysicalMatchRecognize

2023-07-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lincoln lee reassigned FLINK-28743: --- Assignee: lincoln lee > Support validating the determinism for

[GitHub] [flink] XComp commented on a diff in pull request #22932: [FLINK-26549][table][tests] Add tests for INSERT INTO with VALUES leads to wrong type inference with nested types

2023-07-11 Thread via GitHub
XComp commented on code in PR #22932: URL: https://github.com/apache/flink/pull/22932#discussion_r1259561126 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/calcite/FlinkTypeFactoryTest.java: ## @@ -166,6 +172,48 @@ void testCanonizeType() {

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #39: [FLINK-32453] Make main and v3.0 branch build against Flink 1.18-SNAPSHOT

2023-07-11 Thread via GitHub
tzulitai commented on PR #39: URL: https://github.com/apache/flink-connector-kafka/pull/39#issuecomment-1630892082 @XComp there's isn't a Kafka-connector specific release documentation, as far as I'm aware of. So far, the generic doc was good enough at least for the first `v3.0,0` release

[jira] [Commented] (FLINK-32560) Properly deprecate all Scala APIs

2023-07-11 Thread Ryan Skraba (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17742015#comment-17742015 ] Ryan Skraba commented on FLINK-32560: - OK -- taking a quick look at the current work, I'll take a

[jira] [Commented] (FLINK-32455) Breaking change in TypeSerializerUpgradeTestBase prevents flink-connector-kafka from building against 1.18-SNAPSHOT

2023-07-11 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741999#comment-17741999 ] Tzu-Li (Gordon) Tai commented on FLINK-32455: - [~renqs] I'm merging my hotfix PR now which

[jira] [Commented] (FLINK-32455) Breaking change in TypeSerializerUpgradeTestBase prevents flink-connector-kafka from building against 1.18-SNAPSHOT

2023-07-11 Thread Tzu-Li (Gordon) Tai (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741997#comment-17741997 ] Tzu-Li (Gordon) Tai commented on FLINK-32455: - [~gaoyunhaii] that plan sounds good to me.

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #39: [FLINK-32453] Make main and v3.0 branch build against Flink 1.18-SNAPSHOT

2023-07-11 Thread via GitHub
tzulitai commented on PR #39: URL: https://github.com/apache/flink-connector-kafka/pull/39#issuecomment-1630788865 re: @XComp > Would it make sense to create a new testbase class for connectors in flink-connector-common that implements the test data generation and mark it as

[jira] [Commented] (FLINK-27756) Fix intermittently failing test in AsyncSinkWriterTest.checkLoggedSendTimesAreWithinBounds

2023-07-11 Thread Ahmed Hamdy (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741989#comment-17741989 ] Ahmed Hamdy commented on FLINK-27756: - [~Sergey Nuyanzin]thanks for reopening, I will try to take a

[GitHub] [flink-connector-kafka] tzulitai commented on pull request #7: [FLINK-31408] Add support for EOS delivery-guarantee in upsert-kafka

2023-07-11 Thread via GitHub
tzulitai commented on PR #7: URL: https://github.com/apache/flink-connector-kafka/pull/7#issuecomment-1630767966 @Ge as discussed offline, I think there really isn't a better way around the current PR approach. I'll address the comments on the doc and proceed to merge this.

[jira] [Commented] (FLINK-28743) Support validating the determinism for StreamPhysicalMatchRecognize

2023-07-11 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741983#comment-17741983 ] lincoln lee commented on FLINK-28743: - [~twalthr] Sorry for the late reply. Yes, I also confirmed

[jira] [Commented] (FLINK-32528) The RexCall a = a,if a's datatype is nullable, and when a is null, a = a is null, it isn't true in BinaryComparisonExprReducer

2023-07-11 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741974#comment-17741974 ] Yunhong Zheng commented on FLINK-32528: --- Hi, [~shenlang] , can you provide a specific sql query as

[jira] [Commented] (FLINK-32560) Properly deprecate all Scala APIs

2023-07-11 Thread Xintong Song (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741973#comment-17741973 ] Xintong Song commented on FLINK-32560: -- The help is very much welcomed. Thanks [~rskraba] and

[GitHub] [flink] zentol commented on a diff in pull request #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-07-11 Thread via GitHub
zentol commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1259659718 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] afedulov commented on a diff in pull request #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-07-11 Thread via GitHub
afedulov commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1259655490 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] afedulov commented on a diff in pull request #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-07-11 Thread via GitHub
afedulov commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1259655490 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] afedulov commented on a diff in pull request #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-07-11 Thread via GitHub
afedulov commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1259655490 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-07-11 Thread via GitHub
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1630724942 > > One question that comes to my mind now.. This will only work with a 1 server no? if we have a Clickhouse cluster with more than 1 server (that will have a zookeeper

[GitHub] [flink-connector-jdbc] WenDing-Y closed pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-07-11 Thread via GitHub
WenDing-Y closed pull request #49: [FLINK-32068] connector jdbc support clickhouse URL: https://github.com/apache/flink-connector-jdbc/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-07-11 Thread via GitHub
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1630722843 > > One question that comes to my mind now.. This will only work with a 1 server no? if we have a Clickhouse cluster with more than 1 server (that will have a zookeeper

[GitHub] [flink-connector-jdbc] WenDing-Y commented on pull request #49: [FLINK-32068] connector jdbc support clickhouse

2023-07-11 Thread via GitHub
WenDing-Y commented on PR #49: URL: https://github.com/apache/flink-connector-jdbc/pull/49#issuecomment-1630721467 > One question that comes to my mind now.. This will only work with a 1 server no? if we have a Clickhouse cluster with more than 1 server (that will have a zookeeper

[GitHub] [flink] afedulov commented on a diff in pull request #22850: [FLINK-28229][streaming-java] Source API alternatives for StreamExecutionEnvironment#fromCollection() methods

2023-07-11 Thread via GitHub
afedulov commented on code in PR #22850: URL: https://github.com/apache/flink/pull/22850#discussion_r1259648022 ## flink-connectors/flink-connector-datagen-test/pom.xml: ## @@ -0,0 +1,89 @@ + + +http://maven.apache.org/POM/4.0.0; +

[GitHub] [flink] huwh closed pull request #22859: [FLINK-32385][runtime] Introduce SerializedShuffleDescriptorAndIndices to identify a group of ShuffleDescriptorAndIndex

2023-07-11 Thread via GitHub
huwh closed pull request #22859: [FLINK-32385][runtime] Introduce SerializedShuffleDescriptorAndIndices to identify a group of ShuffleDescriptorAndIndex URL: https://github.com/apache/flink/pull/22859 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [flink] huwh closed pull request #22860: [FLINK-32386][runtime] Introduce ShuffleDescriptorsCache to cache ShuffleDescriptorAndIndex

2023-07-11 Thread via GitHub
huwh closed pull request #22860: [FLINK-32386][runtime] Introduce ShuffleDescriptorsCache to cache ShuffleDescriptorAndIndex URL: https://github.com/apache/flink/pull/22860 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [flink] xuzifu666 closed pull request #22021: [Hotfix] typo hotfix in TestingDispatcher

2023-07-11 Thread via GitHub
xuzifu666 closed pull request #22021: [Hotfix] typo hotfix in TestingDispatcher URL: https://github.com/apache/flink/pull/22021 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] xuzifu666 commented on pull request #22980: [FLINK-31035] add warn info to user when NoNodeException happend

2023-07-11 Thread via GitHub
xuzifu666 commented on PR #22980: URL: https://github.com/apache/flink/pull/22980#issuecomment-1630694842 > Thanks for the improvement, could you squash all commits and rebase this to latest master branch. done -- This is an automated message from the Apache Git Service. To

[jira] [Updated] (FLINK-32577) Avoid memory fragmentation when running CI for flink-table-planner module

2023-07-11 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng updated FLINK-32577: -- Description: This issue is a sub-issue of FLINK-18356. (was: This issue is a sub-issue of

[GitHub] [flink] xintongsong commented on a diff in pull request #22975: [FLINK-31643][network] Introduce the configurations for tiered storage

2023-07-11 Thread via GitHub
xintongsong commented on code in PR #22975: URL: https://github.com/apache/flink/pull/22975#discussion_r1259626675 ## flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/NettyShuffleMaster.java: ## @@ -49,7 +55,9 @@ public class NettyShuffleMaster implements

[jira] [Updated] (FLINK-32577) Avoid memory fragmentation when running CI for flink-table-planner module

2023-07-11 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yunhong Zheng updated FLINK-32577: -- Description: This issue is a sub-issue of FLINK-18356. When I run mvn verify for flink

[jira] [Comment Edited] (FLINK-18356) flink-table-planner Exit code 137 returned from process

2023-07-11 Thread Yunhong Zheng (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17741961#comment-17741961 ] Yunhong Zheng edited comment on FLINK-18356 at 7/11/23 11:55 AM: - Hi,

  1   2   >