[GitHub] [flink-connector-jdbc] grzegorz8 commented on pull request #67: [FLINK-30702] Add Elasticsearch dialect

2023-08-16 Thread via GitHub
grzegorz8 commented on PR #67: URL: https://github.com/apache/flink-connector-jdbc/pull/67#issuecomment-1681725076 @MartijnVisser Hi! I've fixed code formatting, so I think build can be rerun now. Thanks! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [flink] WencongLiu commented on pull request #23179: [FLINK-32770][network] Fix the inaccurate backlog number of Hybrid Shuffle

2023-08-16 Thread via GitHub
WencongLiu commented on PR #23179: URL: https://github.com/apache/flink/pull/23179#issuecomment-1681712493 CI has passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-16 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1296743085 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -262,36 +261,92 @@ public void grantLeadership(UUID le

[GitHub] [flink] WencongLiu commented on a diff in pull request #22341: [FLINK-27204][flink-runtime] Refract FileSystemJobResultStore to execute I/O operations on the ioExecutor

2023-08-16 Thread via GitHub
WencongLiu commented on code in PR #22341: URL: https://github.com/apache/flink/pull/22341#discussion_r1296742543 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java: ## @@ -262,36 +261,92 @@ public void grantLeadership(UUID le

[jira] [Created] (FLINK-32887) SourceCoordinatorContext#workerExecutor may cause task initializing slowly

2023-08-16 Thread liang jie (Jira)
liang jie created FLINK-32887: - Summary: SourceCoordinatorContext#workerExecutor may cause task initializing slowly Key: FLINK-32887 URL: https://issues.apache.org/jira/browse/FLINK-32887 Project: Flink

[GitHub] [flink] huwh commented on a diff in pull request #23212: [FLINK-32821][examples] Include flink-connector-datagen for streaming examples

2023-08-16 Thread via GitHub
huwh commented on code in PR #23212: URL: https://github.com/apache/flink/pull/23212#discussion_r1296692344 ## flink-examples/flink-examples-build-helper/flink-examples-streaming-state-machine/pom.xml: ## @@ -79,8 +80,9 @@ under the License.

[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #652: [docs][autoscaler] Autoscaler docs and default config improvement

2023-08-16 Thread via GitHub
gyfora commented on PR #652: URL: https://github.com/apache/flink-kubernetes-operator/pull/652#issuecomment-1681615068 cc @1996fanrui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Updated] (FLINK-27481) Flink checkpoints are very slow after upgrading from Flink 1.13.1 to Flink 1.14.3

2023-08-16 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu updated FLINK-27481: - Component/s: Connectors / Kafka > Flink checkpoints are very slow after upgrading from Flink 1.1

[GitHub] [flink] xuzifu666 commented on pull request #23220: [FLINK-32871][SQL] Support BuiltInMethod TO_TIMESTAMP with timezone options

2023-08-16 Thread via GitHub
xuzifu666 commented on PR #23220: URL: https://github.com/apache/flink/pull/23220#issuecomment-1681563234 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-32883) Support for standby task managers

2023-08-16 Thread Tomoyuki NAKAMURA (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoyuki NAKAMURA updated FLINK-32883: -- Description: [https://docs.ververica.com/user_guide/application_operations/deployments

[GitHub] [flink] X-czh commented on pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
X-czh commented on PR #23200: URL: https://github.com/apache/flink/pull/23200#issuecomment-1681531136 Hi @Jiabao-Sun, thanks for the contribution! Due to the size of the PR, I expect it to take quite a few time, I'll manage to finish reviewing it by the end of this week. -- This is an au

[jira] [Updated] (FLINK-32881) Client supports making savepoints in detach mode

2023-08-16 Thread Renxiang Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Renxiang Zhou updated FLINK-32881: -- Description: When triggering a savepoint using the command-line tool, the client needs to wai

[jira] [Updated] (FLINK-32881) Client supports making savepoints in detach mode

2023-08-16 Thread Renxiang Zhou (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Renxiang Zhou updated FLINK-32881: -- Description: When triggering a savepoint using the command-line tool, the client needs to wai

[jira] [Commented] (FLINK-32668) fix up watchdog timeout error msg in common.sh(e2e test)

2023-08-16 Thread Hongshun Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755331#comment-17755331 ] Hongshun Wang commented on FLINK-32668: --- [~mapohl] , thanks a lot. One more questi

[jira] [Commented] (FLINK-32883) Support for standby task managers

2023-08-16 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755328#comment-17755328 ] Yangze Guo commented on FLINK-32883: ok. I see your problem. The k8s operator will e

[jira] [Commented] (FLINK-32883) Support for standby task managers

2023-08-16 Thread Tomoyuki NAKAMURA (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755326#comment-17755326 ] Tomoyuki NAKAMURA commented on FLINK-32883: --- [~guoyangze] Thank you. It looks

[jira] [Updated] (FLINK-15959) Add min number of slots configuration to limit total number of slots

2023-08-16 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yangze Guo updated FLINK-15959: --- Description: Flink removed `-n` option after FLIP-6, change to ResourceManager start a new worker w

[GitHub] [flink] HuangXingBo commented on a diff in pull request #23141: [FLINK-32758][python] Remove PyFlink dependencies' upper bounds

2023-08-16 Thread via GitHub
HuangXingBo commented on code in PR #23141: URL: https://github.com/apache/flink/pull/23141#discussion_r1296599910 ## flink-python/dev/dev-requirements.txt: ## @@ -15,20 +15,20 @@ pip>=20.3 setuptools>=18.0 wheel -apache-beam==2.43.0 -cython==0.29.24 +apache-beam>=2.43.0,<2.4

[jira] [Comment Edited] (FLINK-32883) Support for standby task managers

2023-08-16 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755319#comment-17755319 ] Yangze Guo edited comment on FLINK-32883 at 8/17/23 2:06 AM: -

[jira] [Commented] (FLINK-32883) Support for standby task managers

2023-08-16 Thread Yangze Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755319#comment-17755319 ] Yangze Guo commented on FLINK-32883: Hi, [~laughingman7743]. IIUC, your requirement

[GitHub] [flink] WencongLiu commented on pull request #23179: [FLINK-32770][network] Fix the inaccurate backlog number of Hybrid Shuffle

2023-08-16 Thread via GitHub
WencongLiu commented on PR #23179: URL: https://github.com/apache/flink/pull/23179#issuecomment-1681486834 The last commit is updated because of checkstyle error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [flink] xuzifu666 commented on pull request #23220: [FLINK-32871][SQL] Support BuiltInMethod TO_TIMESTAMP with timezone options

2023-08-16 Thread via GitHub
xuzifu666 commented on PR #23220: URL: https://github.com/apache/flink/pull/23220#issuecomment-1681484924 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [flink] becketqin commented on a diff in pull request #23164: [FLINK- 32775]Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-08-16 Thread via GitHub
becketqin commented on code in PR #23164: URL: https://github.com/apache/flink/pull/23164#discussion_r1296581609 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java: ## @@ -360,11 +362,27 @@ List registerProvidedLocalResources() {

[GitHub] [flink] wangzzu commented on pull request #23227: [FLINK-32840][runtime][JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-16 Thread via GitHub
wangzzu commented on PR #23227: URL: https://github.com/apache/flink/pull/23227#issuecomment-1681410554 > Hi @wangzzu, thanks for your contribution. The changes overall LGTM. Would you mind updating all change about these improvements? > > * Make test classes package-visible and do no

[GitHub] [flink] wangzzu commented on a diff in pull request #23227: [FLINK-32840][runtime][JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-16 Thread via GitHub
wangzzu commented on code in PR #23227: URL: https://github.com/apache/flink/pull/23227#discussion_r1296540467 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AllVerticesIteratorTest.java: ## @@ -21,23 +21,25 @@ import org.apache.flink.runtime.jobgraph.Jo

[jira] [Updated] (FLINK-13856) Reduce the delete file api when the checkpoint is completed

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-13856: --- Labels: auto-deprioritized-major pull-request-available stale-minor (was: auto-deprioritize

[jira] [Updated] (FLINK-28732) Deprecate ambiguous StateTTLConfig#cleanFullSnapshot API

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28732: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-28520) RestClient doesn't use SNI TLS extension

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28520: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-31747) Externalize debezium from flink-json

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-31747: --- Labels: pull-request-available stale-major (was: pull-request-available) I am the [Flink Ji

[jira] [Updated] (FLINK-18982) InputFormat should remove unnecessary override methods

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-18982: --- Labels: auto-deprioritized-major auto-deprioritized-minor pull-request-available stale-minor

[jira] [Updated] (FLINK-28595) KafkaSource should not read metadata of unmatched regex topics

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28595: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-17855) UDF with parameter Array(Row) can not work

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-17855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-17855: --- Labels: auto-deprioritized-major auto-unassigned sprint stale-minor (was: auto-deprioritize

[jira] [Updated] (FLINK-16050) Add Attempt Information

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-16050: --- Labels: auto-deprioritized-major stale-minor (was: auto-deprioritized-major) I am the [Fli

[jira] [Updated] (FLINK-31395) AbstractPartitionDiscoverer.discoverPartitions calls remove on immutable collection

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-31395: --- Labels: stale-critical test-stability (was: test-stability) I am the [Flink Jira Bot|https:

[jira] [Updated] (FLINK-16686) [State TTL] Make user class loader available in native RocksDB compaction thread

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-16686: --- Labels: auto-deprioritized-major auto-deprioritized-minor stale-minor (was: auto-deprioriti

[jira] [Updated] (FLINK-31192) dataGen takes too long to initialize under sequence

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-31192: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-15123) remove uniqueKeys from FlinkStatistic in blink planner

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-15123: --- Labels: auto-deprioritized-major stale-minor starter (was: auto-deprioritized-major starter

[jira] [Updated] (FLINK-15017) add a thrift server for Flink

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-15017: --- Labels: auto-deprioritized-major auto-deprioritized-minor auto-unassigned stale-minor (was:

[jira] [Updated] (FLINK-15378) StreamFileSystemSink supported mutil hdfs plugins.

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-15378: --- Labels: auto-deprioritized-major pull-request-available stale-minor (was: auto-deprioritize

[jira] [Updated] (FLINK-16165) NestedLoopJoin fallback to HashJoin when build records number is very large

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-16165: --- Labels: auto-deprioritized-critical auto-deprioritized-major auto-deprioritized-minor stale-

[jira] [Updated] (FLINK-18464) ClassCastException during namespace serialization for checkpoint (Heap and RocksDB)

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-18464: --- Labels: auto-deprioritized-major pull-request-available stale-minor (was: auto-deprioritize

[jira] [Updated] (FLINK-15012) Checkpoint directory not cleaned up

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-15012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-15012: --- Labels: auto-deprioritized-major auto-unassigned pull-request-available stale-minor (was: a

[jira] [Updated] (FLINK-28825) [1] Support specify K8S pod scheduler

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28825: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-28639) Preserve distributed consistency of OperatorEvents from subtasks to OperatorCoordinator

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28639: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-28764) Support more than 64 distinct aggregate function calls in one aggregate SQL query

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28764: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-28521) Hostname verification in ssl context is not working

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28521: --- Labels: pull-request-available security stale-assigned (was: pull-request-available securit

[jira] [Updated] (FLINK-28643) Job archive file contains too much Job json file on Flink HistoryServer

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28643: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-28829) [2] Need the ability of preparing K8S resource before JobManager creation

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28829: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Updated] (FLINK-28831) [3] Support pluginable decorators mechanism

2023-08-16 Thread Flink Jira Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-28831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flink Jira Bot updated FLINK-28831: --- Labels: pull-request-available stale-assigned (was: pull-request-available) I am the [Flink

[jira] [Created] (FLINK-32886) Issue with volumeMounts when creating OLM for Flink Operator 1.6.0

2023-08-16 Thread James Busche (Jira)
James Busche created FLINK-32886: Summary: Issue with volumeMounts when creating OLM for Flink Operator 1.6.0 Key: FLINK-32886 URL: https://issues.apache.org/jira/browse/FLINK-32886 Project: Flink

[jira] [Assigned] (FLINK-32885) Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink remote execution

2023-08-16 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise reassigned FLINK-32885: Assignee: Elkhan Dadashov > Refactoring: Moving UrlPrefixDecorator into flink-clients so

[jira] [Assigned] (FLINK-32884) PyFlink remote execution should support URLs with paths and https scheme

2023-08-16 Thread Thomas Weise (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thomas Weise reassigned FLINK-32884: Assignee: Elkhan Dadashov > PyFlink remote execution should support URLs with paths and h

[jira] [Updated] (FLINK-32884) PyFlink remote execution should support URLs with paths and https scheme

2023-08-16 Thread Elkhan Dadashov (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elkhan Dadashov updated FLINK-32884: Description: Currently, the `SUBMIT_ARGS=remote -m http://:` format. For local execution

[jira] [Created] (FLINK-32885) Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink remote execution

2023-08-16 Thread Elkhan Dadashov (Jira)
Elkhan Dadashov created FLINK-32885: --- Summary: Refactoring: Moving UrlPrefixDecorator into flink-clients so it can be used by RestClusterClient for PyFlink remote execution Key: FLINK-32885 URL: https://issues.a

[jira] [Created] (FLINK-32884) PyFlink remote execution should support URLs with paths and https scheme

2023-08-16 Thread Elkhan Dadashov (Jira)
Elkhan Dadashov created FLINK-32884: --- Summary: PyFlink remote execution should support URLs with paths and https scheme Key: FLINK-32884 URL: https://issues.apache.org/jira/browse/FLINK-32884 Projec

[GitHub] [flink] venkata91 commented on a diff in pull request #23164: [FLINK- 32775]Add parent dir of files to classpath using yarn.provided.lib.dirs

2023-08-16 Thread via GitHub
venkata91 commented on code in PR #23164: URL: https://github.com/apache/flink/pull/23164#discussion_r1296273712 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java: ## @@ -360,11 +362,27 @@ List registerProvidedLocalResources() {

[GitHub] [flink] X-czh commented on pull request #23227: [FLINK-32840][runtime][JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-16 Thread via GitHub
X-czh commented on PR #23227: URL: https://github.com/apache/flink/pull/23227#issuecomment-1680970622 Hi @wangzzu, thanks for your contribution. The changes overall LGTM. Would you mind updating all change about these improvements? - Make test classes package-visible and do not extend JUn

[GitHub] [flink] X-czh commented on a diff in pull request #23227: [FLINK-32840][runtime][JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-16 Thread via GitHub
X-czh commented on code in PR #23227: URL: https://github.com/apache/flink/pull/23227#discussion_r1296193064 ## flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AllVerticesIteratorTest.java: ## @@ -21,23 +21,25 @@ import org.apache.flink.runtime.jobgraph.JobV

[GitHub] [flink] X-czh commented on pull request #23198: [FLINK-32856][JUnit5 Migration] Migrate the testutils, throughput and throwable packages of flink-runtime module to junit5

2023-08-16 Thread via GitHub
X-czh commented on PR #23198: URL: https://github.com/apache/flink/pull/23198#issuecomment-1680956906 Thanks for your contribution! Overall LGTM with minor comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [flink] X-czh commented on a diff in pull request #23198: [FLINK-32856][JUnit5 Migration] Migrate the testutils, throughput and throwable packages of flink-runtime module to junit5

2023-08-16 Thread via GitHub
X-czh commented on code in PR #23198: URL: https://github.com/apache/flink/pull/23198#discussion_r1296189640 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/TestJvmProcess.java: ## @@ -316,18 +317,16 @@ public static void waitForMarkerFile(File file, long time

[GitHub] [flink] X-czh commented on a diff in pull request #23198: [FLINK-32856][JUnit5 Migration] Migrate the testutils, throughput and throwable packages of flink-runtime module to junit5

2023-08-16 Thread via GitHub
X-czh commented on code in PR #23198: URL: https://github.com/apache/flink/pull/23198#discussion_r1296189347 ## flink-runtime/src/test/java/org/apache/flink/runtime/testutils/TestJvmProcess.java: ## @@ -316,18 +317,16 @@ public static void waitForMarkerFile(File file, long time

[GitHub] [flink] flinkbot commented on pull request #23227: [FLINK-32840][runtime][JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-16 Thread via GitHub
flinkbot commented on PR #23227: URL: https://github.com/apache/flink/pull/23227#issuecomment-1680953228 ## CI report: * 495e6a3e7c95db994c3065a0f072b3647902ed0d UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-32840) [JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32840: --- Labels: pull-request-available (was: ) > [JUnit5 Migration] The executiongraph package of f

[GitHub] [flink] wangzzu opened a new pull request, #23227: [FLINK-32840][runtime][JUnit5 Migration] The executiongraph package of flink-runtime module

2023-08-16 Thread via GitHub
wangzzu opened a new pull request, #23227: URL: https://github.com/apache/flink/pull/23227 …f flink-runtime module ## What is the purpose of the change Migrate executiongraph related tests under flink-runtime module to junit5 ## Brief change log Migrate e

[GitHub] [flink] jayadeep-jayaraman commented on pull request #23226: [FLINK-32878]add HTTP options to gcs-cloud-storage client

2023-08-16 Thread via GitHub
jayadeep-jayaraman commented on PR #23226: URL: https://github.com/apache/flink/pull/23226#issuecomment-1680936327 @singhravidutt - this commit should be against FLINK-32877, please update the description -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [flink] jayadeep-jayaraman commented on a diff in pull request #23226: [FLINK-32878]add HTTP options to gcs-cloud-storage client

2023-08-16 Thread via GitHub
jayadeep-jayaraman commented on code in PR #23226: URL: https://github.com/apache/flink/pull/23226#discussion_r1296172529 ## docs/content/docs/deployment/filesystems/gcs.md: ## @@ -80,6 +80,8 @@ You can also set `gcs-connector` options directly in the Hadoop `core-site.xml` |

[GitHub] [flink] jayadeep-jayaraman commented on pull request #23226: [FLINK-32878]add HTTP options to gcs-cloud-storage client

2023-08-16 Thread via GitHub
jayadeep-jayaraman commented on PR #23226: URL: https://github.com/apache/flink/pull/23226#issuecomment-1680930945 @MartijnVisser - request you to review this PR which introduces couple of options in the gcs connector to configure timeout properties -- This is an automated message from th

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
Jiabao-Sun commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1296147855 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java: ## @@ -51,43 +51,31 @@ import org.apache.flink.types.IntValue;

[jira] [Updated] (FLINK-32883) Support for standby task managers

2023-08-16 Thread Tomoyuki NAKAMURA (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoyuki NAKAMURA updated FLINK-32883: -- Description: [https://docs.ververica.com/user_guide/application_operations/deployments

[GitHub] [flink] XComp commented on a diff in pull request #20990: [FLINK-29050][JUnit5 Migration] Module: flink-hadoop-compatibility

2023-08-16 Thread via GitHub
XComp commented on code in PR #20990: URL: https://github.com/apache/flink/pull/20990#discussion_r1296124024 ## flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/JavaProgramTestBaseJUnit5.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apache S

[jira] [Updated] (FLINK-32883) Support for standby task managers

2023-08-16 Thread Tomoyuki NAKAMURA (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoyuki NAKAMURA updated FLINK-32883: -- Description: [https://docs.ververica.com/user_guide/application_operations/deployments

[jira] [Created] (FLINK-32883) Support for standby task managers

2023-08-16 Thread Tomoyuki NAKAMURA (Jira)
Tomoyuki NAKAMURA created FLINK-32883: - Summary: Support for standby task managers Key: FLINK-32883 URL: https://issues.apache.org/jira/browse/FLINK-32883 Project: Flink Issue Type: Impro

[jira] [Commented] (FLINK-32873) Add configuration to allow disabling SQL query hints

2023-08-16 Thread Bonnie Varghese (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755158#comment-17755158 ] Bonnie Varghese commented on FLINK-32873: - [~xuyangzhong] [~lsy] Created a discu

[GitHub] [flink] 1996fanrui commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
1996fanrui commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1296100988 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java: ## @@ -51,43 +51,31 @@ import org.apache.flink.types.IntValue;

[GitHub] [flink] XComp commented on a diff in pull request #23195: [FLINK-32834] Ease local use of tools/ci/compile.sh

2023-08-16 Thread via GitHub
XComp commented on code in PR #23195: URL: https://github.com/apache/flink/pull/23195#discussion_r1296070723 ## tools/ci/verify_bundled_optional.sh: ## @@ -17,24 +17,51 @@ # limitations under the License. # +usage() { + echo "Usage: $0 " + echo " A file

[jira] [Resolved] (FLINK-32882) FineGrainedSlotManager cause NPE when clear pending taskmanager twice

2023-08-16 Thread Weihua Hu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weihua Hu resolved FLINK-32882. --- Fix Version/s: 1.18.0 Resolution: Fixed master: b56ae7822f6e4ff3ad67991f1c7916a435c960e9 > F

[GitHub] [flink] RocMarshal commented on a diff in pull request #20990: [FLINK-29050][JUnit5 Migration] Module: flink-hadoop-compatibility

2023-08-16 Thread via GitHub
RocMarshal commented on code in PR #20990: URL: https://github.com/apache/flink/pull/20990#discussion_r1296008112 ## flink-connectors/flink-hadoop-compatibility/src/test/java/org/apache/flink/api/java/hadoop/mapreduce/HadoopInputFormatTest.java: ## @@ -137,27 +132,26 @@ public v

[GitHub] [flink] RocMarshal commented on a diff in pull request #20990: [FLINK-29050][JUnit5 Migration] Module: flink-hadoop-compatibility

2023-08-16 Thread via GitHub
RocMarshal commented on code in PR #20990: URL: https://github.com/apache/flink/pull/20990#discussion_r1296000812 ## flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/JavaProgramTestBaseJUnit5.java: ## @@ -0,0 +1,210 @@ +/* + * Licensed to the Apa

[GitHub] [flink] RocMarshal commented on a diff in pull request #20990: [FLINK-29050][JUnit5 Migration] Module: flink-hadoop-compatibility

2023-08-16 Thread via GitHub
RocMarshal commented on code in PR #20990: URL: https://github.com/apache/flink/pull/20990#discussion_r1295997733 ## flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBaseJUnit5.java: ## @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache

[GitHub] [flink] flinkbot commented on pull request #23226: [FLINK-32878]add HTTP options to gcs-cloud-storage client

2023-08-16 Thread via GitHub
flinkbot commented on PR #23226: URL: https://github.com/apache/flink/pull/23226#issuecomment-1680695275 ## CI report: * 5611cf572d22231a07094dffcc443cd929dc8e00 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[GitHub] [flink] tweise merged pull request #23221: [docs] Add documentation for SQL Client URL support

2023-08-16 Thread via GitHub
tweise merged PR #23221: URL: https://github.com/apache/flink/pull/23221 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache

[jira] [Updated] (FLINK-32878) Add entropy to gcs path for better scalability

2023-08-16 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-32878: --- Labels: pull-request-available (was: ) > Add entropy to gcs path for better scalability > -

[GitHub] [flink] singhravidutt opened a new pull request, #23226: [FLINK-32878]add HTTP options to gcs-cloud-storage client

2023-08-16 Thread via GitHub
singhravidutt opened a new pull request, #23226: URL: https://github.com/apache/flink/pull/23226 ## What is the purpose of the change *Provide a way to ingest http timeout configuration to gcs-cloud-storage library in use.* ## Brief change log - exposed `gs.http.co

[GitHub] [flink-ml] lindong28 commented on a diff in pull request #248: [FLINK-32704] Supports spilling to disk when feedback channel memory buffer is full

2023-08-16 Thread via GitHub
lindong28 commented on code in PR #248: URL: https://github.com/apache/flink-ml/pull/248#discussion_r1295838409 ## flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/typeinfo/IterationRecordSerializer.java: ## @@ -106,7 +106,7 @@ public int get

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
Jiabao-Sun commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295915305 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java: ## @@ -51,43 +51,31 @@ import org.apache.flink.types.IntValue;

[GitHub] [flink] 1996fanrui commented on pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
1996fanrui commented on PR #23200: URL: https://github.com/apache/flink/pull/23200#issuecomment-1680601926 I didn't finish the review due to this PR is totally huge! Hi @X-czh , would you mind helping review this PR in your free time? thanks~ There are too many test migration PR

[GitHub] [flink] 1996fanrui commented on pull request #23211: [FLINK-32835][runtime] Migrate unit tests in "accumulators" and "blob" packages to JUnit5

2023-08-16 Thread via GitHub
1996fanrui commented on PR #23211: URL: https://github.com/apache/flink/pull/23211#issuecomment-1680590054 Hi @Jiabao-Sun , would you mind helping review this PR in your free time? thanks~ There are too many test migration PRs are waiting for my review, and I don't have enough time t

[GitHub] [flink] 1996fanrui commented on pull request #23218: [FLINK-32854][flink-runtime][JUnit5 Migration] The state package of flink-runtime module

2023-08-16 Thread via GitHub
1996fanrui commented on PR #23218: URL: https://github.com/apache/flink/pull/23218#issuecomment-1680588251 Hi @ferenc-csaky , would you mind helping review this PR in your free time? thanks~ There are too many test migration PRs are waiting for my review, and I don't have enough time

[jira] [Commented] (FLINK-32881) Client supports making savepoints in detach mode

2023-08-16 Thread Kelu Tao (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755049#comment-17755049 ] Kelu Tao commented on FLINK-32881: -- +1 for this proposal. > Client supports making sav

[GitHub] [flink] 1996fanrui commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
1996fanrui commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295872872 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/FileChannelManagerImplTest.java: ## @@ -89,28 +90,29 @@ public void testFairness() throws Exception {

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
Jiabao-Sun commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295872833 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java: ## @@ -309,19 +297,19 @@ public void testIsAvailableOrNot() thro

[GitHub] [flink] 1996fanrui commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
1996fanrui commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295867275 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerITCase.java: ## @@ -189,15 +189,13 @@ public void parallelChannelsTest() throws Ex

[GitHub] [flink] 1996fanrui commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
1996fanrui commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295862065 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java: ## @@ -51,43 +51,31 @@ import org.apache.flink.types.IntValue;

[GitHub] [flink] 1996fanrui commented on pull request #23197: [FLINK-32845][JUnit5 Migration] Migrate the memory and messages packages of flink-runtime module to junit5

2023-08-16 Thread via GitHub
1996fanrui commented on PR #23197: URL: https://github.com/apache/flink/pull/23197#issuecomment-1680558427 Hi @Jiabao-Sun , would you mind helping take a look this PR in your free time? thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
Jiabao-Sun commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295845608 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java: ## @@ -309,19 +297,19 @@ public void testIsAvailableOrNot() thro

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
Jiabao-Sun commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295841032 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterDelegateTest.java: ## @@ -137,17 +134,17 @@ private RecordWriter createReco

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
Jiabao-Sun commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295840799 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java: ## @@ -51,43 +51,31 @@ import org.apache.flink.types.IntValue;

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
Jiabao-Sun commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295833653 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerTest.java: ## @@ -61,12 +54,16 @@ public void channelEnumerator() throws Exception

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
Jiabao-Sun commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295831783 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerTest.java: ## @@ -61,12 +54,16 @@ public void channelEnumerator() throws Exception

[GitHub] [flink] Jiabao-Sun commented on a diff in pull request #23200: [FLINK-32850][flink-runtime][JUnit5 Migration] Module: The io package of flink-runtime

2023-08-16 Thread via GitHub
Jiabao-Sun commented on code in PR #23200: URL: https://github.com/apache/flink/pull/23200#discussion_r1295830379 ## flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerITCase.java: ## @@ -222,7 +220,7 @@ public void parallelChannelsTest() throws Exce

  1   2   >