grzegorz8 commented on PR #67:
URL:
https://github.com/apache/flink-connector-jdbc/pull/67#issuecomment-1681725076
@MartijnVisser Hi! I've fixed code formatting, so I think build can be rerun
now. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the mess
WencongLiu commented on PR #23179:
URL: https://github.com/apache/flink/pull/23179#issuecomment-1681712493
CI has passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
WencongLiu commented on code in PR #22341:
URL: https://github.com/apache/flink/pull/22341#discussion_r1296743085
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java:
##
@@ -262,36 +261,92 @@ public void grantLeadership(UUID le
WencongLiu commented on code in PR #22341:
URL: https://github.com/apache/flink/pull/22341#discussion_r1296742543
##
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java:
##
@@ -262,36 +261,92 @@ public void grantLeadership(UUID le
liang jie created FLINK-32887:
-
Summary: SourceCoordinatorContext#workerExecutor may cause task
initializing slowly
Key: FLINK-32887
URL: https://issues.apache.org/jira/browse/FLINK-32887
Project: Flink
huwh commented on code in PR #23212:
URL: https://github.com/apache/flink/pull/23212#discussion_r1296692344
##
flink-examples/flink-examples-build-helper/flink-examples-streaming-state-machine/pom.xml:
##
@@ -79,8 +80,9 @@ under the License.
gyfora commented on PR #652:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/652#issuecomment-1681615068
cc @1996fanrui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
[
https://issues.apache.org/jira/browse/FLINK-27481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hangxiang Yu updated FLINK-27481:
-
Component/s: Connectors / Kafka
> Flink checkpoints are very slow after upgrading from Flink 1.1
xuzifu666 commented on PR #23220:
URL: https://github.com/apache/flink/pull/23220#issuecomment-1681563234
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoyuki NAKAMURA updated FLINK-32883:
--
Description:
[https://docs.ververica.com/user_guide/application_operations/deployments
X-czh commented on PR #23200:
URL: https://github.com/apache/flink/pull/23200#issuecomment-1681531136
Hi @Jiabao-Sun, thanks for the contribution! Due to the size of the PR, I
expect it to take quite a few time, I'll manage to finish reviewing it by the
end of this week.
--
This is an au
[
https://issues.apache.org/jira/browse/FLINK-32881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renxiang Zhou updated FLINK-32881:
--
Description:
When triggering a savepoint using the command-line tool, the client needs to
wai
[
https://issues.apache.org/jira/browse/FLINK-32881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Renxiang Zhou updated FLINK-32881:
--
Description:
When triggering a savepoint using the command-line tool, the client needs to
wai
[
https://issues.apache.org/jira/browse/FLINK-32668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755331#comment-17755331
]
Hongshun Wang commented on FLINK-32668:
---
[~mapohl] , thanks a lot. One more questi
[
https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755328#comment-17755328
]
Yangze Guo commented on FLINK-32883:
ok. I see your problem. The k8s operator will e
[
https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755326#comment-17755326
]
Tomoyuki NAKAMURA commented on FLINK-32883:
---
[~guoyangze] Thank you. It looks
[
https://issues.apache.org/jira/browse/FLINK-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yangze Guo updated FLINK-15959:
---
Description:
Flink removed `-n` option after FLIP-6, change to ResourceManager start a new
worker w
HuangXingBo commented on code in PR #23141:
URL: https://github.com/apache/flink/pull/23141#discussion_r1296599910
##
flink-python/dev/dev-requirements.txt:
##
@@ -15,20 +15,20 @@
pip>=20.3
setuptools>=18.0
wheel
-apache-beam==2.43.0
-cython==0.29.24
+apache-beam>=2.43.0,<2.4
[
https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755319#comment-17755319
]
Yangze Guo edited comment on FLINK-32883 at 8/17/23 2:06 AM:
-
[
https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755319#comment-17755319
]
Yangze Guo commented on FLINK-32883:
Hi, [~laughingman7743]. IIUC, your requirement
WencongLiu commented on PR #23179:
URL: https://github.com/apache/flink/pull/23179#issuecomment-1681486834
The last commit is updated because of checkstyle error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xuzifu666 commented on PR #23220:
URL: https://github.com/apache/flink/pull/23220#issuecomment-1681484924
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
becketqin commented on code in PR #23164:
URL: https://github.com/apache/flink/pull/23164#discussion_r1296581609
##
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java:
##
@@ -360,11 +362,27 @@ List registerProvidedLocalResources() {
wangzzu commented on PR #23227:
URL: https://github.com/apache/flink/pull/23227#issuecomment-1681410554
> Hi @wangzzu, thanks for your contribution. The changes overall LGTM. Would
you mind updating all change about these improvements?
>
> * Make test classes package-visible and do no
wangzzu commented on code in PR #23227:
URL: https://github.com/apache/flink/pull/23227#discussion_r1296540467
##
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AllVerticesIteratorTest.java:
##
@@ -21,23 +21,25 @@
import org.apache.flink.runtime.jobgraph.Jo
[
https://issues.apache.org/jira/browse/FLINK-13856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-13856:
---
Labels: auto-deprioritized-major pull-request-available stale-minor (was:
auto-deprioritize
[
https://issues.apache.org/jira/browse/FLINK-28732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28732:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
[
https://issues.apache.org/jira/browse/FLINK-28520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28520:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
[
https://issues.apache.org/jira/browse/FLINK-31747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-31747:
---
Labels: pull-request-available stale-major (was: pull-request-available)
I am the [Flink Ji
[
https://issues.apache.org/jira/browse/FLINK-18982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-18982:
---
Labels: auto-deprioritized-major auto-deprioritized-minor
pull-request-available stale-minor
[
https://issues.apache.org/jira/browse/FLINK-28595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28595:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
[
https://issues.apache.org/jira/browse/FLINK-17855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-17855:
---
Labels: auto-deprioritized-major auto-unassigned sprint stale-minor (was:
auto-deprioritize
[
https://issues.apache.org/jira/browse/FLINK-16050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-16050:
---
Labels: auto-deprioritized-major stale-minor (was:
auto-deprioritized-major)
I am the [Fli
[
https://issues.apache.org/jira/browse/FLINK-31395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-31395:
---
Labels: stale-critical test-stability (was: test-stability)
I am the [Flink Jira Bot|https:
[
https://issues.apache.org/jira/browse/FLINK-16686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-16686:
---
Labels: auto-deprioritized-major auto-deprioritized-minor stale-minor
(was: auto-deprioriti
[
https://issues.apache.org/jira/browse/FLINK-31192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-31192:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
[
https://issues.apache.org/jira/browse/FLINK-15123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-15123:
---
Labels: auto-deprioritized-major stale-minor starter (was:
auto-deprioritized-major starter
[
https://issues.apache.org/jira/browse/FLINK-15017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-15017:
---
Labels: auto-deprioritized-major auto-deprioritized-minor auto-unassigned
stale-minor (was:
[
https://issues.apache.org/jira/browse/FLINK-15378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-15378:
---
Labels: auto-deprioritized-major pull-request-available stale-minor (was:
auto-deprioritize
[
https://issues.apache.org/jira/browse/FLINK-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-16165:
---
Labels: auto-deprioritized-critical auto-deprioritized-major
auto-deprioritized-minor stale-
[
https://issues.apache.org/jira/browse/FLINK-18464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-18464:
---
Labels: auto-deprioritized-major pull-request-available stale-minor (was:
auto-deprioritize
[
https://issues.apache.org/jira/browse/FLINK-15012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-15012:
---
Labels: auto-deprioritized-major auto-unassigned pull-request-available
stale-minor (was: a
[
https://issues.apache.org/jira/browse/FLINK-28825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28825:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
[
https://issues.apache.org/jira/browse/FLINK-28639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28639:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
[
https://issues.apache.org/jira/browse/FLINK-28764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28764:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
[
https://issues.apache.org/jira/browse/FLINK-28521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28521:
---
Labels: pull-request-available security stale-assigned (was:
pull-request-available securit
[
https://issues.apache.org/jira/browse/FLINK-28643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28643:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
[
https://issues.apache.org/jira/browse/FLINK-28829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28829:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
[
https://issues.apache.org/jira/browse/FLINK-28831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Flink Jira Bot updated FLINK-28831:
---
Labels: pull-request-available stale-assigned (was: pull-request-available)
I am the [Flink
James Busche created FLINK-32886:
Summary: Issue with volumeMounts when creating OLM for Flink
Operator 1.6.0
Key: FLINK-32886
URL: https://issues.apache.org/jira/browse/FLINK-32886
Project: Flink
[
https://issues.apache.org/jira/browse/FLINK-32885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Weise reassigned FLINK-32885:
Assignee: Elkhan Dadashov
> Refactoring: Moving UrlPrefixDecorator into flink-clients so
[
https://issues.apache.org/jira/browse/FLINK-32884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Weise reassigned FLINK-32884:
Assignee: Elkhan Dadashov
> PyFlink remote execution should support URLs with paths and h
[
https://issues.apache.org/jira/browse/FLINK-32884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elkhan Dadashov updated FLINK-32884:
Description:
Currently, the `SUBMIT_ARGS=remote -m http://:` format. For
local execution
Elkhan Dadashov created FLINK-32885:
---
Summary: Refactoring: Moving UrlPrefixDecorator into flink-clients
so it can be used by RestClusterClient for PyFlink remote execution
Key: FLINK-32885
URL: https://issues.a
Elkhan Dadashov created FLINK-32884:
---
Summary: PyFlink remote execution should support URLs with paths
and https scheme
Key: FLINK-32884
URL: https://issues.apache.org/jira/browse/FLINK-32884
Projec
venkata91 commented on code in PR #23164:
URL: https://github.com/apache/flink/pull/23164#discussion_r1296273712
##
flink-yarn/src/main/java/org/apache/flink/yarn/YarnApplicationFileUploader.java:
##
@@ -360,11 +362,27 @@ List registerProvidedLocalResources() {
X-czh commented on PR #23227:
URL: https://github.com/apache/flink/pull/23227#issuecomment-1680970622
Hi @wangzzu, thanks for your contribution. The changes overall LGTM. Would
you mind updating all change about these improvements?
- Make test classes package-visible and do not extend JUn
X-czh commented on code in PR #23227:
URL: https://github.com/apache/flink/pull/23227#discussion_r1296193064
##
flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/AllVerticesIteratorTest.java:
##
@@ -21,23 +21,25 @@
import org.apache.flink.runtime.jobgraph.JobV
X-czh commented on PR #23198:
URL: https://github.com/apache/flink/pull/23198#issuecomment-1680956906
Thanks for your contribution! Overall LGTM with minor comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
X-czh commented on code in PR #23198:
URL: https://github.com/apache/flink/pull/23198#discussion_r1296189640
##
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/TestJvmProcess.java:
##
@@ -316,18 +317,16 @@ public static void waitForMarkerFile(File file, long
time
X-czh commented on code in PR #23198:
URL: https://github.com/apache/flink/pull/23198#discussion_r1296189347
##
flink-runtime/src/test/java/org/apache/flink/runtime/testutils/TestJvmProcess.java:
##
@@ -316,18 +317,16 @@ public static void waitForMarkerFile(File file, long
time
flinkbot commented on PR #23227:
URL: https://github.com/apache/flink/pull/23227#issuecomment-1680953228
## CI report:
* 495e6a3e7c95db994c3065a0f072b3647902ed0d UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
[
https://issues.apache.org/jira/browse/FLINK-32840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-32840:
---
Labels: pull-request-available (was: )
> [JUnit5 Migration] The executiongraph package of f
wangzzu opened a new pull request, #23227:
URL: https://github.com/apache/flink/pull/23227
…f flink-runtime module
## What is the purpose of the change
Migrate executiongraph related tests under flink-runtime module to junit5
## Brief change log
Migrate e
jayadeep-jayaraman commented on PR #23226:
URL: https://github.com/apache/flink/pull/23226#issuecomment-1680936327
@singhravidutt - this commit should be against FLINK-32877, please update
the description
--
This is an automated message from the Apache Git Service.
To respond to the messa
jayadeep-jayaraman commented on code in PR #23226:
URL: https://github.com/apache/flink/pull/23226#discussion_r1296172529
##
docs/content/docs/deployment/filesystems/gcs.md:
##
@@ -80,6 +80,8 @@ You can also set `gcs-connector` options directly in the
Hadoop `core-site.xml`
|
jayadeep-jayaraman commented on PR #23226:
URL: https://github.com/apache/flink/pull/23226#issuecomment-1680930945
@MartijnVisser - request you to review this PR which introduces couple of
options in the gcs connector to configure timeout properties
--
This is an automated message from th
Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1296147855
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java:
##
@@ -51,43 +51,31 @@
import org.apache.flink.types.IntValue;
[
https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoyuki NAKAMURA updated FLINK-32883:
--
Description:
[https://docs.ververica.com/user_guide/application_operations/deployments
XComp commented on code in PR #20990:
URL: https://github.com/apache/flink/pull/20990#discussion_r1296124024
##
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/JavaProgramTestBaseJUnit5.java:
##
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apache S
[
https://issues.apache.org/jira/browse/FLINK-32883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoyuki NAKAMURA updated FLINK-32883:
--
Description:
[https://docs.ververica.com/user_guide/application_operations/deployments
Tomoyuki NAKAMURA created FLINK-32883:
-
Summary: Support for standby task managers
Key: FLINK-32883
URL: https://issues.apache.org/jira/browse/FLINK-32883
Project: Flink
Issue Type: Impro
[
https://issues.apache.org/jira/browse/FLINK-32873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755158#comment-17755158
]
Bonnie Varghese commented on FLINK-32873:
-
[~xuyangzhong] [~lsy] Created a discu
1996fanrui commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1296100988
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java:
##
@@ -51,43 +51,31 @@
import org.apache.flink.types.IntValue;
XComp commented on code in PR #23195:
URL: https://github.com/apache/flink/pull/23195#discussion_r1296070723
##
tools/ci/verify_bundled_optional.sh:
##
@@ -17,24 +17,51 @@
# limitations under the License.
#
+usage() {
+ echo "Usage: $0 "
+ echo " A file
[
https://issues.apache.org/jira/browse/FLINK-32882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Weihua Hu resolved FLINK-32882.
---
Fix Version/s: 1.18.0
Resolution: Fixed
master: b56ae7822f6e4ff3ad67991f1c7916a435c960e9
> F
RocMarshal commented on code in PR #20990:
URL: https://github.com/apache/flink/pull/20990#discussion_r1296008112
##
flink-connectors/flink-hadoop-compatibility/src/test/java/org/apache/flink/api/java/hadoop/mapreduce/HadoopInputFormatTest.java:
##
@@ -137,27 +132,26 @@ public v
RocMarshal commented on code in PR #20990:
URL: https://github.com/apache/flink/pull/20990#discussion_r1296000812
##
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/JavaProgramTestBaseJUnit5.java:
##
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the Apa
RocMarshal commented on code in PR #20990:
URL: https://github.com/apache/flink/pull/20990#discussion_r1295997733
##
flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/AbstractTestBaseJUnit5.java:
##
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache
flinkbot commented on PR #23226:
URL: https://github.com/apache/flink/pull/23226#issuecomment-1680695275
## CI report:
* 5611cf572d22231a07094dffcc443cd929dc8e00 UNKNOWN
Bot commands
The @flinkbot bot supports the following commands:
- `@flinkbot run azure`
tweise merged PR #23221:
URL: https://github.com/apache/flink/pull/23221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache
[
https://issues.apache.org/jira/browse/FLINK-32878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated FLINK-32878:
---
Labels: pull-request-available (was: )
> Add entropy to gcs path for better scalability
> -
singhravidutt opened a new pull request, #23226:
URL: https://github.com/apache/flink/pull/23226
## What is the purpose of the change
*Provide a way to ingest http timeout configuration to gcs-cloud-storage
library in use.*
## Brief change log
- exposed `gs.http.co
lindong28 commented on code in PR #248:
URL: https://github.com/apache/flink-ml/pull/248#discussion_r1295838409
##
flink-ml-iteration/flink-ml-iteration-common/src/main/java/org/apache/flink/iteration/typeinfo/IterationRecordSerializer.java:
##
@@ -106,7 +106,7 @@ public int get
Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295915305
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java:
##
@@ -51,43 +51,31 @@
import org.apache.flink.types.IntValue;
1996fanrui commented on PR #23200:
URL: https://github.com/apache/flink/pull/23200#issuecomment-1680601926
I didn't finish the review due to this PR is totally huge!
Hi @X-czh , would you mind helping review this PR in your free time? thanks~
There are too many test migration PR
1996fanrui commented on PR #23211:
URL: https://github.com/apache/flink/pull/23211#issuecomment-1680590054
Hi @Jiabao-Sun , would you mind helping review this PR in your free time?
thanks~
There are too many test migration PRs are waiting for my review, and I don't
have enough time t
1996fanrui commented on PR #23218:
URL: https://github.com/apache/flink/pull/23218#issuecomment-1680588251
Hi @ferenc-csaky , would you mind helping review this PR in your free time?
thanks~
There are too many test migration PRs are waiting for my review, and I don't
have enough time
[
https://issues.apache.org/jira/browse/FLINK-32881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17755049#comment-17755049
]
Kelu Tao commented on FLINK-32881:
--
+1 for this proposal.
> Client supports making sav
1996fanrui commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295872872
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/FileChannelManagerImplTest.java:
##
@@ -89,28 +90,29 @@ public void testFairness() throws Exception {
Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295872833
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java:
##
@@ -309,19 +297,19 @@ public void testIsAvailableOrNot() thro
1996fanrui commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295867275
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerITCase.java:
##
@@ -189,15 +189,13 @@ public void parallelChannelsTest() throws Ex
1996fanrui commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295862065
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java:
##
@@ -51,43 +51,31 @@
import org.apache.flink.types.IntValue;
1996fanrui commented on PR #23197:
URL: https://github.com/apache/flink/pull/23197#issuecomment-1680558427
Hi @Jiabao-Sun , would you mind helping take a look this PR in your free
time? thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295845608
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java:
##
@@ -309,19 +297,19 @@ public void testIsAvailableOrNot() thro
Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295841032
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterDelegateTest.java:
##
@@ -137,17 +134,17 @@ private RecordWriter createReco
Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295840799
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/api/writer/RecordWriterTest.java:
##
@@ -51,43 +51,31 @@
import org.apache.flink.types.IntValue;
Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295833653
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerTest.java:
##
@@ -61,12 +54,16 @@ public void channelEnumerator() throws Exception
Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295831783
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerTest.java:
##
@@ -61,12 +54,16 @@ public void channelEnumerator() throws Exception
Jiabao-Sun commented on code in PR #23200:
URL: https://github.com/apache/flink/pull/23200#discussion_r1295830379
##
flink-runtime/src/test/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerITCase.java:
##
@@ -222,7 +220,7 @@ public void parallelChannelsTest() throws Exce
1 - 100 of 171 matches
Mail list logo