[jira] [Comment Edited] (FLINK-25857) Add committer metrics to track the status of committables

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789356#comment-17789356 ] Weijie Guo edited comment on FLINK-25857 at 11/24/23 7:53 AM: -- Thanks

[jira] [Commented] (FLINK-25857) Add committer metrics to track the status of committables

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789356#comment-17789356 ] Weijie Guo commented on FLINK-25857: Thanks [~pvary] for the quick reply! Yes, In principle, it is

[jira] [Commented] (FLINK-27681) Improve the availability of Flink when the RocksDB file is corrupted.

2023-11-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789355#comment-17789355 ] Rui Fan commented on FLINK-27681: - {quote}In our production, the underlying environment may produce some

Re: [PR] [FLINK-27681] RocksdbStatebackend verify incremental sst file checksum during checkpoint [flink]

2023-11-23 Thread via GitHub
1996fanrui commented on code in PR #23765: URL: https://github.com/apache/flink/pull/23765#discussion_r1404014532 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java: ## @@ -86,6 +86,18 @@ public class

Re: [PR] [FLINK-33613][python] Make sure gRPC server is shutdown gracefully if Python process startup failed [flink]

2023-11-23 Thread via GitHub
flinkbot commented on PR #23789: URL: https://github.com/apache/flink/pull/23789#issuecomment-1825239372 ## CI report: * 30acb658f852496d73028b93467c024f3f4d43a0 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Assigned] (FLINK-33613) Python UDF Runner process leak in Process Mode

2023-11-23 Thread Dian Fu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dian Fu reassigned FLINK-33613: --- Assignee: Dian Fu > Python UDF Runner process leak in Process Mode >

[jira] [Updated] (FLINK-33613) Python UDF Runner process leak in Process Mode

2023-11-23 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33613: --- Labels: pull-request-available (was: ) > Python UDF Runner process leak in Process Mode >

[PR] [FLINK-33613][python] Make sure gRPC server is shutdown gracefully if Python process startup failed [flink]

2023-11-23 Thread via GitHub
dianfu opened a new pull request, #23789: URL: https://github.com/apache/flink/pull/23789 ## What is the purpose of the change *This pull request fix the issue that the Java gRPC server was not shutdown properly during job cancelling which may cause the Python process not

Re: [PR] [DOC]Update watermark column type [flink]

2023-11-23 Thread via GitHub
flinkbot commented on PR #23788: URL: https://github.com/apache/flink/pull/23788#issuecomment-1825226910 ## CI report: * cfb92fb619cfdbaa4b610d4c95dae57922afec18 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-31385) Introduce extended Assertj Matchers for completable futures

2023-11-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789347#comment-17789347 ] Yun Tang commented on FLINK-31385: -- Also picked in release-1.17

[PR] [DOC]Update watermark column type [flink]

2023-11-23 Thread via GitHub
hehuiyuan opened a new pull request, #23788: URL: https://github.com/apache/flink/pull/23788 ## What is the purpose of the change ![image](https://github.com/apache/flink/assets/18002496/9e1e478b-84ac-4930-9a42-6bb91616a3f2)

[jira] [Updated] (FLINK-31385) Introduce extended Assertj Matchers for completable futures

2023-11-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang updated FLINK-31385: - Fix Version/s: 1.17.3 > Introduce extended Assertj Matchers for completable futures >

[jira] [Resolved] (FLINK-33598) Watch HA configmap via name instead of lables to reduce pressure on APIserver

2023-11-23 Thread Yun Tang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yun Tang resolved FLINK-33598. -- Resolution: Fixed Merged master: 608546e090f5d41c6a8b9af2c264467279181027 ...

[jira] [Commented] (FLINK-33338) Bump FRocksDB version

2023-11-23 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789345#comment-17789345 ] Yue Ma commented on FLINK-8: [~pnowojski] Update:  Now All the changes we need are released in

[jira] [Comment Edited] (FLINK-33338) Bump FRocksDB version

2023-11-23 Thread Yue Ma (Jira)
[ https://issues.apache.org/jira/browse/FLINK-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789345#comment-17789345 ] Yue Ma edited comment on FLINK-8 at 11/24/23 6:49 AM: -- [~pnowojski] Update: 

[jira] [Commented] (FLINK-25857) Add committer metrics to track the status of committables

2023-11-23 Thread Peter Vary (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789335#comment-17789335 ] Peter Vary commented on FLINK-25857: For the Iceberg connector we release separate versions for

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789334#comment-17789334 ] Benchao Li commented on FLINK-33541: There is no such usage: "RAND(a, 10) and RAND(b, 10) ". The

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-23 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789330#comment-17789330 ] xuyang commented on FLINK-33541: Hi, [~libenchao] , I checked the code again and sorry for this mistake.

[jira] [Updated] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-23 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-33541: --- Attachment: image-2023-11-24-13-31-21-209.png > RAND_INTEGER can't be existed in a IF statement >

[jira] [Commented] (FLINK-33565) The concurrentExceptions doesn't work

2023-11-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789329#comment-17789329 ] Rui Fan commented on FLINK-33565: - Give some background here:

[jira] [Commented] (FLINK-33490) Validate the name conflicts when creating view

2023-11-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789326#comment-17789326 ] Benchao Li commented on FLINK-33490: I agree mostly, I don't have a strong opinion whether to have a

[jira] [Commented] (FLINK-33541) RAND_INTEGER can't be existed in a IF statement

2023-11-23 Thread Benchao Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789325#comment-17789325 ] Benchao Li commented on FLINK-33541: {quote}I notice currently the CAST rule is correct. It forbids

[jira] [Resolved] (FLINK-33624) Bump Guava to 32.1.3-jre in flink-table

2023-11-23 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Ge resolved FLINK-33624. - Resolution: Fixed > Bump Guava to 32.1.3-jre in flink-table > --- >

[jira] [Commented] (FLINK-33624) Bump Guava to 32.1.3-jre in flink-table

2023-11-23 Thread Jing Ge (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789324#comment-17789324 ] Jing Ge commented on FLINK-33624: - master: 34620fc5c5698d00e64c6b15f8ce84f807a2e0d7 > Bump Guava to

[jira] [Closed] (FLINK-33547) SQL primitive array type after upgrading to Flink 1.18.0

2023-11-23 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xingcan Cui closed FLINK-33547. --- Resolution: Duplicate Duplicated with https://issues.apache.org/jira/browse/FLINK-33523 > SQL

[jira] [Commented] (FLINK-33547) SQL primitive array type after upgrading to Flink 1.18.0

2023-11-23 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789319#comment-17789319 ] Xingcan Cui commented on FLINK-33547: - Sure. I'll close this. > SQL primitive array type after

[jira] [Commented] (FLINK-33547) SQL primitive array type after upgrading to Flink 1.18.0

2023-11-23 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789317#comment-17789317 ] Prabhu Joseph commented on FLINK-33547: --- [~xccui] Thanks for the details. This issue seems to be

[jira] [Commented] (FLINK-33523) DataType ARRAY fails to cast into Object[]

2023-11-23 Thread Prabhu Joseph (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789316#comment-17789316 ] Prabhu Joseph commented on FLINK-33523: --- Thanks [~jeyhun]. Flink 1.17 does not have this

Re: [PR] [FLINK-33358][sql] Fix Flink SQL Client fail to start in Flink on YARN [flink]

2023-11-23 Thread via GitHub
PrabhuJoseph commented on PR #23629: URL: https://github.com/apache/flink/pull/23629#issuecomment-1825118817 @1996fanrui Could you help in committing this change. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Comment Edited] (FLINK-33472) Solve the problem that the temporary file of flink-conf.yaml in S3AFileSystem cannot be uploaded

2023-11-23 Thread zhengzhili (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789000#comment-17789000 ] zhengzhili edited comment on FLINK-33472 at 11/24/23 3:40 AM: -- [~mapohl]   

[jira] [Commented] (FLINK-33547) SQL primitive array type after upgrading to Flink 1.18.0

2023-11-23 Thread Xingcan Cui (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789311#comment-17789311 ] Xingcan Cui commented on FLINK-33547: - Hi [~jeyhun] , thanks for your attention! What you explained

Re: [PR] [FLINK-27681] RocksdbStatebackend verify incremental sst file checksum during checkpoint [flink]

2023-11-23 Thread via GitHub
mayuehappy commented on PR #23765: URL: https://github.com/apache/flink/pull/23765#issuecomment-1825104163 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-27681] RocksdbStatebackend verify incremental sst file checksum during checkpoint [flink]

2023-11-23 Thread via GitHub
mayuehappy commented on PR #23765: URL: https://github.com/apache/flink/pull/23765#issuecomment-1825103757 @masteryhx Thanks for the code review , I have updated the MR , PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (FLINK-25857) Add committer metrics to track the status of committables

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789304#comment-17789304 ] Weijie Guo commented on FLINK-25857: IIUC, this will cause our external connector sink to be unable

[jira] [Updated] (FLINK-33635) Some connectors can not compile in 1.19-SNAPSHOT

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33635: --- Priority: Blocker (was: Major) > Some connectors can not compile in 1.19-SNAPSHOT >

[jira] [Created] (FLINK-33636) Implement JdbcAutoScalerEventHandler

2023-11-23 Thread Rui Fan (Jira)
Rui Fan created FLINK-33636: --- Summary: Implement JdbcAutoScalerEventHandler Key: FLINK-33636 URL: https://issues.apache.org/jira/browse/FLINK-33636 Project: Flink Issue Type: Sub-task

[jira] [Commented] (FLINK-33635) Some connectors can not compile in 1.19-SNAPSHOT

2023-11-23 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789301#comment-17789301 ] Jiabao Sun commented on FLINK-33635: mongodb:

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-23 Thread via GitHub
flinkbot commented on PR #23787: URL: https://github.com/apache/flink/pull/23787#issuecomment-1825089599 ## CI report: * ebda3f5e2e64929e223823778ca6626435eed26b UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Commented] (FLINK-33635) Some connectors can not compile in 1.19-SNAPSHOT

2023-11-23 Thread Yuxin Tan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789300#comment-17789300 ] Yuxin Tan commented on FLINK-33635: --- The failed reason is that the APIs are changed by

[jira] [Updated] (FLINK-33635) Some connector can not compile in 1.19-SNAPSHOT

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33635: --- Description: The sink API compatibility was broken in FLINK-25857.

[jira] [Updated] (FLINK-33635) Some connectors can not compile in 1.19-SNAPSHOT

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33635: --- Summary: Some connectors can not compile in 1.19-SNAPSHOT (was: Some connector can not compile in

Re: [PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects. [flink]

2023-11-23 Thread via GitHub
JunRuiLee commented on code in PR #23758: URL: https://github.com/apache/flink/pull/23758#discussion_r1403852951 ## flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java: ## @@ -676,8 +690,16 @@ public

Re: [PR] [FLINK-33581][core] Deprecate configuration getters/setters that return/set complex Java objects. [flink]

2023-11-23 Thread via GitHub
JunRuiLee commented on PR #23758: URL: https://github.com/apache/flink/pull/23758#issuecomment-1825087740 Hi @zhuzhurk, Thanks for your review. I've updated this PR, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-23 Thread via GitHub
JingGe opened a new pull request, #23787: URL: https://github.com/apache/flink/pull/23787 ## What is the purpose of the change Add the externalized connector repos into the doc to ease developer find the related connectors. ## Verifying this change This change is a

[jira] [Updated] (FLINK-33635) Some connector can not compile in 1.19-SNAPSHOT

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33635: --- Component/s: Connectors / Common (was: Connectors / ElasticSearch) > Some

[jira] [Updated] (FLINK-33635) Some connector can not compile in 1.19-SNAPSHOT

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33635: --- Summary: Some connector can not compile in 1.19-SNAPSHOT (was: Connector sink can not compile) >

[jira] [Commented] (FLINK-33635) Some connector can not compile in 1.19-SNAPSHOT

2023-11-23 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789299#comment-17789299 ] Jiabao Sun commented on FLINK-33635: It seems caused by the refactor of Sink.InitContext.

[jira] [Updated] (FLINK-33635) Connector sink can not compile

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33635: --- Summary: Connector sink can not compile (was: ElasticSearch connector main branch can not compile)

[jira] [Created] (FLINK-33635) ElasticSearch connector main branch can not compile

2023-11-23 Thread Weijie Guo (Jira)
Weijie Guo created FLINK-33635: -- Summary: ElasticSearch connector main branch can not compile Key: FLINK-33635 URL: https://issues.apache.org/jira/browse/FLINK-33635 Project: Flink Issue Type:

[jira] [Closed] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map on AZP

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-33184. -- Resolution: Fixed > HybridShuffleITCase fails with exception in resource cleanup of task Map on >

[jira] [Commented] (FLINK-33184) HybridShuffleITCase fails with exception in resource cleanup of task Map on AZP

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789293#comment-17789293 ] Weijie Guo commented on FLINK-33184: It sees that this code path(i.e. IllegalStateException: Leaking

[jira] [Closed] (FLINK-33370) Simplify validateAndParseHostsString in Elasticsearch connecter's configuration

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-33370. -- Fix Version/s: elasticsearch-3.1.0 Resolution: Fixed main via

Re: [PR] [FLINK-33370][connectors/elasticsearch] Simplify validateAndParseHostsString in Elasticsearch connector's configuration [flink-connector-elasticsearch]

2023-11-23 Thread via GitHub
reswqa merged PR #77: URL: https://github.com/apache/flink-connector-elasticsearch/pull/77 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo closed FLINK-33502. -- Assignee: Wencong Liu Resolution: Fixed master(1.19) via

[jira] [Updated] (FLINK-33502) HybridShuffleITCase caused a fatal error

2023-11-23 Thread Weijie Guo (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Weijie Guo updated FLINK-33502: --- Fix Version/s: 1.19.0 > HybridShuffleITCase caused a fatal error >

Re: [PR] [FLINK-33502][network] Ignore RejectedExecutionException in DiskIOScheduler when the batch read executor service shuts down [flink]

2023-11-23 Thread via GitHub
reswqa merged PR #23781: URL: https://github.com/apache/flink/pull/23781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33598][k8s] Watch HA configmap via name instead of lables to reduce pressure on APIserver [flink]

2023-11-23 Thread via GitHub
Myasuka merged PR #23764: URL: https://github.com/apache/flink/pull/23764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33583][table] support state ttl hint for join [flink]

2023-11-23 Thread via GitHub
hackergin commented on code in PR #23752: URL: https://github.com/apache/flink/pull/23752#discussion_r1403827616 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/hints/stream/StateTtlHintTest.java: ## @@ -0,0 +1,195 @@ +/* + * Licensed to the

Re: [PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-23 Thread via GitHub
flinkbot commented on PR #23786: URL: https://github.com/apache/flink/pull/23786#issuecomment-1825056837 ## CI report: * 0c724f5597a1654d83682d5c39c7ee0ef2959cca UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][table][test] remove duplicated code [flink]

2023-11-23 Thread via GitHub
JingGe opened a new pull request, #23786: URL: https://github.com/apache/flink/pull/23786 ## What is the purpose of the change remove duplicated code according the clean code concept. ## Verifying this change This change is a trivial rework / code cleanup without any

[jira] [Closed] (FLINK-33616) multi lookup join error

2023-11-23 Thread yong yang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] yong yang closed FLINK-33616. - Resolution: Done > multi lookup join error > --- > > Key:

Re: [PR] [BP-1.17][FLINK-18356] Update CI image [flink]

2023-11-23 Thread via GitHub
snuyanzin commented on PR #23757: URL: https://github.com/apache/flink/pull/23757#issuecomment-1825039210 Thanks for driving this :+1: After looking at FLINK-28203 i noticed that there are also files tools/ci/compile.sh tools/ci/maven-utils.sh

Re: [PR] [BP-1.17][FLINK-18356] Update CI image [flink]

2023-11-23 Thread via GitHub
snuyanzin commented on code in PR #23757: URL: https://github.com/apache/flink/pull/23757#discussion_r1403810179 ## flink-table/flink-sql-gateway/pom.xml: ## @@ -47,6 +47,7 @@ org.apache.flink flink-sql-gateway-api ${project.version} +

Re: [PR] [BP-1.17][FLINK-18356] Update CI image [flink]

2023-11-23 Thread via GitHub
snuyanzin commented on code in PR #23757: URL: https://github.com/apache/flink/pull/23757#discussion_r1403809755 ## flink-dist/pom.xml: ## @@ -480,6 +508,12 @@ under the License. ${project.version} provided

Re: [PR] [BP-1.17][FLINK-18356] Update CI image [flink]

2023-11-23 Thread via GitHub
snuyanzin commented on code in PR #23757: URL: https://github.com/apache/flink/pull/23757#discussion_r1403809450 ## flink-dist/pom.xml: ## @@ -454,6 +470,18 @@ under the License. provided + +

[jira] [Resolved] (FLINK-33485) Optimize the EXISTS sub-query by Metadata RowCount

2023-11-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33485. - Fix Version/s: 1.19.0 Resolution: Fixed > Optimize the EXISTS sub-query by

[jira] [Closed] (FLINK-33485) Optimize the EXISTS sub-query by Metadata RowCount

2023-11-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33485. --- > Optimize the EXISTS sub-query by Metadata RowCount >

[jira] [Commented] (FLINK-33485) Optimize the EXISTS sub-query by Metadata RowCount

2023-11-23 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789280#comment-17789280 ] Sergey Nuyanzin commented on FLINK-33485: - Merged to master as

Re: [PR] [FLINK-33485][table] Optimize exists subqueries by looking at metadata rowcount [flink]

2023-11-23 Thread via GitHub
snuyanzin merged PR #23685: URL: https://github.com/apache/flink/pull/23685 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33485][table] Optimize exists subqueries by looking at metadata rowcount [flink]

2023-11-23 Thread via GitHub
snuyanzin commented on PR #23685: URL: https://github.com/apache/flink/pull/23685#issuecomment-1825029898 Thanks for taking a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] (FLINK-31958) Table to DataStream allow partial fields

2023-11-23 Thread padavan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31958 ] padavan deleted comment on FLINK-31958: - was (Author: JIRAUSER287909): up > Table to DataStream allow partial fields > > > Key:

[jira] [Commented] (FLINK-31958) Table to DataStream allow partial fields

2023-11-23 Thread padavan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-31958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789239#comment-17789239 ] padavan commented on FLINK-31958: - up > Table to DataStream allow partial fields >

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
afedulov commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403659023 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
afedulov commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403659023 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
afedulov commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403656624 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-25421] Add JdbcSink with new format [flink-connector-jdbc]

2023-11-23 Thread via GitHub
eskabetxe commented on PR #2: URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1824762588 @wanglijie95 , @snuyanzin could you check please.. The sink in this moment allows non-xa (at least once) and xa (exactly once) connections I need to add

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
gyfora commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403619658 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
afedulov commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403615188 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
afedulov commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403615188 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
gyfora commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403612096 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
afedulov commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403603955 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2023-11-23 Thread via GitHub
afedulov commented on PR #23777: URL: https://github.com/apache/flink/pull/23777#issuecomment-1824713681 > We could then keep all the existing code and just wrap it. The execution model is fundamentally different - a while loop that runs directly in the function vs an async loop that

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2023-11-23 Thread via GitHub
afedulov commented on code in PR #23777: URL: https://github.com/apache/flink/pull/23777#discussion_r1403579962 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/source/SourceReaderWithCheckpointsLatch.java: ## @@ -0,0 +1,158 @@ +/* +

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2023-11-23 Thread via GitHub
afedulov commented on PR #23777: URL: https://github.com/apache/flink/pull/23777#issuecomment-1824683968 There are some things that can probably be done, but not in the scope of this PR. You can see how much complexity of the new Source API is already hidden behind the

[jira] [Commented] (FLINK-32513) Job in BATCH mode with a significant number of transformations freezes on method StreamGraphGenerator.existsUnboundedSource()

2023-11-23 Thread Vladislav Keda (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789203#comment-17789203 ] Vladislav Keda commented on FLINK-32513: Hi [~huwh]! I would like to ask if there are any news

Re: [PR] [FLINK-28048][connectors] Introduce Source API alternative to FiniteTestSource [flink]

2023-11-23 Thread via GitHub
mxm commented on code in PR #23777: URL: https://github.com/apache/flink/pull/23777#discussion_r1403558590 ## flink-connectors/flink-connector-datagen/src/main/java/org/apache/flink/connector/datagen/source/SourceReaderWithCheckpointsLatch.java: ## @@ -0,0 +1,158 @@ +/* + *

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
gyfora commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403543895 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
gyfora commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403540366 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (FLINK-33634) Add Conditions to Flink CRD's Status field

2023-11-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789178#comment-17789178 ] Gyula Fora commented on FLINK-33634: Could you please elaborate a bit on what exactly do you suggest

[jira] [Commented] (FLINK-33633) Automatic creation of RBAC for instances of Flink Deployments

2023-11-23 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789176#comment-17789176 ] Gyula Fora commented on FLINK-33633: I am not completely sure about this feature. It's generally an

Re: [PR] [FLINK-30593][autoscaler] Determine restart time on the fly fo Autoscaler [flink-kubernetes-operator]

2023-11-23 Thread via GitHub
gyfora commented on code in PR #711: URL: https://github.com/apache/flink-kubernetes-operator/pull/711#discussion_r1403521447 ## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/ScalingTracking.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

Re: [PR] [FLINK-27681] RocksdbStatebackend verify incremental sst file checksum during checkpoint [flink]

2023-11-23 Thread via GitHub
masteryhx commented on code in PR #23765: URL: https://github.com/apache/flink/pull/23765#discussion_r1403408187 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/snapshot/RocksNativeFullSnapshotStrategy.java: ## @@ -80,7

[jira] [Created] (FLINK-33634) Add Conditions to Flink CRD's Status field

2023-11-23 Thread Tony Garrard (Jira)
Tony Garrard created FLINK-33634: Summary: Add Conditions to Flink CRD's Status field Key: FLINK-33634 URL: https://issues.apache.org/jira/browse/FLINK-33634 Project: Flink Issue Type:

Re: [PR] [hotfix][docs] Remove reference to obsolete Collector and refer to yield instead [flink]

2023-11-23 Thread via GitHub
afedulov commented on PR #23776: URL: https://github.com/apache/flink/pull/23776#issuecomment-1824550622 cc @alpinegizmo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-33633) Automatic creation of RBAC for instances of Flink Deployments

2023-11-23 Thread Tony Garrard (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Garrard updated FLINK-33633: - Priority: Not a Priority (was: Major) > Automatic creation of RBAC for instances of Flink

[jira] [Created] (FLINK-33633) Automatic creation of RBAC for instances of Flink Deployments

2023-11-23 Thread Tony Garrard (Jira)
Tony Garrard created FLINK-33633: Summary: Automatic creation of RBAC for instances of Flink Deployments Key: FLINK-33633 URL: https://issues.apache.org/jira/browse/FLINK-33633 Project: Flink

[jira] [Created] (FLINK-33632) Add custom mutator plugin

2023-11-23 Thread Tony Garrard (Jira)
Tony Garrard created FLINK-33632: Summary: Add custom mutator plugin Key: FLINK-33632 URL: https://issues.apache.org/jira/browse/FLINK-33632 Project: Flink Issue Type: Improvement

[jira] [Commented] (FLINK-33630) CoordinationResponse should be wrapped by SerializedValue in TaskOperatorEventGateway and JobMasterOperatorEventGateway

2023-11-23 Thread Hang Ruan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789146#comment-17789146 ] Hang Ruan commented on FLINK-33630: --- Hi, all.  I would like to help to resolve this problem. Please

Re: [PR] [FLINK-30613] Improve resolving schema compatibility -- Milestone one [flink]

2023-11-23 Thread via GitHub
1996fanrui commented on code in PR #21635: URL: https://github.com/apache/flink/pull/21635#discussion_r1402925601 ## docs/content.zh/docs/dev/datastream/fault-tolerance/serialization/custom_serialization.md: ## @@ -442,4 +445,23 @@ migrate from the old abstractions. The steps

[jira] [Commented] (FLINK-33565) The concurrentExceptions doesn't work

2023-11-23 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789137#comment-17789137 ] Rui Fan commented on FLINK-33565: - Before creating this JIRA, I found that the concurrentExceptions

  1   2   >