Re: [PR] [FLINK-33651][Runtime][doc] update statue checkpoins doc in Chinese [flink]

2023-11-25 Thread via GitHub
flinkbot commented on PR #23807: URL: https://github.com/apache/flink/pull/23807#issuecomment-182574 ## CI report: * dabd8dd60ed2858e12bf2a5a0ca7315604a31092 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[jira] [Updated] (FLINK-33651) Update the Chinese version checkpointing doc in fault tolerance

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33651: --- Labels: pull-request-available (was: ) > Update the Chinese version checkpointing doc in

[PR] [FLINK-33651][Runtime][doc] update statue checkpoins doc in Chinese [flink]

2023-11-25 Thread via GitHub
JingGe opened a new pull request, #23807: URL: https://github.com/apache/flink/pull/23807 ## What is the purpose of the change update doc in Chinese for 1. checkpoint storage, 2. unaligned checkpoints, 3. checkpoints with finished tasks ## Does this pull request potentially

Re: [PR] [hotfix][Junit5 Migration] Upgrade the LocalInputPreferredSlotSharingStrategyTest to junit5 [flink]

2023-11-25 Thread via GitHub
flinkbot commented on PR #23806: URL: https://github.com/apache/flink/pull/23806#issuecomment-1826479484 ## CI report: * a667933a817ed3b12d6a414314e30a2098efac53 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][Junit5 Migration] Upgrade the LocalInputPreferredSlotSharingStrategyTest to junit5 [flink]

2023-11-25 Thread via GitHub
1996fanrui commented on PR #23806: URL: https://github.com/apache/flink/pull/23806#issuecomment-1826479226 cc @RocMarshal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-25 Thread via GitHub
1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405310873 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache

[PR] [test][Junit5 Migration] Upgrade the LocalInputPreferredSlotSharingStrategyTest to junit5 [flink]

2023-11-25 Thread via GitHub
1996fanrui opened a new pull request, #23806: URL: https://github.com/apache/flink/pull/23806 - [test][Junit5 Migration] Upgrade the LocalInputPreferredSlotSharingStrategyTest to junit5 In order to simply the review of https://github.com/apache/flink/pull/23635 , and reuse some

Re: [PR] [hotfix][doc] fix checkpoints link in checkpointing [flink]

2023-11-25 Thread via GitHub
JingGe merged PR #23795: URL: https://github.com/apache/flink/pull/23795 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][doc] fix checkpoints link in checkpointing [flink]

2023-11-25 Thread via GitHub
JingGe commented on PR #23795: URL: https://github.com/apache/flink/pull/23795#issuecomment-1826474695 Thanks @1996fanrui for the review. Ticket is created: https://issues.apache.org/jira/browse/FLINK-33651 -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (FLINK-33651) Update the Chinese version checkpointing doc in fault tolerance

2023-11-25 Thread Jing Ge (Jira)
Jing Ge created FLINK-33651: --- Summary: Update the Chinese version checkpointing doc in fault tolerance Key: FLINK-33651 URL: https://issues.apache.org/jira/browse/FLINK-33651 Project: Flink Issue

Re: [PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-25 Thread via GitHub
flinkbot commented on PR #23805: URL: https://github.com/apache/flink/pull/23805#issuecomment-1826474593 ## CI report: * cb036179d46abe0da3440617b8af78b9392d6e43 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][table][doc] add hint to suggest using UserDefinedFunction class over instance [flink]

2023-11-25 Thread via GitHub
JingGe opened a new pull request, #23805: URL: https://github.com/apache/flink/pull/23805 ## What is the purpose of the change add hint to suggest using UserDefinedFunction class over instance ## Does this pull request potentially affect one of the following parts: -

[jira] [Resolved] (FLINK-33650) Checkpoint Storage doc is missed

2023-11-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33650. - Fix Version/s: 1.19.0 Resolution: Fixed > Checkpoint Storage doc is missed >

[jira] [Commented] (FLINK-33650) Checkpoint Storage doc is missed

2023-11-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789751#comment-17789751 ] Rui Fan commented on FLINK-33650: - Merged master<1.19> via 09702a22e43fddfa1ac78e2b8db92c2d1f5395a6 >

Re: [PR] [FLINK-33650][doc] Add the Checkpoint Storage part for Chinese Checkpoint page [flink]

2023-11-25 Thread via GitHub
1996fanrui merged PR #23802: URL: https://github.com/apache/flink/pull/23802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33650][doc] Add the Checkpoint Storage part for Chinese Checkpoint page [flink]

2023-11-25 Thread via GitHub
1996fanrui commented on PR #23802: URL: https://github.com/apache/flink/pull/23802#issuecomment-1826467838 Thanks @JingGe for the review, merging~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
JingGe merged PR #23787: URL: https://github.com/apache/flink/pull/23787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-31339][tests] Fix unstable tests of flink-end-to-end-tests-sql module [flink]

2023-11-25 Thread via GitHub
ruanhang1993 commented on PR #23507: URL: https://github.com/apache/flink/pull/23507#issuecomment-1826461176 Hi, @Jiabao-Sun . If we drop the mini-batch setting, are there still some tests testing the mini-batch feature for these sqls? -- This is an automated message from the Apache

[jira] [Closed] (FLINK-33642) Use docker image with jdk21 in CI

2023-11-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin closed FLINK-33642. --- > Use docker image with jdk21 in CI > - > >

[jira] [Commented] (FLINK-33642) Use docker image with jdk21 in CI

2023-11-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789744#comment-17789744 ] Sergey Nuyanzin commented on FLINK-33642: - Merged to master as

[jira] [Resolved] (FLINK-33642) Use docker image with jdk21 in CI

2023-11-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33642?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33642. - Fix Version/s: 1.19.0 Resolution: Fixed > Use docker image with jdk21 in CI >

[jira] [Commented] (FLINK-33646) Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs

2023-11-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789743#comment-17789743 ] Sergey Nuyanzin commented on FLINK-33646: - Merged to master as

[jira] [Assigned] (FLINK-33646) Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs

2023-11-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin reassigned FLINK-33646: --- Assignee: Sergey Nuyanzin > Cleanup the rest usage of deprecated

[jira] [Resolved] (FLINK-33646) Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs

2023-11-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergey Nuyanzin resolved FLINK-33646. - Fix Version/s: 1.19.0 Resolution: Fixed > Cleanup the rest usage of deprecated

Re: [PR] [FLINK-33646][table] Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs [flink]

2023-11-25 Thread via GitHub
snuyanzin merged PR #23796: URL: https://github.com/apache/flink/pull/23796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33642] Use docker image with jdk21 in CI [flink]

2023-11-25 Thread via GitHub
snuyanzin merged PR #23793: URL: https://github.com/apache/flink/pull/23793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][docs] Remove reference to obsolete Collector and refer to yield instead [flink]

2023-11-25 Thread via GitHub
alpinegizmo merged PR #23776: URL: https://github.com/apache/flink/pull/23776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [hotfix][doc] fix spotless violation [flink]

2023-11-25 Thread via GitHub
JingGe merged PR #23803: URL: https://github.com/apache/flink/pull/23803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-31650][metrics][rest] Cleanup terminal subtask attempt metrics to avoid confusion caused by outdated metrics [flink]

2023-11-25 Thread via GitHub
X-czh commented on PR #23447: URL: https://github.com/apache/flink/pull/23447#issuecomment-1826376453 Hi @JunRuiLee. It's been a while, I've updated the PR to remove the transient metrics (idle/busy/backpressured time) for terminal subtasks only. Could you help take a review when you are

Re: [PR] [FLINK-33650][doc] Add the Checkpoint Storage part for Chinese Checkpoint page [flink]

2023-11-25 Thread via GitHub
JingGe commented on code in PR #23802: URL: https://github.com/apache/flink/pull/23802#discussion_r1405164768 ## docs/content/docs/ops/state/checkpoints.md: ## @@ -86,8 +86,6 @@ The `FileSystemCheckpointStorage` is encouraged for: - All high-availability setups. -It is

Re: [PR] [FLINK-33650][doc] Add the Checkpoint Storage part for Chinese Checkpoint page [flink]

2023-11-25 Thread via GitHub
JingGe commented on code in PR #23802: URL: https://github.com/apache/flink/pull/23802#discussion_r1405164768 ## docs/content/docs/ops/state/checkpoints.md: ## @@ -86,8 +86,6 @@ The `FileSystemCheckpointStorage` is encouraged for: - All high-availability setups. -It is

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
JingGe commented on code in PR #23787: URL: https://github.com/apache/flink/pull/23787#discussion_r1405163951 ## README.md: ## @@ -128,6 +128,22 @@ This is an active open-source project. We are always open to people who want to Contact us if you are looking for implementation

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
JingGe commented on PR #23787: URL: https://github.com/apache/flink/pull/23787#issuecomment-1826372153 Thanks @snuyanzin @1996fanrui for your review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [FLINK-30064] Move existing Hive connector code from Flink repo to dedicated Hive repo [flink-connector-hive]

2023-11-25 Thread via GitHub
snuyanzin commented on PR #5: URL: https://github.com/apache/flink-connector-hive/pull/5#issuecomment-1826369560 rebased since there were new commits in main flink master -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23787: URL: https://github.com/apache/flink/pull/23787#discussion_r1405151842 ## README.md: ## @@ -128,6 +128,22 @@ This is an active open-source project. We are always open to people who want to Contact us if you are looking for

Re: [PR] [hotfix][doc] fix checkpoints link in checkpointing [flink]

2023-11-25 Thread via GitHub
JingGe commented on code in PR #23795: URL: https://github.com/apache/flink/pull/23795#discussion_r1405147685 ## docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -70,7 +70,7 @@ Checkpoint 其他的属性包括: 该选项不能和 "checkpoints 间的最小时间"同时使用。 -

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
JingGe commented on code in PR #23787: URL: https://github.com/apache/flink/pull/23787#discussion_r1405142521 ## README.md: ## @@ -128,6 +128,22 @@ This is an active open-source project. We are always open to people who want to Contact us if you are looking for implementation

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23787: URL: https://github.com/apache/flink/pull/23787#discussion_r1405139838 ## README.md: ## @@ -128,6 +128,22 @@ This is an active open-source project. We are always open to people who want to Contact us if you are looking for

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23787: URL: https://github.com/apache/flink/pull/23787#discussion_r1405139838 ## README.md: ## @@ -128,6 +128,22 @@ This is an active open-source project. We are always open to people who want to Contact us if you are looking for

Re: [PR] [hotfix][optimizer] remove duplicated code [flink]

2023-11-25 Thread via GitHub
JingGe commented on PR #23801: URL: https://github.com/apache/flink/pull/23801#issuecomment-1826355681 @1996fanrui No worries. Thanks for the review. There is a follow-up PR for checkstyle fix: #23803 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33646][table] Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs [flink]

2023-11-25 Thread via GitHub
JingGe commented on code in PR #23796: URL: https://github.com/apache/flink/pull/23796#discussion_r1405136607 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/TableAggregateHarnessTest.scala: ## @@ -56,7 +56,7 @@ class

Re: [PR] [hotfix] Fix the checkstyle of OperatorDescriptorDual [flink]

2023-11-25 Thread via GitHub
1996fanrui closed pull request #23804: [hotfix] Fix the checkstyle of OperatorDescriptorDual URL: https://github.com/apache/flink/pull/23804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [hotfix] Fix the checkstyle of OperatorDescriptorDual [flink]

2023-11-25 Thread via GitHub
JingGe commented on PR #23804: URL: https://github.com/apache/flink/pull/23804#issuecomment-1826354450 @1996fanrui I just open a PR for it a few minutes ago. @snuyanzin thanks for the hint. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [hotfix] Fix the checkstyle of OperatorDescriptorDual [flink]

2023-11-25 Thread via GitHub
flinkbot commented on PR #23804: URL: https://github.com/apache/flink/pull/23804#issuecomment-1826354261 ## CI report: * 1c96326f88c8164c18687ad19ea0ee642cbdec28 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][doc] fix spotless violation [flink]

2023-11-25 Thread via GitHub
flinkbot commented on PR #23803: URL: https://github.com/apache/flink/pull/23803#issuecomment-1826354235 ## CI report: * 56d9cfccb47d731d346957bb3207fc651ef43a30 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
JingGe commented on code in PR #23787: URL: https://github.com/apache/flink/pull/23787#discussion_r1405135018 ## README.md: ## @@ -128,6 +128,23 @@ This is an active open-source project. We are always open to people who want to Contact us if you are looking for implementation

Re: [PR] [hotfix] Fix the checkstyle of OperatorDescriptorDual [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on PR #23804: URL: https://github.com/apache/flink/pull/23804#issuecomment-1826353748 it seems a dupicate of https://github.com/apache/flink/pull/23803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] [hotfix] Fix the checkstyle of OperatorDescriptorDual [flink]

2023-11-25 Thread via GitHub
1996fanrui opened a new pull request, #23804: URL: https://github.com/apache/flink/pull/23804 Fix the checkstyle of https://github.com/apache/flink/pull/23801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] [hotfix][optimizer] fix spotless violation [flink]

2023-11-25 Thread via GitHub
JingGe opened a new pull request, #23803: URL: https://github.com/apache/flink/pull/23803 ## What is the purpose of the change fix the spotless violation ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. GitHub PR

Re: [PR] [hotfix][optimizer] remove duplicated code [flink]

2023-11-25 Thread via GitHub
1996fanrui commented on PR #23801: URL: https://github.com/apache/flink/pull/23801#issuecomment-1826352850 Hey @JingGe , sorry I found the CI fails suddenly. And the checkstyle is broken. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] [hotfix][optimizer] remove duplicated code [flink]

2023-11-25 Thread via GitHub
JingGe merged PR #23801: URL: https://github.com/apache/flink/pull/23801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (FLINK-33608) UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData

2023-11-25 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu resolved FLINK-33608. Fix Version/s: 1.19.0 Resolution: Fixed Fixed in master(1.19):

[jira] [Assigned] (FLINK-33608) UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData

2023-11-25 Thread Leonard Xu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leonard Xu reassigned FLINK-33608: -- Assignee: Jiabao Sun > UpsertTestDynamicTableSink's keySerializationSchama should extract

Re: [PR] [FLINK-33608][test-utils] UpsertTestDynamicTableSink's keySerializationSchama should extract and serialize the primary key fields from RowData [flink]

2023-11-25 Thread via GitHub
leonardBang merged PR #23767: URL: https://github.com/apache/flink/pull/23767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-25 Thread via GitHub
RocMarshal commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1826330445 Hi, @KarmaGYZ @1996fanrui Thank you very much for your patient review comments. I updated it based on your comments. PTAL in your free time,Have a nice weekend~ -- This is an

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-25 Thread via GitHub
RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405028622 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-25 Thread via GitHub
RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405002911 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-25 Thread via GitHub
RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405002804 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-25 Thread via GitHub
RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405002722 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2023-11-25 Thread via GitHub
RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405002564 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33650][doc] Add the Checkpoint Storage part for Chinese Checkpoint page [flink]

2023-11-25 Thread via GitHub
flinkbot commented on PR #23802: URL: https://github.com/apache/flink/pull/23802#issuecomment-1826300287 ## CI report: * e5b86a3cca1aa50cc15ef4342c3f723391ba33c9 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33625][runtime] Support System out and err to be redirected to LOG or discarded [flink]

2023-11-25 Thread via GitHub
1996fanrui commented on code in PR #23800: URL: https://github.com/apache/flink/pull/23800#discussion_r1404873353 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -711,6 +711,61 @@ public class TaskManagerOptions {

[jira] [Updated] (FLINK-33650) Checkpoint Storage doc is missed

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33650: --- Labels: pull-request-available (was: ) > Checkpoint Storage doc is missed >

Re: [PR] [FLINK-33646][table] Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23796: URL: https://github.com/apache/flink/pull/23796#discussion_r1404868150 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/TableAggregateHarnessTest.scala: ## @@ -56,7 +56,7 @@ class

Re: [PR] [FLINK-33646][table] Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23796: URL: https://github.com/apache/flink/pull/23796#discussion_r1404868209 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/harness/TableAggregateHarnessTest.scala: ## @@ -161,7 +161,7 @@ class

Re: [PR] [FLINK-33625][runtime] Support System out and err to be redirected to LOG or discarded [flink]

2023-11-25 Thread via GitHub
1996fanrui commented on PR #23800: URL: https://github.com/apache/flink/pull/23800#issuecomment-1826293112 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (FLINK-33650) Checkpoint Storage doc is missed

2023-11-25 Thread Rui Fan (Jira)
Rui Fan created FLINK-33650: --- Summary: Checkpoint Storage doc is missed Key: FLINK-33650 URL: https://issues.apache.org/jira/browse/FLINK-33650 Project: Flink Issue Type: Technical Debt

[jira] [Resolved] (FLINK-33649) Exponential Delay doc is missed

2023-11-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan resolved FLINK-33649. - Resolution: Fixed > Exponential Delay doc is missed > --- > >

[jira] [Commented] (FLINK-33649) Exponential Delay doc is missed

2023-11-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789658#comment-17789658 ] Rui Fan commented on FLINK-33649: - Merged master<1.19> via bd9f312fe3518695afb0be86d0348a86daff0220 >

[jira] [Updated] (FLINK-33649) Exponential Delay doc is missed

2023-11-25 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan updated FLINK-33649: Fix Version/s: 1.19.0 > Exponential Delay doc is missed > --- > >

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23787: URL: https://github.com/apache/flink/pull/23787#discussion_r1404858557 ## README.md: ## @@ -128,6 +128,23 @@ This is an active open-source project. We are always open to people who want to Contact us if you are looking for

Re: [PR] [hotfix][doc] add repo links of externalized connectors [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23787: URL: https://github.com/apache/flink/pull/23787#discussion_r1404858557 ## README.md: ## @@ -128,6 +128,23 @@ This is an active open-source project. We are always open to people who want to Contact us if you are looking for

Re: [PR] [hotfix][doc] fix checkpoints link in checkpointing [flink]

2023-11-25 Thread via GitHub
1996fanrui commented on code in PR #23795: URL: https://github.com/apache/flink/pull/23795#discussion_r1404855432 ## docs/content.zh/docs/dev/datastream/fault-tolerance/checkpointing.md: ## @@ -70,7 +70,7 @@ Checkpoint 其他的属性包括: 该选项不能和 "checkpoints 间的最小时间"同时使用。 -

Re: [PR] [FLINK-33649][doc] Add the doc related to Exponential Delay [flink]

2023-11-25 Thread via GitHub
1996fanrui merged PR #23797: URL: https://github.com/apache/flink/pull/23797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33646][table] Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs [flink]

2023-11-25 Thread via GitHub
JingGe commented on code in PR #23796: URL: https://github.com/apache/flink/pull/23796#discussion_r1404850835 ## docs/content.zh/docs/dev/table/functions/udfs.md: ## @@ -1797,7 +1797,7 @@ public static class Top2 extends TableAggregateFunction // 注册函数

Re: [PR] [FLINK-33646][table] Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs [flink]

2023-11-25 Thread via GitHub
JingGe commented on code in PR #23796: URL: https://github.com/apache/flink/pull/23796#discussion_r1404850904 ## docs/content.zh/docs/dev/table/functions/udfs.md: ## @@ -1940,7 +1940,7 @@ public static class Top2 extends TableAggregateFunction // 注册函数

Re: [PR] [hotfix][optimizer] remove duplicated code [flink]

2023-11-25 Thread via GitHub
flinkbot commented on PR #23801: URL: https://github.com/apache/flink/pull/23801#issuecomment-1826283814 ## CI report: * 452d8ceddd08062a5f6497cad77dc1578e1e3378 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33625][runtime] Support System out and err to be redirected to LOG or discarded [flink]

2023-11-25 Thread via GitHub
flinkbot commented on PR #23800: URL: https://github.com/apache/flink/pull/23800#issuecomment-1826282849 ## CI report: * 6224393e91094385c24de9c0c36b310fa7176fbb UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

[PR] [hotfix][optimizer] remove duplicated code [flink]

2023-11-25 Thread via GitHub
JingGe opened a new pull request, #23801: URL: https://github.com/apache/flink/pull/23801 ## What is the purpose of the change remove duplicated code ## Verifying this change This change is already covered by existing tests, such as

[jira] [Updated] (FLINK-33625) FLIP-390: Support System out and err to be redirected to LOG or discarded

2023-11-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-33625: --- Labels: pull-request-available (was: ) > FLIP-390: Support System out and err to be

[PR] [FLINK-33625][runtime] Support System out and err to be redirected to LOG or discarded [flink]

2023-11-25 Thread via GitHub
1996fanrui opened a new pull request, #23800: URL: https://github.com/apache/flink/pull/23800 ## What is the purpose of the change Get more from https://cwiki.apache.org/confluence/x/4guZE ## Brief change log [FLINK-33625][runtime] Support System out and err to be

[jira] [Commented] (FLINK-33641) RankITCase.testMultipleUnaryTopNAfterAgg fails on AZP

2023-11-25 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789652#comment-17789652 ] Jiabao Sun commented on FLINK-33641: Thanks [~Sergey Nuyanzin] for your reminder, this problem may

Re: [PR] [FLINK-33646][table] Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23796: URL: https://github.com/apache/flink/pull/23796#discussion_r1404835126 ## docs/content.zh/docs/dev/table/functions/udfs.md: ## @@ -1282,7 +1282,7 @@ public static class WeightedAvg extends

Re: [PR] [FLINK-33646][table] Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23796: URL: https://github.com/apache/flink/pull/23796#discussion_r1404835126 ## docs/content.zh/docs/dev/table/functions/udfs.md: ## @@ -1282,7 +1282,7 @@ public static class WeightedAvg extends

Re: [PR] [FLINK-33646][table] Cleanup the rest usage of deprecated TableEnvironment#registerFunction and in docs [flink]

2023-11-25 Thread via GitHub
snuyanzin commented on code in PR #23796: URL: https://github.com/apache/flink/pull/23796#discussion_r1404835335 ## docs/content.zh/docs/dev/table/functions/udfs.md: ## @@ -1282,7 +1282,7 @@ public static class WeightedAvg extends AggregateFunction

[jira] [Comment Edited] (FLINK-33641) RankITCase.testMultipleUnaryTopNAfterAgg fails on AZP

2023-11-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789648#comment-17789648 ] Sergey Nuyanzin edited comment on FLINK-33641 at 11/25/23 9:56 AM: ---

[jira] [Comment Edited] (FLINK-33641) RankITCase.testMultipleUnaryTopNAfterAgg fails on AZP

2023-11-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789648#comment-17789648 ] Sergey Nuyanzin edited comment on FLINK-33641 at 11/25/23 9:55 AM: ---

[jira] [Commented] (FLINK-33641) RankITCase.testMultipleUnaryTopNAfterAgg fails on AZP

2023-11-25 Thread Sergey Nuyanzin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789648#comment-17789648 ] Sergey Nuyanzin commented on FLINK-33641: - couldn't it be the case that tempdir is shared

[jira] [Commented] (FLINK-33641) RankITCase.testMultipleUnaryTopNAfterAgg fails on AZP

2023-11-25 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789640#comment-17789640 ] Jiabao Sun commented on FLINK-33641: Seems TempDirectory#deleteAllFilesAndDirectories does not

[jira] [Commented] (FLINK-33641) RankITCase.testMultipleUnaryTopNAfterAgg fails on AZP

2023-11-25 Thread Jiabao Sun (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17789639#comment-17789639 ] Jiabao Sun commented on FLINK-33641:

[jira] [Updated] (FLINK-33641) RankITCase.testMultipleUnaryTopNAfterAgg fails on AZP

2023-11-25 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias Pohl updated FLINK-33641: -- Affects Version/s: 1.19.0 > RankITCase.testMultipleUnaryTopNAfterAgg fails on AZP >