[jira] [Assigned] (FLINK-34102) Invalid configuration when using 'env.log.max' on yarn application mode

2024-01-15 Thread Rui Fan (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rui Fan reassigned FLINK-34102: --- Assignee: RocMarshal > Invalid configuration when using 'env.log.max' on yarn application mode >

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
1996fanrui commented on code in PR #24042: URL: https://github.com/apache/flink/pull/24042#discussion_r1453038598 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -216,6 +229,24 @@ public YarnClusterDescriptor( this.nodeLabel =

Re: [PR] [revert][FLINK-33907][ci] Makes copying test jars being done in the package phase [flink]

2024-01-15 Thread via GitHub
XComp commented on PR #24095: URL: https://github.com/apache/flink/pull/24095#issuecomment-1893225487 I responded in the

[jira] [Commented] (FLINK-34106) user defined source parallelism in ddl can't work if connector ScanRuntimeProvider is SourceFunctionProvider

2024-01-15 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807088#comment-17807088 ] Zhanghao Chen commented on FLINK-34106: --- [~Akihito Liang] Are you refering to the new API

[jira] [Comment Edited] (FLINK-34106) user defined source parallelism in ddl can't work if connector ScanRuntimeProvider is SourceFunctionProvider

2024-01-15 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807088#comment-17807088 ] Zhanghao Chen edited comment on FLINK-34106 at 1/16/24 7:54 AM:

[jira] [Comment Edited] (FLINK-34106) user defined source parallelism in ddl can't work if connector ScanRuntimeProvider is SourceFunctionProvider

2024-01-15 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807088#comment-17807088 ] Zhanghao Chen edited comment on FLINK-34106 at 1/16/24 7:54 AM:

[jira] [Commented] (FLINK-33907) Makes copying test jars being done later

2024-01-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807087#comment-17807087 ] Matthias Pohl commented on FLINK-33907: --- I had a discussion with [~chesnay] on that issue. His

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
1996fanrui commented on code in PR #24042: URL: https://github.com/apache/flink/pull/24042#discussion_r1453038598 ## flink-yarn/src/main/java/org/apache/flink/yarn/YarnClusterDescriptor.java: ## @@ -216,6 +229,24 @@ public YarnClusterDescriptor( this.nodeLabel =

[jira] [Commented] (FLINK-34107) Clearer separation of unit test and integration tests

2024-01-15 Thread Matthias Pohl (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807081#comment-17807081 ] Matthias Pohl commented on FLINK-34107: --- One approach here could be to use the [failsafe

[jira] [Created] (FLINK-34107) Clearer separation of unit test and integration tests

2024-01-15 Thread Matthias Pohl (Jira)
Matthias Pohl created FLINK-34107: - Summary: Clearer separation of unit test and integration tests Key: FLINK-34107 URL: https://issues.apache.org/jira/browse/FLINK-34107 Project: Flink

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-15 Thread via GitHub
snuyanzin commented on code in PR #23411: URL: https://github.com/apache/flink/pull/23411#discussion_r1452991614 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-15 Thread via GitHub
snuyanzin commented on code in PR #23411: URL: https://github.com/apache/flink/pull/23411#discussion_r1452991614 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-15 Thread via GitHub
snuyanzin commented on code in PR #23411: URL: https://github.com/apache/flink/pull/23411#discussion_r1452991614 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33450][autoscaler] Support the JDBCAutoScalerStateStore [flink-kubernetes-operator]

2024-01-15 Thread via GitHub
1996fanrui commented on code in PR #741: URL: https://github.com/apache/flink-kubernetes-operator/pull/741#discussion_r1453006111 ## flink-autoscaler-plugin-jdbc/src/main/java/org/apache/flink/autoscaler/jdbc/state/JdbcAutoScalerStateStore.java: ## @@ -0,0 +1,286 @@ +/* + *

Re: [PR] [FLINK-33450][autoscaler] Support the JDBCAutoScalerStateStore [flink-kubernetes-operator]

2024-01-15 Thread via GitHub
1996fanrui commented on code in PR #741: URL: https://github.com/apache/flink-kubernetes-operator/pull/741#discussion_r1453004963 ## docs/content/docs/custom-resource/autoscaler.md: ## @@ -260,17 +260,46 @@ job.autoscaler.metrics.window : 3m > `ScalingReport` will show the

[jira] [Closed] (FLINK-33980) Reorganize job configuration

2024-01-15 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33980?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu closed FLINK-33980. --- Fix Version/s: 1.19.0 Resolution: Done master/release-1.19: 06b37089f0c1cdf70ca21970a40d15c3eaba07ed

Re: [PR] [FLINK-33980][core] Reorganize job configuration [flink]

2024-01-15 Thread via GitHub
zhuzhurk closed pull request #24025: [FLINK-33980][core] Reorganize job configuration URL: https://github.com/apache/flink/pull/24025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-15 Thread via GitHub
snuyanzin commented on code in PR #23411: URL: https://github.com/apache/flink/pull/23411#discussion_r1452991614 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the

[jira] [Resolved] (FLINK-33712) FLIP-391: Deprecate RuntimeContext#getExecutionConfig

2024-01-15 Thread Junrui Li (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Junrui Li resolved FLINK-33712. --- Fix Version/s: 1.19.0 Release Note: RuntimeContext#getExecutionConfig is now be deprecated in

[jira] [Commented] (FLINK-34106) user defined source parallelism in ddl can't work if connector ScanRuntimeProvider is SourceFunctionProvider

2024-01-15 Thread Junning Liang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807065#comment-17807065 ] Junning Liang commented on FLINK-34106: --- I have fixed the issue, please assign it to me~ > user

[jira] [Created] (FLINK-34106) user defined source parallelism in ddl can't work if connector ScanRuntimeProvider is SourceFunctionProvider

2024-01-15 Thread Junning Liang (Jira)
Junning Liang created FLINK-34106: - Summary: user defined source parallelism in ddl can't work if connector ScanRuntimeProvider is SourceFunctionProvider Key: FLINK-34106 URL:

Re: [PR] [FLINK-33803] Set observedGeneration at end of reconciliation [flink-kubernetes-operator]

2024-01-15 Thread via GitHub
gyfora commented on code in PR #755: URL: https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1452979030 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java: ## @@ -55,4 +55,7 @@ public

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-15 Thread via GitHub
Jiabao-Sun commented on PR #23411: URL: https://github.com/apache/flink/pull/23411#issuecomment-1893141857 Thanks @snuyanzin @dawidwys for the review. Could you help review it again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-15 Thread via GitHub
Jiabao-Sun commented on code in PR #23411: URL: https://github.com/apache/flink/pull/23411#discussion_r1452975551 ## flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/ArrayAggFunctionITCase.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2024-01-15 Thread via GitHub
lajith2006 commented on code in PR #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749#discussion_r1452972476 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/utils/ConditionUtils.java: ## @@ -0,0 +1,52 @@ +/* + *

[jira] [Commented] (FLINK-34088) fix the problems with special table name characters of postgres and oracle and sqlserver.

2024-01-15 Thread blackpighe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807062#comment-17807062 ] blackpighe commented on FLINK-34088: https://github.com/apache/flink-connector-jdbc/pull/89 > fix

Re: [PR] [hotfix] fix the problems with special table name characters of postgres and oracle  and sqlserver. [flink-connector-jdbc]

2024-01-15 Thread via GitHub
boring-cyborg[bot] commented on PR #89: URL: https://github.com/apache/flink-connector-jdbc/pull/89#issuecomment-1893138077 Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html) -- This is

[PR] [hotfix] fix the problems with special table name characters of postgres and oracle  and sqlserver. [flink-connector-jdbc]

2024-01-15 Thread via GitHub
BlackPigHe opened a new pull request, #89: URL: https://github.com/apache/flink-connector-jdbc/pull/89 [hotfix] fix the problems with special table name characters of postgres and oracle  and sqlserver. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2024-01-15 Thread via GitHub
lajith2006 commented on code in PR #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749#discussion_r1452972476 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/utils/ConditionUtils.java: ## @@ -0,0 +1,52 @@ +/* + *

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2024-01-15 Thread via GitHub
gyfora commented on code in PR #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749#discussion_r1452970570 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/CommonStatus.java: ## @@ -101,4 +108,67 @@ public

[jira] [Comment Edited] (FLINK-33973) Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API

2024-01-15 Thread Gyula Fora (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17805957#comment-17805957 ] Gyula Fora edited comment on FLINK-33973 at 1/16/24 6:18 AM: - Merged to

Re: [PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-15 Thread via GitHub
gyfora merged PR #24080: URL: https://github.com/apache/flink/pull/24080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [FLINK-33634] Add Conditions to Flink CRD's Status field [flink-kubernetes-operator]

2024-01-15 Thread via GitHub
lajith2006 commented on code in PR #749: URL: https://github.com/apache/flink-kubernetes-operator/pull/749#discussion_r1452966020 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/CommonStatus.java: ## @@ -101,4 +108,67 @@ public

[jira] [Updated] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-15 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-34105: Priority: Critical (was: Major) > Akka timeout happens in TPC-DS benchmarks >

[jira] [Comment Edited] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-15 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807052#comment-17807052 ] Zhu Zhu edited comment on FLINK-34105 at 1/16/24 6:06 AM: -- [~lsdy] [~guoyangze]

[jira] [Updated] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-15 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-34105: Description: We noticed akka timeout happens in 10TB TPC-DS benchmarks in 1.19. The problem did not

[jira] [Updated] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-15 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-34105: Description: We noticed akka timeout happens in 10TB TPC-DS benchmarks in 1.19. The problem did not

[jira] [Updated] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-15 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhu Zhu updated FLINK-34105: Description: We noticed akka timeout happens in 10TB TPC-DS benchmarks in 1.19. The problem did not

[PR] [FLINK-34104][autoscaler] Improve the ScalingReport format of autoscaling [flink-kubernetes-operator]

2024-01-15 Thread via GitHub
1996fanrui opened a new pull request, #757: URL: https://github.com/apache/flink-kubernetes-operator/pull/757 ## What is the purpose of the change Currently, the scaling report format is `Vertex ID %s | Parallelism %d -> %d | Processing capacity %.2f -> %.2f | Target data rate

[jira] [Commented] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-15 Thread Zhu Zhu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807052#comment-17807052 ] Zhu Zhu commented on FLINK-34105: - [~lsdy] [~guoyangze] would you help to take a look? > Akka timeout

[jira] [Updated] (FLINK-34104) Improve the ScalingReport format of autoscaling

2024-01-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-34104: --- Labels: pull-request-available (was: ) > Improve the ScalingReport format of autoscaling >

[jira] [Created] (FLINK-34105) Akka timeout happens in TPC-DS benchmarks

2024-01-15 Thread Zhu Zhu (Jira)
Zhu Zhu created FLINK-34105: --- Summary: Akka timeout happens in TPC-DS benchmarks Key: FLINK-34105 URL: https://issues.apache.org/jira/browse/FLINK-34105 Project: Flink Issue Type: Bug

Re: [PR] [FLINK-33973] Add new interfaces for SinkV2 to synchronize the API with the SourceV2 API [flink]

2024-01-15 Thread via GitHub
pvary commented on PR #24080: URL: https://github.com/apache/flink/pull/24080#issuecomment-1893114512 @gyfora: Please merge. We have a green test run. Thx -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Created] (FLINK-34104) Improve the ScalingReport format of autoscaling

2024-01-15 Thread Rui Fan (Jira)
Rui Fan created FLINK-34104: --- Summary: Improve the ScalingReport format of autoscaling Key: FLINK-34104 URL: https://issues.apache.org/jira/browse/FLINK-34104 Project: Flink Issue Type:

Re: [PR] [FLINK-34078][state]Move InternalKeyContext classes from o.a.f.runtim… [flink]

2024-01-15 Thread via GitHub
masteryhx closed pull request #24093: [FLINK-34078][state]Move InternalKeyContext classes from o.a.f.runtim… URL: https://github.com/apache/flink/pull/24093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (FLINK-34103) AsyncIO example failed to run as DataGen Connector is not bundled

2024-01-15 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-34103: -- External issue ID: (was: FLINK-32821) > AsyncIO example failed to run as DataGen Connector

[jira] [Updated] (FLINK-34103) AsyncIO example failed to run as DataGen Connector is not bundled

2024-01-15 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-34103: -- External issue ID: FLINK-32821 > AsyncIO example failed to run as DataGen Connector is not

[jira] [Commented] (FLINK-32821) Streaming examples failed to execute due to error in packaging

2024-01-15 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-32821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807047#comment-17807047 ] Zhanghao Chen commented on FLINK-32821: --- FYI [~qinjunjerry] , I've created [FLINK-34103] AsyncIO

[jira] [Updated] (FLINK-34103) AsyncIO example failed to run as DataGen Connector is not bundled

2024-01-15 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhanghao Chen updated FLINK-34103: -- Description: >From the comments of FLINK-32821: root@73186f600374:/opt/flink# bin/flink run

[jira] [Created] (FLINK-34103) AsyncIO example failed to run as DataGen Connector is not bundled

2024-01-15 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-34103: - Summary: AsyncIO example failed to run as DataGen Connector is not bundled Key: FLINK-34103 URL: https://issues.apache.org/jira/browse/FLINK-34103 Project: Flink

[jira] [Commented] (FLINK-34052) Missing TopSpeedWindowing and SessionWindowing JARs in Flink Maven Repository

2024-01-15 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807045#comment-17807045 ] Zhanghao Chen commented on FLINK-34052: --- Thanks for reporting this, I'll take a look. [~huweihua]

Re: [PR] [FLINK-33221][core][config] Add config options for administrator JVM options [flink]

2024-01-15 Thread via GitHub
X-czh commented on PR #24098: URL: https://github.com/apache/flink/pull/24098#issuecomment-1893096096 Hi @huwh @1996fanrui, do you have time to help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [FLINK-33803] Set observedGeneration at end of reconciliation [flink-kubernetes-operator]

2024-01-15 Thread via GitHub
justin-chen commented on code in PR #755: URL: https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1452942179 ## flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java: ## @@ -55,4 +55,7 @@

[jira] [Created] (FLINK-34102) Invalid configuration when using 'env.log.max' on yarn application mode

2024-01-15 Thread RocMarshal (Jira)
RocMarshal created FLINK-34102: -- Summary: Invalid configuration when using 'env.log.max' on yarn application mode Key: FLINK-34102 URL: https://issues.apache.org/jira/browse/FLINK-34102 Project: Flink

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
1996fanrui commented on PR #24042: URL: https://github.com/apache/flink/pull/24042#issuecomment-1893069359 > I made a fix like the env-value passing-in at https://github.com/RocMarshal/flink/commit/624c199e756ed5f04f849e8e53033bc1ef258f93 > Would we merge the additional fix into the

Re: [PR] [FLINK-33768] Support dynamic source parallelism inference for batch jobs [flink]

2024-01-15 Thread via GitHub
SinBex commented on PR #24087: URL: https://github.com/apache/flink/pull/24087#issuecomment-1893062734 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (FLINK-25054) Improve exception message for unsupported hashLength for SHA2 function

2024-01-15 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/FLINK-25054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated FLINK-25054: --- Labels: pull-request-available (was: ) > Improve exception message for unsupported

Re: [PR] [FLINK-25054][table-planner] Extend the exception message for SHA2 function [flink]

2024-01-15 Thread via GitHub
flinkbot commented on PR #24099: URL: https://github.com/apache/flink/pull/24099#issuecomment-1893037933 ## CI report: * 6525ba25342d12481b64e64fcc66ba6e57f0480f UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
RocMarshal commented on PR #24042: URL: https://github.com/apache/flink/pull/24042#issuecomment-1893035604 Thanks @X-czh for the double-check and @1996fanrui review. I made a fix like the env-value passing-in at

[PR] Extend the exception message for SHA2 function [flink]

2024-01-15 Thread via GitHub
xishuaidelin opened a new pull request, #24099: URL: https://github.com/apache/flink/pull/24099 ## What is the purpose of the change *This pull request extends the exception message for sha2 function.* ## Brief change log modify the function

Re: [PR] [FLINK-34087][tests][JUnit5 Migration] Migarate to junit5 of flink-dist module [flink]

2024-01-15 Thread via GitHub
Jiabao-Sun commented on PR #24092: URL: https://github.com/apache/flink/pull/24092#issuecomment-1893033205 @flinkbot run azure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Comment Edited] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-15 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807019#comment-17807019 ] Jufang He edited comment on FLINK-33856 at 1/16/24 3:51 AM: ok, I'll get to

[jira] [Commented] (FLINK-33856) Add metrics to monitor the interaction performance between task and external storage system in the process of checkpoint making

2024-01-15 Thread Jufang He (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807019#comment-17807019 ] Jufang He commented on FLINK-33856: --- ok, I'll get to work on it. > Add metrics to monitor the

[jira] [Comment Edited] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-15 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807017#comment-17807017 ] Zhenqiu Huang edited comment on FLINK-34007 at 1/16/24 3:40 AM:

[jira] [Commented] (FLINK-34101) use flink ui upload jar error, message is 'Exactly 1 file must be sent, received 0'

2024-01-15 Thread blackpighe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807018#comment-17807018 ] blackpighe commented on FLINK-34101:   !image-2024-01-16-11-37-26-343.png! this is copy curl

[jira] [Updated] (FLINK-34101) use flink ui upload jar error, message is 'Exactly 1 file must be sent, received 0'

2024-01-15 Thread blackpighe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] blackpighe updated FLINK-34101: --- Attachment: image-2024-01-16-11-37-26-343.png > use flink ui upload jar error, message is 'Exactly

[jira] [Created] (FLINK-34101) use flink ui upload jar error, message is 'Exactly 1 file must be sent, received 0'

2024-01-15 Thread blackpighe (Jira)
blackpighe created FLINK-34101: -- Summary: use flink ui upload jar error, message is 'Exactly 1 file must be sent, received 0' Key: FLINK-34101 URL: https://issues.apache.org/jira/browse/FLINK-34101

[jira] [Comment Edited] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-15 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807017#comment-17807017 ] Zhenqiu Huang edited comment on FLINK-34007 at 1/16/24 3:34 AM:

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-15 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807017#comment-17807017 ] Zhenqiu Huang commented on FLINK-34007: --- [~mapohl] I am intensively testing flink 1.18. Within two

Re: [PR] [FLINK-21949][table] Support ARRAY_AGG aggregate function [flink]

2024-01-15 Thread via GitHub
Jiabao-Sun commented on code in PR #23411: URL: https://github.com/apache/flink/pull/23411#discussion_r1452891261 ## flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/functions/bridging/BridgingSqlAggFunction.java: ## @@ -63,6 +64,7 @@ public final

[jira] [Updated] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-15 Thread Zhenqiu Huang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhenqiu Huang updated FLINK-34007: -- Attachment: LeaderElector-Debug.json > Flink Job stuck in suspend state after losing

[jira] [Updated] (FLINK-34100) Support session window table function without pulling up with window agg

2024-01-15 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34100: --- Description: This subtask resolves the session support in ExecWindowTableFunction. And then the session

[jira] [Updated] (FLINK-34048) Support session window agg in table runtime instead of using legacy group window agg op

2024-01-15 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34048: --- Description: We not only need FLINK-24024  to support session window agg in planner, but also need to

[jira] [Updated] (FLINK-34100) Support session window table function without pulling up with window agg

2024-01-15 Thread xuyang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34100?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] xuyang updated FLINK-34100: --- Description: This subtask resolves the session window agg with WindowAttachedWindowingStrategy. > Support

Re: [PR] [FLINK-34070][test] Adds dedicated tests in MiniClusterITCase for scenarios where there are not enough slots available. [flink]

2024-01-15 Thread via GitHub
jiangxin369 commented on code in PR #24082: URL: https://github.com/apache/flink/pull/24082#discussion_r1452878415 ## tools/azure-pipelines/build-apache-repo.yml: ## @@ -73,6 +73,17 @@ stages: run_end_to_end: false container: flink-build-container

[jira] [Created] (FLINK-34100) Support session window table function without pulling up with window agg

2024-01-15 Thread xuyang (Jira)
xuyang created FLINK-34100: -- Summary: Support session window table function without pulling up with window agg Key: FLINK-34100 URL: https://issues.apache.org/jira/browse/FLINK-34100 Project: Flink

Re: [PR] [FLINK-33988][configuration] Fix the invalid configuration when using initialized root logger level on yarn deployment mode [flink]

2024-01-15 Thread via GitHub
X-czh commented on PR #24042: URL: https://github.com/apache/flink/pull/24042#issuecomment-1892997269 Hi @1996fanrui, I've verified that the current release of Flink supports modifying the logger level in both Native K8s and Standalone mode. Since YARN prepares the container launching

[jira] [Commented] (FLINK-33988) Invalid configuration when using initialized root logger level on yarn application mode

2024-01-15 Thread Zhanghao Chen (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807014#comment-17807014 ] Zhanghao Chen commented on FLINK-33988: --- [~RocMarshal] Thanks for reporting this. You are right,

Re: [PR] [FLINK-33929][jdbc-connector] Support JDBC String field read Fragment read [flink-connector-jdbc]

2024-01-15 Thread via GitHub
zhilinli123 commented on PR #87: URL: https://github.com/apache/flink-connector-jdbc/pull/87#issuecomment-1892982217 > > @zhilinli123 I still don't understand the Jira ticket, so I can't really review it. Perhaps @snuyanzin or @eskabetxe understand the goal of this PR. > > For what

[jira] [Assigned] (FLINK-29802) ChangelogStateBackend supports native savepoint

2024-01-15 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-29802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu reassigned FLINK-29802: Assignee: Hangxiang Yu > ChangelogStateBackend supports native savepoint >

[jira] [Resolved] (FLINK-34078) Move InternalKeyContext classes from o.a.f.runtime.state.heap to o.a.f.runtime.state package

2024-01-15 Thread Hangxiang Yu (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hangxiang Yu resolved FLINK-34078. -- Fix Version/s: 1.19.0 Resolution: Fixed merged 6bdb4f75 into master > Move

Re: [PR] [FLINK-33689][table-runtime] Fix JsonObjectAggFunction can't retract records when enabling LocalGlobal. [flink]

2024-01-15 Thread via GitHub
xishuaidelin commented on code in PR #23827: URL: https://github.com/apache/flink/pull/23827#discussion_r1452864030 ## flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/AggregateITCase.scala: ## @@ -1916,4 +1916,44 @@ class

Re: [PR] [FLINK-33971]Specifies whether to use HBase table that supports dynamic columns. [flink-connector-hbase]

2024-01-15 Thread via GitHub
MOBIN-F commented on code in PR #36: URL: https://github.com/apache/flink-connector-hbase/pull/36#discussion_r1452863933 ## flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/sink/RowDataToMutationConverter.java: ## @@ -43,23 +43,26 @@ public class

Re: [PR] [FLINK-33689][table-runtime] Fix JsonObjectAggFunction can't retract records when enabling LocalGlobal. [flink]

2024-01-15 Thread via GitHub
xishuaidelin commented on code in PR #23827: URL: https://github.com/apache/flink/pull/23827#discussion_r1452862528 ## flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/aggregate/JsonObjectAggFunction.java: ## @@ -128,6 +137,15 @@ public

Re: [PR] [FLINK-33971]Specifies whether to use HBase table that supports dynamic columns. [flink-connector-hbase]

2024-01-15 Thread via GitHub
MOBIN-F commented on code in PR #36: URL: https://github.com/apache/flink-connector-hbase/pull/36#discussion_r1452862759 ## flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseSerde.java: ## Review Comment: I agree with this point of view.

[jira] [Created] (FLINK-34099) CheckpointIntervalDuringBacklogITCase.testNoCheckpointDuringBacklog is unstable on AZP

2024-01-15 Thread Yu Chen (Jira)
Yu Chen created FLINK-34099: --- Summary: CheckpointIntervalDuringBacklogITCase.testNoCheckpointDuringBacklog is unstable on AZP Key: FLINK-34099 URL: https://issues.apache.org/jira/browse/FLINK-34099

Re: [PR] [FLINK-33971]Specifies whether to use HBase table that supports dynamic columns. [flink-connector-hbase]

2024-01-15 Thread via GitHub
MOBIN-F commented on PR #36: URL: https://github.com/apache/flink-connector-hbase/pull/36#issuecomment-1892973838 > > the main question is that is it a good idea to introduce platform-specific features and flags to the IMO common upstream connector.主要问题是,将特定于平台的功能和标志引入 IMO

Re: [PR] [FLINK-29802][state] Changelog supports native savepoint [flink]

2024-01-15 Thread via GitHub
masteryhx commented on PR #22744: URL: https://github.com/apache/flink/pull/22744#issuecomment-1892973498 @rkhachatryan Could you help to take a review again ? cc @Zakelly You may also be interested in this. Since Changelog doesn't support NO_CLAIM mode yet, we could let the native

[jira] [Updated] (FLINK-33668) Decoupling Shuffle network memory and job topology

2024-01-15 Thread Jiang Xin (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiang Xin updated FLINK-33668: -- Description: With FLINK-30469  and FLINK-31643, we have decoupled the shuffle network memory and the

Re: [PR] [FLINK-34078][state]Move InternalKeyContext classes from o.a.f.runtim… [flink]

2024-01-15 Thread via GitHub
ljz2051 commented on PR #24093: URL: https://github.com/apache/flink/pull/24093#issuecomment-1892971770 @masteryhx Would you please help to review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (FLINK-34007) Flink Job stuck in suspend state after losing leadership in HA Mode

2024-01-15 Thread Yang Wang (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807009#comment-17807009 ] Yang Wang commented on FLINK-34007: --- {quote}At least based on the reports of this Jira issue, there

Re: [PR] [FLINK-34089] Verify that the subscribed topics match the assigned topics [flink-connector-kafka]

2024-01-15 Thread via GitHub
Tan-JiaLiang commented on PR #77: URL: https://github.com/apache/flink-connector-kafka/pull/77#issuecomment-1892967906 @tzulitai Hi gordon, can you take a look when you are free? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (FLINK-33950) Update max aggregate functions to new type system

2024-01-15 Thread Jacky Lau (Jira)
[ https://issues.apache.org/jira/browse/FLINK-33950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807008#comment-17807008 ] Jacky Lau commented on FLINK-33950: --- hi [~martijnvisser] [~Zakelly] [~dwysakowicz] , i found it will

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

2024-01-15 Thread via GitHub
KarmaGYZ commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1892964860 > @RocMarshal Just be curious about the progress, does this PR still wait for some comments to be addressed before it could be merged? This PR is in progress now. We plan to merge

Re: [PR] [FLINK-33819] support set CompressionType for RocksDBStateBackend [flink]

2024-01-15 Thread via GitHub
masteryhx commented on code in PR #24072: URL: https://github.com/apache/flink/pull/24072#discussion_r1452854496 ## flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBConfigurableOptions.java: ## @@ -139,6 +149,25 @@

[jira] [Commented] (FLINK-34098) Not enough Azure Pipeline CI runners available?

2024-01-15 Thread lincoln lee (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807004#comment-17807004 ] lincoln lee commented on FLINK-34098: - [~jingge] Can you help check it? > Not enough Azure Pipeline

Re: [PR] [FLINK-32659] Fix the connection leak due to exception [flink-connector-jdbc]

2024-01-15 Thread via GitHub
Aitozi closed pull request #71: [FLINK-32659] Fix the connection leak due to exception URL: https://github.com/apache/flink-connector-jdbc/pull/71 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (FLINK-34088) fix the problems with special table name characters of postgres and oracle and sqlserver.

2024-01-15 Thread blackpighe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807002#comment-17807002 ] blackpighe commented on FLINK-34088: This problem has persisted in other releases as well, but take

[jira] [Commented] (FLINK-34088) fix the problems with special table name characters of postgres and oracle and sqlserver.

2024-01-15 Thread blackpighe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807001#comment-17807001 ] blackpighe commented on FLINK-34088: i edit and update the issue, by use english > fix the problems

[jira] [Updated] (FLINK-34088) fix the problems with special table name characters of postgres and oracle and sqlserver.

2024-01-15 Thread blackpighe (Jira)
[ https://issues.apache.org/jira/browse/FLINK-34088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] blackpighe updated FLINK-34088: --- Fix Version/s: jdbc-3.1.1 Affects Version/s: jdbc-3.1.1 (was:

  1   2   3   4   >